---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35843/#review89311
---
On June 24, 2015, 7:57 p.m., Artem Harutyunyan wrote
!
- Artem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35843/#review89311
---
On June 24, 2015, 7:57 p.m., Artem Harutyunyan wrote
---
This is a documentation change.
Thanks,
Artem Harutyunyan
Description
---
Adding a link to example framework implementations (RENDLR)
Diffs
-
docs/app-framework-development-guide.md
020654a85fc12f1112ccdcdcec7fa4f2d52bf35f
Diff: https://reviews.apache.org/r/35622/diff/
Testing
---
This is a documentation change.
Thanks,
Artem
a typo
Diffs
-
Diff: https://reviews.apache.org/r/35625/diff/
Testing
---
Thanks,
Artem Harutyunyan
---
This is a documentation change.
Thanks,
Artem Harutyunyan
/diff/
Testing
---
This is a test case refactoring.
Thanks,
Artem Harutyunyan
as well as rake/middleman.
Reviewd all affected pages.
Thanks,
Artem Harutyunyan
On July 6, 2015, 1:53 p.m., Artem Harutyunyan wrote:
Ship It!
Thanks for taking care of this!
- Artem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36189/#review90558
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36189/#review90558
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 6, 2015, 8:29 a.m
://reviews.apache.org/r/36024/diff/
Testing
---
# This is a test case refactoring.
$ make check
Thanks,
Artem Harutyunyan
/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392
Diff: https://reviews.apache.org/r/36024/diff/
Testing
---
# This is a test case refactoring.
$ make check
Thanks,
Artem Harutyunyan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35755/#review90423
---
On July 6, 2015, 9:03 a.m., Artem Harutyunyan wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36245/#review90650
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 6, 2015, 10:16
: https://reviews.apache.org/r/35755/diff/
Testing
---
- make check
- added a test case for fetcher
Thanks,
Artem Harutyunyan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36267/#review90761
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 7, 2015, 10:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37011/#review93832
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 31, 2015, 7:10
, 2015, 8:26 p.m., Artem Harutyunyan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/
---
(Updated Aug. 5, 2015, 8:26 p.m
ae10c420f7dddb8650377c91b5343591e8560392
Diff: https://reviews.apache.org/r/35755/diff/
Testing
---
- make check
- added a test case for fetcher
Thanks,
Artem Harutyunyan
://reviews.apache.org/r/36024/diff/
Testing
---
# This is a test case refactoring.
$ make check
Thanks,
Artem Harutyunyan
:00 harutyunyan-virtual-machine kernel: [17440.052577] Killed
process 76599 (lt-memory-test-) total-vm:329808kB, anon-rss:67988kB,
file-rss:59076kB
```
Thanks,
Artem Harutyunyan
22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052577] Killed
process 76599 (lt-memory-test-) total-vm:329808kB, anon-rss:67988kB,
file-rss:59076kB
```
Thanks,
Artem Harutyunyan
the
change.
- Artem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36627/#review93849
---
On July 29, 2015, 4:14 p.m., Artem Harutyunyan wrote
check
Thanks,
Artem Harutyunyan
generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94001
---
On Aug. 3, 2015, 11:32 p.m., Artem Harutyunyan wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93704
---
On July 31, 2015, 8:23 a.m., Artem Harutyunyan wrote
/thread_local.hpp (line 25)
https://reviews.apache.org/r/36845/#comment147675
Also, by default TLS for a lot of people is Transport Layer Security. So
this name will likely cause some brain cycle waste every now and then.
- Artem Harutyunyan
On July 27, 2015, 2:05 p.m., Joris Van Remoortere wrote
(it's a
test case after all), or at least would add a comment that clarifies the
intention.
src/tests/containerizer/port_mapping_tests.cpp (line 986)
https://reviews.apache.org/r/36979/#comment148721
ditto.
+ extra newline.
- Artem Harutyunyan
On Aug. 4, 2015, 5:55 p.m., Marco
4a6e18a17012994d358099ad32d4c282fea3b0b1
3rdparty/libprocess/src/tests/io_tests.cpp
c642bab9e2845668767ad237985cb9ce1109
Diff: https://reviews.apache.org/r/36404/diff/
Testing
---
- Added a test case for process::io::peek
- make check
Thanks,
Artem Harutyunyan
4a6e18a17012994d358099ad32d4c282fea3b0b1
3rdparty/libprocess/src/tests/io_tests.cpp
c642bab9e2845668767ad237985cb9ce1109
Diff: https://reviews.apache.org/r/36404/diff/
Testing
---
- Added a test case for process::io::peek
- make check
Thanks,
Artem Harutyunyan
/
Testing
---
GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
Thanks,
Artem Harutyunyan
child
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052577] Killed
process 76599 (lt-memory-test-) total-vm:329808kB, anon-rss:67988kB,
file-rss:59076kB
```
Thanks,
Artem Harutyunyan
July 27, 2015, 2:15 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael
Park.
Bugs: MESOS-3119
https://issues.apache.org/jira/browse/MESOS-3119
Repository: mesos
Description
---
See summary.
Diffs
-
3rdparty/libprocess
src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255
src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702
Diff: https://reviews.apache.org/r/37190/diff/
Testing
---
Manual testing of the endpoint.
Thanks,
Artem Harutyunyan
Description
---
Here is the paper that describes how Mesos is used
http://arxiv.org/pdf/1507.07429.pdf .
Diffs
-
docs/powered-by-mesos.md 574d1c036f26a856671564673dd04532413dacc3
Diff: https://reviews.apache.org/r/37340/diff/
Testing
---
Thanks,
Artem Harutyunyan
5e40b747f4266e7532baf8fd02ea5db0955124d2
Diff: https://reviews.apache.org/r/37065/diff/
Testing
---
make check
Thanks,
Artem Harutyunyan
.
Thanks,
Artem Harutyunyan
::io::peek
- make check
Thanks,
Artem Harutyunyan
if (mlockall(MCL_FUTURE) != 0)
#endif
{
return ErrnoError(Failed to make pages to be mapped unevictable);
}
```
Artem Harutyunyan wrote:
The mlockall(MCL_FUTURE) has to be called before the memory allocation is
made (because it affects future allocations
Diff: https://reviews.apache.org/r/37065/diff/
Testing
---
make check
Thanks,
Artem Harutyunyan
On Aug. 4, 2015, 7:54 p.m., Artem Harutyunyan wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp, line 50
https://reviews.apache.org/r/36978/diff/1/?file=1026032#file1026032line50
should the variable be called `_cmd`?
Marco Massenzio wrote:
note
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94394
---
On Aug. 6, 2015, 10:34 a.m., Artem Harutyunyan wrote
Diff: https://reviews.apache.org/r/37065/diff/
Testing
---
make check
Thanks,
Artem Harutyunyan
-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94376
---
On Aug. 6, 2015, 10:34 a.m., Artem Harutyunyan wrote:
---
This is an automatically generated e-mail
testing of the endpoint.
Thanks,
Artem Harutyunyan
d699e4bc3cf734a516a6baf329919e04744b5702
Diff: https://reviews.apache.org/r/37190/diff/
Testing
---
Manual testing of the endpoint.
Thanks,
Artem Harutyunyan
+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
make check
Thanks,
Artem Harutyunyan
/r/37018/#review94653
---
On Aug. 9, 2015, 3:16 p.m., Artem Harutyunyan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37018
\s+\S+\s+(' .`
make check
Thanks,
Artem Harutyunyan
b4253e86c0e597a737e83a9660d29ea9748bf285
src/zookeeper/zookeeper.hpp 6d21ed8aba85de1ad1302581fddbc09d22ebe54b
Diff: https://reviews.apache.org/r/37013/diff/
Testing
---
`egrep -nr 'operator\s+\S+(|operator\S+\s+(|operator\s+\S+\s+(' .`
make check
Thanks,
Artem Harutyunyan
On Aug. 4, 2015, 9:16 p.m., Artem Harutyunyan wrote:
src/tests/containerizer/port_mapping_tests.cpp, line 986
https://reviews.apache.org/r/36979/diff/1/?file=1026038#file1026038line986
ditto.
+ extra newline.
Marco Massenzio wrote:
Having looked at both tests, I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93124
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 27, 2015, 12:19
micro nit #2: either s/required/require/, or point to where the
requirement was made.
- Artem Harutyunyan
On July 27, 2015, 2:05 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36629/#review92816
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 22, 2015, 12:07
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36672/#review92817
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 21, 2015, 9:07
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36715/#review92864
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 23, 2015, 12:49
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36674/#review92815
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 21, 2015, 10:56
will always be included before this header?
3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp (line 32)
https://reviews.apache.org/r/36829/#comment147338
Ditto about stdlib.h.
- Artem Harutyunyan
On July 26, 2015, 2 p.m., Joris Van Remoortere wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36825/#review93082
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 26, 2015, 12:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36824/#review93083
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 26, 2015, 12:02
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36820/#review93085
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 26, 2015, 9:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36826/#review93081
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 26, 2015, 12:19
(line 97)
https://reviews.apache.org/r/36828/#comment147342
const?
- Artem Harutyunyan
On July 26, 2015, 1:04 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
)
https://reviews.apache.org/r/36823/#comment147343
const?
- Artem Harutyunyan
On July 26, 2015, 12:02 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36823
3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1
3rdparty/libprocess/src/tests/io_tests.cpp
c642bab9e2845668767ad237985cb9ce1109
Diff: https://reviews.apache.org/r/36404/diff/
Testing
---
- Added a test case for process::io::peek
- make check
Thanks,
Artem
://reviews.apache.org/r/36673/#comment146747
Is this todo still valid?
- Artem Harutyunyan
On July 21, 2015, 9:07 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/#review92553
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 21, 2015, 10:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36741/#review92930
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 23, 2015, 4:40
:67988kB,
file-rss:59076kB
```
Thanks,
Artem Harutyunyan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36658/#review92490
---
Ship it!
Rendered affected files, everything looks good.
- Artem
/protocols/
3rdparty/libprocess/src/tests/ssl_tests.cpp (line 807)
https://reviews.apache.org/r/36656/#comment146700
ditto.
3rdparty/libprocess/src/tests/ssl_tests.cpp (line 865)
https://reviews.apache.org/r/36656/#comment146701
ditto.
- Artem Harutyunyan
On July 21, 2015, 3:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36627/#review92862
---
On July 24, 2015, 5:32 p.m., Artem Harutyunyan wrote
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052577] Killed
process 76599 (lt-memory-test-) total-vm:329808kB, anon-rss:67988kB,
file-rss:59076kB
```
Thanks,
Artem Harutyunyan
14 or
sacrifice child
Jul 22 14:56:00 harutyunyan-virtual-machine kernel: [17440.052577] Killed
process 76599 (lt-memory-test-) total-vm:329808kB, anon-rss:67988kB,
file-rss:59076kB
```
Thanks,
Artem Harutyunyan
On July 15, 2015, 12:36 a.m., Artem Harutyunyan wrote:
src/slave/slave.cpp, line 4755
https://reviews.apache.org/r/36389/diff/4/?file=1011886#file1011886line4755
Shouldn't there be an equivalent of an assert here if we never expect
this to happen? Something like
the result becomes ready right
at the 15th second (in a separate thread) and by the time this lambda is
executed the response becomes actually (and legitimately) ready.
- Artem Harutyunyan
On July 14, 2015, 4:20 p.m., Marco Massenzio wrote
On July 13, 2015, 5:20 p.m., Paul Brett wrote:
a drive by comment suggested by Joris is inline really necessary here?
On July 13, 2015, 5:20 p.m., Paul Brett wrote:
3rdparty/libprocess/include/process/subprocess.hpp, line 307
of the firm opinion that this feature should come with a
whitelisting mechanism that will allow operators to whitelist (benign) commands
that they want to execute, and forbid anything else.
- Artem Harutyunyan
On July 14, 2015, 4:20 p.m., Marco Massenzio wrote
://issues.apache.org/jira/browse/MESOS-3079
Repository: mesos
Description
---
See summary.
Diffs
-
src/tests/cgroups_tests.cpp 9f5028f831a5a2fd4f7f0a0b7459c184ea9598fb
Diff: https://reviews.apache.org/r/36618/diff/
Testing
---
sudo make check
Thanks,
Artem Harutyunyan
visit:
https://reviews.apache.org/r/39604/#review103823
-------
On Oct. 23, 2015, 11:50 a.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generat
/
Testing
---
- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
Thanks,
Artem Harutyunyan
reply, visit:
https://reviews.apache.org/r/39604/#review104064
-------
On Oct. 23, 2015, 4:48 p.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-ma
://reviews.apache.org/r/38705/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
: https://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
.apache.org/r/38883/#review104106
---
On Oct. 28, 2015, 3:01 p.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
200>
s/guarantee/a guarantee/
It'd be great to expand this comment a bit and describe what the gurantee
represents.
- Artem Harutyunyan
On Oct. 23, 2015, 9:38 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an au
/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem Harutyunyan
(updated)
-
support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
support/apply-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39420/diff/
Testing
---
Tested with python 2.7.
- with and without '-p'.
- Tested reviews with and without parents.
Thanks,
Artem
t; > Python being able to use single and double quotes interchangeably (or even
> > use """ if you really want to be hip :)
>
> Artem Harutyunyan wrote:
> I actually do need to escape the quotes becasue {message} is multiline
> and I am executing the `cmd` in a
://reviews.apache.org/r/38883/diff/
Testing
---
Tested the script with python 2.7.
Thanks,
Artem Harutyunyan
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103729
---
On Oct. 22, 2015, 11:58 p.m., Artem Harutyunyan wrote:
>
> --
> On Oct. 19, 2015, 10:06 p.m., Marco Massenzio wrote:
> > support/apply-reviews.py, lines 277-282
> > <https://reviews.apache.org/r/39410/diff/3/?file=1100642#file1100642line277>
> >
> > this code look familiar and I remember already commenting about
> &
To reply, visit:
https://reviews.apache.org/r/38705/#review103656
-------
On Oct. 22, 2015, 11:16 p.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38705/
&
d1fc5a460e7313828014eea999cf4e63dde01921
Diff: https://reviews.apache.org/r/39604/diff/
Testing
---
- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
Thanks,
Artem Harutyunyan
sets the value of the missing option to `None`.
- Artem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review103731
---------
-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/39410/diff/
Testing
---
Tested with python 2.7
Thanks,
Artem Harutyunyan
/mesos/containerizer.cpp
d1fc5a460e7313828014eea999cf4e63dde01921
Diff: https://reviews.apache.org/r/39604/diff/
Testing
---
- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
Thanks,
Artem
,
Artem Harutyunyan
1 - 100 of 334 matches
Mail list logo
