Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

2015-11-27 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/#review108240 --- Ship it! Ship It! - Avinash sridharan On Nov. 27, 2015, 1:44

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
ttps://reviews.apache.org/r/40731/#review108696 --- On Dec. 2, 2015, 8:27 a.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
e7f14079e766ce0a8bad2da646776347e4a17169 Diff: https://reviews.apache.org/r/40731/diff/ Testing --- Ran make check after adding Mandeep's test case to the GTEST framework. Thanks, Avinash sridharan

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108313 --- On Dec. 2, 2015, 8:27 a.m., Avinash sridharan wrote: > > --

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
insert an additional line here. We leave 2 lines > > after each global function/test. ok - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108704 ---

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169 Diff: https://reviews.apache.org/r/40731/diff/ Testing --- Ran make check after adding Mandeep's test case to the GTEST framework. Thanks, Avinash sridharan

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-08 Thread Avinash sridharan
; > EXPECT_CALL(sched, resourceOffers(, _)) > > .WillOnce(FutureArg<1>()); > > Avinash sridharan wrote: > Was following this particular style guide: > http://mesos.apache.org/documentation/latest/c++-style-guide/ > > The "Function Definition/Invocation&

Re: Review Request 40903: Ported approximated Option CPU resource number comparison to v1 and improved the check expression for this.

2015-12-09 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40903/#review109537 --- Ship it! Ship It! - Avinash sridharan On Dec. 3, 2015, 11:09

Re: Review Request 40732: Enabling ResourcesTest.Precision

2015-12-07 Thread Avinash sridharan
.apache.org/r/40732/#review108141 --- On Nov. 26, 2015, 6:52 a.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 40732: Enabling ResourcesTest.Precision

2015-12-07 Thread Avinash sridharan
e the change to EXPECT_DOUBLE_EQ - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40732/#review108150 ------- On Nov.

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-09 Thread Avinash sridharan
protobuf messages. Thanks, Avinash sridharan

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-09 Thread Avinash sridharan
src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 src/slave/http.cpp cef568d77da430b96e8f97487a8d0406dc0a0116 Diff: https://reviews.apache.org/r/41188/diff/ Testing (updated) --- make check Thanks, Avinash sridharan

Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-09 Thread Avinash sridharan
: https://reviews.apache.org/r/41187/diff/ Testing --- make check Thanks, Avinash sridharan

Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-09 Thread Avinash sridharan
5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 src/slave/http.cpp cef568d77da430b96e8f97487a8d0406dc0a0116 Diff: https://reviews.apache.org/r/41188/diff/ Testing --- Thanks, Avinash sridharan

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-15 Thread Avinash sridharan
ttps://reviews.apache.org/r/41188/diff/4/?file=1163918#file1163918line2190> > > > > How about: > > > > ``` > > Port *port1 = ports.add_ports(); > > port1->set_number(80); > > port1->mutable_labels()->CopyFrom

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-15 Thread Avinash sridharan
/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41187/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-15 Thread Avinash sridharan
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-15 Thread Avinash sridharan
in state.json in slave. Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects. Thanks, Avinash sridharan

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-15 Thread Avinash sridharan
.apache.org/r/41187/#review110358 --- On Dec. 14, 2015, 11:34 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41187/ > -

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-16 Thread Avinash sridharan
xposed > > via `/state` endpoint also have a nested `labels` mapping ? > > > > AFAICT, this is an artifact of us using the Protobuf to JSON converters > > when we should have just used the `model(...)` functions. > > Avinash sridharan wrote: > I a

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-16 Thread Avinash sridharan
: https://reviews.apache.org/r/41381/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-16 Thread Avinash sridharan
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-16 Thread Avinash sridharan
/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41187/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-16 Thread Avinash sridharan
in state.json in slave. Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects. Thanks, Avinash sridharan

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-16 Thread Avinash sridharan
/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41187/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-17 Thread Avinash sridharan
/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-17 Thread Avinash sridharan
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review110922 --- On Dec. 17, 2015, 9:33 a.m., Avinash sridharan wrote: > > ---

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-14 Thread Avinash sridharan
of DiscoveryInfo in state.json in slave. Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects. Thanks, Avinash sridharan

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-14 Thread Avinash sridharan
/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41187/diff/ Testing --- make check Thanks, Avinash sridharan

Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-14 Thread Avinash sridharan
/ Testing --- make check Thanks, Avinash sridharan

Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-14 Thread Avinash sridharan
8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-11 Thread Avinash sridharan
in state.json in slave. Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects. Thanks, Avinash sridharan

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-11 Thread Avinash sridharan
in slave. Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects. Thanks, Avinash sridharan

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-11 Thread Avinash sridharan
ert protobuf to JSON. - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review109684 --- On Dec. 12, 2015, 7

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-17 Thread Avinash sridharan
an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/#review110940 --- On Dec. 17, 2015, 3:32 a.m., Avinash sridharan wrote: > > --- > This is a

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-17 Thread Avinash sridharan
://reviews.apache.org/r/41188/diff/ Testing --- make check. Added Unit tests to verify setting of DiscoveryInfo in state.json in slave. Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects. Thanks, Avinash sridharan

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-17 Thread Avinash sridharan
/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41187/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-17 Thread Avinash sridharan
xposed > > via `/state` endpoint also have a nested `labels` mapping ? > > > > AFAICT, this is an artifact of us using the Protobuf to JSON converters > > when we should have just used the `model(...)` functions. > > Avinash sridharan wrote: > I a

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-17 Thread Avinash sridharan
of DiscoveryInfo in state.json in slave. Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects. Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-17 Thread Avinash sridharan
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-17 Thread Avinash sridharan
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review110927 ------- On Dec. 17, 2015, 10:40 p.m., Avinash sridharan wrote: > > --- > This is

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-17 Thread Avinash sridharan
: https://reviews.apache.org/r/41381/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-17 Thread Avinash sridharan
t: https://reviews.apache.org/r/41381/#review110940 ------- On Dec. 17, 2015, 10:43 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-17 Thread Avinash sridharan
: https://reviews.apache.org/r/41381/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-15 Thread Avinash sridharan
in state.json in slave. Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects. Thanks, Avinash sridharan

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-15 Thread Avinash sridharan
/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41187/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-15 Thread Avinash sridharan
eviews.apache.org/r/41187/#review110472 --- On Dec. 15, 2015, 10:11 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-15 Thread Avinash sridharan
: https://reviews.apache.org/r/41381/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-15 Thread Avinash sridharan
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-15 Thread Avinash sridharan
src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 Diff: https://reviews.apache.org/r/41381/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-15 Thread Avinash sridharan
e to follow. Going to move the comments per field. - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/#review110576 --------

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-15 Thread Avinash sridharan
: https://reviews.apache.org/r/41381/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-15 Thread Avinash sridharan
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

2015-12-14 Thread Avinash sridharan
/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 Diff: https://reviews.apache.org/r/41187/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-29 Thread Avinash sridharan
: https://reviews.apache.org/r/41381/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 42048: Defined of the CgroupNetClsIsolatorProcess.

2016-01-09 Thread Avinash sridharan
/cgroups/net_cls.cpp PRE-CREATION Diff: https://reviews.apache.org/r/42048/diff/ Testing --- make check . Added a test case for CgroupNetClsIsolatorProcess. Thanks, Avinash sridharan

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to isolate a mesos container using the net_cls cgroup subsystem.

2016-01-09 Thread Avinash sridharan
/ Testing --- Thanks, Avinash sridharan

Review Request 42097: Added cgroup/net_cls to the mesos containerizer isolation flags.

2016-01-09 Thread Avinash sridharan
the CgroupsNetClsIsoaltorProcess is created. Have added unit-test cases to test the create, prepare and destroy methods of CgroupsNetClsIsolatorProcess. Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-22 Thread Avinash sridharan
: https://reviews.apache.org/r/41381/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan
/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan
/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-22 Thread Avinash sridharan
: https://reviews.apache.org/r/41381/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan
al IP address. Why not use the > existing `Address` message and just add the following to `DiscoveryInfo`: > > `repeated Address vips;` > > Avinash sridharan wrote: > This is the Address message :message Address { > // May contain a hostname, IP addre

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-22 Thread Avinash sridharan
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-19 Thread Avinash sridharan
don't think will make sense to use it in this context ? - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111369 ---------

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-19 Thread Avinash sridharan
al IP address. Why not use the > existing `Address` message and just add the following to `DiscoveryInfo`: > > `repeated Address vips;` > > Avinash sridharan wrote: > This is the Address message :message Address { > // May contain a hostname, IP addre

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-19 Thread Avinash sridharan
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-19 Thread Avinash sridharan
: https://reviews.apache.org/r/41381/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-19 Thread Avinash sridharan
eady have an `ACL` (and `ACLs`). Oh oh should have been more stubborn sticking with Vip !! I thought VIp is also conforming to the coding style. Will go with Vip - Avinash --- This is an automatically generated e-mail. To reply, visit: https://r

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-18 Thread Avinash sridharan
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-18 Thread Avinash sridharan
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-28 Thread Avinash sridharan
utomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111848 --- On Dec. 23, 2015, 3 a.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-28 Thread Avinash sridharan
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 Diff: https://reviews.apache.org/r/41380/diff/ Testing --- make check, and make Thanks, Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-19 Thread Avinash sridharan
-mail. To reply, visit: https://reviews.apache.org/r/41381/#review111362 ----------- On Dec. 19, 2015, 7:58 a.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41381/

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-18 Thread Avinash sridharan
: https://reviews.apache.org/r/41381/diff/ Testing --- make check Thanks, Avinash sridharan

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-19 Thread Avinash sridharan
fs > - > > src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 > src/tests/slave_tests.cpp 109d31c8661c6b91243852e7ee00ce9fa1effe4b > > Diff: https://reviews.apache.org/r/41381/diff/ > > > Testing > --- > > make check > > > Thanks, > > Avinash sridharan > >

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

2015-12-17 Thread Avinash sridharan
in state.json in slave. Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo protobuf is converted to JSON objects. Thanks, Avinash sridharan

Review Request 41189: Adding wild cards to ignore csope and VIM files

2015-12-17 Thread Avinash sridharan
cards to ignore csope and VIM files Diffs - Diff: https://reviews.apache.org/r/41189/diff/ Testing --- Thanks, Avinash sridharan

Review Request 40732: Enabling ResourcesTest.Precision

2015-11-25 Thread Avinash sridharan
of EXPECT_EQ (strict equality) Diffs - src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 Diff: https://reviews.apache.org/r/40732/diff/ Testing --- Ran make check against 40730 Thanks, Avinash sridharan

Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

2015-11-25 Thread Avinash sridharan
/) to test this fix. Thanks, Avinash sridharan

Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-11-25 Thread Avinash sridharan
://reviews.apache.org/r/40731/diff/ Testing --- Ran make check after adding Mandeep's test case to the GTEST framework. Thanks, Avinash sridharan

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-11-30 Thread Avinash sridharan
- src/tests/reservation_tests.cpp 15d180f92ec0aea99e6f3a7d0b505c62bd207b61 Diff: https://reviews.apache.org/r/40731/diff/ Testing --- Ran make check after adding Mandeep's test case to the GTEST framework. Thanks, Avinash sridharan

Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

2016-01-12 Thread Avinash sridharan
Wu. Repository: mesos Description --- Added unit test-case for CgroupsNetClsIsolatorProcess. Diffs (updated) - src/tests/containerizer/isolator_tests.cpp 91178b69ccbf5b6cbf64421e5602e6d554fc34ca Diff: https://reviews.apache.org/r/42098/diff/ Testing --- Thanks, Avinash

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to isolate a mesos container using the net_cls cgroup subsystem.

2016-01-11 Thread Avinash sridharan
--- Thanks, Avinash sridharan

Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

2016-01-11 Thread Avinash sridharan
--- Added unit test-case for CgroupsNetClsIsolatorProcess. Diffs - src/tests/containerizer/isolator_tests.cpp 91178b69ccbf5b6cbf64421e5602e6d554fc34ca Diff: https://reviews.apache.org/r/42098/diff/ Testing --- Thanks, Avinash sridharan

Re: Review Request 42048: Defined of the CgroupNetClsIsolatorProcess.

2016-01-11 Thread Avinash sridharan
/net_cls.cpp PRE-CREATION Diff: https://reviews.apache.org/r/42048/diff/ Testing --- make check . Added a test case for CgroupNetClsIsolatorProcess. Thanks, Avinash sridharan

Re: Review Request 42097: Added cgroup/net_cls to the mesos containerizer isolation flags.

2016-01-11 Thread Avinash sridharan
://reviews.apache.org/r/42097/diff/ Testing --- Ran slave with isolation flags set to 'cgroups/net_cls' to make sure the CgroupsNetClsIsoaltorProcess is created. Have added unit-test cases to test the create, prepare and destroy methods of CgroupsNetClsIsolatorProcess. Thanks, Avinash

Re: Review Request 42097: Added cgroup/net_cls to the mesos containerizer isolation flags.

2016-01-11 Thread Avinash sridharan
. Thanks, Avinash sridharan

Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.

2016-01-12 Thread Avinash sridharan
to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate Thanks, Avinash sridharan

Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

2016-01-12 Thread Avinash sridharan
Wu. Repository: mesos Description --- Added unit test-case for CgroupsNetClsIsolatorProcess. Diffs (updated) - src/tests/containerizer/isolator_tests.cpp 91178b69ccbf5b6cbf64421e5602e6d554fc34ca Diff: https://reviews.apache.org/r/42098/diff/ Testing --- Thanks, Avinash

Review Request 48377: Added the `serialize`/deserialize` methods in `protobuf` namespace.

2016-06-07 Thread Avinash sridharan
/ Testing --- Thanks, Avinash sridharan

Review Request 48378: Moved the `serialize`/ `deserialize` calls to `stout`.

2016-06-07 Thread Avinash sridharan
check Thanks, Avinash sridharan

Re: Review Request 47893: Changed initialization order of `Anonymous` modules in Master.

2016-06-13 Thread Avinash sridharan
Diff: https://reviews.apache.org/r/47893/diff/ Testing --- make check and sudo build/bin/mesos-tests.sh Thanks, Avinash sridharan

Re: Review Request 48594: Added bundled zookeeper to the module-dependencies.

2016-06-12 Thread Avinash sridharan
/mesos_install/lib/mesos/3rdparty/include/zookeeper/zookeeper.jute.h /home/vagrant/mesos_install/include/mesos/zookeeper /home/vagrant/mesos_install/include/mesos/zookeeper/zookeeper.hpp /home/vagrant/mesos_install/include/mesos/state/zookeeper.hpp Thanks, Avinash sridharan

Review Request 48612: Removed conditional for of setting `--prefix=/`.

2016-06-12 Thread Avinash sridharan
og.h /home/vagrant/mesos_install/lib/mesos/3rdparty/include/zookeeper/zookeeper.jute.h /home/vagrant/mesos_install/include/mesos/zookeeper /home/vagrant/mesos_install/include/mesos/zookeeper/zookeeper.hpp /home/vagrant/mesos_install/include/mesos/state/zookeeper.hpp Thanks, Avinash sridharan

Re: Review Request 47893: Changed initialization order of `Anonymous` modules in Master.

2016-06-13 Thread Avinash sridharan
. Diffs (updated) - src/master/main.cpp ce6291f2595163a578abac515cb8250b066cbc52 Diff: https://reviews.apache.org/r/47893/diff/ Testing --- make check and sudo build/bin/mesos-tests.sh Thanks, Avinash sridharan

Review Request 47893: Changed initialization order of `Anonymous` modules in Master.

2016-05-26 Thread Avinash sridharan
check and sudo build/bin/mesos-tests.sh Thanks, Avinash sridharan

Review Request 47892: Re-ordered initialization for Agent `Anonymous` modules.

2016-05-26 Thread Avinash sridharan
to be enforced. Diffs - src/slave/main.cpp ecaa7826798e43244e69315cf0a64e486054cafb Diff: https://reviews.apache.org/r/47892/diff/ Testing --- make check sudo ./build/bin/mesos-tests.sh Thanks, Avinash sridharan

  1   2   3   4   5   6   7   8   9   10   >