---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40767/#review108240
---
Ship it!
Ship It!
- Avinash sridharan
On Nov. 27, 2015, 1:44
ttps://reviews.apache.org/r/40731/#review108696
---
On Dec. 2, 2015, 8:27 a.m., Avinash sridharan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
e7f14079e766ce0a8bad2da646776347e4a17169
Diff: https://reviews.apache.org/r/40731/diff/
Testing
---
Ran make check after adding Mandeep's test case to the GTEST framework.
Thanks,
Avinash sridharan
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review108313
---
On Dec. 2, 2015, 8:27 a.m., Avinash sridharan wrote:
>
> --
insert an additional line here. We leave 2 lines
> > after each global function/test.
ok
- Avinash
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review108704
---
/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169
Diff: https://reviews.apache.org/r/40731/diff/
Testing
---
Ran make check after adding Mandeep's test case to the GTEST framework.
Thanks,
Avinash sridharan
; > EXPECT_CALL(sched, resourceOffers(, _))
> > .WillOnce(FutureArg<1>());
>
> Avinash sridharan wrote:
> Was following this particular style guide:
> http://mesos.apache.org/documentation/latest/c++-style-guide/
>
> The "Function Definition/Invocation&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40903/#review109537
---
Ship it!
Ship It!
- Avinash sridharan
On Dec. 3, 2015, 11:09
.apache.org/r/40732/#review108141
---
On Nov. 26, 2015, 6:52 a.m., Avinash sridharan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
e the
change to EXPECT_DOUBLE_EQ
- Avinash
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40732/#review108150
-------
On Nov.
protobuf messages.
Thanks,
Avinash sridharan
src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96
src/slave/http.cpp cef568d77da430b96e8f97487a8d0406dc0a0116
Diff: https://reviews.apache.org/r/41188/diff/
Testing (updated)
---
make check
Thanks,
Avinash sridharan
: https://reviews.apache.org/r/41187/diff/
Testing
---
make check
Thanks,
Avinash sridharan
5198650ba6dc1ea3dab7912e5ef6e375bf9acc96
src/slave/http.cpp cef568d77da430b96e8f97487a8d0406dc0a0116
Diff: https://reviews.apache.org/r/41188/diff/
Testing
---
Thanks,
Avinash sridharan
ttps://reviews.apache.org/r/41188/diff/4/?file=1163918#file1163918line2190>
> >
> > How about:
> >
> > ```
> > Port *port1 = ports.add_ports();
> > port1->set_number(80);
> > port1->mutable_labels()->CopyFrom
/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41187/diff/
Testing
---
make check
Thanks,
Avinash sridharan
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
in state.json in slave.
Also added Unit test to test that DiscoveryInfo gets exposed in master when
TaskInfo protobuf is converted to JSON objects.
Thanks,
Avinash sridharan
.apache.org/r/41187/#review110358
---
On Dec. 14, 2015, 11:34 p.m., Avinash sridharan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41187/
> -
xposed
> > via `/state` endpoint also have a nested `labels` mapping ?
> >
> > AFAICT, this is an artifact of us using the Protobuf to JSON converters
> > when we should have just used the `model(...)` functions.
>
> Avinash sridharan wrote:
> I a
: https://reviews.apache.org/r/41381/diff/
Testing
---
make check
Thanks,
Avinash sridharan
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41187/diff/
Testing
---
make check
Thanks,
Avinash sridharan
in state.json in slave.
Also added Unit test to test that DiscoveryInfo gets exposed in master when
TaskInfo protobuf is converted to JSON objects.
Thanks,
Avinash sridharan
/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41187/diff/
Testing
---
make check
Thanks,
Avinash sridharan
/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/#review110922
---
On Dec. 17, 2015, 9:33 a.m., Avinash sridharan wrote:
>
> ---
of DiscoveryInfo in state.json in slave.
Also added Unit test to test that DiscoveryInfo gets exposed in master when
TaskInfo protobuf is converted to JSON objects.
Thanks,
Avinash sridharan
/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41187/diff/
Testing
---
make check
Thanks,
Avinash sridharan
/
Testing
---
make check
Thanks,
Avinash sridharan
8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
in state.json in slave.
Also added Unit test to test that DiscoveryInfo gets exposed in master when
TaskInfo protobuf is converted to JSON objects.
Thanks,
Avinash sridharan
in slave.
Also added Unit test to test that DiscoveryInfo gets exposed in master when
TaskInfo protobuf is converted to JSON objects.
Thanks,
Avinash sridharan
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review110940
---
On Dec. 17, 2015, 3:32 a.m., Avinash sridharan wrote:
>
> ---
> This is a
://reviews.apache.org/r/41188/diff/
Testing
---
make check.
Added Unit tests to verify setting of DiscoveryInfo in state.json in slave.
Also added Unit test to test that DiscoveryInfo gets exposed in master when
TaskInfo protobuf is converted to JSON objects.
Thanks,
Avinash sridharan
/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41187/diff/
Testing
---
make check
Thanks,
Avinash sridharan
xposed
> > via `/state` endpoint also have a nested `labels` mapping ?
> >
> > AFAICT, this is an artifact of us using the Protobuf to JSON converters
> > when we should have just used the `model(...)` functions.
>
> Avinash sridharan wrote:
> I a
of DiscoveryInfo in state.json in slave.
Also added Unit test to test that DiscoveryInfo gets exposed in master when
TaskInfo protobuf is converted to JSON objects.
Thanks,
Avinash sridharan
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41188/#review110927
-------
On Dec. 17, 2015, 10:40 p.m., Avinash sridharan wrote:
>
> ---
> This is
: https://reviews.apache.org/r/41381/diff/
Testing
---
make check
Thanks,
Avinash sridharan
: https://reviews.apache.org/r/41381/diff/
Testing
---
make check
Thanks,
Avinash sridharan
in state.json in slave.
Also added Unit test to test that DiscoveryInfo gets exposed in master when
TaskInfo protobuf is converted to JSON objects.
Thanks,
Avinash sridharan
/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41187/diff/
Testing
---
make check
Thanks,
Avinash sridharan
eviews.apache.org/r/41187/#review110472
---
On Dec. 15, 2015, 10:11 p.m., Avinash sridharan wrote:
>
> ---
> This is an automatically generated e-mail. To re
: https://reviews.apache.org/r/41381/diff/
Testing
---
make check
Thanks,
Avinash sridharan
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5
Diff: https://reviews.apache.org/r/41381/diff/
Testing
---
make check
Thanks,
Avinash sridharan
e to follow. Going to move the comments per
field.
- Avinash
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41187/#review110576
--------
: https://reviews.apache.org/r/41381/diff/
Testing
---
make check
Thanks,
Avinash sridharan
include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77
Diff: https://reviews.apache.org/r/41187/diff/
Testing
---
make check
Thanks,
Avinash sridharan
: https://reviews.apache.org/r/41381/diff/
Testing
---
make check
Thanks,
Avinash sridharan
/cgroups/net_cls.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/42048/diff/
Testing
---
make check . Added a test case for CgroupNetClsIsolatorProcess.
Thanks,
Avinash sridharan
/
Testing
---
Thanks,
Avinash sridharan
the
CgroupsNetClsIsoaltorProcess is created. Have added unit-test cases to test the
create, prepare and destroy methods of CgroupsNetClsIsolatorProcess.
Thanks,
Avinash sridharan
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
: https://reviews.apache.org/r/41381/diff/
Testing
---
make check
Thanks,
Avinash sridharan
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
: https://reviews.apache.org/r/41381/diff/
Testing
---
make check
Thanks,
Avinash sridharan
al IP address. Why not use the
> existing `Address` message and just add the following to `DiscoveryInfo`:
>
> `repeated Address vips;`
>
> Avinash sridharan wrote:
> This is the Address message :message Address {
> // May contain a hostname, IP addre
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
don't think will
make sense to use it in this context ?
- Avinash
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/#review111369
---------
al IP address. Why not use the
> existing `Address` message and just add the following to `DiscoveryInfo`:
>
> `repeated Address vips;`
>
> Avinash sridharan wrote:
> This is the Address message :message Address {
> // May contain a hostname, IP addre
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
: https://reviews.apache.org/r/41381/diff/
Testing
---
make check
Thanks,
Avinash sridharan
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
utomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/#review111848
---
On Dec. 23, 2015, 3 a.m., Avinash sridharan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
Diff: https://reviews.apache.org/r/41380/diff/
Testing
---
make check, and make
Thanks,
Avinash sridharan
-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111362
-----------
On Dec. 19, 2015, 7:58 a.m., Avinash sridharan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
: https://reviews.apache.org/r/41381/diff/
Testing
---
make check
Thanks,
Avinash sridharan
fs
> -
>
> src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464
> src/tests/slave_tests.cpp 109d31c8661c6b91243852e7ee00ce9fa1effe4b
>
> Diff: https://reviews.apache.org/r/41381/diff/
>
>
> Testing
> ---
>
> make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
cards to ignore csope and VIM files
Diffs
-
Diff: https://reviews.apache.org/r/41189/diff/
Testing
---
Thanks,
Avinash sridharan
of EXPECT_EQ (strict equality)
Diffs
-
src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12
Diff: https://reviews.apache.org/r/40732/diff/
Testing
---
Ran make check against 40730
Thanks,
Avinash sridharan
/) to
test this fix.
Thanks,
Avinash sridharan
-
src/tests/reservation_tests.cpp 15d180f92ec0aea99e6f3a7d0b505c62bd207b61
Diff: https://reviews.apache.org/r/40731/diff/
Testing
---
Ran make check after adding Mandeep's test case to the GTEST framework.
Thanks,
Avinash sridharan
Wu.
Repository: mesos
Description
---
Added unit test-case for CgroupsNetClsIsolatorProcess.
Diffs (updated)
-
src/tests/containerizer/isolator_tests.cpp
91178b69ccbf5b6cbf64421e5602e6d554fc34ca
Diff: https://reviews.apache.org/r/42098/diff/
Testing
---
Thanks,
Avinash
---
Thanks,
Avinash sridharan
---
Added unit test-case for CgroupsNetClsIsolatorProcess.
Diffs
-
src/tests/containerizer/isolator_tests.cpp
91178b69ccbf5b6cbf64421e5602e6d554fc34ca
Diff: https://reviews.apache.org/r/42098/diff/
Testing
---
Thanks,
Avinash sridharan
/net_cls.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/42048/diff/
Testing
---
make check . Added a test case for CgroupNetClsIsolatorProcess.
Thanks,
Avinash sridharan
://reviews.apache.org/r/42097/diff/
Testing
---
Ran slave with isolation flags set to 'cgroups/net_cls' to make sure the
CgroupsNetClsIsoaltorProcess is created. Have added unit-test cases to test the
create, prepare and destroy methods of CgroupsNetClsIsolatorProcess.
Thanks,
Avinash
.
Thanks,
Avinash sridharan
to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate
Thanks,
Avinash sridharan
Wu.
Repository: mesos
Description
---
Added unit test-case for CgroupsNetClsIsolatorProcess.
Diffs (updated)
-
src/tests/containerizer/isolator_tests.cpp
91178b69ccbf5b6cbf64421e5602e6d554fc34ca
Diff: https://reviews.apache.org/r/42098/diff/
Testing
---
Thanks,
Avinash
/
Testing
---
Thanks,
Avinash sridharan
check
Thanks,
Avinash sridharan
Diff: https://reviews.apache.org/r/47893/diff/
Testing
---
make check
and sudo build/bin/mesos-tests.sh
Thanks,
Avinash sridharan
/mesos_install/lib/mesos/3rdparty/include/zookeeper/zookeeper.jute.h
/home/vagrant/mesos_install/include/mesos/zookeeper
/home/vagrant/mesos_install/include/mesos/zookeeper/zookeeper.hpp
/home/vagrant/mesos_install/include/mesos/state/zookeeper.hpp
Thanks,
Avinash sridharan
og.h
/home/vagrant/mesos_install/lib/mesos/3rdparty/include/zookeeper/zookeeper.jute.h
/home/vagrant/mesos_install/include/mesos/zookeeper
/home/vagrant/mesos_install/include/mesos/zookeeper/zookeeper.hpp
/home/vagrant/mesos_install/include/mesos/state/zookeeper.hpp
Thanks,
Avinash sridharan
.
Diffs (updated)
-
src/master/main.cpp ce6291f2595163a578abac515cb8250b066cbc52
Diff: https://reviews.apache.org/r/47893/diff/
Testing
---
make check
and sudo build/bin/mesos-tests.sh
Thanks,
Avinash sridharan
check
and sudo build/bin/mesos-tests.sh
Thanks,
Avinash sridharan
to be
enforced.
Diffs
-
src/slave/main.cpp ecaa7826798e43244e69315cf0a64e486054cafb
Diff: https://reviews.apache.org/r/47892/diff/
Testing
---
make check
sudo ./build/bin/mesos-tests.sh
Thanks,
Avinash sridharan
keeper.hpp
./include/mesos/state/zookeeper.hpp
Thanks,
Avinash sridharan
robably checkpoint the JSON into the containers checkpoint DIR and set the
stdinof the plugin to the checkpointed JSON config. This would also serve the
dual purpose of checkpointing the mutated JSON to be used when deleteing the
container.
- Avinash sridharan
On June 14, 2016, 7:55 p.m., D
` modules.
Diffs (updated)
-
src/slave/main.cpp fddb05c2d2756f823a4fa393373a9ebc0f14895c
Diff: https://reviews.apache.org/r/47892/diff/
Testing
---
make check
sudo ./build/bin/mesos-tests.sh
Thanks,
Avinash sridharan
May be you enhance the documentation at
https://github.com/projectcalico/calico-containers/blob/master/docs/mesos/ManualInstallCalicoCNI.md
- Avinash sridharan
On May 28, 2016, 1:27 a.m., Dan Osborne wrote:
>
> ---
> This is a
999/#comment200434>
Add a line here.
Should have two lines between sections.
- Avinash sridharan
On May 28, 2016, 1:27 a.m., Dan Osborne wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
1 - 100 of 890 matches
Mail list logo