f047b90d8f0b4dfe7e6cad6dc58909451e9f894b
Diff: https://reviews.apache.org/r/34980/diff/
Testing
---
make check
Thanks,
Bartek Plotka
://reviews.apache.org/r/34980/#review86464
---
On June 3, 2015, 9:16 p.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
On June 3, 2015, 5:54 p.m., Bartek Plotka wrote:
include/mesos/slave/qos_controller.hpp, line 52
https://reviews.apache.org/r/34631/diff/3/?file=977207#file977207line52
Small thing:
s/type/name/ ..to be consistent with allocator factory. (:
What is the reason
f047b90d8f0b4dfe7e6cad6dc58909451e9f894b
Diff: https://reviews.apache.org/r/34980/diff/
Testing
---
make check
Thanks,
Bartek Plotka
f047b90d8f0b4dfe7e6cad6dc58909451e9f894b
Diff: https://reviews.apache.org/r/34980/diff/
Testing
---
make check
Thanks,
Bartek Plotka
/34633/#comment138741
Reorder? (:
Like that for example:
https://github.com/apache/mesos/blob/master/src/examples/test_isolator_module.cpp#L33
- Bartek Plotka
On June 4, 2015, 5:42 p.m., Niklas Nielsen wrote
- Bartek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35157/#review87074
---
On June 9, 2015, 12:17 a.m., Bartek Plotka wrote
---
On June 9, 2015, 12:17 a.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35157/
---
(Updated June 9, 2015
dff45b0d3bf9ef53f19575ab3d90a0b223755d6a
src/tests/oversubscription_tests.cpp afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7
Diff: https://reviews.apache.org/r/35157/diff/
Testing
---
make check
Thanks,
Bartek Plotka
: https://reviews.apache.org/r/35157/diff/
Testing
---
make check
Thanks,
Bartek Plotka
81c4b3e658902be0438f42d9e86911e424828a73
src/slave/slave.cpp 054929b156374a8929ac9fffb032045f13c3eb43
src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417
Diff: https://reviews.apache.org/r/35164/diff/
Testing
---
make check
Thanks,
Bartek Plotka
ReviewRequest
change! ):
- Bartek Plotka
On June 5, 2015, 10:52 p.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35157
,
Bartek Plotka
dff45b0d3bf9ef53f19575ab3d90a0b223755d6a
src/tests/oversubscription_tests.cpp afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7
Diff: https://reviews.apache.org/r/35157/diff/
Testing
---
make check
Thanks,
Bartek Plotka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/#review86246
---
On June 2, 2015, 7:37 p.m., Bartek Plotka wrote
/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b
src/tests/oversubscription_tests.cpp
ea5857cb579aa904fd05530684bdde51a0b3f27f
Diff: https://reviews.apache.org/r/34816/diff/
Testing
---
make check
Thanks,
Bartek Plotka
.
Diffs (updated)
-
include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
Diff: https://reviews.apache.org/r/34748/diff/
Testing
---
make check
Thanks,
Bartek Plotka
/tests/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b
src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
Diff: https://reviews.apache.org/r/34816/diff/
Testing
---
make check
Thanks,
Bartek Plotka
---
On June 2, 2015, 7:40 p.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748
check
Thanks,
Bartek Plotka
://reviews.apache.org/r/34816/#review86271
---
On June 2, 2015, 7:37 p.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
here?
Bartek Plotka wrote:
Do you mean the Resource usage is for an executor sentence or sth else?
Oh, i think you ment:
```
required SlaveID slave_id = 1;
required FrameworkID framework_id = 2;
```
So the SlaveID is not needed, because (in current implementation) ResourceUsage
c379f01ae4e185960b8710b6a10626a3b8784fc8
src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
Diff: https://reviews.apache.org/r/34662/diff/
Testing
---
make check
Thanks,
Bartek Plotka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/#review86283
---
On June 2, 2015, 8:36 p.m., Bartek Plotka wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review86247
---
On June 2, 2015, 12:40 a.m., Bartek Plotka wrote
/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b
src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
Diff: https://reviews.apache.org/r/34816/diff/
Testing
---
make check
Thanks,
Bartek Plotka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86323
---
Ship it!
Ship It!
- Bartek Plotka
On June 2, 2015, 11:15 p.m
(updated)
-
src/tests/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b
src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
Diff: https://reviews.apache.org/r/34816/diff/
Testing
---
make check
Thanks,
Bartek Plotka
: https://reviews.apache.org/r/34748/diff/
Testing
---
make check
Thanks,
Bartek Plotka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35157/#review87229
---
On June 9, 2015, 12:17 a.m., Bartek Plotka wrote
, 2015, 11:44 p.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35164/
---
(Updated June 5, 2015, 11:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35279/#review87402
---
Ship it!
Ship It!
- Bartek Plotka
On June 10, 2015, 1:09 a.m
://reviews.apache.org/r/35280/#comment139734
s/Controller module/Controller module/ (kill one space)
- Bartek Plotka
On June 10, 2015, 1:09 a.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/#comment139731
Could you change s/resource estimator/Resource Estimator/ to be compliant
with QoS Controller name? If you are Upper casing names, you can do it for RE
as well.. (:
- Bartek Plotka
On June 10, 2015, 1:09 a.m., Niklas Nielsen wrote
/r/35281/#comment139742
Reorder.
- Bartek Plotka
On June 10, 2015, 1:09 a.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35281
Thanks,
Bartek Plotka
5e574c5aa79d548e5730db021b0e8b77d27f220b
src/tests/oversubscription_tests.cpp e8ae053dd9cd712e49bd2830e414b7a3d99c20ca
Diff: https://reviews.apache.org/r/35157/diff/
Testing
---
make check
Thanks,
Bartek Plotka
interfaces are out and rebase since this
is a relatively small patch. I'll get the changes out today.
Although, I am ok if you want to commit this one (i'll need to rebase
mine).
Bartek Plotka wrote:
Niklas +1
The only change will be s/list// for this patch
, 4:26 a.m.)
Review request for mesos, Bartek Plotka, Jie Yu, and Vinod Kone.
Repository: mesos
Description
---
Added QoS Controller class and NOOP controller implementation
Diffs
-
include/mesos/slave/qos_controller.hpp PRE-CREATION
src/Makefile.am
/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b
Diff: https://reviews.apache.org/r/34980/diff/
Testing (updated)
---
make check
Thanks,
Bartek Plotka
guess it something with https://reviews.apache.org/r/34962/diff/#file976910,
since this patch depends on that.
- Bartek Plotka
On June 3, 2015, 5:56 a.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply
On June 3, 2015, 5:58 a.m., Bartek Plotka wrote:
Any idea why review requests failed to show diff of noop.hpp?
I guess it something with
https://reviews.apache.org/r/34962/diff/#file976910, since this patch
depends on that.
reviewboard*
- Bartek
---
On May 27, 2015, 1:34 a.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/
---
(Updated May 27, 2015, 1:34
,
Bartek Plotka
48fe59faacf53f1015665b0867aefd08d5b29225
src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
Diff: https://reviews.apache.org/r/34748/diff/
Testing
---
make check
Thanks,
Bartek Plotka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review85585
---
On May 28, 2015, 6:41 p.m., Bartek Plotka wrote
://reviews.apache.org/r/34662/diff/
Testing
---
make check
Thanks,
Bartek Plotka
check
Thanks,
Bartek Plotka
://reviews.apache.org/r/34816/diff/
Testing
---
make check
Thanks,
Bartek Plotka
ea5857cb579aa904fd05530684bdde51a0b3f27f
Diff: https://reviews.apache.org/r/34816/diff/
Testing
---
make check
Thanks,
Bartek Plotka
)
-
include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
Diff: https://reviews.apache.org/r/34748/diff/
Testing
---
make check
Thanks,
Bartek
)
-
include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
Diff: https://reviews.apache.org/r/34748/diff/
Testing
---
make check
Thanks,
Bartek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/#review86051
---
On June 1, 2015, 5:37 a.m., Bartek Plotka wrote
---
On June 1, 2015, 5:37 a.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816
://reviews.apache.org/r/34816/diff/
Testing
---
make check
Thanks,
Bartek Plotka
c379f01ae4e185960b8710b6a10626a3b8784fc8
src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
Diff: https://reviews.apache.org/r/34662/diff/
Testing
---
make check
Thanks,
Bartek Plotka
ac986a0687a576a0bd5693c82b3c7d543aaa956b
src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
Diff: https://reviews.apache.org/r/34816/diff/
Testing
---
make check
Thanks,
Bartek Plotka
c4f811998aef14ab247380318fab79f18672ab29
src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88
src/tests/resource_estimator.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/34662/diff/
Testing
---
make check
Thanks,
Bartek Plotka
?
- Bartek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review85225
---
On May 27, 2015, 12:15 a.m., Bartek Plotka wrote
b8f7a2f9236166e42421d926718af8d45e857eba
src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88
Diff: https://reviews.apache.org/r/34816/diff/
Testing
---
make check
Thanks,
Bartek Plotka
plumbing between RE and Slave.
Diffs
-
src/tests/mesos.hpp b8f7a2f9236166e42421d926718af8d45e857eba
src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88
Diff: https://reviews.apache.org/r/34816/diff/
Testing
---
make check
Thanks,
Bartek Plotka
c4f811998aef14ab247380318fab79f18672ab29
src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88
src/tests/resource_estimator.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/34662/diff/
Testing
---
make check
Thanks,
Bartek Plotka
48fe59faacf53f1015665b0867aefd08d5b29225
src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
Diff: https://reviews.apache.org/r/34748/diff/
Testing
---
make check
Thanks,
Bartek Plotka
:
TestResourceEstimator need to have a 'create()' which takes a Flags
object, to be consistent with modules typed tests; so it's is just to avoid
another 'create()'. Would you prefer that?
Parameters could be removed - @Bartek Plotka, mind removing that one? :)
Bartek Plotka wrote
a66888916dc90e476c8bb20e67e3f6b08c47fb99
src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
Diff: https://reviews.apache.org/r/34748/diff/
Testing
---
make check
Thanks,
Bartek Plotka
., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/
---
(Updated May 29, 2015, 6:18 p.m.)
Review
://reviews.apache.org/r/34816/diff/
Testing
---
make check
Thanks,
Bartek Plotka
(:
- Bartek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/#review85795
---
On May 29, 2015, 6:18 p.m., Bartek Plotka wrote
c379f01ae4e185960b8710b6a10626a3b8784fc8
src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
Diff: https://reviews.apache.org/r/34662/diff/
Testing
---
make check
Thanks,
Bartek Plotka
/tests/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b
src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
Diff: https://reviews.apache.org/r/34816/diff/
Testing
---
make check
Thanks,
Bartek Plotka
-CREATION
src/tests/resource_estimator_module.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34662/diff/
Testing
---
make check
Thanks,
Bartek Plotka
c4f811998aef14ab247380318fab79f18672ab29
src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88
src/tests/resource_estimator.hpp PRE-CREATION
src/tests/resource_estimator_module.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34662/diff/
Testing
---
make check
Thanks,
Bartek
, 5:06 p.m.)
Review request for mesos, Bartek Plotka, Jie Yu, and Vinod Kone.
Repository: mesos
Description
---
Added QoS Controller class and NOOP controller implementation
Diffs
-
include/mesos/slave/qos_controller.hpp PRE-CREATION
src/Makefile.am
/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88
src/tests/resource_estimator.hpp PRE-CREATION
src/tests/resource_estimator_module.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34662/diff/
Testing
---
make check
Thanks,
Bartek Plotka
(make)
2) checked that *oversubscription.pb.h* and *oversubscription.pb.cc* are in the
proper directories
3) run *mesos-slave*, *mesos-master* and checked if their behaviour is proper
Thanks,
Bartek Plotka
Thanks,
Bartek Plotka
/34581/#review84988
---
On May 22, 2015, 7:46 p.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581
* and checked if their behaviour is proper
Thanks,
Bartek Plotka
if their behaviour is proper
Thanks,
Bartek Plotka
Controller and slave.
Diffs
-
include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99
Diff: https://reviews.apache.org/r/34571/diff/
Testing
---
make check
Thanks,
Bartek Plotka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34571/#review84817
---
On May 21, 2015, 11:02 p.m., Bartek Plotka wrote
/34581/diff/
Testing (updated)
---
* make check
* run mesos:
1) build (make)
2) checked that *oversubscription.pb.h* and *oversubscription.pb.cc* are in the
proper directories
3) run *mesos-slave*, *mesos-master* and checked if their behaviour is proper
Thanks,
Bartek Plotka
check
* run mesos:
1) build
2) checked that *oversubscription.pb.h* and *oversubscription.pb.cc* are in the
proper directories
3) run *mesos-slave*, *mesos-master* and checked if their behaviour is proper
Thanks,
Bartek Plotka
://reviews.apache.org/r/34581/#review85227
---
On May 23, 2015, 3:30 a.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
Thanks,
Bartek Plotka
it make sense?
- Bartek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review84988
---
On May 26, 2015, 8:50 p.m., Bartek Plotka
if their behaviour is proper
Thanks,
Bartek Plotka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34631/#review85267
---
Ship it!
Ship It!
- Bartek Plotka
On May 26, 2015, 3:30 p.m
-slave*, *mesos-master* and checked if their behaviour is proper
Thanks,
Bartek Plotka
On May 26, 2015, 7:26 p.m., Vinod Kone wrote:
include/mesos/slave/oversubscription.proto, line 47
https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line47
why optional?
Bartek Plotka wrote:
IMO, because we can (only optionally) specify the descriptive reason
3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273
src/slave/slave.cpp 008170f4ce7b97eda43b50b48083b32ae65925c0
Diff: https://reviews.apache.org/r/36204/diff/
Testing
---
make check.
Thanks,
Bartek Plotka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36204/#review90510
---
On July 7, 2015, 4:20 p.m., Bartek Plotka wrote
://reviews.apache.org/r/36314/diff/
Testing
---
make check.
Thanks,
Bartek Plotka
---
make check.
Thanks,
Bartek Plotka
://reviews.apache.org/r/36314/diff/
Testing
---
make check.
Thanks,
Bartek Plotka
ea0ddf38444915a1cda71cce6a8897803fa49198
Diff: https://reviews.apache.org/r/36314/diff/
Testing
---
make check.
Thanks,
Bartek Plotka
---
make check
Thanks,
Bartek Plotka
/slave/qos_controllers/load.hpp PRE-CREATION
src/slave/qos_controllers/load.cpp PRE-CREATION
src/tests/oversubscription_tests.cpp 0333281c247dd182860a49f39be791c00679bf6b
Diff: https://reviews.apache.org/r/40617/diff/
Testing
---
make check
Thanks,
Bartek Plotka
/load.cpp PRE-CREATION
src/tests/oversubscription_tests.cpp 0333281c247dd182860a49f39be791c00679bf6b
Diff: https://reviews.apache.org/r/40617/diff/
Testing
---
make check
run mesos with org_apache_mesos_LoadQoSController module included.
Thanks,
Bartek Plotka
/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
Diff: https://reviews.apache.org/r/41042/diff/
Testing
---
Thanks,
Bartek Plotka
1 - 100 of 124 matches
Mail list logo
