Re: Review Request 33193: Warn if g++ 4.8, C++ standard library is too old

2015-04-23 Thread Cody Maloney
testing gcc 4.9.2, gcc 4.4.7, clang 3.6 all on Windows Thanks, Cody Maloney

Re: Review Request 28257: Allow prefix paths in libprocess

2015-04-23 Thread Cody Maloney
--- make distcheck ubuntu 14.04 Manually browse the mesos web UI and verify that things seem to generally work Thanks, Cody Maloney

Re: Review Request 33643: Add EMPTY to stout hashset

2015-05-05 Thread Cody Maloney
://reviews.apache.org/r/33643/#comment133391 Any reason we can't do this as a function with a static in it? Solves the destruction order issues, doesn't leak, doesn't require the constant reference. - Cody Maloney On May 5, 2015, 9:50 p.m., Joris Van Remoortere wrote

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

2015-05-05 Thread Cody Maloney
On May 5, 2015, 4:29 p.m., Cody Maloney wrote: configure.ac, line 575 https://reviews.apache.org/r/33849/diff/1/?file=950367#file950367line575 Can you check ax_cxx_compiler_version = Clang/LLVM 3.5 here? Or does that not work on both OS X and Linux? James Peach wrote: Hmm

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

2015-05-05 Thread Cody Maloney
mentioned above. - Cody Maloney On May 5, 2015, 3:53 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33849

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

2015-05-05 Thread Cody Maloney
On May 5, 2015, 4:29 p.m., Cody Maloney wrote: configure.ac, line 575 https://reviews.apache.org/r/33849/diff/1/?file=950367#file950367line575 Can you check ax_cxx_compiler_version = Clang/LLVM 3.5 here? Or does that not work on both OS X and Linux? James Peach wrote: Hmm

Re: Review Request 34225: Deleted travis YAML file.

2015-05-14 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34225/#review83812 --- Ship it! Ship It! - Cody Maloney On May 14, 2015, 6:21 p.m

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

2015-06-04 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/#review86738 --- LGTM - Cody Maloney On June 4, 2015, 7:31 p.m., James Peach

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-06-08 Thread Cody Maloney
On June 9, 2015, 12:28 a.m., Cody Maloney wrote: Partial review, going to review more thoroughly later, just posting so it doesn't get lost since it was on the old revision - Cody --- This is an automatically generated e-mail

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-06-08 Thread Cody Maloney
://reviews.apache.org/r/35084/#comment138799 Since these all follow about the same structure could we add an autoconf macro which takes the package name followed by the help description and does the rest automatically? - Cody Maloney On June 9, 2015, 12:02 a.m., James Peach wrote

Re: Review Request 35179: MESOS-1733 Variadic Path Join

2015-06-09 Thread Cody Maloney
On June 9, 2015, 6:34 a.m., Cody Maloney wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 58 https://reviews.apache.org/r/35179/diff/2/?file=980529#file980529line58 I'm still against using enable_if here, it's a lot of extra complexity (And will be slightly

Re: Review Request 35234: libprocess: consistent handling of --enable options

2015-06-23 Thread Cody Maloney
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35234/ --- (Updated June 9, 2015, 12:04 a.m.) Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair

Re: Review Request 34881: let libprocess to compile on arm64 servers

2015-06-21 Thread Cody Maloney
://reviews.apache.org/r/34881/#comment141289 Where did this header come from? If we were to just update protobuf to a newer version would it just compile? - Cody Maloney On June 1, 2015, 7:10 a.m., Dong Robin wrote

Re: Review Request 35565: Refactored os::environment to return a std::map.

2015-06-20 Thread Cody Maloney
/mobile#issue/MESOS-2811 - Cody Maloney On June 20, 2015, 7:01 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35565

Re: Review Request 32982: Added reservation user guide.

2015-06-26 Thread Cody Maloney
On May 13, 2015, 10:25 p.m., Marco Massenzio wrote: docs/reservation.md, line 71 https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line71 this seems to imply that in the Request, the `slave_id` is some part of a form submission: ``` -d, --data data

Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.

2015-08-04 Thread Cody Maloney
the if java check around the AC_CHECK_FILE where it was previously. - Cody Maloney On Aug. 4, 2015, 9:27 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811

Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.

2015-08-10 Thread Cody Maloney
for correctness though. - Cody Maloney On Aug. 7, 2015, 3:21 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811

Re: Review Request 36810: Don't check protobuf jar in libprocess.

2015-08-04 Thread Cody Maloney
toto guarantee things keep working. - Cody Maloney On Aug. 4, 2015, 9:27 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810

Re: Review Request 36425: Enabling IP Discovery script

2015-07-13 Thread Cody Maloney
libprocess is going to not say very cleanly where that value came from, and I suspect when doing iteration it will be fairly common for people to write IP scripts which give incorrect / invalid output. - Cody Maloney On July 13, 2015, 4:35 p.m., Marco Massenzio wrote

Re: Review Request 36425: Enabling IP Discovery script

2015-07-13 Thread Cody Maloney
, Benjamin Hindman and Cody Maloney. Bugs: MESOS-2902 https://issues.apache.org/jira/browse/MESOS-2902 Repository: mesos Description --- Jira: MESOS-2902 It is sometimes useful to enable an external script to configure the IP address the Mesos Master will bind

Re: Review Request 36425: Enabling IP Discovery script

2015-07-13 Thread Cody Maloney
On July 13, 2015, 9:12 p.m., Cody Maloney wrote: Generally looks reasonable to me. I haven't integration tested yet inside DCOS, will work on that before too long. Marco Massenzio wrote: reasonable not exactly a ringing endorsement :) but I guess I'll take

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

2015-11-05 Thread Cody Maloney
> On Nov. 2, 2015, 5:43 a.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 433 > > > > > > I think there are two problems here to address: > > - --net is not always set to host, and if it's not it's

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102094 --- LGTM! - Cody Maloney On Oct. 9, 2015, 12:57 a.m., Greg Mann

Re: Review Request 41680: Reduced LogLevel in order to avoid overflowing logs.

2015-12-23 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41680/#review111815 --- Ship it! Ship It! - Cody Maloney On Dec. 23, 2015, 9:06 a.m

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-09 Thread Cody Maloney
g them all at once to loadManifest? I'm worried that the behavior here could differ slightly from the --modules flag which calls loadManifest with all the modules at once. - Cody Maloney On May 9, 2016, 5:10 p.m.

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

2016-05-09 Thread Cody Maloney
> On May 10, 2016, 5:27 a.m., Cody Maloney wrote: > > I believe this covers the use cases we need. Be great to have a demo PR of it in action for: https://github.com/dcos/dcos to validate that it does.