Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-17 Thread Guangya Liu
012af0508eeceeccd168b29f36fa258d20b28c21 src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 Diff: https://reviews.apache.org/r/37532/diff/ Testing --- Thanks, Guangya Liu

Re: Review Request 37512: Added user doc for Scheduler HTTP API.

2015-08-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37512/#review95712 --- Ship it! Ship It! - Guangya Liu On 八月 18, 2015, 3:08 a.m

Re: Review Request 37586: Generate usage help information in libprocess.

2015-08-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37586/#review95846 --- Ship it! Ship It! - Guangya Liu On 八月 18, 2015, 6:32 p.m

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-22 Thread Guangya Liu
:47 p.m., Guangya Liu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated 八月 17, 2015, 1:47 p.m.) Review

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-22 Thread Guangya Liu
, Guangya Liu

Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96114 --- Ship it! Ship It! - Guangya Liu On 八月 22, 2015, 6:10 a.m

Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter.

2015-08-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37176/#review95810 --- Ship it! Ship It! - Guangya Liu On 八月 18, 2015, 6:57 p.m

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-08-18 Thread Guangya Liu
/37180/#comment150947 I think the blank line can be removed src/master/master.cpp (line 4841) https://reviews.apache.org/r/37180/#comment150946 I think the blank line can be removed - Guangya Liu On 八月 18, 2015, 6:58 p.m., Joris Van Remoortere wrote

Re: Review Request 37586: Generate usage help information in libprocess.

2015-08-18 Thread Guangya Liu
code, then how to handle the case when mesos want to upgrade the 3rd party libraries? - Guangya Liu On 八月 18, 2015, 6:32 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-08-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/#review95802 --- Ship it! Ship It! - Guangya Liu On 八月 18, 2015, 6:58 p.m

Re: Review Request 37589: Remove unnecessary usage information.

2015-08-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37589/#review95808 --- Ship it! Ship It! - Guangya Liu On 八月 18, 2015, 6:36 p.m

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

2015-08-18 Thread Guangya Liu
://reviews.apache.org/r/37177/#comment150949 Remove this blank space. The commit should not be permitted if there are blank space in code. - Guangya Liu On 八月 18, 2015, 6:57 p.m., Joris Van Remoortere wrote: --- This is an automatically

Re: Review Request 37208: Fix the spell error in help message of slave component.

2015-08-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37208/#review95609 --- Ship it! Ship It! - Guangya Liu On 八月 17, 2015, 6:50 a.m., Yong

Re: Review Request 37511: Fixed master to reject non-subscribe calls made before subscription.

2015-08-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37511/#review95559 --- Ship it! Ship It! - Guangya Liu On 八月 16, 2015, 11:41 p.m

Re: Review Request 37510: Add more logging to the scheduler library

2015-08-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37510/#review95554 --- Ship it! Ship It! - Guangya Liu On 八月 16, 2015, 9:18 p.m

Re: Review Request 37531: MESOS-3070

2015-08-17 Thread Guangya Liu
/37531/#comment150737 Does this logic still needed? I see that the taskTag logic should already covered this? src/messages/messages.proto (line 65) https://reviews.apache.org/r/37531/#comment150736 I want some comments here for what is taskTag - Guangya Liu On Aug. 17, 2015, 1:28 p.m

Re: Review Request 37512: Added user doc for Scheduler HTTP API.

2015-08-17 Thread Guangya Liu
/37512/#comment150739 s/Mesos master/Mesos Master Also I think that we should make master unified in this document. Currently there are master, Master, Mesos master, Mesos Master, we may want to select one as the final name of master and apply to the whole document. - Guangya Liu

Re: Review Request 37268: Style checker checking for { on newline

2015-08-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37268/#review96138 --- Ship it! Ship It! - Guangya Liu On 八月 12, 2015, 1:15 a.m., Jose

Re: Review Request 37142: Removed the unneeded ExecutorInfo from Container struct in MesosContainerizer.

2015-08-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37142/#review94318 --- Ship it! LGTM - Guangya Liu On 八月 5, 2015, 9:22 p.m., Jie Yu

Re: Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.

2015-08-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/#review94913 --- Ship it! Ship It! - Guangya Liu On 八月 7, 2015, 10:44 p.m

Re: Review Request 36979: Updating all references to os::shell

2015-08-06 Thread Guangya Liu
/#comment149063 Why not use the following? return !out.get().empty(); - Guangya Liu On 八月 6, 2015, 6:24 p.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 37198: Add Docker image provisioner and copy backend.

2015-08-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review94485 --- Ship it! LGTM - Guangya Liu On 八月 6, 2015, 8:37 p.m., Lily Chen

Re: Review Request 37196: Add Docker Image type to Container Image protobuf.

2015-08-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37196/#review94480 --- Ship it! Ship It! - Guangya Liu On 八月 6, 2015, 9:27 p.m., Lily

Re: Review Request 37257: Add SUPPRESS call interface to the scheduler

2015-08-13 Thread Guangya Liu
include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca Diff: https://reviews.apache.org/r/37257/diff/ Testing --- Thanks, Guangya

Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator

2015-08-14 Thread Guangya Liu
/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu

Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator

2015-08-14 Thread Guangya Liu
57883686c6e4333fc1a246a758e7dd861556d6fa src/slave/qos_controllers/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu

Re: Review Request 37244: Fixed scheduler message metrics to work with scheduler Calls.

2015-08-08 Thread Guangya Liu
/37244/#comment149216 I think that this change does not related to this RR, can you please handle this in another RR? Thanks - Guangya Liu On 八月 8, 2015, 12:53 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail

Re: Review Request 35711: Disallow special characters in role name.

2015-08-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review94631 --- Ship it! Ship It! - Guangya Liu On 八月 7, 2015, 6:50 p.m

Re: Review Request 37244: Fixed scheduler message metrics to work with scheduler Calls.

2015-08-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37244/#review94632 --- Ship it! Thanks for the update - Guangya Liu On 八月 8, 2015, 3

Re: Review Request 37254: Added Master::teardown() to handle TEARDOWN call.

2015-08-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37254/#review94633 --- So you will add some test cases in another RR? - Guangya Liu

Review Request 37257: Add SUPPRESS call interface to the scheduler

2015-08-08 Thread Guangya Liu
012af0508eeceeccd168b29f36fa258d20b28c21 src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca Diff: https://reviews.apache.org/r/37257/diff/ Testing --- Thanks, Guangya Liu

Re: Review Request 37254: Added Master::teardown() to handle TEARDOWN call.

2015-08-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37254/#review94636 --- Ship it! Ship It! - Guangya Liu On 八月 8, 2015, 3:30 p.m., Vinod

Re: Review Request 37257: Add SUPPRESS call interface to the scheduler

2015-08-08 Thread Guangya Liu
/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca Diff: https://reviews.apache.org/r/37257/diff/ Testing --- Thanks, Guangya Liu

Re: Review Request 37468: Removed allocation types to mesos::master namespace

2015-08-14 Thread Guangya Liu
- Guangya Liu On 八月 14, 2015, 2:01 a.m., José Guilherme Vanz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/ --- (Updated 八月

Re: Review Request 37445: Fix typos in style guide.

2015-08-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37445/#review95419 --- Ship it! Ship It! - Guangya Liu On 八月 13, 2015, 9:58 p.m., Neil

Review Request 36472: Update submitting-a-patch.md

2015-07-13 Thread Guangya Liu
- docs/submitting-a-patch.md 0221fe36f3f061b2f4ffe0fc4684420608f853b2 Diff: https://reviews.apache.org/r/36472/diff/ Testing --- Thanks, Guangya Liu

Re: Review Request 36472: Update submitting-a-patch.md

2015-07-13 Thread Guangya Liu
to the guidelines. Diffs (updated) - docs/submitting-a-patch.md 0221fe36f3f061b2f4ffe0fc4684420608f853b2 Diff: https://reviews.apache.org/r/36472/diff/ Testing --- Thanks, Guangya Liu

Review Request 36441: Update message when master is sending offer(s)

2015-07-13 Thread Guangya Liu
--- If the mesos master send only 1 offer, it should use offer but not offers. This patch is updating the offers to offer(s) to be more generic. Diffs - src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d Diff: https://reviews.apache.org/r/36441/diff/ Testing --- Thanks, Guangya Liu

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-25 Thread Guangya Liu
/36321/#comment151698 Got it. include/mesos/mesos.proto (line 939) https://reviews.apache.org/r/36321/#comment151696 Thanks Joe! Got it, but I think that it is better that we can add some notes here to be more clear - Guangya Liu On Aug. 25, 2015, 3:24 p.m., Joseph Wu wrote

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review96375 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

2015-08-25 Thread Guangya Liu
/37358/#comment151699 Got it - Guangya Liu On Aug. 25, 2015, 5:03 p.m., Joseph Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/#review96369 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 5:03 p.m

Re: Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

2015-08-25 Thread Guangya Liu
/r/36321/diff/11#0 is already covering this part and also the time is using TimeSpec to be more accurate. - Guangya Liu On Aug. 25, 2015, 2:13 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/#review96382 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m

Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator

2015-08-24 Thread Guangya Liu
57883686c6e4333fc1a246a758e7dd861556d6fa src/slave/qos_controllers/noop.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37479/diff/ Testing --- Thanks, Guangya Liu

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

2015-08-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/#review96269 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 12:14 a.m

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

2015-08-24 Thread Guangya Liu
://reviews.apache.org/r/37178/#comment151604 I think that the comments also needs to be updated to reflect inverse offer. include/mesos/v1/scheduler/scheduler.proto (line 70) https://reviews.apache.org/r/37178/#comment151605 ditto - Guangya Liu On 八月 18, 2015, 7:02 p.m., Joris Van Remoortere

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-24 Thread Guangya Liu
. include/mesos/mesos.proto (line 939) https://reviews.apache.org/r/36321/#comment151598 Can you please elaborate more for why in maintaince purpose, this field is always empty? Why cannot an operator set the resources that s/he want to inverse? - Guangya Liu On 八月 24, 2015, 6:26 p.m

Re: Review Request 37101: Remove unused sched API's

2015-08-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37101/#review96266 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 9:30 p.m

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

2015-08-24 Thread Guangya Liu
/r/37500/#comment151607 It is better to add some comments here. i.e. This message is sent to the slave to update framework user info for a slave. src/slave/slave.cpp (line 2173) https://reviews.apache.org/r/37500/#comment151608 Update the indent here - Guangya Liu

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96359 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 6:33 p.m

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-23 Thread Guangya Liu
--gtest_filter="ContentType/SchedulerTest.Suppress/*" --gtest_repeat=-1 --gtest_break_on_failure Thanks, Guangya Liu

Review Request 39628: Clear the suppressed flag when deactive a framework

2015-10-24 Thread Guangya Liu
--- Thanks, Guangya Liu

Re: Review Request 39614: Quota: Added Status Validation Tests.

2015-10-24 Thread Guangya Liu
tps://reviews.apache.org/r/39614/#comment162043> I see that most of the test cases are not using xx_xx to name the test function, can we rename Status_EmptyQuota to StatusEmptyQuota? Same question for all of the functions in this file. - Guangya Liu On 十月 24, 2015, 7:40 p.m., Joerg Schad

Re: Review Request 39492: Added status endpoint for quota master endpoint.

2015-10-24 Thread Guangya Liu
/quota_handler.cpp (line 237) <https://reviews.apache.org/r/39492/#comment162041> Can you please add a new test case for this? You can refer to https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L1623-L1699 as a reference - Guangya Liu On 十月 23, 2015, 10:34 p.m., Joerg Schad

Re: Review Request 39223: Added Quota Request Validation Tests.

2015-10-25 Thread Guangya Liu
ews.apache.org/r/39223/#comment162050> new line - Guangya Liu On 十月 23, 2015, 9:10 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 39492: Added status endpoint for quota master endpoint.

2015-10-24 Thread Guangya Liu
tps://reviews.apache.org/r/39492/#comment162044> indent? - Guangya Liu On 十月 23, 2015, 10:34 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39400: Quota: Implemented quota API.

2015-10-25 Thread Guangya Liu
e? Also when shall we need to add "" for one parameter in log message? - Guangya Liu On 十月 23, 2015, 4:38 p.m., Alexander Rukletsov wrote: > > --- > This is

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-10-25 Thread Guangya Liu
ce, why adding it to allocated? - Guangya Liu On 十月 23, 2015, 4:38 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-22 Thread Guangya Liu
> On 十月 22, 2015, 3:08 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 839 > > <https://reviews.apache.org/r/36913/diff/19/?file=1102864#file1102864line839> > > > > what about "return quotaHandler.create(request)" > > Joerg S

Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-22 Thread Guangya Liu
on_failure Thanks, Guangya Liu

Re: Review Request 39421: Add agent version to /master/slaves endpoint

2015-10-22 Thread Guangya Liu
ive": true, "attributes": {}, "hostname": "devstack007.cn.ibm.com", "id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0", "offered_resources": { "mem": 0, "disk": 0, "cpus": 0 }, "pid": "slave(1)@9.111.242.187:5051", "registered_time": 1445174743.70792, "reregistered_time": 1445174743.7085 } ] } Thanks, Guangya Liu

Review Request 39474: Make the Command Scheduler use the HTTP Scheduler Library

2015-10-22 Thread Guangya Liu
the Command Scheduler use the HTTP Scheduler Library Diffs - src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc Diff: https://reviews.apache.org/r/39474/diff/ Testing --- Thanks, Guangya Liu

Re: Review Request 39400: Quota: Implemented quota API.

2015-10-26 Thread Guangya Liu
> On 十月 25, 2015, 9:06 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 903 > > <https://reviews.apache.org/r/39400/diff/4/?file=1105059#file1105059line903> > > > > I see that in the code, some are using > > > >

Re: Review Request 39628: Clear the suppressed flag when deactive a framework

2015-10-25 Thread Guangya Liu
- Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review103957 --- On 十月 25, 2015, 2:38 a.m., Guangya

Re: Review Request 39432: Add /master/frameworks to master endpoint

2015-10-22 Thread Guangya Liu
atus": { "network_infos": [ { "ip_address": "9.111.242.187" } ] } } ], "state": "TASK_RUNNING", "slave_id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0", "resources": { "mem": 256, "disk": 0, "cpus": 1 }, "name": "cluster-test", "id": "cluster-test", "framework_id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-", "executor_id": "" } ] } ], "completed_frameworks": [] } Thanks, Guangya Liu

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-22 Thread Guangya Liu
--gtest_filter="ContentType/SchedulerTest.Suppress/*" --gtest_repeat=-1 --gtest_break_on_failure Thanks, Guangya Liu

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-22 Thread Guangya Liu
---------- On 十月 23, 2015, 2:32 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39548/ > ---

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-22 Thread Guangya Liu
="ContentType/SchedulerTest.Suppress/*" --gtest_repeat=-1 --gtest_break_on_failure Thanks, Guangya Liu

Re: Review Request 39507: Check message.empty() in Slave::shutdown before log it

2015-10-21 Thread Guangya Liu
e cannot. Will update this patch. - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39507/#review103430 --- On 十月 21, 2

Re: Review Request 39507: Check message.empty() in Slave::shutdown before log it

2015-10-21 Thread Guangya Liu
Diff: https://reviews.apache.org/r/39507/diff/ Testing --- Thanks, Guangya Liu

Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-21 Thread Guangya Liu
> On 十月 21, 2015, 1:51 a.m., Guangya Liu wrote: > > 3rdparty/libprocess/README.md, line 452 > > <https://reviews.apache.org/r/39453/diff/8/?file=1101276#file1101276line452> > > > > s/noting/nothing > > Greg Mann wrote: > Here, I'm saying so

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-21 Thread Guangya Liu
g/r/36913/#comment161564> what about "return quotaHandler.create(request)" src/master/http.cpp (line 843) <https://reviews.apache.org/r/36913/#comment161565> What about return quotaHandler.delete(request); It is better that the operation API can map to CRUD -

Re: Review Request 39432: Add /master/frameworks to master endpoint

2015-10-28 Thread Guangya Liu
! - Guangya Liu On 十月 23, 2015, 2:01 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39432/ > --

Re: Review Request 39421: Add agent version to /master/slaves endpoint

2015-10-28 Thread Guangya Liu
! - Guangya Liu On 十月 23, 2015, 12:17 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 39628: Clear the suppressed flag when deactive a framework

2015-10-28 Thread Guangya Liu
> On 十月 25, 2015, 2:51 p.m., Ben Mahler wrote: > > Can you please add a test that would have caught this issue? > > Guangya Liu wrote: > I think this is a bug, I tested without my code change, the test also > failed sometimes. Shall we file a bug for this?

Re: Review Request 39400: Quota: Implemented quota API.

2015-10-28 Thread Guangya Liu
tps://reviews.apache.org/r/39400/#comment162534> Alex, just want to get more for why do we need to add '' for role? I know that role is user supplied, but does role will contain whitespace? If not, I think that there is no need to add '' for role output, comments? Thanks! - Guangya Liu On

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106061 --- Ship it! Ship It! - Guangya Liu On 十一月 11, 2015, 5:59 a.m

Re: Review Request 40181: Corrected formatting in "hierarchical.cpp".

2015-11-11 Thread Guangya Liu
tps://reviews.apache.org/r/40181/#comment164769> Why moving the check here? This should be at the beginning of the function. - Guangya Liu On 十一月 11, 2015, 10:05 a.m., Alexander Rukletsov wrote: > > --- > This is an automatica

Re: Review Request 40179: Fixed a typo in a comment in the allocator.

2015-11-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40179/#review106043 --- Ship it! Ship It! - Guangya Liu On 十一月 11, 2015, 10:03 a.m

Re: Review Request 40180: Removed namespaces in "hierarchical.cpp".

2015-11-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40180/#review106044 --- Ship it! Ship It! - Guangya Liu On 十一月 11, 2015, 10:05 a.m

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Guangya Liu
org/r/40142/#comment164676> I see that we have some discussion in mail list, can you please add more detail for what we discussed in the "Description" section so that everyone will know how we order the include files in the future. - Guangya Liu On Nov. 10, 2015, 6:30 p.m., J

Re: Review Request 39223: Added Quota Request Validation Tests.

2015-11-08 Thread Guangya Liu
> On Nov. 8, 2015, 2:24 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, lines 209-210 > > <https://reviews.apache.org/r/39223/diff/7/?file=1118237#file1118237line209> > > > > Can you please make this comments limit in 70 per line

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-11-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105638 --- Ship it! Ship It! - Guangya Liu On Nov. 8, 2015, 11:06 p.m

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-11-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105640 --- Ship it! Ship It! - Guangya Liu On Nov. 8, 2015, 11:06 p.m

Re: Review Request 40005: Added principal field to /master/framework and /master/state endpoint.

2015-11-11 Thread Guangya Liu
aster/frameworks; 2>/dev/null| jq . | grep prin "principal": "p1", Thanks, Guangya Liu

Re: Review Request 40246: Removed unused "using" statement from test code.

2015-11-12 Thread Guangya Liu
own_tests.cpp (line 56) <https://reviews.apache.org/r/40246/#comment165118> remove? - Guangya Liu On 十一月 12, 2015, 6 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

2015-11-12 Thread Guangya Liu
g/r/40242/#comment165093> Not yours, but I have a question: currently, the HTTP endpoint for dynamic reservation request :, otherwise the request will be failed. In my understanding, we should enable the HTTP endpoint in the case the end user is not using anthentication? Comments? - Guang

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

2015-11-12 Thread Guangya Liu
tps://reviews.apache.org/r/40243/#comment165094> I think that the v1 part should also be updated - Guangya Liu On 十一月 12, 2015, 5:59 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 40245: Fixed typos in comments.

2015-11-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40245/#review106367 --- Ship it! Ship It! - Guangya Liu On 十一月 12, 2015, 5:59 p.m

Re: Review Request 40244: Clarified comments in Master::Http::_operation.

2015-11-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40244/#review106365 --- Ship it! Ship It! - Guangya Liu On 十一月 12, 2015, 5:59 p.m

Re: Review Request 39223: Added Quota Request Validation Tests.

2015-11-12 Thread Guangya Liu
rmat? https://github.com/apache/mesos/blob/master/src/tests/resources_tests.cpp#L331-L340 src/tests/master_quota_tests.cpp (lines 260 - 262) <https://reviews.apache.org/r/39223/#comment165092> ditto - Guangya Liu On 十一月 12, 2015, 3:22 p.m.,

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

2015-11-16 Thread Guangya Liu
org/r/40371/#comment165562> Can you please explain more why using mesos containerizer can also run a docker container? Thanks! - Guangya Liu On 十一月 17, 2015, 3:01 a.m., Jojy Varghese wrote: > > --- > This is an automatica

Re: Review Request 40291: Added the stye guideline for blank line after line-wrapping.

2015-11-16 Thread Guangya Liu
g/r/40291/#comment165552> Not yours, but why "more than one empty line inside classes"? Why not "one empty line"? I see that most of the elements inside classes using one empty line. - Guangya Liu On 十一月 16, 2015, 5:

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-11-16 Thread Guangya Liu
> On 十一月 16, 2015, 2:23 p.m., Joerg Schad wrote: > > src/tests/mesos.hpp, line 1245 > > > > > > This looks somehow weird... Who is satisfying the expect_call? I also have the same question, seems no one will

Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

2015-11-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40367/#review106779 --- Ship it! Ship It! - Guangya Liu On 十一月 16, 2015, 9:31 p.m

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

2015-11-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/#review106783 --- Ship it! Ship It! - Guangya Liu On 十一月 16, 2015, 3:49 p.m

Re: Review Request 40339: Added a flag to master to enable optimistic offers.

2015-11-16 Thread Guangya Liu
) --- Ubuntu 14.04 make make check Thanks, Guangya Liu

Re: Review Request 40329: Removed stale comment.

2015-11-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40329/#review106594 --- Ship it! Ship It! - Guangya Liu On Nov. 15, 2015, 4:26 p.m

Review Request 40339: Added a flag to master to enable optimistic offers.

2015-11-15 Thread Guangya Liu
/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 Diff: https://reviews.apache.org/r/40339/diff/ Testing --- Thanks, Guangya Liu

  1   2   3   4   5   6   7   8   9   10   >