012af0508eeceeccd168b29f36fa258d20b28c21
src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968
Diff: https://reviews.apache.org/r/37532/diff/
Testing
---
Thanks,
Guangya Liu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37512/#review95712
---
Ship it!
Ship It!
- Guangya Liu
On 八月 18, 2015, 3:08 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/#review95846
---
Ship it!
Ship It!
- Guangya Liu
On 八月 18, 2015, 6:32 p.m
:47 p.m., Guangya Liu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---
(Updated 八月 17, 2015, 1:47 p.m.)
Review
,
Guangya Liu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review96114
---
Ship it!
Ship It!
- Guangya Liu
On 八月 22, 2015, 6:10 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37176/#review95810
---
Ship it!
Ship It!
- Guangya Liu
On 八月 18, 2015, 6:57 p.m
/37180/#comment150947
I think the blank line can be removed
src/master/master.cpp (line 4841)
https://reviews.apache.org/r/37180/#comment150946
I think the blank line can be removed
- Guangya Liu
On 八月 18, 2015, 6:58 p.m., Joris Van Remoortere wrote
code, then
how to handle the case when mesos want to upgrade the 3rd party libraries?
- Guangya Liu
On 八月 18, 2015, 6:32 p.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/#review95802
---
Ship it!
Ship It!
- Guangya Liu
On 八月 18, 2015, 6:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37589/#review95808
---
Ship it!
Ship It!
- Guangya Liu
On 八月 18, 2015, 6:36 p.m
://reviews.apache.org/r/37177/#comment150949
Remove this blank space. The commit should not be permitted if there are
blank space in code.
- Guangya Liu
On 八月 18, 2015, 6:57 p.m., Joris Van Remoortere wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37208/#review95609
---
Ship it!
Ship It!
- Guangya Liu
On 八月 17, 2015, 6:50 a.m., Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37511/#review95559
---
Ship it!
Ship It!
- Guangya Liu
On 八月 16, 2015, 11:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37510/#review95554
---
Ship it!
Ship It!
- Guangya Liu
On 八月 16, 2015, 9:18 p.m
/37531/#comment150737
Does this logic still needed? I see that the taskTag logic should already
covered this?
src/messages/messages.proto (line 65)
https://reviews.apache.org/r/37531/#comment150736
I want some comments here for what is taskTag
- Guangya Liu
On Aug. 17, 2015, 1:28 p.m
/37512/#comment150739
s/Mesos master/Mesos Master
Also I think that we should make master unified in this document. Currently
there are master, Master, Mesos master, Mesos Master, we may want to
select one as the final name of master and apply to the whole document.
- Guangya Liu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review96138
---
Ship it!
Ship It!
- Guangya Liu
On 八月 12, 2015, 1:15 a.m., Jose
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37142/#review94318
---
Ship it!
LGTM
- Guangya Liu
On 八月 5, 2015, 9:22 p.m., Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37228/#review94913
---
Ship it!
Ship It!
- Guangya Liu
On 八月 7, 2015, 10:44 p.m
/#comment149063
Why not use the following?
return !out.get().empty();
- Guangya Liu
On 八月 6, 2015, 6:24 p.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37198/#review94485
---
Ship it!
LGTM
- Guangya Liu
On 八月 6, 2015, 8:37 p.m., Lily Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37196/#review94480
---
Ship it!
Ship It!
- Guangya Liu
On 八月 6, 2015, 9:27 p.m., Lily
include/mesos/scheduler/scheduler.proto
89daf8a6b74057ee156b3ad691397e76fcb835b8
src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21
src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca
Diff: https://reviews.apache.org/r/37257/diff/
Testing
---
Thanks,
Guangya
/noop.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37479/diff/
Testing
---
Thanks,
Guangya Liu
57883686c6e4333fc1a246a758e7dd861556d6fa
src/slave/qos_controllers/noop.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37479/diff/
Testing
---
Thanks,
Guangya Liu
/37244/#comment149216
I think that this change does not related to this RR, can you please handle
this in another RR? Thanks
- Guangya Liu
On 八月 8, 2015, 12:53 a.m., Vinod Kone wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review94631
---
Ship it!
Ship It!
- Guangya Liu
On 八月 7, 2015, 6:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37244/#review94632
---
Ship it!
Thanks for the update
- Guangya Liu
On 八月 8, 2015, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37254/#review94633
---
So you will add some test cases in another RR?
- Guangya Liu
012af0508eeceeccd168b29f36fa258d20b28c21
src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca
Diff: https://reviews.apache.org/r/37257/diff/
Testing
---
Thanks,
Guangya Liu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37254/#review94636
---
Ship it!
Ship It!
- Guangya Liu
On 八月 8, 2015, 3:30 p.m., Vinod
/scheduler.proto
89daf8a6b74057ee156b3ad691397e76fcb835b8
src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21
src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca
Diff: https://reviews.apache.org/r/37257/diff/
Testing
---
Thanks,
Guangya Liu
- Guangya Liu
On 八月 14, 2015, 2:01 a.m., José Guilherme Vanz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37468/
---
(Updated 八月
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37445/#review95419
---
Ship it!
Ship It!
- Guangya Liu
On 八月 13, 2015, 9:58 p.m., Neil
-
docs/submitting-a-patch.md 0221fe36f3f061b2f4ffe0fc4684420608f853b2
Diff: https://reviews.apache.org/r/36472/diff/
Testing
---
Thanks,
Guangya Liu
---
If the mesos master send only 1 offer, it should use offer but not
offers.
This patch is updating the offers to offer(s) to be more generic.
Diffs
-
src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d
Diff: https://reviews.apache.org/r/36441/diff/
Testing
---
Thanks,
Guangya Liu
/36321/#comment151698
Got it.
include/mesos/mesos.proto (line 939)
https://reviews.apache.org/r/36321/#comment151696
Thanks Joe! Got it, but I think that it is better that we can add some
notes here to be more clear
- Guangya Liu
On Aug. 25, 2015, 3:24 p.m., Joseph Wu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/#review96375
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 25, 2015, 2:13 a.m
/37358/#comment151699
Got it
- Guangya Liu
On Aug. 25, 2015, 5:03 p.m., Joseph Wu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37358
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37358/#review96369
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 25, 2015, 5:03 p.m
/r/36321/diff/11#0 is already covering this part and
also the time is using TimeSpec to be more accurate.
- Guangya Liu
On Aug. 25, 2015, 2:13 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review96382
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 25, 2015, 2:13 a.m
57883686c6e4333fc1a246a758e7dd861556d6fa
src/slave/qos_controllers/noop.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37479/diff/
Testing
---
Thanks,
Guangya Liu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96269
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 25, 2015, 12:14 a.m
://reviews.apache.org/r/37178/#comment151604
I think that the comments also needs to be updated to reflect inverse offer.
include/mesos/v1/scheduler/scheduler.proto (line 70)
https://reviews.apache.org/r/37178/#comment151605
ditto
- Guangya Liu
On 八月 18, 2015, 7:02 p.m., Joris Van Remoortere
.
include/mesos/mesos.proto (line 939)
https://reviews.apache.org/r/36321/#comment151598
Can you please elaborate more for why in maintaince purpose, this field is
always empty? Why cannot an operator set the resources that s/he want to
inverse?
- Guangya Liu
On 八月 24, 2015, 6:26 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/#review96266
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 24, 2015, 9:30 p.m
/r/37500/#comment151607
It is better to add some comments here.
i.e.
This message is sent to the slave to update framework user info for a slave.
src/slave/slave.cpp (line 2173)
https://reviews.apache.org/r/37500/#comment151608
Update the indent here
- Guangya Liu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96359
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 24, 2015, 6:33 p.m
--gtest_filter="ContentType/SchedulerTest.Suppress/*"
--gtest_repeat=-1 --gtest_break_on_failure
Thanks,
Guangya Liu
---
Thanks,
Guangya Liu
tps://reviews.apache.org/r/39614/#comment162043>
I see that most of the test cases are not using xx_xx to name the test
function, can we rename Status_EmptyQuota to StatusEmptyQuota?
Same question for all of the functions in this file.
- Guangya Liu
On 十月 24, 2015, 7:40 p.m., Joerg Schad
/quota_handler.cpp (line 237)
<https://reviews.apache.org/r/39492/#comment162041>
Can you please add a new test case for this? You can refer to
https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L1623-L1699
as a reference
- Guangya Liu
On 十月 23, 2015, 10:34 p.m., Joerg Schad
ews.apache.org/r/39223/#comment162050>
new line
- Guangya Liu
On 十月 23, 2015, 9:10 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To r
tps://reviews.apache.org/r/39492/#comment162044>
indent?
- Guangya Liu
On 十月 23, 2015, 10:34 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
e?
Also when shall we need to add "" for one parameter in log message?
- Guangya Liu
On 十月 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
>
> ---
> This is
ce, why adding it to allocated?
- Guangya Liu
On 十月 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
> On 十月 22, 2015, 3:08 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 839
> > <https://reviews.apache.org/r/36913/diff/19/?file=1102864#file1102864line839>
> >
> > what about "return quotaHandler.create(request)"
>
> Joerg S
on_failure
Thanks,
Guangya Liu
ive": true,
"attributes": {},
"hostname": "devstack007.cn.ibm.com",
"id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
"offered_resources": {
"mem": 0,
"disk": 0,
"cpus": 0
},
"pid": "slave(1)@9.111.242.187:5051",
"registered_time": 1445174743.70792,
"reregistered_time": 1445174743.7085
}
]
}
Thanks,
Guangya Liu
the Command Scheduler use the HTTP Scheduler Library
Diffs
-
src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc
Diff: https://reviews.apache.org/r/39474/diff/
Testing
---
Thanks,
Guangya Liu
> On 十月 25, 2015, 9:06 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 903
> > <https://reviews.apache.org/r/39400/diff/4/?file=1105059#file1105059line903>
> >
> > I see that in the code, some are using
> >
> >
- Guangya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/#review103957
---
On 十月 25, 2015, 2:38 a.m., Guangya
atus": {
"network_infos": [
{
"ip_address": "9.111.242.187"
}
]
}
}
],
"state": "TASK_RUNNING",
"slave_id": "3e0df733-08b3-4883-b3fa-92bdc0c05b2f-S0",
"resources": {
"mem": 256,
"disk": 0,
"cpus": 1
},
"name": "cluster-test",
"id": "cluster-test",
"framework_id": "820e082f-be7c-4b59-abc5-9c02f9e8d66d-",
"executor_id": ""
}
]
}
],
"completed_frameworks": []
}
Thanks,
Guangya Liu
--gtest_filter="ContentType/SchedulerTest.Suppress/*"
--gtest_repeat=-1 --gtest_break_on_failure
Thanks,
Guangya Liu
----------
On 十月 23, 2015, 2:32 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39548/
> ---
="ContentType/SchedulerTest.Suppress/*"
--gtest_repeat=-1 --gtest_break_on_failure
Thanks,
Guangya Liu
e cannot. Will
update this patch.
- Guangya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39507/#review103430
---
On 十月 21, 2
Diff: https://reviews.apache.org/r/39507/diff/
Testing
---
Thanks,
Guangya Liu
> On 十月 21, 2015, 1:51 a.m., Guangya Liu wrote:
> > 3rdparty/libprocess/README.md, line 452
> > <https://reviews.apache.org/r/39453/diff/8/?file=1101276#file1101276line452>
> >
> > s/noting/nothing
>
> Greg Mann wrote:
> Here, I'm saying so
g/r/36913/#comment161564>
what about "return quotaHandler.create(request)"
src/master/http.cpp (line 843)
<https://reviews.apache.org/r/36913/#comment161565>
What about return quotaHandler.delete(request);
It is better that the operation API can map to CRUD
-
!
- Guangya Liu
On 十月 23, 2015, 2:01 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39432/
> --
!
- Guangya Liu
On 十月 23, 2015, 12:17 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On 十月 25, 2015, 2:51 p.m., Ben Mahler wrote:
> > Can you please add a test that would have caught this issue?
>
> Guangya Liu wrote:
> I think this is a bug, I tested without my code change, the test also
> failed sometimes. Shall we file a bug for this?
tps://reviews.apache.org/r/39400/#comment162534>
Alex, just want to get more for why do we need to add '' for role? I know
that role is user supplied, but does role will contain whitespace? If not, I
think that there is no need to add '' for role output, comments? Thanks!
- Guangya Liu
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40177/#review106061
---
Ship it!
Ship It!
- Guangya Liu
On 十一月 11, 2015, 5:59 a.m
tps://reviews.apache.org/r/40181/#comment164769>
Why moving the check here? This should be at the beginning of the function.
- Guangya Liu
On 十一月 11, 2015, 10:05 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40179/#review106043
---
Ship it!
Ship It!
- Guangya Liu
On 十一月 11, 2015, 10:03 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40180/#review106044
---
Ship it!
Ship It!
- Guangya Liu
On 十一月 11, 2015, 10:05 a.m
org/r/40142/#comment164676>
I see that we have some discussion in mail list, can you please add more
detail for what we discussed in the "Description" section so that everyone will
know how we order the include files in the future.
- Guangya Liu
On Nov. 10, 2015, 6:30 p.m., J
> On Nov. 8, 2015, 2:24 a.m., Guangya Liu wrote:
> > src/tests/master_quota_tests.cpp, lines 209-210
> > <https://reviews.apache.org/r/39223/diff/7/?file=1118237#file1118237line209>
> >
> > Can you please make this comments limit in 70 per line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review105638
---
Ship it!
Ship It!
- Guangya Liu
On Nov. 8, 2015, 11:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review105640
---
Ship it!
Ship It!
- Guangya Liu
On Nov. 8, 2015, 11:06 p.m
aster/frameworks; 2>/dev/null| jq . | grep prin
"principal": "p1",
Thanks,
Guangya Liu
own_tests.cpp (line 56)
<https://reviews.apache.org/r/40246/#comment165118>
remove?
- Guangya Liu
On 十一月 12, 2015, 6 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply
tps://reviews.apache.org/r/40243/#comment165094>
I think that the v1 part should also be updated
- Guangya Liu
On 十一月 12, 2015, 5:59 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40245/#review106367
---
Ship it!
Ship It!
- Guangya Liu
On 十一月 12, 2015, 5:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40244/#review106365
---
Ship it!
Ship It!
- Guangya Liu
On 十一月 12, 2015, 5:59 p.m
rmat?
https://github.com/apache/mesos/blob/master/src/tests/resources_tests.cpp#L331-L340
src/tests/master_quota_tests.cpp (lines 260 - 262)
<https://reviews.apache.org/r/39223/#comment165092>
ditto
- Guangya Liu
On 十一月 12, 2015, 3:22 p.m.,
org/r/40371/#comment165562>
Can you please explain more why using mesos containerizer can also run a
docker container? Thanks!
- Guangya Liu
On 十一月 17, 2015, 3:01 a.m., Jojy Varghese wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40367/#review106779
---
Ship it!
Ship It!
- Guangya Liu
On 十一月 16, 2015, 9:31 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40345/#review106783
---
Ship it!
Ship It!
- Guangya Liu
On 十一月 16, 2015, 3:49 p.m
)
---
Ubuntu 14.04
make
make check
Thanks,
Guangya Liu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40329/#review106594
---
Ship it!
Ship It!
- Guangya Liu
On Nov. 15, 2015, 4:26 p.m
/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d
src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1
Diff: https://reviews.apache.org/r/40339/diff/
Testing
---
Thanks,
Guangya Liu
/
Testing
---
Thanks,
Guangya Liu
> On Nov. 3, 2015, 5:52 a.m., Guangya Liu wrote:
> > src/master/quota_handler.cpp, lines 159-186
> > <https://reviews.apache.org/r/38110/diff/10/?file=1114101#file1114101line159>
> >
> > How to handle the following cases? Say two roles request quota: r1 and
> On Nov. 10, 2015, 10:41 p.m., Guangya Liu wrote:
> > src/tests/containerizer.hpp, line 19
> > <https://reviews.apache.org/r/40142/diff/4/?file=1122006#file1122006line19>
> >
> > I see that we have some discussion in mail list, can you please add
>
> On Oct. 25, 2015, 2:51 p.m., Ben Mahler wrote:
> > Can you please add a test that would have caught this issue?
>
> Guangya Liu wrote:
> I think this is a bug, I tested without my code change, the test also
> failed sometimes. Shall we file a bug for this?
1 - 100 of 2467 matches
Mail list logo
