Re: Review Request 56174: Added skipping already stored layers to local Docker puller.

verifying that local puller will skip layes that are already in the store. Ran `make check`. Thanks, Ilya Pronin

Review Request 56291: Removed unnecessary mkdirs in ProvisionerDockerLocalStoreTest.*.

/provisioner_docker_tests.cpp af9987f88205d00d091f35fa734d5667506aaffd Diff: https://reviews.apache.org/r/56291/diff/ Testing --- `make check` Thanks, Ilya Pronin

Re: Review Request 56174: Added skipping already stored layers to local Docker puller.

enerated e-mail. To reply, visit: https://reviews.apache.org/r/56174/#review163930 ------- On Feb. 3, 2017, 6:07 p.m., Ilya Pronin wrote: > > --- > This is an automatically generated e-mai

Review Request 56284: Added ProvisionerDockerLocalStoreTest.SkippedLayers test.

af9987f88205d00d091f35fa734d5667506aaffd Diff: https://reviews.apache.org/r/56284/diff/ Testing --- `make check` Thanks, Ilya Pronin

Review Request 56174: Added skipping already stored layers to local Docker puller.

/docker/local_puller.cpp ee391af898886bff9e5b911697f725c5ea53ebd8 Diff: https://reviews.apache.org/r/56174/diff/ Testing --- `make check` Thanks, Ilya Pronin

Re: Review Request 56368: Libprocess: Windows: Remove `CREATE_JOB` parent hook.

()` in `subprocess_base.hpp` should also be removed. - Ilya Pronin On Feb. 7, 2017, 2:31 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 56362: Windows: Create the `WindowsLauncher`.

tps://reviews.apache.org/r/56362/#comment236262> I think it would be better to leave `__linux__` check in place. There's no systemd on macOS or FreeBSD. src/slave/containerizer/mesos/windows_launcher.cpp (line 105) <https://reviews.apache.org/r/56362/#comment236264> Systemd on Windows?

Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.MissingLayer test.

ted this test that is simpler and less fragile and exercises the skipping layers code. - Ilya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56284/#review164539 ---

Re: Review Request 56174: Added skipping already stored layers to local Docker puller.

il. To reply, visit: https://reviews.apache.org/r/56174/#review164257 ------- On Feb. 3, 2017, 6:07 p.m., Ilya Pronin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56174/ &

Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.MissingLayer test.

/containerizer/provisioner_docker_tests.cpp 99e0820fa47303896f70c81cfb91cd34f0474e55 Diff: https://reviews.apache.org/r/56284/diff/ Testing --- `make check` Thanks, Ilya Pronin

Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.MissingLayer test.

://reviews.apache.org/r/56284/diff/ Testing --- `make check` Thanks, Ilya Pronin

Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.SkippedLayers test.

-------- On Feb. 4, 2017, 6:37 p.m., Ilya Pronin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56284/ >

Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.SkippedLayers test.

af9987f88205d00d091f35fa734d5667506aaffd Diff: https://reviews.apache.org/r/56284/diff/ Testing --- `make check` Thanks, Ilya Pronin

Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.SkippedLayers test.

af9987f88205d00d091f35fa734d5667506aaffd Diff: https://reviews.apache.org/r/56284/diff/ Testing --- `make check` Thanks, Ilya Pronin

Re: Review Request 56087: Simplified AppC provisioner cache keys hashing.

fed5ae97419d5eb9611a6fd1ade1bbed7ed440a2 Diff: https://reviews.apache.org/r/56087/diff/ Testing --- `make check` Thanks, Ilya Pronin

Re: Review Request 56086: Simplified AppC provisioner cache keys comparison.

comparison. Diffs - src/slave/containerizer/mesos/provisioner/appc/cache.cpp fed5ae97419d5eb9611a6fd1ade1bbed7ed440a2 Diff: https://reviews.apache.org/r/56086/diff/ Testing --- `make check` Thanks, Ilya Pronin

Re: Review Request 56087: Simplified AppC provisioner cache keys hashing.

ort/post-reviews.py`. Done. Thanks! - Ilya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56087/#review163852 -------

Re: Review Request 55770: Fixed navbar and logo size in WebUI.

> On Jan. 20, 2017, 3:18 p.m., haosdent huang wrote: > > src/webui/master/static/index.html, line 33 > > <https://reviews.apache.org/r/55770/diff/1/?file=1610638#file1610638line33> > > > > How about add class `.img-responsive` directly? > > Ilya Pronin

Review Request 56086: Simplified AppC provisioner cache keys comparison.

fed5ae97419d5eb9611a6fd1ade1bbed7ed440a2 Diff: https://reviews.apache.org/r/56086/diff/ Testing --- `make check` Thanks, Ilya Pronin

Review Request 56087: Simplified AppC provisioner cache keys hashing.

` Thanks, Ilya Pronin

Review Request 55766: Fixed body padding in mobile WebUI.

c817aaee0fd2d2579ff2e4a152d47e83ce80d68c Diff: https://reviews.apache.org/r/55766/diff/ Testing --- Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1. Thanks, Ilya Pronin

Re: Review Request 56889: Added setting volume mode and ownership in LinuxFilesystemIsolator.

/ Testing --- Added permissions and ownerchip check to `LinuxFilesystemIsolatorTest.ROOT_VolumeFromSandbox`. Ran `make check`. Thanks, Ilya Pronin

Review Request 56889: Added setting volume mode and ownership in LinuxFilesystemIsolator.

check`. Thanks, Ilya Pronin

Re: Review Request 56657: Add support for local resolution of Docker images.

t; Looks like this test does exactly the same as `ProvisionerDockerLocalStoreTest.MetadataManagerInitialization`. The new code is exercised in `LocalStoreTestWithMapping`. Since we don't inspect `MetadataManager` directly maybe having that test would be sufficient? - Ilya Pronin On Feb.

Re: Review Request 55637: CMake: Added `test` target.

> On Jan. 17, 2017, 8:46 p.m., Ilya Pronin wrote: > > I think the name "test" can confuse people because it's usually expected to > > be used for CTest. Maybe it would better be leave old {{tests}} and > > {{check}} targets? https://cmake.org/Wiki/CMakeEmulateMa

Re: Review Request 53850: Implemented fetching Docker images that have V2 schema 2 manifests.

/r/53850/diff/ Testing --- Added test to verify that V2 schema 2 image manifest can be pulled with all image blobs. Modified previously added "pull image by digest" test to pull an image that has schema 2 manifest. Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 53849: Added parsing of V2 schema 2 Docker image manifests.

check`. Thanks, Ilya Pronin

Re: Review Request 55637: CMake: Added `test` target.

's usually expected to be used for CTest. Maybe it would better be leave old {{tests}} and {{check}} targets? https://cmake.org/Wiki/CMakeEmulateMakeCheck - Ilya Pronin On Jan. 17, 2017, 7:33 p.m., Alex Cle

Re: Review Request 53849: Added parsing of V2 schema 2 Docker image manifests.

`make check`. Thanks, Ilya Pronin

Re: Review Request 55637: CMake: Added `test` target.

> On Jan. 17, 2017, 8:46 p.m., Ilya Pronin wrote: > > I think the name "test" can confuse people because it's usually expected to > > be used for CTest. Maybe it would better be leave old {{tests}} and > > {{check}} targets? https://cmake.org/Wiki/CMakeEmulateMa

Review Request 55770: Fixed navbar and logo size in WebUI.

/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42 Diff: https://reviews.apache.org/r/55770/diff/ Testing --- Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1. Thanks, Ilya Pronin

Re: Review Request 55770: Fixed navbar and logo size in WebUI.

ied, that didn't work :( - Ilya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55770/#review162428 --- On Jan. 20, 2

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

, Ilya Pronin

Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

/ Testing --- `make check` on OS X 10.11 and Ubuntu 14.04. Thanks, Ilya Pronin

Re: Review Request 52162: Fixed Python bindings build error caused by custom SVN location.

) Done. I'm not a native speaker either so I used your wording :) - Ilya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52162/#review151509 --------

Re: Review Request 52162: Fixed Python bindings build error caused by custom SVN location.

Diff: https://reviews.apache.org/r/52162/diff/ Testing --- ``` ../configure --with-svn=$HOME/svn && make && make check ``` Thanks, Ilya Pronin

Re: Review Request 52162: Fixed Python bindings build error caused by custom SVN location.

variable captures all required LDFLAGS. Diffs - configure.ac 8f971c96bfea0afd7462ea9b91c69458324435b6 Diff: https://reviews.apache.org/r/52162/diff/ Testing --- ``` ../configure --with-svn=$HOME/svn && make && make check ``` Thanks, Ilya Pronin

Review Request 52162: Fixed Python bindings build error caused by custom SVN location.

&& make && make check ``` Thanks, Ilya Pronin

Re: Review Request 52162: Fixed Python bindings build error caused by custom SVN location.

captures all required LDFLAGS. Diffs - configure.ac 57482d39db1f83e92e75fca959cd6df329a1c24f Diff: https://reviews.apache.org/r/52162/diff/ Testing --- ``` ../configure --with-svn=$HOME/svn && make && make check ``` Thanks, Ilya Pronin

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

iew151890 ------- On Oct. 10, 2016, 8:18 p.m., Ilya Pronin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52620/ >

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

to this change and is reproducible on current master. Thanks, Ilya Pronin

Re: Review Request 53009: Add support for task labels to example no_executor_framework.

127 - 137) <https://reviews.apache.org/r/53009/#comment222526> Since currently task labels are simply copied into `TaskInfo` they can be baked into `Labels` outside of `NoExecutorScheduler`. But here this is more a style preference, feel free to drop. - Ilya Pronin On Oct. 19, 2016

Review Request 54081: Added `--pidfile` option to master and agent binaries.

src/tests/common/pid_file_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/54081/diff/ Testing --- Added test to verify that PID file is created upon `PIDFile` object creation and deleted upon its destruction. Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 53849: Added parsing of V2 schema 2 Docker image manifests.

82bddd228df3db95a00eb277ff9c380039b70b1e Diff: https://reviews.apache.org/r/53849/diff/ Testing --- Added tests to verify that V2 schema 2 image manifest can be successfully parsed and errors like missing required fields or empty layers list are caught. Ran `make check`. Thanks, Ilya

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

and deleted upon its destruction. Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 53849: Added parsing of V2 schema 2 Docker image manifests.

required fields or empty layers list are caught. Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

destruction. Ran `make check`. Thanks, Ilya Pronin

Review Request 53848: Added support for pulling Docker images by digest.

/docker.cpp 3f38dddfb4c089322fe4e13b1ef2070b4835885c Diff: https://reviews.apache.org/r/53848/diff/ Testing --- Added a test to verify that an image that has V2 schema 1 manifest can be pulled from the repository by digest. Ran `make check`. Thanks, Ilya Pronin

Review Request 53849: Added parsing of V2 schema 2 Docker image manifests.

image manifest can be successfully parsed and errors like missing required fields or empty layers list are caught. Ran `make check`. Thanks, Ilya Pronin

Review Request 53879: Removed duplicate note.

--- Removed duplicate note. Diffs - src/logging/logging.cpp c7ac957a9c01f93a4ed852cd26d7f2cc8e70c78e Diff: https://reviews.apache.org/r/53879/diff/ Testing --- Thanks, Ilya Pronin

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

by forked processes. What do you think? - Ilya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54081/#review158240 --- On No

Review Request 54587: Introduce a ScaleTestContainerizer suitable for scale testing.

ot;. Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

mplement the locking > > aspect of this (as that seems necessary for this to be safely usable?) > > > > We could structure the patches like this: > > > > (1) Addition of pidfile utilities to stout. > > (2) Tests of the pidfile utilities in stout (should be possib

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

mplement the locking > > aspect of this (as that seems necessary for this to be safely usable?) > > > > We could structure the patches like this: > > > > (1) Addition of pidfile utilities to stout. > > (2) Tests of the pidfile utilities in stout (should be possib

Re: Review Request 54587: Introduce a ScaleTestContainerizer suitable for scale testing.

://reviews.apache.org/r/54587/diff/ Testing --- Added a test to verify that `TASK_RUNNING` and `TASK_KILLED` statuses are reported upon task "launching" and "killing". Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 54587: Introduced a ScaleTestContainerizer suitable for scale testing.

/containerizer/scale_test_containerizer_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/54587/diff/ Testing --- Added a test to verify that `TASK_RUNNING` and `TASK_KILLED` statuses are reported upon task "launching" and "killing". Ran `make check`. Thanks, Ilya Pronin

Review Request 54167: Removed cyclic header dependency in libprocess.

--- ``` make && make check ``` Thanks, Ilya Pronin

Re: Review Request 54167: Removed cyclic header dependency in libprocess.

48c1b34b6bd117653c1728321cf96b909e535964 Diff: https://reviews.apache.org/r/54167/diff/ Testing --- ``` make && make check ``` Thanks, Ilya Pronin

Re: Review Request 55177: Fixed scheme handling in URL::parse().

iew160648 --- On Jan. 6, 2017, 11:37 a.m., Ilya Pronin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 55177: Fixed scheme handling in URL::parse().

97d1424be20e217401519c2bee79857bcf087023 3rdparty/libprocess/src/tests/http_tests.cpp d168ad15da4706fb9c3aa11a125b7dfb5987570d Diff: https://reviews.apache.org/r/55177/diff/ Testing --- Added a test case demonstrating the problem. Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 54873: Added asynchronous libcurl support to Mesos.

herwise. I think it will be better to drop this `break`. src/curl/common.cpp (line 446) <https://reviews.apache.org/r/54873/#comment231739> Ditto as on line 443. - Ilya Pronin On Dec. 26, 2016, 1:41 a.m., Jie Yu wrote: > >

Review Request 55177: Fixed scheme handling in URL::parse().

d168ad15da4706fb9c3aa11a125b7dfb5987570d Diff: https://reviews.apache.org/r/55177/diff/ Testing --- Added a test case demonstrating the problem. Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 54873: Added asynchronous libcurl support to Mesos.

> On Dec. 26, 2016, 8:59 a.m., Avinash sridharan wrote: > > src/curl/common.cpp, line 241 > > > > > > Why is this `else` condition only possible if the function is called > > from a timer callback. From the man

Re: Review Request 57425: Added pull method to Containerizer.

/57425/diff/2/ Changes: https://reviews.apache.org/r/57425/diff/1-2/ Testing --- Added `MesosContainerizerProvisionerTest.PullImage` test verifying that `MesosContainerizer` calls the required `Store` method. Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 57427: Added authorization for PULL_CONTAINER_IMAGE agent API call.

` and `AgentAPITest.PullContainerImageUnauthorized` tests. Ran `make check`. Verified manually by starting the agent with `--authenticate_http_readwrite` and sending a call with curl as a principal that is allowed to `pull_container_image`. Thanks, Ilya Pronin

Re: Review Request 57426: Added PULL_CONTAINER_IMAGE agent API call.

` test. Ran `make check`. Verified manually by sending a call curl. Thanks, Ilya Pronin

Review Request 57689: Replaced Boost Type Traits with STL in Stout.

&& make check` with Clang (OS X 10.11.6) and GCC 4.8.5 Thanks, Ilya Pronin

Review Request 57690: Replaced Boost Type Traits with STL in libprocess.

--- `make && make check` with Clang (OS X 10.11.6) and GCC 4.8.5 Thanks, Ilya Pronin

Review Request 57691: Enabled AsyncExecutorProcess::execute() via a template parameter.

://reviews.apache.org/r/57691/diff/1/ Testing --- `make && make check` with Clang (OS X 10.11.6) and GCC 4.8.5 Thanks, Ilya Pronin

Review Request 58355: Removed unnecessary Registry copying.

^2) because of lookup, hence 2 mins. Unit Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 58355: Removed unnecessary Registry copying.

in 264.850688ms Removed 5 agents in 2.12256788111667mins ``` Agents removal seems to be O(n^2) because of linear lookup, hence 2 mins. Unit Ran `make check`. Thanks, Ilya Pronin

Review Request 58421: Passed `--zk_session_timeout` to ZK master contender and detector.

:67863(0x70934000):ZOO_INFO@check_events@1775: session establishment complete on server [192.168.99.100:2181], sessionId=0x15b67b0efd3000f, negotiated timeout=2 ``` Thanks, Ilya Pronin

Re: Review Request 58421: Passed `--zk_session_timeout` to ZK master contender and detector.

establishment complete on server [192.168.99.100:2181], sessionId=0x15b67b0efd3000f, negotiated timeout=2 ``` Thanks, Ilya Pronin

Re: Review Request 58421: Passed `--zk_session_timeout` to ZK master contender and detector.

ditto. see above. As with `ZooKeeperMasterContender` constructors without `sessionTimeout` are used in tests. Default value can be left for convenience. - Ilya --- This is an automatically generated e-mail. To r

Review Request 57426: Added PULL_CONTAINER_IMAGE agent API call.

/api_tests.cpp 52f58a4d6b1ea75744de1c3d2f0f064d9299fe1d Diff: https://reviews.apache.org/r/57426/diff/1/ Testing --- Added `AgentAPITest.PullContainerImage` test. Ran `make check`. Verified manually by sending a call curl. Thanks, Ilya Pronin

Review Request 57427: Added authorization for PULL_CONTAINER_IMAGE agent API call.

` and sending a call with curl as a principal that is allowed to `pull_container_image`. Thanks, Ilya Pronin

Review Request 57425: Added pull method to Containerizer.

verifying that `MesosContainerizer` calls the required `Store` method. Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

mplement the locking > > aspect of this (as that seems necessary for this to be safely usable?) > > > > We could structure the patches like this: > > > > (1) Addition of pidfile utilities to stout. > > (2) Tests of the pidfile utilities in stout (should be possib

Review Request 58506: Updated the high availability doc about ZK session timeout.

/A Thanks, Ilya Pronin

Re: Review Request 58355: Removed unnecessary Registry copying.

il 18, 2017, 12:21 a.m., Benjamin Mahler wrote: > > src/master/registrar.cpp > > Lines 449-450 (original), 464-465 (patched) > > <https://reviews.apache.org/r/58355/diff/1/?file=1688435#file1688435line465> > > > > Should we say we use an Owned here to avoid copy

Re: Review Request 58355: Removed unnecessary Registry copying.

registry in 264.850688ms Removed 5 agents in 2.12256788111667mins ``` Agents removal seems to be O(n^2) because of linear lookup, hence 2 mins. Unit Ran `make check`. Thanks, Ilya Pronin

Re: Review Request 61123: Added regression test for sandbox volume ownership issue.

> On July 26, 2017, 7:08 p.m., Ilya Pronin wrote: > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > > Lines 252-255 (patched) > > <https://reviews.apache.org/r/61123/diff/1/?file=1782381#file1782381line252> > > > > Why do we need D

Re: Review Request 61120: Fixed the sandbox_path volume source path ownership.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61120/#review181659 --- Ship it! LGTM! - Ilya Pronin On July 28, 2017, 2:42 a.m

Re: Review Request 61121: Added regression test for sandbox_path volume ownership issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61121/#review181661 --- Ship it! Ship It! - Ilya Pronin On July 28, 2017, 2:43 a.m

Re: Review Request 60508: Fixed Attributes comparison.

: https://reviews.apache.org/r/60508/diff/1-2/ Testing --- Added a test to `AttributesTest.Equality`. Ran `make check`. Verified manually by failing over the agent with multiple attributes with the same name. Thanks, Ilya Pronin

Review Request 61662: Added SlaveRecoveryTest.RebootWithSlaveInfoMismatchAndRestart test.

- src/tests/slave_recovery_tests.cpp 9ba6f6005c2edce67e1f63005518ab71ac981423 Diff: https://reviews.apache.org/r/61662/diff/1/ Testing --- Ran `make check`. Verified that this test fails without the bugfix patch. Thanks, Ilya Pronin

Review Request 61661: Added 'latest' symlink removal.

/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b Diff: https://reviews.apache.org/r/61661/diff/1/ Testing --- Ran `make check`. A new test is added in the subsequent patch. Thanks, Ilya Pronin

Review Request 61690: Added `--zk_session_timeout` flag for agent.

@check_events@1775: session establishment complete on server [192.168.99.100:2181], sessionId=0x15de6c7f8920001, negotiated timeout=2 ``` Thanks, Ilya Pronin

Review Request 61689: Removed duplicate using directive.

://issues.apache.org/jira/browse/MESOS-7895 Repository: mesos Description --- Removed duplicate using directive. Diffs - src/slave/main.cpp a4a8ced6825ece1b25003824d987ff83fb799ad7 Diff: https://reviews.apache.org/r/61689/diff/1/ Testing --- `make check` Thanks, Ilya Pronin

Re: Review Request 60203: Introduce HTB class.

/htb.cpp Line 136 (original), 127 (patched) <https://reviews.apache.org/r/60203/#comment255624> This seems to be unused. - Ilya Pronin On July 1, 2017, 12:01 a.m., Ian Downes wrote: > > --- > This is an automatically g

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/#review180436 --- Ship it! Ship It! - Ilya Pronin On July 1, 2017, midnight

Re: Review Request 61123: Added regression test for host volume ownership issue.

> On July 26, 2017, 7:08 p.m., Ilya Pronin wrote: > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > > Lines 252-255 (patched) > > <https://reviews.apache.org/r/61123/diff/1/?file=1782381#file1782381line252> > > > > Why do we need D

Re: Review Request 61123: Added regression test for host volume ownership issue.

. src/tests/containerizer/linux_filesystem_isolator_tests.cpp Lines 252-255 (patched) <https://reviews.apache.org/r/61123/#comment257073> Why do we need Docker for this test? The problem should be reproducible without it. - Ilya Pronin On July 26, 2017, 12:05 a.m., Gilbert Song

Re: Review Request 61122: Fixed the host volume relative host path ownership.

/filesystem/linux.cpp Line 487 (original), 502 (patched) <https://reviews.apache.org/r/61122/#comment257055> Do we call this a host volume as well? We're creating it in the container sandbox. - Ilya Pronin On July 26, 201

Re: Review Request 60003: Reduced copying in defer, dispatch and Future.

could store `f` value and `pid` in a structure, that will be captured by a `std::shared_ptr`. 3rdparty/libprocess/include/process/dispatch.hpp Lines 203-205 (patched) <https://reviews.apache.org/r/60003/#comment254244> Style: `Dispatcher` internals are overindented. Here and in other places

Review Request 60508: Fixed Attributes comparison.

over the agent with multiple attributes with the same name. Thanks, Ilya Pronin

Re: Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.

JSON first and checking `schemaVersion` field in it as I did here: https://reviews.apache.org/r/53850/diff/1#0 Otherwise we may get a cryptic error message saying that some fields are missing. What do you think? - Ilya Pronin On April 26, 2017, 8:14 p.m., Gilbert Song wrote

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

> On April 27, 2017, 1:46 a.m., Jie Yu wrote: > > Do you know if an old registry (< 2.3) will be OK with this header that it > > does not understand? Can you confirm? Shall we include all content types that we currently support? (Can be splitted into multiple `Accept` fields) ``` Accept:

Re: Review Request 60508: Fixed Attributes comparison.

ps://reviews.apache.org/r/60508/#review182010 ------- On Aug. 3, 2017, 1:11 p.m., Ilya Pronin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

Bytes()` constructor here. The result of `max()` here is already `Bytes`. src/slave/containerizer/mesos/isolators/network/port_mapping.cpp Lines 4188 (patched) <https://reviews.apache.org/r/59294/#comment248447> Ditto. - Ilya Pronin On May 15, 2017, 9:56 p.m., Ian Downes wrote

  1   2   3   >