Re: Review Request 29748: Added tests for dynamic reservation.

2015-04-23 Thread Jie Yu
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/ --- (Updated April 8, 2015, 5:05 p.m.) Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-04-22 Thread Jie Yu
On April 21, 2015, 11:25 p.m., Jie Yu wrote: src/slave/slave.cpp, lines 3065-3078 https://reviews.apache.org/r/33249/diff/3/?file=938221#file938221line3065 Instead of doing that in your way, can we just try to make sure `containerizer-wait` here will return a failure

Re: Review Request 33040: Expose qdisc statistics from libnl

2015-04-24 Thread Jie Yu
of the sentense. src/tests/routing_tests.cpp https://reviews.apache.org/r/33040/#comment131887 Could you please remove these prints? src/tests/routing_tests.cpp https://reviews.apache.org/r/33040/#comment131888 Ditto on removal. - Jie Yu On April 24, 2015, 5:46 p.m., Paul Brett wrote

Re: Review Request 33414: Made MesosContainerizer not fail on recovery if the destroy of orphan containers fails.

2015-04-24 Thread Jie Yu
: https://reviews.apache.org/r/33414/#review81532 --- On April 21, 2015, 9:46 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 33459: Fix containerizers to only recover containers they would launch.

2015-04-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33459/#review81251 --- Subsumed by this https://reviews.apache.org/r/33257? - Jie Yu

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-04-22 Thread Jie Yu
On April 21, 2015, 11:25 p.m., Jie Yu wrote: src/slave/slave.cpp, lines 3065-3078 https://reviews.apache.org/r/33249/diff/3/?file=938221#file938221line3065 Instead of doing that in your way, can we just try to make sure `containerizer-wait` here will return a failure

Re: Review Request 33647: Only log processes in the slave cgroup on recovery.

2015-04-28 Thread Jie Yu
/#comment132436 Can you also comment on what the consequence of having those processes left in slave's cgroup? Maybe add a TODO here to address that? - Jie Yu On April 28, 2015, 11:33 p.m., Ian Downes wrote

Re: Review Request 33644: MemoryTestHelper: Changed to do memset before mlock.

2015-04-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33644/#review81899 --- Ship it! Ship It! - Jie Yu On April 28, 2015, 11 p.m., Chi

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-04-29 Thread Jie Yu
On April 8, 2015, 9:19 p.m., Jie Yu wrote: src/common/resources.cpp, line 663 https://reviews.apache.org/r/32149/diff/4/?file=920084#file920084line663 Do you need to call validate(operation.reserve().resources()) first (like we did in CREATE/DESTROY)? Do you also want to check

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-01 Thread Jie Yu
On April 21, 2015, 11:25 p.m., Jie Yu wrote: src/slave/slave.cpp, lines 3065-3078 https://reviews.apache.org/r/33249/diff/3/?file=938221#file938221line3065 Instead of doing that in your way, can we just try to make sure `containerizer-wait` here will return a failure

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-04 Thread Jie Yu
On April 23, 2015, 1:48 p.m., Michael Park wrote: As of now, the tests seem to take a long time to complete. We should investigate what the issue is before committing this patch. Jie Yu wrote: I suspect this is due to the default allocation interval (1 secs by default). Ping

Re: Review Request 33746: Improve logging of clone flags for linux_launcher.

2015-05-01 Thread Jie Yu
, CLONE_NEWNET}, ... } std::vectorstd::string namespaces; foreachpair (int flag, const std::string name, names) { if (clone flag) { namespaces.push_back(name); } } return strings::join( | , namesapces); ``` - Jie Yu On May 1, 2015, 5:27 a.m., Ian

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-04-29 Thread Jie Yu
a boolean, can you pass an Optionstring principal as you did in `validate(reserve)`? src/tests/master_validation_tests.cpp https://reviews.apache.org/r/32150/#comment132685 One extra blank line here please. - Jie Yu On April 28, 2015, 10:43 p.m., Michael Park wrote

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-04-29 Thread Jie Yu
On April 8, 2015, 10:38 p.m., Jie Yu wrote: src/master/validation.cpp, lines 581-584 https://reviews.apache.org/r/32150/diff/5/?file=920955#file920955line581 Is this necessary, or will be captured by the resources contains check later? Michael Park wrote: It probably

Review Request 33631: Fixed a bug in port mapping isolator which will cause SIGABRT during slave recovery.

2015-04-28 Thread Jie Yu
24cb4ba69c463fb7d2bba0786474fc8a14c92ea0 Diff: https://reviews.apache.org/r/33631/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 33935: Improved HTTP request logging for master/slave endpoints.

2015-05-07 Thread Jie Yu
On May 7, 2015, 5:40 p.m., Jie Yu wrote: src/master/master.cpp, lines 732-735 https://reviews.apache.org/r/33935/diff/1/?file=952157#file952157line732 Why do you need to capture `this`? Http::log is a static function, I don't think you need to capture `this`. Capture

Re: Review Request 31504: Add a basic filter to match all packets

2015-05-07 Thread Jie Yu
On May 7, 2015, 10:03 p.m., Jie Yu wrote: src/linux/routing/filter/basic.cpp, lines 95-98 https://reviews.apache.org/r/31504/diff/5/?file=950511#file950511line95 Should you pass a `protocol` as well to the `exists` function? ``` Trybool exists(link, parent

Re: Review Request 31504: Add a basic filter to match all packets

2015-05-07 Thread Jie Yu
Ditto. Please pass in a `protocol` src/linux/routing/filter/basic.cpp https://reviews.apache.org/r/31504/#comment133766 Ditto here. - Jie Yu On May 5, 2015, 6:37 p.m., Cong Wang wrote: --- This is an automatically generated e

Re: Review Request 33935: Improved HTTP request logging for master/slave endpoints.

2015-05-07 Thread Jie Yu
/#comment133756 Forgot this one? - Jie Yu On May 7, 2015, 9:53 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33935

Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-06 Thread Jie Yu
check Thanks, Jie Yu

Re: Review Request 33876: Added usages() to resource monitor

2015-05-06 Thread Jie Yu
We usually put onXXX at the end of the chain: ``` containerizer-usage(...) .then(...) .onFailed(...); ``` Also, could you please move the continuation `_usage` below? - Jie Yu On May 6, 2015, 4:01 p.m., Niklas Nielsen wrote

Re: Review Request 32398: Persisted the reservation state on the slave.

2015-05-08 Thread Jie Yu
is on the critical path. - Jie Yu On April 15, 2015, 3:55 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398

Re: Review Request 33963: Move ARP filter implementation onto basic filter

2015-05-08 Thread Jie Yu
://reviews.apache.org/r/33963/#comment133895 Ditto. No need for this interface. - Jie Yu On May 8, 2015, 12:14 a.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33963

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-05-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32149/#review82348 --- Ship it! Ship It! - Jie Yu On May 1, 2015, 10:50 p.m., Michael

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-05 Thread Jie Yu
On April 21, 2015, 11:25 p.m., Jie Yu wrote: src/slave/slave.cpp, lines 3065-3078 https://reviews.apache.org/r/33249/diff/3/?file=938221#file938221line3065 Instead of doing that in your way, can we just try to make sure `containerizer-wait` here will return a failure

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/#review82905 --- On May 6, 2015, 10:35 p.m., Jie Yu wrote: --- This is an automatically generated e

Re: Review Request 33990: Changed BalloonExecutor to do memset before mlock.

2015-05-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33990/#review83029 --- Ship it! Ship It! - Jie Yu On May 8, 2015, 5:50 p.m., Chi Zhang

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-08 Thread Jie Yu
/resource_estimator.cpp PRE-CREATION Diff: https://reviews.apache.org/r/33918/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-08 Thread Jie Yu
://reviews.apache.org/r/33918/#review82829 --- On May 6, 2015, 10:35 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918

Re: Review Request 33875: Removed unused collect cycle in resource monitor

2015-05-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33875/#review83266 --- Ship it! Ship It! - Jie Yu On May 11, 2015, 6:20 p.m., Niklas

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249/#review83319 --- Ship it! Nice tests! LGTM! - Jie Yu On May 11, 2015, 10:06 p.m

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-11 Thread Jie Yu
://reviews.apache.org/r/29748/#comment134256 2 lines apart between two top level declarations. Please make sure this is the case in this file. - Jie Yu On May 9, 2015, 4:38 a.m., Michael Park wrote: --- This is an automatically generated e-mail

Re: Review Request 33876: Added usages() to resource monitor

2015-05-11 Thread Jie Yu
executorInfo = monitored[containerId]; ... .onFailed([conatinerId, executorInfo](...) {}) ... } ``` src/slave/monitor.cpp https://reviews.apache.org/r/33876/#comment134240 The prefix `ResourceMonitor::` is not needed here - Jie Yu On May 11, 2015, 6:20 p.m

Re: Review Request 33933: Slowed the webui polling for larger clusters.

2015-05-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33933/#review82836 --- Ship it! Ship It! - Jie Yu On May 7, 2015, 5:47 a.m., Ben

Re: Review Request 33934: Added the client address to http::Request.

2015-05-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33934/#review82840 --- Ship it! Ship It! - Jie Yu On May 7, 2015, 5:47 a.m., Ben

Re: Review Request 33935: Improved HTTP request logging for master/slave endpoints.

2015-05-07 Thread Jie Yu
(similar to what we put `=` in the end): ``` (userAgent.isSome() ? with User-Agent=' + userAgent.get() + ' : ) (...) ``` (BTW, I think you don't need `string(...)` above) - Jie Yu On May 7, 2015, 5:47 a.m., Ben Mahler wrote

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-12 Thread Jie Yu
14bc976a7b6a656fb58085484d25c3de3cf0f693 src/slave/resource_estimator.hpp PRE-CREATION src/slave/resource_estimator.cpp PRE-CREATION Diff: https://reviews.apache.org/r/33918/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 33919: Integrated resources estimator with the slave.

2015-05-12 Thread Jie Yu
/#review82858 --- On May 13, 2015, 12:37 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919

Re: Review Request 33919: Integrated resources estimator with the slave.

2015-05-12 Thread Jie Yu
/slave_tests.cpp 04e79ec061e767a82d40242be7884967942c50b6 Diff: https://reviews.apache.org/r/33919/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

2015-05-14 Thread Jie Yu
/#comment134870 s/const// We typically don't use const for primitive type parameters. src/slave/containerizer/isolators/network/port_mapping.cpp https://reviews.apache.org/r/31505/#comment134896 Priority(IP_FILTER_PRIORITY, NORMAL)? - Jie Yu On May 12, 2015, 12:14 a.m., Cong Wang

Re: Review Request 33919: Integrated resources estimator with the slave.

2015-05-13 Thread Jie Yu
/oversubscription_tests.cpp PRE-CREATION src/tests/slave_tests.cpp 04e79ec061e767a82d40242be7884967942c50b6 Diff: https://reviews.apache.org/r/33919/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 33919: Integrated resources estimator with the slave.

2015-05-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/#review83630 --- On May 13, 2015, 12:37 a.m., Jie Yu wrote: --- This is an automatically

Re: Review Request 33919: Integrated resources estimator with the slave.

2015-05-13 Thread Jie Yu
04e79ec061e767a82d40242be7884967942c50b6 Diff: https://reviews.apache.org/r/33919/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-13 Thread Jie Yu
src/slave/resource_estimator.cpp PRE-CREATION Diff: https://reviews.apache.org/r/33918/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 34298: Explictly validated that all resources specified in reserve or unreserve operations are dynamically reserved.

2015-05-15 Thread Jie Yu
/34298/#comment135101 ``` if (!Resources::isDynamicallyReserved(resource)) { ... } ``` src/master/validation.cpp https://reviews.apache.org/r/34298/#comment135102 Ditto. - Jie Yu On May 15, 2015, 11:26 p.m., Vinod Kone wrote

Review Request 34299: Changed to use a push model for resource estimator.

2015-05-15 Thread Jie Yu
132f83e05dd4113c8f6d20a6a64b12fb8f05dd36 src/tests/mesos.hpp df8cd200a6970209588b63a1d58709b1f913a305 src/tests/oversubscription_tests.cpp 64c2ede1f50546f6de1ecb2972036b51fe17e358 Diff: https://reviews.apache.org/r/34299/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

2015-05-15 Thread Jie Yu
/33865/#comment135104 Please use isDynamicallyReserved(resource) src/master/validation.cpp https://reviews.apache.org/r/33865/#comment135103 Maybe add a predicte function in Resources? ``` static bool Resources::isRevokable(resource); ``` - Jie Yu On May 15, 2015, 11

Re: Review Request 34295: Added maintainers documentation.

2015-05-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34295/#review84004 --- Ship it! Thanks Ben! LGTM. - Jie Yu On May 15, 2015, 10:25 p.m

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-18 Thread Jie Yu
--- On May 15, 2015, 11:38 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-18 Thread Jie Yu
64c2ede1f50546f6de1ecb2972036b51fe17e358 Diff: https://reviews.apache.org/r/34299/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-18 Thread Jie Yu
--- On May 15, 2015, 11:38 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-18 Thread Jie Yu
64c2ede1f50546f6de1ecb2972036b51fe17e358 Diff: https://reviews.apache.org/r/34299/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 33876: Added usages() to resource monitor

2015-05-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33876/#review83645 --- Ship it! Ship It! - Jie Yu On May 12, 2015, 8:55 p.m., Niklas

Re: Review Request 34438: Removed unnecessary freeaddrinfo in hostname if getaddrinfo returns error.

2015-05-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34438/#review84400 --- Ship it! Ship It! - Jie Yu On May 19, 2015, 9:44 p.m., Chi

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Jie Yu
. Repository: mesos Description --- Allowed post-reviews.py to configure tracking branch. Diffs - support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1 Diff: https://reviews.apache.org/r/34488/diff/ Testing --- Used it to post this review. Thanks, Jie Yu

Review Request 34483: Moved the repository url constant to reviewboardrc.

2015-05-20 Thread Jie Yu
--- Used it to post this review. Thanks, Jie Yu

Review Request 34482: Fixed a bug in post-reviews.py.

2015-05-20 Thread Jie Yu
--- Fixed a bug in post-reviews.py. Diffs - support/post-reviews.py 2ae9a952f13c62704e6c84c5e44665adfa5b7286 Diff: https://reviews.apache.org/r/34482/diff/ Testing --- Used it to post this review. Thanks, Jie Yu

Review Request 34485: Renamed parent_branch to tracking_branch in post-reviews.py.

2015-05-20 Thread Jie Yu
--- Renamed parent_branch to tracking_branch in post-reviews.py. Diffs - support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1 Diff: https://reviews.apache.org/r/34485/diff/ Testing --- Used it to post this review. Thanks, Jie Yu

Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Jie Yu
--- Allowed post-reviews.py to configure tracking branch. Diffs - support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1 Diff: https://reviews.apache.org/r/34488/diff/ Testing --- Used it to post this review. Thanks, Jie Yu

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Jie Yu
-mail. To reply, visit: https://reviews.apache.org/r/34488/#review84589 --- On May 20, 2015, 6:56 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Jie Yu
On May 20, 2015, 9:27 p.m., Vinod Kone wrote: support/post-reviews.py, line 200 https://reviews.apache.org/r/34488/diff/1/?file=965611#file965611line200 if someone specifies --tracking-branch on the command line, does that mean it'll be passed to 'rbt' twice? Jie Yu wrote

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Jie Yu
it to post this review. Thanks, Jie Yu

Re: Review Request 34488: Allowed post-reviews.py to configure tracking branch.

2015-05-20 Thread Jie Yu
it to post this review. Thanks, Jie Yu

Re: Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.

2015-05-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/#review84626 --- Ship it! Ship It! - Jie Yu On May 20, 2015, 11:13 p.m., Vinod

Review Request 35108: Passed allocated resources to the resource estimator.

2015-06-04 Thread Jie Yu
1b7a24aa7d55218791625ef07202d44537635259 src/tests/mesos.hpp 7e134b7d938e149504a70b77fe617ddc5a192f66 src/tests/oversubscription_tests.cpp a49cb393d30d230896820537ed893eb780e36333 Diff: https://reviews.apache.org/r/35108/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

2015-06-03 Thread Jie Yu
://reviews.apache.org/r/34980/#comment138533 `s/usages_/_usages/` - Jie Yu On June 3, 2015, 9:16 p.m., Bartek Plotka wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980

Re: Review Request 34633: Added QoS Controller test.

2015-06-03 Thread Jie Yu
? ``` listQoSCorrection expected = { QosCorrection() }; corrections.put(expected); ``` src/tests/oversubscription_tests.cpp https://reviews.apache.org/r/34633/#comment138568 I don't think you need this. - Jie Yu On June 3, 2015, 4:29 a.m., Niklas Nielsen wrote

Re: Review Request 34863: Add tests for new qdisc statistics functions.

2015-06-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34863/#review86494 --- Ship it! Ship It! - Jie Yu On June 3, 2015, 9:20 p.m., Paul

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-03 Thread Jie Yu
--- On June 3, 2015, 10:05 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028

Re: Review Request 35038: Updated slave to query resource estimator whenever it wants to forward an update.

2015-06-03 Thread Jie Yu
/#comment138572 Why CHECK instead of logging and retry? So returning a failure in the resource estimator will crash the slave? - Jie Yu On June 3, 2015, 11:20 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-06-03 Thread Jie Yu
/routing/queueing/statistics.hpp https://reviews.apache.org/r/34426/#comment138540 Should we get rid of 'queueing' here because this can be used by filters as well? - Jie Yu On June 3, 2015, 9:19 p.m., Paul Brett wrote

Re: Review Request 34631: Added QoS Controller.

2015-06-03 Thread Jie Yu
leading spaces here (similar to template functions). - Jie Yu On June 3, 2015, 4:26 a.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-03 Thread Jie Yu
f047b90d8f0b4dfe7e6cad6dc58909451e9f894b Diff: https://reviews.apache.org/r/35028/diff/ Testing --- make check Thanks, Jie Yu

Review Request 35028: Added a fixed resource estimator.

2015-06-03 Thread Jie Yu
Thanks, Jie Yu

Re: Review Request 35033: Define potentially missing MS_* mount flags.

2015-06-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35033/#review86498 --- Ship it! Ship It! - Jie Yu On June 3, 2015, 10:53 p.m., Ian

Re: Review Request 34632: Added QoS Controller in slave

2015-06-03 Thread Jie Yu
://reviews.apache.org/r/34632/#comment138554 Add one more line here. src/tests/mesos.cpp https://reviews.apache.org/r/34632/#comment138561 const Option.. - Jie Yu On June 3, 2015, 4:28 a.m., Niklas Nielsen wrote

Re: Review Request 35038: Updated slave to query resource estimator whenever it wants to forward an update.

2015-06-03 Thread Jie Yu
On June 3, 2015, 11:44 p.m., Jie Yu wrote: Also, could you please adjust the comments above the public resource estimator 'oversubscribable()' interface since we incur a minimal interval in the slave? - Jie

Re: Review Request 34720: Added kill executor correction to slave.

2015-06-04 Thread Jie Yu
/ --- (Updated June 4, 2015, 5:43 p.m.) Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone. Bugs: MESOS-2653 https://issues.apache.org/jira/browse/MESOS-2653 Repository: mesos

Review Request 35082: Adjusted the NoopResourceEstimator to the new slave semantics.

2015-06-04 Thread Jie Yu
Description --- Adjusted the NoopResourceEstimator to the new slave semantics. Diffs - src/slave/resource_estimators/noop.cpp 772eb4e9bd987141b8ed9f5d7a681a7145b11a75 Diff: https://reviews.apache.org/r/35082/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 34720: Added kill executor correction to slave.

2015-06-04 Thread Jie Yu
looked into it? Jie Yu wrote: +1 It really gets nasty here. I remembered that jaybuff said that they plan to fix that. Maybe you want to sync with them first. Niklas Nielsen wrote: Mind adding a few references? Where is the Termination proto? Some references for the context

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-04 Thread Jie Yu
src/tests/oversubscription_tests.cpp 43a13eec4aab564f84eadb99970b041faa0379f8 Diff: https://reviews.apache.org/r/35028/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 35080: Fix comments in routing_tests.cpp

2015-06-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35080/#review86670 --- Ship it! Thanks! - Jie Yu On June 4, 2015, 5:51 p.m., Cong Wang

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/#review86502 --- On June 3, 2015, 10:05 p.m., Jie Yu wrote: --- This is an automatically

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-04 Thread Jie Yu
Want to do that instead? Jie Yu wrote: I thought we decided to use char[] consistently? That's what we've been doing in isolators. Should we make a decision and change that in the style guide? cc Ben Mahler, Vinod Kone ``` [tw-172-25-131-112 mesos

Re: Review Request 34632: Added QoS Controller in slave

2015-06-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/#review86677 --- Ship it! Ship It! - Jie Yu On June 4, 2015, 5:42 p.m., Niklas

Re: Review Request 35152: Document and consolidate qdisc handles

2015-06-08 Thread Jie Yu
that there is a 'script' in the end. - Jie Yu On June 8, 2015, 4:35 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35152

Re: Review Request 35165: Extend fq_codel to allow parent and handle to be specified at runtime.

2015-06-08 Thread Jie Yu
://reviews.apache.org/r/35165/#comment139319 Can you make this optional? src/slave/containerizer/isolators/network/port_mapping.cpp https://reviews.apache.org/r/35165/#comment139313 Do we use this? - Jie Yu On June 6, 2015, 12:02 a.m., Paul Brett wrote

Re: Review Request 35164: Added callback to the QoS Controller to retrieve usages from the monitor.

2015-06-08 Thread Jie Yu
On June 9, 2015, 12:34 a.m., Jie Yu wrote: I think the interface of getting resource usage is going to change per discussion here: https://issues.apache.org/jira/browse/MESOS-2818 Niklas Nielsen wrote: The new proposal doesn't mention changing the callback, does it? The new

Re: Review Request 35164: Added callback to the QoS Controller to retrieve usages from the monitor.

2015-06-08 Thread Jie Yu
per discussion here: https://issues.apache.org/jira/browse/MESOS-2818 - Jie Yu On June 5, 2015, 11:44 p.m., Bartek Plotka wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35164

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86860 --- Ship it! LGTM. I'll wait for Ian's shipit. - Jie Yu On June 3

Re: Review Request 35150: Add output stream operation for handle to use in port_mapping.cpp

2015-06-05 Thread Jie Yu
/r/35150/#comment138976 2 lines apart. src/linux/routing/handle.hpp https://reviews.apache.org/r/35150/#comment138977 Ditto. - Jie Yu On June 5, 2015, 8:30 p.m., Paul Brett wrote: --- This is an automatically generated e

Re: Review Request 34956: Refactored the queueing discipline data structure.

2015-06-02 Thread Jie Yu
On June 2, 2015, 10:40 p.m., Paul Brett wrote: src/linux/routing/queueing/discipline.hpp, line 39 https://reviews.apache.org/r/34956/diff/1/?file=976864#file976864line39 Should config be optional? Jie Yu wrote: We still need a Config struct for each type of qdisc so

Re: Review Request 34962: Moved NoopResourceEstimator to a separate file.

2015-06-02 Thread Jie Yu
/#review86315 --- On June 2, 2015, 11:15 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34962

Re: Review Request 34962: Moved NoopResourceEstimator to a separate file.

2015-06-02 Thread Jie Yu
://reviews.apache.org/r/34962/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 34957: Fixed a bug in qdisc search function.

2015-06-02 Thread Jie Yu
but nowhere else or just fix Netlink to hide this (it does hide most of the cleanup logic) Jie Yu wrote: Yeah, we should definitely add some comments. Can you sugguest how to fix Netlink to hide this? Paul Brett wrote: Chi and I were talking about adding a copy constructor

Re: Review Request 34962: Moved NoopResourceEstimator to a separate file.

2015-06-02 Thread Jie Yu
is in singular) Otherwise, LGTM Jie Yu wrote: Hum, seems that we use plural more often than singular (src/tests, src/credentials, src/files, etc.) OK, I think 'containerizer' is a legacy issue (there was only one containerizer at that time) - Jie

Review Request 34962: Moved NoopResourceEstimator to a separate file.

2015-06-02 Thread Jie Yu
/resource_estimator.cpp a67640c3878c5707b8ef39c0750711c619680a39 src/slave/resource_estimator/noop.cpp PRE-CREATION src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6 Diff: https://reviews.apache.org/r/34962/diff/ Testing --- make check Thanks, Jie Yu

Re: Review Request 34816: Changed TestResourceEstimator to be mocked.

2015-06-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34816/#review86289 --- Ship it! Ship It! - Jie Yu On June 2, 2015, 9:19 p.m., Bartek

Re: Review Request 34956: Refactored the queueing discipline data structure.

2015-06-02 Thread Jie Yu
/34956/#review86300 --- On June 2, 2015, 10:04 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34956

Review Request 34956: Refactored the queueing discipline data structure.

2015-06-02 Thread Jie Yu
ae0c38d2215e7fabcc1060e7385484bd455e1699 src/linux/routing/queueing/internal.hpp d43a9fd405af2e59dc57cfc7ba9b5e77cb9f6b70 Diff: https://reviews.apache.org/r/34956/diff/ Testing --- sudo make check Thanks, Jie Yu

  1   2   3   4   5   6   7   8   9   10   >