:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/
---
(Updated April 8, 2015, 5:05 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu
:
https://reviews.apache.org/r/33414/#review81532
---
On April 21, 2015, 9:46 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33459/#review81251
---
Subsumed by this https://reviews.apache.org/r/33257?
- Jie Yu
On April 21, 2015, 11:25 p.m., Jie Yu wrote:
src/slave/slave.cpp, lines 3065-3078
https://reviews.apache.org/r/33249/diff/3/?file=938221#file938221line3065
Instead of doing that in your way, can we just try to make sure
`containerizer-wait` here will return a failure
On April 8, 2015, 9:19 p.m., Jie Yu wrote:
src/common/resources.cpp, line 663
https://reviews.apache.org/r/32149/diff/4/?file=920084#file920084line663
Do you need to call validate(operation.reserve().resources()) first
(like we did in CREATE/DESTROY)? Do you also want to check
On April 21, 2015, 11:25 p.m., Jie Yu wrote:
src/slave/slave.cpp, lines 3065-3078
https://reviews.apache.org/r/33249/diff/3/?file=938221#file938221line3065
Instead of doing that in your way, can we just try to make sure
`containerizer-wait` here will return a failure
, CLONE_NEWNET},
...
}
std::vectorstd::string namespaces;
foreachpair (int flag, const std::string name, names) {
if (clone flag) {
namespaces.push_back(name);
}
}
return strings::join( | , namesapces);
```
- Jie Yu
On May 1, 2015, 5:27 a.m., Ian
a boolean, can you pass an Optionstring principal
as you did in `validate(reserve)`?
src/tests/master_validation_tests.cpp
https://reviews.apache.org/r/32150/#comment132685
One extra blank line here please.
- Jie Yu
On April 28, 2015, 10:43 p.m., Michael Park wrote
24cb4ba69c463fb7d2bba0786474fc8a14c92ea0
Diff: https://reviews.apache.org/r/33631/diff/
Testing
---
make check
Thanks,
Jie Yu
On May 7, 2015, 5:40 p.m., Jie Yu wrote:
src/master/master.cpp, lines 732-735
https://reviews.apache.org/r/33935/diff/1/?file=952157#file952157line732
Why do you need to capture `this`? Http::log is a static function, I
don't think you need to capture `this`.
Capture
Ditto. Please pass in a `protocol`
src/linux/routing/filter/basic.cpp
https://reviews.apache.org/r/31504/#comment133766
Ditto here.
- Jie Yu
On May 5, 2015, 6:37 p.m., Cong Wang wrote:
---
This is an automatically generated e
On April 21, 2015, 11:25 p.m., Jie Yu wrote:
src/slave/slave.cpp, lines 3065-3078
https://reviews.apache.org/r/33249/diff/3/?file=938221#file938221line3065
Instead of doing that in your way, can we just try to make sure
`containerizer-wait` here will return a failure
/resource_estimator.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/33918/diff/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33875/#review83266
---
Ship it!
Ship It!
- Jie Yu
On May 11, 2015, 6:20 p.m., Niklas
://reviews.apache.org/r/29748/#comment134256
2 lines apart between two top level declarations. Please make sure this is
the case in this file.
- Jie Yu
On May 9, 2015, 4:38 a.m., Michael Park wrote:
---
This is an automatically generated e-mail
executorInfo = monitored[containerId];
...
.onFailed([conatinerId, executorInfo](...) {})
...
}
```
src/slave/monitor.cpp
https://reviews.apache.org/r/33876/#comment134240
The prefix `ResourceMonitor::` is not needed here
- Jie Yu
On May 11, 2015, 6:20 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33933/#review82836
---
Ship it!
Ship It!
- Jie Yu
On May 7, 2015, 5:47 a.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33934/#review82840
---
Ship it!
Ship It!
- Jie Yu
On May 7, 2015, 5:47 a.m., Ben
/#review82858
---
On May 13, 2015, 12:37 a.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33919
/#comment134870
s/const//
We typically don't use const for primitive type parameters.
src/slave/containerizer/isolators/network/port_mapping.cpp
https://reviews.apache.org/r/31505/#comment134896
Priority(IP_FILTER_PRIORITY, NORMAL)?
- Jie Yu
On May 12, 2015, 12:14 a.m., Cong Wang
/oversubscription_tests.cpp PRE-CREATION
src/tests/slave_tests.cpp 04e79ec061e767a82d40242be7884967942c50b6
Diff: https://reviews.apache.org/r/33919/diff/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33919/#review83630
---
On May 13, 2015, 12:37 a.m., Jie Yu wrote:
---
This is an automatically
04e79ec061e767a82d40242be7884967942c50b6
Diff: https://reviews.apache.org/r/33919/diff/
Testing
---
make check
Thanks,
Jie Yu
src/slave/resource_estimator.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/33918/diff/
Testing
---
make check
Thanks,
Jie Yu
132f83e05dd4113c8f6d20a6a64b12fb8f05dd36
src/tests/mesos.hpp df8cd200a6970209588b63a1d58709b1f913a305
src/tests/oversubscription_tests.cpp 64c2ede1f50546f6de1ecb2972036b51fe17e358
Diff: https://reviews.apache.org/r/34299/diff/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34295/#review84004
---
Ship it!
Thanks Ben! LGTM.
- Jie Yu
On May 15, 2015, 10:25 p.m
---
On May 15, 2015, 11:38 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34299
64c2ede1f50546f6de1ecb2972036b51fe17e358
Diff: https://reviews.apache.org/r/34299/diff/
Testing
---
make check
Thanks,
Jie Yu
---
On May 15, 2015, 11:38 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34299
64c2ede1f50546f6de1ecb2972036b51fe17e358
Diff: https://reviews.apache.org/r/34299/diff/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33876/#review83645
---
Ship it!
Ship It!
- Jie Yu
On May 12, 2015, 8:55 p.m., Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34438/#review84400
---
Ship it!
Ship It!
- Jie Yu
On May 19, 2015, 9:44 p.m., Chi
.
Repository: mesos
Description
---
Allowed post-reviews.py to configure tracking branch.
Diffs
-
support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1
Diff: https://reviews.apache.org/r/34488/diff/
Testing
---
Used it to post this review.
Thanks,
Jie Yu
---
Renamed parent_branch to tracking_branch in post-reviews.py.
Diffs
-
support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1
Diff: https://reviews.apache.org/r/34485/diff/
Testing
---
Used it to post this review.
Thanks,
Jie Yu
---
Allowed post-reviews.py to configure tracking branch.
Diffs
-
support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1
Diff: https://reviews.apache.org/r/34488/diff/
Testing
---
Used it to post this review.
Thanks,
Jie Yu
-mail. To reply, visit:
https://reviews.apache.org/r/34488/#review84589
---
On May 20, 2015, 6:56 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit
On May 20, 2015, 9:27 p.m., Vinod Kone wrote:
support/post-reviews.py, line 200
https://reviews.apache.org/r/34488/diff/1/?file=965611#file965611line200
if someone specifies --tracking-branch on the command line, does that
mean it'll be passed to 'rbt' twice?
Jie Yu wrote
it to post this review.
Thanks,
Jie Yu
it to post this review.
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34503/#review84626
---
Ship it!
Ship It!
- Jie Yu
On May 20, 2015, 11:13 p.m., Vinod
?
```
listQoSCorrection expected = { QosCorrection() };
corrections.put(expected);
```
src/tests/oversubscription_tests.cpp
https://reviews.apache.org/r/34633/#comment138568
I don't think you need this.
- Jie Yu
On June 3, 2015, 4:29 a.m., Niklas Nielsen wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34863/#review86494
---
Ship it!
Ship It!
- Jie Yu
On June 3, 2015, 9:20 p.m., Paul
---
On June 3, 2015, 10:05 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35028
/#comment138572
Why CHECK instead of logging and retry? So returning a failure in the
resource estimator will crash the slave?
- Jie Yu
On June 3, 2015, 11:20 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail
/routing/queueing/statistics.hpp
https://reviews.apache.org/r/34426/#comment138540
Should we get rid of 'queueing' here because this can be used by filters as
well?
- Jie Yu
On June 3, 2015, 9:19 p.m., Paul Brett wrote
leading spaces here
(similar to template functions).
- Jie Yu
On June 3, 2015, 4:26 a.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34631
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35033/#review86498
---
Ship it!
Ship It!
- Jie Yu
On June 3, 2015, 10:53 p.m., Ian
://reviews.apache.org/r/34632/#comment138554
Add one more line here.
src/tests/mesos.cpp
https://reviews.apache.org/r/34632/#comment138561
const Option..
- Jie Yu
On June 3, 2015, 4:28 a.m., Niklas Nielsen wrote
On June 3, 2015, 11:44 p.m., Jie Yu wrote:
Also, could you please adjust the comments above the public resource estimator
'oversubscribable()' interface since we incur a minimal interval in the slave?
- Jie
Description
---
Adjusted the NoopResourceEstimator to the new slave semantics.
Diffs
-
src/slave/resource_estimators/noop.cpp
772eb4e9bd987141b8ed9f5d7a681a7145b11a75
Diff: https://reviews.apache.org/r/35082/diff/
Testing
---
make check
Thanks,
Jie Yu
looked into it?
Jie Yu wrote:
+1
It really gets nasty here. I remembered that jaybuff said that they plan
to fix that. Maybe you want to sync with them first.
Niklas Nielsen wrote:
Mind adding a few references? Where is the Termination proto?
Some references for the context
src/tests/oversubscription_tests.cpp 43a13eec4aab564f84eadb99970b041faa0379f8
Diff: https://reviews.apache.org/r/35028/diff/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35080/#review86670
---
Ship it!
Thanks!
- Jie Yu
On June 4, 2015, 5:51 p.m., Cong Wang
Want to do that instead?
Jie Yu wrote:
I thought we decided to use char[] consistently? That's what we've been
doing in isolators.
Should we make a decision and change that in the style guide?
cc Ben Mahler, Vinod Kone
```
[tw-172-25-131-112 mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34632/#review86677
---
Ship it!
Ship It!
- Jie Yu
On June 4, 2015, 5:42 p.m., Niklas
that there is a 'script' in the end.
- Jie Yu
On June 8, 2015, 4:35 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152
On June 9, 2015, 12:34 a.m., Jie Yu wrote:
I think the interface of getting resource usage is going to change per
discussion here:
https://issues.apache.org/jira/browse/MESOS-2818
Niklas Nielsen wrote:
The new proposal doesn't mention changing the callback, does it?
The new
per
discussion here:
https://issues.apache.org/jira/browse/MESOS-2818
- Jie Yu
On June 5, 2015, 11:44 p.m., Bartek Plotka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35164
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34894/#review86860
---
Ship it!
LGTM. I'll wait for Ian's shipit.
- Jie Yu
On June 3
/r/35150/#comment138976
2 lines apart.
src/linux/routing/handle.hpp
https://reviews.apache.org/r/35150/#comment138977
Ditto.
- Jie Yu
On June 5, 2015, 8:30 p.m., Paul Brett wrote:
---
This is an automatically generated e
On June 2, 2015, 10:40 p.m., Paul Brett wrote:
src/linux/routing/queueing/discipline.hpp, line 39
https://reviews.apache.org/r/34956/diff/1/?file=976864#file976864line39
Should config be optional?
Jie Yu wrote:
We still need a Config struct for each type of qdisc so
/#review86315
---
On June 2, 2015, 11:15 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962
://reviews.apache.org/r/34962/diff/
Testing
---
make check
Thanks,
Jie Yu
but nowhere else or just fix Netlink
to hide this (it does hide most of the cleanup logic)
Jie Yu wrote:
Yeah, we should definitely add some comments. Can you sugguest how to fix
Netlink to hide this?
Paul Brett wrote:
Chi and I were talking about adding a copy constructor
is in singular)
Otherwise, LGTM
Jie Yu wrote:
Hum, seems that we use plural more often than singular (src/tests,
src/credentials, src/files, etc.)
OK, I think 'containerizer' is a legacy issue (there was only one containerizer
at that time)
- Jie
/resource_estimator.cpp a67640c3878c5707b8ef39c0750711c619680a39
src/slave/resource_estimator/noop.cpp PRE-CREATION
src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6
Diff: https://reviews.apache.org/r/34962/diff/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/#review86289
---
Ship it!
Ship It!
- Jie Yu
On June 2, 2015, 9:19 p.m., Bartek
/34956/#review86300
---
On June 2, 2015, 10:04 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34956
ae0c38d2215e7fabcc1060e7385484bd455e1699
src/linux/routing/queueing/internal.hpp
d43a9fd405af2e59dc57cfc7ba9b5e77cb9f6b70
Diff: https://reviews.apache.org/r/34956/diff/
Testing
---
sudo make check
Thanks,
Jie Yu
.
Repository: mesos
Description
---
Fixed a bug in qdisc search function.
Diffs
-
src/linux/routing/queueing/internal.hpp
d43a9fd405af2e59dc57cfc7ba9b5e77cb9f6b70
Diff: https://reviews.apache.org/r/34957/diff/
Testing
---
sudo make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review86298
---
Ship it!
Ship It!
- Jie Yu
On June 2, 2015, 10:06 p.m., Bartek
. To reply, visit:
https://reviews.apache.org/r/34957/#review86303
---
On June 2, 2015, 10:05 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit
84506fecd01522471a7998176c28bea8f1367aed
src/linux/routing/queueing/ingress.cpp
ae0c38d2215e7fabcc1060e7385484bd455e1699
Diff: https://reviews.apache.org/r/34958/diff/
Testing
---
sudo make check
Thanks,
Jie Yu
://reviews.apache.org/r/35259/diff/
Testing
---
make check
Thanks,
Jie Yu
On June 9, 2015, 12:34 a.m., Jie Yu wrote:
I think the interface of getting resource usage is going to change per
discussion here:
https://issues.apache.org/jira/browse/MESOS-2818
Niklas Nielsen wrote:
The new proposal doesn't mention changing the callback, does it?
Jie Yu
dff45b0d3bf9ef53f19575ab3d90a0b223755d6a
src/tests/monitor_tests.cpp 6de8b1f65843fd7b852dfa69627a1c435b482fe0
Diff: https://reviews.apache.org/r/35260/diff/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225/#review87290
---
Ship it!
Ship It!
- Jie Yu
On June 9, 2015, 5:22 p.m., Paul
On June 3, 2015, 10:35 p.m., Jie Yu wrote:
src/linux/routing/queueing/internal.hpp, line 320
https://reviews.apache.org/r/34426/diff/11/?file=977689#file977689line320
Why =?
Paul Brett wrote:
The definition for RTNL_TC_STATS_MAX comes from libnl and looks like
/34832/#comment138483
s/Ingress/IngressQdisc/
src/tests/routing_tests.cpp
https://reviews.apache.org/r/34832/#comment138484
s/FqCodel/FqCodelQdisc/
- Jie Yu
On June 3, 2015, 6:25 p.m., Paul Brett wrote
looked into it?
Jie Yu wrote:
+1
It really gets nasty here. I remembered that jaybuff said that they plan
to fix that. Maybe you want to sync with them first.
Niklas Nielsen wrote:
Mind adding a few references? Where is the Termination proto?
Jie Yu wrote:
Some
/monitor.hpp bee91ba143c26059fc8badf56beccb68c6556cb7
Diff: https://reviews.apache.org/r/35259/diff/
Testing
---
make check
Thanks,
Jie Yu
---
make check
Thanks,
Jie Yu
://reviews.apache.org/r/35272/diff/
Testing
---
make check
Thanks,
Jie Yu
/port_mapping.cpp
d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f
src/tests/routing_tests.cpp 463c2e556488b18388d4e741cf584644016cec59
Diff: https://reviews.apache.org/r/35273/diff/
Testing
---
make check
Thanks,
Jie Yu
, 7:51 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35264/
---
(Updated June 9, 2015, 7:51 p.m.)
Review
9, 2015, 6:54 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35260/
---
(Updated June 9, 2015, 6:54 p.m
d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f
Diff: https://reviews.apache.org/r/35273/diff/
Testing
---
make check
Thanks,
Jie Yu
---
On June 9, 2015, 6:54 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35260
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35686/#review88812
---
Ship it!
Ship It!
- Jie Yu
On June 20, 2015, 4:42 a.m., Michael
://reviews.apache.org/r/31444/#comment141402
This is not needed?
src/tests/launch_tests.cpp (lines 186 - 187)
https://reviews.apache.org/r/31444/#comment141404
No snake case please. Also, do you still need this?
- Jie Yu
On June 22, 2015, 4:38 p.m., Ian Downes wrote
generated e-mail. To reply, visit:
https://reviews.apache.org/r/35744/#review88849
---
On June 22, 2015, 9:25 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail
: https://reviews.apache.org/r/35744/diff/
Testing
---
sudo make check
Will follow up a test later.
Thanks,
Jie Yu
to locate the libnl3 library
(required for network-isolator). [default:
/usr]]),
[], [])
```
configure.ac (line 830)
https://reviews.apache.org/r/35766/#comment141640
Please move this comments down.
- Jie Yu
On June 23, 2015, 6:18 a.m., Kapil
://reviews.apache.org/r/35586/#comment141637
Please use const Optionint as least:)
- Jie Yu
On June 23, 2015, 7:05 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35586
).
Diffs (updated)
-
src/slave/containerizer/isolators/network/port_mapping.cpp
4de737a158da2ab329de7c57b9b52de305606bf0
Diff: https://reviews.apache.org/r/35749/diff/
Testing
---
sudo make check
Thanks,
Jie Yu
/port_mapping.cpp
4de737a158da2ab329de7c57b9b52de305606bf0
Diff: https://reviews.apache.org/r/35749/diff/
Testing
---
sudo make check
Thanks,
Jie Yu
://reviews.apache.org/r/35750/diff/
Testing
---
sudo make check
Thanks,
Jie Yu
, visit:
https://reviews.apache.org/r/35749/#review88871
---
On June 22, 2015, 11:08 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
generated e-mail. To reply, visit:
https://reviews.apache.org/r/35749/#review88875
---
On June 22, 2015, 11:29 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail
/r/35715/
---
(Updated June 21, 2015, 7 p.m.)
Review request for mesos, Jie Yu, Niklas Nielsen, and Vinod Kone.
Repository: mesos
Description
---
In `mesos.proto`, it specifies the expected state of revocable resource
1 - 100 of 4105 matches
Mail list logo