Re: Review Request 33490: MESOS-2633 Avoid adding duplicate tasks

2015-04-23 Thread Mesos ReviewBot
/apply-review.sh -n -r 33490 Error: 2015-04-23 19:43:56 URL:https://reviews.apache.org/r/33490/diff/raw/ [1294/1294] - 33490.patch [1] error: src/master/framework.cpp: does not exist in index Failed to apply patch - Mesos ReviewBot On April 23, 2015, 7:36 p.m., Marco Massenzio wrote

Re: Review Request 33491: Set the supplementary groups list when switching users.

2015-04-23 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 23, 2015, 8:16 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33491/ --- (Updated

Re: Review Request 32999: Added a document for engineering principles and practices.

2015-04-23 Thread Mesos ReviewBot
, 32999] All tests passed. - Mesos ReviewBot On April 23, 2015, 11:15 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32999

Re: Review Request 33554: Avoid Python declineOffer raise exception when filters is assigned to None explicitly

2015-04-25 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 25, 2015, 8:09 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33554

Re: Review Request 32536: Updated variable naming style.

2015-04-24 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 24, 2015, 1:27 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32536

Re: Review Request 33527: Updated documentation for ClangFormat.

2015-04-26 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 26, 2015, 9:59 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33527

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-04-22 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33276

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-04-22 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275

Re: Review Request 33109: Allow setting environment variables in mesos-execute

2015-04-25 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 25, 2015, 9:11 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33109

Re: Review Request 32509: Documented the scheduler Event/Call protobufs.

2015-04-22 Thread Mesos ReviewBot
, 32843, 32505, 32506, 32844, 32845, 33465, 32509] All tests passed. - Mesos ReviewBot On April 23, 2015, 2:55 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32509

Re: Review Request 33448: Added Eclipse-specific files to the gitignore list

2015-04-22 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On April 22, 2015, 8:36 p.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33448

Re: Review Request 32509: Documented the scheduler Event/Call protobufs.

2015-04-22 Thread Mesos ReviewBot
, 32843, 32505, 32506, 32844, 32845, 32509] All tests passed. - Mesos ReviewBot On April 22, 2015, 9:44 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32509

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-04-22 Thread Mesos ReviewBot
: ./support/apply-review.sh -n -r 29328 Error: 2015-04-22 22:53:16 URL:https://reviews.apache.org/r/29328/diff/raw/ [2149/2149] - 29328.patch [1] error: patch failed: src/slave/flags.hpp:311 error: src/slave/flags.hpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 22, 2015, 10

Re: Review Request 33528: Create '.clang-format' from 'bootstrap' script instead.

2015-04-24 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 24, 2015, 6:22 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33528

Re: Review Request 33644: MemoryTestHelper: Changed to do memset before mlock.

2015-04-28 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 28, 2015, 11 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33644/ --- (Updated

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-04-30 Thread Mesos ReviewBot
/apply-review.sh -n -r 29327 Error: 2015-04-30 07:45:09 URL:https://reviews.apache.org/r/29327/diff/raw/ [2935/2935] - 29327.patch [1] error: patch failed: src/slave/containerizer/docker.cpp:499 error: src/slave/containerizer/docker.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot

Re: Review Request 33781: Add license blobs to Java JNI cpp files

2015-05-02 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 2, 2015, 2:35 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33781/ --- (Updated

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-05-02 Thread Mesos ReviewBot
/apply-review.sh -n -r 29327 Error: 2015-05-02 20:34:47 URL:https://reviews.apache.org/r/29327/diff/raw/ [2935/2935] - 29327.patch [1] error: patch failed: src/slave/containerizer/docker.cpp:499 error: src/slave/containerizer/docker.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot

Re: Review Request 33746: Improve logging of clone flags for linux_launcher.

2015-05-01 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 1, 2015, 5:27 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33746/ --- (Updated May

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

2015-05-01 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 1, 2015, 3:42 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/ --- (Updated

Re: Review Request 33755: Remove the unused acx_pthread autoconf macro from stout.

2015-05-01 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 1, 2015, 4:01 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33755/ --- (Updated

Re: Review Request 33733: Fixed style error with template definitions withing common/parse.hpp

2015-04-30 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 30, 2015, 10:45 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33733

Re: Review Request 33490: MESOS-2633 Avoid adding duplicate tasks

2015-04-30 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On April 30, 2015, 9:46 p.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33490

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-05-01 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On May 1, 2015, 6:56 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612

Re: Review Request 33754: Update pthread autoconf macros for libprocess.

2015-05-01 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 1, 2015, 4:02 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33754/ --- (Updated

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-01 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 1, 2015, 4:02 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33753/ --- (Updated

Re: Review Request 33765: MESOS-2665: fix queuing discipline wrapper in linux/routing/queueing

2015-05-01 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 1, 2015, 7:24 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33765/ --- (Updated May

Re: Review Request 33631: Fixed a bug in port mapping isolator which will cause SIGABRT during slave recovery.

2015-04-28 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 28, 2015, 5:55 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33631/ --- (Updated

Re: Review Request 33828: Fix for MESOS-2690. Issue with enable-optimize build.

2015-05-04 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 4, 2015, 11:48 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33828

Re: Review Request 33505: Add state-summary endpoint to master.

2015-05-05 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 5, 2015, 9:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33505

Re: Review Request 33876: Added usages() to resource monitor

2015-05-05 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 6, 2015, 2:16 a.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33876

Re: Review Request 33792: Add InsensitiveHashMap.

2015-05-03 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 3, 2015, 9:37 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-03 Thread Mesos ReviewBot
distcheck Error: make dist-gzip am__post_remove_distdir='@:' make[1]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot' if test -d mesos-0.23.0; then find mesos-0.23.0 -type d ! -perm -200 -exec chmod u+w {} ';' rm -rf mesos-0.23.0 || { sleep 5 rm -rf mesos-0.23.0

Re: Review Request 33935: Improved HTTP request logging for master/slave endpoints.

2015-05-07 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On May 7, 2015, 5:47 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33935

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-07 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 7, 2015, 6:57 p.m., Jay Buffington wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249/ --- (Updated

Re: Review Request 33718: Extended documentation on Mesos hooks.

2015-05-07 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 7, 2015, 8:40 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33718

Re: Review Request 33935: Improved HTTP request logging for master/slave endpoints.

2015-05-07 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On May 7, 2015, 10 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33935

Re: Review Request 33872: Renamed shutdown_tests.cpp to teardown_tests.cpp.

2015-05-06 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 6, 2015, 9:33 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33872

Re: Review Request 33919: Integrated resources estimator with the slave.

2015-05-06 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 6, 2015, 10:35 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/ --- (Updated

Re: Review Request 33872: Renamed shutdown_tests.cpp to teardown_tests.cpp.

2015-05-06 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 6, 2015, 5:15 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33872

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

2015-05-05 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 5, 2015, 9:13 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/ --- (Updated May

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

2015-05-05 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 5, 2015, 3:53 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33849/ --- (Updated

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-09 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 9, 2015, 7:52 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018

Re: Review Request 31667: Piped hashmapSlaveID, Resources from allocator through to sorter.

2015-05-09 Thread Mesos ReviewBot
, 31667] All tests passed. - Mesos ReviewBot On May 10, 2015, 12:21 a.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31667

Re: Review Request 33514: Wired up --allocator flag in master.

2015-05-08 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 8, 2015, 8:44 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33514

Re: Review Request 33963: Move ARP filter implementation onto basic filter

2015-05-08 Thread Mesos ReviewBot
] All tests passed. - Mesos ReviewBot On May 8, 2015, 7:29 p.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33963

Re: Review Request 32398: Persisted the reservation state on the slave.

2015-05-09 Thread Mesos ReviewBot
not apply error: patch failed: src/tests/reservation_tests.cpp:286 error: src/tests/reservation_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On May 10, 2015, 12:33 a.m., Michael Park wrote

Re: Review Request 33876: Added usages() to resource monitor

2015-05-11 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 11, 2015, 6:20 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33876

Re: Review Request 34048: Fixed disappearing search bar: MESOS-2479

2015-05-11 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 11, 2015, 6:25 p.m., Ian Babrou wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34048/ --- (Updated

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

2015-05-11 Thread Mesos ReviewBot
] All tests passed. - Mesos ReviewBot On May 12, 2015, 12:14 a.m., Cong Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505

Re: Review Request 32398: Persisted the reservation state on the slave.

2015-05-11 Thread Mesos ReviewBot
, 29748, 32398] All tests passed. - Mesos ReviewBot On May 11, 2015, 10:42 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-11 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 12, 2015, 12:56 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34068

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-11 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 11, 2015, 10:06 p.m., Jay Buffington wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

2015-05-08 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 8, 2015, 10:11 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

2015-05-09 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 9, 2015, 5:07 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34016/ --- (Updated

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-07 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 7, 2015, 4:17 p.m., Jay Buffington wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249/ --- (Updated

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

2015-05-05 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 5, 2015, 5:52 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33849/ --- (Updated

Re: Review Request 33718: Extended documentation on Mesos hooks.

2015-05-08 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 8, 2015, 11:19 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33718

Re: Review Request 32398: Persisted the reservation state on the slave.

2015-05-12 Thread Mesos ReviewBot
, 29748, 32398] All tests passed. - Mesos ReviewBot On May 12, 2015, 6:44 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398

Re: Review Request 33241: docs: Add documentation on observability metrics.

2015-05-12 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 12, 2015, 8:43 p.m., Ricardo Cervera-Navarro wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241

Re: Review Request 33155: Added tests for slave removal metrics.

2015-05-12 Thread Mesos ReviewBot
] All tests passed. - Mesos ReviewBot On May 12, 2015, 11:32 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33155

Re: Review Request 34129: Add 2 optional args public_ip and public_port for libprocess to advertise.

2015-05-12 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 12, 2015, 11:30 p.m., Anindya Sinha wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34129

Re: Review Request 30643: Optionally specify executor for mesos execute.

2015-05-12 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 13, 2015, 12:22 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/ --- (Updated

Re: Review Request 33514: Wired up --allocator flag in master.

2015-05-14 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 14, 2015, 1:23 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33514

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-16 Thread Mesos ReviewBot
Failed to apply patch - Mesos ReviewBot On May 16, 2015, 8:31 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34318

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-16 Thread Mesos ReviewBot
Failed to apply patch - Mesos ReviewBot On May 16, 2015, 8:31 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317

Re: Review Request 34319: Update callers of os::getenv() in stout.

2015-05-16 Thread Mesos ReviewBot
Failed to apply patch - Mesos ReviewBot On May 16, 2015, 8:31 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-17 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On May 17, 2015, 3:21 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34318

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

2015-05-14 Thread Mesos ReviewBot
, 32948, 31017, 33372] All tests passed. - Mesos ReviewBot On May 14, 2015, 5:06 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33372

Re: Review Request 33919: Integrated resources estimator with the slave.

2015-05-13 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 14, 2015, 12:07 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919

Re: Review Request 33919: Integrated resources estimator with the slave.

2015-05-13 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 13, 2015, 10:36 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-05-14 Thread Mesos ReviewBot
/apply-review.sh -n -r 29327 Error: 2015-05-14 21:55:18 URL:https://reviews.apache.org/r/29327/diff/raw/ [2935/2935] - 29327.patch [1] error: patch failed: src/slave/containerizer/docker.cpp:499 error: src/slave/containerizer/docker.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot

Re: Review Request 34128: Enable different IP/Port for external access.

2015-05-12 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 12, 2015, 11:23 p.m., Anindya Sinha wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34128

Re: Review Request 34306: Added 'revocable_offers' field to FrameworkInfo.

2015-05-15 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 16, 2015, 12:24 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34306

Re: Review Request 34353: Added right ammount of spacing between structs

2015-05-18 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 18, 2015, 2:14 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34353

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-05-18 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On May 18, 2015, 12:56 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612

Re: Review Request 34258: Removed os::dirname and os::basename.

2015-05-17 Thread Mesos ReviewBot
] All tests passed. - Mesos ReviewBot On May 17, 2015, 10:58 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34258

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-18 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 18, 2015, 5:01 p.m., Colin Williams wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361

Re: Review Request 34195: Refactoring to use BaseFlags common functionality

2015-05-18 Thread Mesos ReviewBot
/flags.hpp: patch does not apply error: patch failed: 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp:483 error: 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On May 18, 2015, 5:28 p.m., Marco Massenzio wrote

Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-05-18 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 18, 2015, 5:41 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

2015-05-14 Thread Mesos ReviewBot
/slave/constants.cpp: patch does not apply error: patch failed: src/tests/fault_tolerance_tests.cpp:144 error: src/tests/fault_tolerance_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On May 14, 2015, 8:54 a.m., Adam B wrote

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

2015-05-14 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 14, 2015, 10:01 a.m., Adam B wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/ --- (Updated May

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

2015-05-18 Thread Mesos ReviewBot
: ./support/apply-review.sh -n -r 34308 Error: 2015-05-18 20:30:01 URL:https://reviews.apache.org/r/34308/diff/raw/ [1838/1838] - 34308.patch [1] error: patch failed: include/mesos/resources.hpp:105 error: include/mesos/resources.hpp: patch does not apply Failed to apply patch - Mesos ReviewBot

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

2015-05-18 Thread Mesos ReviewBot
: ./support/apply-review.sh -n -r 34308 Error: 2015-05-18 21:03:45 URL:https://reviews.apache.org/r/34308/diff/raw/ [1126/1126] - 34308.patch [1] error: patch failed: include/mesos/resources.hpp:189 error: include/mesos/resources.hpp: patch does not apply Failed to apply patch - Mesos ReviewBot On May

Re: Review Request 34128: Enable different IP/Port for external access.

2015-05-18 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 18, 2015, 10:08 p.m., Anindya Sinha wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34128

Re: Review Request 34375: Removed use of namespace aliases.

2015-05-18 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 18, 2015, 11:13 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34375/ --- (Updated

Re: Review Request 34359: Support multiple reasons in status update message.

2015-05-18 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 18, 2015, 6:03 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34359

Re: Review Request 34129: Add 2 optional args public_ip and public_port for libprocess to advertise.

2015-05-18 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 18, 2015, 10:08 p.m., Anindya Sinha wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34129

Re: Review Request 34378: Fixed the dependency between 'summarize' and 'model'.

2015-05-18 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 18, 2015, 11:23 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34378/ --- (Updated

Re: Review Request 34387: Moved up Slave and Framework structs in master.hpp.

2015-05-18 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 19, 2015, 1:56 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34387/ --- (Updated

Re: Review Request 33919: Integrated resources estimator with the slave.

2015-05-12 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 13, 2015, 12:37 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919

Re: Review Request 34152: Master flag validation now supports zookeeper

2015-05-13 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 13, 2015, 2:08 a.m., Tom Arnfeld wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34152/ --- (Updated

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-05-12 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On May 13, 2015, 12:22 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444

Re: Review Request 33746: Improve logging of clone flags for linux_launcher.

2015-05-12 Thread Mesos ReviewBot
. - Mesos ReviewBot On May 13, 2015, 12:23 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33746/ --- (Updated

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-17 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 17, 2015, 10:11 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

2015-05-19 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On May 19, 2015, 10:43 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34310

Re: Review Request 34442: Support manipulating scheduler affinity on Linux.

2015-05-19 Thread Mesos ReviewBot
: src/tests/sched_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On May 19, 2015, 11:32 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-19 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 19, 2015, 4:20 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-17 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On May 17, 2015, 4:54 a.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-17 Thread Mesos ReviewBot
not apply Failed to apply patch - Mesos ReviewBot On May 17, 2015, 1:32 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34318

  1   2   3   4   5   6   7   8   9   10   >