t: https://reviews.apache.org/r/43593/
Thanks,
Yongqiao Wang
)
-
src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3
Diff: https://reviews.apache.org/r/43593/diff/
Testing
---
Make && Make check.
Thanks,
Yongqiao Wang
: https://reviews.apache.org/r/42719/diff/
Testing
---
Thanks,
Yongqiao Wang
ter changing it's weight.
- Yongqiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/#review119848
---
On Feb
,
Yongqiao Wang
> On Feb. 19, 2016, 9:36 a.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1068-1070
> > <https://reviews.apache.org/r/41597/diff/54/?file=1241326#file1241326line1068>
> >
> > Why don't we need to set `reb
n out of the header, I will update this patches
later.
- Yongqiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/#review119857
---
inst set here.
Sorry to do not understand your suggestion here, current using hashmap and use
frameworkid as it's key, here to check value for allocation number for each
framework.
- Yongqiao
---
This is an automat
&& make check successfully.
Thanks,
Yongqiao Wang
/
Testing
---
make && make check successfully!
Thanks,
Yongqiao Wang
. You may look
> > at maintenance and quota for inspiration : ).
> >
> > Going further, how about extracting registry part into a separate
> > patch? It will make reviewing easier. Also, it would be great to see some
> > registry tests as well.
>
> Yongq
l.cpp
1b69fa801cd3f08cfcdce71ee3a3ca266b2fde57
Diff: https://reviews.apache.org/r/43806/diff/
Testing
---
Thanks,
Yongqiao Wang
reply, visit:
https://reviews.apache.org/r/43863/#review121078
---
On Feb. 23, 2016, 2:18 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically
src/master/weights_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/43863/diff/
Testing
---
make && make check successfully!
Thanks,
Yongqiao Wang
src/master/weights_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/43863/diff/
Testing
---
make && make check successfully!
Thanks,
Yongqiao Wang
---
On Jan. 25, 2016, 3:47 p.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
>
from 1 test case ran. (536 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
> On Feb. 27, 2016, 12:21 p.m., Adam B wrote:
> > Sorry this took me forever to get to. Looks pretty good except for some
> > indentation and some unnecessary lines.
> > I'd also like to see a couple of registrar tests, like AlexR suggested.
>
> Yongqiao Wang
"name": "*",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.0
},
{
"frameworks": [],
"name": "role1",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.8
},
{
"frameworks": [],
"name": "role2",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.0
},
{
"frameworks": [],
"name": "role3",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 3.4
}
]
}
Thanks,
Yongqiao Wang
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43824/#review121132
---
On Feb. 22, 2016, 7:23 a.m., Yongqiao Wang wrote:
>
>
set` instead. Given there are
> > two allocations, there is a guarantee, that there will be no attempts to
> > put the same framework into the set twice.
>
> Yongqiao Wang wrote:
> In the current implementation, we only need to check the allocation size
> for each framew
5f771f02db9bd098f3cd36730cd84bf2f5e87a33
Diff: https://reviews.apache.org/r/43824/diff/
Testing
---
make && make check successfully.
Thanks,
Yongqiao Wang
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review121129
---
On Feb. 19, 2016, 7:56 a.m., Yongqiao Wang wrote:
>
>
: https://reviews.apache.org/r/42719/diff/
Testing
---
Thanks,
Yongqiao Wang
file1275001line2790>
> >
> > See my comment above about how to avoid numeral suffixes.
Same comments as above.
- Yongqiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43824/#review121642
--
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1
Diff: https://reviews.apache.org/r/43824/diff/
Testing
---
make && make check successfully.
Thanks,
Yongqiao Wang
----
On Feb. 27, 2016, 12:26 p.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43806/
>
> On March 2, 2016, 2:07 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1066-1069
> > <https://reviews.apache.org/r/43806/diff/2/?file=1272996#file1272996line1066>
> >
> > For posterity, we backtick types and variable
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1
Diff: https://reviews.apache.org/r/43824/diff/
Testing
---
make && make check successfully.
Thanks,
Yongqiao Wang
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1
Diff: https://reviews.apache.org/r/43824/diff/
Testing
---
make && make check successfully.
Thanks,
Yongqiao Wang
/weights.md PRE-CREATION
Diff: https://reviews.apache.org/r/42719/diff/
Testing
---
Thanks,
Yongqiao Wang
;: "*",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.0
},
{
"frameworks": [],
"name": "role1",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.8
},
{
"frameworks": [],
"name": "role2",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.0
},
{
"frameworks": [],
"name": "role3",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 3.4
}
]
}
Thanks,
Yongqiao Wang
44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680
{"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20
{"type":"HEARTBEAT"}20
- Update the weight of role `mesos1`
$ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT
http://127.0.0.1:5050/weights
- The outstanding offer will not be rescinded.
(TODO) I will add couple of tests for this patch in another JIRA.
Thanks,
Yongqiao Wang
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1
Diff: https://reviews.apache.org/r/43824/diff/
Testing
---
make && make check successfully.
Thanks,
Yongqiao Wang
: https://reviews.apache.org/r/42719/diff/
Testing
---
Thanks,
Yongqiao Wang
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1
Diff: https://reviews.apache.org/r/43824/diff/
Testing
---
make && make check successfully.
Thanks,
Yongqiao Wang
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/#review122479
---
On March 7, 2016, 12:19 p.m., Yongqiao Wang wrote:
>
> ---
> Th
"name": "*",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.0
},
{
"frameworks": [],
"name": "role1",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.8
},
{
"frameworks": [],
"name": "role2",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 1.0
},
{
"frameworks": [],
"name": "role3",
"resources": {
"cpus": 0,
"disk": 0,
"mem": 0
},
"weight": 3.4
}
]
}
Thanks,
Yongqiao Wang
/master/weights_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/43863/diff/
Testing
---
make && make check successfully!
Thanks,
Yongqiao Wang
uest after addressing #MESOS-4316.
- Yongqiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review122488
---
On March 8, 2016
://issues.apache.org/jira/browse/MESOS-4797
Repository: mesos
Description
---
Add registry tests for /weights endpoint.
Diffs
-
src/tests/dynamic_weights_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44511/diff/
Testing
---
make && make check.
Thanks,
Yongqiao Wang
{
"role": "role3",
"weight": 3.4
},
{
"role": "role2",
"weight": 1.0
},
{
"role": "role1",
"weight": 1.8
}
]
}
(TODO) Add couple of tests in another patch.
Thanks,
Yongqiao Wang
> > 3. Generalize the method and reuse it for the 3rd instance.
Thanks very much for your detailed description.
- Yongqiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43824/#re
3e4ad31925e1b815a74d67fa3962d23fa5bc89d1
Diff: https://reviews.apache.org/r/43824/diff/
Testing
---
make && make check successfully.
Thanks,
Yongqiao Wang
docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c
src/master/flags.cpp be981ed6155edce18bdb55188c78d73182159418
Diff: https://reviews.apache.org/r/42705/diff/
Testing
---
Thanks,
Yongqiao Wang
cind":{"offer_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680
{"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20
{"type":"HEARTBEAT"}20
- Update the weight of role `mesos1`
$ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT
http://127.0.0.1:5050/weights
- The outstanding offer will not be rescinded.
(TODO) I will add couple of tests for this patch in another JIRA.
Thanks,
Yongqiao Wang
[==] 11 tests from 1 test case ran. (490 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
://reviews.apache.org/r/44511/diff/
Testing
---
make && make check.
Thanks,
Yongqiao Wang
"infos": [
{
"role": "role3",
"weight": 3.4
},
{
"role": "role2",
"weight": 1.0
},
{
"role": "role1",
"weight": 1.8
}
]
}
Has updated all tests of /weights endpoint to check the update results with
/weights GET request.
Thanks,
Yongqiao Wang
------
On March 9, 2016, 5:52 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> ---
case ran. (490 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
with `/weights`
endpoint.
3. Tests whether the `--weights` flag is ignored and use the registry value
instead when Mesos master subsequently starts with `--weights` flag still
specified.
make && make check.
Thanks,
Yongqiao Wang
g/r/44584/#comment184993>
Why adjust this order? `role` is an optional item in `/weights` `PUT`
request, and `/weights` is focus on changing the weight, so I put `weight` item
firstly.
- Yongqiao Wang
On March 10, 2016, 7:28 a.m., Neil Conway
test case ran. (490 ms total)
[ PASSED ] 11 tests.
Thanks,
Yongqiao Wang
[ OK ] Strict/RegistrarTest.UpdateWeights/1 (67 ms)
[--] 2 tests from Strict/RegistrarTest (171 ms total)
[--] Global test environment tear-down
[==] 2 tests from 1 test case ran. (178 ms total)
[ PASSED ] 2 tests.
make && make check.
Thanks,
Yongqiao Wang
ke check.
Thanks,
Yongqiao Wang
:5050/weights
Receive an rescind offer, and a new offer received:
{"rescind":{"offer_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680
{"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20
{"type":"HEARTBEAT"}20
- Update the weight of role `mesos1`
$ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT
http://127.0.0.1:5050/weights
- The outstanding offer will not be rescinded.
(TODO) I will add couple of tests for this patch in another JIRA.
Thanks,
Yongqiao Wang
---
Fix the typo.
Diffs
-
src/webui/master/static/offers.html 25e487193ae5244dde40d1de1d96ce892a7c67b9
Diff: https://reviews.apache.org/r/44888/diff/
Testing
---
Thanks,
Yongqiao Wang
,
Yongqiao Wang
:5050/weights
Receive an rescind offer, and a new offer received:
{"rescind":{"offer_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680
{"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20
{"type":"HEARTBEAT"}20
- Update the weight of role `mesos1`
$ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT
http://127.0.0.1:5050/weights
- The outstanding offer will not be rescinded.
(TODO) I will add couple of tests for this patch in another JIRA.
Thanks,
Yongqiao Wang
&& make check.
Thanks,
Yongqiao Wang
tring1 http://localhost:5050/weights | python
-mjson.tool
[
{
"role": "role3",
"weight": 3.4
},
{
"role": "role2",
"weight": 1.0
},
{
"role": "role1",
"weight": 1.8
}
]
Thanks,
Yongqiao Wang
- --:--:-- 0
* Connection #0 to host localhost left intact
No JSON object could be decoded
```
- Yongqiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44512/#review124512
1/#review124511
---
On March 22, 2016, 7:22 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
ceived:
{"rescind":{"offer_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680
{"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20
{"type":"HEARTBEAT"}20
- Update the weight of role `mesos1`
$ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT
http://127.0.0.1:5050/weights
- The outstanding offer will not be rescinded.
(TODO) I will add couple of tests for this patch in another JIRA.
Thanks,
Yongqiao Wang
ts (1059 ms)
[--] 1 test from MasterAllocatorTest/0 (1059 ms total)
[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (1070 ms total)
[ PASSED ] 1 test.
Thanks,
Yongqiao Wang
iews.apache.org/r/44450/#review124509
---
On March 23, 2016, 1:59 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To repl
tRequest
[ OK ] DynamicWeightsTest.UnauthenticatedQueryWeightRequest (81 ms)
[--] 1 test from DynamicWeightsTest (81 ms total)
[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (91 ms total)
[ PASSED ] 1 test.
Thanks,
Yongqiao Wang
> On March 21, 2016, 9:03 a.m., Adam B wrote:
> > Good start, but you're missing a few things. Are these coming in subsequent
> > patches?
> > - Authentication for GET requests
> > - Tests for GETs
> > - Documentation updates
>
> Yongqiao Wang wrote
.
make && make check.
Thanks,
Yongqiao Wang
0.0.1:5050/weights
Receive an rescind offer, and a new offer received:
{"rescind":{"offer_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O0"}},"type":"RESCIND"}680
{"offers":{"offers":[{"agent_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-S0"},"framework_id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-"},"hostname":"192.168.1.5","id":{"value":"7de42f40-2ddd-44a1-a4ff-4af932d25e02-O1"},"resources":[{"name":"cpus","role":"*","scalar":{"value":8.0},"type":"SCALAR"},{"name":"mem","role":"*","scalar":{"value":15360.0},"type":"SCALAR"},{"name":"disk","role":"*","scalar":{"value":470832.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"role":"*","type":"RANGES"}],"url":{"address":{"hostname":"192.168.1.5","ip":"192.168.1.5","port":5051},"path":"\/slave(1)","scheme":"http"}}]},"type":"OFFERS"}20
{"type":"HEARTBEAT"}20
- Update the weight of role `mesos1`
$ curl --data "[{\"weight\":2.8,\"role\":\"mesos1\"}]" -X PUT
http://127.0.0.1:5050/weights
- The outstanding offer will not be rescinded.
Thanks,
Yongqiao Wang
t.
Thanks,
Yongqiao Wang
automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45202/#review126083
---
On March 25, 2016, 9:13 a.m., Yongqiao Wang wrote:
>
> ---
> This
catorTest/0.RebalancedForUpdatedWeights
[ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (1059 ms)
[--] 1 test from MasterAllocatorTest/0 (1059 ms total)
[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (1070 ms total)
[ PASSED ] 1 test.
Thanks
104)
<https://reviews.apache.org/r/45863/#comment191446>
Mesos operator can update weight for mutilple roles at one time, so it is
better to show which role's weight is not positive to make this error message
more clearly.
- Yongqiao Wang
On April 7, 2016, 10:50 a.m., Alexande
locatorTest/0 (386 ms total)
[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (396 ms total)
[ PASSED ] 1 test.
```
Thanks,
Yongqiao Wang
(135 ms)
[--] 13 tests from DynamicWeightsTest (659 ms total)
[--] Global test environment tear-down
[==] 13 tests from 1 test case ran. (669 ms total)
[ PASSED ] 13 tests.
Thanks,
Yongqiao Wang
t Nothing'.
- Yongqiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46135/#review128640
---
On April 13, 2016, 3:21 a.m., Yongqiao W
y, visit:
https://reviews.apache.org/r/46139/#review128873
---
On April 13, 2016, 6:10 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail.
s from 1 test case ran. (669 ms total)
[ PASSED ] 13 tests.
Thanks,
Yongqiao Wang
ces, you can use
> > `Future` instead.
>
> Yongqiao Wang wrote:
> They are different variable type, 'const mesos::Resources' can not
> convert to 'const Nothing'.
>
> Alexander Rukletsov wrote:
> You use `Future` together with `FutureSatisfy`. The dif
To reply, visit:
https://reviews.apache.org/r/46135/#review128872
---
On April 13, 2016, 3:21 a.m., Yongqiao Wang wrote:
>
> ---
> This is an automatically generated e-mail.
catorTest/0.RebalancedForUpdatedWeights (385 ms)
[--] 1 test from MasterAllocatorTest/0 (386 ms total)
[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (396 ms total)
[ PASSED ] 1 test.
```
Thanks,
Yongqiao Wang
ce.
I plan to implement these functions in JIRA MESOS-3943, If you think we should
merge them together, I am happy to do that.
- Yongqiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/#review109706
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/#review109704
---
On Dec. 8, 2015, 5:20 a.m., Yongqiao Wang wrote:
>
> -
successfully
TODO: will add a test for role update.
Thanks,
Yongqiao Wang
/hierarchical_allocator_tests.cpp
e239b4746494fcc2b362a83afb634a2ce5e25f9b
Diff: https://reviews.apache.org/r/40469/diff/
Testing
---
Make successfully.
Make check successfully.
Run test framework successfully
TODO: will add a test for role update.
Thanks,
Yongqiao Wang
shown with /roles endpoint?
- Yongqiao Wang
On Dec. 14, 2015, 11:16 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
g/r/41075/#comment170181>
This function does not be called in the code diff, do we still need to
change it? can we remove it directly and rename the new function modelRole() to
mode(const string& name, double weight, Option role_)?
- Yongqiao Wang
On Dec. 14, 2015, 11:16 p.m., Neil Co
g/r/41075/#comment170190>
Roles with a non-default quota are shown in /roles endpoint, but their
quota infromation does not be shown, is it reasonalbe? Like weight, non-default
weight is shown in /roles, why non-default quota does not be shown, I think we
should keep consitence.
- Yongqia
, please
check if something is wrong.
- Yongqiao Wang
On Dec. 15, 2015, 8:56 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
sname` just
> > like the other protos?
> > Looks like isolator.proto and oversubscription.proto are missing it
> > too. Would you mind creating a separate patch to fix that?
>
> Yongqiao Wang wrote:
> I am not sure if we need to add java_package and java_outer_classn
g/r/41075/#comment170891>
I am not sure /roles will return the reserved resources of role, as far as
I know, it will return the used resources of each registered framework.
- Yongqiao Wang
On Dec. 17, 2015, 2:01 a.m., Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41075/#review110879
---
Ship it!
Ship It!
- Yongqiao Wang
On Dec. 17, 2015, 2:58 a.m
g/r/41075/#comment171108>
If the value of the specified weight is default value 1.0, do we still need
to put it in weights hashmap and pass to allocator?
- Yongqiao Wang
On Dec. 18, 2015, 1:54 a.m., Neil Conway wrote:
>
> ---
/diff/
Testing
---
Make & Make check successfully!
(TODO): Add a test for dynamic weights + allocation behavior later.
Thanks,
Yongqiao Wang
src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef
Diff: https://reviews.apache.org/r/41597/diff/
Testing
---
Make & Make check successfully!
(TODO): Add a test for dynamic weights + allocation behavior later.
Thanks,
Yongqiao Wang
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26
src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef
Diff: https://reviews.apache.org/r/41597/diff/
Testing (updated)
---
Make & Make check successfully!
Test case: https://reviews.apache.org/r/41672/
Thanks,
Yongqiao Wang
---
Thanks,
Yongqiao Wang
)
[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (340 ms total)
[ PASSED ] 1 test.
Thanks,
Yongqiao Wang
1 - 100 of 298 matches
Mail list logo
