Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review113227 --- Ship it! Committing this now, with the below change.

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review112969 --- Ship it! Great job! I'll make the one minor change and commit

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/ --- (Updated Jan. 5, 2016, 7:01 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review112951 --- Patch looks great! Reviews applied: [40429] Passed command:

Re: Review Request 40429: Report executor exit to framework schedulers.

> On Jan. 4, 2016, 11:15 a.m., Adam B wrote: > > Looks good, but you really need to set up your EXPECTations before you do > > the thing (e.g. `containerizer.destroy()`) that would trigger the > > EXPECTation. Fix these, and I'd feel comfortable committing it. > > Any further thoughts from

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review112541 --- Ship it! Looks good, but you really need to set up your

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/ --- (Updated Jan. 5, 2016, 1:14 a.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review112740 --- Ship it! Besides a few minor changes that I could make myself

Re: Review Request 40429: Report executor exit to framework schedulers.

> On Jan. 4, 2016, 11:15 a.m., Adam B wrote: > > Looks good, but you really need to set up your EXPECTations before you do > > the thing (e.g. `containerizer.destroy()`) that would trigger the > > EXPECTation. Fix these, and I'd feel comfortable committing it. > > Any further thoughts from

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review112789 --- Patch looks great! Reviews applied: [40429] Passed command:

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review111881 --- Patch looks great! Reviews applied: [40429] Passed command:

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/ --- (Updated Dec. 24, 2015, 8:29 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review111871 --- - Zhitao Li On Dec. 24, 2015, 8:29 p.m., Zhitao Li wrote: > >

Re: Review Request 40429: Report executor exit to framework schedulers.

> On Dec. 21, 2015, 5:47 a.m., Qian Zhang wrote: > > src/sched/sched.cpp, line 576 > > > > > > Why do you change the logic under "Event::MESSAGE"? I think it has > > nothing to do with this ticket. Mistread

Re: Review Request 40429: Report executor exit to framework schedulers.

> On Dec. 18, 2015, 12:04 p.m., Adam B wrote: > > CHANGELOG, line 104 > > > > > > You're modifying the 0.26 Release Notes, but this is going into 0.27 > > now. > > If this is worth calling out as an "API

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review111440 --- src/sched/sched.cpp

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review110348 --- You've got the basics down, but you need to put your EXPECT calls

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review111202 --- Patch looks great! Reviews applied: [40429] Passed command:

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/ --- (Updated Dec. 14, 2015, 8:09 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 40429: Report executor exit to framework schedulers.

> On Dec. 9, 2015, 8:02 p.m., Vinod Kone wrote: > > Few things you need to do before this can get committed > > > > 1) Send an email to the mailing list announcing this change. I hope none of > > the existing schedulers crash when they receive this callback, but we want > > to make sure. > >

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review109593 --- Few things you need to do before this can get committed 1) Send

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review107042 --- Thanks for working on this. This functionality has been missing

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/ --- (Updated Nov. 18, 2015, 7:20 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review107076 --- Ship it! LGTM! Just some minor newline nits.

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review106993 --- Patch looks great! Reviews applied: [40429] Passed command:

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review107122 --- src/sched/sched.cpp (line 1072)

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review107101 --- Patch looks great! Reviews applied: [40429] Passed command:

Re: Review Request 40429: Report executor exit to framework schedulers.

> On Nov. 19, 2015, 3:29 a.m., Guangya Liu wrote: > > src/sched/sched.cpp, line 1073 > > > > > > s/VLOG(1)/LOG(WARNING) The logging level here is consistent with lostSlave above: ``` if (from !=

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/ --- (Updated Nov. 18, 2015, 9:50 p.m.) Review request for mesos, Adam B and Vinod