[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179296427 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala --- @@ -0,0 +1,135 @@ +/*

[GitHub] spark pull request #20955: [SPARK-23838][WEBUI] Running SQL query is display...

2018-04-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20955 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread mccheah
Github user mccheah commented on the issue: https://github.com/apache/spark/pull/20910 Latest commits address @kimoonkim and @liyinan926's comments. Also fixed merge conflicts related to https://github.com/apache/spark/pull/20811 @andrusha ---

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20910 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20910 **[Test build #88912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88912/testReport)** for PR 20910 at commit

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20910 **[Test build #88912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88912/testReport)** for PR 20910 at commit

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20910 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20910 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88912/ Test PASSed. ---

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20910 **[Test build #88915 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88915/testReport)** for PR 20910 at commit

[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20961 **[Test build #88909 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88909/testReport)** for PR 20961 at commit

[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20961 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19193: [WIP][SPARK-21896][SQL] Fix Stack Overflow when window f...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19193 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88910/ Test PASSed. ---

[GitHub] spark issue #19193: [WIP][SPARK-21896][SQL] Fix Stack Overflow when window f...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19193 **[Test build #88910 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88910/testReport)** for PR 19193 at commit

[GitHub] spark issue #19193: [WIP][SPARK-21896][SQL] Fix Stack Overflow when window f...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19193 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179297415 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -175,49 +138,41 @@

[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression

2018-04-04 Thread JiahuiJiang
Github user JiahuiJiang commented on the issue: https://github.com/apache/spark/pull/20961 @hvanhovell added a test, before this change the origin would be undefined --- - To unsubscribe, e-mail:

[GitHub] spark issue #19193: [WIP][SPARK-21896][SQL] Fix Stack Overflow when window f...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19193 **[Test build #88910 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88910/testReport)** for PR 19193 at commit

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20962 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1981/

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20962 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20965 **[Test build #88918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88918/testReport)** for PR 20965 at commit

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20965 **[Test build #88917 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88917/testReport)** for PR 20965 at commit

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88917/ Test FAILed. ---

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1983/

[GitHub] spark issue #20937: [SPARK-23094][SPARK-23723][SPARK-23724][SQL] Support cus...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20937 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88907/ Test PASSed. ---

[GitHub] spark issue #20937: [SPARK-23094][SPARK-23723][SPARK-23724][SQL] Support cus...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20937 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179332522 --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -515,7 +518,8 @@ public void writeToOutputStreamUnderflow()

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179335313 --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -515,7 +518,8 @@ public void writeToOutputStreamUnderflow()

[GitHub] spark issue #20778: [SPARK-23584][SQL] NewInstance should support interprete...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20778 **[Test build #88920 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88920/testReport)** for PR 20778 at commit

[GitHub] spark issue #20786: [SPARK-14681][ML] Provide label/impurity stats for spark...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20786 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88914/ Test FAILed. ---

[GitHub] spark issue #20786: [SPARK-14681][ML] Provide label/impurity stats for spark...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20786 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20933 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20955: [SPARK-23838][WEBUI] Running SQL query is displayed as "...

2018-04-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20955 Merging to master / 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20781: [SPARK-23637][YARN]Yarn might allocate more resou...

2018-04-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20781 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread mccheah
Github user mccheah commented on the issue: https://github.com/apache/spark/pull/20910 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20945: [SPARK-23790][Mesos] fix metastore connection issue

2018-04-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20945 SPARK-20982 doesn't look particularly hard to fix. I don't understand the differences between plain Mesos and DC/OS so a lot of the things you're saying are over my head. I'm just concerned

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20910 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19675: [SPARK-14540][BUILD] Support Scala 2.12 closures and Jav...

2018-04-04 Thread retronym
Github user retronym commented on the issue: https://github.com/apache/spark/pull/19675 I suppose the problematic case is: ``` scala> :javap p2.C$D#$anonfun$test$1 public static final java.lang.String $anonfun$test$1(p2.C$D, java.lang.String); descriptor:

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/20910 LGTM with only one comment. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179315793 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -45,38 +45,162 @@ */ public static final int

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179319738 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java --- @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179319478 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java --- @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20962 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88908/ Test FAILed. ---

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179320913 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java --- @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179321572 --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -515,7 +518,8 @@ public void writeToOutputStreamUnderflow()

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179331924 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java --- @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #20757: [SPARK-23595][SQL] ValidateExternalType should support i...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20757 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1984/

[GitHub] spark issue #20757: [SPARK-23595][SQL] ValidateExternalType should support i...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20757 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-04 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20890 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20953: [SPARK-23822][SQL] Improve error message for Parq...

2018-04-04 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20953#discussion_r179342708 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala --- @@ -382,6 +384,59 @@ class

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179297367 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -175,49 +138,41 @@

[GitHub] spark issue #20781: [SPARK-23637][YARN]Yarn might allocate more resource if ...

2018-04-04 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20781 Merging to master / 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20910 **[Test build #88913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88913/testReport)** for PR 20910 at commit

[GitHub] spark issue #19675: [SPARK-14540][BUILD] Support Scala 2.12 closures and Jav...

2018-04-04 Thread retronym
Github user retronym commented on the issue: https://github.com/apache/spark/pull/19675 It just occurred to me that my answer above, discussing ways to access the bytecode of the lambda class, aren't really relevant here. The structure of the lambda class is always the same: it just

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20910 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20910 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88915/ Test PASSed. ---

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179318575 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java --- @@ -48,6 +49,16 @@ public static int

[GitHub] spark pull request #20913: [SPARK-23799] FilterEstimation.evaluateInSet prod...

2018-04-04 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20913#discussion_r179322407 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -427,7 +427,11 @@ case

[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20961 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88909/ Test FAILed. ---

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20962 **[Test build #88916 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88916/testReport)** for PR 20962 at commit

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20965 **[Test build #88917 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88917/testReport)** for PR 20965 at commit

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20965 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1982/

[GitHub] spark issue #20757: [SPARK-23595][SQL] ValidateExternalType should support i...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20757 **[Test build #88919 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88919/testReport)** for PR 20757 at commit

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20890 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20890 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1986/

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20890 **[Test build #88921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88921/testReport)** for PR 20890 at commit

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20933 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1988/

[GitHub] spark issue #20970: [SPARK-23870][ML] Forward RFormula handleInvalid Param t...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20970 **[Test build #88911 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88911/testReport)** for PR 20970 at commit

[GitHub] spark issue #20970: [SPARK-23870][ML] Forward RFormula handleInvalid Param t...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20970 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20970: [SPARK-23870][ML] Forward RFormula handleInvalid Param t...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20970 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88911/ Test PASSed. ---

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179321207 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java --- @@ -19,15 +19,21 @@ import

[GitHub] spark issue #20786: [SPARK-14681][ML] Provide label/impurity stats for spark...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20786 **[Test build #88914 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88914/testReport)** for PR 20786 at commit

[GitHub] spark pull request #20953: [SPARK-23822][SQL] Improve error message for Parq...

2018-04-04 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20953#discussion_r179343192 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaColumnConvertNotSupportedException.java --- @@ -0,0

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20933 **[Test build #88923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88923/testReport)** for PR 20933 at commit

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20976 **[Test build #88903 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88903/testReport)** for PR 20976 at commit

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20976 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88903/ Test FAILed. ---

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20976 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20910 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1977/

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20910 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1943/ ---

[GitHub] spark issue #20786: [SPARK-14681][ML] Provide label/impurity stats for spark...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20786 **[Test build #88914 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88914/testReport)** for PR 20786 at commit

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179333954 --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -515,7 +518,8 @@ public void writeToOutputStreamUnderflow()

[GitHub] spark issue #20778: [SPARK-23584][SQL] NewInstance should support interprete...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20778 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1985/

[GitHub] spark issue #20778: [SPARK-23584][SQL] NewInstance should support interprete...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20778 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20977: [SPARK-23867][Scheduler] use droppedCount in logW...

2018-04-04 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/20977#discussion_r179338562 --- Diff: core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala --- @@ -166,7 +166,7 @@ private class AsyncEventQueue(val name: String,

[GitHub] spark issue #20786: [SPARK-14681][ML] Provide label/impurity stats for spark...

2018-04-04 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20786 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20937: [SPARK-23094][SPARK-23723][SPARK-23724][SQL] Support cus...

2018-04-04 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/20937 Seems fine to me ... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20874: [WIP][SPARK-23763][SQL] OffHeapColumnVector uses MemoryB...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20874 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20910 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1978/

[GitHub] spark issue #20874: [WIP][SPARK-23763][SQL] OffHeapColumnVector uses MemoryB...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20874 **[Test build #88904 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88904/testReport)** for PR 20874 at commit

[GitHub] spark issue #20910: [SPARK-22839] [K8s] Refactor to unify driver and executo...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20910 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20874: [WIP][SPARK-23763][SQL] OffHeapColumnVector uses MemoryB...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20874 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88904/ Test PASSed. ---

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179315071 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -45,38 +45,162 @@ */ public static final int

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179320302 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/ByteArrayMemoryBlock.java --- @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #20913: [SPARK-23799] FilterEstimation.evaluateInSet prod...

2018-04-04 Thread apache-hivemall
Github user apache-hivemall commented on a diff in the pull request: https://github.com/apache/spark/pull/20913#discussion_r179322297 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -427,7 +427,11 @@

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-04 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179335019 --- Diff: common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -515,7 +518,8 @@ public void writeToOutputStreamUnderflow()

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20962 **[Test build #88908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88908/testReport)** for PR 20962 at commit

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20962 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20962 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1975/

  1   2   3   4   5   >