[GitHub] [spark] maropu commented on a change in pull request #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-10-23 Thread GitBox
maropu commented on a change in pull request #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#discussion_r338382197 ## File path:

[GitHub] [spark] maropu commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-10-23 Thread GitBox
maropu commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#issuecomment-545745432 Can you update the title? `Support sub-queries in join conditions`?

[GitHub] [spark] AmplabJenkins removed a comment on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26237#issuecomment-545750786 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26237#issuecomment-545750782 Merged build finished. Test PASSed.

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25854: [SPARK-29145][SQL] Support sub-queries in join conditions

2019-10-23 Thread GitBox
AngersZh commented on a change in pull request #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#discussion_r338387047 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala ##

[GitHub] [spark] maropu commented on issue #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect

2019-10-23 Thread GitBox
maropu commented on issue #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect URL: https://github.com/apache/spark/pull/26230#issuecomment-545757199 Can you add some tests in `JDBCSuite`? You can see the other examples there, e.g.,

[GitHub] [spark] maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect

2019-10-23 Thread GitBox
maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect URL: https://github.com/apache/spark/pull/26230#discussion_r338391294 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect

2019-10-23 Thread GitBox
maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect URL: https://github.com/apache/spark/pull/26230#discussion_r338390391 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect

2019-10-23 Thread GitBox
maropu commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect URL: https://github.com/apache/spark/pull/26230#discussion_r338391122 ## File path:

[GitHub] [spark] HyukjinKwon commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema.

2019-10-23 Thread GitBox
HyukjinKwon commented on issue #26118: [SPARK-24915][Python] Fix Row handling with Schema. URL: https://github.com/apache/spark/pull/26118#issuecomment-545746315 Seems making sense to me. This is an automated message from

[GitHub] [spark] cloud-fan commented on a change in pull request #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
cloud-fan commented on a change in pull request #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#discussion_r338384646 ## File path: sql/core/benchmarks/IntervalBenchmark-results.txt ## @@ -1,25 +1,25 @@ -Java

[GitHub] [spark] SparkQA commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions

2019-10-23 Thread GitBox
SparkQA commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545752072 **[Test build #112585 has

[GitHub] [spark] AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545752446 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545752471 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545752463 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545752440 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] maropu commented on a change in pull request #26114: [SPARK-29468][SQL] Change Literal.sql to be correct for floats.

2019-10-23 Thread GitBox
maropu commented on a change in pull request #26114: [SPARK-29468][SQL] Change Literal.sql to be correct for floats. URL: https://github.com/apache/spark/pull/26114#discussion_r338379260 ## File path:

[GitHub] [spark] SparkQA commented on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands

2019-10-23 Thread GitBox
SparkQA commented on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26237#issuecomment-545750405 **[Test build #112576 has

[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545750607 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545750607 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545750602 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545750560 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26237#issuecomment-545750786 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26237#issuecomment-545750782 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545750554 Build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545750602 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545750560 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545750554 Build finished. Test PASSed. This is an automated message

[GitHub] [spark] SparkQA removed a comment on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands

2019-10-23 Thread GitBox
SparkQA removed a comment on issue #26237: [SPARK-29526][SQL] UNCACHE TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26237#issuecomment-545704979 **[Test build #112576 has

[GitHub] [spark] AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545754294 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] HyukjinKwon commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-10-23 Thread GitBox
HyukjinKwon commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-545754103 Looks making sense to me. cc @maryannxue, @maropu, @cloud-fan

[GitHub] [spark] AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545754298 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545753982 **[Test build #112587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112587/testReport)** for PR

[GitHub] [spark] AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545752471 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #25854: [SPARK-29145][SQL] Support sub-queries in join conditions URL: https://github.com/apache/spark/pull/25854#issuecomment-545752463 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545752440 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545752446 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats

2019-10-23 Thread GitBox
HyukjinKwon commented on a change in pull request #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats URL: https://github.com/apache/spark/pull/26016#discussion_r338386395 ## File path:

[GitHub] [spark] SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545750297 **[Test build #112584 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112584/testReport)** for PR

[GitHub] [spark] PavithraRamachandran commented on a change in pull request #26138: [SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab

2019-10-23 Thread GitBox
PavithraRamachandran commented on a change in pull request #26138: [SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab URL: https://github.com/apache/spark/pull/26138#discussion_r338386018 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-10-23 Thread GitBox
HyukjinKwon commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#discussion_r338391078 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-10-23 Thread GitBox
HyukjinKwon commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#discussion_r338390931 ## File path:

[GitHub] [spark] PavithraRamachandran commented on issue #26222: [SPARK-29504][WebUI] Toggle full job description on click

2019-10-23 Thread GitBox
PavithraRamachandran commented on issue #26222: [SPARK-29504][WebUI] Toggle full job description on click URL: https://github.com/apache/spark/pull/26222#issuecomment-545740477 @gengliangwang thank you . Could you merge?

[GitHub] [spark] AmplabJenkins removed a comment on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py URL: https://github.com/apache/spark/pull/26232#issuecomment-545744459 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545752071 **[Test build #112586 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112586/testReport)** for PR

[GitHub] [spark] AmplabJenkins commented on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4)

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4) URL: https://github.com/apache/spark/pull/26238#issuecomment-545755378 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4)

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4) URL: https://github.com/apache/spark/pull/26238#issuecomment-545755371 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] SparkQA removed a comment on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4)

2019-10-23 Thread GitBox
SparkQA removed a comment on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4) URL: https://github.com/apache/spark/pull/26238#issuecomment-545709744 **[Test build #112578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112578/testReport)**

[GitHub] [spark] AmplabJenkins removed a comment on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4)

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4) URL: https://github.com/apache/spark/pull/26238#issuecomment-545755371 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4)

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4) URL: https://github.com/apache/spark/pull/26238#issuecomment-545755378 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26138: [SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26138: [SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab URL: https://github.com/apache/spark/pull/26138#issuecomment-542617331 Can one of the admins verify this patch?

[GitHub] [spark] maropu commented on issue #25344: [SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect

2019-10-23 Thread GitBox
maropu commented on issue #25344: [SPARK-28151][SQL] Mapped ByteType to TinyINT for MsSQLServerDialect URL: https://github.com/apache/spark/pull/25344#issuecomment-545746972 That should be like this?

[GitHub] [spark] HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type

2019-10-23 Thread GitBox
HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-545746713 This patch is a bit hard to say a bug fix (as pointed out at

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats

2019-10-23 Thread GitBox
HyukjinKwon commented on a change in pull request #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats URL: https://github.com/apache/spark/pull/26016#discussion_r338388607 ## File path:

[GitHub] [spark] habren closed pull request #24663: [SPARK-27792][SQL] SkewJoin--handle only skewed keys with broadcastjoin

2019-10-23 Thread GitBox
habren closed pull request #24663: [SPARK-27792][SQL] SkewJoin--handle only skewed keys with broadcastjoin URL: https://github.com/apache/spark/pull/24663 This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] AmplabJenkins removed a comment on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py URL: https://github.com/apache/spark/pull/26232#issuecomment-545744462 Test PASSed. Refer to this link for build results (access rights

[GitHub] [spark] SparkQA commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py

2019-10-23 Thread GitBox
SparkQA commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py URL: https://github.com/apache/spark/pull/26232#issuecomment-545744186 **[Test build #112583 has

[GitHub] [spark] AmplabJenkins commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py URL: https://github.com/apache/spark/pull/26232#issuecomment-545744462 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py URL: https://github.com/apache/spark/pull/26232#issuecomment-545744459 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4)

2019-10-23 Thread GitBox
SparkQA commented on issue #26238: [SPARK-29110][SQL][TESTS] Port window.sql (Part 4) URL: https://github.com/apache/spark/pull/26238#issuecomment-545754953 **[Test build #112578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112578/testReport)** for PR

[GitHub] [spark] AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545754298 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545754294 Merged build finished. Test PASSed. This is an

[GitHub] [spark] wangyum commented on issue #26138: [SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab

2019-10-23 Thread GitBox
wangyum commented on issue #26138: [SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab URL: https://github.com/apache/spark/pull/26138#issuecomment-545758101 ok to test This is an

[GitHub] [spark] cloud-fan commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
cloud-fan commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545756654 The last argument is about performance: https://github.com/apache/spark/pull/26190#discussion_r338206250 My point is that:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
dongjoon-hyun commented on a change in pull request #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#discussion_r337953103 ## File path:

[GitHub] [spark] HyukjinKwon commented on issue #24896: [WIP][SPARK-28006] User-defined grouped transform pandas_udf for window operations

2019-10-23 Thread GitBox
HyukjinKwon commented on issue #24896: [WIP][SPARK-28006] User-defined grouped transform pandas_udf for window operations URL: https://github.com/apache/spark/pull/24896#issuecomment-545372217 @BryanCutler, I think yes for both questions. BTW, I guess the same should be something similar

[GitHub] [spark] AmplabJenkins commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545371817 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545371821 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545371821 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545371817 Merged build finished. Test PASSed.

[GitHub] [spark] juliuszsompolski commented on a change in pull request #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift protocol

2019-10-23 Thread GitBox
juliuszsompolski commented on a change in pull request #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift protocol URL: https://github.com/apache/spark/pull/26221#discussion_r337965448 ## File path: sql/thriftserver/if/TCLIService.thrift

[GitHub] [spark] AngersZhuuuu commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-10-23 Thread GitBox
AngersZh commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#issuecomment-545376935 @dilipbiswal Add more UT, result is ok, I wonder if it covers all the cases you want

[GitHub] [spark] SparkQA commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-10-23 Thread GitBox
SparkQA commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-545376748 **[Test build #112532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112532/testReport)** for PR

[GitHub] [spark] cloud-fan commented on a change in pull request #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
cloud-fan commented on a change in pull request #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#discussion_r337967969 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/IntervalBenchmark.scala

[GitHub] [spark] AmplabJenkins commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-545377262 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-545377274 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#issuecomment-545377249 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#issuecomment-545377258 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
cloud-fan commented on a change in pull request #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#discussion_r337974040 ## File path: sql/core/benchmarks/IntervalBenchmark-results.txt ## @@ -1,25 +1,23 @@ -Java

[GitHub] [spark] AmplabJenkins removed a comment on issue #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26183#issuecomment-545382200 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide

2019-10-23 Thread GitBox
HyukjinKwon commented on a change in pull request #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide URL: https://github.com/apache/spark/pull/26110#discussion_r337981832 ## File path: docs/sql-pyspark-pandas-with-arrow.md ## @@ -178,6 +178,41 @@ For

[GitHub] [spark] AmplabJenkins commented on issue #26222: [SPARK-29504][WebUI]show full decription when double click on ellipse

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26222: [SPARK-29504][WebUI]show full decription when double click on ellipse URL: https://github.com/apache/spark/pull/26222#issuecomment-545393338 Merged build finished. Test PASSed. This

[GitHub] [spark] SparkQA removed a comment on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-10-23 Thread GitBox
SparkQA removed a comment on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#issuecomment-545303268 **[Test build #112521 has

[GitHub] [spark] SparkQA commented on issue #26200: [SPARK-29542][SQL][DOC] Make the descriptions of spark.sql.files.* be clearly

2019-10-23 Thread GitBox
SparkQA commented on issue #26200: [SPARK-29542][SQL][DOC] Make the descriptions of spark.sql.files.* be clearly URL: https://github.com/apache/spark/pull/26200#issuecomment-545393398 **[Test build #112518 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26222: [SPARK-29504][WebUI]show full decription when double click on ellipse

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26222: [SPARK-29504][WebUI]show full decription when double click on ellipse URL: https://github.com/apache/spark/pull/26222#issuecomment-545393342 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-545393330 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-545393323 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #26222: [SPARK-29504][WebUI]show full decription when double click on ellipse

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26222: [SPARK-29504][WebUI]show full decription when double click on ellipse URL: https://github.com/apache/spark/pull/26222#issuecomment-545393342 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#issuecomment-545393664 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN"

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#issuecomment-545393676 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26222: [SPARK-29504][WebUI]show full decription when double click on ellipse

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26222: [SPARK-29504][WebUI]show full decription when double click on ellipse URL: https://github.com/apache/spark/pull/26222#issuecomment-545393338 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-545393323 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-545393330 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AngersZhuuuu commented on issue #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift protocol

2019-10-23 Thread GitBox
AngersZh commented on issue #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift protocol URL: https://github.com/apache/spark/pull/26221#issuecomment-545397687 @juliuszsompolski Do we need to add cpp/r/py ? Hive add all this and build a python

[GitHub] [spark] AmplabJenkins commented on issue #26223: [WIP][SPARK-29564][SQL] Cluster deploy mode should support Spark Thrift server

2019-10-23 Thread GitBox
AmplabJenkins commented on issue #26223: [WIP][SPARK-29564][SQL] Cluster deploy mode should support Spark Thrift server URL: https://github.com/apache/spark/pull/26223#issuecomment-545397072 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26223: [WIP][SPARK-29564][SQL] Cluster deploy mode should support Spark Thrift server

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26223: [WIP][SPARK-29564][SQL] Cluster deploy mode should support Spark Thrift server URL: https://github.com/apache/spark/pull/26223#issuecomment-545397072 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26223: [WIP][SPARK-29564][SQL] Cluster deploy mode should support Spark Thrift server

2019-10-23 Thread GitBox
AmplabJenkins removed a comment on issue #26223: [WIP][SPARK-29564][SQL] Cluster deploy mode should support Spark Thrift server URL: https://github.com/apache/spark/pull/26223#issuecomment-545397068 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing

2019-10-23 Thread GitBox
SparkQA removed a comment on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545337472 **[Test build #112526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112526/testReport)**

[GitHub] [spark] zhengruifeng commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-23 Thread GitBox
zhengruifeng commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-545402172 I manually tested this PR in repl in the past days, with some datasets in `/data/mllib`, set relative params to in normal

[GitHub] [spark] wangyum commented on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab

2019-10-23 Thread GitBox
wangyum commented on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab URL: https://github.com/apache/spark/pull/26226#issuecomment-545425114 ok to test This is an automated message from the Apache Git Service.

  1   2   3   4   5   6   7   8   9   10   >