Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83420249
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +104,191 @@ private[ml] class WeightedLeastSquares(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83421445
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +104,191 @@ private[ml] class WeightedLeastSquares(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83428359
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -201,11 +476,13 @@ class WeightedLeastSquaresSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83408577
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83425844
--- Diff:
mllib-local/src/test/scala/org/apache/spark/ml/linalg/BLASSuite.scala ---
@@ -422,4 +422,49 @@ class BLASSuite extends SparkMLFunSuite {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83425552
--- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/BLAS.scala
---
@@ -244,6 +244,23 @@ private[spark] object BLAS extends Serializable {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83422603
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +104,191 @@ private[ml] class WeightedLeastSquares(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83413947
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83420840
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +104,191 @@ private[ml] class WeightedLeastSquares(
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83091619
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -45,34 +47,48 @@ private[ml] class WeightedLeastSquaresModel(
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83079711
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -60,24 +60,87 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83090088
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83090919
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -45,34 +47,48 @@ private[ml] class WeightedLeastSquaresModel(
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83086536
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -132,24 +197,234 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83091695
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +101,193 @@ private[ml] class WeightedLeastSquares(
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83084385
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -132,24 +197,234 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83086860
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -201,11 +476,13 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83079621
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -60,24 +60,87 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83081588
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -60,24 +60,87 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83091585
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -45,34 +47,48 @@ private[ml] class WeightedLeastSquaresModel(
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83078777
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +101,193 @@ private[ml] class WeightedLeastSquares(
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83069767
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83087184
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -757,8 +761,9 @@ class LinearRegressionSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83041314
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -132,24 +197,234 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83091607
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -45,34 +47,48 @@ private[ml] class WeightedLeastSquaresModel(
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83084435
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -132,24 +197,234 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83072526
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +101,193 @@ private[ml] class WeightedLeastSquares(
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83086545
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -132,24 +197,234 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83113222
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -132,24 +197,234 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83086848
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -201,11 +476,13 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83089207
--- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/BLAS.scala
---
@@ -244,6 +244,15 @@ private[spark] object BLAS extends Serializable {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83079430
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -286,6 +434,24 @@ private[ml] object WeightedLeastSquares {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83082013
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -60,24 +60,87 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83078820
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +101,193 @@ private[ml] class WeightedLeastSquares(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82996998
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -132,24 +197,234 @@ class WeightedLeastSquaresSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82979581
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -201,11 +476,13 @@ class WeightedLeastSquaresSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82999864
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -45,34 +47,48 @@ private[ml] class WeightedLeastSquaresModel(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83004676
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +101,193 @@ private[ml] class WeightedLeastSquares(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82976378
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -60,24 +60,87 @@ class WeightedLeastSquaresSuite extends
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82978203
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -60,24 +60,87 @@ class WeightedLeastSquaresSuite extends
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83013547
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -757,8 +761,9 @@ class LinearRegressionSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83021809
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82980129
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -132,24 +197,234 @@ class WeightedLeastSquaresSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83001469
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -45,34 +47,48 @@ private[ml] class WeightedLeastSquaresModel(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83027710
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -217,7 +215,7 @@ class LinearRegression @Since("1.3.0")
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83016461
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +101,193 @@ private[ml] class WeightedLeastSquares(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82980460
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -132,24 +197,234 @@ class WeightedLeastSquaresSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83006722
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +101,193 @@ private[ml] class WeightedLeastSquares(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82975032
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -60,24 +60,87 @@ class WeightedLeastSquaresSuite extends
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83006938
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +101,193 @@ private[ml] class WeightedLeastSquares(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83004415
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +101,193 @@ private[ml] class WeightedLeastSquares(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83022418
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83021228
--- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/BLAS.scala
---
@@ -244,6 +244,15 @@ private[spark] object BLAS extends Serializable {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83010921
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -132,24 +197,234 @@ class WeightedLeastSquaresSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83025262
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r83020033
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -201,11 +476,13 @@ class WeightedLeastSquaresSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82967639
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -286,6 +434,24 @@ private[ml] object WeightedLeastSquares {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82979921
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -132,24 +197,234 @@ class WeightedLeastSquaresSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82994352
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -60,24 +60,87 @@ class WeightedLeastSquaresSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82648263
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -217,7 +215,7 @@ class LinearRegression @Since("1.3.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82647560
--- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/BLAS.scala
---
@@ -244,6 +244,15 @@ private[spark] object BLAS extends Serializable {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82647370
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82504017
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/NormalEquationSolver.scala ---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82503897
--- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/BLAS.scala
---
@@ -244,6 +244,15 @@ private[spark] object BLAS extends Serializable {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82503779
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -217,7 +215,7 @@ class LinearRegression @Since("1.3.0")
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82503417
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -45,34 +47,48 @@ private[ml] class WeightedLeastSquaresModel(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82503493
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -45,34 +47,48 @@ private[ml] class WeightedLeastSquaresModel(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82503487
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -45,34 +47,48 @@ private[ml] class WeightedLeastSquaresModel(
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15394#discussion_r82466110
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -85,73 +101,193 @@ private[ml] class WeightedLeastSquares(
GitHub user sethah opened a pull request:
https://github.com/apache/spark/pull/15394
[SPARK-17749][ML] One pass solver for Weighted Least Squares with ElasticNet
## What changes were proposed in this pull request?
1. Make a pluggable solver interface for
70 matches
Mail list logo
