Hello again in this thread,
A little heads up for anyone who will be changing webrev.sh in
substantial way (adding/removing command line options):
As Darren (Cc'ed) mentioned in CR 6751994, adding an option to webrev.sh
should be accompanied by change in cdm.py:cmdtable. Unfortunately, there
Running the tests and reading the man page changes again I realized
there is an aspect of webrev behavior which might not be obvious:
'webrev -U' will store the webrev to local directory named "webrev" and
upload it to remote host with directory name equal to dirname of local
workspace/reposit
John Plocher wrote:
> I'm not a webrev expert, but here's a few nits...
>
> usr/src/tools/scripts/webrev.1:
> 371 For custom remote targets, -t option allows to specify all
> components:
>
> Better: -t option allows one to provide a completely specified upload
> target
>
> Q: Does
Hi all again,
This review request is still missing code reviewers. If someone feels
bored or even interested, please take a look:
http://cr.opensolaris.org/~vkotal/webrev_upload.onnv/
Thanks,
v.
Vladimir Kotal wrote:
> Hi all again,
>
> This review request is still missing code reviewers. If someone feels
> bored or even interested, please take a look:
>
>http://cr.opensolaris.org/~vkotal/webrev_upload.onnv/
>
> Thanks,
>
>
> v.
> ___
Vladimir Kotal wrote:
> $ webrev -O -p original_webrev \
> -o $CODEMGR_WS/incremental_webrev -U
>
> will upload the webrev to this location:
>http://cr.opensolaris.org/incremental_webrev/
Of course I rather meant:
http://cr.opensolaris.org/~OSOL_USERNAME/incremental_webrev/
v.
Vladimir Kotal wrote:
> Vladimir Kotal wrote:
>
>
>
>> The webrev has been updated to include code which implements the above:
>>http://cr.opensolaris.org/~vkotal/webrev_upload.onnv/
>
> Just to give an idea of the capabilities of current version here is the
> list of "unit tests":
>
> po
Vladimir Kotal wrote:
> The webrev has been updated to include code which implements the above:
>http://cr.opensolaris.org/~vkotal/webrev_upload.onnv/
Just to give an idea of the capabilities of current version here is the
list of "unit tests":
positive:
- SSH
webrev -O -U -t ssh:
> > Please don't use -r to indicate rsync; I want to reserve that for
> > "revision", to enable the ability to create a webrev based on one or more
> > revisions in a tree. I have working code for this, but it was rejected
> > some time ago (didn't take care of some unusual corner cases, I think)
On Tue, 2008-09-30 at 18:54 +0200, Vladimir Marek wrote:
> > > Please don't use -r to indicate rsync; I want to reserve that for
> > > "revision", to enable the ability to create a webrev based on one or more
> > > revisions in a tree. I have working code for this, but it was rejected
> > > some t
Danek Duvall wrote:
> On Fri, Sep 26, 2008 at 03:01:20PM +0200, Vladimir Kotal wrote:
>
>> - rsync user with remote host
>>webrev -r -U -h some_host.org
>>
>> - rsync user with custom directory
>>(local file-system copy, just for demonstration)
>>webrev -r -U -d /foo/bar/fix.webrev
>
Gordon Ross wrote:
>> ???> Also, usually we do not want to upload non-OSol webrevs to
>>> cr.opensolaris.org which also speaks for current state of the code (on
>>> the other hand, the upload-trigger option can be limited to -O, sigh).
>> I pretty much never publish a webrev without intervening s
On Fri, Sep 26, 2008 at 03:01:20PM +0200, Vladimir Kotal wrote:
> - rsync user with remote host
>webrev -r -U -h some_host.org
>
> - rsync user with custom directory
>(local file-system copy, just for demonstration)
>webrev -r -U -d /foo/bar/fix.webrev
Please don't use -r to indicate
> ???> Also, usually we do not want to upload non-OSol webrevs to
> > cr.opensolaris.org which also speaks for current state of the code (on
> > the other hand, the upload-trigger option can be limited to -O, sigh).
>
> I pretty much never publish a webrev without intervening steps. Those
> i
> ???Vladimir Kotal wrote:
> > Vladimir Kotal wrote:
> >
> >
> >
> >> new webrev is here:
> >>http://cr.opensolaris.org/~vkotal/webrev_upload.onnv/
[...]
> Personally, I generate them to look at them first. After I'm certain I
> haven't missed anything, then I upload them.
>
> I ended u
Dan Price wrote:
> I would suggest that upload be enabled via a separate flag.
Already done (after Shawn's e-mail) as -U flag.
> -O was really intended to be an ON specific hack, when I added it.
> Some consolidations (like packaging and the installer) are using
> defect.opensolaris.org and -O
On Wed 24 Sep 2008 at 09:17PM, Vladimir Kotal wrote:
> Vladimir Kotal wrote:
>
>
>
> > new webrev is here:
> >http://cr.opensolaris.org/~vkotal/webrev_upload.onnv/
>
> For potential reviewers: I am little bit torn between upload by default
> with -O and having an option to trigger the uplo
Shawn Walker wrote:
> Personally, I generate them to look at them first. After I'm certain I
> haven't missed anything, then I upload them.
okay. Thinking about it for a little more, it makes sense to follow the
classic UNIX school and have extra option for the upload trigger.
webrev refresh
Vladimir Kotal wrote:
> Vladimir Kotal wrote:
>
>
>
>> new webrev is here:
>>http://cr.opensolaris.org/~vkotal/webrev_upload.onnv/
>
> For potential reviewers: I am little bit torn between upload by default
> with -O and having an option to trigger the upload.
>
> It's the question of sta
19 matches
Mail list logo
