Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

2024-05-13 Thread Kevin Driver
On Tue, 14 May 2024 00:12:23 GMT, Weijun Wang wrote: >> What would we say in the javadoc? We throw `null` temporarily, since there >> are no known algorithms that support parameters? We may not want to issue a >> change/fix if this becomes no longer the case (ie- some provider besides us >>

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v3]

2024-05-13 Thread ExE Boss
On Mon, 13 May 2024 11:47:38 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

2024-05-13 Thread Weijun Wang
On Mon, 13 May 2024 23:08:41 GMT, Kevin Driver wrote: >> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java >> line 81: >> >>> 79: * if the initialization parameters are inappropriate for this >>> {@code KDFSpi} >>> 80: */ >>> 81: protected

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

2024-05-13 Thread Kevin Driver
On Mon, 13 May 2024 20:48:31 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> code review comments > > src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java > line 81: > >>

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v44]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v43]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v42]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with four additional commits since

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]

2024-05-13 Thread Kevin Driver
On Mon, 13 May 2024 09:27:57 GMT, Alan Bateman wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-enable preview annotations > > src/java.base/share/classes/javax/crypto/KDF.java line 457: > >> 455: * >>

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v41]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v40]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

2024-05-13 Thread Weijun Wang
On Mon, 13 May 2024 22:34:04 GMT, Kevin Driver wrote: >> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java >> line 237: >> >>> 235: } catch (InvalidKeyException ike) { >>> 236: throw new InvalidParameterSpecException( >>> 237:

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v39]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

2024-05-13 Thread Kevin Driver
On Mon, 13 May 2024 20:27:46 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> code review comments > > src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java > line 237: > >>

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v38]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]

2024-05-13 Thread Kevin Driver
On Mon, 13 May 2024 14:12:17 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-enable preview annotations > > src/java.base/share/classes/sun/security/util/Debug.java line 142: > >> 140:

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v37]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11

2024-05-13 Thread Valerie Peng
On Mon, 22 Apr 2024 18:31:37 GMT, Francisco Ferrari Bihurriet wrote: > Hi, > > I would like to propose an implementation to support AES CBC with Ciphertext > Stealing (CTS) in SunPKCS11, according to what has been specified in > [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-8330843).

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v3]

2024-05-13 Thread Kevin Driver
On Thu, 9 May 2024 21:28:47 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> some code review comments > > test/jdk/com/sun/crypto/provider/KDF/TestHkdf.java line 233: > >> 231: * are the

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v36]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

2024-05-13 Thread Kevin Driver
On Mon, 13 May 2024 19:58:27 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> code review comments > > src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java > line 407: > >>

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v35]

2024-05-13 Thread Weijun Wang
On Fri, 10 May 2024 20:54:45 GMT, Kevin Driver wrote: >> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 47: >> >>> 45: final class Builder { >>> 46: >>> 47: Extract extract = null; >> >> No need to store an `extract` field. Just create one and return it

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v35]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v33]

2024-05-13 Thread Kevin Driver
On Mon, 13 May 2024 19:00:52 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update @return statement > > src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 363: > >> 361:

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v33]

2024-05-13 Thread Weijun Wang
On Mon, 13 May 2024 17:37:38 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update @return statement > > src/java.base/share/classes/javax/crypto/KDFSpi.java line 72: > >> 70: protected

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]

2024-05-13 Thread Weijun Wang
On Mon, 13 May 2024 09:31:53 GMT, Alan Bateman wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-enable preview annotations > > src/java.base/share/classes/javax/crypto/KDFSpi.java line 41: > >> 39: * All the

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

2024-05-13 Thread Weijun Wang
On Mon, 13 May 2024 19:01:09 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: [Bug] javax.security.auth.kerberos.KeyTab returns unrequested keys

2024-05-13 Thread Osipov, Michael (IN IT IN)
On 2024-05-09 00:13, Wei-Jun Wang wrote: Hi Michael, I've filed https://bugs.openjdk.org/browse/JDK-8331975. I plan to introduce a system property to control the string comparison mode. In my earlier reply I mentioned fixing keytab entry lookup no matter how the comparison is done. I did

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 19:01:09 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v3]

2024-05-13 Thread Sean Mullan
On Thu, 9 May 2024 20:58:00 GMT, Kevin Driver wrote: >> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java >> line 223: >> >>> 221: // A switch would be nicer, but we may need to backport this >>> before JDK 17 >>> 222: // Also, JEP 305 came out in JDK

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v3]

2024-05-13 Thread Sean Mullan
On Thu, 9 May 2024 20:24:19 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> some code review comments > > src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java > line 80: >

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 15:53:45 GMT, Kevin Driver wrote: >> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line >> 213: >> >>> 211: /** >>> 212: * Static helper-method that may be used to initialize an {@code >>> ExtractExpand} object >>> 213: * >> >> Do we

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 09:12:20 GMT, Alan Bateman wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-enable preview annotations > > src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 206: > >>

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 19:01:09 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 09:07:53 GMT, Alan Bateman wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-enable preview annotations > > src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 383: > >>

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 18:56:25 GMT, Kevin Driver wrote: >> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line >> 332: >> >>> 330: * @return the optional context and application specific >>> information >>> 331: */ >>> 332: public byte[] info() {

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v33]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 16:30:54 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]

2024-05-13 Thread Kevin Driver
On Mon, 13 May 2024 09:06:34 GMT, Alan Bateman wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-enable preview annotations > > src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 332: > >>

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8331008: KDF Implementation (Preview) [v2]

2024-05-13 Thread Sean Mullan
On Fri, 10 May 2024 21:13:22 GMT, Kevin Driver wrote: >> src/java.base/share/classes/javax/crypto/KDFSpi.java line 45: >> >>> 43: * provides access to the KDF alg params for implementers of the Spi >>> 44: */ >>> 45: protected final AlgorithmParameterSpec algorithmParameterSpec;

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 14:01:46 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-enable preview annotations > > src/java.base/share/classes/javax/crypto/KDFSpi.java line 59: > >> 57: * >>

Re: RFR: 8331008: KDF Implementation (Preview) [v33]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 16:30:54 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: RFR: 8331008: KDF Implementation (Preview) [v33]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Kevin Driver
On Mon, 13 May 2024 09:02:42 GMT, Alan Bateman wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-enable preview annotations > > src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 121: > >>

Re: RFR: 8331008: KDF Implementation (Preview) [v32]

2024-05-13 Thread Kevin Driver
On Thu, 9 May 2024 15:18:43 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove (now) extraneous null-check > > src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 352: >

Re: RFR: 8331008: KDF Implementation (Preview) [v32]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic [v9]

2024-05-13 Thread Anthony Scarpino
On Fri, 10 May 2024 00:19:32 GMT, Volodymyr Paprotski wrote: >> Performance. Before: >> >> Benchmark(algorithm) (dataSize) (keyLength) >> (provider) Mode Cnt ScoreError Units >> SignatureBench.ECDSA.signSHA256withECDSA1024 256

Integrated: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit

2024-05-13 Thread Prajwal Kumaraswamy
On Thu, 21 Mar 2024 09:23:43 GMT, Prajwal Kumaraswamy wrote: > This fix intends to eliminate additional library call to C_EncryptInit or > C_DecryptInit for Ciphers running through the CKM_AES_GCM. > > Background: > > There are two types of CK_GCM_PARAMS struct that are used, one with IV

Re: RFR: 8331008: KDF Implementation (Preview) [v31]

2024-05-13 Thread Kevin Driver
On Fri, 10 May 2024 15:51:56 GMT, Sean Mullan wrote: >> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line >> 201: >> >>> 199: * the PRK (may be null) >>> 200: * @param info >>> 201: * the info (may be null) >> >> I know you use a null `prk` in

Re: RFR: 8331008: KDF Implementation (Preview) [v31]

2024-05-13 Thread Kevin Driver
On Thu, 9 May 2024 15:17:17 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - method reuse >> - null/boundary/modifiability checks > >

Re: RFR: 8331008: KDF Implementation (Preview) [v31]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with two additional commits since

Re: RFR: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit [v4]

2024-05-13 Thread Sean Coffey
On Fri, 10 May 2024 08:04:26 GMT, Prajwal Kumaraswamy wrote: >> This fix intends to eliminate additional library call to C_EncryptInit or >> C_DecryptInit for Ciphers running through the CKM_AES_GCM. >> >> Background: >> >> There are two types of CK_GCM_PARAMS struct that are used, one with

Re: RFR: 8331008: KDF Implementation (Preview) [v30]

2024-05-13 Thread Kevin Driver
On Thu, 9 May 2024 15:13:25 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> disallow null or empty values for ikm/salt rather than silent ignore > >

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v3]

2024-05-13 Thread Alan Bateman
On Mon, 13 May 2024 11:47:38 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and

Re: RFR: 8331008: KDF Implementation (Preview) [v30]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8331008: KDF Implementation (Preview) [v30]

2024-05-13 Thread Kevin Driver
On Fri, 10 May 2024 14:58:38 GMT, Sean Mullan wrote: >> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line >> 108: >> >>> 106: * >>> 107: * @param ikm >>> 108: * the ikm value (null values will not be added) >> >> Are you sure about

Re: RFR: 8331008: KDF Implementation (Preview) [v29]

2024-05-13 Thread Kevin Driver
On Thu, 9 May 2024 13:01:16 GMT, Sibabrata Sahoo wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> code review comment re:returning null from derives > >

Re: RFR: 8331008: KDF Implementation (Preview) [v29]

2024-05-13 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since

Re: RFR: 8331008: KDF Implementation (Preview) [v29]

2024-05-13 Thread Kevin Driver
On Mon, 13 May 2024 15:23:59 GMT, Kevin Driver wrote: >> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java >> line 148: >> >>> 146: } >>> 147: >>> 148: return null; >> >> Should it throw exception instead of null? Also it will never reach here. > > An

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 13:55:48 GMT, Weijun Wang wrote: >> src/java.base/share/classes/javax/crypto/KDF.java line 50: >> >>> 48: * {@code KDF} objects are instantiated through the {@code getInstance} >>> family >>> 49: * of methods. Key derivation algorithm names follow a naming >>>

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 15:04:20 GMT, Sean Mullan wrote: >> Do we need to mention "at the same time" because it's thread-safe? > > Yes, how about: "The `deriveKey` and `deriveData` methods of `KDF` objects > must be thread-safe. That is, multiple threads may concurrently invoke these > methods on

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 13:57:10 GMT, Weijun Wang wrote: >> src/java.base/share/classes/javax/crypto/KDF.java line 395: >> >>> 393: * >>> 394: * The {@code deriveKey} method may be called multiple times once a >>> 395: * {@code KDF} object is initialized. >> >> I think this

RFR: 8331975: Enable case-insensitive check in ccache and keytab entry lookup

2024-05-13 Thread Weijun Wang
Add a new system property to control the name comparison in keytab and ccache entry lookup. - Commit messages: - year - the commit Changes: https://git.openjdk.org/jdk/pull/19216/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19216=00 Issue:

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Weijun Wang
On Fri, 10 May 2024 20:55:47 GMT, Kevin Driver wrote: >> I agree. Also, if we do want to validate arguments (and I don't know if we >> need to), then I think the `Extract` constructor should be responsible for >> doing that, not the `Builder`. Doing it in `Extract` is safer since it is >>

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-13 Thread Weijun Wang
On Sun, 12 May 2024 14:43:04 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> commenting out until better understood -- causing failures > > src/java.base/share/classes/javax/crypto/KDF.java line

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Weijun Wang
On Mon, 13 May 2024 09:18:55 GMT, Alan Bateman wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-enable preview annotations > > src/java.base/share/classes/javax/crypto/KDF.java line 50: > >> 48: * {@code KDF}

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Weijun Wang
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v3]

2024-05-13 Thread Daniel Fuchs
On Mon, 13 May 2024 11:47:38 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-13 Thread Sean Mullan
On Sun, 12 May 2024 18:13:37 GMT, Weijun Wang wrote: >> src/java.base/share/classes/javax/crypto/KDF.java line 398: >> >>> 396: * >>> 397: * Delayed provider selection is also supported such that the >>> provider >>> 398: * performing the derive is not selected until the method

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Sean Mullan
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: RFR: 8332102: Add `@since` to package-info of `jdk.security.jarsigner`

2024-05-13 Thread Weijun Wang
On Sat, 11 May 2024 16:01:34 GMT, Nizar Benalla wrote: > Code cleanup. The package was added back in > [8056174](https://bugs.openjdk.org/browse/JDK-8056174). > Thanks to anyone reviewing this change. I split my changes into 1 PR per > module to make reviewing simpler. LGTM. Thanks!

Integrated: 8332102: Add `@since` to package-info of `jdk.security.jarsigner`

2024-05-13 Thread Nizar Benalla
On Sat, 11 May 2024 16:01:34 GMT, Nizar Benalla wrote: > Code cleanup. The package was added back in > [8056174](https://bugs.openjdk.org/browse/JDK-8056174). > Thanks to anyone reviewing this change. I split my changes into 1 PR per > module to make reviewing simpler. This pull request has

Re: RFR: 8332102: Add `@since` to package-info of `jdk.security.jarsigner`

2024-05-13 Thread Nizar Benalla
On Sat, 11 May 2024 16:01:34 GMT, Nizar Benalla wrote: > Code cleanup. The package was added back in > [8056174](https://bugs.openjdk.org/browse/JDK-8056174). > Thanks to anyone reviewing this change. I split my changes into 1 PR per > module to make reviewing simpler. You're welcome

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v3]

2024-05-13 Thread Weijun Wang
On Mon, 13 May 2024 11:47:38 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v3]

2024-05-13 Thread Erik Joelsson
On Mon, 13 May 2024 11:47:38 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-13 Thread Pavel Rappo
On Thu, 9 May 2024 08:18:41 GMT, David Holmes wrote: >> Please review this mechanical change to man pages. This PR should be >> integrated after https://github.com/openjdk/jdk/pull/18787. > > src/java.base/share/man/java.1 line 3856: > >> 3854: .SH REMOVED JAVA OPTIONS >> 3855: .PP >> 3856:

Integrated: 8332100: Add missing `@since` to KeyValue::EC_TYPE in `java.xml.crypto`

2024-05-13 Thread Nizar Benalla
On Sat, 11 May 2024 15:46:20 GMT, Nizar Benalla wrote: > Simple code cleanup. I split my changes into 1 PR per module to make > reviewing simpler. > This was added back in [JDK > 13](https://github.com/openjdk/jdk/commit/71825293eb83d7c9ac122c11a12465c2acbec040) > and should have an `@since`

Re: RFR: 8332100: Add missing `@since` to KeyValue::EC_TYPE in `java.xml.crypto`

2024-05-13 Thread Sean Mullan
On Sat, 11 May 2024 15:46:20 GMT, Nizar Benalla wrote: > Simple code cleanup. I split my changes into 1 PR per module to make > reviewing simpler. > This was added back in [JDK > 13](https://github.com/openjdk/jdk/commit/71825293eb83d7c9ac122c11a12465c2acbec040) > and should have an `@since`

Re: RFR: 8332100: Add missing `@since` to KeyValue::EC_TYPE in `java.xml.crypto`

2024-05-13 Thread Nizar Benalla
On Sat, 11 May 2024 15:46:20 GMT, Nizar Benalla wrote: > Simple code cleanup. I split my changes into 1 PR per module to make > reviewing simpler. > This was added back in [JDK > 13](https://github.com/openjdk/jdk/commit/71825293eb83d7c9ac122c11a12465c2acbec040) > and should have an `@since`

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v3]

2024-05-13 Thread Maurizio Cimadamore
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting > the use of JNI in the following ways: > > * `System::load` and `System::loadLibrary` are now restricted methods > * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods > * binding a JNI `native`

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v2]

2024-05-13 Thread Maurizio Cimadamore
On Mon, 13 May 2024 11:38:40 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v2]

2024-05-13 Thread Maurizio Cimadamore
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting > the use of JNI in the following ways: > > * `System::load` and `System::loadLibrary` are now restricted methods > * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods > * binding a JNI `native`

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI

2024-05-13 Thread Maurizio Cimadamore
On Mon, 13 May 2024 10:42:26 GMT, Maurizio Cimadamore wrote: > This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting > the use of JNI in the following ways: > > * `System::load` and `System::loadLibrary` are now restricted methods > * `Runtime::load` and

RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI

2024-05-13 Thread Maurizio Cimadamore
This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting the use of JNI in the following ways: * `System::load` and `System::loadLibrary` are now restricted methods * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods * binding a JNI `native` method

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Alan Bateman
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Alan Bateman
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: [Bug] javax.security.auth.kerberos.KeyTab returns unrequested keys

2024-05-13 Thread Osipov, Michael (IN IT IN)
That's totally fine, thank you. There is a typo in JDK-8331976: environemnt On 2024-05-09 00:13, Wei-Jun Wang wrote: Hi Michael, I've filed https://bugs.openjdk.org/browse/JDK-8331975. I plan to introduce a system property to control the string comparison mode. In my earlier reply I

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Alan Bateman
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Alan Bateman
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Alan Bateman
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Alan Bateman
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the

Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-13 Thread Alan Bateman
On Mon, 13 May 2024 03:46:50 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the