Hi all,
Please review this patch to fix a problem with unintialized values in
our generation counters.
https://cr.openjdk.java.net/~stefank/8226797/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8226797
The jstat values NGCMN and OGCMN both return uninitialized values.
I stumbled upon t
In the interest to get this integrated before the RDP cut-off I'm going
to push this ASAP. This has gone through tier1-tier3 testing.
StefanK
On 2019-12-12 13:01, Stefan Karlsson wrote:
Hi all,
Please review this patch to fix a problem with unintialized values in
our generation cou
Thanks, Dan.
StefanK
On 2019-12-12 17:06, Daniel D. Daugherty wrote:
src/hotspot/share/gc/shared/generationSpec.hpp
No comments.
test/hotspot/jtreg/serviceability/tmtools/jstat/utils/JstatGcCapacityResults.java
No comments.
Thumbs up.
Dan
On 12/12/19 10:23 AM, Stefan Karlsson
ushed this yesterday to make the JDK 14 fork cut-off.
Thanks,
StefanK
Thanks,
Serguei
On 12/12/19 07:23, Stefan Karlsson wrote:
In the interest to get this integrated before the RDP cut-off I'm
going to push this ASAP. This has gone through tier1-tier3 testing.
StefanK
On 2019-12-1
Hi all,
Please review this patch to change our usages of LingeredApp and
getVmOptions() to instead use getTestJavaOpts().
https://cr.openjdk.java.net/~stefank/8237111/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8237111
This issue was encountered by both Coleen and I, independently.
W
initialized testVmArgs with an
array of the final sized, and then lazily initialize the runtime data.
Copyrights need updating.
Other than that it looks good.
Thanks for reviewing,
StefanK
thanks,
Chris
On 1/21/20 6:58 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to change
Hi David,
On 2020-01-22 05:28, David Holmes wrote:
Hi Stefan,
Thanks for tackling this.
On 22/01/2020 12:58 am, Stefan Karlsson wrote:
Hi all,
Please review this patch to change our usages of LingeredApp and
getVmOptions() to instead use getTestJavaOpts().
https://cr.openjdk.java.net
Thanks. Created JDK-8237639.
StefanK
On 2020-01-22 10:50, David Holmes wrote:
Hi Stefan,
Thanks David. Would you accept it if I created a follow-up RFR to
investigate if we could change order of the combined flags?
Sure, no problem.
Thanks,
David
On 22/01/2020 6:58 pm, Stefan Karlsson
Hi Zhengyu,
On 2020-02-07 16:53, Zhengyu Gu wrote:
Hi,
I would like purpose this change that allows GC to provide ObjectMarker
during JVMTI heap walk.
Currently, JVMTI heap walk uses oop markword's 'marked' pattern to
indicate 'visited' oop.
Unfortunately, it conflicts with Shenandoah, wh
Hi Zhengyu,
On 2020-02-17 15:51, Zhengyu Gu wrote:
Hi Stefan,
Thanks for the review and suggestions, updated accordingly:
http://cr.openjdk.java.net/~zgu/JDK-8238633/webrev.01/
Thanks for moving the code. I think this looks good.
If you're up for it, I have a couple of style change suggesti
Looks good. This is left-overs from the CMS removal.
StefanK
On 2020-02-25 19:02, Chris Plummer wrote:
Adding hotspot-gc-dev.
Chris
On 2/25/20 2:21 AM, linzang(臧琳) wrote:
Hi,
Please review the following change:
Bugs: https://bugs.openjdk.java.net/browse/JDK-8239916
webrev: http:/
Looks good.
StefanK
On 2020-03-18 05:52, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8240906
diff --git a/test/hotspot/jtreg/ProblemList-zgc.txt
b/test/hotspot/jtreg/ProblemList-zgc.txt
--- a/test/hotspot/jtreg/ProblemList-zgc.txt
+++ b
On 2020-03-25 17:40, Igor Ignatyev wrote:
Hi Leonid,
I have briefly looked at the patch, a few comments so far:
test/hotspot/jtreg/serviceability/sa/ClhsdbFlags.java:
- at L#114, could you please call static method using class name (as the
opposite of using instance)? or was it meant to be t
er check as Ioi suggested in
startApp method.
+ public static void startApp(LingeredApp theApp, String...
additionalJvmOpts) throws IOException {
+ startAppExactJvmOpts(theApp,
Utils.appendTestJavaOpts(additionalJvmOpts));
+ }
Leonid
On 3/25/20 10:14 AM, Stefan Karlsson wrote:
On 2020-03
Hi Lin,
I took a look at this earlier and saw that the heap inspection code is
strongly coupled with the CollectedHeap and G1CollectedHeap. I'd prefer
if we'd abstract this away, so that the GCs only provide a "parallel
object iteration" interface, and the heap inspection code is kept elsewher
;
wrote:
Dear Stefan,
Thanks a lot! I agree with you to decouple the heap
inspection code with GC's.
I will start from your POC code, may discuss with you
later.
BRs,
Lin
On 2020/4/22, 5
Looks good.
StefanK
On 2020-04-25 00:30, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8243568/webrev.00
8 lines changed: 0 ins; 6 del; 2 mod;
Hi all,
could you please review this small and trivial patch which updates
serviceability/logging/TestLogRotation.java test to pass bo
Hi all,
Please review this patch to make it less likely that we accidentally add
or fail to add test.java.opts and test.vm.opts to our spawned test JVMs.
https://cr.openjdk.java.net/~stefank/8244078/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8244078
ProcessTools.createJavaProcessBuil
On 2020-04-30 11:24, Alan Bateman wrote:
On 30/04/2020 10:07, Stefan Karlsson wrote:
Hi all,
Please review this patch to make it less likely that we accidentally
add or fail to add test.java.opts and test.vm.opts to our spawned
test JVMs.
https://cr.openjdk.java.net/~stefank/8244078/webrev
Hi David,
On 2020-04-30 11:59, David Holmes wrote:
Hi Stefan,
On 30/04/2020 7:07 pm, Stefan Karlsson wrote:
Hi all,
Please review this patch to make it less likely that we accidentally
add or fail to add test.java.opts and test.vm.opts to our spawned
test JVMs.
https
On 2020-04-30 12:22, Stefan Karlsson wrote:
Hi David,
On 2020-04-30 11:59, David Holmes wrote:
...
---
test/hotspot/jtreg/gc/arguments/GCArguments.java
Isn't the String[] <-> List conversion already handled in
ProcessTools?
This looks like an area where GC added its own helpe
On 2020-05-01 21:34, Chris Plummer wrote:
On 4/30/20 2:07 AM, Stefan Karlsson wrote:
...
There was one odd thing in jdi that requires extra scrutiny:
https://cr.openjdk.java.net/~stefank/8244078/webrev.01/test/jdk/com/sun/jdi/lib/jdb/Debuggee.java.udiff.html
Yes, that did look a odd at
Hi Mikael,
On 2020-05-04 07:12, Mikael Vidstedt wrote:
Please review this change which implements part of JEP 381:
JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/hotspot/open/webrev/
I went over this patch and colle
Looks good.
StefanK
On 2020-05-27 01:07, Chris Plummer wrote:
Hello,
Please review the following trivial change to remove FreeChunk.java:
https://bugs.openjdk.java.net/browse/JDK-8244622
http://cr.openjdk.java.net/~cjplummer/8244622/webrev.00/index.html
Tested with tier1 and also running all
Looks good.
StefanK
On 2020-06-10 23:00, Schmelter, Ralf wrote:
Hi,
https://bugs.openjdk.java.net/browse/JDK-8237354 added a test, which
did not properly protect against explicitly set GCs (for serial,
parallel and G1 GC). This fixes it by adding the corresponding
@requires tag for each of
Hi Coleen,
On 2020-06-17 23:25, coleen.phillim...@oracle.com wrote:
Summary: Remove JVMTI oops_do calls from JVMTI and GCs
Tested with tier1-3, also built shenandoah to verify shenandoah changes.
open webrev at http://cr.openjdk.java.net/~coleenp/2020/8247808.01/webrev
https://cr.openjdk.jav
-
From: "Hohensee, Paul"
Date: Thursday, July 23, 2020 at 6:48 AM
To: "linzang(臧琳)" , Stefan Karlsson ,
"serguei.spit...@oracle.com" , David Holmes , ser
"
*Date: *Wednesday, August 5, 2020 at 1:02 PM
*To: *"linzang(臧琳)" , "Hohensee, Paul"
, Stefan Karlsson ,
David Holmes , serviceability-dev
, "hotspot-gc-...@openjdk.java.net"
*Subject: *Re: RFR(L): 8215624: add parallel heap inspection support for
jmap histo(G
Hi all,
Please review this patch to fix a recently introduced jmap bug.
https://cr.openjdk.java.net/~stefank/8251835/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8251835
I added the same kind of checks that we have in histo.
Testing:
- Tested locally with the failing test
- Tier1-tier5
ds=100" successfully, including
your patch for 8251570.
This 8251835 patch looks good to me.
Thanks!
StefanK
Thanks,
Paul
On 8/14/20, 7:49 AM, "Stefan Karlsson" wrote:
Hi all,
Please review this patch to fix a recently introduced jmap bug.
https://cr.openjdk.
Hi all,
I propose this simple change to use the concrete class as the return
type of VMObjectFactory.newObject.
https://cr.openjdk.java.net/~stefank/8218731/webrev.01
https://bugs.openjdk.java.net/browse/JDK-8218731
This allows us to specify the class only once when calling newObject.
For ex
Hi all,
Please review this small patch to resolve ZPageAllocator::_physical as a
value object instead of a pointer.
https://cr.openjdk.java.net/~stefank/8218732/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218732
This fixes the Heap Parameters view.
Thanks,
StefanK
Hi all,
Please review this patch to remove the broken implementation of
CollectedHeap used() and capacity() and instead force all GCs to provide
their own implementations.
https://cr.openjdk.java.net/~stefank/8218733/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218733
This was found
Hi all,
Please review this patch to fix the resolving of oops inside the (VM)
OopHandles.
https://cr.openjdk.java.net/~stefank/8218734/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218734
Before this patch the OopHandle::_obj was assumed to be located at
offset 0, and the SA resolved
On 2019-02-11 10:39, Aleksey Shipilev wrote:
On 2/11/19 9:13 AM, Stefan Karlsson wrote:
Please review this patch to remove the broken implementation of CollectedHeap
used() and capacity()
and instead force all GCs to provide their own implementations.
https://cr.openjdk.java.net/~stefank
Thanks, Jini.
StefanK
On 2019-02-11 13:00, Jini George wrote:
Hi Stefan,
Looks good to me.
Thanks,
Jini.
On 2/11/2019 1:43 PM, Stefan Karlsson wrote:
Hi all,
Please review this patch to remove the broken implementation of
CollectedHeap used() and capacity() and instead force all GCs to
Hi all,
Please review this patch to add support for large bitmaps in the SA.
http://cr.openjdk.java.net/~stefank/8218743/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218743
I've added a minimal interface (at, atPut, clear) that uses longs
instead of ints, and changed MarkBits to use th
Hi all,
Please review this patch to implement a discontiuous bitmap for ZGC in
the SA.
http://cr.openjdk.java.net/~stefank/8218746/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218746
ZGC uses a 16TB virtual memory address range, so the normal scheme to
map a bitmap over the entire ad
2/11/2019 1:23 PM, Stefan Karlsson wrote:
Hi all,
Please review this small patch to resolve ZPageAllocator::_physical
as a value object instead of a pointer.
https://cr.openjdk.java.net/~stefank/8218732/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218732
This fixes the Heap Parameter
Hi Jini,
On 2019-02-13 05:53, Jini George wrote:
Hi Stefan,
Looks good to me. Nits: pls do change the copyright year.
Thanks for reviewing. I'll update the copyright years.
Thanks,
StefanK
Thanks,
Jini.
On 2/11/2019 6:06 PM, Stefan Karlsson wrote:
Hi all,
Please review this pat
Hi all,
Please review / comment on this patch to enable a best-effort live heap
region iteration implementation in ZGC.
http://cr.openjdk.java.net/~stefank/8218922/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218922
The SA has functionally that relies on live heap region information f
On 2019-02-13 17:12, coleen.phillim...@oracle.com wrote:
On 2/13/19 10:40 AM, Stefan Karlsson wrote:
On 2019-02-13 14:40, coleen.phillim...@oracle.com wrote:
On 2/11/19 3:39 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to fix the resolving of oops inside the
(VM
Thanks, Erik.
Stefank
On 2019-02-14 09:19, Erik Österlund wrote:
Hi Stefan,
This looks good and trivial.
Thanks,
/Erik
On 2019-02-11 08:47, Stefan Karlsson wrote:
Hi all,
I propose this simple change to use the concrete class as the return
type of VMObjectFactory.newObject.
https
Thanks, Erik.
Stefank
On 2019-02-14 09:26, Erik Österlund wrote:
Hi Stefan,
Given that the remark from Jini is fixed, this looks good. I don't need
another webrev.
Thanks,
/Erik
On 2019-02-11 19:09, Stefan Karlsson wrote:
Hi Jini,
On 2019-02-11 19:00, Jini George wrote:
Hi S
reviewing.
StefanK
Thanks,
/Erik
On 2019-02-11 09:39, Stefan Karlsson wrote:
Hi all,
Please review this patch to fix the resolving of oops inside the (VM)
OopHandles.
https://cr.openjdk.java.net/~stefank/8218734/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218734
Before this
Thanks, Erik.
Stefank
On 2019-02-14 09:38, Erik Österlund wrote:
Hi Stefan,
Looks good.
Thanks,
/Erik
On 2019-02-11 09:13, Stefan Karlsson wrote:
Hi all,
Please review this patch to remove the broken implementation of
CollectedHeap used() and capacity() and instead force all GCs to
Thanks, Erik.
Stefank
On 2019-02-14 10:11, Erik Österlund wrote:
Hi Stefan,
Looks good.
Thanks,
/Erik
On 2019-02-11 13:36, Stefan Karlsson wrote:
Hi all,
Please review this patch to add support for large bitmaps in the SA.
http://cr.openjdk.java.net/~stefank/8218743/webrev.01/
https
do that or not.
Otherwise looks good. Don't need another webrev.
I'll fix. Thanks for reviewing.
StefanK
Thanks,
/Erik
On 2019-02-11 14:55, Stefan Karlsson wrote:
Hi all,
Please review this patch to implement a discontiuous bitmap for ZGC in
the SA.
http://cr.openjdk.java.ne
this further at some point in the future
to deal with broken Klass pointers better.
Thanks,
/Erik
On 2019-02-13 15:52, Stefan Karlsson wrote:
Hi all,
Please review / comment on this patch to enable a best-effort live
heap region iteration implementation in ZGC.
http://cr.openjdk.java.net
If this patch is accepted we also need this patch to turn on the SA
hprof implementation:
http://cr.openjdk.java.net/~stefank/8218970/webrev.01/
StefanK
On 2019-02-13 15:52, Stefan Karlsson wrote:
Hi all,
Please review / comment on this patch to enable a best-effort live heap
region
the tests:
http://cr.openjdk.java.net/~stefank/8218978/webrev.01/
I'm currently rerunning the tests to see that the latest changes didn't
break anything.
Thanks,
StefanK
Thanks,
Yasumasa
On 2019/02/13 23:52, Stefan Karlsson wrote:
Hi all,
Please review / comment on this patch to enabl
.
StefanK
Thanks!
Jini.
On 2/11/2019 7:25 PM, Stefan Karlsson wrote:
Hi all,
Please review this patch to implement a discontiuous bitmap for ZGC
in the SA.
http://cr.openjdk.java.net/~stefank/8218746/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218746
ZGC uses a 16TB virtual memo
Hi again,
I've separated the live regions iteration refactoring into this patch:
https://cr.openjdk.java.net/~stefank/8219003/webrev.01/
And use this RFE for the ZGC specific parts:
https://cr.openjdk.java.net/~stefank/8218922/webrev.02/
Thanks,
StefanK
On 2019-02-14 14:39, Stefan Kar
copyright year for some of the files need updation.
Sure.
This looks good to me otherwise.
Thanks for reviewing.
StefanK
Thanks,
Jini.
On 2/11/2019 2:09 PM, Stefan Karlsson wrote:
Hi all,
Please review this patch to fix the resolving of oops inside the (VM)
OopHandles.
https
Thanks, Yasumasa!
StefanK
On 2019-02-15 01:54, Yasumasa Suenaga wrote:
Hi Stefan,
Both changes look good to me!
Thanks,
Yasumasa
2019年2月15日(金) 2:12 Stefan Karlsson :
Hi again,
I've separated the live regions iteration refactoring into this patch:
https://cr.openjdk.java.net/~st
r all these changes:
https://cr.openjdk.java.net/~stefank/zgc/zSABitMapsAndLiveRegions/webrev/
StefanK
Thanks
Kevin
On 14/02/2019 17:12, Stefan Karlsson wrote:
Hi again,
I've separated the live regions iteration refactoring into this patch:
https://cr.openjdk.java.net/~stefank/8219003
B
pointers have the correct colors, otherwise we'll end up crashing when
-XX:+ZUnmapBadViews are used.
With this fix, the patches passes tier1,tier2, and tier3 testing.
Thanks,
StefanK
On 2019-02-13 15:52, Stefan Karlsson wrote:
Hi all,
Please review / comment on this patch to enable
Thanks, Erik.
StefanK
On 2019-02-18 10:35, Erik Österlund wrote:
Hi Stefan,
Looks good!
Thanks,
/Erik
On 2019-02-15 20:25, Stefan Karlsson wrote:
Testing showed that the re-enabling of the retiring of TLABs was
broken. This has been fixed with this patch:
http://cr.openjdk.java.net
Hi all,
Please review this patch to ProblemList
serviceability/sa/TestJmapCoreMetaspace.java
https://cr.openjdk.java.net/~stefank/8219571/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8219571
Original bug:
https://bugs.openjdk.java.net/browse/JDK-8219443
Thanks,
StefanK
Thanks, Igor!
StefanK
On 2019-02-22 22:02, Igor Ignatyev wrote:
Hi Stefan,
LGTM.
-- Igor
On Feb 22, 2019, at 1:00 PM, Stefan Karlsson wrote:
Hi all,
Please review this patch to ProblemList
serviceability/sa/TestJmapCoreMetaspace.java
https://cr.openjdk.java.net/~stefank/8219571/webrev
Hi all,
Please review and/or comment on this change to remove
CodeCache::scavenge_root_nmehods_do from
VM_HeapWalkOperation::collect_simple_roots.
http://cr.openjdk.java.net/~stefank/8220342/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8220342
VM_HeapWalkOperation::collect_simple_root
On 2019-03-14 10:21, Erik Helin wrote:
On 12 Mar 2019, at 16:19, Stefan Karlsson wrote:
Hi all,
Hey StefanK,
Please review and/or comment on this change to remove
CodeCache::scavenge_root_nmehods_do from
VM_HeapWalkOperation::collect_simple_roots.
http://cr.openjdk.java.net/~stefank
Thanks, Serguei!
StefanK
On 2019-03-12 22:50, serguei.spit...@oracle.com wrote:
Hi Stefan,
The fix looks good to me.
Testing the tiers 1-7 for different GC's has to be good enough.
Thanks,
Serguei
On 3/12/19 8:19 AM, Stefan Karlsson wrote:
Hi all,
Please review and/or comment on
Looks good.
StefanK
On 2019-03-25 10:59, Per Liden wrote:
Clean up serviceability/sa/TestUniverse.java to remove the need for the
withZ/withoutZ option we currently pass in. This also changes the test
to only run with the selected GC instead of testing all GCs every time,
which should save us
Looks good!
StefanK
On 2019-04-08 03:49, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8221584
webrev: http://cr.openjdk.java.net/~dholmes/8221584/webrev/
I'm really just sponsoring this fix as the problem was diagnozed by
Robbin Ehn and Stefan Karlsson - thanks
Hi all,
Please review this patch to introduce a new diagnostic command: VM.get_flag.
http://cr.openjdk.java.net/~stefank/8224479/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8224479
Today we have:
- VM.set_flag - which allows the user to set a manageable flag
- VM.flags - which allows t
HelloSleep VM.flags -name=UseSerialGC
371:
bool UseSerialGC = false
{product} {default}
Let's see if anyone else has some feedback regarding this.
Thanks,
StefanK
Just my 5c
.. Thomas
On Tue, May 21, 2019, 12:14 Stefan Kar
Hi all,
Please review this patch to read objects with AS_NO_KEEPALIVE in the
HeapDumper.
http://cr.openjdk.java.net/~stefank/8227086/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8227086
Found this while running some extra verification code through our
barriers. This is one place where
Thanks, Serguei.
StefanK
On 2019-07-02 17:57, serguei.spit...@oracle.com wrote:
Hi Stefan,
It looks good.
Thanks,
Serguei
On 7/2/19 06:53, Stefan Karlsson wrote:
Hi all,
Please review this patch to read objects with AS_NO_KEEPALIVE in the
HeapDumper.
http://cr.openjdk.java.net
Thanks, Kim.
StefanK
On 2019-07-03 00:11, Kim Barrett wrote:
On Jul 2, 2019, at 9:53 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to read objects with AS_NO_KEEPALIVE in the HeapDumper.
http://cr.openjdk.java.net/~stefank/8227086/webrev.01/
https://bugs.openjdk.java.net
08-14 11:11, Roman Kennke wrote:
Am 14.08.19 um 01:26 schrieb Kim Barrett:
On Aug 12, 2019, at 12:19 PM, Stefan Karlsson
wrote:
Hi Roman,
Kim helped me figuring out how to get past the volatile issues I had with the
class markWord { uintptr_t value; ... } version. So, I've created a ver
3) JVMCI maintainers
Thanks,
StefanK
On 2019-08-14 11:11, Roman Kennke wrote:
Am 14.08.19 um 01:26 schrieb Kim Barrett:
On Aug 12, 2019, at 12:19 PM, Stefan Karlsson
wrote:
Hi Roman,
Kim helped me figuring out how to get past the volatile issues I had
with the class markWord { uintptr_t
On 2019-08-16 00:59, Kim Barrett wrote:
On Aug 15, 2019, at 7:46 AM, Stefan Karlsson wrote:
Thanks Kim, Roman, Dan and Coleen for reviews and feedback.
I rebased the patch, fixed more alignments, renamed the bug, and rerun the test
through tier1-3.
https://cr.openjdk.java.net/~stefank
Looks good.
StefanK
On 2018-02-23 02:16, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8198585
http://cr.openjdk.java.net/~cjplummer/8198585/webrev.00/webrev/
Before removing ServiceUtil::visible_oop(), I want to make sure it
really isn't
Looks good to me.
StefanK
On 2018-03-20 01:48, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8195109
http://cr.openjdk.java.net/~cjplummer/8195109/webrev.00/index.html
The assert I added to make sure this is safe has been in place in
jdk/j
Looks good.
StefanK
On 2018-03-20 20:39, Chris Plummer wrote:
Hi,
New webrev:
http://cr.openjdk.java.net/~cjplummer/8195109/webrev.01/index.html
There was a build failure on solaris-sparc in threadSMR.cpp. References
to the Copy class were producing "unresolved symbol" errors.
threadSMR.cp
Hi all,
Please review this patch to deal with the case when all available
MemoryPoolMXBeans support usage thresholds.
http://cr.openjdk.java.net/~stefank/8204170/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8204170
The tests searches for a MemoryPoolMXBean that returns false for
isUsa
Hi all,
Please review this patch to lower the minimum number of heap memory
pools in MemoryTest.java.
http://cr.openjdk.java.net/~stefank/8204173/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8204173
Just like the comment in the test says:
* NOTE: This expected result is hardcoded in
Thanks, Erik.
StefanK
On 2018-05-31 16:26, Erik Österlund wrote:
Hi Stefan,
Looks good.
Thanks,
/Erik
On 2018-05-31 15:53, Stefan Karlsson wrote:
Hi all,
Please review this patch to lower the minimum number of heap memory
pools in MemoryTest.java.
http://cr.openjdk.java.net/~stefank
Thanks, Erik.
StefanK
On 2018-05-31 16:27, Erik Österlund wrote:
Hi Stefan,
Looks good.
Thanks,
/Erik
On 2018-05-31 15:38, Stefan Karlsson wrote:
Hi all,
Please review this patch to deal with the case when all available
MemoryPoolMXBeans support usage thresholds.
http
h the other GCs.
Does this sound reasonable?
Thanks,
StefanK
Mandy
On 5/31/18 6:38 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to deal with the case when all available
MemoryPoolMXBeans support usage thresholds.
http://cr.openjdk.java.net/~stefank/8204170/webrev.01/
On 2018-05-31 19:04, mandy chung wrote:
On 5/31/18 10:01 AM, Stefan Karlsson wrote:
Hi Mandy,
On 2018-05-31 18:44, mandy chung wrote:
Hi Stefan,
I think a better fix is to find another operation that will throw an
exception. ThreadMXBean::getThreadInfo throws IAE and it can be a
MemoryTestZGC.sh test, that calls MemoryTest 1
1 and explains that ZGC has one memory manager and one heap memory pool?
Thanks,
StefanK
Mandy
On 5/31/18 6:53 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to lower the minimum number of heap memory
pools in MemoryTest.java.
http
On 2018-05-31 20:09, mandy chung wrote:
On 5/31/18 10:36 AM, Stefan Karlsson wrote:
Hi Mandy,
On 2018-05-31 18:19, mandy chung wrote:
Hi Stefan,
This change looks okay. Can you add a comment to describe the
expected memory pools for ZGC so that it explains why the min number
of heap
Hi Chris,
On 2015-01-08 00:29, Chris Plummer wrote:
Hi,
Please review the following changes for the addition of the
VM.class_hierarchy DCMD. Please read the bug first for some background
information.
Webrev: http://cr.openjdk.java.net/~cjplummer/8054888/webrev.00/
Bug: https://bugs.openjdk.
On 2015-01-08 20:15, Chris Plummer wrote:
Hi Stefan,
Comments inline below:
On 1/8/15 2:50 AM, Stefan Karlsson wrote:
Hi Chris,
On 2015-01-08 00:29, Chris Plummer wrote:
Hi,
Please review the following changes for the addition of the
VM.class_hierarchy DCMD. Please read the bug first for
Hi,
Please review this patch to fix an incorrect usage of #if INCLUDE_ALL_GCS.
http://cr.openjdk.java.net/~stefank/8078601/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8078601
This code in thread.cpp is guarded by INCLUDE_ALL_GCS:
#if INCLUDE_ALL_GCS
// Dump concurrent locks
Concurre
On 2015-04-24 23:49, David Holmes wrote:
Looks good. Thanks Stefan.
Thanks, David.
StefanK
David
On 25/04/2015 12:41 AM, Stefan Karlsson wrote:
Hi,
Please review this patch to fix an incorrect usage of #if
INCLUDE_ALL_GCS.
http://cr.openjdk.java.net/~stefank/8078601/webrev.01/
https
Hi Marcus,
On 2016-03-23 10:23, Marcus Larsson wrote:
Hi,
Please review the following patch to fix the issue where duplicate
tagsets are created for the same logical tagset.
The code that emulates the variadic template arguments assumes that
_NO_TAG terminates the sequence of tags. If other
Hi all,
Please, review this patch to optimize the log_is_enabled check in the
Unified Logging framework.
http://cr.openjdk.java.net/~stefank/8152538/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8152538
The following code:
void logLine() {
log_debug(gc)("logLine");
}
expands in
Hi Robbin,
On 2016-03-23 14:50, Robbin Ehn wrote:
Hi all,
After more input, this is the current version.
Please have a look.
Webrev: http://cr.openjdk.java.net/~rehn/8151993/v4/webrev/
Incremental: http://cr.openjdk.java.net/~rehn/8151993/v3-v4/
Looks good to me.
It's non-obvious why you ch
Hi Marcus,
On 23/03/16 11:59, Marcus Larsson wrote:
Hi Stefan,
On 03/23/2016 11:00 AM, Stefan Karlsson wrote:
Hi Marcus,
On 2016-03-23 10:23, Marcus Larsson wrote:
Hi,
Please review the following patch to fix the issue where duplicate
tagsets are created for the same logical tagset.
The
Looks good.
StefanK
On 2016-04-04 17:09, Robbin Ehn wrote:
Hi all,
Please review,
Webrev: http://cr.openjdk.java.net/~rehn/8153396/webrev/
Bug: https://bugs.openjdk.java.net/browse/JDK-8153396
Tested with internal vm test.
Thanks!
/Robbin
Looks good.
StefanK
On 2016-04-08 10:08, Robbin Ehn wrote:
Hi all,
Please review,
Webrev: http://cr.openjdk.java.net/~rehn/8153731/webrev/
Bug: https://bugs.openjdk.java.net/browse/JDK-8153731
Tested with internal vm test (inc a new test for just this).
Thanks!
/Robbin
Looks good.
StefanK
On 2016-04-13 07:50, Robbin Ehn wrote:
Hi all,
Please review this bug fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154064
Test with tonga. (the 5 crashed tonga test no longer crashes)
Thanks!
/Robbin
diff -r 4823056a5bbd src/share/vm/prims/jvmtiExport.cpp
--- a/
Hi Ramki and Jon,
What's the status of this review thread? The bug is still open and
targeted for JDK 9.
Thanks,
StefanK
On 2015-06-03 08:15, Srinivas Ramakrishna wrote:
Thanks Jon for the review and the pointer to the test. I'll get back
to you later this week with a suitable test.
-- Ram
Hi Robbin,
This looks good to me. This breaks gc nightly and is a fairly trivial
change, so I'll push this right away.
Thanks,
StefanK
On 2016-04-20 09:40, Robbin Ehn wrote:
Hi all,
Please review.
We are missing a cr on a log stream, which leads to this guarantee.
Bug: https://bugs.openjd
Changeset: 4c84d351cca9
Author:stefank
Date: 2013-08-16 13:22 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4c84d351cca9
8007074: SIGSEGV at ParMarkBitMap::verify_clear()
Summary: Replace the broken large pages implementation on Linux. New flag:
-XX:+UseTranspare
On 9/12/13 9:21 PM, serguei.spit...@oracle.com wrote:
On 9/11/13 8:54 PM, David Holmes wrote:
Hi Dmitry,
It seems odd that you install the new_method even if there was an
exception. What if the new_method is not valid because of the
exception ?
Coleen suggested this fragment.
New methods wi
Changeset: b606775fd1a3
Author:stefank
Date: 2013-08-29 11:08 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b606775fd1a3
8014659: NPG: performance counters for compressed klass space
Reviewed-by: jmasa, sla
Contributed-by: erik.he...@oracle.com
! src/share/classes/sun/tools
1 - 100 of 220 matches
Mail list logo
