Re: RFR: 8271396: Spelling errors

On Wed, 3 Feb 2021 19:12:25 GMT, Emmanuel Bourg wrote: > This PR fixes the following spelling errors: > > choosen -> chosen > commad -> command > hiearchy -> hierarchy > leagacy -> legacy > minium -> minimum > subsytem -> subsystem > unamed -> unnamed Trivially, looks ok to me.

Re: RFR: 8253119: Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl implementation [v3]

On Thu, 24 Jun 2021 11:44:19 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my changes for the removal of the legacy >> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations? >> >> In JDK 13, JEP 353 provided a drop in replacement for the legacy >>

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. >

Re: RFR: 8264124: Update MXBean specification and implementation to extend mapping of CompositeType to records [v7]

On Fri, 2 Apr 2021 18:00:57 GMT, Daniel Fuchs wrote: >> This RFE proposes to extend the MXBean framework to define a mapping to >> records. >> >> The MXBean framework already defines a mapping of `CompositeType` to plain >> java objects. Records are a natural representation of CompositeTypes.

Re: RFR: 8264124: Update MXBean specification and implementation to extend mapping of CompositeType to records

On Thu, 25 Mar 2021 17:30:52 GMT, Daniel Fuchs wrote: > This RFE proposes to extend the MXBean framework to define a mapping to > records. > > The MXBean framework already defines a mapping of `CompositeType` to plain > java objects. Records are a natural representation of CompositeTypes. A

Re: RFR: 8246774: implementing Record Classes as a standard feature in Java [v9]

On Thu, 1 Oct 2020 01:31:04 GMT, Vicente Romero wrote: >> Co-authored-by: Vicente Romero >> Co-authored-by: Harold Seigel >> Co-authored-by: Jonathan Gibbons >> Co-authored-by: Brian Goetz >> Co-authored-by: Maurizio Cimadamore >> Co-authored-by: Joe Dar

Re: RFR: 8246774: implementing Record Classes as a standard feature in Java [v3]

On Wed, 23 Sep 2020 08:54:57 GMT, Chris Hegarty wrote: >> Vicente Romero has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Merge pull request #1 from ChrisHegarty/record-serial-tests >> >>

Re: RFR: 8246774: implementing Record Classes as a standard feature in Java [v3]

On Wed, 23 Sep 2020 03:34:29 GMT, Vicente Romero wrote: >> Co-authored-by: Vicente Romero >> Co-authored-by: Harold Seigel >> Co-authored-by: Jonathan Gibbons >> Co-authored-by: Brian Goetz >> Co-authored-by: Maurizio Cimadamore >> Co-authored-by: Joe Dar

Re: RFR: 8246774: Record Classes (final) implementation

On Mon, 21 Sep 2020 23:21:18 GMT, Vicente Romero wrote: >> Hi Vicente, >> Please file a separate subtask for the javax.lang.model changes. This helps >> with the JSR 269 MR paperwork. >> Thanks, >> -Joe > > note: I have removed from the original patch the code related to > javax.lang.model, I

Re: PING: Re: RFR: JDK-8184770: JDWP support for IPv6

added some comments as per Serguei request. About scopes support - I thought that the functionality is not important for debugger, but I can implement it (I'd prefer to do it by separate RFE). Ok. -Chris. --alex On 05/11/2019 03:39, Chris Hegarty wrote: On 7 May 2019, at 19:40, sergue

Re: PING: Re: RFR: JDK-8184770: JDWP support for IPv6

> On 7 May 2019, at 19:40, serguei.spit...@oracle.com wrote: > > Hi guys, > > We need a couple of partial reviews for this enhancement: > > - From the net-dev to check IPv6-addresses related part. >It does not need to be a thorough review. >We need another pair of eyes to check for

Re: RFR: JDK-8184770: JDWP support for IPv6

On 01/04/2019 10:51, Daniel Fuchs wrote: Hi Arthur, Not directly related to Alex's original question but... On 30/03/2019 00:03, Arthur Eubanks wrote: We have some ipv6 patches as well in this area as well (as well as other patches to support ipv6 only environments) that we're trying to

Re: RFR: JDK-8184770: JDWP support for IPv6

On 01/04/2019 12:50, Chris Hegarty wrote: ... Specifically on SocketTransportService.java. What Arthur has proposed is better ( changing to lastIndexOf alone is not sufficient ). Or is your assumption that the IPv6 literal is not enclosed in square brackets? More specifically, what syntax

Re: RFR: JDK-8184770: JDWP support for IPv6

Alex, On 29/03/2019 22:07, Alex Menkov wrote: (added net-dev as suggested by Alan) Net gurus, please assist in reviewing socket-related code. New webrev: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.01/ Specifically on SocketTransportService.java. What Arthur has proposed is better (

Re: RFR: JDK-8211324: Link to java.lang.ThreadGroup in JDWP spec is broken

The updated link looks ok to me. -Chris > On 8 Oct 2018, at 19:15, Gary Adams wrote: > > Alan suggested in the bug report for the broken link from the jdwp-protocol > spec to the java/lang/ThreadGroup documentation to simply remove the > href link. Another possibility is to simply update the

Re: RFR: 8201327: Make Sensor deeply immutably thread safe

> On 9 Apr 2018, at 20:31, Alan Bateman wrote: > >> On 09/04/2018 18:54, Martin Buchholz wrote: >> Another little cleanup to make Google's race detector happy. >> >> 8201327: Make Sensor deeply immutably thread safe >>

Re: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

Gary, > http://cr.openjdk.java.net/%7Egadams/8080990/webrev.02/ I think the replacement of WSASendDisconnect with shutdown(SD_SEND) should be fine. I do note that there is another usage of WSASendDisconnect in java.base/windows/native/libnet/net_util_md.c. [ Maybe you want to separate out the

Re: RFR(L): JDK-8154258 [TESTBUG] Various serviceability tests fail compilation

On 25 Apr 2016, at 12:50, Dmitry Samersoff wrote: > Everybody, > > Please review the changes. > > http://cr.openjdk.java.net/~dsamersoff/JDK-8154258/webrev.04/ Thank you Dmitry. Your changes look good to me. As a follow up, it would be nice to refactor the

RFR [9] 8147553: Remove sun.misc.ManagedLocalsThread from java.management

8056152 added a new constructor to java.lang.Thread to constructing Threads that do not inherit inheritable-thread-local initial values. Given there is now a supported API for creating such threads, other areas of the JDK should be updated to use it. This change updates the code in

Re: RFR [9] 8153737: Unsupported Module

This change has been pushed to jdk9/dev. The hotspot gatekeeper will bring it down into the hotspot forests. -Chris. > On 7 Apr 2016, at 18:14, Chris Hegarty <chris.hega...@oracle.com> wrote: > > Enough technical debt has been paid down that we can now create the new > J

Re: RFR [9] 8153737: Unsupported Module

On 08/04/16 03:52, Mandy Chung wrote: On Apr 7, 2016, at 10:14 AM, Chris Hegarty <chris.hega...@oracle.com> wrote: Enough technical debt has been paid down that we can now create the new JDK-specific module as proposed by JEP 260 [1], named jdk.unsupported. This module will initially c

Re: RFR [9] 8153737: Unsupported Module

On 07/04/16 19:57, Alan Bateman wrote: On 07/04/2016 18:14, Chris Hegarty wrote: Enough technical debt has been paid down that we can now create the new JDK-specific module as proposed by JEP 260 [1], named jdk.unsupported. This module will initially contain, and export, the sun.misc package

Re: RFR [9] 8153737: Unsupported Module

On 08/04/16 15:31, Peter Levart wrote: On 04/08/2016 12:24 PM, Paul Sandoz wrote: On 7 Apr 2016, at 19:14, Chris Hegarty <chris.hega...@oracle.com> wrote: Enough technical debt has been paid down that we can now create the new JDK-specific module as proposed by JEP 260 [1],

RFR [9] 8153737: Unsupported Module

Enough technical debt has been paid down that we can now create the new JDK-specific module as proposed by JEP 260 [1], named jdk.unsupported. This module will initially contain, and export, the sun.misc package, and will eventually export the sun.reflect package too ( once it has been sanitized

Re: RFR [9] 8153181: Examine sun.misc.VMSupport

al.perf.Perf. >> It could although I assume this means that introducing a new shared library. > > jdk.internal.perf is in java.base. Another option is to move it to > jdk.jvmstat that i considered but may not worth it since perf counter is > still in java.base. > > Mandy

Re: RFR [9] 8150168: jconsole AboutDialog should use the JDK specific Version API

progress can be made on finding it a new home. Ultimately, these other areas should use the new JDK specific Version API. It is a simple matter of a string substitution later if jdk.Version is moved to a new home. -Chris. > -Alan > > On 18/02/2016 13:42, Chris Hegarty wrote: >> Wit

RFR [9] 8150168: jconsole AboutDialog should use the JDK specific Version API

With the introduction of a JDK specific Version API, the console AboutDialog should no longer use sun.misc.Version. It should be be updated to use the new JDK specific API. diff --git a/src/jdk.jconsole/share/classes/sun/tools/jconsole/AboutDialog.java

Re: RFR : JDK-8147610 - javax/management/mxbean/MXBeanLoadingTest1.java assumes URLClassLoader

On 09/02/16 06:30, Harsha Wardhana B wrote: Hi All, I request you to review fix for, Issue : JDK-8147610 - javax/management/mxbean/MXBeanLoadingTest1.java assumes URLClassLoader Webrev : http://cr.openjdk.java.net/~hb/8147610/werev.00/ I will leave it to others to comment on the specifics

Re: jmx-dev RFR 8145982: JMXInterfaceBindingTest is failing intermittently

On 22 Dec 2015, at 17:25, olivier.lagn...@oracle.com wrote: > Hi Jaroslav, > > Looks good. Not a reviewer however. +1 -Chris. > Olivier. > > On 22/12/2015 17:50, Jaroslav Bachorik wrote: >> Please, review this trivial test change >> >> Issue :

Re: RFR 8068233: java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java is still in exclude list

On 29 Dec 2014, at 11:04, Jaroslav Bachorik jaroslav.bacho...@oracle.com wrote: Please, review this simple ProblemList.txt update Issue : https://bugs.openjdk.java.net/browse/JDK-8068233 Webrev: http://cr.openjdk.java.net/~jbachorik/8068233/webrev.00 Part of the fix for JDK-8058506

RFR [9]: javax/management/remote/mandatory/connection/RMIConnector_NPETest.java fails to compile

The changes in 8035000 [1] changed some common rmi testlibrary classes, RMID.java for one, and this test no longer compiles. The test should call RMID destroy() instead of shutdown(..). ../chhegar/s/jdk/test/javax/management/remote/mandatory/connection/RMIConnector_NPETest.java:64: error:

Re: RFR: 8056143: java/lang/management/MemoryMXBean/LowMemoryTest.java leaves running process on Windows

Reviewed. -Chris. On 27/08/14 09:48, Stefan Karlsson wrote: Hi all, Please review this patch to put the LowMemoryTest.java test in the ProblemLists.txt. It currently hangs and leaves processes running after the test run has completed. http://cr.openjdk.java.net/~stefank/8056143/webrev.00/

Re: 8056148: Add java/lang/management/MemoryMXBean/LowMemoryTest.java to ProblemList.txt

Looks ok to me. -Chris. On 27/08/14 10:11, Stefan Karlsson wrote: Hi all, Please review this patch to put the LowMemoryTest.java test in the ProblemLists.txt. It currently hangs and leaves processes running after the test run has completed.

Re: Review request: 8055230: Rename attach provider implementation class

On 26 Aug 2014, at 08:26, Alan Bateman alan.bate...@oracle.com wrote: On 26/08/2014 05:29, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8055230/ This patch renames the class name of attach provider implementation class to be the same for all platforms.

Re: RFR(S): JDK-8029172: warnings from b117 for hotspot.agent.src.os.linux: JNI exception pending

Looks good to me Dmitry. -Chris On 10 Aug 2014, at 10:32, Dmitry Samersoff dmitry.samers...@oracle.com wrote: Please review: http://cr.openjdk.java.net/~dsamersoff/JDK-8029172/webrev.01/ Added more exception checks to agent/src/os/linux/LinuxDebuggerLocal.c -- Dmitry Samersoff

Re: RFR(S): JDK-8035952 Remove use of JVM_Open, JVM_Read and JVM_Close functions from serviceability code

Looks good to me Frederic. JVM_Read is restartable, but that may not be an issue here. -Chris. On 28 Feb 2014, at 21:19, frederic parain frederic.par...@oracle.com wrote: Greetings, Please review this small changeset for CR JDK-8035952 Remove use of JVM_Open, JVM_Read and JVM_Close

Re: RFR: JDK-8033917 Keep track of file paths in file streams and channels for instrumentation purposes

On 07/02/14 15:24, Dmitry Samersoff wrote: Staffan, FileInputStream.java 55: It's better to initialize path with null. I'm afraid I disagree with this. The default value is already null, why set it to null again? I see this pattern all over the code, but it seems completely redundant to

Re: RFR 8031420: sun/management/jmxremote/bootstrap/CustomLauncherTest.java fails on some platforms: Unable to locate 'libjvm.so'

Looks fine to me. -Chris. On 9 Jan 2014, at 14:05, Jaroslav Bachorik jaroslav.bacho...@oracle.com wrote: Please, review this small test change. Issue : https://bugs.openjdk.java.net/browse/JDK-8031420 Webrev: http://cr.openjdk.java.net/~jbachorik/8031420/webrev.00 The test needs to

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 18080cca998a Author:dl Date: 2014-01-03 06:22 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18080cca998a 8031133: AbstractMap should specify its default implementation using @implSpec Reviewed-by: chegar, alanb ! src/share/classes/java/util/AbstractMap.java

hg: jdk8/tl/jdk: 2 new changesets

Changeset: e2bdddb8bedf Author:dl Date: 2013-12-19 10:31 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2bdddb8bedf 8026155: Enhance ForkJoin pool Reviewed-by: chegar, alanb, ahgross ! src/share/classes/java/util/concurrent/ForkJoinPool.java !

hg: jdk8/tl/jdk: 8029141: Add @FunctionalInterface annotation to Callable interface

Changeset: 2a6611ebfb6c Author:smarks Date: 2013-12-04 18:02 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a6611ebfb6c 8029141: Add @FunctionalInterface annotation to Callable interface Reviewed-by: chegar, alanb ! src/share/classes/java/util/concurrent/Callable.java

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

On 26 Nov 2013, at 18:08, Iris Clark wrote: So overall it looks good to me and should be pushed to the staging forest once you hear from others that commented previously. I think that means Chris Hegarty, Michael McMahon, and Sergey Bylokhov. Alan, please correct me if I'm wrong. I'm

hg: jdk8/tl/jdk: 8029348: ProblemList.txt updates (11/2013)

Changeset: 5bcaf730ceb8 Author:tyan Date: 2013-11-29 09:29 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bcaf730ceb8 8029348: ProblemList.txt updates (11/2013) Reviewed-by: chegar ! test/ProblemList.txt

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 2972241cf7eb Author:tyan Date: 2013-11-21 13:37 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2972241cf7eb 703: test/com/sun/net/httpserver/Test9a.java fails intermittently Summary: Additional stacktrace information is printed on failure Reviewed-by: alanb,

Re: RFR 8028141 intermittent test failure of LocalManagementTest

. Thanks, Roger On 11/18/2013 5:25 PM, Chris Hegarty wrote: On 18 Nov 2013, at 21:59, roger riggs roger.ri...@oracle.com wrote: Please review this fix to improve the reliability of the jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may apply to other tests that fail

hg: jdk8/tl/jdk: 7086879: java/net/InetAddress/CheckJNI.java hangs on Linux when IPv6 enabled

Changeset: d5ddde25d107 Author:tyan Date: 2013-11-19 13:46 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5ddde25d107 7086879: java/net/InetAddress/CheckJNI.java hangs on Linux when IPv6 enabled Reviewed-by: chegar ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8028094: TEST_BUG: java/lang/ProcessBuilder/Basic.java leaves sleep 6666 processes behind

Changeset: cfbee8ee71bf Author:bvaidya Date: 2013-11-19 15:31 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cfbee8ee71bf 8028094: TEST_BUG: java/lang/ProcessBuilder/Basic.java leaves sleep processes behind Reviewed-by: chegar !

Re: RFR 8028141 intermittent test failure of LocalManagementTest

On 18 Nov 2013, at 21:59, roger riggs roger.ri...@oracle.com wrote: Please review this fix to improve the reliability of the jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may apply to other tests that fail with ClassNotFound. The tests did not include the

hg: jdk8/tl/jdk: 8022213: Intermittent test failures in java/net/URLClassLoader

Changeset: 70f1bed5e7fd Author:chegar Date: 2013-11-13 16:44 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70f1bed5e7fd 8022213: Intermittent test failures in java/net/URLClassLoader Reviewed-by: dxu, alanb ! test/java/net/URLClassLoader/closetest/CloseTest.java !

hg: jdk8/tl/jdk: 8028102: All test targets, jdk/test/Makefile, fail on Windows

Changeset: b48eded97dff Author:chegar Date: 2013-11-11 10:33 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b48eded97dff 8028102: All test targets, jdk/test/Makefile, fail on Windows Reviewed-by: mduigou ! test/Makefile

hg: jdk8/tl/jdk: 8022963: java/net/NetworkInterface/Equals.java fails equality for Windows Teredo Interface

Changeset: 3112729d6b74 Author:tyan Date: 2013-11-08 15:12 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3112729d6b74 8022963: java/net/NetworkInterface/Equals.java fails equality for Windows Teredo Interface Reviewed-by: chegar !

hg: jdk8/tl/jdk: 8019834: InetAddress.getByName hangs for bad IPv6 literals

Changeset: 771c77b49bb6 Author:chegar Date: 2013-11-08 15:15 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/771c77b49bb6 8019834: InetAddress.getByName hangs for bad IPv6 literals Reviewed-by: alanb ! src/share/classes/java/net/InetAddress.java !

hg: jdk8/tl/jdk: 8027822: ProblemList.txt Updates (11/2013)

Changeset: f37d62e295c0 Author:chegar Date: 2013-11-07 08:04 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f37d62e295c0 8027822: ProblemList.txt Updates (11/2013) Reviewed-by: chegar, alanb Contributed-by: Amy Lu amy...@oracle.com ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8027961: Inet[4|6]Address native initializing code should check field/MethodID values

Changeset: 82b276590b85 Author:chegar Date: 2013-11-07 08:23 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82b276590b85 8027961: Inet[4|6]Address native initializing code should check field/MethodID values Reviewed-by: michaelm, rriggs !

Re: Review request for 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java

On 05/11/2013 03:20, Mandy Chung wrote: David, Rereading your comment and I think you misread the switch statement (see my comments below). In any case, I revisited ThreadStateController.java and looked int the potential races and have done further cleanup. Here is the updated webrev.

hg: jdk8/tl/jdk: 8026880: NetworkInterface native initializing code should check fieldID values

Changeset: 9a5048dc7c0d Author:chegar Date: 2013-10-30 14:41 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a5048dc7c0d 8026880: NetworkInterface native initializing code should check fieldID values Reviewed-by: alanb ! src/solaris/native/java/net/NetworkInterface.c !

hg: jdk8/tl/jdk: 8027466: Revert jdk/THIRD_PARTY_README to known good version

Changeset: 121c34517841 Author:chegar Date: 2013-10-29 17:21 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/121c34517841 8027466: Revert jdk/THIRD_PARTY_README to known good version Reviewed-by: alanb ! THIRD_PARTY_README

hg: jdk8/tl/jdk: 7079145: Remove java/net/ipv6tests/UdpTest.java from the ProblemList.txt

Changeset: d126301ad372 Author:ewang Date: 2013-10-25 11:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d126301ad372 7079145: Remove java/net/ipv6tests/UdpTest.java from the ProblemList.txt Reviewed-by: alanb, chegar ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8020758: HttpCookie constructor does not throw IAE when name contains a space

Changeset: f120672b91ef Author:chegar Date: 2013-10-23 14:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f120672b91ef 8020758: HttpCookie constructor does not throw IAE when name contains a space Reviewed-by: michaelm, msheppar !

hg: jdk8/tl/jdk: 8017779: java/net/Authenticator/B4769350.java fails

Changeset: 7cafbb397683 Author:chegar Date: 2013-10-22 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cafbb397683 8017779: java/net/Authenticator/B4769350.java fails Reviewed-by: chegar Contributed-by: Tristan Yan tristan@oracle.com, Kurchi Subhra Hazra

hg: jdk8/tl/jdk: 8023390: Test java/net/NetworkInterface/MemLeakTest.java failed with the latest jdk8 build

Changeset: 6a1989dc302d Author:igerasim Date: 2013-10-15 18:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a1989dc302d 8023390: Test java/net/NetworkInterface/MemLeakTest.java failed with the latest jdk8 build Summary: Removing the test as it is unreliable and fails

hg: jdk8/tl/jaxp: 14 new changesets

Changeset: ecb66dc473c1 Author:joehw Date: 2013-07-16 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ecb66dc473c1 8012425: Transform TransformerFactory Reviewed-by: alanb, dfuchs, mullan ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java !

hg: jdk8/tl/jaxws: 11 new changesets

Changeset: 43240b8b995b Author:mkos Date: 2013-08-01 16:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/43240b8b995b 8017505: Better Client Service Reviewed-by: mullan, ahgross, mgrebac !

hg: jdk8/tl: 3 new changesets

Changeset: af87dabb4263 Author:msheppar Date: 2013-06-14 15:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/af87dabb4263 8011157: Improve CORBA portablility Summary: fix also reviewed by Alexander Fomin Reviewed-by: alanb, coffeys, skoivu ! common/makefiles/RMICompilation.gmk

hg: jdk8/tl/corba: 15 new changesets

Changeset: 81d694b1ab2f Author:msheppar Date: 2013-06-14 16:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/81d694b1ab2f 8011157: Improve CORBA portablility Summary: fix also reviewed by Alexander Fomin Reviewed-by: alanb, coffeys, skoivu !

hg: jdk8/tl/hotspot: 13 new changesets

Changeset: 5c599c419c1d Author:hseigel Date: 2013-07-11 12:59 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5c599c419c1d 8016256: Make finalization final Summary: Add private methods to final methods check Reviewed-by: coleenp, acorn, ahgross Contributed-by:

hg: jdk8/tl/jdk: 61 new changesets

Changeset: b3baca585b7f Author:jbachorik Date: 2013-04-23 09:37 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3baca585b7f 8011081: Improve jhat Summary: Properly escape HTML output Reviewed-by: alanb, mschoene, sundar !

hg: jdk8/tl/langtools: 14 new changesets

Changeset: 84df20dc604a Author:bpatel Date: 2013-07-24 15:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84df20dc604a 8016675: Make Javadoc pages more robust Reviewed-by: jlaskey, ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java

hg: jdk8/tl/jdk: 8023555: test/java/net/Socks/SocksProxyVersion.java fails when machine name is localhost

Changeset: 077237e4613f Author:tyan Date: 2013-10-14 11:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/077237e4613f 8023555: test/java/net/Socks/SocksProxyVersion.java fails when machine name is localhost Reviewed-by: chegar, alanb !

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

Alan, I checked the httpsever and sctp changes. All look good to me. -Chris. On 10/06/2013 09:03 PM, Alan Bateman wrote: As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, I'd like to have another attempt at adding the annotation to a number of JDK specific APIs that are

hg: jdk8/tl/jdk: 8016271: wsimport -clientjar does not create portable jars on Windows due to hardcoded backslash

Changeset: 7d2112abbb1d Author:coffeys Date: 2013-10-04 16:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d2112abbb1d 8016271: wsimport -clientjar does not create portable jars on Windows due to hardcoded backslash Reviewed-by: mkos, chegar +

hg: jdk8/tl/jaxws: 2 new changesets

Changeset: b0610cd08440 Author:mkos Date: 2013-10-04 16:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b0610cd08440 8025054: Update JAX-WS RI integration to 2.2.9-b130926.1035 Reviewed-by: chegar !

Re: RFR: 8014446: JT_JDK: Wrong detection of test result for test com/sun/jdi/NoLaunchOptionTest.java

Look ok to me Peter. -Chris On 4 Oct 2013, at 12:13, Peter Allwin peter.all...@oracle.com wrote: Hello! Looking for reviews for this very simple fix to a JDK test, where warnings in stderr could cause the test to fail. Bug: https://bugs.openjdk.java.net/browse/JDK-8014446 CR:

Re: jmx-dev RFR: 8022220 Intermittent test failures in javax/management/remote/mandatory/connection/RMIConnectionIdTest.java

On 10/03/2013 04:02 PM, Jaroslav Bachorik wrote: ... But it might hardly matter - it seems that the main culprit for this test to fail on this particular configuration was the fact that 127.0.0.1 was *NOT* detected as a loopback IP. This is pretty weird and I have not looked at the

Re: jmx-dev RFR: 8022220 Intermittent test failures in javax/management/remote/mandatory/connection/RMIConnectionIdTest.java

On 10/03/2013 04:37 PM, Jaroslav Bachorik wrote: On 3.10.2013 17:29, Chris Hegarty wrote: On 10/03/2013 04:02 PM, Jaroslav Bachorik wrote: ... But it might hardly matter - it seems that the main culprit for this test to fail on this particular configuration was the fact that 127.0.0.1

Re: RFR: 8012923: [parfait] File Descriptor Leak in jdk/src/windows/demo/jvmti/hprof/hprof_md.c

On 30 Sep 2013, at 13:06, Peter Allwin peter.all...@oracle.com wrote: Thanks everyone for the reviews, just need a JDK reviewer to approve this! The changes look good to me. -Chris. /peter On Sep 16, 2013, at 5:44 PM, Peter Allwin peter.all...@oracle.com wrote: Hello! Please

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

Volker, I skimmed over the networking part of the changes, and nothing jumps out at me. I'd like to spend a little more time doing a more detailed review, but I will not have time to do this until after JavaOne. -Chris. On 09/16/2013 08:30 PM, Volker Simonis wrote: Resending this to more

hg: jdk8/tl/jdk: 8015762: TEST_BUG: java/nio/channels/DatagramChannel/AdaptDatagramSocket.java failing intermittently [win]

Changeset: b3a506a30fda Author:ewang Date: 2013-09-18 15:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3a506a30fda 8015762: TEST_BUG: java/nio/channels/DatagramChannel/AdaptDatagramSocket.java failing intermittently [win] Reviewed-by: chegar, alanb !

hg: jdk8/tl/jdk: 8024675: java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows

Changeset: c53411f89b4c Author:msheppar Date: 2013-09-13 12:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c53411f89b4c 8024675: java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows Summary: amended test to add active, i.e. isUp(), NetworkInterfaces to

Re: RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out

On 09/12/2013 04:45 AM, David Holmes wrote: Hi Jaroslav, You need a copyright notice in the new file. As written this test can only run on a full JDK - so please add it to the :needs_jdk group in TEST.groups. (Does jcmd really needs to come from the test-jdk? And use the VMOPTS passed to the

hg: jdk8/tl/jdk: 8024508: Fix doclint issues in com.sun.nio.sctp

Changeset: 517c5e99fb2f Author:chegar Date: 2013-09-11 11:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/517c5e99fb2f 8024508: Fix doclint issues in com.sun.nio.sctp Reviewed-by: alanb ! src/share/classes/com/sun/nio/sctp/Association.java !

hg: jdk8/tl/jdk: 8023090: Additional debug info for java/net/NetworkInterface/Equals.java

Changeset: d389dedd1ccb Author:chegar Date: 2013-09-11 11:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d389dedd1ccb 8023090: Additional debug info for java/net/NetworkInterface/Equals.java Reviewed-by: alanb ! test/java/net/NetworkInterface/Equals.java

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 02064634bc88 Author:msheppar Date: 2013-09-06 15:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/02064634bc88 8023326: [TESTBUG] java/net/CookieHandler/LocalHostCookie.java misplaced try/finally Summary: amended test to be more robust to set of potential

Re: RFR: 8004179: test/java/lang/management/ThreadMXBean/SynchronizerLockingThread.java doesn't clean up

On 09/03/2013 09:02 AM, Jaroslav Bachorik wrote: Please, review the following patch: http://cr.openjdk.java.net/~jbachorik/8004179/webrev.01 Issue: https://bugs.openjdk.java.net/browse/JDK-8004179 It addresses the problem of the test not properly cleaning up the created threads at exit. It

hg: jdk8/tl/jdk: 8024103: AtomicLongArray getAndAccumulate/accumulateAndGet have int type for new value arg

Changeset: 441da45931fa Author:chegar Date: 2013-09-02 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/441da45931fa 8024103: AtomicLongArray getAndAccumulate/accumulateAndGet have int type for new value arg Reviewed-by: alanb, psandoz !

hg: jdk8/tl/jdk: 6470700: Math.random() / Math.initRNG() uses double checked locking

Changeset: 223be1d3494f Author:bpb Date: 2013-08-22 13:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/223be1d3494f 6470700: Math.random() / Math.initRNG() uses double checked locking Summary: Replace class Random variable with a static final holder class Reviewed-by:

hg: jdk8/tl/jaxws: 8022885: Update JAX-WS RI integration to 2.2.9-b14140; ...

Changeset: b99d7e355d4b Author:mkos Date: 2013-08-23 09:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b99d7e355d4b 8022885: Update JAX-WS RI integration to 2.2.9-b14140 8013016: Rebase 8009009 against the latest jdk8/jaxws Reviewed-by: alanb, chegar !

hg: jdk8/tl/jaxws: 8023636: Missing files from 8022885

Changeset: d8593d8581df Author:mkos Date: 2013-08-23 11:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d8593d8581df 8023636: Missing files from 8022885 Reviewed-by: alanb, chegar + src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/StreamingSOAP.java +

Re: RFR: Remove tests from ProblemList.txt

Looks good to me. -Chris On 21 Aug 2013, at 15:31, Markus Grönlund markus.gronl...@oracle.com wrote: Thanks for taking a look at these old bugs Staffan. Looks good (not a Reviewer). /Markus -Original Message- From: Staffan Larsen Sent: den 21 augusti 2013 16:21 To:

hg: jdk8/tl: 8021820: Number of opened files used in select() is limited to 1024 [macosx]

Changeset: 00dcfaa6bc01 Author:aefimov Date: 2013-08-16 18:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/00dcfaa6bc01 8021820: Number of opened files used in select() is limited to 1024 [macosx] Reviewed-by: alanb, chegar, tbell, smarks !

hg: jdk8/tl/jdk: 8021820: Number of opened files used in select() is limited to 1024 [macosx]

Changeset: 11ccaabdb2a8 Author:aefimov Date: 2013-08-16 18:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11ccaabdb2a8 8021820: Number of opened files used in select() is limited to 1024 [macosx] Reviewed-by: alanb, chegar, tbell, smarks +

hg: jdk8/tl/jdk: 8022584: Memory leak in some NetworkInterface methods

Changeset: 7d7d553a8c61 Author:igerasim Date: 2013-08-13 13:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d7d553a8c61 8022584: Memory leak in some NetworkInterface methods Reviewed-by: alanb, dholmes, chegar, michaelm ! src/solaris/native/java/net/NetworkInterface.c +

hg: jdk8/tl/jdk: 8023103: FJ parallelism zero; ...

Changeset: 3223342fb76e Author:dl Date: 2013-08-15 15:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3223342fb76e 8023103: FJ parallelism zero 8020537: java/util/concurrent/forkjoin/ThrowingRunnable.java Reviewed-by: chegar, mduigou, alanb !

hg: jdk8/tl/jdk: 8023104: ConcurrentHashMap typo

Changeset: b07b19182e40 Author:dl Date: 2013-08-15 15:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b07b19182e40 8023104: ConcurrentHashMap typo Reviewed-by: chegar, mduigou ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java

hg: jdk8/tl/jdk: 8022126: Remove throws SocketException from DatagramPacket constructors accepting SocketAddress

Changeset: e7137695dce3 Author:chegar Date: 2013-08-15 15:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7137695dce3 8022126: Remove throws SocketException from DatagramPacket constructors accepting SocketAddress Reviewed-by: smarks, alanb, michaelm, darcy !

hg: jdk8/tl/jdk: 8022779: ProblemList.txt updates (8/2013)

Changeset: 18e15d92610b Author:chegar Date: 2013-08-13 14:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18e15d92610b 8022779: ProblemList.txt updates (8/2013) Summary: Update ProblemList and remove AggressiveOpts MOAT test run Reviewed-by: chegar, alanb Contributed-by:

hg: jdk8/tl/jdk: 8022661: InetAddress.writeObject() performs flush() on object output stream

Changeset: 84004d0e3fdd Author:chegar Date: 2013-08-09 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84004d0e3fdd 8022661: InetAddress.writeObject() performs flush() on object output stream Reviewed-by: michaelm, alanb ! src/share/classes/java/net/InetAddress.java

hg: jdk8/tl/jdk: 8022724: lint warnings in j.u.concurrent packages

Changeset: ce1c874903cb Author:dl Date: 2013-08-09 17:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce1c874903cb 8022724: lint warnings in j.u.concurrent packages Reviewed-by: chegar, lancea, darcy ! src/share/classes/java/util/concurrent/CompletableFuture.java !

hg: jdk8/tl/jdk: 8022344: Additional debug info for test/java/net/NetworkInterface/IndexTest.java

Changeset: 6773af0dda02 Author:chegar Date: 2013-08-06 15:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6773af0dda02 8022344: Additional debug info for test/java/net/NetworkInterface/IndexTest.java Reviewed-by: michaelm, alanb !

hg: jdk8/tl/jdk: 8022121: Remove superfluous @test tag from SpliteratorTraversingAndSplittingTest

Changeset: 60c275e56a69 Author:chegar Date: 2013-08-02 11:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60c275e56a69 8022121: Remove superfluous @test tag from SpliteratorTraversingAndSplittingTest Reviewed-by: psandoz !

  1   2   3   4   >