[Spacewalk-devel] LICENSE file in proxy/proxy-docs

2009-05-14 Thread Miroslav Suchy
If proxy/proxy-docs/LICENSE is some kind of Red Hat Eula. It is OK to replace it with GPLv2 text? Or we really release Proxy documentation under license different from GPLv2? Miroslav Suchy ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: All, I'd like to start getting some eyes on the pgsql branch in preparation of a merge to master. So far, the changes on this branch have been focused on porting the schema and updating the application infrastructure to work

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: The goal here was to push as much of the schema into common as practical and make the schema code tree as developer friendly as possible. - The schema directory has been refactored replacing rhnsat/ with: oracle/

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
Another email, focusing on the tables/ directory. On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: - Table files (rhnsat/tables/*) - table.sql files: - Most moved to common/tables/ - Trigger DDL split out and moved into existing or new oracle/triggers/table.sql -

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: - Upgrades (upgrade/* directories files): - Most files (git) moved to common/upgrade/upgrade - Few files forked: (git) moved to oracle/upgrade/upgrade. - Few files forked: copied to postgres/upgrade/upgrade and ported to PG.

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: MAKEFILES The Makefile.schema refactored into a /regular/ makefile. Dependency sorting and .sql file aggregation split out into a build tool named blend. Although, make does do dependency sorting with the .deps files, the

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: PACKAGING The spacewalk-schema.spec was updated to package and install install / upgrade scripts for both oracle and postgres. The files are installed in: /etc/sysconif/rhn/oracle/ main.sql spacewalk_0.4-spacewalk_0.5.sql

Re: [Spacewalk-devel] Why rhn-client-tools requires yum-rhn-plugin?

2009-05-14 Thread Pradeep Kilambi
Miroslav Suchy wrote: We have cyclic dependency between rhn-client-tools and yum-rhn-plugin, which seems to be bad for Fedora review. I tried to look on code in rhn-client-tools code, but I did not find direct dependency on yum-rhn-plugin. Did I miss something? Yes, they are interdependent

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Thanks for you comments! Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: All, I'd like to start getting some eyes on the pgsql branch in preparation of a merge to master. So far, the changes on this branch have been focused on porting the schema and

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: The goal here was to push as much of the schema into common as practical and make the schema code tree as developer friendly as possible. - The schema directory has been refactored replacing rhnsat/

Re: [Spacewalk-devel] Why rhn-client-tools requires yum-rhn-plugin?

2009-05-14 Thread Pradeep Kilambi
Miroslav Suchy wrote: - Pradeep Kilambi pkila...@redhat.com wrote: cdn support. If you use yum-rhn-plugin 0.5.3-30 with latest version of rhn-client tools it will break the multiarch support. If you use latest yum-rhn-plugin with older rhn-client-tools it will break cdn and

Re: [Spacewalk-devel] Why rhn-client-tools requires yum-rhn-plugin?

2009-05-14 Thread Jan Pazdziora
On Thu, May 14, 2009 at 10:50:11AM -0400, Pradeep Kilambi wrote: cdn support. If you use yum-rhn-plugin 0.5.3-30 with latest version of rhn-client tools it will break the multiarch support. If you use latest yum-rhn-plugin with older rhn-client-tools it will break cdn and versioning

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: Another email, focusing on the tables/ directory. On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: - Table files (rhnsat/tables/*) - table.sql files: - Most moved to common/tables/ - Trigger DDL split out and moved into existing or new

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: - Upgrades (upgrade/* directories files): - Most files (git) moved to common/upgrade/upgrade - Few files forked: (git) moved to oracle/upgrade/upgrade. - Few files forked: copied to

Re: [Spacewalk-devel] Why rhn-client-tools requires yum-rhn-plugin?

2009-05-14 Thread Pradeep Kilambi
Jan Pazdziora wrote: On Thu, May 14, 2009 at 10:50:11AM -0400, Pradeep Kilambi wrote: cdn support. If you use yum-rhn-plugin 0.5.3-30 with latest version of rhn-client tools it will break the multiarch support. If you use latest yum-rhn-plugin with older rhn-client-tools it will

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jason Dobies
Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: STYLE You may notice that the common/tables/*.sql were formatted using chameleon. Consistent with most DDL/SQL style guides, chameleon renders keywords in caps and uses spaces instead of tabs. If you don't like

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: At build, common (common/) files are transformed by a build tool named chameleon into DB specific files. For example: # # cd oracle # chameleon -s oracle -o tables/common/x.sql ../common/tables/x.sql # Long

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: MAKEFILES The Makefile.schema refactored into a /regular/ makefile. Dependency sorting and .sql file aggregation split out into a build tool named blend. Although, make does do dependency sorting with the

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote: PACKAGING The spacewalk-schema.spec was updated to package and install install / upgrade scripts for both oracle and postgres. The files are installed in: /etc/sysconif/rhn/oracle/ main.sql

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jan Pazdziora
On Thu, May 14, 2009 at 03:18:25PM -0400, Jeff Ortel wrote: You cannot aggregate upgrade scripts because other products (like Satellite) might want to address individual upgrade scripts (via symlinks, or, work-in-progress, via references). There is a reason we kept the upgrade scripts

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Thu, May 14, 2009 at 03:18:25PM -0400, Jeff Ortel wrote: You cannot aggregate upgrade scripts because other products (like Satellite) might want to address individual upgrade scripts (via symlinks, or, work-in-progress, via references). There is a reason we kept the

Re: [Spacewalk-devel] pgsql review

2009-05-14 Thread Jeff Ortel
Jan Pazdziora wrote: On Thu, May 14, 2009 at 02:33:47PM -0400, Jeff Ortel wrote: Note: I don't really care about the actual format, so I'm not voting against the format per se (apart from the trailing spaces it seems to introduce). We can put together some coding guidelines and use them for