[PATCH 8/9] profile.c: remove a variable which is set but not used

2014-10-26 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com fill_o2_values(): struct gas_pressures *pressures; Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- profile.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/profile.c b/profile.c index bea556f..f0b7041 100644 --- a/profile.c +++ b

[PATCH 7/9] profile.c: remove unused variables in calculate_ccr_po2()

2014-10-26 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- profile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/profile.c b/profile.c index d64d1c7..bea556f 100644 --- a/profile.c +++ b/profile.c @@ -833,9 +833,9 @@ void

[PATCH 5/9] divelogexportdialog.cpp: attempt to fix a 'unsigned / signed' warning

2014-10-26 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com duration_t holds unsinged values, offset_t holds signed values. Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- not sure about this one... can a picture offset be negative anyhow? --- qt-ui/divelogexportdialog.cpp | 2 +- 1 file changed, 1

[PATCH 6/9] deco.c: remove unused variables in add_segment()

2014-10-26 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- deco.c | 1 - 1 file changed, 1 deletion(-) diff --git a/deco.c b/deco.c index 8dcfb7e..d0bcaa6 100644 --- a/deco.c +++ b/deco.c @@ -187,7 +187,6 @@ double he_factor(int period_in_seconds, int

Re: [PATCH 0/9] fix some warnings

2014-10-27 Thread Lubomir I. Ivanov
On 27 October 2014 05:18, Dirk Hohndel d...@hohndel.org wrote: On Sat, Oct 25, 2014 at 01:03:28PM +0300, Lubomir I. Ivanov wrote: please ignore anything in particular if you see fit. i'm not really advocating any of these. [PATCH 1/9] MainWindow: prevent a possible crash on re-plan [PATCH 2

Re: [PATCH 0/9] fix some warnings

2014-10-27 Thread Lubomir I. Ivanov
On 27 October 2014 22:44, Robert Helling hell...@atdotde.de wrote: On 27 Oct 2014, at 21:03, Lubomir I. Ivanov neolit...@gmail.com wrote: this is Robert's code (CC) so perhaps he or others have some ideas. on a brief look, DiveLogExportDialog::export_depths() would not always produce

cochran_emc.h: packed structs

2014-10-28 Thread Lubomir I. Ivanov
} __attribute__((packed)); is unreliable with MINGW 4.6 up until 4.8.2 - the one i have bundled with the Qt 5.3. padding is added regardless and there is high potential for the code to break. one solution would be to branch / use #pragma pack() which is an MSVC thing but recent MINGW supports

[PATCH 1/4] dive.h: add a 'unsafe' variant of FOR_EACH_PICTURE

2014-10-28 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com This prevents a warning caused by -Waddress, that the address of 'displayed_dive' will always be defined. We don't really want to disable this warning group as it's *actually* useful in terms of partability. A previous, less intrusive solution was also

[PATCH 2/4] cochran.c: coding style cleanup

2014-10-28 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com - empty lines - indentation - { placement - others... Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- cochran.c | 434 +- 1 file changed, 200 insertions(+), 234 deletions(-) diff

[PATCH 3/4] cochran.c: mark 'ascent_rate' as unused

2014-10-28 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com cochran_parse_samples(): 'ascent_rate' can be used at some point so we mark it as unused with (void) Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- cochran.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cochran.c b/cochran.c index

[PATCH 4/4] cochran.c: make cochran_predive_event_bytes() return 0

2014-10-28 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com It seems that an iteration will happen even if the function returns 0, but this looks like a non-breaking change. Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- cochran.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cochran.c b

Re: cochran_emc.h: packed structs

2014-10-28 Thread Lubomir I. Ivanov
On 28 October 2014 16:28, Dirk Hohndel d...@hohndel.org wrote: On Tue, Oct 28, 2014 at 01:28:47PM +0200, Lubomir I. Ivanov wrote: } __attribute__((packed)); is unreliable with MINGW 4.6 up until 4.8.2 - the one i have bundled with the Qt 5.3. Yes, Jef pointed that out (with less detail

Re: cochran_emc.h: packed structs

2014-10-28 Thread Lubomir I. Ivanov
On 28 October 2014 17:17, Thiago Macieira thi...@macieira.org wrote: On Tuesday 28 October 2014 08:09:20 Dirk Hohndel wrote: On October 28, 2014 8:05:20 AM Lubomir I. Ivanov neolit...@gmail.com wrote: On 28 October 2014 16:28, Dirk Hohndel d...@hohndel.org wrote: On Tue, Oct 28, 2014 at 01

Re: cochran_emc.h: packed structs

2014-10-28 Thread Lubomir I. Ivanov
On 28 October 2014 17:54, Thiago Macieira thi...@macieira.org wrote: On Tuesday 28 October 2014 17:39:27 Lubomir I. Ivanov wrote: __declspec(packed) i don't have that in MSVC 2003; perhaps it's a newer feature. Yeah, I was wrong, it's not there. http://msdn.microsoft.com/en-us/library

Re: cochran_emc.h: packed structs

2014-10-28 Thread Lubomir I. Ivanov
On 28 October 2014 18:28, Thiago Macieira thi...@macieira.org wrote: On Tuesday 28 October 2014 18:03:27 Lubomir I. Ivanov wrote: On 28 October 2014 17:54, Thiago Macieira thi...@macieira.org wrote: On Tuesday 28 October 2014 17:39:27 Lubomir I. Ivanov wrote: __declspec(packed) i don't

Re: cochran_emc.h: packed structs

2014-10-28 Thread Lubomir I. Ivanov
On 28 October 2014 20:43, Thiago Macieira thi...@macieira.org wrote: On Tuesday 28 October 2014 09:32:17 Dirk Hohndel wrote: A typical 8 byte sample might look like this: struct sample { unsigned char temp; // in F unsigned int16_t depth; // in 1/16 ft unsigned

Re: cochran_emc.h: packed structs

2014-10-28 Thread Lubomir I. Ivanov
On 28 October 2014 21:26, Jef Driesen j...@libdivecomputer.org wrote: On 28-10-14 17:32, Dirk Hohndel wrote: The reason so many people reverse engineering want packed structures is that it makes it so much easier to write readable code. A typical 8 byte sample might look like this: struct

Re: File::encodeName() and Utf8 as the default encoding under Qt5

2014-10-29 Thread Lubomir I. Ivanov
On 29 October 2014 17:32, Lubomir I. Ivanov neolit...@gmail.com wrote: hi Thiogo, oops sorry - typo (Thiago). lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo

[PATCH] Divelist: make the column headers for units left aligned

2014-10-29 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com Fixes #739 Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- qt-ui/models.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qt-ui/models.cpp b/qt-ui/models.cpp index ef76e7e..f548d37 100644 --- a/qt-ui/models.cpp

Re: File::encodeName() and Utf8 as the default encoding under Qt5

2014-10-29 Thread Lubomir I. Ivanov
On 29 October 2014 18:27, Dirk Hohndel d...@hohndel.org wrote: On Wed, Oct 29, 2014 at 06:18:14PM +0200, Lubomir I. Ivanov wrote: On 29 October 2014 18:02, Thiago Macieira thi...@macieira.org wrote: On Wednesday 29 October 2014 17:32:58 Lubomir I. Ivanov wrote: now, i know how to fix

Re: File::encodeName() and Utf8 as the default encoding under Qt5

2014-10-29 Thread Lubomir I. Ivanov
On 29 October 2014 20:33, Dirk Hohndel d...@hohndel.org wrote: On Wed, Oct 29, 2014 at 07:04:20PM +0200, Lubomir I. Ivanov wrote: change affects QString::toLocal8Bit(), so i've tried some of the areas where toLocal8Bit() is used in the app (Win32): - cmd arguments: no problem (with special

Re: help understanding a Windows crash report

2014-10-30 Thread Lubomir I. Ivanov
On 30 October 2014 00:07, Dirk Hohndel d...@hohndel.org wrote: Please test http://subsurface-divelog.org/downloads/daily/subsurface-4.2-349-g2b8043b82b99.exe if you have a chance to make sure that it's not just my system where this works again... This one also implements the long missing

Re: stack trace for bug #755

2014-11-11 Thread Lubomir I. Ivanov
On 11 November 2014 15:45, Miika Turkia miika.tur...@gmail.com wrote: #0 strlen () at ../sysdeps/x86_64/strlen.S:106 #1 0x720b523e in __GI___strdup (s=0x0) at strdup.c:41 #2 0x004982e8 in MainTab::acceptChanges (this=this@entry=0x936320) at ../qt-ui/maintab.cpp:698 to me

Re: stack trace for bug #755

2014-11-11 Thread Lubomir I. Ivanov
On 11 November 2014 17:23, Lubomir I. Ivanov neolit...@gmail.com wrote: but i think i found another one: - start new divelog - import dives/test0.xml-test38.xml - select first dive in the trip - select second dive in the trip (dive #35?) it enters an infinite loop allocating 3MB per second

Re: stack trace for bug #755

2014-11-11 Thread Lubomir I. Ivanov
On 11 November 2014 20:55, Dirk Hohndel d...@hohndel.org wrote: On Tue, Nov 11, 2014 at 06:42:34PM +0200, Lubomir I. Ivanov wrote: On 11 November 2014 17:23, Lubomir I. Ivanov neolit...@gmail.com wrote: but i think i found another one: - start new divelog - import dives/test0.xml-test38

Re: stack trace for bug #755

2014-11-11 Thread Lubomir I. Ivanov
On 11 November 2014 20:55, Dirk Hohndel d...@hohndel.org wrote: On Tue, Nov 11, 2014 at 06:42:34PM +0200, Lubomir I. Ivanov wrote: On 11 November 2014 17:23, Lubomir I. Ivanov neolit...@gmail.com wrote: but i think i found another one: - start new divelog - import dives/test0.xml-test38

[PATCH] Print: add the support to store margins and printer options

2014-11-13 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com All the print options will be stored after the user closes or cancels the print dialog. There seems to be no good way to store the last selected page size, because print dialogs are different and some just list them as strings - A4, A3, etc. The patch

Re: Problems compiling Subsurface

2014-11-14 Thread Lubomir I. Ivanov
On 14 November 2014 12:36, Benjamin nyst...@gmail.com wrote: Today, I synced the git tree and when I tried to compile I got the following error: qt-ui/printdialog.cpp:17:21: fatal error: QMarginsF: No such file or directory #include QMarginsF ^ compilation terminated.

Re: Problems compiling Subsurface

2014-11-14 Thread Lubomir I. Ivanov
On 14 November 2014 13:34, Robert Helling hell...@atdotde.de wrote: On 14.11.2014, at 12:15, Lubomir I. Ivanov neolit...@gmail.com wrote: Hi, Today, I synced the git tree and when I tried to compile I got the following error: qt-ui/printdialog.cpp:17:21: fatal error: QMarginsF

Re: Data corruption when saving dives in win daily 4.2.-457

2014-11-14 Thread Lubomir I. Ivanov
On 15 November 2014 00:44, Salvador Cuñat salvador.cu...@gmail.com wrote: On Fri, Nov 14, 2014 at 11:42:11PM +0100, Salvador Cuñat wrote: On Sat, Nov 15, 2014 at 12:00:17AM +0200, Lubomir I. Ivanov wrote: add another cylinder and then save to XML stores both, yet when loading that XML only

Re: bugs in daily build 4.2-549

2014-11-17 Thread Lubomir I. Ivanov
hello, On 17 November 2014 11:05, Salvador Cuñat salvador.cu...@gmail.com wrote: BTW, there is a crash when discarding the changes on the manually added dive. win7 64bit: i can't make it crash by pressing cancel for a manual dive, while adding it or editing after it's added; can you

Re: bugs in daily build 4.2-549

2014-11-17 Thread Lubomir I. Ivanov
On 17 November 2014 15:30, Dirk Hohndel d...@hohndel.org wrote: Anyway, Linux is much more resillient to memory errors - Windows crashes much more aggressively. But I think the crash / corruption should be fixed (famous last words). yes, seems like i cannot reproduce salvador's steps on Win7.

Re: bugs in daily build 4.2-549

2014-11-17 Thread Lubomir I. Ivanov
On 17 November 2014 16:30, Davide DB dbdav...@gmail.com wrote: I forgot: if I discard those changes the app crashes... I this this is useless but... just in case: Nome evento problema: APPCRASH Nome applicazione: subsurface.exe Versione applicazione: 4.2.0.549 that's on an older

[PATCH] Ruler: fix weird behaviour near x = 0

2014-11-17 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com RulerNodeItem2::recalculate() does something which is apparently not a good idea in combination with RulerNodeItem2::mouseMoveEvent(). Each time the mouse moves, setPos() is called. Then in recalculate() the x() value is checked and if less than 0 it's

Re: INSTALL file

2014-11-17 Thread Lubomir I. Ivanov
On 17 November 2014 23:53, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 November 2014 23:49, Steve Butler kg...@comcast.net wrote: Looks like I need to find a non-Canonical source to update. Is there another PPA to which I can point for a later version? that should be it: https

Re: [PATCH 3/6] Create events from mouthpiece position

2014-11-20 Thread Lubomir I. Ivanov
On 20 November 2014 03:47, Dirk Hohndel d...@hohndel.org wrote: Oh the translators will LOVE this. What the HECK is NC and UN? as a layman translator i usually just keep the abbreviations from the source string, even in a case where i have understanding of the meaning, hoping that the user will

Re: RFC patch: store dive computer serial / firmware again

2014-11-20 Thread Lubomir I. Ivanov
On 20 November 2014 23:00, Linus Torvalds torva...@linux-foundation.org wrote: Of course, the right solution would be to just do this right in libdivecomputer.c and have libdivecomputer just format the string right in the first place. Using, say, DC_STRING_FIELD. can't really comment much on

#772

2014-11-23 Thread Lubomir I. Ivanov
can someone give advice to the user @ #772: http://trac.subsurface-divelog.org/ticket/ to my (non-existent) knowledge if one adds cylinders to a dive, those will remain unused and cannot be marked as used and participate in the calculations. is that correct? lubomir --

Re: #772

2014-11-23 Thread Lubomir I. Ivanov
On 23 November 2014 at 21:25, Lubomir I. Ivanov neolit...@gmail.com wrote: can someone give advice to the user @ #772: http://trac.subsurface-divelog.org/ticket/ URL typo: http://trac.subsurface-divelog.org/ticket/772 lubomir -- ___ subsurface

a couple of crashes with the test dives

2014-11-23 Thread Lubomir I. Ivanov
i was testing something by importing all test dives and i think i found some bugs. not sure if these are known or related to WIP code - both patches mention CCR. Win7, 32bit build, Qt 5.3 - 1) (the older bug) introduced in: fa181d1de (CC Dirk) - start with an empty

Re: a couple of crashes with the test dives

2014-11-24 Thread Lubomir I. Ivanov
On 24 November 2014 at 16:46, Robert Helling hell...@atdotde.de wrote: On 24.11.2014, at 14:51, Lubomir I. Ivanov neolit...@gmail.com wrote: Lubomir, with the patch it still crashes with the second backtrace when selecting #36 - #1 (from the same, first trip). the problem

Re: Recompile Marble and Subsurface -- still undefined reference

2014-11-26 Thread Lubomir I. Ivanov
hello, On 26 November 2014 at 06:08, Steve Butler kg...@comcast.net wrote: -- Found Qt4: /usr/bin/qmake-qt4 (found version 4.8.6) snip * Qt4 , cross-platform application framework , http://qt.digia.com/ core framework marble is basically saying it found Qt4.8.6 installed on your system

[PATCH 1/3] file.c: fix uninitialized variable

2014-12-01 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/file.c b/file.c index 07774b1..d31e280 100644 --- a/file.c +++ b/file.c @@ -836,7 +836,7 @@ int parse_csv_file(const

[PATCH 3/3] configuredivecomputerthreads.cpp: conditionally define read_ostc_cf()

2014-12-01 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com Fixes a warning. The function is only used if DC_VERSION_CHECK(0, 5, 0) is defined. Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- configuredivecomputerthreads.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] Remove libdivecomputer ifdefs for configuring OSTC

2014-12-02 Thread Lubomir I. Ivanov
On 2 December 2014 at 19:22, Anton Lundin gla...@acc.umu.se wrote: On 02 December, 2014 - Dirk Hohndel wrote: All of those are nice-to-have but it's not like subsurface is useless without them. The only thing we need to test is that we actually still work with a libdivecomputer 0.4.2. It's

Re: [PATCH] Remove libdivecomputer ifdefs for configuring OSTC

2014-12-02 Thread Lubomir I. Ivanov
On 2 December 2014 at 20:38, Dirk Hohndel d...@hohndel.org wrote: On Tue, Dec 02, 2014 at 08:10:51PM +0200, Lubomir I. Ivanov wrote: but i don't own a DC to test it. Have you played with Jef's dive computer simulator? It's pretty awesome and I often use it for testing. You can simulate quite

Re: daily builds for Ubuntu

2014-12-02 Thread Lubomir I. Ivanov
On 2 December 2014 at 23:29, Dirk Hohndel d...@hohndel.org wrote: (btw - tip of master of libgit2 is already incompatible again with Subsurface... what is WRONG with these people?). oh man, i should periodically check for such stuff from the libgit2 crew. 799e22ea0c3f20 * git_threads_init()

[PATCH] main.cpp: fix broken build for libgit2 0.21

2014-12-06 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com 799e22ea0c3f20 in libgit2 renamed a function, which breaks our build. To fix that we check the current version and if the USE_LIBGIT21_API definition was used. Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- re-sending to the ML --- main.cpp

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

2014-12-07 Thread Lubomir I. Ivanov
On 7 December 2014 at 04:39, Thiago Macieira thi...@macieira.org wrote: On Sunday 07 December 2014 02:15:33 Lubomir I. Ivanov wrote: On 7 December 2014 at 00:42, Thiago Macieira thi...@macieira.org wrote: On Saturday 06 December 2014 15:49:57 Lubomir I. Ivanov wrote: +#if !LIBGIT2_VER_MAJOR

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

2014-12-07 Thread Lubomir I. Ivanov
On 7 December 2014 at 14:37, Lubomir I. Ivanov neolit...@gmail.com wrote: On 7 December 2014 at 04:39, Thiago Macieira thi...@macieira.org wrote: On Sunday 07 December 2014 02:15:33 Lubomir I. Ivanov wrote: On 7 December 2014 at 00:42, Thiago Macieira thi...@macieira.org wrote: On Saturday 06

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

2014-12-07 Thread Lubomir I. Ivanov
On 7 December 2014 at 20:05, Thiago Macieira thi...@macieira.org wrote: On Sunday 07 December 2014 19:09:03 Lubomir I. Ivanov wrote: also the version bump for 0.21 is not at the tag for 0.21, but before it. Ask them to bump the master version to 0.22 already. In fact, you can probably

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

2014-12-07 Thread Lubomir I. Ivanov
On 7 December 2014 at 20:18, Gaetan Bisson bis...@archlinux.org wrote: [2014-12-06 15:48:03 +0200] Lubomir I. Ivanov: +#if !LIBGIT2_VER_MAJOR LIBGIT2_VER_MINOR = 20 !defined(USE_LIBGIT21_API) This breaks building against libgit2 for me: main.cpp: In function 'int main(int, char

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

2014-12-07 Thread Lubomir I. Ivanov
On 7 December 2014 at 20:26, Lubomir I. Ivanov neolit...@gmail.com wrote: On 7 December 2014 at 20:24, Gaetan Bisson bis...@archlinux.org wrote: [2014-12-07 08:18:48 -1000] Gaetan Bisson: and USE_LIBGIT21_API is nowhere defined... Ah, well, maybe in subsurface-configure.pri; not sure why

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

2014-12-07 Thread Lubomir I. Ivanov
On 7 December 2014 at 21:08, Joakim Bygdell j.bygd...@gmail.com wrote: Both your patches breaks building on Mac. llibgit2 version.h #define LIBGIT2_VERSION 0.21.2 #define LIBGIT2_VER_MAJOR 0 #define LIBGIT2_VER_MINOR 21 #define LIBGIT2_VER_REVISION 2 and this one (attached)? lubomir --

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

2014-12-07 Thread Lubomir I. Ivanov
On 7 December 2014 at 21:34, Gaetan Bisson bis...@archlinux.org wrote: [2014-12-07 20:32:14 +0200] Lubomir I. Ivanov: so if 'git_libgit2_init' isn't there and this is the case for version.h: #define LIBGIT2_VER_MAJOR 0 #define LIBGIT2_VER_MINOR 21 there is no solution

Re: Any qmake experts out there?

2015-01-30 Thread Lubomir I. Ivanov
On 30 January 2015 at 03:07, Lubomir I. Ivanov neolit...@gmail.com wrote: here is my progress in a single patch if someone is interested. i'm CCing Thiago, because maybe he can help with a qmake issue. basically i have the same setup that this patch applies in a test project: - the version_h

ssrf-version.h and rebuilding

2015-02-06 Thread Lubomir I. Ivanov
hello, in terms of our current scheme for updating ssrf-version.h, with each git HEAD change one potential small issue is present where the macros from the file itself are used on compile time by a number of files. this forces recompilation of said files into object code even if they effectively

Re: ssrf-version.h and rebuilding

2015-02-07 Thread Lubomir I. Ivanov
On 7 February 2015 at 20:05, Dirk Hohndel d...@hohndel.org wrote: On Sat, Feb 07, 2015 at 06:26:38PM +0100, Anton Lundin wrote: On 06 February, 2015 - Lubomir I. Ivanov wrote: in terms of our current scheme for updating ssrf-version.h, with each git HEAD change one potential small issue

Re: F-Secure blocking Subsurface

2015-02-08 Thread Lubomir I. Ivanov
On 8 February 2015 at 17:55, Krzysztof Arentowicz karent@gmail.com wrote: I got a report from a user that on his machine Subsurface was blocked by F-Secure's Deep Guard heurestic. Policy settings prevented him from disabling this functionality, so he was unable to run Subsurface. I

Re: Patches concerning the speed of mouse-movement over the profile.

2015-01-14 Thread Lubomir I. Ivanov
after staring for a while at the callgrind log, i realized it did similar to what i got from a windows tool. my opinion is that both tools somehow don't register well the amount of ToolTipItem calls we get and the actual CPU usage they do. so i did some more manual investigation... On 14 January

Re: Patches concerning the speed of mouse-movement over the profile.

2015-01-15 Thread Lubomir I. Ivanov
On 15 January 2015 at 02:56, Tomaz Canabrava tcanabr...@kde.org wrote: Lubomir, I'v removed almost every allocation that I could find. can you try this 8 patches and tell me if anything worked to reduce the cpu usage? We can still do some stuff to not remove the animations ( yup, I like

ui.globePane is missing?

2015-02-11 Thread Lubomir I. Ivanov
building with NO_MARBLE qt-ui/mainwindow.cpp: In constructor 'MainWindow::MainWindow()': qt-ui/mainwindow.cpp:129:5: error: 'class Ui::MainWindow' has no member named 'g lobePane' ui.globePane-hide(); ^ qt-ui/mainwindow.cpp: In member function 'void MainWindow::refreshDisplay(bool)' :

Re: ui.globePane is missing?

2015-02-11 Thread Lubomir I. Ivanov
On 12 February 2015 at 01:01, Lubomir I. Ivanov neolit...@gmail.com wrote: building with NO_MARBLE seems that master was broken for NO_MARBLE. this works for me (patch attached). lubomir -- 0001-mainwindow.cpp-don-t-use-ui.globePane.patch Description: Binary data

Re: [PATCH] Increase the limits for recursion and variables on XSLT parsing

2015-02-11 Thread Lubomir I. Ivanov
On 8 February 2015 at 22:37, Miika Turkia miika.tur...@gmail.com wrote: + xsltMaxVars = 15; the horrors... *rant mode engaged* this global variable (which first of all is a horrible thing API wise and no self respecting library developer should ever use global symbols like that for

[PATCH] INSTALL: remove the native win32 build notes

2015-02-11 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com Outdated and should not be maintained as there are many levels of complications. The NOT RECOMMENDED note should suffice. Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- i have no plans to maintain these, as even things like sh (from msys

Re: problems compiling subsurface 4.4 on fedora 18

2015-02-17 Thread Lubomir I. Ivanov
On 17 February 2015 at 16:01, Michele Fabi fabie...@gmail.com wrote: Done, and here the result. /usr/bin/ld: cannot find -lssrfmarblewidget collect2: error: ld returned 1 exit status make: *** [subsurface] Error 1 it says that a our localized version of the marblewidget cannot be found.

Re: problems compiling subsurface 4.4 on fedora 18

2015-02-17 Thread Lubomir I. Ivanov
On 17 February 2015 at 17:14, Dirk Hohndel d...@hohndel.org wrote: linking subsurface .obj/moc_globe.o:(.data.rel.ro._ZTV8GlobeGPS[_ZTV8GlobeGPS]+0x188): undefined reference to `QWidget::styleChange(QStyle)' .obj/moc_globe.o:(.data.rel.ro._ZTV8GlobeGPS[_ZTV8GlobeGPS]+0x190): undefined

Re: problems compiling subsurface 4.4 on fedora 18

2015-02-17 Thread Lubomir I. Ivanov
On 17 February 2015 at 15:42, Michele Fabi fabie...@gmail.com wrote: DivelogsDeWebServices::prepare_dives_for_divelogs(const QString, bool)’: qt-ui/subsurfacewebservices.cpp:129:85: error: invalid use of incomplete type ‘class QDebug’ try applying this patch as well (attached): git am

Re: problems compiling subsurface 4.4 on fedora 18

2015-02-17 Thread Lubomir I. Ivanov
On 17 February 2015 at 16:38, Michele Fabi fabie...@gmail.com wrote: qt-ui/simplewidgets.cpp:577:25: error: ‘class QLineEdit’ has no member named ‘setClearButtonEnabled’ make: *** [.obj/simplewidgets.o] Error 1 [michele@localhost subsurface]$ you need to apply the two patches i've sent again

Re: problems compiling subsurface 4.4 on fedora 18

2015-02-17 Thread Lubomir I. Ivanov
On 17 February 2015 at 03:27, Michele Fabi fabie...@gmail.com wrote: This is the laptop I use for work (and all the rest :) and I procrastinated the upgrade for lack of time and a bit of laziness. F18 is ok for all I need. (well, it was...) Another reason for using git version is that my dive

Re: FIY: libzip and UTF-8 on Win32

2015-02-19 Thread Lubomir I. Ivanov
On 19 February 2015 at 08:40, Dirk Hohndel d...@hohndel.org wrote: On Thu, Feb 19, 2015 at 01:03:12AM +0200, Lubomir I. Ivanov wrote: nothing bad should happen to my knowledge as they seem to have only changed their backend. hopefully it doesn't break anything... Hmmm. from what i just

Re: [libgit2] Compile issue on debian-unstable

2015-02-19 Thread Lubomir I. Ivanov
On 19 February 2015 at 07:02, Miika Turkia miika.tur...@gmail.com wrote: On Ubuntu Utopic (14.10) I also have the problem with only 1 parameter for git_remote _fetch #define LIBGIT2_VERSION 0.20.0 I use the attached patch on my tree, but never sent it out ideally we can have

Re: problems compiling subsurface 4.4 on fedora 18

2015-02-16 Thread Lubomir I. Ivanov
On 17 February 2015 at 02:58, Michele Fabi fabie...@gmail.com wrote: hello, Qt4 is no longer supported by Subsurface. you should install the Qt5 developer packages and use the appropriate Qt5 qmake command to build the application. lubomir -- Thank you for your quick reply. To tell the

Re: problems compiling subsurface 4.4 on fedora 18

2015-02-16 Thread Lubomir I. Ivanov
On 17 February 2015 at 02:23, Michele Fabi fabie...@gmail.com wrote: Hello, I'm trying to compile subsurface on my f18 following the instructions reported in the website. I succesfully compiled libdivecomputer and cloned subsurface git repository. qmake-qt4 also work, but make command gives me

Re: FIY: libzip and UTF-8 on Win32

2015-02-19 Thread Lubomir I. Ivanov
On 19 February 2015 at 18:38, Dirk Hohndel d...@hohndel.org wrote: Thanks. The user who reported the issue still can't get things to work. I simply know too little about how all the encoding works on a Windows box. His user name is something like Große Krähe (no, that's of course not his

FIY: libzip and UTF-8 on Win32

2015-02-18 Thread Lubomir I. Ivanov
so, i've been bringing this annoying topic multiple times now, if Subsurface is built with older libzip, when targeting Win32 there was this problem where zip_open() from libzip doesn't work with weird UTF-16 encoded paths...etc... so i've just downloaded the tip from their mercurial:

Re: FIY: libzip and UTF-8 on Win32

2015-02-18 Thread Lubomir I. Ivanov
On 19 February 2015 at 00:53, Dirk Hohndel d...@hohndel.org wrote: On Thu, Feb 19, 2015 at 12:46:34AM +0200, Lubomir I. Ivanov wrote: so, i've been bringing this annoying topic multiple times now, if Subsurface is built with older libzip, when targeting Win32 there was this problem where

Re: [libgit2] Compile issue on debian-unstable

2015-02-18 Thread Lubomir I. Ivanov
On 19 February 2015 at 00:50, Salvador Cuñat salvador.cu...@gmail.com wrote: Good night. While compiling last git-master (2e6fcfc) I have had this problem: compiling git-access.c git-access.c: In function ‘update_local_repo’: git-access.c:23:65: error: too many arguments to function

[PATCH] simplewidgets.cpp: QLineEdit::setClearButtonEnabled() is from Qt5.2

2015-02-17 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com This could cause problems if the user tries to compile with Qt versions between 5.0 and 5.2. Reported-by: Michele Fabi fabie...@gmail.com Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- qt-ui/simplewidgets.cpp | 8 1 file changed, 4

Re: String improvements

2015-01-27 Thread Lubomir I. Ivanov
On 27 January 2015 at 16:41, Davide DB dbdav...@gmail.com wrote: On Tue, Jan 27, 2015 at 3:31 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: some duplicates can't be avoided. because Sensor1 could be an ID, while Sensor 1 is what the user sees on the UI. I think these are strings

[PATCH 1/3] divelogimportdialog.cpp: more capitalization of acronyms

2015-01-27 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- qt-ui/divelogimportdialog.cpp | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/qt-ui/divelogimportdialog.cpp b/qt-ui/divelogimportdialog.cpp index

[PATCH 2/3] divelogimportdialog.cpp: remove extra line at EOF

2015-01-27 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- qt-ui/divelogimportdialog.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/qt-ui/divelogimportdialog.cpp b/qt-ui/divelogimportdialog.cpp index df69dc1..5cda903 100644 --- a/qt-ui

[PATCH 3/3] diveplotdatamodel.cpp: use space before sensor index

2015-01-27 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com the manual uses Sensor 1:, not sure if it breaks anything. Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- qt-ui/profile/diveplotdatamodel.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qt-ui/profile

Re: String improvements

2015-01-27 Thread Lubomir I. Ivanov
On 27 January 2015 at 10:48, Davide DB dbdav...@gmail.com wrote: Sensor1 Sensor2 Sensor3 .../qt-ui/profile/diveplotdatamodel.cpp:139 Shouln't be Sensor 1 Sensor 2 Sensor 3? Sorry to be nitpick but this morning I realized I'm translating over and over the same strings. Moreover

Re: Any qmake experts out there?

2015-01-29 Thread Lubomir I. Ivanov
On 29 January 2015 at 15:38, Thiago Macieira thi...@macieira.org wrote: On Thursday 29 January 2015 15:30:43 Lubomir I. Ivanov wrote: this is what i would do: - all: main.exe .PHONY: persist version.h: persist cat $@ 2 /dev/null || git rev-parse HEAD $@ git rev

Re: Any qmake experts out there?

2015-01-29 Thread Lubomir I. Ivanov
On 29 January 2015 at 04:59, Thiago Macieira thi...@macieira.org wrote: On Wednesday 28 January 2015 11:04:21 Linus Torvalds wrote: The proper way to get the git version is to just do # get raw SHA1 git rev-parse HEAD # get description of it git describe --tags

Re: Any qmake experts out there?

2015-01-29 Thread Lubomir I. Ivanov
On 29 January 2015 at 15:30, Lubomir I. Ivanov neolit...@gmail.com wrote: On 29 January 2015 at 04:59, Thiago Macieira thi...@macieira.org wrote: On Wednesday 28 January 2015 11:04:21 Linus Torvalds wrote: The proper way to get the git version is to just do # get raw SHA1 git rev

Re: Missing translations

2015-01-31 Thread Lubomir I. Ivanov
On 31 January 2015 at 16:03, Robert Helling hell...@lmu.de wrote: Hi, On 31 Jan 2015, at 12:36, Eduardo Ramalho eduardo.rama...@gmail.com wrote: - Bottom window message in red: No filename to save into I think we have 100% translations done on transifex for PT language. uhoh, this opened

Re: [PATCH] qmake: use a dedicated build script to generate ssrf-version.h

2015-01-31 Thread Lubomir I. Ivanov
On 31 January 2015 at 00:45, Cristian Ionescu-Idbohrn cristian.ionescu-idbo...@axis.com wrote: On Fri, 30 Jan 2015, Lubomir I. Ivanov wrote: I'll just nitpick on this one: diff --git a/scripts/write-version b/scripts/write-version new file mode 100644 index 000..42505ae --- /dev/null

Re: [PATCH] qmake: use a dedicated build script to generate ssrf-version.h

2015-01-31 Thread Lubomir I. Ivanov
On 31 January 2015 at 17:56, Dirk Hohndel d...@hohndel.org wrote: On January 31, 2015 5:54:36 AM Lubomir I. Ivanov neolit...@gmail.com wrote: On 31 January 2015 at 15:29, Lubomir I. Ivanov neolit...@gmail.com wrote: On 31 January 2015 at 00:45, Cristian Ionescu-Idbohrn cristian.ionescu

Re: Translation window and some ideas

2015-01-24 Thread Lubomir I. Ivanov
On 25 January 2015 at 02:37, Lubomir I. Ivanov neolit...@gmail.com wrote: perhaps i check occasionally for things like pO2 using the subscript 2, and request a re-send from the developer. also, will see if i can sort a patch tomorrow with some text fixes. :-) and that's a typo right

Re: Translation window and some ideas

2015-01-24 Thread Lubomir I. Ivanov
. if there is a concept to be proven e.g. RPATH issues etc. On Sat, Jan 24, 2015 at 05:50:29PM +0200, Lubomir I. Ivanov wrote: ideally there should be only one string update notification at trasifex per beta cycle. the dreams could be real... ;-) I don't think that's the right answer, because it would mean

Re: [PATCH 6/8] Typos: fix capitalization after semicolumn in preferences.ui

2015-01-25 Thread Lubomir I. Ivanov
On 25 January 2015 at 17:15, Dirk Hohndel d...@hohndel.org wrote: Technically this is a colon (':'), not a semicolon (';'). But I wonder if we really want to continue lower case after a colon... that's my bad, because i was thinking of semicolons at the time. i think the rule for both colon

Re: [PATCH 6/8] Typos: fix capitalization after semicolumn in preferences.ui

2015-01-25 Thread Lubomir I. Ivanov
On 25 January 2015 at 17:35, Dirk Hohndel d...@hohndel.org wrote: On Sun, Jan 25, 2015 at 05:30:56PM +0200, Lubomir I. Ivanov wrote: On 25 January 2015 at 17:15, Dirk Hohndel d...@hohndel.org wrote: Technically this is a colon (':'), not a semicolon (';'). But I wonder if we really want

[PATCH 8/8] Typos: capitalization in uemis-downloader.c

2015-01-25 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- uemis-downloader.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/uemis-downloader.c b/uemis-downloader.c index b4abfeb..7ce25cd 100644 --- a/uemis-downloader.c +++ b

[PATCH 5/8] Typos: usermanual.cpp capitalization

2015-01-25 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- qt-ui/usermanual.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/usermanual.cpp b/qt-ui/usermanual.cpp index ab64751..4b50919 100644 --- a/qt-ui/usermanual.cpp +++ b

[PATCH 7/8] Typos: mid-sentence capitalization in usersurvey.cpp

2015-01-25 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com some common nouns, even if the S in OS is capitalized but that's when it's in acronym form. Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- qt-ui/usersurvey.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qt-ui

Re: Translation window and some ideas

2015-01-25 Thread Lubomir I. Ivanov
On 25 January 2015 at 09:33, Robert C. Helling rob...@euve10195.vserver.de wrote: Hi, Am 25.01.2015 um 01:37 schrieb Lubomir I. Ivanov neolit...@gmail.com: on the other hand the developers should be more strict not to send typos in the first place, so that the typos don't make

[PATCH 6/8] Typos: fix capitalization after semicolumn in preferences.ui

2015-01-25 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- qt-ui/preferences.ui | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qt-ui/preferences.ui b/qt-ui/preferences.ui index 66eda46..2072e4e 100644 --- a/qt-ui/preferences.ui

[PATCH 4/8] Typos: a couple of capitalization fixes in socialnetworks.cpp

2015-01-25 Thread Lubomir I. Ivanov
From: Lubomir I. Ivanov neolit...@gmail.com Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- qt-ui/socialnetworks.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qt-ui/socialnetworks.cpp b/qt-ui/socialnetworks.cpp index c09da10..e76a77d 100644 --- a/qt-ui

  1   2   3   4   5   6   7   8   9   10   >