Re: [systemd-devel] Permanently Ban for Dovecot

2019-03-10 Thread Martin Pitt
Hello Onno, Onno Verbeek [2019-03-10 14:52 +0100]: > I’ve setup my firewalls pretty tight, I just run into a problem with the > firewall for dovecot. > When someone is trying to login, they get blocked after 5 try’s. I would like > to ban the ip permanently, for now the ban seems to be cancelled

Re: [systemd-devel] Antw: Re: Antw: Re: Arbitrary restrictions (e.g. for RuntimeDirectory)

2019-05-13 Thread Martin Pitt
Hello all, Ulrich Windl [2019-05-14 8:35 +0200]: > I knew that. It doesn't answer _why_ /var/run is obsolete. The short reason is that /var can be on a separate partition, so it's not available during early mount or late shutdown, or in a rescue environment with only the root fs mounted. Some ad

Re: [systemd-devel] Shutdown a specific service in systemd shutdown

2016-05-19 Thread Martin Pitt
ars, and there's no way all the services can simultaneously be "last" :-) You should put sufficient After= properties into your service, so that it gets started after and stopped before the ones you specify. See man systemd.unit for details. Martin -- Martin Pitt

Re: [systemd-devel] restart vs. stop/start

2016-05-22 Thread Martin Pitt
behaviour so that it > reloads the profiles while keeping running processes confined. > > The easiest solution would be an ExecRestart= directive in the service > file, but unfortunately this isn't available. But ExecReload= is available, isn't that enough? Martin -- Mart

Re: [systemd-devel] when/where was support for assigning "ethX" names removed?

2016-05-26 Thread Martin Pitt
course hack the kernel to do anything.. This is why we have needed to come up with ways to rename interfaces in userspace. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) _

Re: [systemd-devel] when/where was support for assigning "ethX" names removed?

2016-05-28 Thread Martin Pitt
ew installs, for precisely this reason. Specifically, if you already have an existing /etc/udev/rules.d/70-persistent-net.rules, this will still be present (and trump ifnames). But we also disable it for VM upgrades where the previous persistent-net-generator was blacklisted. Martin -- Mar

Re: [systemd-devel] /usr/lib/systemd/*.wants vs. Wants in unit definition

2016-06-06 Thread Martin Pitt
nal file, but the symlinks are structurally simpler. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] /usr/lib/systemd/*.wants vs. Wants in unit definition

2016-06-06 Thread Martin Pitt
sual WantedBy= in the unit and call systemctl enable on installation (that's what the Debian package does), but there are cases where you don't really want to make the enablement configurable by the admin. Martin -- Martin Pitt| http://www.piware.de Ubunt

Re: [systemd-devel] When System is Degraded

2016-06-06 Thread Martin Pitt
vs > "degraded"? Try adding a .service with "Type=idle" and add it to your default target (usually multi-user.target). This should run the unit after the system is booted (i. e. running or degraded). (Tested here with systemd 230) Martin -- Martin Pitt

Re: [systemd-devel] how to use per-user systemd --user services / how to replace /etc/xdg/autostart/app.desktop?

2016-06-24 Thread Martin Pitt
it/systemd-graphical-session/tree/ [2] https://git.launchpad.net/~pitti/+git/systemd-graphical-session/tree/usr/share/systemd-graphical-session/session-wrapper -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com)

[systemd-devel] Standardizing names for graphical session units

2016-07-04 Thread Martin Pitt
ree that we want to start standardizing session services in systemd. Feedback appreciated! Thanks, Martin [1] https://lists.freedesktop.org/archives/systemd-devel/2016-May/036440.html [2] https://git.launchpad.net/~pitti/+git/systemd-graphical-session/tree/ [3] https://lists.freedesktop.org/ar

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-04 Thread Martin Pitt
on't have a parent like "graphical.slice" any more which you can refer to in units. We certainly don't want to use the root slice (-.slice) as we don't want to kill *all* the user services on graphical logout. Thanks, Martin -- Martin

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-04 Thread Martin Pitt
PLAY, graphical-$TYPE.slice, and now $TYPE-session.target. If this becomes a "first submitter wins" then we might miss improvements like the above for a nicer design. Thanks for your input, this is a nice idea! Let's hear a few more opinions before jumping to the implementation

Re: [systemd-devel] Standardizing names for graphical session units -- version 2

2016-07-06 Thread Martin Pitt
actually start/stop the targets are unaffected by this change; I'll follow up to Simon's reply about that). So again, the only change we should do in systemd is to ship the graphical.target user unit. WDYT? Thanks, Martin -- Martin Pitt| http://www.piware.de Ubun

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Martin Pitt
Martin Pitt [2016-07-06 13:47 +0200]: > I have a gut feeling that this should be expressible with systemd > dependencies -- i. e. "if gnome-session.service stops, then stop > gnome-session.target". Naïvely this would be > "PartOf=gnome-session.target" in gnome-sess

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Martin Pitt
Simon McVittie [2016-07-05 10:27 +0100]: > On 04/07/16 21:01, Martin Pitt wrote: > > A session type like "GNOME" or "KDE" then defines which top-level > > servcies it wants. > > Could this be done by having the .desktop file in /usr/share/xsessions

Re: [systemd-devel] Standardizing names for graphical session units -- version 3, now working!

2016-07-06 Thread Martin Pitt
Andrei Borzenkov [2016-07-06 14:44 +0300]: > On Wed, Jul 6, 2016 at 2:25 PM, Martin Pitt wrote: > >$ cat .config/systemd/user/gnome-session.target > >[Unit] > >Description=User systemd services for GNOME graphical session > >Requires=graphical.target >

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Martin Pitt
here's also StopWhenUnneeded=, which might useful on the targets. Indeed. The version 3 approach now uses that, and this finally works as intended. Thanks for pointing out! Martin -- Martin Pitt| http://www.piware.de Ubuntu De

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Martin Pitt
Martin Pitt [2016-07-06 13:47 +0200]: > Simon McVittie [2016-07-05 10:27 +0100]: > > Could this be done by having the .desktop file in /usr/share/xsessions > > or /usr/share/wayland-sessions start an appropriate systemd user unit > > directly, and wait for it to terminate? &g

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Martin Pitt
Having a unit structure which actually works and is reasonably easy to extend and maintain is AFAICS the main blocker why systemd isn't being used for desktop environments at all yet. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubu

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-06 Thread Martin Pitt
"runtime alias" for units, TTBOMK. There is Alias= in the [Install] section, but this cannot really be used for this purpose -- we don't want to change the /usr/lib/systemd/user/user-graphical.target symlink every time that we start a user session in a DM. Hence my idea of a graphical.t

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-07 Thread Martin Pitt
independent sessions. Thanks everyone for their input! Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-07 Thread Martin Pitt
Martin Pitt [2016-07-07 9:29 +0200]: > I'll go ahead and create a PR with the unit and a manpage, using > graphical-session.target for now. Then the name bikeshedding can be > continued there. https://github.com/systemd/systemd/pull/3678 -- Martin Pitt

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-07 Thread Martin Pitt
or it would need to apply transitively, and to Wants= as well, which sounds quite strange). OTOH adding "PartOf=graphical-session.target" to all graphical session specific user services works fine and works with the existing systemd model and dependencies. Martin -- Martin Pitt

Re: [systemd-devel] Standardizing names for graphical session units

2016-07-07 Thread Martin Pitt
temd instance continues to run after you log out of the graphical session, as long as that user still has some other (non-graphical) session open. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com)

Re: [systemd-devel] How to override generators on debian (v215)?

2016-08-17 Thread Martin Pitt
ystemd/system-generators/ with a different name. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) signature.asc Description: PGP signature ___ systemd-

Re: [systemd-devel] "dev-xxx.device" is trying to start indefinitely long

2016-09-19 Thread Martin Pitt
atic error, such as missing some udev rules, or not re-triggering all udev devices during boot, etc. Martin [1] https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial-pitti-systemd-semaphore/xenial/i386/s/systemd-upstream/20160903_005404@/log.gz [2

Re: [systemd-devel] "dev-xxx.device" is trying to start indefinitely long

2016-09-20 Thread Martin Pitt
Block device units are mostly being used to know when the corresponding mount units get started. Anton Gerasimov [2016-09-20 11:37 +0200]: > Yes, just adding 'KERNEL=="hda" TAGS+="systemd"' to udev rules did the > trick. Thank you! That means you are missing /lib/u

Re: [systemd-devel] getting systemd 232 ready

2016-10-21 Thread Martin Pitt
f those are a regression from 231, so we could easily move them to 233. Should we? Thanks for pushing this! Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-

Re: [systemd-devel] How to make udev not touch my device?

2016-11-04 Thread Martin Pitt
uot;foo"), see udev(7). So indeed the most straightforward way would be to tag or set a property on those devices which you want to handle in libvirtd yourself, and then add something like TAG=="libvirtd", GOTO="skip_selinux_context" [... original rule that changes c

Re: [systemd-devel] Promoting a pull request

2016-11-22 Thread Martin Pitt
e it's just UI obfuscation, but perhaps label setting/removing is limited to project members? Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ syst

Re: [systemd-devel] systemd-timesyncd with read-only root filesystem

2016-12-01 Thread Martin Pitt
. I'm not entirely sure if dangling symlinks should be counted as "enabled", but this should least explain your observation. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) __

Re: [systemd-devel] Stable interface names even when hardware is added or removed, not true

2016-12-02 Thread Martin Pitt
the level the firmware permits this)" qualification seems to adequately address that? Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ sy

Re: [systemd-devel] systemd-timesyncd with read-only root filesystem

2016-12-04 Thread Martin Pitt
k in /etc pointing to /dev/null. This is called "masking" and what "systemctl mask" does, and is sort of a stronger version of "disable" (in the sense that it will also not be started any more through Requires= and friends). Martin -- Martin Pitt

Re: [systemd-devel] systemd-timesyncd with read-only root filesystem

2016-12-09 Thread Martin Pitt
enabled: yes > NTP synchronized: no > RTC in local TZ: no > DST active: n/a I don't see an inconsistency? If timedated is not running then timedatectl can't actualy talk to it and just shows values which it can make up by itself.

Re: [systemd-devel] systemd-timesyncd with read-only root filesystem

2016-12-10 Thread Martin Pitt
ories writable. > > > # systemctl status systemd.timesyncd > > > * systemd.timesyncd.service > > >Loaded: not-found (Reason: No such file or directory) > > >Active: inactive (dead) It's systemd-timesyncd (dash, not dot). Viele Grüße, Martin -- Martin Pitt

Re: [systemd-devel] systemd-networkd in initrd

2016-12-25 Thread Martin Pitt
temd nor D-Bus nor much other bells and whistles aside from busybox and udev) and it works fine. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ syste

Re: [systemd-devel] [PATCH] add LIB_ARCH_TUPLE for tilegx-linux-gnu

2017-02-27 Thread Martin Pitt
Helmut Grohne [2017-02-27 16:51 +0100]: > The following changes since commit 3c3fff44b2c46818bc240e3237925ad927b2831e: > > man: fix typo (#5468) (2017-02-27 13:59:11 +0100) > > are available in the git repository at: > > git://git.subdivi.de/~helmut/systemd.git tilegx > > for you to fetch c

Re: [systemd-devel] Disabling 'Predictable Network Interface Names'

2017-03-07 Thread Martin Pitt
Hello Lucas, Lucas Ventura Carro [2017-03-07 9:25 +0100]: > (1) Creating a symlink > (2) Changing a kernel boot parameter > > But, using option (1) doesn't work, and I'm still having predictable names. Did you rebuild the initrd after that? Without that, it won't work indeed. Martin __

[systemd-devel] ANN: CI now tests meson and rebases

2017-04-27 Thread Martin Pitt
Hello all, quick announcement for things to watch out for in PR integration tests. After Zbigniew's meson build system work landed two days ago [1], I now set up our CI so that the "xenial-s390x" test builds using meson, while i386 and amd64 continue to run the classic autotools build. I initiall

Re: [systemd-devel] Apparmor and ureadhead failed to start

2018-01-11 Thread Martin Pitt
Hello Dorian, Dorian ROSSE [2018-01-10 9:35 +]: > Since I have kernel 4.14.12 I have two errors : > > apparmor failed because It failed to start LSB the status exit code is 123 > and there is a error by program /etc/apparmor.d/usr.lib.snapd-confine.real in > line 11 unable to open /var/lib

Re: [systemd-devel] Graphical session targets as standard

2018-06-30 Thread Martin Pitt
Hello Alberto, Alberto Salvia Novella [2018-06-28 6:33 +0200]: > Currently many Linux Distributions don't activate graphical-session.target > and graphical-session-pre.target during login. > > I liked to know which software should ideally be in charge of that. So I can > inform their developers

Re: [systemd-devel] Graphical session targets as standard

2018-07-03 Thread Martin Pitt
Hello Alberto, Alberto Salvia Novella [2018-07-04 1:56 +0200]: > Requested on: > - gitlab.gnome.org/GNOME/gdm/issues/396 > - github.com/CanonicalLtd/lightdm/issues/29 > - github.com/sddm/sddm/issues/1044 > - bugs.freedesktop.org/show_bug.cgi?id=107107 These are invalid, please see my previous re

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-13 Thread Martin Pitt
rt a while ago: https://bugs.launchpad.net/systemd/+bug/102 This is reproducible in a container with udev running, see the small reproducer in the bug trail. This is on my plate to investigate/fix, I just got interrupted by a couple of security issues, so not this week. Martin --

[systemd-devel] Crash with extra space after Exec prefix

2015-05-13 Thread Martin Pitt
d be? In the sense of "be liberal what you accept" I think the extra space(s) should just be ignored; or should that count as an error and the unit get rejected? Thanks, Martin [1] https://launchpad.net/bugs/1454173 -- Martin Pitt| http://www.piware.de Ubun

Re: [systemd-devel] Crash with extra space after Exec prefix

2015-05-13 Thread Martin Pitt
Lennart Poettering [2015-05-13 17:55 +0200]: > On Wed, 13.05.15 17:01, Martin Pitt (martin.p...@ubuntu.com) wrote: > > So, obviously we need to fix the crash; but I was wondering what the > > desired behaviour should be? In the sense of "be liberal what you > > accept&

[systemd-devel] [PATCH] core: Fix assertion with empty Exec*= paths

2015-05-14 Thread Martin Pitt
Martin Pitt [2015-05-13 17:01 +0200]: > I got a report [1] that you can trivially crash systemd (pid1) at boot > by creating a unit with an Exec= line with a modifier and a space: > > $ cat /tmp/foo.service > [Service] > ExecStart=- /bin/echo hello > > $ systemd-analyze

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-14 Thread Martin Pitt
tus changes back to "dead", causing the unmount attempt. IMHO this approach isn't conceptually correct either -- in such containers, if don't have the corresponding device nodes at all, we shouldn't try to react to hotplug events and clean up mounts. I. e. the &

Re: [systemd-devel] Reduce unit-loading time

2015-05-17 Thread Martin Pitt
to use some readahead solution. We found that it makes a significant improvement on ARM boards with slow MMC cards. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-17 Thread Martin Pitt
explicit checks like "is /sys writable" appear to be more like a brittle hack than a robust solution; this doesn't tell you anything about what your /dev looks like or whether or not udev is running, etc. I also have a gut feeling that Dimitri's use case with a plan9 file syste

Re: [systemd-devel] Automatic user ACL management

2015-05-17 Thread Martin Pitt
this issue Personally I wouldn't consider this a "fix"; it's a very wrong thing to do for environments with multiple users. But indeed using static group memberships will achieve this "first user to grab a device will keep owning it" behaviour. Martin -- Martin Pitt

[systemd-devel] [PATCH v2] dev-root.device is not active, results in an umount spree

2015-05-17 Thread Martin Pitt
Hello again, Martin Pitt [2015-05-17 13:02 +0200]: > - Alternative: Fix device_found_node() to create a .device with the > correct ("tentative") state if the device doesn't exist in /dev/ > or udev (yet). Then manager_load_unit() would not create a "dead

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-17 Thread Martin Pitt
questionable, it's just one way to exhibit the bugs, as Dimitri's plan9 example shows there are other cases where file systems aren't on a "real" /dev/ device. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www

[systemd-devel] [PATCH] hostname: Allow comments in /etc/hostname

2015-05-18 Thread Martin Pitt
ted to 64 bytes (HOST_NAME_MAX) this could be written more efficiently. Thanks, Martin [1] https://launchpad.net/bugs/1053048 -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) From 0d5195a617df34abcd200a49c5560f46337e5e7

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-18 Thread Martin Pitt
t with the first patch (the one you replied to). The v2 patches do create the .device right from the start in state "tentative" (that was the intention judging by the comments, it just doesn't actually behave that way) and thus .mounts do get bound to the .devices. Martin -- Mart

[systemd-devel] [PATCH v2] hostname: Allow comments in /etc/hostname

2015-05-18 Thread Martin Pitt
Hey Thomas, Thomas H.P. Andersen [2015-05-18 11:49 +0200]: > On Mon, May 18, 2015 at 11:33 AM, Martin Pitt wrote: > > This currently uses read_full_file() and strv_split_newlines() which > > is relatively expensive (although, in most cases there will only be > > one line)

Re: [systemd-devel] Reduce unit-loading time

2015-05-18 Thread Martin Pitt
ere, just where/when we actually need it. Martin [1] https://launchpad.net/ubuntu/+source/ureadahead -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-18 Thread Martin Pitt
ake deps dynamic, based on state, and that's something I > really don't like. No, it just fixes the creation of the .device units to happen at the right and intended time (when we actually have a proper state), and thus have the intended state "tentative" instead of "dea

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-18 Thread Martin Pitt
produce the overzealous unmounting yet, but it shows the wrong state) Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing list system

Re: [systemd-devel] [correct PATCH v2] dev-root.device is not active, results in an umount spree

2015-05-18 Thread Martin Pitt
Martin Pitt [2015-05-17 15:54 +0200]: > This fixes the original "systemd immediately unmounts my mounts" bug, > but not for very long: If you remount or unmount just one mount on a > tentative device, mountinfo changes, and device_found_node() now calls > device_update_foun

Re: [systemd-devel] tentative state and unmount on mapper

2015-05-18 Thread Martin Pitt
rg/archives/systemd-devel/attachments/20150518/09d36e6f/attachment-0001.patch This is caused by the device_update_found_one() state transition from "tentative" to "dead" which we must never do as there is no way to know when a tentative device is actually dead. We must

[systemd-devel] [PATCH v3] hostname: Allow comments in /etc/hostname

2015-05-18 Thread Martin Pitt
entirely in hostname-setup.c. Done. However, I called the function read_hostname_config() and give it a path argument. This is mostly so that we can write tests for it, but maybe one of these days we actually want to use it for other purposes (reading hostnames from contain

[systemd-devel] [PATCH v3] dev-root.device is not active, results in an umount spree

2015-05-18 Thread Martin Pitt
smaller, mostly because lots of it is an indentation change :/ Re-tested on a normal system, nspawn, LXC, and with ejecting a mounted CD. > > Subject: [PATCH 2/3] device: never transition from "tentative" to "dead" > Not following on this patch Will reply on your ot

Re: [systemd-devel] [correct PATCH v2] dev-root.device is not active, results in an umount spree

2015-05-18 Thread Martin Pitt
Lennart Poettering [2015-05-18 23:04 +0200]: > On Mon, 18.05.15 16:08, Martin Pitt (martin.p...@ubuntu.com) wrote: > > > Martin Pitt [2015-05-17 15:54 +0200]: > > > This fixes the original "systemd immediately unmounts my mounts" bug, > > > but not for v

[systemd-devel] [PATCH v3] device: Fix overzealous unmounting of tentative device mounts

2015-05-19 Thread Martin Pitt
Hello all, I have a better fix now. Martin Pitt [2015-05-19 8:59 +0200]: > - Boot, dev-foo.device becomes DEVICE_FOUND_MOUNT/tentative > > - Do some more mounts from /dev/foo, e. g. > >mkdir /tmp/etc /tmp/boot >mount -o bind /etc /tmp/etc >mount -o

Re: [systemd-devel] tentative state and unmount on mapper

2015-05-19 Thread Martin Pitt
ld give it a try. > - Seems like poky is enabling udev rules for DM. Maybe we should add > required switches on README file to make DM work. So far I found > CONFIG_DM_UEVENT on kernel and some switches on lvm, > --enable-udev_sync, --enable-udev_rules, --with-udev-prefix=. That's

Re: [systemd-devel] tentative state and unmount on mapper

2015-05-19 Thread Martin Pitt
ctual use case we need to optimize for. So please consider my previous reply to replace "container" with "situations with a mounted device not being in /dev". Sorry for the confusion! Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubunt

Re: [systemd-devel] [PATCH v3] device: Fix overzealous unmounting of tentative device mounts

2015-05-19 Thread Martin Pitt
is that this is caused by calling mount_load_proc_self_mountinfo() in mount_dispatch_io() (src/core/mount.c:1682) *before* it goes through that new SET_FOREACH() loop. That call will already see the removed mount and call device_found_node() with the removal. I'll debug this more closely ASAP, j

Re: [systemd-devel] [PATCH v3] device: Fix overzealous unmounting of tentative device mounts

2015-05-19 Thread Martin Pitt
Martin Pitt [2015-05-19 15:17 +0200]: > My first hunch is that this is caused by calling > mount_load_proc_self_mountinfo() in mount_dispatch_io() > (src/core/mount.c:1682) *before* it goes through that new > SET_FOREACH() loop. That call will already see the removed moun

Re: [systemd-devel] [PATCH v3] device: Fix overzealous unmounting of tentative device mounts

2015-05-19 Thread Martin Pitt
committed a change to implement that, can you check if this > fixes the issue for you? It does, and it looks much more straightforward now. Many thanks for your patience, this was a hairy thing to untangle.. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer

Re: [systemd-devel] Reduce unit-loading time

2015-05-19 Thread Martin Pitt
nd hhd: Right. These were created by some rather wide-scale measurements back then. Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___ systemd-devel mailing lis

Re: [systemd-devel] [ANNOUNCE] Separating gudev from systemd

2015-05-19 Thread Martin Pitt
and all.. (Yes, there are "epochs" in Debian, and I'm sure RPM has these too, but they might not be available everywhere and are generally frowned upon) Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debi

[systemd-devel] [PATCH] audit: Fix journal failing on unsupported audit in containers [was: journal: don't complain about audit socket errors in a container.]

2015-05-20 Thread Martin Pitt
ConditionSecurity=audit check more thorough and actually working in containers. With that I can leave audit enabled on the host, containers will boot fine (including journalling) without audit support, and as soon as the kernel gets fixed it'll automagically start working in contain

Re: [systemd-devel] [PATCH] audit: Fix journal failing on unsupported audit in containers [was: journal: don't complain about audit socket errors in a container.]

2015-05-20 Thread Martin Pitt
Lennart Poettering [2015-05-20 14:57 +0200]: > On Wed, 20.05.15 13:53, Martin Pitt (martin.p...@ubuntu.com) wrote: > > > -cached_use = true; > > +/* bind() fails in namespaces (containers), so

Re: [systemd-devel] [PATCH] audit: Fix journal failing on unsupported audit in containers [was: journal: don't complain about audit socket errors in a container.]

2015-05-20 Thread Martin Pitt
(This needs to be fixed in unprivileged LXC containers, but that's not a systemd problem; I'll talk to LXC upstream about that). With these two fixes, should we now remove the scary warning in README? AFAICS there is no need to turn auditing off on the host any more. Thanks! Martin -- Marti

Re: [systemd-devel] fsckd needs to go

2015-05-22 Thread Martin Pitt
l testing myself, since I > don't use file systems that require fsck anymore myself. Neither do I, but there's always test/mocks/fsck which works very nicely. Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian D

[systemd-devel] 220 tarball erroneously ships keyboard-keys-from-name.gperf

2015-05-22 Thread Martin Pitt
ame.gperf \ - src/udev/keyboard-keys.txt \ - src/udev/net/link-config-gperf.c but apparently this wasn't put back someplace else? Thanks, Martin [1] http://lists.freedesktop.org/archives/systemd-devel/2015-May/032148.html -- Martin Pitt

[systemd-devel] 220 regression: path_is_mount_point() for non-directories

2015-05-25 Thread Martin Pitt
nd don't specify one (or maybe we even can specify it easily, I didn't check) in rm_rf_children() as file bind mounts don't seem relevant there. This would be simpler, but it would technically be an API break (unless we want to add fd_is_mount_point_with_parent). Does anyo

Re: [systemd-devel] 220 regression: path_is_mount_point() for non-directories

2015-05-25 Thread Martin Pitt
Martin Pitt [2015-05-25 21:06 +0200]: > Alternatively we could pass a "parent_path" to fd_is_mount_point(), > compute that in path_is_mountpoint(), and don't specify one (or maybe > we even can specify it easily, I didn't check) in rm_rf_children() as > file bind

Re: [systemd-devel] 220 tarball erroneously ships keyboard-keys-from-name.gperf

2015-05-26 Thread Martin Pitt
Lennart Poettering [2015-05-26 16:06 +0200]: > I think this has been fixed now with Tom's commit > ee3c31bf69746c5afc764c3d0337feec1bf25f0e contributed my Marc-Antoine. Confirmed this morning. Sorry, I should have followed up to the ML immediately. Thanks Tom! Martin --

[systemd-devel] pre-release warnings? [was: 220 tarball erroneously ships keyboard-keys-from-name.gperf]

2015-05-26 Thread Martin Pitt
-release tarballs means that not much will change any more until the real release, so the second time testing will be faster). Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) _

Re: [systemd-devel] pre-release warnings? [was: 220 tarball erroneously ships keyboard-keys-from-name.gperf]

2015-05-26 Thread Martin Pitt
ith Debianisms, and then there's a lot for having a non-merged /usr (which Debian didn't do yet). Aside from two or three which keep breaking most of them just tag along, but there's always enough noise to break completely automatically building packages from git master. Anyway,

[systemd-devel] 220 udev boot regression: timeout, giving up waiting for workers to finish

2015-05-26 Thread Martin Pitt
of commit 185abfc3 still has that problem, so it wasn't fixed by one of the recent udev commits. Does anyone else see this too? Any idea what causes this? Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer

[systemd-devel] non-merged /usr changes [was: pre-release warnings?]

2015-05-26 Thread Martin Pitt
e an improvement! Martin [1] http://cgit.freedesktop.org/systemd/systemd/commit/?id=46a2911bf [2] http://lists.freedesktop.org/archives/systemd-devel/2015-February/028544.html [3] http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/tree/debian/patches?h=experimental-220 -- Martin Pitt

Re: [systemd-devel] 220 tarball erroneously ships keyboard-keys-from-name.gperf

2015-05-26 Thread Martin Pitt
low-benefit work. I'd much rather get some distro-side testing before we do an upstream release (see my other reply). Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

Re: [systemd-devel] non-merged /usr changes [was: pre-release warnings?]

2015-05-26 Thread Martin Pitt
surprised about their number. It's still better to keep upstream clean of hacks. > > http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/tree/debian/patches/Fix-paths-in-man-pages.patch?h=experimental-220 > > Not enthusiastic about the idea. But the XML magic is

[systemd-devel] [PATCH] path-util: Fix path_is_mount_point for files

2015-05-27 Thread Martin Pitt
Martin Pitt [2015-05-25 21:06 +0200]: > in 220, path_is_mount_point() now always fails with "-20 ENOTDIR" when > calling it on files. This is problematic as it's perfectly valid to > have bind-mounted files; in fact, systemd's machine_id_setup() itself > creates a /

Re: [systemd-devel] 220 tarball erroneously ships keyboard-keys-from-name.gperf

2015-05-27 Thread Martin Pitt
ny commit which isn't an important bug fix, especially not large refactorings or new features. Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) ___

Re: [systemd-devel] 220 tarball erroneously ships keyboard-keys-from-name.gperf

2015-05-27 Thread Martin Pitt
large patches (like the chkconfig → update-rc. ones, or the man page paths), doing CI more often on my "distro" side will also become a much less manual process. Thanks for having this post-mortem discussion, this is useful! Martin -- Martin Pitt| http://www.p

[systemd-devel] abstracting chkconfig vs. update-rc.d [was: non-merged /usr changes]

2015-05-27 Thread Martin Pitt
mple.com-coffeed /usr/lib/lsb/remove_initd /etc/init.d/example.com-coffeed So we could make systemctl just call this if it's available, and otherwise do nothing for init.d scripts. I'll cook a patch for this. Martin -- Martin Pitt| http://www.piware.de Ubuntu

Re: [systemd-devel] 220 tarball erroneously ships keyboard-keys-from-name.gperf

2015-05-27 Thread Martin Pitt
'd really have a Jenkins instance for that, like David > Strauss' one, but testing the .deb packages Ubuntu (or Debian) > builds. *nod* Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org

Re: [systemd-devel] [PATCH 1/1] Ensure that /run/systemd/network exists

2015-05-27 Thread Martin Pitt
b/tmpfiles.d/systemd.conf instead, together with the related d /run/systemd/netif 0755 systemd-network systemd-network - d /run/systemd/netif/links 0755 systemd-network systemd-network - d /run/systemd/netif/leases 0755 systemd-network systemd-network - ? Thanks, Martin -- Martin Pitt

[systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Martin Pitt
th not having the LSB wrappers. If there is both a script and a unit for the same name we need a second patch, will post that separately as 2/2 as it's unrelated to this change. Thanks for considering, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (

Re: [systemd-devel] [PATCH 1/2] corrected Subject: systemctl: add support for LSB init.d script enabling/disabling

2015-05-27 Thread Martin Pitt
Meh, copy&paste fail, Subject: should have been systemctl: add support for LSB init.d script enabling/disabling -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian

[systemd-devel] [PATCH 2/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Martin Pitt
issue for e. g. Debian or third-party packages which want to support multiple init systems. This patch calls both chkconfig (or install_initd with the previous patch) and handles the native unit in that case. Thanks for considering, Martin -- Martin Pitt| http

Re: [systemd-devel] abstracting chkconfig vs. update-rc.d [was: non-merged /usr changes]

2015-05-27 Thread Martin Pitt
t supported with sysvinit" error with --disable-chkconfig. > Also, I'd like to keep Lukas Nykryn in the loop on this, our > initscripts maintainer. Did you mean to CC: him? Thanks, Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubunt

Re: [systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Martin Pitt
t have a specification for is-enabled, so we have to make up one (/usr/lib/lsb/initd_enabled), but for enable/disable it seems quite fine? But if you still say you want /usr/lib/systemd/systemd-sysv-install I'll implement it that way. I care more about getting some abstraction than g

Re: [systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Martin Pitt
What should is-enabled foo bar baz mean? "any", "all", "first", "error"? Where do we need this? systemctl calls stuff one by one in a loop anyway? Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debi

Re: [systemd-devel] abstracting chkconfig vs. update-rc.d [was: non-merged /usr changes]

2015-05-27 Thread Martin Pitt
t CLI. But anyway, this is moot. We won't call those from systemd after all, but instead introduce /usr/lib/systemd/systemd-sysv-install. Thanks! Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer

[systemd-devel] [PATCH v2 1/2] systemctl: drop hardcoded chkconfig invocation

2015-05-27 Thread Martin Pitt
change. I tested this with both --enable-chkconfig and --disable-chkconfig, and with "make dist" (*cough*) This doesn't have a manpage yet (as it's not an user-callable program); where should this be documented? Just adding to README? Thanks, Martin -- Martin Pitt

  1   2   3   4   5   >