On 04/27/2016 12:29 AM, Felipe Sateler wrote:
> On Tue, 26 Apr 2016 17:28:34 +0200, Daniel Mack wrote:
>
>> Hi Michael,
>>
>> On 04/15/2016 11:00 PM, Daniel Mack wrote:
>>> On 04/15/2016 10:47 PM, Michael Biebl wrote:
>>
>>> Including the built res
Hi Michael,
On 04/15/2016 11:00 PM, Daniel Mack wrote:
> On 04/15/2016 10:47 PM, Michael Biebl wrote:
> Including the built results of systemd-initctl into your .deb packet is
> not a solution? Making that an extra package causes too much trouble, I
> totally agree.
Did you further
On 04/15/2016 10:47 PM, Michael Biebl wrote:
> 2016-04-15 19:33 GMT+02:00 Daniel Mack :
>> On 04/15/2016 07:03 PM, Mike Gilbert wrote:
>>> On Fri, Apr 15, 2016 at 11:43 AM, Daniel Mack wrote:
>>>> On 04/15/2016 03:55 PM, Mike Gilbert wrote:
>>
>>>>
On 04/15/2016 07:03 PM, Mike Gilbert wrote:
> On Fri, Apr 15, 2016 at 11:43 AM, Daniel Mack wrote:
>> On 04/15/2016 03:55 PM, Mike Gilbert wrote:
>>> I'm happy to move it if others want to utilize it. I will need someone
>>> to set me up with access to push the
On 04/15/2016 03:55 PM, Mike Gilbert wrote:
> On Fri, Apr 15, 2016 at 6:42 AM, Daniel Mack wrote:
>> Nice, thanks for working on this! What's still missing in that is the
>> other side, the client that talks to the initctl socket. I have patches
>> to remove the initctl
Hi Mike,
On 04/01/2016 10:11 PM, Mike Gilbert wrote:
> On Wed, Feb 24, 2016 at 10:42 PM, Mike Gilbert wrote:
>> The existing systemd-initctl (/dev/initctl) interface works quite
>> nicely, so I will probably end up extracting it from systemd when you
>> drop it, or just building/installing it fr
On 04/12/2016 01:52 PM, Jóhann B. Guðmundsson wrote:
> Anyone know that centos is not running the latest version(s) of systemd
> required for the upstream bug tracker so one has to ask what
> notification spam is this
> "Can one of the admins verify this patch?"
Regarding that spam, I already to
Hi Daniel,
On 02/22/2016 11:04 AM, Daniel Wagner wrote:
> On 02/22/2016 09:54 AM, Tomasz Bursztyka wrote:
>> I haven't been following the recent (well... the last ~2 years ^^')
>> work on nftables but I believe there are still people using the
>> iptables format. The use the iptables- nftables co
On 02/18/2016 12:19 PM, Jóhann B. Guðmundsson wrote:
> On 02/18/2016 10:22 AM, Daniel Mack wrote:
>> I disagree. All sorts of testing is good for us, and if a PR is breaking
>> downstream Ubuntu, and we recognize that before merging, that's really
>> great.
>
> I&#
On 02/17/2016 08:02 PM, Umut Tezduyar Lindskog wrote:
> Hi,
>
> src/shared & src/basic have very useful code that upstream have been
> static linking to most binaries. My understanding is that we haven’t
> been feeling comfortable about the API to make these paths a
> standalone library (or includ
On 02/18/2016 11:08 AM, Jóhann B. Guðmundsson wrote:
> On 02/18/2016 08:01 AM, Martin Pitt wrote:
>> So please don't put too much attention to these results yet. I want to
>> to enable them to see how the testing and communication holds up in
>> practice, but before this we definitively need to sor
On 02/17/2016 06:03 PM, Jóhann B. Guðmundsson wrote:
>
>
> On 02/17/2016 04:51 PM, Daniel Mack wrote:
>> Hey,
>>
>> [I've put all people in Cc who have had more than one commit related to
>> systemd-bootchart in the past]
>>
>> As part of our
Hey,
[I've put all people in Cc who have had more than one commit related to
systemd-bootchart in the past]
As part of our spring cleaning, we've been thinking about giving
systemd-bootchart a new home, in a new repository of its own. I've been
working on this and put the result here:
https://
Hi,
On 01/06/2016 12:07 AM, Pathangi Janardhanan wrote:
> Hi All,
>
> After trying a few things out, here are couple doubts that I have.
>
> 1. I am able to get this to work, if I modify the way the sendmsg is
> being done, here is a temp. function that I wrote in my own service
> to mimic the
On 01/06/2016 03:37 AM, Hui Wang wrote:
> This Lenovo machine use codec Line2 to implement a microphone mute
> button, it depends on the unsolicited interrupt to generate key event,
> the scan code for this button is assigned to 0x00 in the linux kernel
> driver, and the keycode is KEY_MICMUTE(248)
On 01/05/2016 06:33 PM, Pathangi Janardhanan wrote:
> This is the output of the strace call on this section of the code in
> the sd_pid_notify_with_fds, when I try to save the fds.
>
> socket(PF_LOCAL, SOCK_DGRAM|SOCK_CLOEXEC, 0) = 8
>
> sendmsg(8, {msg_name(21)={sa_family=AF_LOCAL,
> sun_path="
On 10/05/2015 12:59 PM, Iñigo Martínez wrote:
> In a home made daemon, I needed to change some variables while
> running, so I though about D-Bus as IPC and gived a chance to sd-bus.
>
> Let's say that I'm trying it on a development system (currently a
> debian jessie) without any users on it, jus
On 09/24/2015 03:27 PM, D.S. Ljungmark wrote:
> (re-send due to wrong email address)
>
> On 24/09/15 14:38, Daniel Mack wrote:
>> On 09/24/2015 01:17 PM, D.S. Ljungmark wrote:
>>> I've got the following unit:
>>>
>>> [Unit]
>>> Desc
On 09/24/2015 01:17 PM, D.S. Ljungmark wrote:
> I've got the following unit:
>
> [Unit]
> Description=Random Submitter
> Wants=network-online.target
> After=network-online.target other.service
> RequiresMountsFor=/data
>
> [Service]
> Type=simple
Type=simple implies that the executable specified
Applied thanks!
Though I removed the S-o-b line, we don't use that in systemd.
On 09/23/2015 01:42 PM, Hendrik Brueckner wrote:
> Signed-off-by: Hendrik Brueckner
> ---
> src/basic/missing.h |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/src/basic/missing.h b/sr
On 09/14/2015 02:16 PM, Hans de Goede wrote:
> Like many other recent thinkpads the factory default pointingstick
> sensitivity on these devices is quite low, making the pointingstick
> very slow in moving the cursor.
>
> This extends the existing hwdb rules for tweaking the sensitivity to
> also
On 09/01/2015 10:58 AM, eshark wrote:
> Hi, All，
>
>I found that in bus-message.c , the bus_message_from_header() seems
> to misuse the _cleanup_free_ ,
>
>int bus_message_from_header()
>{
>
> _cleanup_free_ sd_bus_message *m = NULL;
>
On 08/18/2015 04:24 PM, Brenton Horne wrote:
> Aug 18 23:18:10 fusion809-vbox systemd[1]: Starting Apache Web Server...
> -- Subject: Unit httpd.service has begun start-up
> -- Defined-By: systemd
> -- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
> --
>
On 08/05/2015 12:50 PM, Sebastian Schindler wrote:
> Hi,
>
> I have Systemd v216 on a VM, there I was able to reproduce this.
> I did use this tool https://github.com/carosio/jlog to create the logs:
>
> jlog 'MESSAGE=this will crash' 'SYSLOG_IDENTIFIER=foobar' 'SYSLOG_FACILITY=3'
> 'PRIORITY=5'
On 07/30/2015 03:53 PM, Umut Tezduyar Lindskog wrote:
> Fantastic! Tried to purchase a ticket but seems like PayPal is the
> only supported payment. Is this a glitch?
For now, only going with PayPal as checkout option was the easiest way
of get the sale going. If that turns out to be a major probl
On 07/29/2015 01:40 PM, SF Markus Elfring wrote:
>> Do you have *any* local modifications in your tree?
>
> Yes. - It seems that I was bitten by a format string mismatch during
> an attempt to display a few more implementation details for my needs.
>
>
> diff --git a/src/libsystemd/sd-device/dev
On 07/29/2015 10:06 AM, SF Markus Elfring wrote:
> Program received signal SIGSEGV, Segmentation fault.
> 0x76fefc78 in vfprintf () from /lib64/libc.so.6
> (gdb) bt full
> #0 0x76fefc78 in vfprintf () from /lib64/libc.so.6
> No symbol table info available.
> #1 0x77016f39
On 07/20/2015 02:06 PM, Mantas Mikulėnas wrote:
> On Mon, Jul 20, 2015 at 1:14 PM, Daniel Mack <mailto:dan...@zonque.org>> wrote:
>
> On 07/19/2015 11:01 AM, Namhyung Kim wrote:
> > Signed-off-by: Namhyung Kim <mailto:namhy...@gmail.com>>
>
&
On 07/17/2015 02:12 PM, Vivenzio Pagliari wrote:
> ---
> man/systemd.preset.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Now merged through
https://github.com/systemd/systemd/pull/626
Thanks!
Daniel
>
> diff --git a/man/systemd.preset.xml b/man/systemd.preset.xml
> index 2f
On 07/19/2015 11:01 AM, Namhyung Kim wrote:
> Signed-off-by: Namhyung Kim
Looks good, thanks! However, it does not apply against current master.
Care to rebase? Also, we generally prefer GitHub pull requests these
days. And you can leave off the Signed-off-by line, we don't use that in
the system
On 07/14/2015 03:39 PM, RicΛrdo Bastos™ wrote:
> [Gentoo] I updated yesterday to version 'sys-apps/systemd-222-r1';
> Jul 14 16:18:27 ric-pc systemd[1]: *Failed to insert module 'kdbus':
> Function not implemented*
That's just a non-fatal warning message which is caused by a bug in
libkmod that ha
On 07/10/2015 05:00 PM, poma wrote:
> What do you think, what is it about?
?
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
On 07/09/2015 06:32 AM, Andrei Borzenkov wrote:
> On Thu, Jul 9, 2015 at 12:43 PM, Armin K. wrote:
>> > Now, this might be an issue with my limited git knowledge, but
>> > I don't think that's related to the web interface not showing
>> > the commits in the correct order between two release tags.
On 07/09/2015 09:28 AM, Armin K. wrote:
> On 09.07.2015 12:32, Andrei Borzenkov wrote:
>> I clicked on release link and it downloaded file with name
>> systemd-222.tar.gz. I see that there could be an issue with dumb cli
>> clients not following redirections probably.
>>
>
> I suppose it's a gith
On 07/09/2015 01:52 AM, cee1 wrote:
> From 76a7f141d54428af3019732c0fce146f9a6f6394 Mon Sep 17 00:00:00 2001
> From: cee1
> Date: Thu, 9 Jul 2015 12:06:59 +0800
> Subject: [PATCH] basic/util.c fopen_temporary(): close fd if failed
>
> ---
> src/basic/util.c | 1 +
> 1 file changed, 1 insertion(+
On 07/08/2015 03:43 PM, Michael Biebl wrote:
> 2015-07-08 21:17 GMT+02:00 Zbigniew Jędrzejewski-Szmek :
>> On Tue, Jul 07, 2015 at 03:49:13PM +0200, Michael Biebl wrote:
>>> 2015-07-07 2:51 GMT+02:00 Zbigniew Jędrzejewski-Szmek :
Comments, patches, pull requests — especially for documentation
On 07/07/2015 04:42 PM, Michael Biebl wrote:
> 2015-07-06 19:54 GMT+02:00 David Herrmann :
>> Hi
>>
>> We intend to release v222 tomorrow. If anyone has open issues that
>> need to be in that release, please speak up. Right now, the release
>> consists almost exclusively of bug-fixes, and we want t
On 07/06/2015 08:51 PM, Zbigniew Jędrzejewski-Szmek wrote:
> I've been asked to split the python-systemd out of the main systemd tree.
> This is the set of python modules which wrap libsystemd. They were
> originally started as a separate project by David Strauss. By splitting
> them out we return
On 07/02/2015 10:30 AM, Tomasz Torcz wrote:
> On Thu, Jul 02, 2015 at 02:04:08PM +, François Vocel wrote:
>> Process: 29174 ExecStart=/usr/sbin/amavisd -c /etc/amavisd/amavisd.conf
>> (code=exited, status=227/NO_NEW_PRIVILEGES)
>
> prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0) is failing. I don
On 06/28/2015 07:23 PM, Eric Biggers wrote:
> ---
> src/basic/util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/basic/util.c b/src/basic/util.c
> index 727be56..906e4ab 100644
> --- a/src/basic/util.c
> +++ b/src/basic/util.c
> @@ -3627,7 +3627,7 @@ bool string_i
On 06/24/2015 12:20 PM, Thomas Schmidt wrote:
> Hello, many thanks for your replies!
>
> Is there an advise what should be used instead ? SDBus/DBus is too
> late activated, private socket looks like a short term solution. Is
> there anything already there which would be the optimal way ?
No. Tha
On 06/24/2015 11:57 AM, Umut Tezduyar Lindskog wrote:
> On Wed, Jun 24, 2015 at 11:53 AM, Daniel Mack wrote:
>> On 06/24/2015 11:30 AM, Umut Tezduyar Lindskog wrote:
>>> IMPORTANT: Man page says "This interface is private to systemd and
>>> should not be used
On 06/24/2015 11:30 AM, Umut Tezduyar Lindskog wrote:
> IMPORTANT: Man page says "This interface is private to systemd and
> should not be used in external projects." for /run/systemd/private. I
> am not sure if this is still the case.
Yes it is. The private socket is a hack that will go away mid-
On 06/19/2015 09:31 PM, Johannes Ernst wrote:
> After a reboot, root gets this:
>
> # journalctl
> Error was encountered while opening journal files: Invalid argument
>
> No other output.
What does 'strace journalctl' say?
Thanks,
Daniel
___
syst
On 06/19/2015 09:34 AM, Chaiken, Alison wrote:
> ceel, are you aware that readahead is deprecated in systemd and has not
> been included since about release 216? Some of us in automotive are
> still working on it. I have some patches here
>
> https://github.com/chaiken/systemd-hacks/tree/pac
On 06/18/2015 10:08 AM, Michael Olbrich wrote:
> I have a pull request[1] that I think should be release-critical, but it
> seems I can't add labels to it. Either I'm doing something wrong, or I
> don't have the necessary permissions to add labels.
>
> Michael
>
> [1] https://github.com/systemd/s
Hi,
Now that we're using Semaphore CI for building all pull requests and
pushes to the master branch, I've set up a second VM instance to also
use their service for static code analysis on a nightly base.
We've had the systemd project registered with Coverity for a while, and
so far, new builds w
On 06/10/2015 07:04 PM, Filipe Brandenburger wrote:
> On Wed, Jun 10, 2015 at 12:23 AM, Jan Synáček wrote:
>> See https://github.com/systemd/systemd/pull/5. There are multiple
>> references to this PR that say " referenced this pull request from
>> a commit in ", which is hilarious, as those clear
On 06/10/2015 07:04 PM, Filipe Brandenburger wrote:
> On Wed, Jun 10, 2015 at 12:23 AM, Jan Synáček wrote:
>> See https://github.com/systemd/systemd/pull/5. There are multiple
>> references to this PR that say " referenced this pull request from
>> a commit in ", which is hilarious, as those clear
On 06/10/2015 09:23 AM, Jan Synáček wrote:
> See https://github.com/systemd/systemd/pull/5. There are multiple
> references to this PR that say " referenced this pull request from
> a commit in ", which is hilarious, as those clearly are not
> references to this PR. Their commit messages contain th
On 06/02/2015 04:34 PM, Martin Pitt wrote:
> Merging manually is quite a bit of work, as you have to add a new
> remote every time, fetch that, and pull from it. But it does keep a
> cleaner git log history.
Btw, Harald pointed me to this simple alias that makes checking out a
pending pull request
On 06/02/2015 03:50 PM, Filipe Brandenburger wrote:
> Hi Daniel,
>
> On Tue, Jun 2, 2015 at 3:04 AM, Daniel Mack wrote:
>> On 06/02/2015 11:25 AM, Martin Pitt wrote:
>>> FTR, this works fine here, using --with-rootprefix= (to avoid the
>>> extra slashes). This s
On 06/02/2015 02:19 PM, Jason A. Donenfeld wrote:
> On Tue, Jun 2, 2015 at 1:06 PM, David Herrmann wrote:
>> Regarding the final github address: David Strauss kindly offered the
>> 'systemd' user to us. Hence, we hope to move the repository to
>> github.com/systemd/systemd this week. Sorry for the
Hi Filipe,
On 06/02/2015 07:34 AM, Filipe Brandenburger wrote:
> On Mon, Jun 1, 2015 at 9:10 AM, Daniel Mack
>> diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c
>> index c95c110..df5fe6f 100644
>> --- a/src/core/load-fragment.c
>> +++ b/src/core/load-fra
On 06/02/2015 11:25 AM, Martin Pitt wrote:
> Daniel Mack [2015-05-29 11:05 +0200]:
>> Could you try the attached patch?
>>
>> I had to introduce a new entity in custom-entites.ent, because with
>> "--with-rootprefix=/", "&rootprefix;/lib" resolv
On 06/01/2015 10:11 PM, Ian Pilcher wrote:
> Is this going to make nspawn/networkd fundamentally incompatible with
> distributions that use iptables-based tools (such as firewalld)?
No, nftables and iptables can peacefully coexist. With nftables though,
systemd can have a table of its own, and hen
On 05/30/2015 12:31 PM, Christian Seiler wrote:
> On 05/30/2015 10:28 AM, Daniel Mack wrote:
>> On 05/30/2015 08:50 AM, Mike Gilbert wrote:
>>> On Fri, May 29, 2015 at 8:05 PM, Daniel Mack wrote:
>>>> Make sure the variable set via --with-rootprefix= does not contain
On 05/30/2015 08:50 AM, Mike Gilbert wrote:
> On Fri, May 29, 2015 at 8:05 PM, Daniel Mack wrote:
>> Make sure the variable set via --with-rootprefix= does not contain a
>> trailing slash, so man pages can use entities like "&rootprefix;/lib"
>> with
On 05/30/2015 02:21 AM, Michael Biebl wrote:
> 2015-05-30 2:05 GMT+02:00 Daniel Mack :
>> Make sure the variable set via --with-rootprefix= does not contain a
>> trailing slash, so man pages can use entities like "&rootprefix;/lib"
>> with
Replace some /usr/lib occurences in man/ with &rootprefix;/lib.
---
man/hwdb.xml| 4 ++--
man/systemd.link.xml| 4 ++--
man/systemd.netdev.xml | 4 ++--
man/systemd.network.xml | 4 ++--
man/udev.xml| 4 ++--
5 files changed, 10 insertions(+), 10 deletions(-)
diff --g
Make sure the variable set via --with-rootprefix= does not contain a
trailing slash, so man pages can use entities like "&rootprefix;/lib"
without ending up having double slashes.
---
configure.ac | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
ind
On 05/29/2015 07:37 PM, Filipe Brandenburger wrote:
> I haven't tested it, but I do have a few comments.
>
> First, why not use "rootlibdir" instead of "rootprefixlibdir"?
Because $(rootlibdir) resolves to /usr/lib64 on my system.
[...]
> On Fri, May 29
On 05/29/2015 06:53 PM, Lennart Poettering wrote:
> On Fri, 29.05.15 09:45, Filipe Brandenburger (filbran...@google.com) wrote:
>>> Atm, man/custom-entities.ent is only cleaned up on "make distclean".
>>> I think we should move that from DISTCLEANFILES to CLEANFILES.
>>
>> Yes I think that's a goo
On 05/29/2015 12:07 PM, Lennart Poettering wrote:
> On Fri, 29.05.15 03:03, Daniel Mack (zon...@kemper.freedesktop.org) wrote:
>
>> Makefile.am |2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> New commits:
>> commit 6096d9ccc3f0b963010a47febce
and with
the default behaviour of configure, "&rootprefix;lib" becomes "/usrlib".
That is solved with a subsitiution in Makefile.am now, which cleans up
all double slashes in custom-entites.ent.
Thanks,
Daniel
From f60d5707246d3a1ce8bcb11f3874ef696425a446 Mon Sep 17 00:
On 05/29/2015 05:26 AM, Andrei Borzenkov wrote:
> If you do not use D-Bus daemon systemd will be listening on private
> socket. In this case the only check it does is that peer runs as UID=0
> (note - not EUID, so suid does not really help).
>
> I wonder how access control is implemented in kdbus
On 05/27/2015 03:04 PM, Lennart Poettering wrote:
> Hmm, any chance we can somehow define those entities without having to
> add
>
>
> %entities;
> ]>
>
> To each file? Can't we tell xsltproc about this via some command line
> switch or so?
>
> This is in a way similar to how we use gcc's "
On 05/10/2015 03:14 AM, Cristian Rodríguez wrote:
> Building with address sanitizer enabled on GCC 5.1.x a memory leak
> is reported because we never close the bus, fix it by using
> cleanup variable attribute.
> ---
> src/libsystemd/sd-bus/test-bus-chat.c | 4 +---
> 1 file changed, 1 insertion(+
On 05/11/2015 01:49 PM, Torstein Husebø wrote:
> ---
> man/hwdb.xml | 2 +-
> man/nss-myhostname.xml| 2 +-
> man/sd_bus_creds_get_pid.xml | 2 +-
> man/sd_bus_default.xml| 2 +-
> man/sd_bus_message_append.xml
The only purpose of the little helper daemon called shutdownd is to keep
track and execute a scheduled shutdown. It prints utmp wall
notifications to TTYs in periodic intervals, makes sure to create the
/run/nologin and /run/systemd/shutdown/scheduled files, and eventually,
once the timeout is reac
On 04/20/2015 07:27 AM, Raul Gutierrez S wrote:
> Signed-off-by: Raul Gutierrez S
This isn't needed in the systemd project, so I dropped it.
Applied, thanks!
> ---
> src/shared/util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/shared/util.c b/src/shared/util
On 04/18/2015 05:29 AM, Matt Hoosier wrote:
> On Fri, Apr 17, 2015 at 3:52 PM, Cristian Rodríguez
> mailto:crrodrig...@opensuse.org>> wrote:
> Did you watch this presentation ?
>
> https://www.youtube.com/watch?v=RFVlbaDqll8
>
> what part of systemd is taking 1.5 seconds to start, on
Hi Lukasz,
[+dbus ML]
On 04/10/2015 04:20 PM, Lukasz Skalski wrote:
> Currently I'm working on some testsuite (let's call it dbus1-spec-test)
> for dbus-1 specification. My idea is to test dbus-1 specification
> coverage on systems with dbus-daemon and on systems without dbus-daemon
> (but with l
On 04/12/2015 03:46 PM, Lennart Poettering wrote:
> On Fri, Apr 10, 2015 at 10:18 AM, Ani Sinha wrote:
>> OK I see it now. shutdownd.c eventually issues 'shutdown -r now'. This
>> > gets parsed by shutdown_parse_argv(). Eventually we end up calling
>> > halt_main() ->halt_now() ->reboot(RB_AUTOBO
On 04/05/2015 07:03 PM, Shawn Landden wrote:
> found with coverty report
Applied, thanks!
> ---
> src/bootchart/store.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bootchart/store.c b/src/bootchart/store.c
> index f19427e..f159cba 100644
> --- a/src/bootchart/st
Hi,
With the help of Lennart and Alexander Sverdlin, I reworked major parts
of the bootchart code to make it more readable and maintainable. Most
importantly, I got rid a number of global variables that were used all
over the place, fixed tons of coding style issues and dead code. The
patches for
On 03/29/2015 08:46 PM, Alexander Sverdlin wrote:
> Entropy Graph code doesn't handle the error condition if open() of /proc entry
> fails. Moreover, the file is only opened once and only first sample will
> contain
> the correct value because the return value of pread() is also not handled
> prop
On 03/29/2015 08:44 PM, Alexander Sverdlin wrote:
> Correctly handle the potential failure of fdopen() (because of OOM, for
> instance)
> after potentially successful open(). Prevent leaking open fd in such case.
Applied, thanks!
> ---
> src/bootchart/store.c | 12 ++--
> src/bootchart/
On 03/29/2015 08:41 PM, Alexander Sverdlin wrote:
> If the kernel has no CONFIG_SCHED_DEBUG option set, systemd-bootchart produces
> empty .svg file. The reason for this is very fragile file descriptor logic in
> log_sample() and main() (/* do some cleanup, close fd's */ block). There are
> many pl
Hi Alexander,
On 03/29/2015 03:04 PM, Alexander Sverdlin wrote:
> On 29/03/15 13:44, Daniel Mack wrote:
>>> @@ -184,6 +185,7 @@ vmstat_next:
>>>> n = pread(schedstat, buf, sizeof(buf) - 1, 0); if (n <= 0) {
>>>> close(schedstat); +scheds
On 03/29/2015 03:13 AM, Alexander Sverdlin wrote:
> Fix it by zeroing all the closed descriptors immediately, this would repair
> existing caching of open files and clean-up strategy.
>
> The fix is important even with CONFIG_SCHED_DEBUG option enabled, because very
> first failure to open /proc//
Applied, thanks!
On 03/09/2015 01:02 PM, Torstein Husebø wrote:
> ---
> man/systemd.network.xml | 2 +-
> src/systemd/sd-daemon.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/man/systemd.network.xml b/man/systemd.network.xml
> index 3522551293..5d7518b348 100644
>
Hi Shawn,
On 02/19/2015 02:15 AM, Shawn Landden wrote:
> ---
> fs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs.c b/fs.c
> index 22ca62b..f751392 100644
> --- a/fs.c
> +++ b/fs.c
> @@ -208,7 +208,6 @@ static struct inode *fs_inode_get(struct super_block *sb,
>
> inode->i_p
On 02/09/2015 10:53 AM, Lukasz Skalski wrote:
> This patch fixes also problem with "ReleaseName" call in
> systemd-bus-proxyd.
Applied, thanks!
>
> diff --git a/names.c b/names.c
> index 5f57aa3..e85ba45 100644
> --- a/names.c
> +++ b/names.c
> @@ -266,6 +266,7 @@ static int kdbus_name_release(
On 02/06/2015 05:08 PM, Lukasz Skalski wrote:
> Set proper kdbus_cmd_list object size, otherwise:
Applied, thanks!
>
> dbus-send --system --dest=org.freedesktop.DBus --type=method_call \
> print-reply / org.freedesktop.DBus.ListQueuedOwners
> string:org.freedesktop.systemd1
>
> Error org.free
On 01/29/2015 05:42 AM, Bryan Hundven wrote:
> During the 3.19 merge window, two commits in Linus's tree:
> b5ae6b15bd73e35b129408755a0804287a87e041
> =
> merge d_materialise_unique() into d_splice_alias()
> =
> and
> 41d28bca2da4bd75a8915c1ccf2cacf7f4a2e531
> =
> switch d_materialise_u
On 01/20/2015 12:56 PM, Rami Rosen wrote:
> subscibe->subscribe
Applied, thanks!
>
> ---
> src/network/networkd-wait-online-manager.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/network/networkd-wait-online-manager.c
> b/src/network/networkd-wait-online-manage
On 01/05/2015 02:45 PM, Lukasz Skalski wrote:
> ---
> src/bus-proxyd/bus-proxyd.c | 4
> 1 file changed, 4 insertions(+)
Applied, thanks!
>
> diff --git a/src/bus-proxyd/bus-proxyd.c b/src/bus-proxyd/bus-proxyd.c
> index a7818f5..fc70cce 100644
> --- a/src/bus-proxyd/bus-proxyd.c
> +++ b/s
On 11/11/2014 03:31 PM, Colin Walters wrote:
> See:
> http://build.gnome.org/continuous/buildmaster/builds/2014/11/11/23/build/log-systemd.txt
>
> Perhaps something like this?
My bad, sorry. I had a hunk confusion due to rebasing.
It's already reverted in master.
Daniel
>
> diff --git a/src
On 10/24/2014 03:40 AM, Chris Bell wrote:
> On Thu, Oct 23, 2014 at 8:53 PM, Lennart Poettering
>> -all processes of the session are terminated. If
>> -the last concurrent session of a user ends, his
>> -user systemd instance w
On 10/15/2014 10:46 AM, Jan Synacek wrote:
> ---
> man/systemd.service.xml | 6 +++---
> man/systemd.socket.xml | 2 +-
> man/systemd.swap.xml| 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
Applied, thanks!
>
> diff --git a/man/systemd.service.xml b/man/systemd.service.xml
> ind
On 10/14/2014 04:13 PM, Lukasz Skalski wrote:
> ---
> src/bus-proxyd/bus-proxyd.c | 12 ++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
Applied, thanks!
> diff --git a/src/bus-proxyd/bus-proxyd.c b/src/bus-proxyd/bus-proxyd.c
> index 52498f3..6ff0e8c 100644
> --- a/src/bus-proxy
On 10/13/2014 03:29 PM, Lukasz Skalski wrote:
> 'GetConnectionUnixProcessID', 'GetConnectionUnixUser' and
> 'GetConnectionSELinuxSecurityContext' methods should return
> 'NameHasNoOwner' error (if chosen name is not available on bus)
> with more detailed description - like dbus-1:
>
> Could not ge
On 10/10/2014 04:42 PM, Lukasz Skalski wrote:
> 'ListQueuedOwners' method should return 'NameHasNoOwner' error
> if chosen name is not available on bus.
Applied, thanks!
>
> ---
> src/bus-proxyd/bus-proxyd.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/bus-proxyd/bus-p
On 10/10/2014 12:29 PM, Lukasz Skalski wrote:
> Commit 710fc9779b7c (kdbus repo) introduced attaching items[]
> instead of name[] in kdbus_cmd_conn_info struct. Commit 581fe6c81
> (systemd repo) caught up with this change, but item size was not
> properly calculated.
Thanks for spotting this!
App
Hi Simon,
On 10/01/2014 03:33 PM, Simon McVittie wrote:
> (Cc'd to the systemd mailing list because sd-bus is the reference
> implementation of the user-space side of kdbus, but please join the dbus
> list and follow-up there if you are interested in D-Bus.)
>
> I've recently been looking at kdbu
On 09/27/2014 02:48 PM, Eric Cook wrote:
> removed pointless index sort of bootids.
> use `compadd -a' to add each array, instead of expanding possibly hundreds of
> words needlessly.
> optional completion of -b
Applied, thanks.
>
> ---
> shell-completion/zsh/_journalctl | 8
> 1 fil
On 09/26/2014 01:16 PM, Zbigniew Jędrzejewski-Szmek wrote:
> On Fri, Sep 26, 2014 at 10:24:25AM +0200, Daniel Mack wrote:
>> On 09/26/2014 05:05 AM, Zbigniew Jędrzejewski-Szmek wrote:
>>> Hi,
>>> test-bus-policy fails intermittently in 'make distchec
On 09/26/2014 05:05 AM, Zbigniew Jędrzejewski-Szmek wrote:
> Hi,
> test-bus-policy fails intermittently in 'make distcheck'
>
> FAIL: test-bus-policy
> =
>
> Assertion 'policy_check_own(&p, &ucred, "org.test.test1") == true' failed at
> ../src/bus-proxyd/test-bus-policy.c:58,
On 09/18/2014 02:56 AM, Cristian Rodríguez wrote:
> ..by simply moving the declaration of "unit" into the STRV_FOREACH
> loop as suggested by Andreas.
> ---
> src/systemctl/systemctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/systemctl/systemctl.c b/src/syste
1 - 100 of 185 matches
Mail list logo
