[tcpdump-workers] Re: Dropping support in tcpdump for older versions of libpcap?

2024-05-05 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 25/04/2024 12:25, Denis Ovsienko wrote: > On Fri, 19 Apr 2024 11:18:47 -0700 > Guy Harris wrote: > >> On Apr 19, 2024, at 5:49 AM, Denis Ovsienko >> wrote: >> >>> On Fri, 12 Apr 2024 18:49:05 -0700 >>> Guy Harris wrote: >> >> ... >> >>> Since tcpdump is the

[tcpdump-workers] Re: openwrt Conclusions from CVE-2024-3094 (libxz disaster)

2024-04-02 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 01/04/2024 20:18, Guy Harris wrote: > On Apr 1, 2024, at 6:53 AM, Michael Richardson wrote: > >> I wonder if we should nuke our own make tarball system. > > I.e., replace: > > to get {libpcap,tcpdump,tcpslice} version X.Y.Z, download >

[tcpdump-workers] Re: openwrt Conclusions from CVE-2024-3094 (libxz disaster)

2024-04-01 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 01/04/2024 20:18, Guy Harris wrote: > On Apr 1, 2024, at 6:53 AM, Michael Richardson wrote: > >> I wonder if we should nuke our own make tarball system. > > I.e., replace: > > to get {libpcap,tcpdump,tcpslice} version X.Y.Z, download >

[tcpdump-workers] Re: Pcap debug at runtime

2024-02-24 Thread Francois-Xavier Le Bail
[Send, second try] On 02/03/2023 09:22, Francois-Xavier Le Bail wrote: > On 01/03/2023 20:28, Denis Ovsienko wrote: >> On Tue, 28 Feb 2023 17:01:51 +0100 >> Francois-Xavier Le Bail wrote: >> >>> In addition to printf()/fprintf(), here is a brand new way to help

[tcpdump-workers] Re: Pcap debug at runtime

2024-02-24 Thread Francois-Xavier Le Bail
On 02/03/2023 09:22, Francois-Xavier Le Bail wrote: > On 01/03/2023 20:28, Denis Ovsienko wrote: >> On Tue, 28 Feb 2023 17:01:51 +0100 >> Francois-Xavier Le Bail wrote: >> >>> In addition to printf()/fprintf(), here is a brand new way to help >>> debugging

[tcpdump-workers] Re: [tcpdump] About TSO

2023-10-07 Thread Francois-Xavier Le Bail
On 22/09/2023 09:02, Francois-Xavier Le Bail wrote: >> In 2005, a patch was proposed about TSO (TCP segment offload) for print-ip.c >> with a "#ifdef GUESS_TSO". >> https://github.com/the-tcpdump-group/tcpdump/commit/c8623960f050cb81c12b31107070021f27f14b18 >>

[tcpdump-workers] Re: [libpcap] About PR 980

2023-10-05 Thread Francois-Xavier Le Bail
On 04/10/2023 08:39, Francois-Xavier Le Bail wrote: > Hello, > > Reviews and comments welcome on PR 980. > (Answer on PR page.) > > https://github.com/the-tcpdump-group/libpcap/pull/980 In subject s/[tcpdump]/[libpcap]/ ___ tcpdu

[tcpdump-workers] [tcpdump] About PR 980

2023-10-04 Thread Francois-Xavier Le Bail
Hello, Reviews and comments welcome on PR 980. (Answer on PR page.) https://github.com/the-tcpdump-group/libpcap/pull/980 -- Francois-Xavier ___ tcpdump-workers mailing list -- tcpdump-workers@lists.tcpdump.org To unsubscribe send an email to

[tcpdump-workers] Re: [tcpdump] About TSO

2023-09-22 Thread Francois-Xavier Le Bail
> In 2005, a patch was proposed about TSO (TCP segment offload) for print-ip.c > with a "#ifdef GUESS_TSO". > https://github.com/the-tcpdump-group/tcpdump/commit/c8623960f050cb81c12b31107070021f27f14b18 > > It was never build by default. Is there a reason? Missing tests? Missing some >

[tcpdump-workers] [tcpdump] About TSO

2023-09-05 Thread Francois-Xavier Le Bail
Hello, In 2005, a patch was proposed about TSO (TCP segment offload) for print-ip.c with a "#ifdef GUESS_TSO". https://github.com/the-tcpdump-group/tcpdump/commit/c8623960f050cb81c12b31107070021f27f14b18 It was never build by default. Is there a reason? Missing tests? Missing some additional

[tcpdump-workers] Re: Accurate ECN support in tcpdump/libpcap

2023-09-05 Thread Francois-Xavier Le Bail
On 29/08/2023 16:34, Scheffenegger, Richard via tcpdump-workers wrote: > And some initial discussions which aren't yet reflected on the mailing list: > > -Original Message- > From: Scheffenegger, Richard > Sent: Freitag, 18. August 2023 14:01 > To: Francois-Xavier Le

[tcpdump-workers] Re: [tcpdump] About PR 812

2023-08-27 Thread Francois-Xavier Le Bail
On 22/08/2023 20:41, Michael Richardson wrote: > > Francois-Xavier Le Bail wrote: > > Does anyone see a problem with this change? (Answer on PR page.) > > > https://github.com/the-tcpdump-group/tcpdump/pull/812 > > It looks so simple, it's probably correct

[tcpdump-workers] [tcpdump] About PR 812

2023-08-22 Thread Francois-Xavier Le Bail
Hello, Does anyone see a problem with this change? (Answer on PR page.) https://github.com/the-tcpdump-group/tcpdump/pull/812 Greetings, -- Francois-Xavier ___ tcpdump-workers mailing list -- tcpdump-workers@lists.tcpdump.org To unsubscribe send an

[tcpdump-workers] [tcpdump] About PR 1043

2023-04-28 Thread Francois-Xavier Le Bail
Hello, Does anyone see a problem with this change? (Answer on PR page.) https://github.com/the-tcpdump-group/tcpdump/pull/1043 -- Francois-Xavier ___ tcpdump-workers mailing list -- tcpdump-workers@lists.tcpdump.org To unsubscribe send an email to

[tcpdump-workers] Re: [tcpdump] About PR 972

2023-04-21 Thread Francois-Xavier Le Bail
On 13/04/2023 09:46, Francois-Xavier Le Bail wrote: > Hello, > > Does anyone see a problem with this change? > (Answer on PR page.) > > https://github.com/the-tcpdump-group/tcpdump/pull/972 The PR has been merged. ___ tcpdump-wo

[tcpdump-workers] [tcpdump] About PR 972

2023-04-13 Thread Francois-Xavier Le Bail
Hello, Does anyone see a problem with this change? (Answer on PR page.) https://github.com/the-tcpdump-group/tcpdump/pull/972 -- Francois-Xavier ___ tcpdump-workers mailing list -- tcpdump-workers@lists.tcpdump.org To unsubscribe send an email to

[tcpdump-workers] Re: Pcap debug at runtime

2023-03-14 Thread Francois-Xavier Le Bail
On 28/02/2023 17:01, Francois-Xavier Le Bail wrote: > On 20/02/2023 21:18, Guy Harris wrote: >> On Feb 20, 2023, at 12:15 PM, Paschal Chukwuebuk Amusuo >> wrote: >> >>> Please, is there a way to print out debug statements at runtime when using >>> pcap?

[tcpdump-workers] Re: Pcap debug at runtime

2023-03-02 Thread Francois-Xavier Le Bail
On 01/03/2023 20:28, Denis Ovsienko wrote: > On Tue, 28 Feb 2023 17:01:51 +0100 > Francois-Xavier Le Bail wrote: > >> In addition to printf()/fprintf(), here is a brand new way to help >> debugging a program using libpcap, currently only tested on Debian >> Linux (sta

[tcpdump-workers] Re: Pcap debug at runtime

2023-02-28 Thread Francois-Xavier Le Bail
On 20/02/2023 21:18, Guy Harris wrote: > On Feb 20, 2023, at 12:15 PM, Paschal Chukwuebuk Amusuo > wrote: > >> Please, is there a way to print out debug statements at runtime when using >> pcap? > > Debug statements in your program? Add printf() or fprintf(stderr, ...) or... > calls to your

[tcpdump-workers] Re: TCP Header Flags

2023-02-26 Thread Francois-Xavier Le Bail
On 26/02/2023 22:45, Denis Ovsienko wrote: > On Sun, 26 Feb 2023 15:46:56 +0100 > Francois-Xavier Le Bail wrote: > > [...] >>>> I wonder if there would be any other incurred future maintenance. >> >> The proposed patch is: >> >> diff --git a

[tcpdump-workers] Re: TCP Header Flags

2023-02-26 Thread Francois-Xavier Le Bail
On 19/02/2023 13:34, Francois-Xavier Le Bail wrote: > On 18/02/2023 21:51, Denis Ovsienko wrote: >> On Sat, 18 Feb 2023 17:06:29 +0100 >> Francois-Xavier Le Bail wrote: >> >>> Hello, >>> >>> https://www.rfc-editor.org/rfc/rfc9293 states: >>

[tcpdump-workers] Re: TCP Header Flags

2023-02-26 Thread Francois-Xavier Le Bail
On 19/02/2023 13:34, Francois-Xavier Le Bail wrote: > On 18/02/2023 21:51, Denis Ovsienko wrote: >> On Sat, 18 Feb 2023 17:06:29 +0100 >> Francois-Xavier Le Bail wrote: >> >>> Hello, >>> >>> https://www.rfc-editor.org/rfc/rfc9293 states: >>

[tcpdump-workers] Re: TCP Header Flags

2023-02-19 Thread Francois-Xavier Le Bail
On 18/02/2023 21:51, Denis Ovsienko wrote: > On Sat, 18 Feb 2023 17:06:29 +0100 > Francois-Xavier Le Bail wrote: > >> Hello, >> >> https://www.rfc-editor.org/rfc/rfc9293 states: >> "Control bits: >> >> The control bits are also known as "

[tcpdump-workers] TCP Header Flags

2023-02-18 Thread Francois-Xavier Le Bail
Hello, https://www.rfc-editor.org/rfc/rfc9293 states: "Control bits: The control bits are also known as "flags". Assignment is managed by IANA from the "TCP Header Flags" registry [62]. The currently assigned control bits are CWR, ECE, URG, ACK, PSH, RST, SYN, and FIN." (All on three

Re: [tcpdump-workers] [tcpdump] About HAVE_NO_PRINTF_Z

2023-01-12 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 12/01/2023 10:04, Denis Ovsienko wrote: > Do you think it would be > appropriate to use [again] %lu instead of %zu for size_t [...] on systems > that don't have %zu [...]? The problem is that the needed conversion specification is "%lu" on 64 bits system and "%u" on 32

[tcpdump-workers] [tcpdump] About HAVE_NO_PRINTF_Z

2023-01-11 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- Hello, The commit fbd44158e0d5e6bb0c9b05671f702ebcf68cc56d was: --- Mend "make check" on Solaris 9 (Autoconf only). Sun C 5.9 does not support C99. GCC 4.6.4 recognizes -std=gnu99, but

Re: [tcpdump-workers] Autoconf with Debian patches

2023-01-07 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 07/01/2023 20:13, Michael Richardson wrote: > > Francois-Xavier Le Bail via tcpdump-workers wrote: > > Or don't generate it and have the build process be: > > ./autogen.sh && ./configure && ... > > That just leads

Re: [tcpdump-workers] Autoconf with Debian patches

2023-01-07 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 06/01/2023 21:38, Francois-Xavier Le Bail via tcpdump-workers wrote: >> As some have experienced before, attempts to regenerate the configure >> script often result in two groups of unnecessary changes (runstatedir >> and LARGE_OFF_T), both of whic

Re: [tcpdump-workers] Autoconf with Debian patches

2023-01-07 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 06/01/2023 23:49, Guy Harris via tcpdump-workers wrote: > An alternative would be *not* to keep the generated configure script in the > repository (that's what Wireshark ended up doing before it ceased to use > autoconf/automake), and generate it as part of the

Re: [tcpdump-workers] Autoconf with Debian patches

2023-01-06 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 04/01/2023 23:30, Denis Ovsienko via tcpdump-workers wrote: > As some have experienced before, attempts to regenerate the configure > script often result in two groups of unnecessary changes (runstatedir > and LARGE_OFF_T), both of which come from Debian-specific patches

[tcpdump-workers] About formalization of pcap expressions

2022-07-23 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- Hi, FYI, the author of the following document try a formalization of pcap expressions: https://www.seas.upenn.edu/~nsultana/files/pcap_semantics.pdf In this document, reference to a tool: https://gitlab.com/niksu/caper -- Francois-Xavier --- End Message ---

Re: [tcpdump-workers] [tcpdump] About struct in_addr / struct in6_addr

2022-07-17 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 17/07/2022 19:57, Guy Harris wrote: > On Jul 17, 2022, at 10:10 AM, Francois-Xavier Le Bail via tcpdump-workers > wrote: > >> The current nd_ipv4 and nd_ipv6 types were added in 2017 for alignment >> reasons. >> >> Since then, >

[tcpdump-workers] [tcpdump] About struct in_addr / struct in6_addr

2022-07-17 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- Hi, The current nd_ipv4 and nd_ipv6 types were added in 2017 for alignment reasons. Since then, most of the 'struct in_addr' were replaced by 'nd_ipv4', most of the 'struct in6_addr' were replaced by 'nd_ipv6'. Remain: pflog.h:110:struct in_addr v4;

Re: [tcpdump-workers] [tcpdump] New configure option for debugging

2022-01-22 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- > The usage is: > ./configure --enable-instrument-functions > > This should help some debugging processes. > > Enabling it generate instrumentation calls for entry and exit to functions. > Just after function entry and just before function exit, these profiling >

[tcpdump-workers] [tcpdump] New configure option for debugging

2022-01-19 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- Hello, The usage is: ./configure --enable-instrument-functions This should help some debugging processes. Enabling it generate instrumentation calls for entry and exit to functions. Just after function entry and just before function exit, these profiling functions are

Re: [tcpdump-workers] [libpcap] Keep Win32/Prj/* files ?

2021-12-07 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 07/12/2021 02:26, Denis Ovsienko via tcpdump-workers wrote: > On Mon, 6 Dec 2021 12:31:33 -0800 > Guy Harris wrote: > > [...] >> The CMake files are likely to be better maintained than the "use >> Visual Studio directly" files, as you don't need Visual Studio, and >>

[tcpdump-workers] [libpcap] Keep Win32/Prj/* files ?

2021-11-29 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- Hello, The information on building libpcap on Windows with Visual Studio is here: https://github.com/the-tcpdump-group/libpcap/blob/master/doc/README.Win32.md (The supported way to build libpcap (and tcpdump) on Windows is with CMake) Does anyone use these files?

Re: [tcpdump-workers] Saving packets with libpcap in PCAPNG format

2021-11-20 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 20/11/2021 20:55, Guy Harris wrote: > On Nov 20, 2021, at 11:41 AM, Francois-Xavier Le Bail via tcpdump-workers > wrote: > >> It's seems that Apple has changed their license to: "License: BSD." >> >> See: >> https://opensour

Re: [tcpdump-workers] Saving packets with libpcap in PCAPNG format

2021-11-20 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 06/12/2016 19:32, Guy Harris wrote: > On Dec 6, 2016, at 10:15 AM, Martin Dubuc wrote: > >> I am working on an application that requires to store packets in PCAPNG >> format. My understanding is that there isn't support for saving packets in >> PCAPNG format in the

[tcpdump-workers] [www.tcpdump.org] favicon

2021-11-08 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- Hello, To keep coherent the visual identity of the project, I propose the attached favicon for the web site. -- Francois-Xavier--- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org

[tcpdump-workers] [tcpdump] Finding inconsistent outputs of tcpdump with different compilers

2021-08-09 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- Hello, As a follow-up to https://github.com/the-tcpdump-group/tcpdump/issues/919, here is a way to help finding eventual inconsistent outputs. 1) Get libpcap and tcpdump from the-tcpdump-group:master branches in the same directory. git clone

Re: [tcpdump-workers] Stick with Travis for continuous integration, or switch?

2021-02-10 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 03/02/2021 17:50, Francois-Xavier Le Bail via tcpdump-workers wrote: > These scripts can be used locally for build tests, used on other CI and > easily be updated to run new tests (32 bits builds, sanitizers, coverage, > etc). > > Next step is doin

Re: [tcpdump-workers] Stick with Travis for continuous integration, or switch?

2021-02-03 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 01/02/2021 18:08, Denis Ovsienko via tcpdump-workers wrote: > On Mon, 18 Jan 2021 22:29:21 -0800 > Guy Harris via tcpdump-workers > wrote: > >> I guess we meet those requirements, although I'm not too keen on >> having to keep going hat-in-hand to them every time we run

Re: [tcpdump-workers] libpcap detection and linking in tcpdump

2021-01-07 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 07/01/2021 18:35, Bill Fenner via tcpdump-workers wrote: > These jobs are still failing, but now for a different reason. The build > succeeds, but the tests fail - the tests that require the new libpcap. > However, if you augment TESTrun to print the version, it says >

Re: [tcpdump-workers] [tcpdump] After setjmp/longjmp update

2021-01-03 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 18/12/2020 21:36, Francois-Xavier Le Bail via tcpdump-workers wrote: > The post setjmp/longjmp updates take more time than expected. About 30% of > the work is done. > To avoid keeping too long the other updates in the master branch, we plan to > release s

Re: [tcpdump-workers] [tcpdump] After setjmp/longjmp update

2020-12-18 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 05/09/2020 18:20, Francois-Xavier Le Bail via tcpdump-workers wrote: > Hello, > > Some people ask for a new version of tcpdump. > > To understand why we cannot release now, here is some information: > > We are in the process to harden the tcpdump

Re: [tcpdump-workers] [tcpdump] After setjmp/longjmp update

2020-10-14 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 24/09/2020 21:51, Denis Ovsienko via tcpdump-workers wrote: > On Sat, 5 Sep 2020 18:20:42 +0200 > Francois-Xavier Le Bail via tcpdump-workers > wrote: > > [...] >> 2) Process all the truncated cases with: >> ndo->ndo_ll_hdr_len = 0; &g

Re: [tcpdump-workers] [tcpdump] After setjmp/longjmp update

2020-09-23 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 20/09/2020 18:28, Michael Richardson wrote: > > Given: > > case CTRL_BA: > (*) ND_TCHECK_LEN(p, CTRL_BA_HDRLEN); > if (!ndo->ndo_eflag) > ND_PRINT(" RA:%s ", > GET_ETHERADDR_STRING(((const

Re: [tcpdump-workers] [tcpdump] After setjmp/longjmp update

2020-09-23 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 20/09/2020 18:25, Michael Richardson wrote: > > Also, please confirm for me that these lines like this are redundant: > > ND_TCHECK_LEN(p, IEEE802_11_REASON_LEN); > if (length < IEEE802_11_REASON_LEN) > goto trunc; > > In fact, we don't

Re: [tcpdump-workers] [tcpdump] After setjmp/longjmp update

2020-09-18 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 17/09/2020 22:05, Francois-Xavier Le Bail via tcpdump-workers wrote: > On 17/09/2020 16:15, Denis Ovsienko via tcpdump-workers wrote: >> On Sat, 5 Sep 2020 18:20:42 +0200 >> Francois-Xavier Le Bail via tcpdump-workers >> wrote: >> >>>

Re: [tcpdump-workers] [tcpdump] After setjmp/longjmp update

2020-09-17 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 17/09/2020 16:15, Denis Ovsienko via tcpdump-workers wrote: > On Sat, 5 Sep 2020 18:20:42 +0200 > Francois-Xavier Le Bail via tcpdump-workers > wrote: > >> 2) Process all the truncated cases with: >> ndo->ndo_ll_hdr_len = 0; >&

Re: [tcpdump-workers] [tcpdump] After setjmp/longjmp update

2020-09-07 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 07/09/2020 16:43, Denis Ovsienko via tcpdump-workers wrote: > On Sat, 5 Sep 2020 18:20:42 +0200 > Thank you for posting a detailed explanation and making the first round > of changes. I am looking into the logic of this work. As soon as it > feels I can tell the right

[tcpdump-workers] [tcpdump] After setjmp/longjmp update

2020-09-05 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- Hello, Some people ask for a new version of tcpdump. To understand why we cannot release now, here is some information: We are in the process to harden the tcpdump code with use of new (GET_) macros (with setjmp/longjmp logic) to fetch the packet data without have to do

Re: [tcpdump-workers] strlcpy() in tcpslice

2020-08-25 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 25/08/2020 19:44, Denis Ovsienko via tcpdump-workers wrote: > +[missing/strlcpy.c:46]: (style) The function 'strlcpy' is never used. > > (Which is true, but neither GCC nor Clang complain about that.) > > LBL code never used strlcpy(), it appeared in TTG code in 2001 via

Re: [tcpdump-workers] [tcpdump] Keep win32/prj/WinDump.dsp ?

2020-07-25 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 08/06/2020 21:50, Guy Harris wrote: > On Jun 8, 2020, at 12:24 PM, Francois-Xavier Le Bail > wrote: > >> Thus all the files in win32/prj/ could be removed? >> (WinDump.dsp WinDump.dsw WinDump.sln WinDump.vcproj) > > I have no problem

Re: [tcpdump-workers] Reading capture files with an unknown link-layer header type

2020-06-13 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 12/06/2020 07:31, Guy Harris via tcpdump-workers wrote: > François checked in a change to tcpdump so that, if it's handed a capture > file with a link-layer header type for which it has no dissector, it just > dumps the packet data in hex, rather than failing with an

Re: [tcpdump-workers] [tcpdump] Keep win32/prj/WinDump.dsp ?

2020-06-08 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 25/05/2020 00:22, Guy Harris wrote: > On May 24, 2020, at 4:37 AM, Francois-Xavier Le Bail via tcpdump-workers > wrote: > >> 15 printers are missing in win32/prj/WinDump.dsp. >> Does anyone use it? Any reason to keep it ? > > Note that t

[tcpdump-workers] [tcpdump] Keep win32/prj/WinDump.dsp ?

2020-05-24 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- Hello, 15 printers are missing in win32/prj/WinDump.dsp. Does anyone use it? Any reason to keep it ? Greetings, -- Francois-Xavier --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org

Re: [tcpdump-workers] Compile libpcap with DLT_LINUX_SLL2

2020-05-10 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 10/05/2020 10:04, Francois-Xavier Le Bail via tcpdump-workers wrote: > On 10/05/2020 00:37, Guy Harris via tcpdump-workers wrote: >> Is SLL2 sufficiently established that we'd have to introduce an SLL3 type, >> or can we just change SLL2 at this point? >

Re: [tcpdump-workers] Compile libpcap with DLT_LINUX_SLL2

2020-05-10 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 10/05/2020 00:37, Guy Harris via tcpdump-workers wrote: > Is SLL2 sufficiently established that we'd have to introduce an SLL3 type, or > can we just change SLL2 at this point? Just on the SLL2/SLL3 point: libpcap-1.9.1 is the first libpcap release to support SLL2, but

Re: [tcpdump-workers] LINUX_SLL2 printing update

2020-05-09 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 09/05/2020 07:17, Guy Harris wrote: > On May 8, 2020, at 9:57 PM, Francois-Xavier Le Bail via tcpdump-workers > wrote: > >> For a quick look, I don't need 'ifindex N', but I need 'In/Out,...' >> >> Thus I pr

[tcpdump-workers] LINUX_SLL2 printing update

2020-05-08 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- Hello, As a user, I think the current print with LINUX_SLL2 on the "any" interface is not optimal. tcpdump -nt: ifindex 2 (eth0) IP 192.168.1.1 > 9.9.9.9: ICMP echo request, id 1098, seq 1, length 64 ifindex 2 (eth0) IP 9.9.9.9 > 192.168.1.1: ICMP echo reply, id 1098, seq

Re: [tcpdump-workers] Compile libpcap with DLT_LINUX_SLL2

2020-05-08 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 08/05/2020 22:59, Francois-Xavier Le Bail via tcpdump-workers wrote: >> > In fact, no need to change libpcap. Can be do in tcpdump code. >> >> > See: https://github.com/the-tcpdump-group/tcpdump/pull/850 >> >> definitely do this

Re: [tcpdump-workers] Compile libpcap with DLT_LINUX_SLL2

2020-05-08 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 08/05/2020 19:59, Michael Richardson wrote: > > Francois-Xavier Le Bail via tcpdump-workers wrote: > >>> BTW how about DLT_LINUX_SLL2 as the default? What does it block? > > >> To avoid breaking program that cannot use SLL2, coul

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-08 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 07/05/2020 15:39, Francois-Xavier Le Bail wrote: > On 07/05/2020 09:39, Francois-Xavier Le Bail via tcpdump-workers wrote: >>> In this *particular* case, that test is done only if the uppermost nibble >>> of the uppermost octet is 0, so that w

Re: [tcpdump-workers] Compile libpcap with DLT_LINUX_SLL2

2020-05-08 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 31/03/2020 11:09, Francois-Xavier Le Bail via tcpdump-workers wrote: >> BTW how about DLT_LINUX_SLL2 as the default? What does it block? > To avoid breaking program that cannot use SLL2, could we have an API like > pcap_set_cooked_

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-07 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 07/05/2020 09:39, Francois-Xavier Le Bail via tcpdump-workers wrote: >> In this *particular* case, that test is done only if the uppermost nibble of >> the uppermost octet is 0, so that would only be the case for the source >> address, which is less li

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-07 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 07/05/2020 09:17, Guy Harris wrote: >> On 07/05/2020 08:53, Guy Harris via tcpdump-workers wrote: >> >>> "Looks like a valid Ethernet address" is defined as "the first three octets >>> appear in Wireshark's file giving manufacturer names for OUIs". >> What if the

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-07 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 07/05/2020 09:13, Gert Doering wrote: > Due to missing {}, the "p += 4" will always be executed, skipping the > control word twice if "-v" is set. Yes, already corrected, not the good patch ... -- Francois-Xavier --- End Message ---

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-07 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 07/05/2020 08:53, Guy Harris via tcpdump-workers wrote: > "Looks like a valid Ethernet address" is defined as "the first three octets > appear in Wireshark's file giving manufacturer names for OUIs". What if the destination address is ff:ff:ff:ff:ff:ff (broadcast) for

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-07 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 05/05/2020 21:44, Gert Doering wrote: > Hi, > > On Tue, May 05, 2020 at 08:47:04PM +0200, Francois-Xavier Le Bail wrote: >>> So, given that the first 16 bits are "4 bit always 0, and 12 bits >>> reserved-must-be-set-to-0", using th

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-05 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 05/05/2020 21:44, Gert Doering wrote: >> We should print "PW Ethernet Control Word" and the "Sequence Number", 2 last >> 2 octets of the 4. >> Like: >> PW Ethernet Control Word, Sequence Number xxx > I think we should only print this if "-v" is given. Most of the time,

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-05 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 05/05/2020 20:45, Francois-Xavier Le Bail via tcpdump-workers wrote: > We should print "PW Ethernet Control Word" and the "Sequence Number", 2 last > 2 octets of the 4. > Like: > PW Ethernet Control Word, Sequence Number xxx Attached pat

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-05 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 05/05/2020 20:37, Gert Doering wrote: > Hi, > > On Tue, May 05, 2020 at 07:28:28PM +0200, Francois-Xavier Le Bail wrote: >> On 05/05/2020 12:15, Gert Doering via tcpdump-workers wrote: >>> In my case, there is an MPLS control word before the et

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-05 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 05/05/2020 12:15, Gert Doering via tcpdump-workers wrote: > In my case, there is an MPLS control word before the ethernet header > (" "), and if I skip that and just clear "ethernet in here", I > get nicely printed packets... It seems it is like:

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-05 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 05/05/2020 19:17, Gert Doering wrote: > Hi, > > On Tue, May 05, 2020 at 06:45:27PM +0200, Francois-Xavier Le Bail wrote: >>> Attached as well. Not very smart yet, just does "what I need". >> >> Thanks, >> >> P

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-05 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 05/05/2020 18:34, Gert Doering wrote: > Hi, > > On Tue, May 05, 2020 at 04:45:04PM +0200, Francois-Xavier Le Bail wrote: >> On 05/05/2020 12:15, Gert Doering via tcpdump-workers wrote: >>> 12:11:46.116238 MPLS (label 105, exp 0, ttl 254) (label 240

Re: [tcpdump-workers] decode MPLS-contained packets?

2020-05-05 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 05/05/2020 12:15, Gert Doering via tcpdump-workers wrote: > 12:11:46.116238 MPLS (label 105, exp 0, ttl 254) (label 24003, exp 0, [S], > ttl 254) IP 10.27.99.2 > 10.27.99.34: ICMP echo request, id 49866, seq 5160, > length 84 > 12:11:46.117107 MPLS (label 24002, exp 0,

Re: [tcpdump-workers] Compile libpcap with DLT_LINUX_SLL2

2020-03-31 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 31/03/2020 00:04, Petr Vorel wrote: > Hi Guy, > >>> BTW man pages (pcap.3pcap.in, pcap_datalink.3pcap.in, pcap_loop.3pcap and >>> pcap_next_ex.3pcap) mention only DLT_LINUX_SLL. > >> Fixed in commit ffb99eceefd31771a4aa89f0da5d02a3c53cfd03. > Thanks a lot! > > BTW how

[tcpdump-workers] Fwd: Re: [tcpdump] About smiInit() parameter

2020-03-30 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- Forwarded Message Subject: Re: [tcpdump] About smiInit() parameter On 30/03/2020 19:54, Guy Harris wrote: > >> On Mar 30, 2020, at 10:24 AM, Francois-Xavier Le Bail >> wrote: >> >> Hi Guy, >> >> We have: >>

Re: [tcpdump-workers] Compile libpcap with DLT_LINUX_SLL2

2020-03-30 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 13/03/2020 12:35, Bill Fenner via tcpdump-workers wrote: > > The "-y" flag to tcpdump allows you to specify capturing with > DLT_LINUX_SLL2. Should DLT_LINUX_SLL2 be now the default when tcpdump is built with a libpcap that support it ? -- Francois-Xavier --- End

Re: [tcpdump-workers] New RFCs for 1) pcap file format and 2) rpcapd protocol?

2020-03-22 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 22/03/2020 18:29, Guy Harris via tcpdump-workers wrote: > 5) Treat rpcap as "remote procedure call for libpcap" and put it under the > the-tcpdump-group team, and put pcap under the pcapng team as per the same > reason as 4). Ok. --- End Message ---

Re: [tcpdump-workers] New RFCs for 1) pcap file format and 2) rpcapd protocol?

2020-03-21 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 21/03/2020 22:14, Guy Harris via tcpdump-workers wrote: > 1) has the slight disadvantage that the name for the team suggests it's for > pcapng only; it appears that teams can be renamed: > > >

Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)

2020-03-20 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 19/03/2020 22:11, Michael Richardson via tcpdump-workers wrote: > I will submit a whitespace change to master next week, and then a modeline > fix. > Are there any integrations to github that will warn people to fix their > whitespace settings? Could you explain the

Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)

2020-03-20 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 20/03/2020 16:16, Michael Richardson wrote: > Francois-Xavier Le Bail wrote: > >> > If we do, we should replace all the tabs in pcap-int.h with spaces; > we > >> > should at least be consistent, and change #918 fixed on

Re: [tcpdump-workers] [the-tcpdump-group/libpcap] Use tab instead of space in formatting pcap-int.h (#918)

2020-03-20 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 19/03/2020 22:11, Michael Richardson via tcpdump-workers wrote: > >> I thought we wanted all spaces? > > > If we do, we should replace all the tabs in pcap-int.h with spaces; we > > should at least be consistent, and change #918 fixed one inconsistent > >

Re: [tcpdump-workers] tcpdump testsuite and Perl

2020-02-04 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 03/02/2020 03:17, Guy Harris wrote: >> And remove the yaml stuff. > ...which, it appears, is not being used; we're still using the old plain-text > TESTLIST file, and have no YAML files for tests yet. > > What YAML would provide would be easier extensibility, in that you

Re: [tcpdump-workers] tcpdump testsuite and Perl

2020-02-02 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 02/02/2020 04:24, Francois-Xavier Le Bail wrote: > On 31/01/2020 17:19, Michael Richardson wrote: >> >> Francois-Xavier Le Bail via tcpdump-workers wrote: >> > On 28/01/2020 23:17, Denis Ovsienko via tcpdump-workers wrote: >> >&

Re: [tcpdump-workers] tcpdump testsuite and Perl

2020-02-01 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 02/02/2020 04:24, Francois-Xavier Le Bail via tcpdump-workers wrote: > We could add a "type" field in TESTLIST and do the process following this > type. > > std: standard test. > crypto: need ssl library. > gcc: need GCC co

Re: [tcpdump-workers] tcpdump testsuite and Perl

2020-02-01 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 31/01/2020 17:19, Michael Richardson wrote: > > Francois-Xavier Le Bail via tcpdump-workers wrote: > > On 28/01/2020 23:17, Denis Ovsienko via tcpdump-workers wrote: > >> The new dependency makes it more difficult to run tests and will b

Re: [tcpdump-workers] tcpdump testsuite and Perl

2020-01-29 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 28/01/2020 23:17, Denis Ovsienko via tcpdump-workers wrote: > The new dependency makes it more difficult to run tests and will break > package builds downstream (thus penalising people that cared enough to > make "make check" a part of the build). Maybe the cost of the

Re: [tcpdump-workers] tcpdump testsuite and Perl

2020-01-28 Thread Francois-Xavier Le Bail via tcpdump-workers
--- Begin Message --- On 28/01/2020 18:45, Michael Richardson wrote: > > Francois-Xavier Le Bail wrote: > >> I noticed that the testsuite of tcpdump recently fails with > >> "make_path" is not exported by the File::Path module > >> &quo

Re: [tcpdump-workers] GET_BYTES() macro, doing a bounds check and a memcpy()?

2019-09-10 Thread Francois-Xavier Le Bail
On 03/05/2019 19:08, Guy Harris wrote: > Commit e150c713a2ea333e9ab173e062b447dd65c9a4ee added some ND_TCHECK_LEN() > calls before doing a memcpy. > > Should we have a function > > static inline void > get_bytes(netdissect_options *ndo, u_char *dst, const u_char *p, size_t > len) >

Re: [tcpdump-workers] {clang, gcc} X {i386, x86_64} building, and docker/travis

2019-08-22 Thread Francois-Xavier Le Bail
On 19/08/2019 03:48, Michael Richardson wrote: > > Francois-Xavier Le Bail wrote: > >> We build with gcc and clang on travis, with options that do not always > match > >> what contributors get by default. > >> > >> I've added "

Re: [tcpdump-workers] {clang, gcc} X {i386, x86_64} building, and docker/travis

2019-08-18 Thread Francois-Xavier Le Bail
On 18/08/2019 19:49, Michael Richardson wrote: > We build with gcc and clang on travis, with options that do not always match > what contributors get by default. > > I've added "./buildem" which goes through the set of -m32/-m64 and clang, gcc > to build them all using build directories. > It

Re: [tcpdump-workers] GET_BYTES() macro, doing a bounds check and a memcpy()?

2019-05-03 Thread Francois-Xavier Le Bail
On 03/05/2019 19:08, Guy Harris wrote: > Should we have a function > > static inline void > get_bytes(netdissect_options *ndo, u_char *dst, const u_char *p, size_t > len) > { > if (!ND_TCHECK_LEN(p, len)) > longjmp(ndo->ndo_truncated, 1); >

Re: [tcpdump-workers] [tcpdump] Keep win32/prj/GNUmakefile ?

2019-05-03 Thread Francois-Xavier Le Bail
On 16/04/2019 17:14, Francois-Xavier Le Bail wrote: > 39 printers are missing in win32/prj/GNUmakefile. Someone use it ? keep it ? If no one uses it, we will delete it. ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org ht

[tcpdump-workers] [tcpdump] Keep win32/prj/GNUmakefile ?

2019-04-16 Thread Francois-Xavier Le Bail
Hi, 39 printers are missing in win32/prj/GNUmakefile. Someone use it ? keep it ? -- Francois-Xavier ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

[tcpdump-workers] [tcpdump] Remove --enable-smb/--disable-smb configure options ?

2018-10-27 Thread Francois-Xavier Le Bail
[not seen on the list, sent again] Hello, Denis had removed a useless warning about the SMB decoder. (commit 415b70b6cedadb4a08b7e873385226f0a7b68076) Is it time to remove --enable-smb/--disable-smb (enable possibly-buggy SMB printer) code ? -- Francois-Xavier

Re: [tcpdump-workers] [tcpdump] Truncated strings

2018-09-08 Thread Francois-Xavier Le Bail
On 21/08/2018 17:21, Denis Ovsienko wrote: > (moving this to tcpdump-workers) > > On Tue, 08 May 2018 14:41:13 +0100 Francois-Xavier Le Bail > wrote > > e.g.: > > proto1_print(...) > > { > > ndo->ndo_protocol = &qu

  1   2   >