Re: Small ifconfig output tweak for inet6?

2015-03-26 Thread Mike Belopuhov
On 26 March 2015 at 14:27, Stuart Henderson st...@openbsd.org wrote: seems reasonable. (I'd quite like that for v4 too, though it wouldn't cope with non-contiguous netmask ;) non-contiguous netmasks for IPv4 addresses configured on an interface? is that possible? what's the use case? perhaps

Re: Avoid doing IPv6 SLAAC for prefixes with preferred lifetime of zero

2015-03-09 Thread Mike Belopuhov
On 9 March 2015 at 16:37, Stuart Henderson st...@openbsd.org wrote: whitespace nit here (5 char indent), otherwise OK done on purpose.

Avoid doing IPv6 SLAAC for prefixes with preferred lifetime of zero

2015-03-09 Thread Mike Belopuhov
Hi, It looks like Mac OS X puts some IPv6 garbage on the wire and our cheap consumer router starts happily advertising routes like this: 4006:16e1:ac17:189::/64 if=re0 flags=LAO vltime=6401, pltime=0, expire=1h46m34s, ref=0 advertised by fe80::9ec7:a6ff:fe86:a3f4%re0 (reachable) This

Re: splassert: rtrequest1: want 5 have 0

2015-02-19 Thread Mike Belopuhov
On 19 February 2015 at 21:30, Alexander Bluhm alexander.bl...@gmx.net wrote: On Wed, Feb 18, 2015 at 12:14:15PM +0100, Matthieu Herrb wrote: Feb 18 12:09:59 castor /bsd: splassert: rtrequest1: want 5 have 0 Feb 18 12:09:59 castor /bsd: Starting stack trace... Feb 18 12:09:59 castor /bsd:

Re: libpcap use after free

2015-01-15 Thread Mike Belopuhov
On 15 January 2015 at 03:53, Lawrence Teo l...@openbsd.org wrote: libpcap has a use after free (found via LLVM). pcap_close() currently looks like this: void pcap_close(pcap_t *p) { if (p-opt.source != NULL) free(p-opt.source); pcap_cleanup_bpf(p);

Re: Kill IPv4 list of addresses

2015-01-12 Thread Mike Belopuhov
On 6 January 2015 at 13:26, Martin Pieuchot mpieuc...@nolizard.org wrote: Diff below remove the last use of the global IPv4 list of addresses. The code using it is a hack to move the unique cloning route of a subnet from one ifa to another. I know a proper fix would be to use multipath for

Re: idle pool page gc

2014-12-22 Thread Mike Belopuhov
On 22 December 2014 at 06:43, David Gwynne da...@gwynne.id.au wrote: this introduces a global gc task that loops over all the pools looking for pages that havent been used for a very long time so they can be freed. this is the simplest way of doing this without introducing per pool

Re: divert(4) m_pullup

2014-12-16 Thread Mike Belopuhov
On 16 December 2014 at 12:08, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Mon, 15 Dec 2014 23:44:54 -0500 From: Lawrence Teo l...@openbsd.org Make divert_output() do an m_pullup only if truly needed. ok? Questionable. AFAIK m_pullup(9) will only do the pullup if it is necesary in

Re: page fault at resume, possibly caused by java/jenkins

2014-12-11 Thread Mike Belopuhov
On 11 December 2014 at 14:16, Martin Pieuchot mpieuc...@nolizard.org wrote: On 11/12/14(Thu) 12:37, frantisek holop wrote: login: kernel: page fault trap, code=0 Stopped at in_selectsrc+0xd8: movl 0xf0(%esi),%ebx ddb{0} trace

Re: tcpdump follows incorrect alignment requirement rules

2014-12-09 Thread Mike Belopuhov
On 9 December 2014 at 19:00, Christian Weisgerber na...@mips.inka.de wrote: On 2014-12-03, Mike Belopuhov m...@belopuhov.com wrote: bpf aligns data following the datalink header (e.g. ethernet) on the BPF_ALIGNMENT boundary. Since rev1.41 of bpf.h it's uint32_t instead of a long. And also

Call for testing of watchdog devices

2014-12-08 Thread Mike Belopuhov
Hi, We plan to remove shutdown hooks for good and need to convert all drivers implementing a watchdog(4) device to the config_* framework namely implementing the activate method with a DVACT_POWERDOWN action handler fleshed out. This is the diff I came up with. wdog_shutdown will now check that

Re: tcpdump follows incorrect alignment requirement rules

2014-12-08 Thread Mike Belopuhov
On Wed, Dec 03, 2014 at 14:56 +0100, Mike Belopuhov wrote: bpf aligns data following the datalink header (e.g. ethernet) on the BPF_ALIGNMENT boundary. Since rev1.41 of bpf.h it's uint32_t instead of a long. And also since then almost all packets become unaligned from the tcpdump perspective

Re: operations on nd_prefix list must take rdomain into account

2014-12-08 Thread Mike Belopuhov
Ping. On Fri, Nov 28, 2014 at 13:40 +0100, Mike Belopuhov wrote: Still looking for OK's. On Wed, Nov 26, 2014 at 18:24 +0100, Mike Belopuhov wrote: More rdomain checks are needed to be able to use the same subnet in a back to back connection between IPv6 rdomains as pointed out by mpi

Re: ix(4) and Unsupported SFP+ Module

2014-12-05 Thread Mike Belopuhov
On Fri, Dec 05, 2014 at 11:24 +0100, Gabriel Linder wrote: Hi, On a 5.6-release I have an ix card which refuses to work with unsupported SFP+ modules, saying this : ix0 at pci1 dev 0 function 0 Intel 82599 rev 0x01Unsupported SFP+ Module. However, this seems to be an artificial

tcpdump follows incorrect alignment requirement rules

2014-12-03 Thread Mike Belopuhov
bpf aligns data following the datalink header (e.g. ethernet) on the BPF_ALIGNMENT boundary. Since rev1.41 of bpf.h it's uint32_t instead of a long. And also since then almost all packets become unaligned from the tcpdump perspective and require costly copies into the internal buffer. Neither

Re: tcpdump: Ethernet header is not dumped with -xX if IP header is unaligned

2014-11-28 Thread Mike Belopuhov
Still looking for OK's. On Wed, Nov 26, 2014 at 17:18 +0100, Mike Belopuhov wrote: better diff. the problem is that dissectors use packetp and snapend pointers themselves therefore they should be pointing to the newly allocated structure. we can restore them once we're done

Re: tcpdump: Ethernet header is not dumped with -xX if IP header is unaligned

2014-11-27 Thread Mike Belopuhov
On 27 November 2014 at 03:12, Theo de Raadt dera...@cvs.openbsd.org wrote: On Tue, Nov 25, 2014 at 18:42 +0100, Mike Belopuhov wrote: On Mon, Nov 24, 2014 at 19:04 +0100, Mike Belopuhov wrote: Hi, IP header is not always aligned since bpf copies out the mbuf chain into the contigous

Re: tcpdump: Ethernet header is not dumped with -xX if IP header is unaligned

2014-11-26 Thread Mike Belopuhov
On Tue, Nov 25, 2014 at 18:42 +0100, Mike Belopuhov wrote: On Mon, Nov 24, 2014 at 19:04 +0100, Mike Belopuhov wrote: Hi, IP header is not always aligned since bpf copies out the mbuf chain into the contigous buffer provided by the userland. I've seen this with large packet sizes

operations on nd_prefix list must take rdomain into account

2014-11-26 Thread Mike Belopuhov
More rdomain checks are needed to be able to use the same subnet in a back to back connection between IPv6 rdomains as pointed out by mpi@. OK? diff --git sys/netinet6/nd6.c sys/netinet6/nd6.c index 9616187..d704cd6 100644 --- sys/netinet6/nd6.c +++ sys/netinet6/nd6.c @@ -1264,10 +1264,13 @@

Re: iked control process crash at startup

2014-11-25 Thread Mike Belopuhov
On 25 November 2014 at 13:11, Vincent Gross dermi...@kilob.yt wrote: Hi tech@, I've been using iked for some weeks to tunnel my laptop to home over 3G. Sunday I upgraded my laptop to the latest snapshot; previous upgrade was about 2 or 3 weeks ago. When I started iked, it crashed randomly, as

Re: Simplify in_broadcast()

2014-11-25 Thread Mike Belopuhov
On 20 November 2014 at 15:24, Martin Pieuchot mpieuc...@nolizard.org wrote: Diff below make the function always iterate on all the interfaces. After that I'd like to change ifa_ifwithaddr() to only match unicast addresses and use in_broadcast() in the few places where we also accept broadcast

Re: Rename rt_ifa_addloop(9)

2014-11-24 Thread Mike Belopuhov
On 20 November 2014 at 15:37, Martin Pieuchot mpieuc...@nolizard.org wrote: When I decided to use in6_ifaddloop() for IPv4 I barely though about the name of the function. Recently mikeb@ told me that the name is confusing, especially because I'm trying to turn the loopback hack into local

Re: Make every interface with a watchdog register it's own timeout

2014-11-24 Thread Mike Belopuhov
On Sun, Nov 23, 2014 at 13:39 +0100, Claudio Jeker wrote: On Sun, Nov 23, 2014 at 02:10:24AM +0100, Mike Belopuhov wrote: Hi, This removes the system wide if_slowtimo timeout and lets every interface with a valid if_watchdog method register it's own. The rational is to get rid

Re: Make every interface with a watchdog register it's own timeout

2014-11-24 Thread Mike Belopuhov
On Sun, Nov 23, 2014 at 12:06 +0100, Martin Pieuchot wrote: On 23/11/14(Sun) 02:10, Mike Belopuhov wrote: Hi, This removes the system wide if_slowtimo timeout and lets every interface with a valid if_watchdog method register it's own. The rational is to get rid of the ifnet loop

Trimming tcpdump a bit

2014-11-24 Thread Mike Belopuhov
Hi, I've been trying to fix a bug in tcpdump but the rottenness of the current code base with it's horrendous APIs is just getting in the way. What if we trimmed it a bit, say killed all those pesky 'register' values, kill protocols that we cannot really test (appletalk, fddi, etc.), kill

Re: Trimming tcpdump a bit

2014-11-24 Thread Mike Belopuhov
On 24 November 2014 at 17:20, Mike Belopuhov m...@belopuhov.com wrote: On 24 November 2014 at 16:42, Mike Belopuhov m...@belopuhov.com wrote: Hi, I've been trying to fix a bug in tcpdump but the rottenness of the current code base with it's horrendous APIs is just getting in the way. What

Re: Trimming tcpdump a bit

2014-11-24 Thread Mike Belopuhov
On 24 November 2014 at 16:42, Mike Belopuhov m...@belopuhov.com wrote: Hi, I've been trying to fix a bug in tcpdump but the rottenness of the current code base with it's horrendous APIs is just getting in the way. What if we trimmed it a bit, say killed all those pesky 'register' values

tcpdump: Ethernet header is not dumped with -xX if IP header is unaligned

2014-11-24 Thread Mike Belopuhov
Hi, IP header is not always aligned since bpf copies out the mbuf chain into the contigous buffer provided by the userland. I've seen this with large packet sizes on VLANs. ip_print will then copy the packet but the Ethernet header into the internal buffer so that it can cast it to the IP

Re: tcpdump: Ethernet header is not dumped with -xX if IP header is unaligned

2014-11-24 Thread Mike Belopuhov
On Nov 24, 2014 7:10 PM, Mike Belopuhov m...@belopuhov.com wrote: Hi, IP header is not always aligned since bpf copies out the mbuf chain into the contigous buffer provided by the userland. I've seen this with large packet sizes on VLANs. ip_print will then copy the packet

Make every interface with a watchdog register it's own timeout

2014-11-22 Thread Mike Belopuhov
Hi, This removes the system wide if_slowtimo timeout and lets every interface with a valid if_watchdog method register it's own. The rational is to get rid of the ifnet loop in the softclock context to avoid further complications with concurrent access to the ifnet list. This might also save

Re: Make every interface with a watchdog register it's own timeout

2014-11-22 Thread Mike Belopuhov
On Sun, Nov 23, 2014 at 02:10 +0100, Mike Belopuhov wrote: Hi, This removes the system wide if_slowtimo timeout and lets every interface with a valid if_watchdog method register it's own. The rational is to get rid of the ifnet loop in the softclock context to avoid further complications

remove useless includes in netstat

2014-11-21 Thread Mike Belopuhov
apparently these are not needed and just make my life harder. ok? diff --git usr.bin/netstat/if.c usr.bin/netstat/if.c index f722db23..b07860d 100644 --- usr.bin/netstat/if.c +++ usr.bin/netstat/if.c @@ -36,11 +36,10 @@ #include sys/protosw.h #include sys/socket.h #include sys/sysctl.h

Re: ping6 to Link Local disturbed by pf set skip?

2014-11-18 Thread Mike Belopuhov
On 18 November 2014 15:30, Martin Pieuchot mpieuc...@nolizard.org wrote: On 13/11/14(Thu) 16:41, Stuart Henderson wrote: This changes behaviour of ping6 ff02::1%pppoe0 for me, previously I saw a response to each icmp message in the sequence, now I just see the first response. I am not using

Re: VPLS patch [0/3]: introduction

2014-11-14 Thread Mike Belopuhov
On 14 November 2014 17:26, Rafael Zalamena rzalam...@gmail.com wrote: On Sun, Sep 14, 2014 at 11:48:11PM -0300, Rafael Zalamena wrote: The following mails will contain patchs that implement the VPLS datapath in OpenBSD. Applying all patchs should allow people to configure a network using VPLS

Re: improving OpenBSD's gmac.c...

2014-11-12 Thread Mike Belopuhov
On 10 October 2014 02:39, Damien Miller d...@mindrot.org wrote: On Thu, 9 Oct 2014, Christian Weisgerber wrote: John-Mark Gurney: I also have an implementation of ghash that does a 4 bit lookup table version with the table split between cache lines in p4 at:

Re: 5.6 Icmp6 checksum / pf

2014-11-10 Thread Mike Belopuhov
On Sun, Nov 09, 2014 at 10:17 +0100, Bastien Durel wrote: Hi, I recently upgraded to 5.6, and got problems with icmpv6 I have a gif tunnel for IPv6: [root@fremen root]# ifconfig gif0

Re: iked responds with esp over external ips.

2014-11-05 Thread Mike Belopuhov
On 4 November 2014 17:06, Martin Larsson martin.larss...@gmail.com wrote: Hello! I've setup a tunnel between OpenBSD 5.6 using iked and an openwrt router running strongswan. The tunnel works great with ping and other traffic but traffic between the two external ip's dies. This is a

Re: iked responds with esp over external ips.

2014-11-05 Thread Mike Belopuhov
On 5 November 2014 13:28, Mike Belopuhov m...@belopuhov.com wrote: On 4 November 2014 17:06, Martin Larsson martin.larss...@gmail.com wrote: Hello! I've setup a tunnel between OpenBSD 5.6 using iked and an openwrt router running strongswan. The tunnel works great with ping and other traffic

Re: Multipath for HOST p2p routes

2014-11-04 Thread Mike Belopuhov
On 4 November 2014 12:51, Martin Pieuchot mpieuc...@nolizard.org wrote: How are we suppose to support configuration with multiple p2p interfaces pointing to the same destination address? Right now only one route to host is added. Diff below replaces a hack that move a host route from one p2p

Re: Kill in_iawithaddr()

2014-11-04 Thread Mike Belopuhov
On 4 November 2014 12:52, Martin Pieuchot mpieuc...@nolizard.org wrote: This function is just a wrapper around ifa_ifwithaddr() and I'd prefer to have less function iterating over the global list of interfaces. ok? what's not immediately apparent is that it also makes sure that the address

Re: network pool names

2014-11-04 Thread Mike Belopuhov
On 4 November 2014 13:23, Martin Pieuchot mpieuc...@nolizard.org wrote: Remove pl suffix, ok? ok with a syncache instead of syn

Re: pool page colouring

2014-11-04 Thread Mike Belopuhov
On 5 November 2014 01:12, Mike Belopuhov m...@belopuhov.com wrote: well, first of all, right now this is a rather theoretical gain. we need to test it to understand if it makes things easier. err. i meant to say go faster not easier.

Re: pool page colouring

2014-11-04 Thread Mike Belopuhov
On 5 November 2014 00:38, David Gwynne da...@gwynne.id.au wrote: On 30 Oct 2014, at 07:52, Ted Unangst t...@tedunangst.com wrote: On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: i dunno. im fine with either removing colouring altogether or setting it from something else completely. i

Re: pool page colouring

2014-10-29 Thread Mike Belopuhov
On 29 October 2014 22:52, Ted Unangst t...@tedunangst.com wrote: On Wed, Oct 29, 2014 at 07:25, David Gwynne wrote: i dunno. im fine with either removing colouring altogether or setting it from something else completely. i just want a decision to be made cos right now ph_color isnt set,

Re: pool page colouring

2014-10-28 Thread Mike Belopuhov
On 28 October 2014 17:02, Ted Unangst t...@tedunangst.com wrote: On Tue, Oct 28, 2014 at 16:49, David Gwynne wrote: when i shuffled the locking in pools around, page colouring was left behind. page colouring is where you offset items within a page if you have enough slack space. the previous

Re: A system without interface?

2014-10-14 Thread Mike Belopuhov
On 14 October 2014 11:01, Martin Pieuchot mpieuc...@nolizard.org wrote: On 08/10/14(Wed) 14:29, Martin Pieuchot wrote: I'm looking after the uses of the global list of interface. These ones are pointless, you always have at least one interface on your system. Ok? Anyone? looks good to

Re: RTFREE - rtfree

2014-10-08 Thread Mike Belopuhov
On 8 October 2014 12:24, Martin Pieuchot mpieuc...@nolizard.org wrote: Diff below kills the macro and use the fonction instead since they are equivalent. It also replaces some 0 - NULL where it applies. It does not include the manpage bits, I'll deal with that afterward. I'd appreciate

Re: improving OpenBSD's gmac.c...

2014-10-08 Thread Mike Belopuhov
On 8 October 2014 00:48, John-Mark Gurney j...@funkthat.com wrote: Christian Weisgerber wrote this message on Tue, Oct 07, 2014 at 23:08 +0200: John-Mark Gurney: So, as I was working on FreeBSD's implementation of gmac.c, I noticed that I was able to get a significant speed up by using a

Re: splnet() and SIOCSIFADDR

2014-09-03 Thread Mike Belopuhov
On 3 September 2014 15:53, Martin Pieuchot mpieuc...@nolizard.org wrote: On 03/09/14(Wed) 15:25, Martin Pieuchot wrote: Drivers that need a splnet() protection inside their SIOCSIFADDR generally raise the spl level themselves, so we should not need to do that in in{6,}_ifinit(). One exception

Re: bge(4) Jumbo support for newer chipsets

2014-09-02 Thread Mike Belopuhov
On 2 September 2014 03:54, Brad Smith b...@comstyle.com wrote: On Wed, Aug 27, 2014 at 02:25:27AM -0400, Brad Smith wrote: Looking for some testing of the following diff to add Jumbo support for the BCM5714 / BCM5780 and BCM5717 / BCM5719 / BCM5720 / BCM57765 / BCM57766 chipsets. Here is an

Re: minphys woes

2014-09-01 Thread Mike Belopuhov
On 29 August 2014 22:39, Stefan Fritsch s...@sfritsch.de wrote: On Fri, 29 Aug 2014, Mike Belopuhov wrote: correct me if i'm wrong, but what happens is that bread being a block read reads up to MAXBSIZE which is conveniently set to 64k and you can't create a filesystem with a larger block size

Re: reduce the number of missed PCB cache with tcpbench -su

2014-09-01 Thread Mike Belopuhov
On 29 August 2014 18:01, Damien Miller d...@mindrot.org wrote: What's the benefit of this? This creates a UDP PCB per connection. Otherwise we always rely on matching the wildcard PCB. I've never seen an application do this; I doubt that. However, things like NTP or DNS servers usually

Re: minphys woes

2014-09-01 Thread Mike Belopuhov
On 1 September 2014 13:06, Stefan Fritsch s...@sfritsch.de wrote: On Mon, 1 Sep 2014, Mike Belopuhov wrote: On 29 August 2014 22:39, Stefan Fritsch s...@sfritsch.de wrote: Yes, that seems to be what happens. But if every adapter needs to support transfers of MAXBSIZE == MAXPHYS anyway

Re: reduce the number of missed PCB cache with tcpbench -su

2014-08-31 Thread Mike Belopuhov
Daniel, don't reply anything to Damien just yet. Can you please run a simple test on Monday. Try tcpbench -u -n 2 ip (as in multi- connection test) without your patch and then with the patch and see if behavior is changed. Thanks On 29 August 2014 18:01, Damien Miller d...@mindrot.org wrote:

Re: minphys woes

2014-08-29 Thread Mike Belopuhov
On 29 August 2014 11:26, Stefan Fritsch s...@sfritsch.de wrote: On Fri, 29 Aug 2014, Miod Vallat wrote: sc-sc_xfer_max is computed according to the host's capabilities. What I want to simulate with this diff is a host adapter that can only cope with transfers 64k == MAXPHYS. Back to your

Re: newfs.8

2014-08-29 Thread Mike Belopuhov
On 29 August 2014 08:19, Jason McIntyre j...@kerhand.co.uk wrote: is this correct? i'm not a user myself, but the text states that special, for mount_mfs, is typically that of the primary swap area. how would you even define the swap area without a disklabel? jmc sort of yes. mount_mfs(8)

Re: newfs.8

2014-08-29 Thread Mike Belopuhov
On 29 August 2014 13:44, Jason McIntyre j...@kerhand.co.uk wrote: On Fri, Aug 29, 2014 at 01:39:57PM +0200, Mike Belopuhov wrote: On 29 August 2014 08:19, Jason McIntyre j...@kerhand.co.uk wrote: is this correct? i'm not a user myself, but the text states that special, for mount_mfs

Re: bge(4) Jumbo support for newer chipsets

2014-08-28 Thread Mike Belopuhov
On 28 August 2014 12:32, David Gwynne da...@gwynne.id.au wrote: On 28 Aug 2014, at 3:02 am, Mike Belopuhov m...@belopuhov.com wrote: On 27 August 2014 08:25, Brad Smith b...@comstyle.com wrote: Looking for some testing of the following diff to add Jumbo support for the BCM5714 / BCM5780

Re: let vlan(4) mtu be limited by the parents hardmtu instead of current mtu

2014-08-27 Thread Mike Belopuhov
On 27 August 2014 13:17, David Gwynne da...@gwynne.id.au wrote: On Tue, Aug 26, 2014 at 09:11:14PM -0400, Brad Smith wrote: On 20/08/14 8:03 PM, David Gwynne wrote: sthen@ says this is likely a bit optimistic. while most of our drivers unconditionally configure their max mru, there's some

Re: let vlan(4) mtu be limited by the parents hardmtu instead of current mtu

2014-08-27 Thread Mike Belopuhov
On 27 August 2014 13:23, David Gwynne da...@gwynne.id.au wrote: On Tue, Aug 26, 2014 at 09:11:14PM -0400, Brad Smith wrote: On 20/08/14 8:03 PM, David Gwynne wrote: sthen@ says this is likely a bit optimistic. while most of our drivers unconditionally configure their max mru, there's some

Re: bge(4) Jumbo support for newer chipsets

2014-08-27 Thread Mike Belopuhov
On 27 August 2014 08:25, Brad Smith b...@comstyle.com wrote: Looking for some testing of the following diff to add Jumbo support for the BCM5714 / BCM5780 and BCM5717 / BCM5719 / BCM5720 / BCM57765 / BCM57766 chipsets. i have tested this on Broadcom BCM5719 rev 0x01, unknown BCM5719

Re: pf: once for match rules?

2014-08-20 Thread Mike Belopuhov
On Tue, Aug 12, 2014 at 18:26 +0200, Mike Belopuhov wrote: On Tue, Jul 22, 2014 at 19:03 +0200, Mike Belopuhov wrote: Hi, Before I send a diff for pfctl to disable once on match rules, I've decided to try and see how much work is it to make it actually work. Turns out that I need

/dev/crypto removal (1/3): unlink pseudo device

2014-08-18 Thread Mike Belopuhov
first step is to unlink crypto(4) pseudo device from the architecture dependant character device tables and kernel config files. OK? diff --git sys/arch/alpha/alpha/conf.c sys/arch/alpha/alpha/conf.c index 83cea34..7d103af 100644 --- sys/arch/alpha/alpha/conf.c +++ sys/arch/alpha/alpha/conf.c @@

/dev/crypto removal (2/3): remove kernel support

2014-08-18 Thread Mike Belopuhov
this removes /dev/crypto device interface and public key functionality that is only usable via /dev/crypto. OK? diff --git sys/conf/files sys/conf/files index 3941639..9af78cc 100644 --- sys/conf/files +++ sys/conf/files @@ -870,11 +870,10 @@ file crypto/blf.c (inet ipsec) |

/dev/crypto removal (3/3): userland bits

2014-08-18 Thread Mike Belopuhov
please note that the commented out example usage in etc/MAKEDEV.common remains till someone feels the need to change it. OK? diff --git etc/MAKEDEV.common etc/MAKEDEV.common index bfcd943..b656d46 100644 --- etc/MAKEDEV.common +++ etc/MAKEDEV.common @@ -131,11 +131,10 @@ target(all, wd, 0, 1, 2,

Re: /dev/crypto removal (2/3): remove kernel support

2014-08-18 Thread Mike Belopuhov
On Mon, Aug 18, 2014 at 16:03 +0200, Mike Belopuhov wrote: this removes /dev/crypto device interface and public key functionality that is only usable via /dev/crypto. OK? minor correction: preserve #ifdef _KERNEL in the cryptodev.h. while there are no userland programs including it atm

/dev/crypto removal (3bis): DTYPE_CRYPTO

2014-08-18 Thread Mike Belopuhov
I don't know if we recycle them somehow, but just in case... diff --git sys/sys/file.h sys/sys/file.h index d98118e..64c0f31 100644 --- sys/sys/file.h +++ sys/sys/file.h @@ -67,11 +67,11 @@ struct file { short f_flag; /* see fcntl.h */ #defineDTYPE_VNODE 1 /*

Re: Kill MRT_{ADD,DEL}_BW_UPCALL

2014-08-13 Thread Mike Belopuhov
On 13 August 2014 10:56, Martin Pieuchot mpieuc...@nolizard.org wrote: Our multicast routing code is insert your adjective and for the most part unused. We discussed with claudio@ during t2k13 to rewrite only the parts that people currently use, any volunteer? In the meantime, I'd like to

Re: Fix pppoe(4) with rdomain != 0

2014-08-13 Thread Mike Belopuhov
OK On 13 August 2014 11:56, Martin Pieuchot mpieuc...@nolizard.org wrote: ok? Index: net/if_pppoe.c === RCS file: /home/ncvs/src/sys/net/if_pppoe.c,v retrieving revision 1.40 diff -u -p -r1.40 if_pppoe.c --- net/if_pppoe.c

[regress] convert aes testcase from /dev/crypto

2014-08-13 Thread Mike Belopuhov
in order to deprecate crypto(4) interface regress tests need to be converted. this aes test case actually uses ecb vectors, therefore no chaining is required and the code looks very simple. OK? diff --git regress/sys/crypto/aes/Makefile regress/sys/crypto/aes/Makefile index 459aedb..826d98c

[regress] convert aes-ctr test from /dev/crypto

2014-08-13 Thread Mike Belopuhov
this test is converted the same way jsing@ has recently converted an xts test by pulling in xform.c code. OK? diff --git regress/sys/crypto/aesctr/Makefile regress/sys/crypto/aesctr/Makefile index 31ae500..7310dbc 100644 --- regress/sys/crypto/aesctr/Makefile +++

[regress] convert enc (3des) test from /dev/crypto

2014-08-13 Thread Mike Belopuhov
this one with a bit of cheating however (manual cbc implementation). OK? diff --git regress/sys/crypto/enc/Makefile regress/sys/crypto/enc/Makefile index cc29b32..8725f0c 100644 --- regress/sys/crypto/enc/Makefile +++ regress/sys/crypto/enc/Makefile @@ -1,12 +1,21 @@ # $OpenBSD:

Re: pf: once for match rules?

2014-08-12 Thread Mike Belopuhov
On Tue, Jul 22, 2014 at 19:03 +0200, Mike Belopuhov wrote: Hi, Before I send a diff for pfctl to disable once on match rules, I've decided to try and see how much work is it to make it actually work. Turns out that I need to extend pf_rule_item by 3 pointers to track the match rule ruleset

pf: fixup pf_step_into_anchor to save current anchor rule pointer (2)

2014-07-22 Thread Mike Belopuhov
Hi, This is a second diff and it makes sure that pf_step_into_anchor always saves a pointer to the rule that owns the anchor on the pf anchor stack. There's no reason why we should check for depth here. As a side effect this makes sure that the correct nested anchor gets it's counter bumped

pf: once for match rules?

2014-07-22 Thread Mike Belopuhov
Hi, Before I send a diff for pfctl to disable once on match rules, I've decided to try and see how much work is it to make it actually work. Turns out that I need to extend pf_rule_item by 3 pointers to track the match rule ruleset, anchor rule and the ruleset it belongs to. Here's what this

Re: [PATCH] rdomain support on rc.d

2014-07-11 Thread Mike Belopuhov
On 11 July 2014 10:29, Antoine Jacoutot ajacou...@bsdfrog.org wrote: On Thu, Jul 10, 2014 at 06:51:01PM +0200, Loďc BLOT wrote: Hello all, I use rdomains to split routing domains per company and also separate administration interfaces from routing interfaces on my routers (sshd, bacula,

Re: PF Once rules are not removed from main anchor

2014-07-02 Thread Mike Belopuhov
On 21 June 2014 15:36, Alexandr Nedvedicky alexandr.nedvedi...@oracle.com wrote: Hello, I'm not sure it is the right place to submit patches. Let me know if there is better/more appropriate address for this. during our testing we've found the once rules are not removed, when used in main

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread Mike Belopuhov
On 26 June 2014 08:53, patrick keshishian sids...@boxsoft.com wrote: On Wed, Jun 25, 2014 at 10:01:06PM -0700, patrick keshishian wrote: On Thu, Jun 26, 2014 at 06:37:00AM +0200, Alexander Hall wrote: On 06/25/14 20:52, Bob Beck wrote: If you or someone you love runs an anoncvs server, they

pfctl: better af-to translation specs handling

2014-06-25 Thread Mike Belopuhov
Hi, collapse_redirspec is one of my pet peeve since the af-to support. Unfortunately we didn't put much effort in making it work well back then, but now it is time for a change! Improving upon the last diff here's a collapsed version of the collapse_redirspec, so to speak. Instead of having two

Re: pfctl: stricter redirect specs

2014-06-24 Thread Mike Belopuhov
On Tue, Jun 24, 2014 at 15:07 +0200, Mike Belopuhov wrote: I have carefully tested that and do not expect any unrelated fallout. And for the reasons stated above I don't believe anyone is using this since it's largely error prone. and a regress chunk that avoids using such combination

Re: pf anchor references

2014-06-05 Thread Mike Belopuhov
On Mon, Jun 02, 2014 at 17:51 +0200, Mike Belopuhov wrote: Hi, I've been chasing some bugs in the pfctl anchor code for a couple of weeks and I'm not astonished at how loose the handling is in general. Lot's of rules and checks are being violated by some code paths while honoured by others

Re: Remove a global variable in ip_input

2014-06-04 Thread Mike Belopuhov
On 4 June 2014 12:30, Martin Pieuchot mpieuc...@nolizard.org wrote: ok? sure

Re: in_pcbbind() and in_broadcast/in_iawithaddr

2014-06-04 Thread Mike Belopuhov
On 3 June 2014 09:18, Martin Pieuchot mpieuc...@nolizard.org wrote: On 02/06/14(Mon) 15:45, Martin Pieuchot wrote: This diff is similar to the one that has been committed to handle the SOCK_RAW binding. I'd like to stop using in_iawithaddr() *and* in_broadcast(). Since these functions are

Re: PRU_BIND in raw ip

2014-06-02 Thread Mike Belopuhov
On 28 May 2014 13:36, Martin Pieuchot mpieuc...@nolizard.org wrote: On 28/05/14(Wed) 09:30, Jérémie Courrèges-Anglas wrote: Martin Pieuchot mpieuc...@nolizard.org writes: Diff below replace in_iawithaddr() + in_broadcast() - ifa_ifwithaddr(), that does the same for IPv4 since broadcast

Re: Remove p2p loopback hack in nd6_rtrequest()

2014-05-13 Thread Mike Belopuhov
On Mon, May 12, 2014 at 12:48 +0200, Martin Pieuchot wrote: On 07/05/14(Wed) 12:46, Martin Pieuchot wrote: Diff below stops abusing nd6_rtrequest() for loopback interfaces, which means we can remove the special hack below and reduce the differences with arp_rtrequest(). This diff

Re: snmpd: add backend from bgpd to support multiple routing tables

2014-05-13 Thread Mike Belopuhov
On Mon, Apr 28, 2014 at 14:20 +0200, Mike Belopuhov wrote: This adds ktable code from bgpd to fetch, store and perform lookups in multiple routing tables. Currently it doesn't do anything useful but it's a prerequisite for any future work in this direction. OK to get this in? Any

Re: MI MTU size for lo(4)

2014-05-13 Thread Mike Belopuhov
On 13 May 2014 15:45, Claudio Jeker cje...@diehard.n-r-g.com wrote: With KAME the MTU size of the loopback interface became strange and is actually dependend on the architecture. I see no point in all this just go back to the way it was long long long ago and just use 32k as the MTU. AFAIK all

Re: MI MTU size for lo(4)

2014-05-13 Thread Mike Belopuhov
On 13 May 2014 16:05, Mike Belopuhov m...@belopuhov.com wrote: On 13 May 2014 15:45, Claudio Jeker cje...@diehard.n-r-g.com wrote: With KAME the MTU size of the loopback interface became strange and is actually dependend on the architecture. I see no point in all this just go back to the way

Re: m-m_pkthdr.rcvif and ip6_input()

2014-05-12 Thread Mike Belopuhov
On 12 May 2014 15:12, Martin Pieuchot mpieuc...@nolizard.org wrote: Like the previous diffs, it reduces the number of m-m_pkthdr.rcvif occurrences, this time in ip6_input(). Should be no functional change. Ok? OK

Re: Annoying emacs variable in if_spppsubr.c

2014-05-02 Thread Mike Belopuhov
On 2 May 2014 12:09, Jérémie Courrèges-Anglas j...@wxcvbn.org wrote: This one is bugging me each time I start my Emacs session (because Emacs now asks confirmation for most variables). This one would be useful only with hilit19.el (obsolete) from editors/emacs21... if the size of the file

Re: data modified on freelist, tmpfs-related?

2014-04-30 Thread Mike Belopuhov
On 30 April 2014 15:55, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Wed, 30 Apr 2014 15:38:39 +0200 (CEST) From: Mark Kettenis mark.kette...@xs4all.nl Date: Wed, 30 Apr 2014 13:39:20 +0100 From: Stuart Henderson st...@openbsd.org Seen when running e2fsprogs regression tests with

Re: data modified on freelist, tmpfs-related?

2014-04-30 Thread Mike Belopuhov
On 30 April 2014 16:55, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Mike Belopuhov m...@belopuhov.com Date: Wed, 30 Apr 2014 16:00:45 +0200 On 30 April 2014 15:55, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Wed, 30 Apr 2014 15:38:39 +0200 (CEST) From: Mark Kettenis

snmpd: add backend from bgpd to support multiple routing tables

2014-04-28 Thread Mike Belopuhov
This adds ktable code from bgpd to fetch, store and perform lookups in multiple routing tables. Currently it doesn't do anything useful but it's a prerequisite for any future work in this direction. OK to get this in? diff --git usr.sbin/snmpd/kroute.c usr.sbin/snmpd/kroute.c index

Re: iked + isakmpd on the same machine

2014-04-24 Thread Mike Belopuhov
On 24 April 2014 12:12, Philipp e1c1bac6253dc54a1e89ddc046585...@posteo.net wrote: Am 22.04.2014 17:28 schrieb Mike Belopuhov: more like it's not supported and is not supposed to work. not supposed as in 'not wanted'? not supposed. it's like running nginx and apache at the same time

Re: Kill in_localaddr()

2014-04-24 Thread Mike Belopuhov
On 24 April 2014 16:41, Martin Pieuchot mpieuc...@nolizard.org wrote: in_localaddr() is used only once in our tree and only if the sysctl net.inet.ip.mtudisc is set to 0. It is used to optimize the size of the MSS if the forward address correspond to a host on one of our subnets. Since it's

Re: iked + isakmpd on the same machine

2014-04-24 Thread Mike Belopuhov
On 24 April 2014 20:25, Chris Cappuccio ch...@nmedia.net wrote: Mike Belopuhov [m...@belopuhov.com] wrote: more like it's not supported and is not supposed to work. it's like running nginx and apache at the same time hey, nginx and httpd run concurrently quite fine on different IP addresses

Re: iked + isakmpd on the same machine

2014-04-24 Thread Mike Belopuhov
On 24 April 2014 22:25, Alexander Hall alexan...@beard.se wrote: On 04/24/14 21:53, Stuart Henderson wrote: On 2014/04/24 20:30, Mike Belopuhov wrote: On 24 April 2014 20:25, Chris Cappuccio ch...@nmedia.net wrote: Mike Belopuhov [m...@belopuhov.com] wrote: more like it's not supported

Re: IPv6 DoS sysctl man page additions

2014-04-22 Thread Mike Belopuhov
On 19 April 2014 13:20, Loganaden Velvindron lo...@elandsys.com wrote: On Sat, Apr 19, 2014 at 04:04:30AM -0700, Loganaden Velvindron wrote: Hi All, I'm taking a short break from playing with pf statistics. There were 4 sysctls added from KAME, but the man pages weren't updated accordingly.

Re: iked + isakmpd on the same machine

2014-04-22 Thread Mike Belopuhov
On 22 April 2014 17:13, Philipp e1c1bac6253dc54a1e89ddc046585...@posteo.net wrote: It happened! A remote peer *requires* IKEv2 - and I've to do that on a machine running isakmpd with somewhat 25+ IKEv1 peers. First hurdle: I cannot bind iked to a certain (carp) IP-address. Mad workaround:

Re: snmpd: support for ipNetToMediaTable (ARP table exporting)

2014-04-10 Thread Mike Belopuhov
On Mon, Apr 07, 2014 at 17:03 +0200, Mike Belopuhov wrote: a bit of an update, mainly style changes. one functional change: don't rely on rtm_rmx.rmx_expire to set the F_STATIC flag as rt_getmetrics is not called consistenly (only with RTM_GETs) and besides RTF_STATIC flag is already present

<    1   2   3   4   5   6   7   8   9   10   >