George Sexton wrote:
OK, here is what I believe is the final version of the Mapper code with
support for wildcard matching.
The new code is approximately 14.7% faster, executing the 1,000,000
iteration test loop in 7480 ms versus 8772.5 ms for the original code, a
difference of 1292.5 ms. Times
8775ms
8782ms
Median: 8772.5ms
George Sexton
MH Software, Inc.
http://www.mhsoftware.com/
Voice: 303 438 9585
-Original Message-
From: Peter Rossbach [mailto:[EMAIL PROTECTED]
Sent: Thursday, May 05, 2005 8:40 AM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card
-Original Message-
From: Remy Maucherat [mailto:[EMAIL PROTECTED]
Sent: Wednesday, May 04, 2005 1:41 PM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card Aliases
George Sexton wrote:
The original code you submitted looks quite bad so I don't trust your
The measurement was calculated by taking the median reading of 10
consecutive executions.
Just for your edification they were:
New Code:
7373ms
7395ms
7383ms
7370ms
7384ms
7385ms
7395ms
7376ms
7378ms
7393ms
Median: 7383.5ms
Old code:
8561ms
8560ms
8771ms
8774ms
8771ms
8767ms
8860ms
8775ms
Great news,
can you post your new code that we can test it also?
Many thanks
Peter
George Sexton schrieb:
The measurement was calculated by taking the median reading of 10
consecutive executions.
Just for your edification they were:
New Code:
7373ms
7395ms
7383ms
7370ms
7384ms
7385ms
7395ms
7376ms
George Sexton wrote:
Let me see what I can do.
So that I don't get a too bad reputation, here's an algorithm idea I
thought about:
- first, why use *.foo.com ? I'd say .foo.com is better (the algo will
use it)
- use a separate array for wildcard host names, where they are stored
reversed (ex:
.
George Sexton
MH Software, Inc.
http://www.mhsoftware.com/
Voice: 303 438 9585
-Original Message-
From: Remy Maucherat [mailto:[EMAIL PROTECTED]
Sent: Wednesday, May 04, 2005 5:45 AM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card Aliases
George Sexton wrote
George Sexton wrote:
Rémy,
I'll look at those. So far, I re-wrote the algorithm, and I've got it
improved.
The old algorithm (5.5.9) takes 8772 ms on a P3 600 ( My earlier timed
reports were approximate but relative).
My current version of the algorithm taks 7383 ms. This is for the million
-Original Message-
From: Remy Maucherat [mailto:[EMAIL PROTECTED]
Sent: Wednesday, May 04, 2005 11:45 AM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card Aliases
George Sexton wrote:
Rémy,
I'll look at those. So far, I re-wrote the algorithm, and
I've got
George Sexton wrote:
You should read my message more carefully.
I re-wrote it. It's 15% faster than the current 5.5.9 code. Elapsed time
drops from 8772 ms for the stock 5.5.9 code to 7383ms for the revised code.
You know, I bit my lip and re-wrote the algorithm, even though I think it's
a case
9585
-Original Message-
From: Peter Rossbach [mailto:[EMAIL PROTECTED]
Sent: Monday, May 02, 2005 10:28 PM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card Aliases
Hey Geroge,
I review the mapper patch. Cool!
I think getHosts is a little bit strange
George Sexton wrote:
I have completed the coding in o.a.t.u.http.mapper.Mapper to implement
wild-card aliases.
If a request for a host is made, and that host is not found, the code tests
the host and aliases list and looks for wild-cards.
So, a host name of www.mydomain.com would match an alias of
On 5/2/05, George Sexton [EMAIL PROTECTED] wrote:
I have completed the coding in o.a.t.u.http.mapper.Mapper to implement
wild-card aliases.
If a request for a host is made, and that host is not found, the code tests
the host and aliases list and looks for wild-cards.
So, a host name of
List
Subject: Re: Code Submission - Wild Card Aliases
George Sexton wrote:
I have completed the coding in o.a.t.u.http.mapper.Mapper to implement
wild-card aliases.
If a request for a host is made, and that host is not found, the code
tests
the host and aliases list and looks for wild
: Code Submission - Wild Card Aliases
George Sexton wrote:
I have completed the coding in o.a.t.u.http.mapper.Mapper
to implement
wild-card aliases.
If a request for a host is made, and that host is not
found, the code tests
the host and aliases list and looks for wild-cards
-
From: Remy Maucherat [mailto:[EMAIL PROTECTED]
Sent: Tuesday, May 03, 2005 8:04 AM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card Aliases
George Sexton wrote:
I have completed the coding in o.a.t.u.http.mapper.Mapper
to implement
wild-card aliases
-Original Message-
From: Remy Maucherat [mailto:[EMAIL PROTECTED]
Sent: Tuesday, May 03, 2005 10:04 AM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card Aliases
George Sexton wrote:
I have completed the coding in o.a.t.u.http.mapper.Mapper to implement
wild-card
Yoav Shapira wrote:
Hi,
The performance impact is not that big. If it was a configurable option,
e.g. enableAliasWildcardMatching, turned off by default, I'd be OK with it.
It's not an excuse to write inefficient code. Replicate that kind of
stuff all over the place and you'll see the overall
Developers List'
Subject: RE: Code Submission - Wild Card Aliases
Hi,
The performance impact is not that big. If it was a
configurable option,
e.g. enableAliasWildcardMatching, turned off by default, I'd
be OK with it.
Yoav
-Original Message-
From: Remy Maucherat [mailto:[EMAIL
Hey Remy and George,
I have analyse the patch and find it very usefull. When you have a lot
of customer at one
tomcat with a lot of virtual hosts and customer can change there
subdomains mapping, this * Alias Feature is a great help.
I have the next two week limit time, but I thing we can
://www.mhsoftware.com/
Voice: 303 438 9585
-Original Message-
From: Remy Maucherat [mailto:[EMAIL PROTECTED]
Sent: Tuesday, May 03, 2005 8:04 AM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card Aliases
George Sexton wrote:
I have completed the coding
George Sexton wrote:
0.05% lower is hardly a sufficient reason to reject this.
Sure, but since it's my decision and not yours, it's a -1 at the moment.
Please read my reply to Yoav. Again, you like the use case, while I
think it is useless.
Rémy
??
Jin Yu [EMAIL PROTECTED] :
On 5/2/05, George Sexton wrote:
I have completed the coding in o.a.t.u.http.mapper.Mapper to implement
wild-card aliases.
If a request for a host is made, and that host is not found, the code tests
the host and aliases list and looks for wild-cards.
So, a
AM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card Aliases
George Sexton wrote:
I have completed the coding in o.a.t.u.http.mapper.Mapper
to implement
wild-card aliases.
If a request for a host is made, and that host is not
found, the code
Peter Rossbach wrote:
I also thing that the impact is small but the feature is very usefull.
A connector option enableAliasWildcardMatching was a good idea.
+1 for the patch again.
-1 for it.
Rémy
-
To unsubscribe, e-mail: [EMAIL
George Sexton wrote:
OK, if I'm hearing (almost everyone) the issues to address are:
1) Sync getHosts() and getContextNames()
2) Figure out some sort of rate-limiting mechanism to limit DOS -
Perhaps this should be configurable with # 3 below.
Your feature is uselss, so try to reduce the
- Original Message -
From: Remy Maucherat [EMAIL PROTECTED]
To: Tomcat Developers List tomcat-dev@jakarta.apache.org
Sent: Tuesday, May 03, 2005 10:44 AM
Subject: Re: Code Submission - Wild Card Aliases
Peter Rossbach wrote:
I also thing that the impact is small but the feature is very
Let me see what I can do.
George Sexton
MH Software, Inc.
http://www.mhsoftware.com/
Voice: 303 438 9585
-Original Message-
From: Bill Barker [mailto:[EMAIL PROTECTED]
Sent: Tuesday, May 03, 2005 1:32 PM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card Aliases
Hey Geroge,
I review the mapper patch. Cool!
I think getHosts is a little bit strange:
What you think about this:
public String[] getHosts() {
Host[] hosts ;
synchronized(this) {
hosts=new Host[hmHosts.size()];
hosts=(Host[])hmHosts.values().toArray(hosts);
...
George Sexton
MH Software, Inc.
http://www.mhsoftware.com/
Voice: 303 438 9585
-Original Message-
From: Peter Rossbach [mailto:[EMAIL PROTECTED]
Sent: Monday, May 02, 2005 10:28 PM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card Aliases
Hey Geroge,
I
30 matches
Mail list logo
