Re: Desktop Meecrowave extension contribution

2018-02-02 Thread Mark Struberg
Hi Aaron! This sounds like extremely useful work! I hope you enjoyed digging into OWB and Meecrowave and of course we do highly welcome your contributions back to the project :) Is the code available anywhere already? Looking forward to work with you! @Romain incubator whould be an overkill for

Re: Support of JAX-RS 2.1 SSE using CXF

2018-02-02 Thread Mark Struberg
Hi folks! Just one minor point: if you add anything from cxf then you might likely add it to the Meecrowave libs directly. The reason is that CXF does not use the ThreadContextClassLoader when looking for it's own SPI implementations. So if you have cxf-core in meecrowave-lib and the cxf jax-ws

Re: Desktop Meecrowave extension contribution

2018-02-02 Thread Romain Manni-Bucau
I see, my fear about desktop API is it doesn't work well (browse() worked 50% of the times on the computers I got in the last 5 years for instance, I didnt set it up, right, but also not a great default). That said we can easily replace it by an exec with config + good default guess algorithm. The

Re: Desktop Meecrowave extension contribution

2018-02-02 Thread Aaron Anderson
Hi Mark and Romain, I will go ahead and create a github fork of meecrowave and commit my current work there. I was looking for affirmation that this contribution could possibly be accepted before I went through the effort of renaming all of the packages. If the contribution is accepted that will

Re: Desktop Meecrowave extension contribution

2018-02-02 Thread Romain Manni-Bucau
quick advice: maybe start by the already agreed parts and do it iteratively instead of putting it all at once, will allow to merge faster ;) side note: we are in the process of planning a release, not sure it can be in but dont worry if not we can release later without issues Romain Manni-Bucau

Re: Desktop Meecrowave extension contribution

2018-02-02 Thread Aaron Anderson
Hi Mark, My experience with creating a contribution was overall positive. I did encounter a few of issues that I had to work around: 1) meecrowave.properties and CLI binding - I have several options classes that I registered as Cli.Options service loader extensions and I was able to obtain the c

Re: Desktop Meecrowave extension contribution

2018-02-02 Thread Romain Manni-Bucau
Hi Aaron, 2018-02-02 15:12 GMT+01:00 Aaron Anderson : > Hi Mark, > > My experience with creating a contribution was overall positive. I did > encounter a few of issues that I had to work around: > > 1) meecrowave.properties and CLI binding - I have several options classes > that I registered as

Re: Desktop Meecrowave extension contribution

2018-02-02 Thread Mark Struberg
> Am 02.02.2018 um 09:25 schrieb Romain Manni-Bucau : > > the update is very cool and I'm fine with Mark saying we do it here then > maybe generify it. I thought about the update a bit longer. A core issue with updates is to _not_ pick up faulty/dangerous updates. So we might do something li

Re: Desktop Meecrowave extension contribution

2018-02-02 Thread Mark Struberg
+1 having a iCLA is a good thing to start ;) LieGrue, strub > Am 02.02.2018 um 14:43 schrieb Aaron Anderson : > > Hi Mark and Romain, > > I will go ahead and create a github fork of meecrowave and commit my current > work there. I was looking for affirmation that this contribution could > po

Re: Desktop Meecrowave extension contribution

2018-02-02 Thread Mark Struberg
With 'Extension' do you mean CDI Extension? I was thinking about this the other day and thought it might be cool to have an exclude list in OWB directly. So with the openwebbeans.properties you might be able to have a list of fqcn of the Extensions to ignore. Not sure whether this is in the dir

Re: Desktop Meecrowave extension contribution

2018-02-02 Thread Romain Manni-Bucau
Mw extension ;) Le 2 févr. 2018 21:03, "Mark Struberg" a écrit : > With 'Extension' do you mean CDI Extension? > > I was thinking about this the other day and thought it might be cool to > have an exclude list in OWB directly. > So with the openwebbeans.properties you might be able to have a lis