Re: Java 11 support

2019-01-25 Thread Yasser Zamani
ler. >>> >>> >>> Am 23.01.2019 um 08:17 schrieb Yasser Zamani: >>>>> -Original Message- >>>>> From: Sebastian Götz >>>>> Sent: Thursday, January 17, 2019 4:41 PM >>>>> To: user@struts.apache.org >>

Re: Java 11 support

2019-01-25 Thread Sebastian Götz
struts2 2.5.2 and 2.5.20 or a matter of the >> Java 11 compiler. >> >> >> Am 23.01.2019 um 08:17 schrieb Yasser Zamani: >>>> -Original Message- >>>> From: Sebastian Götz >>>> Sent: Thursday, January 17, 2019 4:41 PM >>>

Re: Java 11 support

2019-01-24 Thread Yasser Zamani
1.2019 um 08:17 schrieb Yasser Zamani: >> >>> -Original Message- >>> From: Sebastian Götz >>> Sent: Thursday, January 17, 2019 4:41 PM >>> To: user@struts.apache.org >>> Subject: Re: Java 11 support >>> >>> Hi folks, >

Re: Java 11 support

2019-01-24 Thread Sebastian Götz
Yasser Zamani: > >> -Original Message- >> From: Sebastian Götz >> Sent: Thursday, January 17, 2019 4:41 PM >> To: user@struts.apache.org >> Subject: Re: Java 11 support >> >> Hi folks, >> >> it appears that there is some work left

Re: Java 11 support

2019-01-24 Thread Yasser Zamani
On 1/24/2019 10:28 AM, Lukasz Lenart wrote: > śr., 23 sty 2019 o 15:49 Yasser Zamani napisał(a): >> I'm not sure if I get your point correctly but I didn't change `target` in >> [1]. >> >> If you meant the user's itself java 11 compiled classes structure, to double >> verify if it works, with

Re: Java 11 support

2019-01-23 Thread Sebastian Götz
I agree with Lukasz. That's the way to do it. Am 24.01.2019 um 07:58 schrieb Lukasz Lenart: > śr., 23 sty 2019 o 15:49 Yasser Zamani napisał(a): >> I'm not sure if I get your point correctly but I didn't change `target` in >> [1]. >> >> If you meant the user's itself java 11 compiled classes

Re: Java 11 support

2019-01-23 Thread Lukasz Lenart
śr., 23 sty 2019 o 15:49 Yasser Zamani napisał(a): > I'm not sure if I get your point correctly but I didn't change `target` in > [1]. > > If you meant the user's itself java 11 compiled classes structure, to double > verify if it works, with [1]'s local branch with a few local changes into >

RE: Java 11 support

2019-01-23 Thread Yasser Zamani
>-Original Message- >From: Lukasz Lenart >Sent: Wednesday, January 23, 2019 4:59 PM >To: Struts Users Mailing List >Subject: Re: Java 11 support > >śr., 23 sty 2019 o 14:10 Yasser Zamani napisał(a): >> >I would start with detecting a proper Java ver

Re: Java 11 support

2019-01-23 Thread Lukasz Lenart
śr., 23 sty 2019 o 14:10 Yasser Zamani napisał(a): > >I would start with detecting a proper Java version first. The additional > >constant > >will introduce unneeded burden for users to control it. > > Fortunately it seems it isn't required. Locally all tests are passing here > with all java

RE: Java 11 support

2019-01-23 Thread Yasser Zamani
>-Original Message- >From: Lukasz Lenart >Sent: Wednesday, January 23, 2019 11:34 AM >To: Struts Users Mailing List >Subject: Re: Java 11 support > >śr., 23 sty 2019 o 08:35 Yasser Zamani napisał(a): >> I would prefer to allow user to optionally override th

Re: Java 11 support

2019-01-23 Thread Lukasz Lenart
śr., 23 sty 2019 o 08:35 Yasser Zamani napisał(a): > I would prefer to allow user to optionally override the default Opcodes.ASM5 > via a constant in struts.xml e.g. value=" Opcodes.ASM7"/>, Or more better, to think if it's possible to > determine it at runtime via user's runtime context e.g.

RE: Java 11 support

2019-01-22 Thread Yasser Zamani
>-Original Message- >From: Lukasz Lenart >Sent: Tuesday, January 22, 2019 12:03 PM >To: Struts Users Mailing List >Subject: Re: Java 11 support > >Ok, thanks. I see your point now, but this can be hard to support as we must >support Java 7 (or Java

Re: Java 11 support

2019-01-22 Thread Sebastian Götz
@struts.apache.org Subject: Re: Java 11 support Hi folks, it appears that there is some work left in the convention plugin. As I can see from my IVY resolve process this plugin drags in asm 5.2. From its sources it looks like it supports class version up to 1.8 (class version 52). As we compile with JDK

RE: Java 11 support

2019-01-22 Thread Yasser Zamani
>-Original Message- >From: Paul Zepernick >Sent: Friday, January 18, 2019 4:24 PM >To: Struts Users Mailing List >Subject: RE: Java 11 support > >I can confirm that this was the same error I was seeing when trying Java 11 >using >Struts 2.5.18. It is

RE: Java 11 support

2019-01-22 Thread Yasser Zamani
>-Original Message- >From: Sebastian Götz >Sent: Thursday, January 17, 2019 4:41 PM >To: user@struts.apache.org >Subject: Re: Java 11 support > >Hi folks, > >it appears that there is some work left in the convention plugin. As I can see >from >my IVY

Re: Java 11 support

2019-01-22 Thread Lukasz Lenart
Great, thanks a lot! wt., 22 sty 2019 o 10:36 Sebastian Götz napisał(a): > > Okay, > > I have filed a JIRA issue: https://issues.apache.org/jira/browse/WW-5005. > > Am 22.01.2019 um 09:32 schrieb Lukasz Lenart: > > Ok, thanks. I see your point now, but this can be hard to support as > > we must

Re: Java 11 support

2019-01-22 Thread Sebastian Götz
Okay, I have filed a JIRA issue: https://issues.apache.org/jira/browse/WW-5005. Am 22.01.2019 um 09:32 schrieb Lukasz Lenart: Ok, thanks. I see your point now, but this can be hard to support as we must support Java 7 (or Java 8 in case of Struts 2.6) and at the same time Java 11 - I think we

Re: Java 11 support

2019-01-22 Thread Lukasz Lenart
n pluggin on the > startup of the server when it scans for actions to configure Struts. It is > not a compile issue, but happening at runtime. > > Paul > > -Original Message- > From: Sebastian Götz > Sent: Friday, January 18, 2019 3:30 AM > To: user@struts.apach

RE: Java 11 support

2019-01-18 Thread Paul Zepernick
Message- From: Sebastian Götz Sent: Friday, January 18, 2019 3:30 AM To: user@struts.apache.org Subject: Re: Java 11 support NOTICE: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe

Re: Java 11 support

2019-01-18 Thread Sebastian Götz
In the end: yes. Although we are building with ANT and IVY. But the compiler levels are specified as 11, yes. I do not know how to do it with maven. But it woul dbe relevant for the tests of the convention plugin to analyse some Struts2 action class with class version 55. Am 18.01.2019 um

Re: Java 11 support

2019-01-18 Thread Lukasz Lenart
nfig.java:270) > >>>>at > >>>> > >>>> > >> > org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251) > >>>>at > >>>> > >>>> > >> > org.apache.catali

Re: Java 11 support

2019-01-18 Thread Sebastian Götz
schrieb Yasser Zamani: Hi Sebastian, Yes the release will be ready this month hopefully this week already ☺ Kind Regards. From: Sebastian Götz Sent: Tuesday, January 15, 2019 10:51 AM To: Yasser Zamani Subject: Re: Java 11 support Hi Yasser, sure! We are not in a hurry :-) but really looking

Re: Java 11 support

2019-01-17 Thread Lukasz Lenart
Host.java:831) > >> at > >> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183) > >> at > >> > >> > org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432) > >> at > >> >

Re: Java 11 support

2019-01-17 Thread Sebastian Götz
Subject: Re: Java 11 support Hi Yasser, sure! We are not in a hurry :-) but really looking forward to this release. I tried with the 2.5.18 yesterday. But then I will await the 2.5.20 release with pleasure. I know this sort of question sucks but will the release be ready this month already

Re: Java 11 support

2019-01-17 Thread Lukasz Lenart
ssorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:566) > at org.apache.catalina.startup.Bootstrap.start(

Re: Java 11 support

2019-01-17 Thread Sebastian Götz
Regards. From: Sebastian Götz Sent: Tuesday, January 15, 2019 10:51 AM To: Yasser Zamani Subject: Re: Java 11 support Hi Yasser, sure! We are not in a hurry :-) but really looking forward to this release. I tried with the 2.5.18 yesterday. But then I will await the 2.5.20 release with pleasure

Re: Java 11 support

2019-01-15 Thread Sebastian Götz
Great to hear that! Am 15.01.2019 um 09:37 schrieb Yasser Zamani: Hi Sebastian, Yes the release will be ready this month hopefully this week already ☺ Kind Regards. From: Sebastian Götz Sent: Tuesday, January 15, 2019 10:51 AM To: Yasser Zamani Subject: Re: Java 11 support Hi Yasser

RE: Java 11 support

2019-01-15 Thread Yasser Zamani
Hi Sebastian, Yes the release will be ready this month hopefully this week already ☺ Kind Regards. From: Sebastian Götz Sent: Tuesday, January 15, 2019 10:51 AM To: Yasser Zamani Subject: Re: Java 11 support Hi Yasser, sure! We are not in a hurry :-) but really looking forward

Re: Java 11 support

2019-01-14 Thread Lukasz Lenart
pon., 14 sty 2019 o 08:43 Sebastian Götz napisał(a): > I searched through the website and the issue tracker to find any roadmap > info concerning Java 11 support. > At the moment I try upgrading our webapp to Tomcat 9 with OpenJDK 11. I > now from past upgrades that we had to use a

Re: Java 11 support

2019-01-14 Thread Yasser Zamani
Hi Sebastian, I'm pleased to announce it seems we were able to add both java 9 and 11 supports into Struts 2.5.20. Could you please wait a few days for its release and then test the bits? It currently can pass all tests with all jdks (see [1]) but it's so great if you will be able to test it in