Re: Java 11 support

[Yasser Zamani]

Hello and Thank you Sebastian!

Could you please continue with this workaround: downgrade OGNL to 3.1.18.

 ognl
 ognl
 3.1.18

and report if any further issue emerges? If so it's so great to fix them
as well for 2.5.21. If not, then, it's an another evidence to merge [1],
I think :)

Sincerely Yours,
Yasser.

[1] https://github.com/apache/struts/pull/315

On 1/25/2019 12:20 PM, Sebastian Götz wrote:
> Hey guys,
> 
> I can tell you now that my other problems or not related to the ASM
> configuration or Java 11.
> In the Apache JIRA I have created another issues
> (https://issues.apache.org/jira/browse/WW-5006) which is related to OGNL
> accessing static fields.
> 
> Kind regards,
> 
> Sebastian
> 
> Am 24.01.2019 um 12:13 schrieb Yasser Zamani:
>> Hi Sebastian, thanks again for your time to feed back! It's really a
>> great help.
>>
>> Regarding the web app doesn't work, it always a good practice to enable
>> devMode and set log mode to warn or at next step to debug.
>>
>> Kind Regards.
>>
>> On 1/24/2019 2:11 PM, Sebastian Götz wrote:
>>> Hello Yasser,
>>>
>>> I have followed your instructions. The exceptions are gone although my
>>> webapp does not work either.
>>> But I need more time to figure out whether this is a general
>>> compatibility issue between struts2 2.5.2 and 2.5.20 or a matter of the
>>> Java 11 compiler.
>>>
>>>
>>> Am 23.01.2019 um 08:17 schrieb Yasser Zamani:
>>>>> -Original Message-
>>>>> From: Sebastian Götz 
>>>>> Sent: Thursday, January 17, 2019 4:41 PM
>>>>> To: user@struts.apache.org
>>>>> Subject: Re: Java 11 support
>>>>>
>>>>> Hi folks,
>>>>>
>>>>> it appears that there is some work left in the convention plugin. As I 
>>>>> can see from
>>>>> my IVY resolve process this plugin drags in asm 5.2. From its sources it 
>>>>> looks like it
>>>>> supports class version up to 1.8 (class version 52).
>>>>> As we compile with JDK 11 already (class version 55) we get a lot of these
>>>>> exceptions:
>>>>>
>>>>>  java.lang.IllegalArgumentException
>>>>>     at org.objectweb.asm.ClassReader.(Unknown Source)
>>>>>     at org.objectweb.asm.ClassReader.(Unknown Source)
>>>>>     at org.objectweb.asm.ClassReader.(Unknown Source)
>>>>>     at
>>>>> org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFind
>>>>> er.java:461)
>>>>>     at
>>>>> org.apache.struts2.convention.DefaultClassFinder.(DefaultClassFinder.java:
>>>>> 93)
>>>>>     at
>>>>> org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildClassFind
>>>>> er(PackageBasedActionConfigBuilder.java:395)
>>>>>     at
>>>>> org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActions(Pa
>>>>> ckageBasedActionConfigBuilder.java:377)
>>>>>     at
>>>>> org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionCo
>>>>> nfigs(PackageBasedActionConfigBuilder.java:333)
>>>>>     at
>>>>> org.apache.struts2.convention.ClasspathPackageProvider.loadPackages(Classpat
>>>>> hPackageProvider.java:52)
>>>>>     at
>>>>> com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(D
>>>>> efaultConfiguration.java:206)
>>>>>     at
>>>>> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(Con
>>>>> figurationManager.java:66)
>>>>>     at
>>>>> org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:957)
>>>>>     at
>>>>> org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.j
>>>>> ava:463)
>>>>>     at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:496)
>>>>>     at
>>>>> org.apache.struts2.dispatcher.InitOperations.initDispatcher(InitOperations.java:7
>>>>> 3)
>>>>>     at
>>>>> org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrep
>>>>> areAndExecuteFilter.java:61)
>>>>>     at
>>>>> eu.inform.servlet.context.URIExcludeFilter.init(URIExcludeFilter.java:37)
>>>>>     at
>>>>> org.apache.catalina.core.Applicat

Re: Java 11 support

[Sebastian Götz]

Hey guys,

I can tell you now that my other problems or not related to the ASM
configuration or Java 11.
In the Apache JIRA I have created another issues
(https://issues.apache.org/jira/browse/WW-5006) which is related to OGNL
accessing static fields.

Kind regards,

Sebastian

Am 24.01.2019 um 12:13 schrieb Yasser Zamani:
> Hi Sebastian, thanks again for your time to feed back! It's really a
> great help.
>
> Regarding the web app doesn't work, it always a good practice to enable
> devMode and set log mode to warn or at next step to debug.
>
> Kind Regards.
>
> On 1/24/2019 2:11 PM, Sebastian Götz wrote:
>> Hello Yasser,
>>
>> I have followed your instructions. The exceptions are gone although my
>> webapp does not work either.
>> But I need more time to figure out whether this is a general
>> compatibility issue between struts2 2.5.2 and 2.5.20 or a matter of the
>> Java 11 compiler.
>>
>>
>> Am 23.01.2019 um 08:17 schrieb Yasser Zamani:
>>>> -Original Message-
>>>> From: Sebastian Götz 
>>>> Sent: Thursday, January 17, 2019 4:41 PM
>>>> To: user@struts.apache.org
>>>> Subject: Re: Java 11 support
>>>>
>>>> Hi folks,
>>>>
>>>> it appears that there is some work left in the convention plugin. As I can 
>>>> see from
>>>> my IVY resolve process this plugin drags in asm 5.2. From its sources it 
>>>> looks like it
>>>> supports class version up to 1.8 (class version 52).
>>>> As we compile with JDK 11 already (class version 55) we get a lot of these
>>>> exceptions:
>>>>
>>>>  java.lang.IllegalArgumentException
>>>>     at org.objectweb.asm.ClassReader.(Unknown Source)
>>>>     at org.objectweb.asm.ClassReader.(Unknown Source)
>>>>     at org.objectweb.asm.ClassReader.(Unknown Source)
>>>>     at
>>>> org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFind
>>>> er.java:461)
>>>>     at
>>>> org.apache.struts2.convention.DefaultClassFinder.(DefaultClassFinder.java:
>>>> 93)
>>>>     at
>>>> org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildClassFind
>>>> er(PackageBasedActionConfigBuilder.java:395)
>>>>     at
>>>> org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActions(Pa
>>>> ckageBasedActionConfigBuilder.java:377)
>>>>     at
>>>> org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionCo
>>>> nfigs(PackageBasedActionConfigBuilder.java:333)
>>>>     at
>>>> org.apache.struts2.convention.ClasspathPackageProvider.loadPackages(Classpat
>>>> hPackageProvider.java:52)
>>>>     at
>>>> com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(D
>>>> efaultConfiguration.java:206)
>>>>     at
>>>> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(Con
>>>> figurationManager.java:66)
>>>>     at
>>>> org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:957)
>>>>     at
>>>> org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.j
>>>> ava:463)
>>>>     at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:496)
>>>>     at
>>>> org.apache.struts2.dispatcher.InitOperations.initDispatcher(InitOperations.java:7
>>>> 3)
>>>>     at
>>>> org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrep
>>>> areAndExecuteFilter.java:61)
>>>>     at
>>>> eu.inform.servlet.context.URIExcludeFilter.init(URIExcludeFilter.java:37)
>>>>     at
>>>> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig
>>>> .java:270)
>>>>     at
>>>> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig
>>>> .java:251)
>>>>     at
>>>> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.ja
>>>> va:102)
>>>>     at
>>>> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4491)
>>>>     at
>>>> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:51
>>>> 35)
>>>>     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>>>>     at
>>>> org.apach

Re: Java 11 support

[Yasser Zamani]

Hi Sebastian, thanks again for your time to feed back! It's really a
great help.

Regarding the web app doesn't work, it always a good practice to enable
devMode and set log mode to warn or at next step to debug.

Kind Regards.

On 1/24/2019 2:11 PM, Sebastian Götz wrote:
> Hello Yasser,
> 
> I have followed your instructions. The exceptions are gone although my
> webapp does not work either.
> But I need more time to figure out whether this is a general
> compatibility issue between struts2 2.5.2 and 2.5.20 or a matter of the
> Java 11 compiler.
> 
> 
> Am 23.01.2019 um 08:17 schrieb Yasser Zamani:
>>
>>> -Original Message-
>>> From: Sebastian Götz 
>>> Sent: Thursday, January 17, 2019 4:41 PM
>>> To: user@struts.apache.org
>>> Subject: Re: Java 11 support
>>>
>>> Hi folks,
>>>
>>> it appears that there is some work left in the convention plugin. As I can 
>>> see from
>>> my IVY resolve process this plugin drags in asm 5.2. From its sources it 
>>> looks like it
>>> supports class version up to 1.8 (class version 52).
>>> As we compile with JDK 11 already (class version 55) we get a lot of these
>>> exceptions:
>>>
>>>  java.lang.IllegalArgumentException
>>>     at org.objectweb.asm.ClassReader.(Unknown Source)
>>>     at org.objectweb.asm.ClassReader.(Unknown Source)
>>>     at org.objectweb.asm.ClassReader.(Unknown Source)
>>>     at
>>> org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFind
>>> er.java:461)
>>>     at
>>> org.apache.struts2.convention.DefaultClassFinder.(DefaultClassFinder.java:
>>> 93)
>>>     at
>>> org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildClassFind
>>> er(PackageBasedActionConfigBuilder.java:395)
>>>     at
>>> org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActions(Pa
>>> ckageBasedActionConfigBuilder.java:377)
>>>     at
>>> org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionCo
>>> nfigs(PackageBasedActionConfigBuilder.java:333)
>>>     at
>>> org.apache.struts2.convention.ClasspathPackageProvider.loadPackages(Classpat
>>> hPackageProvider.java:52)
>>>     at
>>> com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(D
>>> efaultConfiguration.java:206)
>>>     at
>>> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(Con
>>> figurationManager.java:66)
>>>     at
>>> org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:957)
>>>     at
>>> org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.j
>>> ava:463)
>>>     at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:496)
>>>     at
>>> org.apache.struts2.dispatcher.InitOperations.initDispatcher(InitOperations.java:7
>>> 3)
>>>     at
>>> org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrep
>>> areAndExecuteFilter.java:61)
>>>     at
>>> eu.inform.servlet.context.URIExcludeFilter.init(URIExcludeFilter.java:37)
>>>     at
>>> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig
>>> .java:270)
>>>     at
>>> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig
>>> .java:251)
>>>     at
>>> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.ja
>>> va:102)
>>>     at
>>> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4491)
>>>     at
>>> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:51
>>> 35)
>>>     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>>>     at
>>> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432
>>> )
>>>     at
>>> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422
>>> )
>>>     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>>>     at
>>> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorServ
>>> ice.java:75)
>>>     at
>>> java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorS
>>> ervice.java:140)
>>>     at
>>> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
>>

Re: Java 11 support

[Sebastian Götz]

Hello Yasser,

I have followed your instructions. The exceptions are gone although my
webapp does not work either.
But I need more time to figure out whether this is a general
compatibility issue between struts2 2.5.2 and 2.5.20 or a matter of the
Java 11 compiler.


Am 23.01.2019 um 08:17 schrieb Yasser Zamani:
>
>> -Original Message-
>> From: Sebastian Götz 
>> Sent: Thursday, January 17, 2019 4:41 PM
>> To: user@struts.apache.org
>> Subject: Re: Java 11 support
>>
>> Hi folks,
>>
>> it appears that there is some work left in the convention plugin. As I can 
>> see from
>> my IVY resolve process this plugin drags in asm 5.2. From its sources it 
>> looks like it
>> supports class version up to 1.8 (class version 52).
>> As we compile with JDK 11 already (class version 55) we get a lot of these
>> exceptions:
>>
>>  java.lang.IllegalArgumentException
>>     at org.objectweb.asm.ClassReader.(Unknown Source)
>>     at org.objectweb.asm.ClassReader.(Unknown Source)
>>     at org.objectweb.asm.ClassReader.(Unknown Source)
>>     at
>> org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFind
>> er.java:461)
>>     at
>> org.apache.struts2.convention.DefaultClassFinder.(DefaultClassFinder.java:
>> 93)
>>     at
>> org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildClassFind
>> er(PackageBasedActionConfigBuilder.java:395)
>>     at
>> org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActions(Pa
>> ckageBasedActionConfigBuilder.java:377)
>>     at
>> org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionCo
>> nfigs(PackageBasedActionConfigBuilder.java:333)
>>     at
>> org.apache.struts2.convention.ClasspathPackageProvider.loadPackages(Classpat
>> hPackageProvider.java:52)
>>     at
>> com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(D
>> efaultConfiguration.java:206)
>>     at
>> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(Con
>> figurationManager.java:66)
>>     at
>> org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:957)
>>     at
>> org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.j
>> ava:463)
>>     at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:496)
>>     at
>> org.apache.struts2.dispatcher.InitOperations.initDispatcher(InitOperations.java:7
>> 3)
>>     at
>> org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrep
>> areAndExecuteFilter.java:61)
>>     at
>> eu.inform.servlet.context.URIExcludeFilter.init(URIExcludeFilter.java:37)
>>     at
>> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig
>> .java:270)
>>     at
>> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig
>> .java:251)
>>     at
>> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.ja
>> va:102)
>>     at
>> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4491)
>>     at
>> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:51
>> 35)
>>     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>>     at
>> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432
>> )
>>     at
>> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422
>> )
>>     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>>     at
>> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorServ
>> ice.java:75)
>>     at
>> java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorS
>> ervice.java:140)
>>     at
>> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
>>     at
>> org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
>>     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>>     at
>> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432
>> )
>>     at
>> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422
>> )
>>     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>>     at
>> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorServ
>> ice.java:75)
>>     at
>> jav

Re: Java 11 support

[Yasser Zamani]

On 1/24/2019 10:28 AM, Lukasz Lenart wrote:
> śr., 23 sty 2019 o 15:49 Yasser Zamani  napisał(a):
>> I'm not sure if I get your point correctly but I didn't change `target` in 
>> [1].
>>
>> If you meant the user's itself java 11 compiled classes structure, to double 
>> verify if it works, with [1]'s local branch with a few local changes into 
>> showcase app, I compiled showcase app into a war file with JDK11. Inside the 
>> war file, I verified that showcase classes are compiled with JDK11 and 
>> WEB-INF\lib\struts-convention-plugin.jar classes are compiled with JDK7 (via 
>> viewing their .class files first 8 bytes) i.e. similar to Sebastian case. I 
>> then deployed that war into tomcat starting with java 11. I saw it launched 
>> with no error and I saw it's bean-validation-example.action (a convention 
>> configured action) works fine.
> 
> I think the proper test case scenario is as follow:
> - build Struts with  JDK7 (or JDK8 as we are going to use Java 8 in Struts 
> 2.6)
> - prepare a Convention based Struts app
> - build the app use JDK 11 (with target set to Java 11)
> - start the app and see if all the actions were properly initialised
> 
> Issue isn't with building Struts itself under JDK11 but with using
> Struts in Java 11 based application (where the source is compiled with
> JDK11)

Yes I already got the issue. As I illustrated above, I think I already
done your proposed test scenario. As I illustrated above, I had compiled
Struts showcase app with JDK11 source and target but had compiled the
rest modules (including core and plugins and etc) with JDK7 source and
target. I even had verified this in struts-showcase.war via viewing
.class files raw first 8 bytes. This same struts-showcase.war with
current 2.5 branch logs same errors which Sebastian and Paul reported.
But this same struts-showcase.war with my proposed PR launches with no
error in output and convention-based actions of it works fine.

Regards.

Re: Java 11 support

[Sebastian Götz]

I agree with Lukasz.
That's the way to do it.

Am 24.01.2019 um 07:58 schrieb Lukasz Lenart:
> śr., 23 sty 2019 o 15:49 Yasser Zamani  napisał(a):
>> I'm not sure if I get your point correctly but I didn't change `target` in 
>> [1].
>>
>> If you meant the user's itself java 11 compiled classes structure, to double 
>> verify if it works, with [1]'s local branch with a few local changes into 
>> showcase app, I compiled showcase app into a war file with JDK11. Inside the 
>> war file, I verified that showcase classes are compiled with JDK11 and 
>> WEB-INF\lib\struts-convention-plugin.jar classes are compiled with JDK7 (via 
>> viewing their .class files first 8 bytes) i.e. similar to Sebastian case. I 
>> then deployed that war into tomcat starting with java 11. I saw it launched 
>> with no error and I saw it's bean-validation-example.action (a convention 
>> configured action) works fine.
> I think the proper test case scenario is as follow:
> - build Struts with  JDK7 (or JDK8 as we are going to use Java 8 in Struts 
> 2.6)
> - prepare a Convention based Struts app
> - build the app use JDK 11 (with target set to Java 11)
> - start the app and see if all the actions were properly initialised
>
> Issue isn't with building Struts itself under JDK11 but with using
> Struts in Java 11 based application (where the source is compiled with
> JDK11)
>
>
> Regards

-- 
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de 
http://www.inform-technology.de/

*

Zentrale Stockach:
Bodenseeallee 18
D-78333 Stockach
Tel: +49 7771 9282 494

*

Geschäftsführer: Dipl.-Ing. (FH) Heinz Roth | Handelsregister: HRB
715948, Amtsgericht Freiburg | USt-ID Nr.: DE312290945

Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte
Informationen. Wenn Sie nicht der richtige Adressat sind oder diese
E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den
Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie
die unbefugte Weitergabe dieser Mail ist nicht gestattet.

This e-mail may contain confidential and/or privileged information. If
you are not the intended recipient (or have received this e-mail in
error) please notify the sender immediately and destroy this e-mail. Any
unauthorised copying, disclosure or distribution of the material in this
e-mail is strictly forbidden.

Re: Java 11 support

[Lukasz Lenart]

śr., 23 sty 2019 o 15:49 Yasser Zamani  napisał(a):
> I'm not sure if I get your point correctly but I didn't change `target` in 
> [1].
>
> If you meant the user's itself java 11 compiled classes structure, to double 
> verify if it works, with [1]'s local branch with a few local changes into 
> showcase app, I compiled showcase app into a war file with JDK11. Inside the 
> war file, I verified that showcase classes are compiled with JDK11 and 
> WEB-INF\lib\struts-convention-plugin.jar classes are compiled with JDK7 (via 
> viewing their .class files first 8 bytes) i.e. similar to Sebastian case. I 
> then deployed that war into tomcat starting with java 11. I saw it launched 
> with no error and I saw it's bean-validation-example.action (a convention 
> configured action) works fine.

I think the proper test case scenario is as follow:
- build Struts with  JDK7 (or JDK8 as we are going to use Java 8 in Struts 2.6)
- prepare a Convention based Struts app
- build the app use JDK 11 (with target set to Java 11)
- start the app and see if all the actions were properly initialised

Issue isn't with building Struts itself under JDK11 but with using
Struts in Java 11 based application (where the source is compiled with
JDK11)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org

RE: Java 11 support

[Yasser Zamani]

>-Original Message-
>From: Lukasz Lenart 
>Sent: Wednesday, January 23, 2019 4:59 PM
>To: Struts Users Mailing List 
>Subject: Re: Java 11 support
>
>śr., 23 sty 2019 o 14:10 Yasser Zamani  napisał(a):
>> >I would start with detecting a proper Java version first. The
>> >additional constant will introduce unneeded burden for users to control it.
>>
>> Fortunately it seems it isn't required. Locally all tests are passing here 
>> with all
>java versions (7,8,9,11) for [1].
>
>The case is that we target JDK7 in pom.xml, once changed to JDK11 a class
>structure will change and having just ASM7 on classpath won't help.

I'm not sure if I get your point correctly but I didn't change `target` in [1].

If you meant the user's itself java 11 compiled classes structure, to double 
verify if it works, with [1]'s local branch with a few local changes into 
showcase app, I compiled showcase app into a war file with JDK11. Inside the 
war file, I verified that showcase classes are compiled with JDK11 and 
WEB-INF\lib\struts-convention-plugin.jar classes are compiled with JDK7 (via 
viewing their .class files first 8 bytes) i.e. similar to Sebastian case. I 
then deployed that war into tomcat starting with java 11. I saw it launched 
with no error and I saw it's bean-validation-example.action (a convention 
configured action) works fine.

Regards.

[1] https://github.com/apache/struts/pull/315

Re: Java 11 support

[Lukasz Lenart]

śr., 23 sty 2019 o 14:10 Yasser Zamani  napisał(a):
> >I would start with detecting a proper Java version first. The additional 
> >constant
> >will introduce unneeded burden for users to control it.
>
> Fortunately it seems it isn't required. Locally all tests are passing here 
> with all java versions (7,8,9,11) for [1].

The case is that we target JDK7 in pom.xml, once changed to JDK11 a
class structure will change and having just ASM7 on classpath won't
help.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org

RE: Java 11 support

[Yasser Zamani]

>-Original Message-
>From: Lukasz Lenart 
>Sent: Wednesday, January 23, 2019 11:34 AM
>To: Struts Users Mailing List 
>Subject: Re: Java 11 support
>
>śr., 23 sty 2019 o 08:35 Yasser Zamani  napisał(a):
>> I would prefer to allow user to optionally override the default Opcodes.ASM5
>via a constant in struts.xml e.g. value=" Opcodes.ASM7"/>, Or more better, to think if it's possible to 
>determine it
>at runtime via user's runtime context e.g. java version. Wdyt?
>
>I would start with detecting a proper Java version first. The additional 
>constant
>will introduce unneeded burden for users to control it.

Fortunately it seems it isn't required. Locally all tests are passing here with 
all java versions (7,8,9,11) for [1].

Kind Regards.

[1] https://github.com/apache/struts/pull/315
"According to ASM7's source codes, it seems it uses passed api version only to 
check if it should throw an unsupported exception or not (i.e. doesn't have any 
effect on functionality and somehow is just a validation). So, as we upgrade to 
asm.version=7.0 for default then I think it's OK to upgrade Opcodes.ASM5 to 
Opcodes.ASM7 as well. It only breaks when user manually exclude ASM7 dependency 
with an older version which is not usually expected."

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org

Re: Java 11 support

[Lukasz Lenart]

śr., 23 sty 2019 o 08:35 Yasser Zamani  napisał(a):
> I would prefer to allow user to optionally override the default Opcodes.ASM5 
> via a constant in struts.xml e.g.  value=" Opcodes.ASM7"/>, Or more better, to think if it's possible to 
> determine it at runtime via user's runtime context e.g. java version. Wdyt?

I would start with detecting a proper Java version first. The
additional constant will introduce unneeded burden for users to
control it.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org

RE: Java 11 support

[Yasser Zamani]

>-Original Message-
>From: Lukasz Lenart 
>Sent: Tuesday, January 22, 2019 12:03 PM
>To: Struts Users Mailing List 
>Subject: Re: Java 11 support
>
>Ok, thanks. I see your point now, but this can be hard to support as we must
>support Java 7 (or Java 8 in case of Struts 2.6) and at the same time Java 11 
>- I
>think we will have to develop a dedicated plugin that will replace ClassFinder 
>in
>the Convention plugin in case of Java 11.
>

Hi Łukasz,

I would prefer to allow user to optionally override the default Opcodes.ASM5 
via a constant in struts.xml e.g. , Or more better, to think if it's possible to determine 
it at runtime via user's runtime context e.g. java version. Wdyt?

Kind Regards.

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org

Re: Java 11 support

[Sebastian Götz]

Hello Yasser,

sure I will give that a try and give you the feedback.
But I cannot guarantee that I will make it today.

Regards

Sebastian

Am 23.01.2019 um 08:17 schrieb Yasser Zamani:



-Original Message-
From: Sebastian Götz 
Sent: Thursday, January 17, 2019 4:41 PM
To: user@struts.apache.org
Subject: Re: Java 11 support

Hi folks,

it appears that there is some work left in the convention plugin. As I can see 
from
my IVY resolve process this plugin drags in asm 5.2. From its sources it looks 
like it
supports class version up to 1.8 (class version 52).
As we compile with JDK 11 already (class version 55) we get a lot of these
exceptions:

  java.lang.IllegalArgumentException
     at org.objectweb.asm.ClassReader.(Unknown Source)
     at org.objectweb.asm.ClassReader.(Unknown Source)
     at org.objectweb.asm.ClassReader.(Unknown Source)
     at
org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFind
er.java:461)
     at
org.apache.struts2.convention.DefaultClassFinder.(DefaultClassFinder.java:
93)
     at
org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildClassFind
er(PackageBasedActionConfigBuilder.java:395)
     at
org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActions(Pa
ckageBasedActionConfigBuilder.java:377)
     at
org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionCo
nfigs(PackageBasedActionConfigBuilder.java:333)
     at
org.apache.struts2.convention.ClasspathPackageProvider.loadPackages(Classpat
hPackageProvider.java:52)
     at
com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(D
efaultConfiguration.java:206)
     at
com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(Con
figurationManager.java:66)
     at
org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:957)
     at
org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.j
ava:463)
     at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:496)
     at
org.apache.struts2.dispatcher.InitOperations.initDispatcher(InitOperations.java:7
3)
     at
org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrep
areAndExecuteFilter.java:61)
     at
eu.inform.servlet.context.URIExcludeFilter.init(URIExcludeFilter.java:37)
     at
org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig
.java:270)
     at
org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig
.java:251)
     at
org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.ja
va:102)
     at
org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4491)
     at
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:51
35)
     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432
)
     at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422
)
     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
     at
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorServ
ice.java:75)
     at
java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorS
ervice.java:140)
     at
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
     at
org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432
)
     at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422
)
     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
     at
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorServ
ice.java:75)
     at
java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorS
ervice.java:140)
     at
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
     at
org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:261)
     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     at
org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)
     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     at
org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:801)
     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     at org.apache.catalina.startup.Catalina.start(Catalina.java:695)
     at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
     at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodA
ccessorImpl.java:62)
     at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Delegating
MethodAccessorImpl.java:43

RE: Java 11 support

[Yasser Zamani]

>-Original Message-
>From: Paul Zepernick 
>Sent: Friday, January 18, 2019 4:24 PM
>To: Struts Users Mailing List 
>Subject: RE: Java 11 support
>
>I can confirm that this was the same error I was seeing when trying Java 11 
>using
>Struts 2.5.18.  It is happening in the convention pluggin on the startup of the
>server when it scans for actions to configure Struts.  It is not a compile 
>issue, but
>happening at runtime.
>

Hi Paul,

Thanks for your time!

Could you please check if any further issue persists with my solution posted in 
previous mail in list (beside the workaround for drop-in ASM7 dependency)? I 
think "This feature requires ASM7" will vanished with it but I'm not 
comprehensively sure if any further issue arises after. If so, it would be nice 
to fix them in 2.5.21 as well (beside asm.version=7.0).

Thanks in advance!

Kind Regards.

RE: Java 11 support

[Yasser Zamani]

>-Original Message-
>From: Sebastian Götz 
>Sent: Thursday, January 17, 2019 4:41 PM
>To: user@struts.apache.org
>Subject: Re: Java 11 support
>
>Hi folks,
>
>it appears that there is some work left in the convention plugin. As I can see 
>from
>my IVY resolve process this plugin drags in asm 5.2. From its sources it looks 
>like it
>supports class version up to 1.8 (class version 52).
>As we compile with JDK 11 already (class version 55) we get a lot of these
>exceptions:
>
>  java.lang.IllegalArgumentException
>     at org.objectweb.asm.ClassReader.(Unknown Source)
>     at org.objectweb.asm.ClassReader.(Unknown Source)
>     at org.objectweb.asm.ClassReader.(Unknown Source)
>     at
>org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFind
>er.java:461)
>     at
>org.apache.struts2.convention.DefaultClassFinder.(DefaultClassFinder.java:
>93)
>     at
>org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildClassFind
>er(PackageBasedActionConfigBuilder.java:395)
>     at
>org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActions(Pa
>ckageBasedActionConfigBuilder.java:377)
>     at
>org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionCo
>nfigs(PackageBasedActionConfigBuilder.java:333)
>     at
>org.apache.struts2.convention.ClasspathPackageProvider.loadPackages(Classpat
>hPackageProvider.java:52)
>     at
>com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(D
>efaultConfiguration.java:206)
>     at
>com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(Con
>figurationManager.java:66)
>     at
>org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:957)
>     at
>org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.j
>ava:463)
>     at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:496)
>     at
>org.apache.struts2.dispatcher.InitOperations.initDispatcher(InitOperations.java:7
>3)
>     at
>org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrep
>areAndExecuteFilter.java:61)
>     at
>eu.inform.servlet.context.URIExcludeFilter.init(URIExcludeFilter.java:37)
>     at
>org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig
>.java:270)
>     at
>org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig
>.java:251)
>     at
>org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.ja
>va:102)
>     at
>org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4491)
>     at
>org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:51
>35)
>     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>     at
>org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432
>)
>     at
>org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422
>)
>     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>     at
>org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorServ
>ice.java:75)
>     at
>java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorS
>ervice.java:140)
>     at
>org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
>     at
>org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
>     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>     at
>org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432
>)
>     at
>org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422
>)
>     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>     at
>org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorServ
>ice.java:75)
>     at
>java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorS
>ervice.java:140)
>     at
>org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
>     at
>org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:261)
>     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>     at
>org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)
>     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>     at
>org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:801)
>     at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>     at org.apache.catalina.startup.Catalina.start(Catalina.java:695)
>     at
>java.base/jdk.inte

Re: Java 11 support

[Lukasz Lenart]

Great, thanks a lot!

wt., 22 sty 2019 o 10:36 Sebastian Götz 
napisał(a):
>
> Okay,
>
> I have filed a JIRA issue: https://issues.apache.org/jira/browse/WW-5005.
>
> Am 22.01.2019 um 09:32 schrieb Lukasz Lenart:
> > Ok, thanks. I see your point now, but this can be hard to support as
> > we must support Java 7 (or Java 8 in case of Struts 2.6) and at the
> > same time Java 11 - I think we will have to develop a dedicated plugin
> > that will replace ClassFinder in the Convention plugin in case of Java
> > 11.
> >
> > Would you mind to fill a ticket in JIRA?
> >
> >
> > Regards
>
> --
> Mit freundlichen Grüßen
>
> Sebastian Götz
>
> iNFORM Technology GmbH
> Niederlassung Albstadt
> Berliner Straße 24
> 72458 Albstadt-Ebingen
>
> Tel: +49 7431 9816090
> Fax: +49 7431 9816092
> s.go...@inform-technology.de 
> http://www.inform-technology.de/
>
> *
>
> Zentrale Stockach:
> Bodenseeallee 18
> D-78333 Stockach
> Tel: +49 7771 9282 494
>
> *
>
> Geschäftsführer: Dipl.-Ing. (FH) Heinz Roth | Handelsregister: HRB
> 715948, Amtsgericht Freiburg | USt-ID Nr.: DE312290945
>
> Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte
> Informationen. Wenn Sie nicht der richtige Adressat sind oder diese
> E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den
> Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie
> die unbefugte Weitergabe dieser Mail ist nicht gestattet.
>
> This e-mail may contain confidential and/or privileged information. If
> you are not the intended recipient (or have received this e-mail in
> error) please notify the sender immediately and destroy this e-mail. Any
> unauthorised copying, disclosure or distribution of the material in this
> e-mail is strictly forbidden.

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org

Re: Java 11 support

[Sebastian Götz]

Okay,

I have filed a JIRA issue: https://issues.apache.org/jira/browse/WW-5005.

Am 22.01.2019 um 09:32 schrieb Lukasz Lenart:

Ok, thanks. I see your point now, but this can be hard to support as
we must support Java 7 (or Java 8 in case of Struts 2.6) and at the
same time Java 11 - I think we will have to develop a dedicated plugin
that will replace ClassFinder in the Convention plugin in case of Java
11.

Would you mind to fill a ticket in JIRA?


Regards


--
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de 
http://www.inform-technology.de/

*

Zentrale Stockach:
Bodenseeallee 18
D-78333 Stockach
Tel: +49 7771 9282 494

*

Geschäftsführer: Dipl.-Ing. (FH) Heinz Roth | Handelsregister: HRB 
715948, Amtsgericht Freiburg | USt-ID Nr.: DE312290945


Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte 
Informationen. Wenn Sie nicht der richtige Adressat sind oder diese 
E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den 
Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie 
die unbefugte Weitergabe dieser Mail ist nicht gestattet.


This e-mail may contain confidential and/or privileged information. If 
you are not the intended recipient (or have received this e-mail in 
error) please notify the sender immediately and destroy this e-mail. Any 
unauthorised copying, disclosure or distribution of the material in this 
e-mail is strictly forbidden.

Re: Java 11 support

[Lukasz Lenart]

Ok, thanks. I see your point now, but this can be hard to support as
we must support Java 7 (or Java 8 in case of Struts 2.6) and at the
same time Java 11 - I think we will have to develop a dedicated plugin
that will replace ClassFinder in the Convention plugin in case of Java
11.

Would you mind to fill a ticket in JIRA?


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

pt., 18 sty 2019 o 13:54 Paul Zepernick
 napisał(a):
>
> I can confirm that this was the same error I was seeing when trying Java 11 
> using Struts 2.5.18.  It is happening in the convention pluggin on the 
> startup of the server when it scans for actions to configure Struts.  It is 
> not a compile issue, but happening at runtime.
>
> Paul
>
> -Original Message-
> From: Sebastian Götz 
> Sent: Friday, January 18, 2019 3:30 AM
> To: user@struts.apache.org
> Subject: Re: Java 11 support
>
> NOTICE: This email originated from outside of the organization. Do not click 
> links or open attachments unless you recognize the sender and know the 
> content is safe.
>
> In the end: yes. Although we are building with ANT and IVY.
> But the compiler levels are specified as 11, yes.
>
> I do not know how to do it with maven. But it woul dbe relevant for the tests 
> of the convention plugin to analyse some Struts2 action class with class 
> version 55.
>
> Am 18.01.2019 um 09:13 schrieb Lukasz Lenart:
> > To clarify, you run your build on JDK11 and you defined source &
> > target in Maven pom as version 11, right?
> >
> >
> > Regards
>
> --
> Mit freundlichen Grüßen
>
> Sebastian Götz
>
> iNFORM Technology GmbH
> Niederlassung Albstadt
> Berliner Straße 24
> 72458 Albstadt-Ebingen
>
> Tel: +49 7431 9816090
> Fax: +49 7431 9816092
> s.go...@inform-technology.de <mailto:s.go...@inform-technology.de>
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.inform-technology.de%2Fdata=02%7C01%7CPaul.Zepernick%40healthsmart.com%7Cc78b0160c9634fa0556f08d67d1f37a9%7C2ce547c5e80a40628a56f25adceefb52%7C0%7C1%7C636833970376493460sdata=N8iSyqBh0pmpCN2hMkS8DlPzT6oIilTAsJpWxvaxaew%3Dreserved=0
>
> *
>
> Zentrale Stockach:
> Bodenseeallee 18
> D-78333 Stockach
> Tel: +49 7771 9282 494
>
> *
>
> Geschäftsführer: Dipl.-Ing. (FH) Heinz Roth | Handelsregister: HRB 715948, 
> Amtsgericht Freiburg | USt-ID Nr.: DE312290945
>
> Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte 
> Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail 
> irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und 
> vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte 
> Weitergabe dieser Mail ist nicht gestattet.
>
> This e-mail may contain confidential and/or privileged information. If you 
> are not the intended recipient (or have received this e-mail in
> error) please notify the sender immediately and destroy this e-mail. Any 
> unauthorised copying, disclosure or distribution of the material in this 
> e-mail is strictly forbidden.
> Disclaimer: This communication and any files transmitted with it may contain 
> information that is privileged, confidential and/or exempt from disclosure 
> under applicable law. If you are not the intended recipient, you are hereby 
> notified that any disclosure, copying, distribution, or use of the 
> information contained herein (including any reliance thereon) is strictly 
> prohibited. If you received this communication in error, please immediately 
> contact the sender and destroy the material in its entirety, whether in 
> electronic or hard copy format. Thank you.

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org

RE: Java 11 support

[Paul Zepernick]

I can confirm that this was the same error I was seeing when trying Java 11 
using Struts 2.5.18.  It is happening in the convention pluggin on the startup 
of the server when it scans for actions to configure Struts.  It is not a 
compile issue, but happening at runtime.

Paul

-Original Message-
From: Sebastian Götz 
Sent: Friday, January 18, 2019 3:30 AM
To: user@struts.apache.org
Subject: Re: Java 11 support

NOTICE: This email originated from outside of the organization. Do not click 
links or open attachments unless you recognize the sender and know the content 
is safe.

In the end: yes. Although we are building with ANT and IVY.
But the compiler levels are specified as 11, yes.

I do not know how to do it with maven. But it woul dbe relevant for the tests 
of the convention plugin to analyse some Struts2 action class with class 
version 55.

Am 18.01.2019 um 09:13 schrieb Lukasz Lenart:
> To clarify, you run your build on JDK11 and you defined source &
> target in Maven pom as version 11, right?
>
>
> Regards

--
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de <mailto:s.go...@inform-technology.de>
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.inform-technology.de%2Fdata=02%7C01%7CPaul.Zepernick%40healthsmart.com%7Cc78b0160c9634fa0556f08d67d1f37a9%7C2ce547c5e80a40628a56f25adceefb52%7C0%7C1%7C636833970376493460sdata=N8iSyqBh0pmpCN2hMkS8DlPzT6oIilTAsJpWxvaxaew%3Dreserved=0

*

Zentrale Stockach:
Bodenseeallee 18
D-78333 Stockach
Tel: +49 7771 9282 494

*

Geschäftsführer: Dipl.-Ing. (FH) Heinz Roth | Handelsregister: HRB 715948, 
Amtsgericht Freiburg | USt-ID Nr.: DE312290945

Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. 
Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten 
haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. 
Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht 
gestattet.

This e-mail may contain confidential and/or privileged information. If you are 
not the intended recipient (or have received this e-mail in
error) please notify the sender immediately and destroy this e-mail. Any 
unauthorised copying, disclosure or distribution of the material in this e-mail 
is strictly forbidden.
Disclaimer: This communication and any files transmitted with it may contain 
information that is privileged, confidential and/or exempt from disclosure 
under applicable law. If you are not the intended recipient, you are hereby 
notified that any disclosure, copying, distribution, or use of the information 
contained herein (including any reliance thereon) is strictly prohibited. If 
you received this communication in error, please immediately contact the sender 
and destroy the material in its entirety, whether in electronic or hard copy 
format. Thank you.

Re: Java 11 support

[Sebastian Götz]

In the end: yes. Although we are building with ANT and IVY.
But the compiler levels are specified as 11, yes.

I do not know how to do it with maven. But it woul dbe relevant for the 
tests of the convention plugin to analyse some Struts2 action class with 
class version 55.


Am 18.01.2019 um 09:13 schrieb Lukasz Lenart:

To clarify, you run your build on JDK11 and you defined source & target in
Maven pom as version 11, right?


Regards


--
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de 
http://www.inform-technology.de/

*

Zentrale Stockach:
Bodenseeallee 18
D-78333 Stockach
Tel: +49 7771 9282 494

*

Geschäftsführer: Dipl.-Ing. (FH) Heinz Roth | Handelsregister: HRB 
715948, Amtsgericht Freiburg | USt-ID Nr.: DE312290945


Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte 
Informationen. Wenn Sie nicht der richtige Adressat sind oder diese 
E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den 
Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie 
die unbefugte Weitergabe dieser Mail ist nicht gestattet.


This e-mail may contain confidential and/or privileged information. If 
you are not the intended recipient (or have received this e-mail in 
error) please notify the sender immediately and destroy this e-mail. Any 
unauthorised copying, disclosure or distribution of the material in this 
e-mail is strictly forbidden.

Re: Java 11 support

[Lukasz Lenart]

e.struts2.dispatcher.InitOperations.initDispatcher(InitOperations.java:73)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrepareAndExecuteFilter.java:61)
> >>>>at
> >>>>
> >>
> eu.inform.servlet.context.URIExcludeFilter.init(URIExcludeFilter.java:37)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:102)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4491)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5135)
> >>>>at
> >>>> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422)
> >>>>at
> >> java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
> >>>>at
> >>>>
> >>>>
> >>
> java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
> >>>>at
> >>>>
> >>
> org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
> >>>>at
> >>>> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422)
> >>>>at
> >> java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
> >>>>at
> >>>>
> >>>>
> >>
> java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:261)
> >>>>at
> >>>> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)
> >>>>at
> >>>> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> >>>>at
> >>>>
> >>>>
> >>
> org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:801)
> >>>>at
> >>>> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> >>>>at
> org.apache.catalina.startup.Catalina.start(Catalina.java:695)
> >>>>at
> >>>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> >>>> Method)
> >>>>at
> >>>>
> >>>>
> >>

Re: Java 11 support

[Sebastian Götz]

)
   at



org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432)

   at



org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422)

   at

java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)

   at



org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)

   at



java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)

   at



org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)

   at


org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)

   at
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
   at



org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432)

   at



org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422)

   at

java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)

   at



org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)

   at



java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)

   at



org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)

   at



org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:261)

   at
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
   at



org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)

   at
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
   at



org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:801)

   at
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
   at org.apache.catalina.startup.Catalina.start(Catalina.java:695)
   at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
   at



java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

   at



java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
   at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

Can someone verfiy that and propose a fix?

Kind regards,

Sebastian


Am 15.01.2019 um 09:45 schrieb Sebastian Götz:

Great to hear that!


Am 15.01.2019 um 09:37 schrieb Yasser Zamani:

Hi Sebastian,

Yes the release will be ready this month hopefully this week already ☺

Kind Regards.


From: Sebastian Götz
Sent: Tuesday, January 15, 2019 10:51 AM
To: Yasser Zamani
Subject: Re: Java 11 support

Hi Yasser,

sure! We are not in a hurry :-) but really looking forward to this

release. I tried with the 2.5.18 yesterday.

But then I will await the 2.5.20 release with pleasure.

I know this sort of question sucks but will the release be ready this

month already or will it take somewhat longer.

Kind regards,

Sebastian
Am 14.01.2019 um 19:06 schrieb Yasser Zamani:

Hi Sebastian,



I'm pleased to announce it seems we were able to add both java 9 and

11

supports into Struts 2.5.20. Could you please wait a few days for its

release and then test the bits? It currently can pass all tests with

all

jdks (see [1]) but it's so great if you will be able to test it in

production also.



Thanks for using Struts!



Kind Regards.



[1]https://travis-ci.org/apache/struts/builds/456910100





On 1/14/2019 11:13 AM, Sebastian Götz wrote:

Hello all.



I searched through the website and the issue tracker to find any

roadmap

info concerning Java 11 support.

At the moment I try upgrading our webapp to Tomcat 9 with OpenJDK 11.

I

now from past upgrades that we had to use a Java8-support-plugin for a

while.

Now with JDK 11 it looks a bit more complex getting the Java 9 module

stuff together correctly. But I think someone must have a plan for

this

migration.



So the question is: how and when is it going to be possible to use

struts2 with Java 11?



Kind regards



Sebastian Götz





-

To unsubscribe, e-mail:user-unsubscr...@struts.apache.org
user-unsubscr...@struts.apache.org>

For additional commands, e-mail:user-h...@struts.apache.org
user-h...@struts.apache.org>

--
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de<mailto:s.go...@inform-technology.de>
http://www.inform-technology.de/

*

Zentrale Stockach:
Bodenseeallee 18
D-78333 Stockach
Tel: +49 7771 9282 494

*

Geschäftsführer: Di

Re: Java 11 support

[Lukasz Lenart]

ltClassFinder.java:93)
> >>   at
> >>
> >>
> org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildClassFinder(PackageBasedActionConfigBuilder.java:395)
> >>   at
> >>
> >>
> org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActions(PackageBasedActionConfigBuilder.java:377)
> >>   at
> >>
> >>
> org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionConfigs(PackageBasedActionConfigBuilder.java:333)
> >>   at
> >>
> >>
> org.apache.struts2.convention.ClasspathPackageProvider.loadPackages(ClasspathPackageProvider.java:52)
> >>   at
> >>
> >>
> com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:206)
> >>   at
> >>
> >>
> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:66)
> >>   at
> >>
> org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:957)
> >>   at
> >>
> >>
> org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:463)
> >>   at
> org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:496)
> >>   at
> >>
> >>
> org.apache.struts2.dispatcher.InitOperations.initDispatcher(InitOperations.java:73)
> >>   at
> >>
> >>
> org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrepareAndExecuteFilter.java:61)
> >>   at
> >>
> eu.inform.servlet.context.URIExcludeFilter.init(URIExcludeFilter.java:37)
> >>   at
> >>
> >>
> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
> >>   at
> >>
> >>
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)
> >>   at
> >>
> >>
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:102)
> >>   at
> >>
> >>
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4491)
> >>   at
> >>
> >>
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5135)
> >>   at
> >> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> >>   at
> >>
> >>
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432)
> >>   at
> >>
> >>
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422)
> >>   at
> java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> >>   at
> >>
> >>
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
> >>   at
> >>
> >>
> java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
> >>   at
> >>
> >>
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
> >>   at
> >>
> org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
> >>   at
> >> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> >>   at
> >>
> >>
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432)
> >>   at
> >>
> >>
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422)
> >>   at
> java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> >>   at
> >>
> >>
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
> >>   at
> >>
> >>
> java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
> >>   at
> >>
> >>
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
> >>   at
> >>
> >>
> org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:261)
> >>   at
> >> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> >>   at
> >>
> >>
> org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)
> >>   at
> >> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> >>   at
> >>
> >>
> org.apache.catalina.core.StandardServer

Re: Java 11 support

[Sebastian Götz]

)
  at

org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
  at

java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
  at

org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
  at

org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:261)
  at
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
  at

org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)
  at
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
  at

org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:801)
  at
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
  at org.apache.catalina.startup.Catalina.start(Catalina.java:695)
  at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
  at

java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at

java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.base/java.lang.reflect.Method.invoke(Method.java:566)
  at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
  at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

Can someone verfiy that and propose a fix?

Kind regards,

Sebastian


Am 15.01.2019 um 09:45 schrieb Sebastian Götz:

Great to hear that!


Am 15.01.2019 um 09:37 schrieb Yasser Zamani:

Hi Sebastian,

Yes the release will be ready this month hopefully this week already ☺

Kind Regards.


From: Sebastian Götz
Sent: Tuesday, January 15, 2019 10:51 AM
To: Yasser Zamani
Subject: Re: Java 11 support

Hi Yasser,

sure! We are not in a hurry :-) but really looking forward to this

release. I tried with the 2.5.18 yesterday.

But then I will await the 2.5.20 release with pleasure.

I know this sort of question sucks but will the release be ready this

month already or will it take somewhat longer.

Kind regards,

Sebastian
Am 14.01.2019 um 19:06 schrieb Yasser Zamani:

Hi Sebastian,



I'm pleased to announce it seems we were able to add both java 9 and 11

supports into Struts 2.5.20. Could you please wait a few days for its

release and then test the bits? It currently can pass all tests with all

jdks (see [1]) but it's so great if you will be able to test it in

production also.



Thanks for using Struts!



Kind Regards.



[1]https://travis-ci.org/apache/struts/builds/456910100





On 1/14/2019 11:13 AM, Sebastian Götz wrote:

Hello all.



I searched through the website and the issue tracker to find any roadmap

info concerning Java 11 support.

At the moment I try upgrading our webapp to Tomcat 9 with OpenJDK 11. I

now from past upgrades that we had to use a Java8-support-plugin for a

while.

Now with JDK 11 it looks a bit more complex getting the Java 9 module

stuff together correctly. But I think someone must have a plan for this

migration.



So the question is: how and when is it going to be possible to use

struts2 with Java 11?



Kind regards



Sebastian Götz





-

To unsubscribe, e-mail:user-unsubscr...@struts.apache.org
user-unsubscr...@struts.apache.org>

For additional commands, e-mail:user-h...@struts.apache.org
user-h...@struts.apache.org>

--
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de<mailto:s.go...@inform-technology.de>
http://www.inform-technology.de/

*

Zentrale Stockach:
Bodenseeallee 18
D-78333 Stockach
Tel: +49 7771 9282 494

*

Geschäftsführer: Dipl.-Ing. (FH) Heinz Roth | Handelsregister: HRB

715948, Amtsgericht Freiburg | USt-ID Nr.: DE312290945

Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte

Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail
irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und
vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte
Weitergabe dieser Mail ist nicht gestattet.

This e-mail may contain confidential and/or privileged information. If

you are not the intended recipient (or have received this e-mail in error)
please notify the sender immediately and destroy this e-mail. Any
unauthorised copying, disclosure or distribution of the material in this
e-mail is strictly forbidden.

--
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de <mailto:s.go...@inform-technology.de>
http://www.inform-technology.de/

*

Zentrale Stockach

Re: Java 11 support

[Lukasz Lenart]

cat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>  at
>
> java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
>  at
>
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
>  at
>
> org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:261)
>  at
> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>  at
>
> org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)
>  at
> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>  at
>
> org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:801)
>  at
> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>  at org.apache.catalina.startup.Catalina.start(Catalina.java:695)
>  at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
>  at
>
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>      at
>
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>  at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
>  at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)
>
> Can someone verfiy that and propose a fix?
>
> Kind regards,
>
> Sebastian
>
>
> Am 15.01.2019 um 09:45 schrieb Sebastian Götz:
> > Great to hear that!
> >
> >
> > Am 15.01.2019 um 09:37 schrieb Yasser Zamani:
> >> Hi Sebastian,
> >>
> >> Yes the release will be ready this month hopefully this week already ☺
> >>
> >> Kind Regards.
> >>
> >>
> >> From: Sebastian Götz
> >> Sent: Tuesday, January 15, 2019 10:51 AM
> >> To: Yasser Zamani
> >> Subject: Re: Java 11 support
> >>
> >> Hi Yasser,
> >>
> >> sure! We are not in a hurry :-) but really looking forward to this
> release. I tried with the 2.5.18 yesterday.
> >> But then I will await the 2.5.20 release with pleasure.
> >>
> >> I know this sort of question sucks but will the release be ready this
> month already or will it take somewhat longer.
> >>
> >> Kind regards,
> >>
> >> Sebastian
> >> Am 14.01.2019 um 19:06 schrieb Yasser Zamani:
> >>
> >> Hi Sebastian,
> >>
> >>
> >>
> >> I'm pleased to announce it seems we were able to add both java 9 and 11
> >>
> >> supports into Struts 2.5.20. Could you please wait a few days for its
> >>
> >> release and then test the bits? It currently can pass all tests with all
> >>
> >> jdks (see [1]) but it's so great if you will be able to test it in
> >>
> >> production also.
> >>
> >>
> >>
> >> Thanks for using Struts!
> >>
> >>
> >>
> >> Kind Regards.
> >>
> >>
> >>
> >> [1]https://travis-ci.org/apache/struts/builds/456910100
> >>
> >>
> >>
> >>
> >>
> >> On 1/14/2019 11:13 AM, Sebastian Götz wrote:
> >>
> >> Hello all.
> >>
> >>
> >>
> >> I searched through the website and the issue tracker to find any roadmap
> >>
> >> info concerning Java 11 support.
> >>
> >> At the moment I try upgrading our webapp to Tomcat 9 with OpenJDK 11. I
> >>
> >> now from past upgrades that we had to use a Java8-support-plugin for a
> >>
> >> while.
> >>
> >> Now with JDK 11 it looks a bit more complex getting the Java 9 module
> >>
> >> stuff together correctly. But I think someone must have a plan for this
> >>
> >> migration.
> >>
> >>
> >>
> >> So the question is: how and when is it going to be possible to use
> >>
> >> struts2 with Java 11?
> >>
> >>
> >>
> >> Kind regards
> >>
> >>
> >>
> >> Sebastian Götz
> >>
> >>
> >>
> >>
> >>
> >> -
> >>
> >> To unsubscribe, e-mail:user-unsubscr...@struts.apache.org user-unsubscr...@struts.apache.org>
> >>
> >> For additional commands, e-mail:user-h...@struts.apache.org user-h...@struts.apache.org>
> >>
> >&g

Re: Java 11 support

[Sebastian Götz]

 15.01.2019 um 09:45 schrieb Sebastian Götz:

Great to hear that!


Am 15.01.2019 um 09:37 schrieb Yasser Zamani:

Hi Sebastian,

Yes the release will be ready this month hopefully this week already ☺

Kind Regards.


From: Sebastian Götz
Sent: Tuesday, January 15, 2019 10:51 AM
To: Yasser Zamani
Subject: Re: Java 11 support

Hi Yasser,

sure! We are not in a hurry :-) but really looking forward to this release. I 
tried with the 2.5.18 yesterday.
But then I will await the 2.5.20 release with pleasure.

I know this sort of question sucks but will the release be ready this month 
already or will it take somewhat longer.

Kind regards,

Sebastian
Am 14.01.2019 um 19:06 schrieb Yasser Zamani:

Hi Sebastian,



I'm pleased to announce it seems we were able to add both java 9 and 11

supports into Struts 2.5.20. Could you please wait a few days for its

release and then test the bits? It currently can pass all tests with all

jdks (see [1]) but it's so great if you will be able to test it in

production also.



Thanks for using Struts!



Kind Regards.



[1]https://travis-ci.org/apache/struts/builds/456910100





On 1/14/2019 11:13 AM, Sebastian Götz wrote:

Hello all.



I searched through the website and the issue tracker to find any roadmap

info concerning Java 11 support.

At the moment I try upgrading our webapp to Tomcat 9 with OpenJDK 11. I

now from past upgrades that we had to use a Java8-support-plugin for a

while.

Now with JDK 11 it looks a bit more complex getting the Java 9 module

stuff together correctly. But I think someone must have a plan for this

migration.



So the question is: how and when is it going to be possible to use

struts2 with Java 11?



Kind regards



Sebastian Götz





-

To unsubscribe, 
e-mail:user-unsubscr...@struts.apache.org<mailto:user-unsubscr...@struts.apache.org>

For additional commands, 
e-mail:user-h...@struts.apache.org<mailto:user-h...@struts.apache.org>

--
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de<mailto:s.go...@inform-technology.de>
http://www.inform-technology.de/

*

Zentrale Stockach:
Bodenseeallee 18
D-78333 Stockach
Tel: +49 7771 9282 494

*

Geschäftsführer: Dipl.-Ing. (FH) Heinz Roth | Handelsregister: HRB 715948, 
Amtsgericht Freiburg | USt-ID Nr.: DE312290945

Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. 
Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten 
haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. 
Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht 
gestattet.

This e-mail may contain confidential and/or privileged information. If you are 
not the intended recipient (or have received this e-mail in error) please 
notify the sender immediately and destroy this e-mail. Any unauthorised 
copying, disclosure or distribution of the material in this e-mail is strictly 
forbidden.


--
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de <mailto:s.go...@inform-technology.de>
http://www.inform-technology.de/

*

Zentrale Stockach:
Bodenseeallee 18
D-78333 Stockach
Tel: +49 7771 9282 494

*

Geschäftsführer: Dipl.-Ing. (FH) Heinz Roth | Handelsregister: HRB 
715948, Amtsgericht Freiburg | USt-ID Nr.: DE312290945


Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte 
Informationen. Wenn Sie nicht der richtige Adressat sind oder diese 
E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den 
Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie 
die unbefugte Weitergabe dieser Mail ist nicht gestattet.


This e-mail may contain confidential and/or privileged information. If 
you are not the intended recipient (or have received this e-mail in 
error) please notify the sender immediately and destroy this e-mail. 
Any unauthorised copying, disclosure or distribution of the material 
in this e-mail is strictly forbidden.


--
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de <mailto:s.go...@inform-technology.de>
http://www.inform-technology.de/

*

Zentrale Stockach:
Bodenseeallee 18
D-78333 Stockach
Tel: +49 7771 9282 494

*

Geschäftsführ

Re: Java 11 support

[Sebastian Götz]

Great to hear that!


Am 15.01.2019 um 09:37 schrieb Yasser Zamani:

Hi Sebastian,

Yes the release will be ready this month hopefully this week already ☺

Kind Regards.


From: Sebastian Götz 
Sent: Tuesday, January 15, 2019 10:51 AM
To: Yasser Zamani 
Subject: Re: Java 11 support

Hi Yasser,

sure! We are not in a hurry :-) but really looking forward to this release. I 
tried with the 2.5.18 yesterday.
But then I will await the 2.5.20 release with pleasure.

I know this sort of question sucks but will the release be ready this month 
already or will it take somewhat longer.

Kind regards,

Sebastian
Am 14.01.2019 um 19:06 schrieb Yasser Zamani:

Hi Sebastian,



I'm pleased to announce it seems we were able to add both java 9 and 11

supports into Struts 2.5.20. Could you please wait a few days for its

release and then test the bits? It currently can pass all tests with all

jdks (see [1]) but it's so great if you will be able to test it in

production also.



Thanks for using Struts!



Kind Regards.



[1] https://travis-ci.org/apache/struts/builds/456910100





On 1/14/2019 11:13 AM, Sebastian Götz wrote:

Hello all.



I searched through the website and the issue tracker to find any roadmap

info concerning Java 11 support.

At the moment I try upgrading our webapp to Tomcat 9 with OpenJDK 11. I

now from past upgrades that we had to use a Java8-support-plugin for a

while.

Now with JDK 11 it looks a bit more complex getting the Java 9 module

stuff together correctly. But I think someone must have a plan for this

migration.



So the question is: how and when is it going to be possible to use

struts2 with Java 11?



Kind regards



Sebastian Götz





-

To unsubscribe, e-mail: 
user-unsubscr...@struts.apache.org<mailto:user-unsubscr...@struts.apache.org>

For additional commands, e-mail: 
user-h...@struts.apache.org<mailto:user-h...@struts.apache.org>

--
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de<mailto:s.go...@inform-technology.de>
http://www.inform-technology.de/

*

Zentrale Stockach:
Bodenseeallee 18
D-78333 Stockach
Tel: +49 7771 9282 494

*

Geschäftsführer: Dipl.-Ing. (FH) Heinz Roth | Handelsregister: HRB 715948, 
Amtsgericht Freiburg | USt-ID Nr.: DE312290945

Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. 
Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten 
haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. 
Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht 
gestattet.

This e-mail may contain confidential and/or privileged information. If you are 
not the intended recipient (or have received this e-mail in error) please 
notify the sender immediately and destroy this e-mail. Any unauthorised 
copying, disclosure or distribution of the material in this e-mail is strictly 
forbidden.


--
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de <mailto:s.go...@inform-technology.de>
http://www.inform-technology.de/

*

Zentrale Stockach:
Bodenseeallee 18
D-78333 Stockach
Tel: +49 7771 9282 494

*

Geschäftsführer: Dipl.-Ing. (FH) Heinz Roth | Handelsregister: HRB 
715948, Amtsgericht Freiburg | USt-ID Nr.: DE312290945


Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte 
Informationen. Wenn Sie nicht der richtige Adressat sind oder diese 
E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den 
Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie 
die unbefugte Weitergabe dieser Mail ist nicht gestattet.


This e-mail may contain confidential and/or privileged information. If 
you are not the intended recipient (or have received this e-mail in 
error) please notify the sender immediately and destroy this e-mail. Any 
unauthorised copying, disclosure or distribution of the material in this 
e-mail is strictly forbidden.

RE: Java 11 support

[Yasser Zamani]

Hi Sebastian,

Yes the release will be ready this month hopefully this week already ☺

Kind Regards.


From: Sebastian Götz 
Sent: Tuesday, January 15, 2019 10:51 AM
To: Yasser Zamani 
Subject: Re: Java 11 support

Hi Yasser,

sure! We are not in a hurry :-) but really looking forward to this release. I 
tried with the 2.5.18 yesterday.
But then I will await the 2.5.20 release with pleasure.

I know this sort of question sucks but will the release be ready this month 
already or will it take somewhat longer.

Kind regards,

Sebastian
Am 14.01.2019 um 19:06 schrieb Yasser Zamani:

Hi Sebastian,



I'm pleased to announce it seems we were able to add both java 9 and 11

supports into Struts 2.5.20. Could you please wait a few days for its

release and then test the bits? It currently can pass all tests with all

jdks (see [1]) but it's so great if you will be able to test it in

production also.



Thanks for using Struts!



Kind Regards.



[1] https://travis-ci.org/apache/struts/builds/456910100





On 1/14/2019 11:13 AM, Sebastian Götz wrote:

Hello all.



I searched through the website and the issue tracker to find any roadmap

info concerning Java 11 support.

At the moment I try upgrading our webapp to Tomcat 9 with OpenJDK 11. I

now from past upgrades that we had to use a Java8-support-plugin for a

while.

Now with JDK 11 it looks a bit more complex getting the Java 9 module

stuff together correctly. But I think someone must have a plan for this

migration.



So the question is: how and when is it going to be possible to use

struts2 with Java 11?



Kind regards



Sebastian Götz





-

To unsubscribe, e-mail: 
user-unsubscr...@struts.apache.org<mailto:user-unsubscr...@struts.apache.org>

For additional commands, e-mail: 
user-h...@struts.apache.org<mailto:user-h...@struts.apache.org>

--
Mit freundlichen Grüßen

Sebastian Götz

iNFORM Technology GmbH
Niederlassung Albstadt
Berliner Straße 24
72458 Albstadt-Ebingen

Tel: +49 7431 9816090
Fax: +49 7431 9816092
s.go...@inform-technology.de<mailto:s.go...@inform-technology.de>
http://www.inform-technology.de/

*

Zentrale Stockach:
Bodenseeallee 18
D-78333 Stockach
Tel: +49 7771 9282 494

*

Geschäftsführer: Dipl.-Ing. (FH) Heinz Roth | Handelsregister: HRB 715948, 
Amtsgericht Freiburg | USt-ID Nr.: DE312290945

Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. 
Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten 
haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. 
Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht 
gestattet.

This e-mail may contain confidential and/or privileged information. If you are 
not the intended recipient (or have received this e-mail in error) please 
notify the sender immediately and destroy this e-mail. Any unauthorised 
copying, disclosure or distribution of the material in this e-mail is strictly 
forbidden.

Re: Java 11 support

[Lukasz Lenart]

pon., 14 sty 2019 o 08:43 Sebastian Götz
 napisał(a):
> I searched through the website and the issue tracker to find any roadmap
> info concerning Java 11 support.
> At the moment I try upgrading our webapp to Tomcat 9 with OpenJDK 11. I
> now from past upgrades that we had to use a Java8-support-plugin for a
> while.

The plugin was dropped after switching to Struts 2.5.x

> Now with JDK 11 it looks a bit more complex getting the Java 9 module
> stuff together correctly. But I think someone must have a plan for this
> migration.
>
> So the question is: how and when is it going to be possible to use
> struts2 with Java 11?

In most cases it was an issue with third-party dependencies, Struts
2.5.20 should be ok and it uses all the dependencies that are Java 11
compliant.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org

Re: Java 11 support

[Yasser Zamani]

Hi Sebastian,

I'm pleased to announce it seems we were able to add both java 9 and 11
supports into Struts 2.5.20. Could you please wait a few days for its
release and then test the bits? It currently can pass all tests with all
jdks (see [1]) but it's so great if you will be able to test it in
production also.

Thanks for using Struts!

Kind Regards.

[1] https://travis-ci.org/apache/struts/builds/456910100


On 1/14/2019 11:13 AM, Sebastian Götz wrote:
> Hello all.
> 
> I searched through the website and the issue tracker to find any roadmap
> info concerning Java 11 support.
> At the moment I try upgrading our webapp to Tomcat 9 with OpenJDK 11. I
> now from past upgrades that we had to use a Java8-support-plugin for a
> while.
> Now with JDK 11 it looks a bit more complex getting the Java 9 module
> stuff together correctly. But I think someone must have a plan for this
> migration.
> 
> So the question is: how and when is it going to be possible to use
> struts2 with Java 11?
> 
> Kind regards
> 
> Sebastian Götz
> 

-
To unsubscribe, e-mail: user-unsubscr...@struts.apache.org
For additional commands, e-mail: user-h...@struts.apache.org