CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1219943002/470001
https://codereview.chromium.org/1219943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
I've rebased on top of the order switch --- it's passing release tests, but
fails a DCHECK(temps_.is_empty()) in Scope::FinalizeBlockScope().
Does this DCHECK really matter? Should temporaries always be declared in the
top-level function scope?
https://codereview.chromium.org/1235153006/
--
--
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1241713004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 4 (id:??) landed as
https://crrev.com/1f61ac50338cc2ef1a54735206351f9798687248
Cr-Commit-Position: refs/heads/master@{#29715}
https://codereview.chromium.org/1241713004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #2 on issue 4244 by bugdro...@chromium.org: RegExp lastIndex should
use ToLength
https://code.google.com/p/v8/issues/detail?id=4244#c2
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/1f61ac50338cc2ef1a54735206351f9798687248
commit
https://codereview.chromium.org/1238593003/diff/40001/src/array.js
File src/array.js (left):
https://codereview.chromium.org/1238593003/diff/40001/src/array.js#oldcode571
src/array.js:571: if (!IS_UNDEFINED(current_i) || low in array) {
On 2015/07/16 22:08:13, adamk wrote:
As discussed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1238593003/60001
https://codereview.chromium.org/1238593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
As discussed in person this seems reasonable to me, but I'd like rossberg's
sign-off as well.
https://codereview.chromium.org/1233913008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
+1!
https://codereview.chromium.org/1240453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
On 2015/07/16 15:39:51, commit-bot: I haz the power wrote:
Patchset 1 (id:??) landed as
https://crrev.com/1251d02e7bb2a13ae5cf6fda5d3403730d2ae12f
Cr-Commit-Position: refs/heads/master@{#29708}
Looks like this might have caused a regression: The octane gbemu-part1 test
timed out. Could it be
On 2015/07/16 17:29:58, caitp wrote:
I've rebased on top of the order switch --- it's passing release tests,
but
fails a DCHECK(temps_.is_empty()) in Scope::FinalizeBlockScope().
Does this DCHECK really matter? Should temporaries always be declared in
the
top-level function scope?
Please add tests for these changes.
https://codereview.chromium.org/1236033010/diff/1/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1236033010/diff/1/src/typedarray.js#newcode358
src/typedarray.js:358: READ_ONLY | DONT_ENUM | DONT_DELETE);
Why are you
https://codereview.chromium.org/1238743002/diff/11/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1238743002/diff/11/src/compiler/ast-graph-builder.cc#newcode3288
src/compiler/ast-graph-builder.cc:3288: Node*
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: Debugger: use debug break slots to break at function exit.
port fc9c5275c3a747caca709b7d5745579f70e61301 (r29672).
original commit message:
Debugger: use debug break slots to break at function exit.
By not having to patch the
Patchset 1 (id:??) landed as
https://crrev.com/1d9216504965ab4f3e88d99b4f07bdbefa305676
Cr-Commit-Position: refs/heads/master@{#29694}
https://codereview.chromium.org/1236023007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1230813004/20001
https://codereview.chromium.org/1230813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1227213003/1
https://codereview.chromium.org/1227213003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 1 (id:??) landed as
https://crrev.com/83207b93f4d23e1df5c4f9bae1a97c8205b079e5
Cr-Commit-Position: refs/heads/master@{#29698}
https://codereview.chromium.org/1227213003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1227213003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm.
https://codereview.chromium.org/1240553003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Looks pretty good to me. A couple of comments.
https://codereview.chromium.org/1230753004/diff/120001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1230753004/diff/120001/src/heap/heap.h#newcode1684
src/heap/heap.h:1684: PretenureFlag pretenure = NOT_TENURED);
On 2015/07/15 22:59:01, adamk wrote:
The broader question I have for rossberg is something like: why did TC39
make
ToLength have different behavior for negative values than ToUint32?
The wrap-around semantics of ToUint is completely crazy, and would be even
crazier when applied to random
Updates:
Owner: little...@chromium.org
Cc: rossb...@chromium.org
Comment #3 on issue 3593 by rossb...@chromium.org: symbol == Object(symbol)
https://code.google.com/p/v8/issues/detail?id=3593
(No comment was entered for this change.)
--
You received this message because this
Comment #15 on issue 3087 by rossb...@chromium.org: ES6:
Array.prototype.slice and friends should use ToLength instead of ToUint32
https://code.google.com/p/v8/issues/detail?id=3087
@ #14: v8.team.admin was me using the wrong account. :)
Note that there is an orphan CL for this by dpino:
Reviewers: bbudge, danno, paul.l..., dusmil.imgtec, akos.palfi.imgtec,
Description:
MIPS64: Fix 'Expose SIMD.Float32x4 type to Javascript.'
Port e5ed3bee99807c502fa7d7a367ec401e16d3f773
Original commit message:
This CL exposes the constructor function, defines type related
information, and
On 2015/07/16 10:56:24, jochen wrote:
lgtm from my side, but please also wait for Yang
lgtm.
https://codereview.chromium.org/1233563005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
Comment #12 on issue 4132 by bugdro...@chromium.org: Improve performance
when break points are set.
https://code.google.com/p/v8/issues/detail?id=4132#c12
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/83207b93f4d23e1df5c4f9bae1a97c8205b079e5
Updates:
Status: Fixed
Comment #2 on issue 4309 by yang...@chromium.org: ScopeIterator cannot deal
with turbofan code.
https://code.google.com/p/v8/issues/detail?id=4309
(No comment was entered for this change.)
--
You received this message because this project is configured to send
Updates:
Owner: little...@chromium.org
Cc: rossb...@chromium.org
Comment #3 on issue 3788 by rossb...@chromium.org:
ToPrimitive(Object(Symbol()) should produce the wrapped symbol instead of
throwing.
https://code.google.com/p/v8/issues/detail?id=3788
(No comment was entered
Reviewers: rossberg, adamk,
Message:
Andreas: PTAL.
Adam: FYI.
Description:
Represent implicit 'this' binding by 'super' in AST.
This makes the implicit initializing assignment to 'this' performed
after a super constructor call explicit in the AST. It removes the
need to handle the special
Reviewers: rmcilroy,
Message:
Thanks! All done/ack'ed.
https://codereview.chromium.org/1230753004/diff/40001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/1230753004/diff/40001/src/factory.cc#newcode880
src/factory.cc:880: length, start, pretenure),
On 2015/07/15
Comment #1 on issue 4309 by bugdro...@chromium.org: ScopeIterator cannot
deal with turbofan code.
https://code.google.com/p/v8/issues/detail?id=4309#c1
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/3a0ee39cbde6a9778cfc4e2a6a0a8ff68933ff38
Patchset 3 (id:??) landed as
https://crrev.com/3a0ee39cbde6a9778cfc4e2a6a0a8ff68933ff38
Cr-Commit-Position: refs/heads/master@{#29697}
https://codereview.chromium.org/1239033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: jochen, Yang,
Description:
Take the ScriptOrigin into account for CompileFunctionInContext
R=joc...@chromium.org,yang...@chromium.org
LOG=n
BUG=
Please review this at https://codereview.chromium.org/1233563005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected
Updates:
Status: Assigned
Owner: little...@chromium.org
Comment #3 on issue 4307 by rossb...@chromium.org: Implement well-known
symbol `Symbol.toPrimitive`
https://code.google.com/p/v8/issues/detail?id=4307
(No comment was entered for this change.)
--
You received this
lgtm from my side, but please also wait for Yang
https://codereview.chromium.org/1233563005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
https://codereview.chromium.org/1239793002/diff/20001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1239793002/diff/20001/src/interpreter/interpreter.cc#newcode29
src/interpreter/interpreter.cc:29: static_castint(Bytecode::kLast) +
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1239033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
On 2015/07/13 at 11:29:15, jochen wrote:
the change per se looks good
Danno, should we take this in?
I am willing to give this the OK as soon as we know we have adequate
coverage.
https://codereview.chromium.org/1223613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1230813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1238743002/diff/11/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1238743002/diff/11/src/compiler/ast-graph-builder.cc#newcode3288
src/compiler/ast-graph-builder.cc:3288: Node*
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: Switch CallConstructStub to take new.target in register.
original commit message:
This changes the calling convention of the CallConstructStub to take
the original constructor (i.e. new.target in JS-speak) in a register
instead
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1239033002/40001
https://codereview.chromium.org/1239033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 7 (id:??) landed as
https://crrev.com/b76acef799bd07346918a78c5eb1d8ebf085975b
Cr-Commit-Position: refs/heads/master@{#29696}
https://codereview.chromium.org/1238743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Still LGTM.
https://codereview.chromium.org/1239033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1239033002/20001
https://codereview.chromium.org/1239033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #7 (id:140001)
https://codereview.chromium.org/1238743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/c6d42c7d6c60f0651ee993f2de5b59f37225732a
Cr-Commit-Position: refs/heads/master@{#29695}
https://codereview.chromium.org/1235273003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1235273003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Comment #3 on issue 4211 by rossb...@chromium.org: Wrong precedence for
arrow function without parameters
https://code.google.com/p/v8/issues/detail?id=4211
@ #2: No, these examples are all fine. A ConciseBody is an
AssignmentExpression, which can be an application. That is, ()=1() parses
On 2015/07/16 07:17:06, Yang wrote:
The ScopeIterator code is a mess. This CL is to fix a bug. I will however
submit
a clean up to put the ScopeIterator into a separate file and clean it up,
later.
https://codereview.chromium.org/1239033002/
--
--
v8-dev mailing list
Reviewers: Benedikt Meurer,
Description:
Debugger: use FrameInspector in ScopeIterator to find context.
In optimized code, it's not guaranteed that the current context
is stored in its frame slot.
R=bmeu...@chromium.org
BUG=v8:4309
LOG=N
Please review this at
Reviewers: jochen,
Description:
Update OWNERS file.
R=joc...@chromium.org
Please review this at https://codereview.chromium.org/1230813004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -2 lines):
M OWNERS
Index: OWNERS
diff --git a/OWNERS b/OWNERS
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1238743002/140001
https://codereview.chromium.org/1238743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
LGTM with nit (mostly rubber-stamped).
https://codereview.chromium.org/1239033002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/1239033002/diff/1/src/runtime/runtime-debug.cc#newcode1741
src/runtime/runtime-debug.cc:1741:
LGTM.
https://codereview.chromium.org/1230103004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1237083003/1
https://codereview.chromium.org/1237083003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
On 2015/07/15 18:50:53, jochen wrote:
yeah, it's essentially the same as while (1) {} - nothing gets rendered,
and
after a while you'll get the tab unresponsive, kill? dialog.
With while(1) {} you still get stack checks, so you can interrupt (e.g.,
from
the debugger or some such). Here,
On 2015/07/15 15:05:11, paul.l... wrote:
Actually, a small nit on the commit message. You can just edit the issue
here
in
Reitveld to fix.
When we change both MIPS MIPS64, we just use 'MIPS:' in message. Please
remove
the '[64]'
Also, we try for 72 char limit on first line of commit
Patchset 1 (id:??) landed as
https://crrev.com/2bc5a2121102282fc67cf96423bae02b19e18e42
Cr-Commit-Position: refs/heads/master@{#29693}
https://codereview.chromium.org/1237083003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1237083003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1235273003/1
https://codereview.chromium.org/1235273003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1235273003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1236023007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1236023007/20001
https://codereview.chromium.org/1236023007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Try jobs failed on following builders:
v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/7716)
(exceeded global retry quota)
https://codereview.chromium.org/1239033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #1 (id:20001)
https://codereview.chromium.org/1236023007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/1239873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1230813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
https://codereview.chromium.org/1234383002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1234383002/diff/1/src/parser.cc#newcode5940
src/parser.cc:5940: args-InsertAt(0, get_prototype, zone());
On 2015/07/16 11:59:34, rossberg wrote:
On 2015/07/16 11:47:19,
Patchset 1 (id:??) landed as
https://crrev.com/f24ebb324a21dede00bc087fbd74b46504c8314b
Cr-Commit-Position: refs/heads/master@{#29700}
https://codereview.chromium.org/1233563005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1233563005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: jochen, Yang,
Description:
Takes the script offset into account when obtaining the column of the
message.
R=joc...@chromium.org,yang...@chromium.org
Please review this at https://codereview.chromium.org/1231663007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Reviewers: Michael Achenbach,
Description:
Version 4.6.10.1 (cherry-pick)
Merged 40c38c5a5a14471e88f4e7a31660f4908bd8fdf7
Revert of Expose SIMD.Float32x4 type to Javascript. (patchset #14 id:450001
of
https://codereview.chromium.org/1219943002/)
BUG=v8:4124
LOG=N
R=machenb...@chromium.org
On 2015/07/02 at 09:37:20, mstarzinger wrote:
Michael: As discussed offline, feel free to CQ this when we decide to ship
try-catch.
Heads-up: going to submit this on Monday so it does not interfere with Dev.
https://codereview.chromium.org/1216373002/
--
--
v8-dev mailing list
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1238503003/1
https://codereview.chromium.org/1238503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1226123010/11
https://codereview.chromium.org/1226123010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/1234383002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1234383002/diff/1/src/parser.cc#newcode5940
src/parser.cc:5940: args-InsertAt(0, get_prototype, zone());
On 2015/07/16 11:47:19, caitp wrote:
Don't you need to also
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1233563005/1
https://codereview.chromium.org/1233563005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1231663007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1226123010/diff/20001/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/1226123010/diff/20001/src/ast.cc#newcode62
src/ast.cc:62: bool Expression::IsVariableProxyOrProperty() const {
On 2015/07/16 11:50:48, rossberg wrote:
I have a slight
lgtm
https://codereview.chromium.org/1240553003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/07/03 at 13:22:24, Hablich wrote:
On 2015/07/03 13:00:13, Hannes Payer wrote:
lgtm
Thanks for the heads-up. Let's ship this after branching. The current
Canary
is to crashy ATM.
Heads-up: Going to submit this on Monday so it does not interfere with Dev.
lgtm
https://codereview.chromium.org/1238503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: rossberg, adamk, caitp,
Message:
Andreas: PTAL.
Adam, Caitlin: FYI.
Description:
Remove obsolete %CallSuperWithSpread intrinsic.
The aforementioned intrinsic is now longer needed and can be fully
desugared now that binding assignments to 'this' are explicit.
R=rossb...@chromium.org
Comment #24 on issue 4124 by bugdro...@chromium.org: Implement SIMD.js
https://code.google.com/p/v8/issues/detail?id=4124#c24
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/40c38c5a5a14471e88f4e7a31660f4908bd8fdf7
commit
https://codereview.chromium.org/1226123010/diff/80001/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/1226123010/diff/80001/test/mjsunit/harmony/super.js#newcode1983
test/mjsunit/harmony/super.js:1983: derivedCalled++;
On 2015/07/16
lgtm
https://codereview.chromium.org/1230103004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1238693004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1234383002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1234383002/diff/1/src/parser.cc#newcode5940
src/parser.cc:5940: args-InsertAt(0, get_prototype, zone());
On 2015/07/16 12:08:14, caitp wrote:
There is definitely some
https://codereview.chromium.org/1234383002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1234383002/diff/1/src/parser.cc#newcode5940
src/parser.cc:5940: args-InsertAt(0, get_prototype, zone());
On 2015/07/16 11:47:19, caitp wrote:
Don't you need to also
LGTM
https://codereview.chromium.org/1234383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1234213004/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1234213004/diff/1/src/parser.cc#newcode4310
src/parser.cc:4310: bool Parser::NeedsParameterInitializationBlock(
Make this into IsSimpleParameterList, to match what's in
No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
On 2015/07/16 at 12:55:09, Hablich wrote:
On 2015/07/02 at 09:37:20, mstarzinger wrote:
Michael: As discussed offline, feel free to CQ this when we decide to
ship
try-catch.
Heads-up: going to submit this on Monday so it does not interfere with
Dev.
To correct myself: Next dev will be
Reviewers: Michael Starzinger,
Message:
PTAL
Initial ports. I cannot even turn on the flag temporarily because super()
support is still missing. (Only tests failing locally with the flag turned
on
are involving super calls.)
Description:
Fix memento initialization when constructing from new
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1240833002/1
https://codereview.chromium.org/1240833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 2 (id:??) landed as
https://crrev.com/f22a6cfca276f1dc000d72b95b7e8087fa17c5f5
Cr-Commit-Position: refs/heads/master@{#29699}
https://codereview.chromium.org/1230813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm
https://codereview.chromium.org/1226123010/diff/20001/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/1226123010/diff/20001/src/ast.cc#newcode62
src/ast.cc:62: bool Expression::IsVariableProxyOrProperty() const {
I have a slight preference for
Committed patchset #1 (id:1)
https://codereview.chromium.org/1241533004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
1 - 100 of 225 matches
Mail list logo
