lgtm
https://codereview.chromium.org/459413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
lgtm
normally when we do this, we convert all the cctest files to use the new
api,
and we introduce one test for the old behaviour (as you've done).
Please do that either in this CL or an immediate follow up.
https://codereview.chromium.org/467013003/diff/1/include/v8.h
File include/v8.h
lgtm
https://codereview.chromium.org/467013003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/467013003/diff/1/include/v8.h#newcode3730
include/v8.h:3730: void SetGenericNamedPropertyHandler(
On 2014/08/13 10:45:39, wingo wrote:
On 2014/08/13 08:25:39, dcarney
lgtm, assuming this is something we want to expose. I don't see why it
would be
particularly. Andreas?
https://codereview.chromium.org/483173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
rossberg@ : what would you think of passing a struct containing all the
callbacks to SetNamedPropertyHandler?
It turns out we have a use case for having a GetNamedPropertyHandler
method, and
the struct would be ideal for that.
see https://code.google.com/p/chromium/issues/detail?id=404300#c20
Agreed wrt a struct making sense, but isn't it reasonable to also have an
old-style API? (Just trying to limit the scope of this patchset, as it
touches
runtime stuff and i have to keep rebasing that.)
There are some future interceptor changes that we will want the struct for,
and
we don't
lgtm
https://codereview.chromium.org/559913002/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):
https://codereview.chromium.org/559913002/diff/1/src/jsregexp.cc#newcode1602
src/jsregexp.cc:1602: // is it? For example, \u00C5 is equivalent to
\u212B.
On 2014/09/10 08:26:36, Yang wrote:
Reviewers: Benedikt Meurer,
Message:
ptal
Description:
[turbofan] don't call out to c
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/587273002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -237 lines):
M
Reviewers: Sven Panne,
Message:
ptal
Description:
fix compile for arm64 on mavericks
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/592063002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -3 lines):
M
Committed patchset #1 (id:1) manually as 24121 (presubmit successful).
https://codereview.chromium.org/592063002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Committed patchset #1 (id:60001) manually as 24122 (presubmit successful).
https://codereview.chromium.org/587273002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Reviewers: Michael Starzinger,
Message:
ptal
i still need to add unit tests
Description:
basic block profiler
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/593563005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
Okay, ben can you take a look? I'm working on unit tests now.
https://codereview.chromium.org/593563005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: titzer,
Message:
ptal
Description:
[turbofan] more verification of rpo
R=tit...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/603533002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+13, -15 lines):
M
Reviewers: Sven Panne,
Message:
ptal
Description:
convert disassembler to use OStream
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/598703003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+49, -90 lines):
M
everything addressed - ptal
starting to add unit tests
https://codereview.chromium.org/593563005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
On 2014/09/25 07:44:49, danno wrote:
Adding Dan as reviewer
lgtm if you add an instruction-selector unit test to verify matching
when the intel backend was first introduced, we didn't have the unit test
framework in place, but now that we do, all new selection changes should be
unit tested.
https://codereview.chromium.org/593563005/diff/290001/src/basic-block-profiler.h
File src/basic-block-profiler.h (right):
https://codereview.chromium.org/593563005/diff/290001/src/basic-block-profiler.h#newcode26
src/basic-block-profiler.h:26: int* block_ids() { return block_ids_[0];
}
On
Committed patchset #5 (id:80001) manually as 24214 (presubmit successful).
https://codereview.chromium.org/598703003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
https://codereview.chromium.org/593563005/diff/330001/src/compiler/basic-block-instrumentor.cc
File src/compiler/basic-block-instrumentor.cc (right):
https://codereview.chromium.org/593563005/diff/330001/src/compiler/basic-block-instrumentor.cc#newcode87
Reviewers: Michael Achenbach,
Description:
Version 3.28.71.13 (merged r24049)
Revert filter cross context eval
BUG=chromium:415051
LOG=N
R=machenb...@chromium.org
Please review this at https://codereview.chromium.org/600203003/
SVN Base: https://v8.googlecode.com/svn/branches/3.28
Affected
Committed patchset #1 (id:1) manually as 24241 (tree was closed).
https://codereview.chromium.org/600203003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: titzer,
Message:
ptal - check out the approach, i'm adding unit tests now
Description:
[turbofan] add new x64 addressing modes
R=tit...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/605693002/
SVN Base:
https://codereview.chromium.org/605693002/diff/80001/src/compiler/x64/instruction-selector-x64.cc
File src/compiler/x64/instruction-selector-x64.cc (right):
https://codereview.chromium.org/605693002/diff/80001/src/compiler/x64/instruction-selector-x64.cc#newcode77
Reviewers: Jakob,
Message:
Committed patchset #1 (id:40001) manually as 24256 (tree was closed).
Description:
initialize v8 early in unittests
BUG=
R=jkumme...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=24256
Please review this at
Committed patchset #19 (id:370001) manually as 24263 (presubmit successful).
https://codereview.chromium.org/593563005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Reviewers: marja,
Message:
Committed patchset #1 (id:1) manually as 24265 (tree was closed).
Description:
build fix - add missing inl include
TBR=ma...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=24265
Please review this at
https://codereview.chromium.org/605693002/diff/120001/src/compiler/x64/code-generator-x64.cc
File src/compiler/x64/code-generator-x64.cc (right):
https://codereview.chromium.org/605693002/diff/120001/src/compiler/x64/code-generator-x64.cc#newcode148
src/compiler/x64/code-generator-x64.cc:148:
Committed patchset #8 (id:160001) manually as 24267 (presubmit successful).
https://codereview.chromium.org/605693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
lgtm
https://codereview.chromium.org/609273002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: marja,
Message:
Committed patchset #1 (id:1) manually as 24272 (tree was closed).
Description:
fix win compilation after r24267
TBR=ma...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=24272
Please review this at
lgtm
https://codereview.chromium.org/609253002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
Message:
Committed patchset #2 (id:40001) manually as 24277 (presubmit successful).
Description:
[turbofan] add new ia32 addressing modes
R=bmeu...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=24277
Please review this at
Reviewers: marja,
Message:
Committed patchset #1 (id:1) manually as 24279 (tree was closed).
Description:
add missing inl includes
TBR=ma...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=24279
Please review this at https://codereview.chromium.org/612813002/
SVN
Reviewers: Benedikt Meurer,
Message:
ptal
Description:
[turbofan] x64 lea matching
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/615483003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+302, -56 lines):
M BUILD.gn
M
https://codereview.chromium.org/603533002/diff/1/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):
https://codereview.chromium.org/603533002/diff/1/src/compiler/scheduler.cc#newcode879
src/compiler/scheduler.cc:879: }
On 2014/09/25 14:52:58, titzer wrote:
Can we put this new
Reviewers: Benedikt Meurer,
Message:
ptal
Description:
[turbofan] cleanup x64 code generator a little
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/612573004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+109, -232
Committed patchset #2 (id:80001) manually as 24305 (presubmit successful).
https://codereview.chromium.org/612573004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Reviewers: marja,
Description:
Version 3.29.88.3 (merged r24251)
Script streaming: fix split UTF-8 character handling.
BUG=chromium:417891
LOG=N
R=ma...@chromium.org
Please review this at https://codereview.chromium.org/617753002/
SVN Base: https://v8.googlecode.com/svn/branches/3.29
https://codereview.chromium.org/617753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
https://codereview.chromium.org/615483003/diff/20001/src/compiler/node-matchers.h
File src/compiler/node-matchers.h (right):
https://codereview.chromium.org/615483003/diff/20001/src/compiler/node-matchers.h#newcode215
src/compiler/node-matchers.h:215: bool Matches() { return left_ != NULL;
}
On
Reviewers: marja,
Description:
Version 3.29.88.3 (merged r24251)
Script streaming: fix split UTF-8 character handling.
BUG=chromium:417891
LOG=N
R=ma...@chromium.org
Please review this at https://codereview.chromium.org/618613002/
SVN Base: https://v8.googlecode.com/svn/branches/3.29
Committed patchset #1 (id:1) manually as 24309.
https://codereview.chromium.org/618613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
On 2014/09/30 09:14:21, Benedikt Meurer wrote:
https://codereview.chromium.org/615483003/diff/20001/src/compiler/x64/instruction-codes-x64.h
File src/compiler/x64/instruction-codes-x64.h (right):
Reviewers: jarin,
Message:
Committed patchset #1 (id:1) manually as 24312 (presubmit successful).
Description:
fix nacl build after r24308
TBR=ja...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=24312
Please review this at
Committed patchset #5 (id:80001) manually as 24317 (presubmit successful).
https://codereview.chromium.org/615483003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Reviewers: Benedikt Meurer,
Message:
ptal
note: i undid a change to constant fold in the addressing mode matching
since
the graph should anyway have been reduced by this point and it's more
consistent
with x64
Description:
[turbofan] ia32 lea multiplication matching
Committed patchset #4 (id:60001) manually as 24318 (presubmit successful).
https://codereview.chromium.org/583963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
I added some tests. PTAL.
Thanks.
Sorry for the delay landing this. I didn't see your last message.
https://codereview.chromium.org/583963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
Committed patchset #1 (id:1) manually as 24326 (presubmit successful).
https://codereview.chromium.org/616833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Reviewers: Benedikt Meurer,
Message:
Committed patchset #1 (id:1) manually as 24327 (tree was closed).
Description:
[turbofan] instantiate and run InstructionSelectorMultTest for ia32
TBR=bmeu...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=24327
Please review
Reviewers: ,
Message:
ptal
Description:
[turbofan] intel lea add multiply matchers
BUG=
Please review this at https://codereview.chromium.org/614013002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+308, -71 lines):
M
ptal
https://codereview.chromium.org/614013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: Benedikt Meurer,
Message:
ptal
Description:
[turbofan] support all shift operands on ia32
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/619663002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+26, -20 lines):
Committed patchset #5 (id:80001) manually as 24357 (presubmit successful).
https://codereview.chromium.org/614013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Reviewers: Benedikt Meurer,
Message:
ptal
Description:
[turbofan] support all shift operands on x64
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/615223005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+152, -106 lines):
Committed patchset #1 (id:80001) manually as 24387 (presubmit successful).
https://codereview.chromium.org/619663002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Committed patchset #1 (id:40001) manually as 24388 (presubmit successful).
https://codereview.chromium.org/615223005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Reviewers: Benedikt Meurer,
Message:
ptal
Description:
fix imul(reg, op, imm) emission on x64
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/619903005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+20, -12 lines):
M
Committed patchset #2 (id:20001) manually as 24395 (presubmit successful).
https://codereview.chromium.org/619903005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
lgtm
https://codereview.chromium.org/620113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jarin,
Message:
ptal
Description:
[turbofan] compress live_in bitvectors
R=ja...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/626493002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+160, -38 lines):
M
lgtm
https://codereview.chromium.org/634493002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jarin,
Message:
ptal
Description:
[turbofan] map vregs early
R=ja...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/623313003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+55, -33 lines):
M src/compiler/instruction.h
lgtm
https://codereview.chromium.org/635513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/629983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:20001) manually as 24414 (presubmit successful).
https://codereview.chromium.org/623313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
..0fe0b0e380b0923ea5053aba12fc8380447af558
100644
--- a/src/compiler/instruction.h
+++ b/src/compiler/instruction.h
@@ -828,6 +828,8 @@ class InstructionSequence FINAL {
BasicBlock* GetBasicBlock(int instruction_index);
int GetVirtualRegister(const Node* node);
+ // TODO(dcarney): find a way
lgtm
i'm ooto, can someone land this?
https://codereview.chromium.org/639283003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group
Committed patchset #2 (id:20001) manually as 24541 (presubmit successful).
https://codereview.chromium.org/639283003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
lgtm
a unit test would be nice...
https://codereview.chromium.org/651783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Committed patchset #1 (id:1) manually as 24542 (presubmit successful).
https://codereview.chromium.org/641153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Reviewers: Benedikt Meurer,
Message:
Committed patchset #2 (id:170001) manually as 24545 (presubmit successful).
Description:
[turbofan] remove graph from InstructionSequence
R=bmeu...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=24545
Please review this at
lgtm
https://codereview.chromium.org/650843002/diff/110001/src/compiler/js-graph.h
File src/compiler/js-graph.h (right):
https://codereview.chromium.org/650843002/diff/110001/src/compiler/js-graph.h#newcode78
src/compiler/js-graph.h:78: // Creates a Int32Constant/Int64Constant
node,
lgtm
https://codereview.chromium.org/649083005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
https://codereview.chromium.org/646393002/diff/21/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/646393002/diff/21/src/compiler/instruction-selector.cc#newcode386
Committed patchset #2 (id:280001) manually as 24584 (presubmit successful).
https://codereview.chromium.org/646393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Reviewers: Benedikt Meurer,
Message:
Committed patchset #1 (id:1) manually as 24590 (tree was closed).
Description:
build fix
TBR=bmeu...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=24590
Please review this at https://codereview.chromium.org/652163002/
Base
lgtm
https://codereview.chromium.org/654833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Description:
Version 3.30.9.1 (merged r24603)
Correctly expand literal buffer for surrogate pairs.
BUG=chromium:423212
LOG=N
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/655563004/
Base URL: https://v8.googlecode.com/svn/trunk
Affected files
Committed patchset #1 (id:1) manually as 24605.
https://codereview.chromium.org/655563004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
) {
// TODO(titzer): these code comments are a giant memory leak.
Vectorchar buffer = Vectorchar::New(32);
- // TODO(dcarney): should not be rpo number there
- SNPrintF(buffer, -- B%d (rpo) start --, current_block_.ToInt());
+ SNPrintF(buffer, -- B%d start --, block_start
Reviewers: Toon Verwaest,
Message:
Committed patchset #1 (id:40001) manually as 24618 (presubmit successful).
Description:
Let FastCloneShallowObjectStub work with empty literal objects.
R=verwa...@chromium.org
LOG=N
BUG=417290
Committed: https://code.google.com/p/v8/source/detail?r=24618
: // TODO(dcarney): don't need
scratch in this case.
this comment still holds
https://codereview.chromium.org/651383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group
lgtm
https://codereview.chromium.org/651413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 (id:20001) manually as 24630 (presubmit successful).
https://codereview.chromium.org/603533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
lgtm
https://codereview.chromium.org/664473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/659253002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: marja,
Message:
Committed patchset #1 manually as r19621 (tree was closed).
Description:
Experimental parser: remove lexer-shell from tools/
TBR=ma...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=19621
Please review this at
Reviewers: marja,
Message:
Committed patchset #1 manually as r19625 (tree was closed).
Description:
Refactor lexer-shell settings
TBR=ma...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=19625
Please review this at https://codereview.chromium.org/184623002/
SVN
Reviewers: ,
Message:
Committed patchset #3 manually as r19659 (tree was closed).
Description:
Experimental parser: merge to r19637
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=19659
Please review this at https://codereview.chromium.org/185653004/
SVN Base:
(unicode_cache),
isolate_(source-GetIsolate()),
- // TODO(dcarney): don't need to allocate here, used stored positions
- source_handle_(isolate_-factory()-NewSubString(
- source, start_position, end_position)),
+ source_handle_(FlattenGetString(source)),
source_ptr_(NULL
Reviewers: marja,
Message:
Committed patchset #1 manually as r19665 (tree was closed).
Description:
Experimental parser: more cleanup after rebase
TBR=ma...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=19665
Please review this at
Reviewers: marja,
Message:
Committed patchset #1 manually as r19678 (tree was closed).
Description:
Experimental parser: make utf8 sort of work
TBR=ma...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=19678
Please review this at
Reviewers: marja,
Message:
Committed patchset #2 manually as r19682 (tree was closed).
Description:
Experimental parser: make lexer shell do something again
TBR=ma...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=19682
Please review this at
Committed patchset #1 manually as r19740 (presubmit successful).
https://codereview.chromium.org/177343002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r19741 (presubmit successful).
https://codereview.chromium.org/179983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #2 manually as r19744 (presubmit successful).
https://codereview.chromium.org/173853005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/190503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/189463019/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/189463019/diff/1/include/v8.h#newcode840
include/v8.h:840: V8_INLINE bool SetReturnValueFrom(const K key,
just SetReturnValue
1 - 100 of 1319 matches
Mail list logo
