Re: [vchkpw] adding domains error

2003-11-21 Thread Michael Bowe
- Original Message - 
From: "Tom Collins" <[EMAIL PROTECTED]>
To: "vpopmail list" <[EMAIL PROTECTED]>
Sent: Wednesday, October 22, 2003 3:26 AM
Subject: Re: [vchkpw] adding domains error


> On Tuesday, October 21, 2003, at 09:11  AM, Trey Nolen wrote:
> > After upgrading to 5.3.29, we are getting the following error when 
> > trying to
> > add a domain:
> > Error: (vadduser) can't read domain limits
> 
> If you have a ~vpopmail/etc/vlimits.default file, it should work.
> 
> I'll look into having the install process create that file if it 
> doesn't already exist.
> 
> Should we update the code so that it doesn't generate an error if 
> neither .qmailadmin-limits or vlimits.default exist?

I think that this is a very important issue that needs to be resolved
before the 5.3-devel series goes to 5.4 stable.

Why should vpopmail fail to work when this file is missing ?

Surely if the file is missing, the vpopmail should just work as it
always has in the past... ie implement no limit

Domain limits are not required at many sites, it should be an 
optional feature that can be implemented by sites that
need it.

And while we are on the subject, under this new limits system,
is the value input into the --enable-defaultquota configure switch 
still used by vpopmail at all? If not, it needs to be removed.

Michael.



Re: [vchkpw] adding domains error

2003-10-22 Thread Tom Collins
On Wednesday, October 22, 2003, at 10:53  AM, Charles Sprickman wrote:
On Tue, 21 Oct 2003, Tom Collins wrote:
On Tuesday, October 21, 2003, at 09:11  AM, Trey Nolen wrote:
After upgrading to 5.3.29, we are getting the following error when
trying to
add a domain:
Error: (vadduser) can't read domain limits
If you have a ~vpopmail/etc/vlimits.default file, it should work.
Before I jump to .29, what's the behaviour if I don't have that file 
but I
do use mysql limits?

I'll look into having the install process create that file if it
doesn't already exist.
Same question as above...
I'm really not sure.  I've spent a limited amount of time with the 
limits code, and haven't looked at how it behaves under MySQL.

Unfortunately, I'm spending most of today getting ready for a 26-day 
trip to Australia.  With the limits problem and the APOP error, I'm 
tempted to recommend that users stick with 5.3.28 for now.  I don't 
plan to do any vpopmail development while I'm away (and may even 
unsubscribe from the mailing lists) and the APOP error is fairly 
serious.

If someone can track down the error and get a fix in, I'll make an 
updated release along with my code that creates vlimits.default.

--
Tom Collins  -  [EMAIL PROTECTED]
Note: The Tom Logic offices will be closed October 23 to November 18.
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/



Re: [vchkpw] adding domains error

2003-10-22 Thread Charles Sprickman
On Tue, 21 Oct 2003, Tom Collins wrote:

> On Tuesday, October 21, 2003, at 09:11  AM, Trey Nolen wrote:
> > After upgrading to 5.3.29, we are getting the following error when
> > trying to
> > add a domain:
> > Error: (vadduser) can't read domain limits
>
> If you have a ~vpopmail/etc/vlimits.default file, it should work.

Before I jump to .29, what's the behaviour if I don't have that file but I
do use mysql limits?

> I'll look into having the install process create that file if it
> doesn't already exist.

Same question as above...

Thanks,

Charles

> Should we update the code so that it doesn't generate an error if
> neither .qmailadmin-limits or vlimits.default exist?
>
> --
> Tom Collins  -  [EMAIL PROTECTED]
> Note: The Tom Logic offices will be closed October 23 to November 18.
> QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
> Info on the Sniffter hand-held Network Tester: http://sniffter.com/
>
>
>



Re: [vchkpw] adding domains error

2003-10-21 Thread Jochen Schug
Tom Collins wrote:

On Tuesday, October 21, 2003, at 12:50  PM, Jochen Schug wrote:

# quota for entire domain, in megabytes
# example shows a domain with a 100MB quota and a limit of 10,000 
messages
#quota  100


Unless the behaviour changed, shouldn't this read 104857600 instead 
of 100?
Actually, that's a little inconsistency we have right now.
I checked my existing .qmailadmin-limits file for the values that are 
written by vmoddomlimits, that's where I got the 104857600 from.

maildirquota.c multiplies the number by 1024*1024, so it definitely 
considers it MB.

vmoddomlimits writes it out exactly as provided on the command line, 
which probably isn't a good idea now that we allow KB and MB modifiers 
(since if I say "-Q 100M", I want 100MB, not 100TB).  The reason it's 
currently parsed, was in response to earlier bug reports that it 
wasn't (and it wasn't because it shouldn't have been).

I've updated vmoddomlimits to indicate that the -Q option is megabytes 
and -q is bytes.  The -S options adds "MB" after the domain quota and 
"bytes" after the default user quota when displaying the information.
Ok, fair enough. But - again just my humble opinion - this introduces 
two different metrics the user/admin has to get right... changing the 
code in maildirquota.c so that it expects a value in bytes instead of 
megabytes, and consitent metrics for vmoddomlimits' -q and -Q options 
(incl. parsing of the latter) would be easier to handle.


A general question regarding domain limits: What would be the correct 
behaviour when I add a new domain and have the limits in 
~vpopmail/etc/vlimits.default? Should a .qmaladmin-limits under the 
new domain, with the data from the default file, be created? Or 
should such a domain automatically refer to the data from default 
file (-> when I change the defaults, all existing domains with no 
.qmailadmin-limits are affected by the change)?
Current (and I think the expected) behavior is to not create a 
.qmailadmin-limits file.  For sites that don't have domain-specific 
limits, this allows for easy updating of limits.
Exactly... this can be good or bad, depending on whether or not this is 
desired by the user. I really don't know what's better :) Maybe giving 
the user the choice (by adding another option to vadddomain) to copy or 
"symlink" the defaults would be a convenient solution.

I noticed that there's no .qmailadmin-limits file created when I add 
a new domain, but when I check the domain limits with vmoddomlimits 
-S, the default values from the time when I added the domain are 
shown (even when I edit the vlimits-default file in the meantime). 
Where do these values come from?
They come from ~vpopmail/etc/vlimits.default (not vlimits-default).  I 
checked on my system, and after modifying vlimits.default, 
vmoddomlimits -S reported the updated values.
You're right - I tried it again, and it works as expected... don't know 
what I did before, I was pretty sure that I saw the behaviour as I 
stated above. Sorry for the false alarm.

Regards
Jochen




Re: [vchkpw] adding domains error

2003-10-21 Thread Tom Collins
On Tuesday, October 21, 2003, at 12:44  PM, Justin Heesemann wrote:
i'll do it.

guess that means yet another -o ption :)
Couldn't you just use/modify the defaults if they didn't specify a 
domain name?

Running `vmoddomlimits -S` would show the defaults, any other flags 
would make the necessary changes to the default domain.

Then again, it's probably safer to add something like "-d" to use the 
default settings.

--
Tom Collins  -  [EMAIL PROTECTED]
Note: The Tom Logic offices will be closed October 23 to November 18.
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/



Re: [vchkpw] adding domains error

2003-10-21 Thread Tom Collins
On Tuesday, October 21, 2003, at 12:50  PM, Jochen Schug wrote:
# quota for entire domain, in megabytes
# example shows a domain with a 100MB quota and a limit of 10,000 
messages
#quota  100
Unless the behaviour changed, shouldn't this read 104857600 instead of 
100?
Actually, that's a little inconsistency we have right now.

maildirquota.c multiplies the number by 1024*1024, so it definitely 
considers it MB.

vmoddomlimits writes it out exactly as provided on the command line, 
which probably isn't a good idea now that we allow KB and MB modifiers 
(since if I say "-Q 100M", I want 100MB, not 100TB).  The reason it's 
currently parsed, was in response to earlier bug reports that it wasn't 
(and it wasn't because it shouldn't have been).

I've updated vmoddomlimits to indicate that the -Q option is megabytes 
and -q is bytes.  The -S options adds "MB" after the domain quota and 
"bytes" after the default user quota when displaying the information.

A general question regarding domain limits: What would be the correct 
behaviour when I add a new domain and have the limits in 
~vpopmail/etc/vlimits.default? Should a .qmaladmin-limits under the 
new domain, with the data from the default file, be created? Or should 
such a domain automatically refer to the data from default file (-> 
when I change the defaults, all existing domains with no 
.qmailadmin-limits are affected by the change)?
Current (and I think the expected) behavior is to not create a 
.qmailadmin-limits file.  For sites that don't have domain-specific 
limits, this allows for easy updating of limits.

I noticed that there's no .qmailadmin-limits file created when I add a 
new domain, but when I check the domain limits with vmoddomlimits -S, 
the default values from the time when I added the domain are shown 
(even when I edit the vlimits-default file in the meantime). Where do 
these values come from?
They come from ~vpopmail/etc/vlimits.default (not vlimits-default).  I 
checked on my system, and after modifying vlimits.default, 
vmoddomlimits -S reported the updated values.

--
Tom Collins  -  [EMAIL PROTECTED]
Note: The Tom Logic offices will be closed October 23 to November 18.
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/



Re: [vchkpw] adding domains error

2003-10-21 Thread Jochen Schug
Tom Collins wrote:

On Tuesday, October 21, 2003, at 11:28  AM, Jochen Schug wrote:

Is there a documentation about what these values mean? What's the 
difference between quota, default_quota, perm_quota and 
perm_defaultquota?
Here's the file I built for the distribution which includes some 
details on what everything means.
Thanks, Tom :)  That explains it well.

# Default limits file.  This file is used for domains without a
# .qmailadmin-limits file.
# maximums for each account type, -1 = unlimited
maxpopaccounts  -1
maxforwards -1
maxautoresponders   -1
maxmailinglists -1
# quota for entire domain, in megabytes
# example shows a domain with a 100MB quota and a limit of 10,000 
messages
#quota  100
Unless the behaviour changed, shouldn't this read 104857600 instead of 100?

A general question regarding domain limits: What would be the correct 
behaviour when I add a new domain and have the limits in 
~vpopmail/etc/vlimits.default? Should a .qmaladmin-limits under the new 
domain, with the data from the default file, be created? Or should such 
a domain automatically refer to the data from default file (-> when I 
change the defaults, all existing domains with no .qmailadmin-limits are 
affected by the change)?

I noticed that there's no .qmailadmin-limits file created when I add a 
new domain, but when I check the domain limits with vmoddomlimits -S, 
the default values from the time when I added the domain are shown (even 
when I edit the vlimits-default file in the meantime). Where do these 
values come from?

Regards
Jochen



Re: [vchkpw] adding domains error

2003-10-21 Thread Justin Heesemann
On Tuesday 21 October 2003 20:01, Tom Collins wrote:
> On Tuesday, October 21, 2003, at 10:41  AM, Justin Heesemann wrote:
>
> > a better way would be to have vmoddomlimits create one for one
> > domain 
 of
> > yours, and then copy that
> > ~vpopmail/domains/domain.com//.qmailadmin-limits file to
> > ~vpopmail/etc/vlimits.default
>
> 
> It would be nice if someone could update vmoddomlimits to allow the 
> user to show/modify the defaults stored in vlimits.default somehow.
> 
> Any volunteers?
>
i'll do it.

guess that means yet another -o ption :)

-- 
Mit internetten Grüßen / Best Regards
---
Justin Heesemannionium Technologies
[EMAIL PROTECTED]www.ionium.org



Re: [vchkpw] adding domains error

2003-10-21 Thread Tom Collins
On Tuesday, October 21, 2003, at 11:28  AM, Jochen Schug wrote:
Is there a documentation about what these values mean? What's the 
difference between quota, default_quota, perm_quota and 
perm_defaultquota?
Here's the file I built for the distribution which includes some 
details on what everything means.

# Default limits file.  This file is used for domains without a
# .qmailadmin-limits file.
# maximums for each account type, -1 = unlimited
maxpopaccounts  -1
maxforwards -1
maxautoresponders   -1
maxmailinglists -1
# quota for entire domain, in megabytes
# example shows a domain with a 100MB quota and a limit of 10,000 
messages
#quota  100
#maxmsgcount1

# default quota for newly created users (in bytes)
# example shows a user with a 10MB quota and a limit of 1000 messages
#default_quota  10485760
#default_maxmsgcount1000
# uncomment the following lines to disable certain features
#disable_pop
#disable_imap
#disable_dialup
#disable_password_changing
#disable_external_relay
#disable_smtp
#disable_webmail
# Set bitflags on account management for non-postmaster admins.
# To disable certain features, add the following bits:
#   Create = 1, Modify = 2, Delete = 4
# So, to allow modification but not creation or deletion of
# POP/IMAP accounts, set perm_account to 5.
perm_account0
perm_alias  0
perm_forward0
perm_autoresponder  0
perm_maillist   0
perm_quota  0
perm_defaultquota   0
--
Tom Collins  -  [EMAIL PROTECTED]
Note: The Tom Logic offices will be closed October 23 to November 18.
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/



Re: [vchkpw] adding domains error

2003-10-21 Thread Jochen Schug
Justin Heesemann wrote:

a vlimits.default file might look like

maxpopaccounts: -1
maxaliases: -1
maxforwards: -1
maxautoresponders: -1
maxmailinglists: -1
quota: 0
maxmsgcount: 0
default_quota: 0
default_maxmsgcount: 0
perm_account: 0
perm_alias: 0
perm_forward: 0
perm_autoresponder: 0
perm_maillist: 0
perm_quota: 0
perm_defaultquota: 0
(which ofcourse doesn't limit anything at all ;)
 

Is there a documentation about what these values mean? What's the 
difference between quota, default_quota, perm_quota and perm_defaultquota?

a better way would be to have vmoddomlimits create one for one domain of 
yours, and then copy that 
~vpopmail/domains/domain.com//.qmailadmin-limits file to 
~vpopmail/etc/vlimits.default

Why is there a different name for the same thing? Having a 
~vpopmail/etc/.qmailadmin-limits.default would be more consistent IMHO...

Regards
Jochen



Re: [vchkpw] adding domains error

2003-10-21 Thread Jochen Schug
X-Istence wrote:

Tom Collins wrote:

On Tuesday, October 21, 2003, at 09:11  AM, Trey Nolen wrote:

After upgrading to 5.3.29, we are getting the following error when 
trying to
add a domain:
Error: (vadduser) can't read domain limits
If you have a ~vpopmail/etc/vlimits.default file, it should work.

Ok, this seems to be a new requirement for 5.3.29 - after creating the 
file with the default values Justin mentioned in another mail, it works 
now for me, too.

I'll look into having the install process create that file if it 
doesn't already exist.

Good idea :)

Should we update the code so that it doesn't generate an error if 
neither .qmailadmin-limits or vlimits.default exist?
It shouldnt generate an error if either doesnt exist. As it would then 
make the admin freak.
I see three possible solutions:
- Creating the missing file with the default values (i.e. no limits) if 
it doesn't exist.
- Don't create the file, but don't complain about it either. Just use 
the default values as with before 5.3.29
- Throw an error message, and point out how to fix it (i.e. provide a 
vlimits.default-example file with the installation)

Also in your post about the new release, i suggest you take a look at 
the problems the person had, and see how those happened :)
That was me ;) As mentioned above, creating the vlimits.default file 
solved the problems for me, too.

Regards
Jochen



Re: [vchkpw] adding domains error

2003-10-21 Thread Tom Collins
On Tuesday, October 21, 2003, at 10:41  AM, Justin Heesemann wrote:
a better way would be to have vmoddomlimits create one for one domain 
of
yours, and then copy that
~vpopmail/domains/domain.com//.qmailadmin-limits file to
~vpopmail/etc/vlimits.default
It would be nice if someone could update vmoddomlimits to allow the 
user to show/modify the defaults stored in vlimits.default somehow.

Any volunteers?

--
Tom Collins  -  [EMAIL PROTECTED]
Note: The Tom Logic offices will be closed October 23 to November 18.
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/



Re: [vchkpw] adding domains error

2003-10-21 Thread Justin Heesemann
On Tuesday 21 October 2003 18:40, Trey Nolen wrote:
> > Should we update the code so that it doesn't generate an error if
> > neither .qmailadmin-limits or vlimits.default exist?

> That would be good because I'm sure there are a lot of servers like
> ours out
 there that don't have either file in most of their existing
> domains. 
Oh, and i forgot to mention:
you don't need an .qmailadmin-limits file for every domain, but just the 
vlimits.default file (in ~vpopmail/etc/) to make the error message 
disappear.

a vlimits.default file might look like

maxpopaccounts: -1
maxaliases: -1
maxforwards: -1
maxautoresponders: -1
maxmailinglists: -1
quota: 0
maxmsgcount: 0
default_quota: 0
default_maxmsgcount: 0
perm_account: 0
perm_alias: 0
perm_forward: 0
perm_autoresponder: 0
perm_maillist: 0
perm_quota: 0
perm_defaultquota: 0


(which ofcourse doesn't limit anything at all ;)

a better way would be to have vmoddomlimits create one for one domain of 
yours, and then copy that 
~vpopmail/domains/domain.com//.qmailadmin-limits file to 
~vpopmail/etc/vlimits.default


-- 
Mit internetten Grüßen / Best Regards
---
Justin Heesemannionium Technologies
[EMAIL PROTECTED]www.ionium.org



Re: [vchkpw] adding domains error

2003-10-21 Thread Justin Heesemann
On Tuesday 21 October 2003 18:40, Trey Nolen wrote:
> >
> > If you have a ~vpopmail/etc/vlimits.default file, it should work.
> >
> > I'll look into having the install process create that file if it
> > doesn't already exist.
> >
> > Should we update the code so that it doesn't generate an error if
> > neither .qmailadmin-limits or vlimits.default exist?
>
> 
> That would be good because I'm sure there are a lot of servers like
> ours out
 there that don't have either file in most of their existing
> domains. 
> Trey

an error should be generated and a default limits file should be 
installed (if there is no old one, or maybe call it  
vlimits.default-dist)

vpopmail also has the mysql config file, which the admin has to create.. 
should we update the code, so it doesn't generate an error, if it can't 
connect to mysql too ? :)

-- 
Mit internetten Grüßen / Best Regards
---
Justin Heesemannionium Technologies
[EMAIL PROTECTED]www.ionium.org



Re: [vchkpw] adding domains error

2003-10-21 Thread Trey Nolen

>
> If you have a ~vpopmail/etc/vlimits.default file, it should work.
>
> I'll look into having the install process create that file if it
> doesn't already exist.
>
> Should we update the code so that it doesn't generate an error if
> neither .qmailadmin-limits or vlimits.default exist?

That would be good because I'm sure there are a lot of servers like ours out
there that don't have either file in most of their existing domains.

Trey





Re: [vchkpw] adding domains error

2003-10-21 Thread X-Istence
Tom Collins wrote:

On Tuesday, October 21, 2003, at 09:11  AM, Trey Nolen wrote:

After upgrading to 5.3.29, we are getting the following error when 
trying to
add a domain:
Error: (vadduser) can't read domain limits


If you have a ~vpopmail/etc/vlimits.default file, it should work.

I'll look into having the install process create that file if it 
doesn't already exist.

Should we update the code so that it doesn't generate an error if 
neither .qmailadmin-limits or vlimits.default exist?

--
Tom Collins  -  [EMAIL PROTECTED]
Note: The Tom Logic offices will be closed October 23 to November 18.
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/
It shouldnt generate an error if either doesnt exist. As it would then 
make the admin freak.

Also in your post about the new release, i suggest you take a look at 
the problems the person had, and see how those happened :)




Re: [vchkpw] adding domains error

2003-10-21 Thread Tom Collins
On Tuesday, October 21, 2003, at 09:11  AM, Trey Nolen wrote:
After upgrading to 5.3.29, we are getting the following error when 
trying to
add a domain:
Error: (vadduser) can't read domain limits
If you have a ~vpopmail/etc/vlimits.default file, it should work.

I'll look into having the install process create that file if it 
doesn't already exist.

Should we update the code so that it doesn't generate an error if 
neither .qmailadmin-limits or vlimits.default exist?

--
Tom Collins  -  [EMAIL PROTECTED]
Note: The Tom Logic offices will be closed October 23 to November 18.
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/