Michal Skrivanek has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65059
To unsubscribe, visit https://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: osinfo: drop package buildtime
..
Patch Set 3: Code-Review+1
I casually checked engine 3.0 and it's not used there either
--
To view, visit https
Michal Skrivanek has posted comments on this change.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65182/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py
Michal Skrivanek has posted comments on this change.
Change subject: osinfo: properly parse kernel compile time
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py
Michal Skrivanek has posted comments on this change.
Change subject: osinfo: properly parse kernel compile time
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py
Michal Skrivanek has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
It is out of scope of this patch. But the series of patches
Michal Skrivanek has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2: Code-Review-1
if this is supposed to bring official ovs
Michal Skrivanek has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 4:
>During vm migration we invoke a libvirt hook: vm_migrate_hook.py.
>This was added re
Michal Skrivanek has posted comments on this change.
Change subject: net: Ignore missing graphics from VM conf on target host
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64300/1/vdsm/virt/vm_migrate_hook.py
File
Michal Skrivanek has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 4: Code-Review-1
I don't think we want to have plugins of plugins. What for? Why not build
Michal Skrivanek has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65007
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: virt: Try to detect non guest iniated shutdowns
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/64991/3/lib/vdsm/virt/guestagent.py
File lib/vdsm
Michal Skrivanek has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18:
(3 comments)
indeed we should avoid semantics change, but please do not split into hundred
little patches
Michal Skrivanek has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64499
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18:
2:1 for line removals, that's always a good thing!
--
To view, visit https://gerrit.ovirt.org/61475
Michal Skrivanek has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 1:
backport to 4.0 as well, i suppose
--
To view, visit https://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64468
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py
File vdsm/virt
Michal Skrivanek has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py
File vdsm/virt
Michal Skrivanek has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 6:
(6 comments)
https://gerrit.ovirt.org/#/c/62873/4/vdsm/virt/migration.py
File vdsm/virt
Michal Skrivanek has posted comments on this change.
Change subject: logging: More standard logging format
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: logging: More standard logging format
..
Patch Set 3: Code-Review-1
I would hate to see the thread id somewhere deep, it is THE most critical thing
Michal Skrivanek has posted comments on this change.
Change subject: vm: avoid mark unresponsive on startup
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/63008/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 514
Michal Skrivanek has posted comments on this change.
Change subject: api: emit warnings only if configured
..
Patch Set 1:
yeah:) though I suppose we will soon replace the logging with something better
globally, and re-enable
Michal Skrivanek has posted comments on this change.
Change subject: api: emit warnings only if configured
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62186
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 1:
does it work on ppc64le? I thought not
--
To view, visit https://gerrit.ovirt.org/61984
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/60533/1/README.logging
File
Michal Skrivanek has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/32504
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: xmlrpc: Hide fenceNode password in the log
..
Patch Set 1: Code-Review+1
doesn't look too risky to me (this particular backport), and it improves
security
Michal Skrivanek has posted comments on this change.
Change subject: migration: usage of single reactor in vdsm
..
Patch Set 1: Verified+1
patch was verified on 4.0 as of yesterday as well
--
To view, visit https
Michal Skrivanek has posted comments on this change.
Change subject: migration: usage of single reactor in vdsm
..
Patch Set 5: Code-Review+1
Milan managed to check the resources too,looks ok, so let's proceed
--
To view
Michal Skrivanek has posted comments on this change.
Change subject: migration: usage of single reactor in vdsm
..
Patch Set 5:
Milan, did you have a chance to check for resource leaks?
--
To view, visit https
Michal Skrivanek has posted comments on this change.
Change subject: migration: use reactor per connection
..
Patch Set 3:
I don't think CI have such a case. Would need to be done manually I suppose.
And the leak verification
Michal Skrivanek has posted comments on this change.
Change subject: migration: use reactor per connection
..
Patch Set 3:
This is an urgent patch, if we don't manage to do that in time for 4.0.1 we
should proceed with extra
Michal Skrivanek has posted comments on this change.
Change subject: migration: use reactor per connection
..
Patch Set 3: Verified-1
Can we doublecheck there is no resource leak, similar to how we chased leaks
not so long
Michal Skrivanek has posted comments on this change.
Change subject: spec: consume fix for rhbz#1339963
..
Patch Set 9:
this just underlines the discussion on host upgrade. we can't really continue
this way and create bugs
Michal Skrivanek has posted comments on this change.
Change subject: migration: use reactor per connection
..
Patch Set 2:
Verified by couple hundred migrations in few hours on Sefi's setup with
4.18.4-2 plus this patch
Michal Skrivanek has posted comments on this change.
Change subject: migration: use reactor per connection
..
Patch Set 2: Verified+1
seems to work. let's verify a bit more thoroughly
--
To view, visit https
Michal Skrivanek has posted comments on this change.
Change subject: migration: use reactor per connection
..
Patch Set 1: Verified-1
tried to apply on Sefi's setup, but didn't seem to work ok. It's not 100%
confirmation
Michal Skrivanek has posted comments on this change.
Change subject: suppport: 3.5 not supported in 4.x
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59504
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: adding support for version 4.1
..
Patch Set 2:
(1 comment)
please remove the exception for ppc, other than that +1
https://gerrit.ovirt.org/#/c/59308
Michal Skrivanek has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/58465/17/vdsm/API.py
File vdsm/API.py:
Line 1344
Michal Skrivanek has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/58465/17/vdsm/API.py
File vdsm/API.py:
Line 1344
Michal Skrivanek has posted comments on this change.
Change subject: xmlrpc: Hide fenceNode password in the log
..
Patch Set 4:
hey Toni, thanks for comments!:) Though let's just merge, it's about a fifth
time we're arguing
Michal Skrivanek has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4:
Nir - so, this is a method in utils, implying it's a generic method which
should work
Michal Skrivanek has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4: Code-Review+1
Nir, I suppose you've meant all your comments as an idea for followup
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphics: enforce spice default mode
..
Patch Set 4: Code-Review+1
I don't think fedora jenkins works ok
--
To view, visit https://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphics: enforce spice default mode
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/56746/3/vdsm/virt/vmdevices/graphics.py
Michal Skrivanek has posted comments on this change.
Change subject: mkimage: mk_sysprep_floppy to supervdsm
..
Patch Set 2:
I'd much rather see it go away instead. We want to eliminate floppy and forget
about it;)
sysprep
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphics: open nontls port only if requested
..
Patch Set 2: Code-Review+1
nice 4.0 change. Docs need to be updated because now we have twice as many
Michal Skrivanek has posted comments on this change.
Change subject: migration: added logging of more detailed stats
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/55976/14/vdsm/virt/migration.py
File vdsm/virt
Michal Skrivanek has posted comments on this change.
Change subject: migration: added logging of more detailed stats
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55976
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: hostdev: ignore scsi devices when retrieving addresses
..
Patch Set 6: Code-Review+1
tested by a RHEV user
--
To view, visit https://gerrit.ovirt.org/55957
Michal Skrivanek has posted comments on this change.
Change subject: hostdev: ignore scsi devices when retrieving addresses
..
Patch Set 4: Code-Review+1
(1 comment)
please tag as 3.6-only
https://gerrit.ovirt.org/#/c/55957
Michal Skrivanek has posted comments on this change.
Change subject: hostdev: ignore scsi devices when retrieving addresses
..
Patch Set 3: -Code-Review
let's discuss the possible hacky code for 3.6 only. It is tested
Michal Skrivanek has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 5:
I know this is one of the reasons we're doing that for, but better safe than
sorry - please verify
Michal Skrivanek has posted comments on this change.
Change subject: migration: added logging of more detailed stats
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55976
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: migration: added logging of more detailed stats
..
Patch Set 7:
(except too long lines;-)
--
To view, visit https://gerrit.ovirt.org/55976
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: migration: added logging of more detailed stats
..
Patch Set 7: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/55976/7/vdsm/virt/migration.py
File
Michal Skrivanek has posted comments on this change.
Change subject: migration: added logging of more detailed stats
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/55976/2/vdsm/virt/migration.py
File vdsm/virt
Michal Skrivanek has posted comments on this change.
Change subject: Revert "hostdev/sr-iov: don't reattach devices"
..
Patch Set 1: Code-Review-1
IIUC, -1 on master as the engine should be fixed to not require
Michal Skrivanek has posted comments on this change.
Change subject: Revert "hostdev: don't implicitly reattach devices"
..
Patch Set 1: Code-Review-1
this may make sense for 3.6, but on master the engine code shou
Michal Skrivanek has posted comments on this change.
Change subject: migration: added logging of more detailed stats
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/55976/1/vdsm/virt/migration.py
File
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27:
so, after checking, the code is ok. but it is certainly fragile
--
To view, visit https
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27:
What I was(and still am) concerned about is the case progress is 100 from other
place. The monitor
Michal Skrivanek has posted comments on this change.
Change subject: hostdev: ignore scsi devices when retrieving addresses
..
Patch Set 3:
do we have a tag for 3.6 only?
--
To view, visit https://gerrit.ovirt.org/55957
Michal Skrivanek has posted comments on this change.
Change subject: hostdev: ignore scsi devices when retrieving addresses
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/27/vdsm/virt/migration.py
File vdsm/virt/migration.py
Michal Skrivanek has posted comments on this change.
Change subject: spec: bump libguestfs-tools-c requirement
..
Patch Set 3: Code-Review+1
everything's ready
--
To view, visit https://gerrit.ovirt.org/55375
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 3:
@francesco: I tried to describe that in previous comment. (and i had a longer
version which i lost
Michal Skrivanek has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 3:
well, to make it clear - the values are intentionally conservative as I would
want to do this change
Michal Skrivanek has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 2:
we're testing that a bit more with mpolednik. so far the best values seem to be:
concurrency 2
Michal Skrivanek has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 2: Code-Review-1
Didn't we talk about 54?;) it's an increase from 768Mbps to 864Mbps, but that
should
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/52799/23/lib/vdsm/config.py.in
File lib/vdsm
Michal Skrivanek has posted comments on this change.
Change subject: spec: bump libguestfs-tools-c requirement
..
Patch Set 1: Code-Review-1
I believe this version does _not_ contain the fix yet
--
To view, visit https
Michal Skrivanek has posted comments on this change.
Change subject: configurator: libvirt: do not jump on virtlogd
..
Patch Set 1: Code-Review+1
might be good to open bug e.g. on 4.1(or whatever is the most distant
available
Michal Skrivanek has posted comments on this change.
Change subject: spec: bump safelease version
..
Patch Set 6:
this doesn't really bring in virt-v2v, right? I see only the libguestfs tool
update(in 54797). Ultimately we
Michal Skrivanek has posted comments on this change.
Change subject: hostdev/sr-iov: don't reattach devices
..
Patch Set 3:
please document in a (suitable) bug the change in behavior and how to reattach
the device should
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 20:
I agree with mbetak. Plus this aligns with existing mechanism of queueing
migrations by vdsm itself
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 18:
@ykaul: yes, scheduling should solve it most of the times, this is just a
safeguard. Following
Michal Skrivanek has posted comments on this change.
Change subject: freeze: Freeze guest even when creating memory snapshot
..
Patch Set 6: -Code-Review
did you reopen it due to the corruption with ceph disks?
--
To view
Michal Skrivanek has posted comments on this change.
Change subject: vmstats: remove useless short stacktrace
..
Patch Set 7:
Dan, in a sense it's common - any time around VM lifecycle changes we get a
bunch of errors from
Michal Skrivanek has posted comments on this change.
Change subject: virt: safer handling of migration parameters
..
Patch Set 2:
merge?
--
To view, visit https://gerrit.ovirt.org/52342
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vm: safer handling of conf in restore
..
Patch Set 2:
merge?
--
To view, visit https://gerrit.ovirt.org/52343
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: migration: use context manager for semaphore
..
Patch Set 2:
merge?
--
To view, visit https://gerrit.ovirt.org/52341
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 4: Code-Review+1
as Piotr suggested we may want to expose it differently in the future, but I
don't see
Michal Skrivanek has posted comments on this change.
Change subject: virt: safer handling of migration parameters
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52342/1//COMMIT_MSG
Commit Message:
Line 26:
Line 27
Michal Skrivanek has posted comments on this change.
Change subject: migration: use context manager for semaphore
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52341/1//COMMIT_MSG
Commit Message:
Line 19:
Line 20
Michal Skrivanek has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 3: Code-Review+1
sure, better than nothing
--
To view, visit https://gerrit.ovirt.org/51708
Michal Skrivanek has posted comments on this change.
Change subject: lib: use weakmethod to break reference cycles
..
Patch Set 3: Code-Review+1
this is a backporting material - we don't want to change behavior of killing
Michal Skrivanek has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/51786/3//COMMIT_MSG
Commit Message:
Line 11:
Line 12:
Line 13
Michal Skrivanek has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51786
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/51786/2/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py
Michal Skrivanek has posted comments on this change.
Change subject: migration: use context manager for semaphore
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51655
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/51786/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line
Michal Skrivanek has posted comments on this change.
Change subject: lib: avoid circular references due to wrapping
..
Patch Set 2:
keep in mind we need something backportable, and something proper for long
term. those can
1 - 100 of 799 matches
Mail list logo
