gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 28:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: migration: Add retry on full capacity
..
migration: Add retry on full capacity
Utilize the new error code 'migrateLimit' to differentiate between
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27:
it is fragile, but because of the existing conditions, we cannot make things
much better without a
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27:
so, after checking, the code is ok. but it is certainly fragile
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27:
What I was(and still am) concerned about is the case progress is 100 from other
place. The monitor
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/52799/27/vdsm/virt/migration.py
File
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/27/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27: Code-Review+1
(1 comment)
temporary lowering score because of further comments
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/27/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/52799/27/vdsm/virt/migration.py
File
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 26:
(2 comments)
https://gerrit.ovirt.org/#/c/52799/26/vdsm/virt/migration.py
File
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 27:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 26:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/26/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 26: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 25:
(2 comments)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/25/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/25/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/25/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/25/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 25: Code-Review-1
(3 comments)
ok, we just need a couple of minor fixed and that's it. -1 for visibility.
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23: Code-Review-1
(1 comment)
few comments accumulated, I think a resubmit is needed :\
-1 for
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(2 comments)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(2 comments)
https://gerrit.ovirt.org/#/c/52799/23/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/52799/23/lib/vdsm/config.py.in
File
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(3 comments)
https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
(5 comments)
If we want the retry logic, codewise is mostly OK, but there are few possible
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 22: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 20:
I agree with mbetak. Plus this aligns with existing mechanism of queueing
migrations by vdsm itself
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 20:
@Yaniv: Indeed it is true that scheduler in ideal scenario should cover 99% of
cases. This code is there
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Yaniv Kaul has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 19:
Again, unsure why VDSM would do that and not engine. Only in the remote case
where engine disconnected and
Martin Polednik has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 20:
I agree with Yaniv. Scheduler should consider choosing different destination
(and be aware of current
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/18/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 439:
Michal Skrivanek has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 18:
@ykaul: yes, scheduling should solve it most of the times, this is just a
safeguard. Following the
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 18: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 18: Code-Review+1
(3 comments)
Looks good, but a couple of questions inside. Overall, -1 for visibility
Yaniv Kaul has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 18:
Why is this a VDSM decision and not engine? What if by now, there's a better
chance to migrate to a
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/14/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/14/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 686:
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/52799/14/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 14: Code-Review-1
(3 comments)
mostly OK, but:
1. (MAJOR) we should review and test the saveState()
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
69 matches
Mail list logo
