Martin Sivák has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Nir Soffer has uploaded a new change for review.
Change subject: logging: Document the secret TRACE log level
..
logging: Document the secret TRACE log level
This may be useful to for developers to understand complicated flows.
Nir Soffer has uploaded a new change for review.
Change subject: logging: Improve log level alignment
..
logging: Improve log level alignment
Shorten WARNING to WARN and CRITICAL to CRIT to make log messages align
nicer.
Here
Nir Soffer has uploaded a new change for review.
Change subject: tests: Use same log format as vdsm
..
tests: Use same log format as vdsm
Using the same format as in vdsm logs may make it easier to debug
failing tests. In
Nir Soffer has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64196/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line 9915:
Nir Soffer has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: logging: Document the secret TRACE log level
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64218
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: stomp: use socket pending
..
Patch Set 3:
* #133::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#133::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 2: Code-Review+1
Waiting for more reviews.
--
To view, visit https://gerrit.ovirt.org/64196
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: stomp: use socket pending
..
Patch Set 3: -Verified
* #133::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#133::OK, public bug
* Check
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: use socket pending
..
Patch Set 3:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN,
Nir Soffer has posted comments on this change.
Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64203/2/tests/Makefile.am
File tests/Makefile.am:
Marcin Mirecki has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
(8 comments)
This was just a quick and dirty draft to show the
Francesco Romani has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 2: Code-Review-1
(5 comments)
-1 for visibility
Jenny Tokar has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/63748/2/lib/api/vdsm-api.yml
File
gerrit-hooks has posted comments on this change.
Change subject: log: More standard logging format
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 2:
(1 comment)
Let's discuss the API we want before proceeding.
Edward Haas has uploaded a new change for review.
Change subject: net: Setup validation for OVS - Check nics usage
..
net: Setup validation for OVS - Check nics usage
OVS is not properly failing when adding a port that is
Jenny Tokar has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/63748/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2,
gerrit-hooks has posted comments on this change.
Change subject: net: Setup validation for OVS - Check nics usage
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/63748/2/lib/api/vdsm-api.yml
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
gerrit-hooks has posted comments on this change.
Change subject: WIP benchmark decorator module speed
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has abandoned this change.
Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/62838
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: tests: shorten py3 blacklist
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64060
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: tests: shorten py3 blacklist
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64060
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: log: Nicer logging format
..
Patch Set 1:
Do we know whether anyone already parses our log to collect information about
what is going on?
--
To view,
Piotr Kliczewski has posted comments on this change.
Change subject: Remove python-argparse requirement
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: [wip] build: assumptions about the path do not work for
distcheck
..
Patch Set 1:
sure
--
To view, visit https://gerrit.ovirt.org/52508
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: WIP: API: more cleanups
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: lib: response: helper to detect valid responses
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: WIP: add helper to enforce the `common` rules
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Petr Horáček has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 9: Verified+1
(3 comments)
func_bond_basic_test passed
gerrit-hooks has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 9:
* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Francesco Romani has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 8: Verified+1
tests still pass :)
--
To view, visit https://gerrit.ovirt.org/62212
To
Piotr Kliczewski has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64123/2/vdsm/alignmentScan.py
File vdsm/alignmentScan.py:
Piotr Kliczewski has posted comments on this change.
Change subject: lib: move the response.py under common
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63954
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/4//COMMIT_MSG
Commit Message:
Line 3:
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: lib: move define.py under common
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63953
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connect
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59702
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64123/2/vdsm/alignmentScan.py
File vdsm/alignmentScan.py:
Line 1:
gerrit-hooks has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 8:
* #1369822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
*
Petr Horáček has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 2: Verified+1
Passed testing by QE. No regression with legacy network. OVS networks' IP
config was restored.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Yaniv Bronhaim has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.spmStart
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: yml: return type fixes for StoragePool.getSpmStatus
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59706
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: yml: return type fixes for StoragePool.getInfo
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59707
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: yml: return type fixes for Task.getStatus
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59705
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: yml: return type fixes for LVMVolumeGroup.getInfo
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59708
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: [wip] build: assumptions about the path do not work for
distcheck
..
Patch Set 1:
After rebase this patch is not needed anymore. There are new issues that I
Nir Soffer has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4: Code-Review-1
(4 comments)
qemuimg module cannot have storage logic, move the logic to
Piotr Kliczewski has posted comments on this change.
Change subject: lib: move exception.py under common
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63952
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
This change broke many tests - please make sure all tests pass before you
upload the
gerrit-hooks has posted comments on this change.
Change subject: lib: api: allow to return prebuilt responses
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Milan Zamazal has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 29: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hooks: Destroy fcoe interface once config removed
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/57867
Simone Tiraboschi has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 31: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove python-argparse requirement
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..
Patch Set 1:
* #1370103::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/62838
To
Yaniv Kaul has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/4/lib/vdsm/qemuimg.py
File
Francesco Romani has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/61475/9/vdsm/API.py
File vdsm/API.py:
Line 37: from vdsm import
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File
Petr Horáček has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/64118/4/lib/vdsm/network/netswitch.py
File
gerrit-hooks has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 16:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: hostdev: properly set is_hostdevice
..
Patch Set 8:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: lib: move define.py under common
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: lib: move the response.py under common
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Edward Haas has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: draft: migration plugin proposal - draft 102
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: add test for Xen block device
..
v2v: add test for Xen block device
Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Signed-off-by: Shahar
Martin Polednik has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/60640/15/lib/vdsm/config.py.in
File
gerrit-hooks has posted comments on this change.
Change subject: devices: add is_hostdevice attribute
..
Patch Set 8:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 30:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 29: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: cmdutils: enhance systemd_run
..
cmdutils: enhance systemd_run
Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
TODO: explain
Signed-off-by:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: move define.py under common
..
lib: move define.py under common
The commit fc732ae broke the rule that code under lib/vdsm/common
should depend
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: move the response.py under common
..
lib: move the response.py under common
The commit fc732ae broke the rule that code under lib/vdsm/common
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: api.py: preserve signature in decorator
..
lib: api.py: preserve signature in decorator
The api.method decorator needs to preserve the function
Dan Kenigsberg has posted comments on this change.
Change subject: lib: api.py: preserve signature in decorator
..
Patch Set 13: Code-Review+2
never mind the minor slowdown of each API call, let's take this in.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: lib: api.py: preserve signature in decorator
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose numa_node in host device
..
Patch Set 14:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 14:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vmxml: move condition from appendNumaTune to buildDomainXML
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: shorten py3 blacklist
..
tests: shorten py3 blacklist
A few more test modules are passing under Python 3. Let's keeep testing
them.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: tests: shorten py3 blacklist
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: v2v: add test for Xen block device
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Marcin Mirecki has uploaded a new change for review.
Change subject: draft: migration plugin proposal - draft 102
..
draft: migration plugin proposal - draft 102
Just a draft to show the idea, not verified
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: draft: migration plugin proposal - draft 102
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/64186/1/vdsm/virt/vm_migrate_hook.py
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: move exception.py under common
..
lib: move exception.py under common
The commit fc732ae broke the rule that code under lib/vdsm/common
should
gerrit-hooks has posted comments on this change.
Change subject: lib: move exception.py under common
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: gluster: set selinux labels while creating bricks
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/62773/5/vdsm/gluster/storagedev.py
File
Milan Zamazal has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 16:
(2 comments)
https://gerrit.ovirt.org/#/c/60640/16/vdsm/virt/vm.py
File vdsm/virt/vm.py:
1 - 100 of 218 matches
Mail list logo