Milan Zamazal has posted comments on this change.
Change subject: periodic: explicitely track domain availability
..
Patch Set 5:
(4 comments)
I think this change is tricky enough to deserve at least some comment in the
Milan Zamazal has posted comments on this change.
Change subject: virt: periodic: factor out periodic operations
..
Patch Set 23: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44548
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: periodic: reduce NotConnectedError noise
..
Patch Set 16: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44813
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vmstats: take in account missing bulk stats fields
..
Patch Set 3: Code-Review-1
(2 comments)
Fine, just typos in the comment.
Milan Zamazal has posted comments on this change.
Change subject: vmstats: take in account missing bulk stats fields
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47760
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 36: Code-Review-1
(3 comments)
The tests take relatively long time to run. It would be nice to make
Milan Zamazal has posted comments on this change.
Change subject: virt: periodic: reduce NotConnectedError noise
..
Patch Set 14: Code-Review-1
(2 comments)
Looks fine to me, I'd just suggest to polish typos in the commit
Milan Zamazal has posted comments on this change.
Change subject: virt: periodic: factor out common code
..
Patch Set 20: Code-Review-1
I'd prefer if virdomain.NotConnectedError change remained in a separate patch.
It's
Milan Zamazal has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48404/1//COMMIT_MSG
Commit Message:
Line 14: This
Milan Zamazal has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/48404/1/tests/vmTests.py
File tests/vmTests.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: gitignore: Missing autogenerated files added
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48328
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: periodic: add executor-compatible naming
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/48193/6//COMMIT_MSG
Commit Message:
Line 8:
Line 9: We
Milan Zamazal has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/48404/1/tests/vmTests.py
File tests/vmTests.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/48404/3/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Milan Zamazal has posted comments on this change.
Change subject: periodic: add executor-compatible naming
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/48193/6/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:
Milan Zamazal has posted comments on this change.
Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/48542/1/tests/utilsTests.py
File
Milan Zamazal has posted comments on this change.
Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/48542/1/tests/utilsTests.py
File
Milan Zamazal has posted comments on this change.
Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter
..
Patch Set 1:
(1 comment)
We now check for unicodes and convert them to strings.
Milan Zamazal has posted comments on this change.
Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter
..
Patch Set 3:
Let's summarize what we can do about this change:
# "Only strings, no unicodes in VDSM
Milan Zamazal has posted comments on this change.
Change subject: vm: periodic: NumaInfoMonitor doesn't need jobs
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48411
To unsubscribe, visit
Milan Zamazal has uploaded a new change for review.
Change subject: virt: vm: Use formatting string to log domxml
..
virt: vm: Use formatting string to log domxml
Variable data shouldn't be passed to logging as the first
Milan Zamazal has posted comments on this change.
Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/48542/2/tests/utilsTests.py
File
Milan Zamazal has abandoned this change.
Change subject: virt: vm: Use formatting string to log domxml
..
Abandoned
SimpleLogAdapter doesn't interpret the first argument as a format string.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: vmstats: reformat to make the code nicer
..
Patch Set 2: Code-Review+1
It's arguable whether inserting two more lines makes the code nicer or the
other way
Milan Zamazal has posted comments on this change.
Change subject: periodic: add __str__ methods
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48193
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: more robust support of event strings
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48517
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: add support for "Crashed" event
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48594
To unsubscribe, visit
Milan Zamazal has uploaded a new change for review.
Change subject: gitignore: Missing autogenerated files added
..
gitignore: Missing autogenerated files added
Change-Id: If4a1e9c2607d817ccca2a321060ab4f452422c32
Milan Zamazal has posted comments on this change.
Change subject: periodic: more cautious return to fast path
..
Patch Set 2: Code-Review-1
(6 comments)
Looks like a good idea to me. -1 just due to the typos.
Milan Zamazal has posted comments on this change.
Change subject: periodic: explicitely track domain availability
..
Patch Set 9:
(3 comments)
https://gerrit.ovirt.org/#/c/47246/9/vdsm/virt/periodic.py
File
Milan Zamazal has posted comments on this change.
Change subject: sampling: HostStatsThread as periodic operation
..
Patch Set 32: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/40431/32/vdsm/virt/periodic.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: enhance/fix migration.SourceThread.stop()
..
Patch Set 11: Verified+1
I checked the migration cancellation by starting and canceling migration from
Milan Zamazal has posted comments on this change.
Change subject: lib: utils: consolidate Error class in one place
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/47964/1//COMMIT_MSG
Commit Message:
Line 10: they
Milan Zamazal has posted comments on this change.
Change subject: lib: utils: consolidate Error class in one place
..
Patch Set 3:
Fine for me now except the "alogside" typo in the commit message.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: lib: sparsify: use common Error class
..
Patch Set 3:
(1 comment)
OK except for the commit message.
https://gerrit.ovirt.org/#/c/47965/3//COMMIT_MSG
Commit
Milan Zamazal has posted comments on this change.
Change subject: lib: utils: consolidate Error class in one place
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47964
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: periodic: explicitely track domain availability
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47246
To unsubscribe, visit
Milan Zamazal has uploaded a new change for review.
Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter
..
logging: Don't crash on non-ASCII in SimpleLogAdapter
The values and messages passed to
Milan Zamazal has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py
File vdsm/v2v.py:
Line 175:
Milan Zamazal has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 1:
(2 comments)
Looks nice to me. Just docstrings are missing and see my comments on tests.
Milan Zamazal has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py
File vdsm/v2v.py:
Line 175:
Milan Zamazal has posted comments on this change.
Change subject: vm: add support for "Crashed" event
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49674
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: more robust support of event strings
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49675
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/49507/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 154:
Milan Zamazal has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 2: Code-Review-1
I think the corresponding master patch is actually
https://gerrit.ovirt.org/49507. Not
Milan Zamazal has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/49507/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 154:
Milan Zamazal has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 3:
(5 comments)
Documentation better now, I still suggest some fixes run_async docstring, see
the comments.
Milan Zamazal has posted comments on this change.
Change subject: migration: make status field private
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/49522/2/vdsm/virt/migration.py
File
Milan Zamazal has posted comments on this change.
Change subject: sampling: HostStatsThread as periodic operation
..
Patch Set 35: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40431
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: reformat _EVENT_STRINGS
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49673
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/49570/2/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line 121:
Line 122:
Milan Zamazal has posted comments on this change.
Change subject: sampling: HostStatsThread as periodic operation
..
Patch Set 33: Code-Review-1
(1 comment)
Just one minor omission, otherwise fine.
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 4:
(5 comments)
https://gerrit.ovirt.org/#/c/48860/4/tests/vmTests.py
File tests/vmTests.py:
Line 987:
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 5: Verified+1
Verified by suspending a VM without NTP running, awaking it again and checking
that:
- In
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 6:
Reworked tests (addressing Francesco's comments); no changes in functional code.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 2: Verified+1
Tested together with the corresponding Engine change: Changing number of heads
on single PCI
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 8:
Post-rebase fix: __recording__ renamed to __calls__ in tests.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after migration
..
Patch Set 3: Code-Review-1
We should wait with this until qemu-guest-agent issues are resolved, as
discussed in
Milan Zamazal has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49570/3/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line 137: If
Milan Zamazal has posted comments on this change.
Change subject: migration: make status field private
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49522
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40522
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 10: Verified+1
Verified by suspending and resuming a VM with and without qemu-guest-agent
running and
Milan Zamazal has posted comments on this change.
Change subject: virt: Allow vm.cont() to resume VM in SAVING_STATE
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47527
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: tests: More testVideoXML tests
..
Patch Set 1: Verified+1
Verified by running the tests.
--
To view, visit https://gerrit.ovirt.org/50420
To
Milan Zamazal has uploaded a new change for review.
Change subject: virt: tests: More testVideoXML tests
..
virt: tests: More testVideoXML tests
As suggested in
https://gerrit.ovirt.org/#/c/50091/3/tests/deviceTests.py@296, we
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after migration
..
Patch Set 3:
Thinking about it more and more, my opinion is we shouldn't update time after
live migration. The
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 3:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/50456
To unsubscribe, visit
Milan Zamazal has uploaded a new change for review.
Change subject: virt: vm: Replace update time migration TODO
..
virt: vm: Replace update time migration TODO
As discussed in https://gerrit.ovirt.org/49212, we are not going
Milan Zamazal has posted comments on this change.
Change subject: virt: tests: More testVideoXML tests
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50420/1/tests/deviceTests.py
File tests/deviceTests.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: virt: tests: More testVideoXML tests
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50420/1/tests/deviceTests.py
File tests/deviceTests.py:
Line
Milan Zamazal has abandoned this change.
Change subject: virt: vm: Update time on VM after migration
..
Abandoned
As explained in the comments, we shouldn't merge this. See
https://gerrit.ovirt.org/50499 for related source
Milan Zamazal has posted comments on this change.
Change subject: daemon: reformat __set_cpu_affinity
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49613
To unsubscribe, visit
Milan Zamazal has uploaded a new change for review.
Change subject: virt: vm: Update time on VM after resume
..
virt: vm: Update time on VM after resume
When a VM is resumed from suspension and/or migrated, its clock
continues
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after migration
..
Patch Set 3:
According to a libvirt developer, there should be no delay -- libvirt should be
aware whether the
Milan Zamazal has uploaded a new change for review.
Change subject: virt: vm: Update time on VM after resume
..
virt: vm: Update time on VM after resume
When a VM is resumed from suspension and/or migrated, its clock
continues
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1: Verified+1
Verified by suspending and resuming a VM with qemu-guest-agent running and not
running and
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1:
Compared to 3.6:
- virdomain.NotConnectedError handling removed (not present in 3.5).
- Success test
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/50456/1//COMMIT_MSG
Commit Message:
Line 35: with libvirt
Milan Zamazal has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 1: Verified+1
Verified by running with a patched Engine and checking on QEMU command line
that vgamem (and
Hello Nir Soffer, Vinzenz Feenstra, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50507
to review the following change.
Change subject: virt: Add support for vgamem attribute
..
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/48860/9/tests/vmTests.py
File tests/vmTests.py:
Line 1564:
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 8:
Delay documented in the commit message + TODO in the migration path updated +
rebased.
--
To view,
Milan Zamazal has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3:
Improved doc in schema.
--
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 7:
The delay doesn't make the VM unavailable (e.g. there should be no disruption
during migration because
Milan Zamazal has posted comments on this change.
Change subject: virt: Correct VM state before vm.cont() in _recover()
..
Patch Set 2:
AFAICT it should help recovery from stuck paused states and I couldn't identify
any risks
Milan Zamazal has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/50091/3/tests/deviceTests.py
File tests/deviceTests.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 7:
After some discussion with Michal, we decided that the patch is probably fine
as it is for now.
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't expose GuestAgent.guestInfo directly
..
Patch Set 1:
(1 comment)
Commit message improved.
Milan Zamazal has posted comments on this change.
Change subject: virt: devices: initial support for device updates with etree's
..
Patch Set 8:
Rebased.
--
To view, visit https://gerrit.ovirt.org/46525
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: introduce "Async" helper
..
Patch Set 2: Code-Review-1
(11 comments)
I can't get rid of feeling that the implementation is too complicated for the
Milan Zamazal has posted comments on this change.
Change subject: clientIF: add logs during the recovery
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49140
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: packaging: updating for VDSM 4.17.4 on Debian jessie
..
Patch Set 35: Code-Review-1
(10 comments)
Current Debian packaging looks like a reasonable start, let's
Milan Zamazal has posted comments on this change.
Change subject: periodic: add __str__ methods
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49143
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vmstats: network: avoid ZeroDivisionError
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48478/2/tests/vmStatsTests.py
File tests/vmStatsTests.py:
Milan Zamazal has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 7: Verified+1
Verified by manually testing it as usually.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 6:
(5 comments)
https://gerrit.ovirt.org/#/c/48404/6//COMMIT_MSG
Commit Message:
Line 8:
Line 9:
Milan Zamazal has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/48404/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: lib: daemon: autodetect online cpus for affinity
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49402
To unsubscribe, visit
1 - 100 of 805 matches
Mail list logo
