Piotr Kliczewski has posted comments on this change.
Change subject: tests: shorten py3 blacklist
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64060
To unsubscribe, visit https://gerrit.ovirt.org/se
Piotr Kliczewski has posted comments on this change.
Change subject: tests: shorten py3 blacklist
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64060
To unsubscribe, visit https://gerrit.ovirt.org/se
Piotr Kliczewski has posted comments on this change.
Change subject: lib: move the response.py under common
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63954
To unsubscribe, visit https://gerrit.ov
Piotr Kliczewski has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64123/2/vdsm/alignmentScan.py
File vdsm/alignmentScan.py:
PS2
Nir Soffer has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4: Code-Review-1
(4 comments)
qemuimg module cannot have storage logic, move the logic to sd
Piotr Kliczewski has posted comments on this change.
Change subject: lib: move exception.py under common
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63952
To unsubscribe, visit https://gerrit.ovirt
Nir Soffer has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/4//COMMIT_MSG
Commit Message:
Line 3: Aut
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Nir Soffer has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
This change broke many tests - please make sure all tests pass before you
upload the next
Nir Soffer has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64123/2/vdsm/alignmentScan.py
File vdsm/alignmentScan.py:
Line 1: #
Nir Soffer has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: log: Nicer logging format
..
Patch Set 1:
Do we know whether anyone already parses our log to collect information about
what is going on?
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: Remove python-argparse requirement
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit https://gerrit.ovirt.
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Piotr Kliczewski has posted comments on this change.
Change subject: lib: move define.py under common
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63953
To unsubscribe, visit https://gerrit.ovirt.or
Piotr Kliczewski has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ovi
Piotr Kliczewski has posted comments on this change.
Change subject: [wip] build: assumptions about the path do not work for
distcheck
..
Patch Set 1:
sure
--
To view, visit https://gerrit.ovirt.org/52508
To unsubscribe, vis
gerrit-hooks has posted comments on this change.
Change subject: WIP benchmark decorator module speed
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: WIP: API: more cleanups
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: WIP: add helper to enforce the `common` rules
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: lib: response: helper to detect valid responses
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: lib: api: allow to return prebuilt responses
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Milan Zamazal has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 29: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/set
gerrit-hooks has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 8:
* #1369822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1369822::OK, public bug
* Che
gerrit-hooks has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 9:
* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::
Petr Horáček has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 9: Verified+1
(3 comments)
func_bond_basic_test passed
https://gerrit.ovirt.org/#/
Petr Horáček has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 2: Verified+1
Passed testing by QE. No regression with legacy network. OVS networks' IP
config was restored.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: hooks: Destroy fcoe interface once config removed
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/57867
To
Simone Tiraboschi has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62209
To unsubscribe, visit https://gerrit.ov
Petr Horáček has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 31: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt
Francesco Romani has abandoned this change.
Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/62838
To unsubscribe, visit https://gerrit.ovirt.org/s
gerrit-hooks has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..
Patch Set 1:
* #1370103::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/62838
To unsub
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove python-argparse requirement
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit https://gerrit.ovirt.org/s
Yaniv Bronhaim has posted comments on this change.
Change subject: yml: return type fixes for StoragePool.getSpmStatus
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59706
To unsubscribe, visit https:
Yaniv Bronhaim has posted comments on this change.
Change subject: yml: return type fixes for StoragePool.getInfo
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59707
To unsubscribe, visit https://ger
Yaniv Bronhaim has posted comments on this change.
Change subject: yml: return type fixes for Task.getStatus
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59705
To unsubscribe, visit https://gerrit.o
Yaniv Bronhaim has posted comments on this change.
Change subject: yml: return type fixes for LVMVolumeGroup.getInfo
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59708
To unsubscribe, visit https://
Yaniv Bronhaim has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.spmStart
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59704
To unsubscribe, visit https:/
Yaniv Bronhaim has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connect
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59702
To unsubscribe, visit https://
Piotr Kliczewski has posted comments on this change.
Change subject: [wip] build: assumptions about the path do not work for
distcheck
..
Patch Set 1:
After rebase this patch is not needed anymore. There are new issues that I
Petr Horáček has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/64118/4/lib/vdsm/network/netswitch.py
File li
Francesco Romani has posted comments on this change.
Change subject: vdsm: drop the warnings module configuration
..
Patch Set 8: Verified+1
tests still pass :)
--
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe,
Edward Haas has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, vi
gerrit-hooks has posted comments on this change.
Change subject: draft: migration plugin proposal - draft 102
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Marcin Mirecki has uploaded a new change for review.
Change subject: draft: migration plugin proposal - draft 102
..
draft: migration plugin proposal - draft 102
Just a draft to show the idea, not verified
Change-Id: Ia0fb056c4
Martin Polednik has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/60640/15/lib/vdsm/config.py.in
File lib/vdsm/config
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose numa_node in host device
..
Patch Set 14:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 14:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Pro
gerrit-hooks has posted comments on this change.
Change subject: vmxml: move condition from appendNumaTune to buildDomainXML
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
gerrit-hooks has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 16:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: hostdev: properly set is_hostdevice
..
Patch Set 8:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Produc
gerrit-hooks has posted comments on this change.
Change subject: devices: add is_hostdevice attribute
..
Patch Set 8:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Produ
Dan Kenigsberg has posted comments on this change.
Change subject: draft: migration plugin proposal - draft 102
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/64186/1/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_m
Dan Kenigsberg has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 29: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/se
Dan Kenigsberg has submitted this change and it was merged.
Change subject: cmdutils: enhance systemd_run
..
cmdutils: enhance systemd_run
Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
TODO: explain
Signed-off-by: France
gerrit-hooks has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 30:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://ge
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: move exception.py under common
..
lib: move exception.py under common
The commit fc732ae broke the rule that code under lib/vdsm/common
should dep
gerrit-hooks has posted comments on this change.
Change subject: lib: move exception.py under common
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: move define.py under common
..
lib: move define.py under common
The commit fc732ae broke the rule that code under lib/vdsm/common
should depend on
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: move the response.py under common
..
lib: move the response.py under common
The commit fc732ae broke the rule that code under lib/vdsm/common
shou
gerrit-hooks has posted comments on this change.
Change subject: lib: move define.py under common
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://
gerrit-hooks has posted comments on this change.
Change subject: lib: move the response.py under common
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit ht
Dan Kenigsberg has posted comments on this change.
Change subject: lib: api.py: preserve signature in decorator
..
Patch Set 13: Code-Review+2
never mind the minor slowdown of each API call, let's take this in.
--
To view, vi
gerrit-hooks has posted comments on this change.
Change subject: lib: api.py: preserve signature in decorator
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, v
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: api.py: preserve signature in decorator
..
lib: api.py: preserve signature in decorator
The api.method decorator needs to preserve the function
or
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: shorten py3 blacklist
..
tests: shorten py3 blacklist
A few more test modules are passing under Python 3. Let's keeep testing
them.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: tests: shorten py3 blacklist
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerr
gerrit-hooks has posted comments on this change.
Change subject: v2v: add test for Xen block device
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: add test for Xen block device
..
v2v: add test for Xen block device
Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Signed-off-by: Shahar Hav
Milan Zamazal has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 16:
(2 comments)
https://gerrit.ovirt.org/#/c/60640/16/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS16,
Francesco Romani has posted comments on this change.
Change subject: gluster: set selinux labels while creating bricks
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/62773/5/vdsm/gluster/storagedev.py
File vdsm/glust
gerrit-hooks has posted comments on this change.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Edward Haas has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/64118/4/lib/vdsm/network/netswitch.py
File lib
Edward Haas has uploaded a new change for review.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
net: Delete an OVS bridge when the last SB is detached.
Moving the action of deleting unused OVS bridge
Edward Haas has posted comments on this change.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
Patch Set 1: Verified+1
Passing all unit and functional tests
--
To view, visit https://gerrit.ovirt.o
Edward Haas has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 4: Verified+1
Passing all unit and functional tests.
--
To view, visit https://gerrit.ovir
Edward Haas has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 31: Verified+1
--
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org
Edward Haas has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/64131
To unsubscribe, visit https://gerrit
Petr Horáček has posted comments on this change.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
Patch Set 1: Code-Review+1
Really nice
--
To view, visit https://gerrit.ovirt.org/64192
To unsubscrib
gerrit-hooks has posted comments on this change.
Change subject: net: switch type switch
..
Patch Set 10:
* #1362399::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1362399::OK, public bug
* Check Product::#1362399
Ramesh N has posted comments on this change.
Change subject: gluster: set selinux labels while creating bricks
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/62773/5/vdsm/gluster/storagedev.py
File vdsm/gluster/stora
gerrit-hooks has posted comments on this change.
Change subject: virt: Correct disconnectAction parameter extraction
..
Patch Set 4:
* #1371264::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1371264::OK, public bu
gerrit-hooks has posted comments on this change.
Change subject: virt: Ensure uncaught exceptions on disconnect events are caught
..
Patch Set 4:
* #1371264::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1371264::
gerrit-hooks has posted comments on this change.
Change subject: virt: Pass missing parameter on desktopLogoff
..
Patch Set 4:
* #1371264::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1371264::OK, public bug
* Ch
gerrit-hooks has posted comments on this change.
Change subject: logging: add and use new devel logger
..
Patch Set 9:
* #1369822::Update tracker: OK
* #1377069::Update tracker: OK
* Set MODIFIED::bug 1369822#1369822IGN
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logging: add and use new devel logger
..
logging: add and use new devel logger
After rhbz#1264149 we learned that way that the warnings
module doesn't
Edward Haas has posted comments on this change.
Change subject: draft: migration plugin proposal - draft 102
..
Patch Set 1: Code-Review-1
(11 comments)
https://gerrit.ovirt.org/#/c/64186/1/vdsm/virt/vm_migrate_hook.py
File vd
Francesco Romani has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/60481/21/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 33:
Li
Francesco Romani has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 31: Code-Review-1
TL;DR - kill duplication, improve docstrings.
--
To view, visit https://ge
Francesco Romani has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 25:
(15 comments)
https://gerrit.ovirt.org/#/c/59824/25/lib/vdsm/virt/containers/config/__ini
Francesco Romani has posted comments on this change.
Change subject: draft: migration plugin proposal - draft 102
..
Patch Set 1:
just looking at the names, I have a very bad feeling about the idea of adding
plugins to an hook
Ala Hino has uploaded a new change for review.
Change subject: sdm: Introduce new SDM.merge verb
..
sdm: Introduce new SDM.merge verb
This API is another data operation separate from SPM. It merges data
from top volume to base v
gerrit-hooks has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Edward Haas has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63988
To unsubscribe, visit https://gerrit.ovirt.org/settings
G
Edward Haas has posted comments on this change.
Change subject: draft: migration plugin proposal - draft 102
..
Patch Set 1:
Marcin, please add an explanation in the commit message on why we had to use
plugins for this, and no
Ala Hino has uploaded a new change for review.
Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..
tests: Rename qemuimgTests.py to new Vdsm convention
Change-Id: Ifcdf2cd43d681777c1fa5075a86ee044b378d840
Sig
1 - 100 of 220 matches
Mail list logo