Re: [PATCH] drm: support up to 128 drm devices

2023-07-25 Thread Emil Velikov
On Mon, 17 Jul 2023 at 14:54, Simon Ser wrote: > > On Monday, July 17th, 2023 at 15:24, Emil Velikov > wrote: > > > > > For going forward, here is one way we can shave this yak: > > > > - update libdrm to max 64 nodes > > > > - roll libdrm rel

Re: [PATCH] drm: support up to 128 drm devices

2023-07-17 Thread Emil Velikov
On Mon, 17 Jul 2023 at 10:45, Simon Ser wrote: > > On Monday, July 17th, 2023 at 09:30, Emil Velikov > wrote: > > > > I'm worried what might happen with old user-space, especially old libdrm. > > > > I also share the same concern. Although the bigger issue

Re: [PATCH] drm: support up to 128 drm devices

2023-07-17 Thread Emil Velikov
On Fri, 14 Jul 2023 at 11:32, Simon Ser wrote: > > (cc Daniel Vetter and Pekka because this change has uAPI repercussions) > > On Friday, June 30th, 2023 at 13:56, James Zhu wrote: > > > From: Christian König > > > > This makes room for up to 128 DRM devices. > > > > Signed-off-by: Christian

Re: wayland-protocols scope and governance

2019-05-06 Thread Emil Velikov
Hi Drew, On Mon, 6 May 2019 at 01:41, Drew DeVault wrote: > > Here's an updated governance document for everyone to consider. Changes > from the first version: > > - Use wayland-devel instead of a dedicated mailing list > - Use Gitlab for reviewing new protocols > - Extend discussion period for

Re: [PATCH wayland v4 1/5] build/doc: Ensure destination dir exists despite VPATH

2018-08-29 Thread Emil Velikov
Hi Dan, On 28 August 2018 at 23:19, Daniel Stone wrote: > Make considers a variable called VPATH when trying to satisfy > dependencies, e.g. for a target 'foo', it will consider the target > extant if VPATH is '../../bar' and '../../bar/foo' exists. > > Part of the doc build, the '$(alldirs)'

Re: [PATCH wayland 6/6] tests: Remove memory leak checking infrastructure

2018-08-29 Thread Emil Velikov
On 29 August 2018 at 07:17, Daniel Stone wrote: > There are far better ways to detect memory leaks, such as either > valgrind or ASan. Having Meson makes it really easy to use these tools > in our tests, and we can do that in CI as well. > > Having these local wrappers actually completely broke

Re: [PATCH wayland 5/6] tests: Overly elaborate compiler warning workaround

2018-08-29 Thread Emil Velikov
Hi Dan, On 29 August 2018 at 07:17, Daniel Stone wrote: > Clang will rightly point out that example_sockaddr_un in socket-test > will get discarded from the compilation unit as it is completely unused. > Put in a couple of lines which of no value other than stopping Clang > from complaining. > >

Re: [PATCH] cursor: use memfd_create or shm_open for anonymous in-memory files

2018-08-16 Thread Emil Velikov
On 15 August 2018 at 15:14, Simon Ser wrote: > On Linux, try using memfd_create and file sealing. Fallback to > shm_open on old kernels. > > On FreeBSD, use shm_open with SHM_ANON. > > Otherwise, use shm_open with a random name, making sure the name > isn't already taken. > Thinking out loud: I

Re: How fwrd-compatible is using dlopen and core only?

2018-08-14 Thread Emil Velikov
On 14 August 2018 at 08:57, Pekka Paalanen wrote: > On Fri, 10 Aug 2018 18:31:03 + > ferreiradaselva wrote: > >> Oh, >> >> I solved the problem with the extern variable >> (wl_registry_interface), I could get a pointer to it using >> `dlsym(handler, "wl_registry_interface")`. >> >> The other

Re: [PATCH wayland 1/2] build: Remove execinfo.h check

2018-07-26 Thread Emil Velikov
s. If you guys like Fixes tags, here is one Fixes: bc3e020475e ("build: Add declaration checks to check for required syscall flags") Fwiw, series is Reviewed-by: Emil Velikov -Emil ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston] simple-dmabuf-drm: use GBM generic calls

2018-07-24 Thread Emil Velikov
Hi everyone, On 11 July 2018 at 09:33, Daniel Stone wrote: > Hi, > On Wed, 11 Jul 2018 at 09:16, Pekka Paalanen wrote: >> On Tue, 10 Jul 2018 17:53:15 +0200 Emilio Pozuelo Monfort >> wrote: >> > No need to write libdrm driver specific code for each supported >> > driver, we can just let GBM

Re: [PATCH v16 15/23] compositor-drm: Support modifiers with GBM

2018-07-06 Thread Emil Velikov
Hi Dan, On 5 July 2018 at 18:16, Daniel Stone wrote: > Use the extended GBM allocator interface to support modifiers and > multi-planar BOs. > > Signed-off-by: Daniel Stone > Tested-by: Emre Ucan > --- > configure.ac | 3 ++ > libweston/compositor-drm.c | 61

Re: [PATCH libinput 1/5] tools: if the execdir is the builddir, add it to the path

2018-07-04 Thread Emil Velikov
Hi Peter, On 28 June 2018 at 00:51, Peter Hutterer wrote: > When running libinput tools from the builddir, look up the subtools in the > builddir as well. Otherwise, add the install prefix to the list of lookup > locations. > > This ensures that a) we're running builddir stuff against builddir

Re: [PATCH weston] simple-dmabuf-drm: fix build with --disable-egl

2018-07-03 Thread Emil Velikov
Hi Emilio, On 2 July 2018 at 16:22, Emilio Pozuelo Monfort wrote: > Signed-off-by: Emilio Pozuelo Monfort > --- > I tried a build with --disable-egl as I didn't have the headers > installed, and it broke here. The EGL usage here seemed optional so I > did that, but I didn't run-test the result.

Re: [PATCH wayland 4/8] fixup! scanner: use c99 initializers for the request/events arrays

2018-07-03 Thread Emil Velikov
On 3 July 2018 at 12:28, Pekka Paalanen wrote: > On Thu, 14 Jun 2018 16:49:41 +0100 > Emil Velikov wrote: > >> --- >> tests/data/example-code.c | 238 >> >> tests/data/small-code-core.c| 8 +- >>

Re: [PATCH wayland 8/8] fixup! scanner: initialize .{method, event}_count via ARRAY_SIZE

2018-07-03 Thread Emil Velikov
On 3 July 2018 at 12:45, Pekka Paalanen wrote: > On Thu, 14 Jun 2018 16:49:45 +0100 > Emil Velikov wrote: > >> --- >> tests/data/example-code.c | 73 >> + >> tests/data/small-code-core.c| 5 +-- >>

Re: [PATCH weston] configure.ac: bump libdrm requirement to 2.4.68

2018-07-02 Thread Emil Velikov
On 2 July 2018 at 10:41, Emil Velikov wrote: > On 2 July 2018 at 03:07, Peter Hutterer wrote: >> On Mon, Jun 11, 2018 at 11:02:19AM +0100, Daniel Stone wrote: >>> Hi, >>> >>> On 11 June 2018 at 10:25, Pekka Paalanen wrote: >>> > On Mon, 11 Jun

Re: [PATCH weston] configure.ac: bump libdrm requirement to 2.4.68

2018-07-02 Thread Emil Velikov
On 2 July 2018 at 03:07, Peter Hutterer wrote: > On Mon, Jun 11, 2018 at 11:02:19AM +0100, Daniel Stone wrote: >> Hi, >> >> On 11 June 2018 at 10:25, Pekka Paalanen wrote: >> > On Mon, 11 Jun 2018 09:29:49 +1000 >> > Peter Hutterer wrote: >> >> +PKG_CHECK_MODULES(LIBDRM, [libdrm >= 2.4.68], [],

Re: [PATCH weston] build: don't manually parse the weston.ini.in templates

2018-07-02 Thread Emil Velikov
Hi All, Tl;Dr: Silly brain of mine auto-expanded $(foo). Patch might work, but as Quentin mentioned it won't majority of the time. Please consider this binned. On 29 June 2018 at 08:37, Pekka Paalanen wrote: > On Thu, 28 Jun 2018 18:59:01 +0100 > Emil Velikov wrote: > >> On 28

Re: [PATCH weston] build: don't manually parse the weston.ini.in templates

2018-06-28 Thread Emil Velikov
On 28 June 2018 at 10:58, Quentin Glidic wrote: > On 6/27/18 3:04 PM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Adding those to configure.ac ensures that: >> - the weston.ini files are {re,}generated only when needed >> - the .in file

Re: [PATCH wayland] contributing: review rules for bugs

2018-06-28 Thread Emil Velikov
On 28 June 2018 at 10:12, Pekka Paalanen wrote: > On Wed, 27 Jun 2018 17:49:34 +0100 > Emil Velikov wrote: > >> Hi Pekka, >> >> A couple small ideas come to mind: >> >> On 27 June 2018 at 14:47, Pekka Paalanen wrote: >> > From: Pekka Paalan

Re: [PATCH wayland] contributing: review rules for bugs

2018-06-27 Thread Emil Velikov
Hi Pekka, A couple small ideas come to mind: On 27 June 2018 at 14:47, Pekka Paalanen wrote: > From: Pekka Paalanen > > Half of the ideas came from Daniel but most of them are reworded, the > rest are my thoughts. > > Mention compiler warnings specifically, and be more explicit on what > kind

[PATCH weston] build: don't manually parse the weston.ini.in templates

2018-06-27 Thread Emil Velikov
From: Emil Velikov Adding those to configure.ac ensures that: - the weston.ini files are {re,}generated only when needed - the .in files are shipped in the tarball - all the manual handling of the above can be removed ;-) Note: the abs_top_builddir for weston-flower was swapped

Re: [PATCH weston v2] ivi-shell: use install paths in example config

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 12:12, Emil Velikov wrote: > On 27 June 2018 at 12:01, Michael Tretter wrote: >> Hi, >> >> On Fri, 25 May 2018 08:46:16 +0200, Michael Tretter wrote: >>> On Thu, 24 May 2018 17:08:47 +0200, Emre Ucan wrote: >>> > The exa

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 12:42, Guido Günther wrote: > Hi, > On Wed, Jun 27, 2018 at 11:30:40AM +0100, Emil Velikov wrote: >> On 26 June 2018 at 19:40, Guido Günther wrote: >> > Some modeline generators put out e.g. +HSync instead of +hsync. Accept >> > that too since

Re: [PATCH weston v2] ivi-shell: use install paths in example config

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 12:01, Michael Tretter wrote: > Hi, > > On Fri, 25 May 2018 08:46:16 +0200, Michael Tretter wrote: >> On Thu, 24 May 2018 17:08:47 +0200, Emre Ucan wrote: >> > The example weston.ini file uses source and build >> > directory paths. Therefore, it is only useful when >> > used on

Re: [PATCH v7 5/6] compositor-fbdev: detect the first fb device in the seat

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 00:39, nerdopolis wrote: > This adds a function to detect the first framebuffer device in the > current seat. Instead of hardcoding /dev/fb0, detect the device > with udev, favoring the boot_vga device, and falling back to the > first framebuffer device in the seat if there is

Re: [PATCH v7 0/6] Make Weston multiseat aware

2018-06-27 Thread Emil Velikov
the boot_vga device, and making > requested changes > With the leak plugged the series is Reviewed-by: Emil Velikov I would strongly recommend the boot_vga refactor as well, but I don't think it's worth blocking on it. HTH Emil ___ wayland-devel ma

Re: [PATCH v7 3/6] launcher-logind: only get a VT on seat0, as only seat0 supports VTs

2018-06-27 Thread Emil Velikov
On 27 June 2018 at 00:39, nerdopolis wrote: > As only seat0 supports TTYs, this changes the logind launcher where > it detects a TTY, only if the seat is seat0. This has only been > tested for logind > --- > libweston/launcher-logind.c | 22 -- > libweston/launcher-util.c |

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

2018-06-27 Thread Emil Velikov
On 26 June 2018 at 19:40, Guido Günther wrote: > Some modeline generators put out e.g. +HSync instead of +hsync. Accept > that too since it's not ambigous. > Hmm which generator is that? The cvt one, given as an example seems to produce lowercase ones. Personally I'm inclined to suggest fixing

Re: [PATCH 0/5] Implement support for drm properties "GAMMA_LUT" and "CTM"

2018-06-26 Thread Emil Velikov
On 26 June 2018 at 17:47, Matheus Santana wrote: > > > On Tue, Jun 26, 2018 at 11:51 AM, Emil Velikov > wrote: >> >> On 25 June 2018 at 19:48, Matheus Santana wrote: >> > Hi Harsha, >> > >> >> Weston needs to be rebuilt. But, no new l

Re: [PATCH 0/5] Implement support for drm properties "GAMMA_LUT" and "CTM"

2018-06-26 Thread Emil Velikov
On 25 June 2018 at 19:48, Matheus Santana wrote: > Hi Harsha, > >> Weston needs to be rebuilt. But, no new library versions dependencies. > > > All right. > > On Mon, Jun 25, 2018 at 10:21 AM, Harsha Manjula Mallikarjun (RBEI/ECF3) > wrote: >> >> Hi Matheus, >> >> >From: Matheus Santana

Re: [PATCH weston] man: remove redundant word in weston.ini(5)

2018-06-26 Thread Emil Velikov
t this output should be associated with. If this > is set then the seat's input will be confined to the output that has the seat > set on it. The expectation is that this functionality will be used in a > multiheaded environment with a single compositor for multiple

Re: [PATCH libinput] tools: fake-build the measure touch-pressure/size sources

2018-06-26 Thread Emil Velikov
On 21 June 2018 at 05:56, Peter Hutterer wrote: > This way we can make them execute the list-quirks from the builddir. > > Signed-off-by: Peter Hutterer > --- > If anyone has any good ideas for how to do something similar for C source > file, I'd appreciate it. > Here is the approach used by git

Re: [PATCH wayland-web 2/3] building: use enable-llvm option

2018-06-26 Thread Emil Velikov
is Reviewed-by: Emil Velikov Thanks Emil ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 2/4] shared: remove weston_config_get_libexec_dir()

2018-06-20 Thread Emil Velikov
On 20 June 2018 at 12:04, Pekka Paalanen wrote: > On Tue, 19 Jun 2018 18:02:16 +0100 > Emil Velikov wrote: > >> On 18 June 2018 at 15:40, Pekka Paalanen wrote: >> > From: Pekka Paalanen >> > >> > Now that WESTON_MODULE_MAP supersedes WESTON_BUILD_DI

Re: [PATCH weston 1/4] tests: Don't rely on build directory layout

2018-06-20 Thread Emil Velikov
On 20 June 2018 at 11:51, Pekka Paalanen wrote: > On Tue, 19 Jun 2018 18:30:13 +0100 > Emil Velikov wrote: > >> Hi Pekka, >> >> On 18 June 2018 at 15:40, Pekka Paalanen wrote: >> > From: Daniel Stone >> > >> > Rather than having a hardco

Re: [PATCHv2 wayland 0/8] wayland-scanner: produce code with c99 initializers

2018-06-20 Thread Emil Velikov
On 20 June 2018 at 11:23, Pekka Paalanen wrote: > On Tue, 19 Jun 2018 17:43:47 +0100 > Emil Velikov wrote: > >> On 18 June 2018 at 11:36, Pekka Paalanen wrote: >> > On Thu, 14 Jun 2018 16:49:37 +0100 >> > Emil Velikov wrote: >> > >> >&

Re: [PATCH wayland 1/2] contributing: add review guidelines

2018-06-19 Thread Emil Velikov
Hi Pekka, On 18 June 2018 at 14:42, Pekka Paalanen wrote: > +- Stable ABI or API is not broken. > + I think I've just caught one of those ;-) Thanks for the vast, yet concise writeup. Fwiw Reviewed-by: Emil Velikov -Emil ___ wayland-devel m

Re: [PATCH weston 4/4] tests: Reshuffle IVI layout tests

2018-06-19 Thread Emil Velikov
ate from the rest? Either way, patch looks spot on and is Reviewed-by: Emil Velikov -Emil ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 1/4] tests: Don't rely on build directory layout

2018-06-19 Thread Emil Velikov
Hi Pekka, On 18 June 2018 at 15:40, Pekka Paalanen wrote: > From: Daniel Stone > > Rather than having a hardcoded dependency on the build-directory layout, > use an explicit module-map environment variable, which rewrites requests > for modules and helper/libexec binaries to specific paths. > >

Re: [PATCH weston 2/4] shared: remove weston_config_get_libexec_dir()

2018-06-19 Thread Emil Velikov
On 18 June 2018 at 15:40, Pekka Paalanen wrote: > From: Pekka Paalanen > > Now that WESTON_MODULE_MAP supersedes WESTON_BUILD_DIR for libexec > binaries, we don't need to check in WESTON_BUILD_DIR anymore. > > There was only one user of weston_config_get_libexec_dir(), so remove > the whole

Re: [PATCH wayland 2/2] contributing: commit rights

2018-06-19 Thread Emil Velikov
project. Commit rights will be reinstated when > they > +come back to the project. > + > +Maintainers and committers should encourage contributors to request commit > +rights, especially junior contributors tend to underestimate their skills. > + > + Yay, glad to see some docu

Re: [PATCHv2 wayland 0/8] wayland-scanner: produce code with c99 initializers

2018-06-19 Thread Emil Velikov
On 18 June 2018 at 11:36, Pekka Paalanen wrote: > On Thu, 14 Jun 2018 16:49:37 +0100 > Emil Velikov wrote: > >> Hi all, >> >> Here's a take v2 of the series, with the following changes: >> - don't trim trailing NULL entries from the wl_interfaces* array >&

Re: [PATCH] Makefile.am: add include dir for AC_CONFIG_MACRO_DIR to work

2018-06-18 Thread Emil Velikov
stable/pointer-gestures/pointer-gestures-unstable-v1.xml >> \ >> unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml >> \ >> > > I'm sorry, I didn't specify - this is a patch for wayland-protocols. That helps clear some confus

[PATCH wayland] .gitlab-ci.yml: collect the distcheck error logs

2018-06-14 Thread Emil Velikov
From: Emil Velikov Currently we issue both check and distcheck, as reportedly there has been cases in the past one works, while the other doesn't. Yet we only collect the check artefacts (test logs). Correct that, by picking the distcheck ones as well. Note: the build-*/wayland*/ directory

[PATCH wayland 8/8] fixup! scanner: initialize .{method, event}_count via ARRAY_SIZE

2018-06-14 Thread Emil Velikov
--- tests/data/example-code.c | 73 + tests/data/small-code-core.c| 5 +-- tests/data/small-code.c | 5 +-- tests/data/small-private-code.c | 5 +-- 4 files changed, 46 insertions(+), 42 deletions(-) diff --git

[PATCH wayland 6/8] fixup! scanner: use c99 initializers for the interface symbols

2018-06-14 Thread Emil Velikov
--- tests/data/example-code.c | 124 +++- tests/data/small-code-core.c| 6 +- tests/data/small-code.c | 6 +- tests/data/small-private-code.c | 6 +- 4 files changed, 67 insertions(+), 75 deletions(-) diff --git

[PATCH wayland 7/8] scanner: initialize .{method, event}_count via ARRAY_SIZE

2018-06-14 Thread Emil Velikov
From: Emil Velikov Demystify the final magic value within the generated files. Signed-off-by: Emil Velikov --- src/scanner.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 22b1daa..8f469e9 100644 --- a/src/scanner.c +++ b/src

[PATCH wayland 4/8] fixup! scanner: use c99 initializers for the request/events arrays

2018-06-14 Thread Emil Velikov
--- tests/data/example-code.c | 238 tests/data/small-code-core.c| 8 +- tests/data/small-code.c | 8 +- tests/data/small-private-code.c | 8 +- 4 files changed, 131 insertions(+), 131 deletions(-) diff --git

[PATCH wayland 5/8] scanner: use c99 initializers for the interface symbols

2018-06-14 Thread Emil Velikov
From: Emil Velikov Provides some clarity and removes the unnecessary zero/NULL initialization. Signed-off-by: Emil Velikov --- src/scanner.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index fb3c808..22b1daa 100644 --- a/src

[PATCHv2 wayland 0/8] wayland-scanner: produce code with c99 initializers

2018-06-14 Thread Emil Velikov
understandable by a human being... Thanks Emil Emil Velikov (8): scanner: use c99 initializers for the wl_interface * array fixup! scanner: use c99 initializers for the wl_interface * array scanner: use c99 initializers for the request/events arrays fixup! scanner: use c99 initializers

[PATCH wayland 3/8] scanner: use c99 initializers for the request/events arrays

2018-06-14 Thread Emil Velikov
From: Emil Velikov Makes things a bit less magical, should you be looking in the file. Signed-off-by: Emil Velikov --- src/scanner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 4b49593..fb3c808 100644 --- a/src/scanner.c +++ b

[PATCH wayland 2/8] fixup! scanner: use c99 initializers for the wl_interface * array

2018-06-14 Thread Emil Velikov
--- tests/data/example-code.c | 190 tests/data/small-code-core.c| 16 ++-- tests/data/small-code.c | 16 ++-- tests/data/small-private-code.c | 16 ++-- 4 files changed, 119 insertions(+), 119 deletions(-) diff --git

[PATCH wayland 1/8] scanner: use c99 initializers for the wl_interface * array

2018-06-14 Thread Emil Velikov
From: Emil Velikov Makes it a bit more obvious, should you be reading through the generated code. We might even drop the NULL entries (at a later stage) making things shorter and easier to read. v2: don't alter the array size by discarding trailing NULL entries Signed-off-by: Emil Velikov

Re: [PATCH weston 2/2] Add .gitlab-ci.yml

2018-06-07 Thread Emil Velikov
On 7 June 2018 at 08:46, Daniel Stone wrote: > Hi, > > On 6 June 2018 at 16:41, Emil Velikov wrote: >> On 6 June 2018 at 15:47, Simon McVittie wrote: >>> On Wed, 06 Jun 2018 at 15:33:13 +0100, Emil Velikov wrote: >>>> On 5 June 2018 at 23:06, Daniel

Re: [PATCH weston 2/2] Add .gitlab-ci.yml

2018-06-06 Thread Emil Velikov
On 6 June 2018 at 15:47, Simon McVittie wrote: > On Wed, 06 Jun 2018 at 15:33:13 +0100, Emil Velikov wrote: >> On 5 June 2018 at 23:06, Daniel Stone wrote: >> > + - apt-get -y --no-install-recommends install build-essential automake >> > autoconf libtool pkg-conf

Re: [PATCH weston 2/2] Add .gitlab-ci.yml

2018-06-06 Thread Emil Velikov
On 6 June 2018 at 09:56, Pekka Paalanen wrote: > On Wed, 6 Jun 2018 09:22:59 +0100 > Daniel Stone wrote: > >> On 6 June 2018 at 09:12, Daniel Stone wrote: >> > On 6 June 2018 at 09:03, Pekka Paalanen wrote: >> >> Distcheck does not --disable-xwayland-test, does it? So should we match >> >> it

Re: [PATCH weston 2/2] Add .gitlab-ci.yml

2018-06-06 Thread Emil Velikov
Hi Dan, On 5 June 2018 at 23:06, Daniel Stone wrote: > + - apt-get -y --no-install-recommends install build-essential automake > autoconf libtool pkg-config libexpat1-dev libffi-dev libxml2-dev > libpixman-1-dev libpng-dev libjpeg-dev libcolord-dev mesa-common-dev > libglu1-mesa-dev

Re: [Mesa-dev] [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

2018-04-26 Thread Emil Velikov
On 24 April 2018 at 20:14, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: > On Tue, Apr 24, 2018 at 7:30 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> On 13 April 2018 at 11:00, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: >>> This tries to

Re: [Mesa-dev] [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

2018-04-24 Thread Emil Velikov
On 13 April 2018 at 11:00, Daniel Vetter wrote: > This tries to align with the X.org communities's long-standing > tradition of trying to be an inclusive community and handing out > commit rights fairly freely. > > We also tend to not revoke commit rights for people no

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-21 Thread Emil Velikov
On 21 March 2018 at 09:28, Daniel Stone wrote: > Hi, > > On 21 March 2018 at 08:27, Pekka Paalanen wrote: >> On Tue, 20 Mar 2018 11:46:32 +, Daniel Stone >> wrote: >>> inconvenience of maintaining a list of every linker's

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 15:09, Derek Foreman <der...@osg.samsung.com> wrote: > On 2018-03-20 10:02 AM, Emil Velikov wrote: >> On 20 March 2018 at 14:50, Derek Foreman <der...@osg.samsung.com> wrote: >>> On 2018-03-20 07:11 AM, Daniel Stone wrote: >>>&g

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 14:50, Derek Foreman <der...@osg.samsung.com> wrote: > On 2018-03-20 07:11 AM, Daniel Stone wrote: >> On 20 March 2018 at 11:55, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>> On 20 March 2018 at 11:46, Daniel Stone <dan...@fooishbar.org>

Re: T480s Trackpoint drifts

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 04:05, Peter Hutterer wrote: > On Mon, Mar 19, 2018 at 04:28:20PM +0800, Kai Hendry wrote: >> Hi there, >> >> I'm an Archlinux user who has a new T480s Thinkpad and unfortunately >> the Trackpoint can (not always or reproducibly) "drift". I hope that

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 12:11, Daniel Stone <dan...@fooishbar.org> wrote: > On 20 March 2018 at 11:55, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 20 March 2018 at 11:46, Daniel Stone <dan...@fooishbar.org> wrote: >>> Sure. As on IRC though, we de

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 11:46, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Emil, > > On 20 March 2018 at 11:30, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 20 March 2018 at 11:01, Daniel Stone <dani...@collabora.com> wrote: >>> Rather than a

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

2018-03-20 Thread Emil Velikov
On 20 March 2018 at 11:01, Daniel Stone wrote: > Rather than a hard-coded list of platform symbols, just ignore anything > prefaced with an underscore. This fixes breakage on ARM, which declares > several slightly different platform symbols to x86. > FWIW I've explicitly

[PATCH wayland 2/2] .gitignore: add wayland-egl-abi-check

2018-03-20 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Instruct git go ignore the file, in case we've done an in-tree build. Cc: Derek Foreman <der...@osg.samsung.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- I've opted for the shortest fix - add an entry instead

[PATCH wayland 1/2] wayland-egl-symbols-check: add ARM specific glib entrypoints

2018-03-20 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Seems like glibc on ARM (32 or 64 bit) exports a few extra symbols. Add them to the list. Quick look reveals that those are aliases of the already listed symbols, and have been added to glibc since day 1 :-\ Fixes: 21b1f22eb05 ("

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

2018-03-19 Thread Emil Velikov
On 19 March 2018 at 13:39, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Emil, > > On 19 March 2018 at 13:27, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 19 March 2018 at 13:20, Daniel Stone <dan...@fooishbar.org> wrote: >>> Me neither

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

2018-03-19 Thread Emil Velikov
On 19 March 2018 at 13:20, Daniel Stone wrote: > Hi Quentin, > Thanks for the quick review! > > On 19 March 2018 at 13:06, Quentin Glidic > wrote: >> On 3/19/18 1:31 PM, Daniel Stone wrote: >>> diff --git a/egl/wayland-egl-symbols-check

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

2018-03-19 Thread Emil Velikov
On 19 March 2018 at 09:56, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Fri, 16 Mar 2018 16:18:57 +0000 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 16 March 2018 at 13:52, Pekka Paalanen <ppaala...@gmail.com> wrote: >> > On Thu, 15

Re: [PATCH weston v2] configure.ac: fixup systemd/systemd-login detection

2018-03-16 Thread Emil Velikov
On 15 March 2018 at 17:23, Michael Tretter <m.tret...@pengutronix.de> wrote: > On Thu, 15 Mar 2018 14:20:21 +0000, Emil Velikov wrote: >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Current systemd/systemd-login integration requires dbus. Although

[PATCH wayland] wayland-egl: set the correct path to libwayland-egl.so

2018-03-16 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Earlier commit changed to passing the binary name as env. variable introducing a typo. That went unnoticed, since we do not check if the file is present or not. Cc: Pukka Paalanen <ppaala...@gmail.com> Cc: Daniel Stone <dani..

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

2018-03-16 Thread Emil Velikov
On 16 March 2018 at 13:52, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Thu, 15 Mar 2018 14:30:27 +0000 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Based on a similar patch (in Mes

Re: [PATCH wayland-protcols v2] unstable: add xdg-toplevel-decoration protocol

2018-03-16 Thread Emil Velikov
On 15 March 2018 at 15:43, Simon Ser <cont...@emersion.fr> wrote: > On March 15, 2018 4:15 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 2 March 2018 at 15:33, Simon Ser <cont...@emersion.fr> wrote: >> > This adds a new protocol to negotia

Re: [PATCH wayland-protcols v2] unstable: add xdg-toplevel-decoration protocol

2018-03-15 Thread Emil Velikov
On 2 March 2018 at 15:33, Simon Ser wrote: > This adds a new protocol to negotiate server- and client-side rendering of > window decorations for xdg-toplevels. This allows compositors that want > to draw decorations themselves to send their preference to clients, and >

Re: [weston PATCH] simple-dmabuf-drm: support etnaviv drm as well

2018-03-15 Thread Emil Velikov
On 15 March 2018 at 13:58, Pekka Paalanen wrote: > On Mon, 12 Mar 2018 16:41:46 +0100 > Guido Günther wrote: > >> Since freedreno and etnaviv can live in parallel allow to build in >> different DRM backends. >> --- >> Makefile.am | 6 ++-

[PATCH wayland v3 3/3] wayland-egl: bump the version number to 18.1.0

2018-03-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Seems like I was overoptimistic with my earlier assumption, namely: "... 17.3.x should be the last version that ships the library." Mesa 18.0.0 and its wayland-egl is about to be released any time soon, so bump the numb

[PATCH wayland v3 2/3] wayland-egl: enhance the symbol test

2018-03-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> The current test had a few fall-outs: - it was checking only for T (.text) symbols - did not consider symbol removal Fix that by fetching all the symbols and doing a bidirectional check - for added and removed symbols. Error out with infor

[PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

2018-03-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Based on a similar patch (in Mesa) by Eric Engestrom. v2: Rebase on top of $NM patch v3: Rebase Reviewed-by: Eric Engestrom <e...@engestrom.ch> (v1) Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- egl/wayland-egl-

[PATCH weston v2] configure.ac: fixup systemd/systemd-login detection

2018-03-15 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Current systemd/systemd-login integration requires dbus. Although that is far from clear the way current checks are handled. Be explicit and clear, effectively fixing cases where the systemd auto detection will trip when dbus is explicitly di

[PATCH weston v2] build: honour libinput header location

2018-03-15 Thread Emil Velikov
kka.paala...@collabora.co.uk> Cc: Jan Engelhardt <jeng...@inai.de> [Emil Velikov: polish commit message, v2] Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Pekka feel free to pick whichever patch you feel more confortable with. --- Makefile.am | 5 - 1 file changed, 4 i

Re: [PATCH weston] build: honour libinput header location

2018-03-15 Thread Emil Velikov
On 15 March 2018 at 13:11, Jan Engelhardt wrote: > > On Thursday 2018-03-15 13:20, Pekka Paalanen wrote: >>> diff --git a/Makefile.am b/Makefile.am >>> index b5c29c04..8de40e51 100644 >>> --- a/Makefile.am >>> +++ b/Makefile.am >>> @@ -43,7 +43,8 @@ AM_CPPFLAGS =

[PATCH weston] configure.ac: fixup systemd/systemd-login detection

2018-03-14 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Current systemd/systemd-login integration requires dbus. Although that is far from clear the way current checks are handled. Be explicit and clear, effectively fixing cases where the systemd auto detection will trip when dbus is explicitly di

Re: weston-launch: libEGL: no configs with appropriate attributes

2018-03-14 Thread Emil Velikov
On 14 March 2018 at 11:36, Pekka Paalanen wrote: > On Wed, 14 Mar 2018 11:55:54 +0100 > Král Gergely wrote: > >> Hi, >> >> >> On my old notebook I would like to set up a test environment by running >> weston and let clients to connect to it. I am stuck

Re: [PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-03-13 Thread Emil Velikov
On 12 March 2018 at 11:25, Daniel Stone <dan...@fooishbar.org> wrote: > Hi, > > On 12 March 2018 at 11:21, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 9 March 2018 at 11:09, Daniel Stone <dan...@fooishbar.org> wrote: >>> On 9 March 2018 at 10:

[PATCH wayland] configure.ac: don't install the static libraries

2018-03-13 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> One should always be using the shared libraries. Spotted while going through the Debian packaing. Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- Can we have this in the 1.5 release, please? --- configure.ac | 2 +- 1 fil

Re: [PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-03-12 Thread Emil Velikov
On 9 March 2018 at 11:09, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Emil, > > On 9 March 2018 at 10:59, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 9 March 2018 at 09:47, Daniel Stone <dan...@fooishbar.org> wrote: >>> Patches 2-4 look fine

Re: [PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-03-09 Thread Emil Velikov
On 9 March 2018 at 09:47, Daniel Stone <dan...@fooishbar.org> wrote: > Hi Emil, > > On 8 March 2018 at 18:32, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 28 February 2018 at 16:38, Emil Velikov <emil.l.veli...@gmail.com&g

Re: [PATCH] gl-renderer: Create a high priority context

2018-03-02 Thread Emil Velikov
Hi Chris, On 1 March 2018 at 08:28, Chris Wilson wrote: > EGL_IMG_context_priority allows the client to request that their > rendering be considered high priority. For ourselves, this is important > as we are interactive and any delay in our rendering causes

[PATCH wayland v2 2/4] wayland-egl: fail the symbol check if lib is missing

2018-02-28 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Based on a similar patch (in Mesa) by Eric Engestrom. v2: Rebase on top of $NM patch. Reviewed-by: Eric Engestrom <e...@engestrom.ch> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- egl/wayland-egl-symbols-check

[PATCH wayland v2 3/4] wayland-egl: enhance the symbol test

2018-02-28 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> The current test had a few fall-outs: - it was checking only for T (.text) symbols - did not consider symbol removal Fix that by fetching all the symbols and doing a bidirectional check - for added and removed symbols. Error out with infor

[PATCH wayland v2 4/4] wayland-egl: bump the version number to 18.1.0

2018-02-28 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Seems like I was overoptimistic with my earlier assumption, namely: "... 17.3.x should be the last version that ships the library." Mesa 18.0.0 and its wayland-egl is about to be released any time soon, so bump the numb

[PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

2018-02-28 Thread Emil Velikov
This reverts commit 85cb5ed64aa8246f4da93fc5b76dfc34096bf803. It seems like we've misread the existing code - the DSO name can be propagated via the build-system. The one available in the script was a simple fall-back. v2: Rebase on top of $NM patch. Cc: Daniel Stone ---

[PATCH weston] build: honour libinput header location

2018-02-27 Thread Emil Velikov
From: Jan Engelhardt <jeng...@inai.de> Add the respective CFLAGS to the build, otherwise the build will error out as seen below. src/libinput-seat.c:30:22: fatal error: libinput.h: No such file or directory [Emil Velikov: polish commit message] Signed-off-by: Emil Velikov <

Re: [PATCH wayland] scanner: Fix broken private-code generation

2018-02-23 Thread Emil Velikov
On 23 February 2018 at 22:24, Derek Foreman <der...@osg.samsung.com> wrote: > Missing a closing bracket. > Eek, that's a embarasing. Reviewed-by: Emil Velikov <emil.veli...@collabora.com> We might want to tweak the existing infra to check that, bonus points if we also check th

[PATCH wayland] wayland-egl: use correct `nm` path when cross-compiling

2018-02-23 Thread Emil Velikov
From: Emil Velikov <emil.veli...@collabora.com> Inspired by Heiko Becker and Eric's work in libdrm and Mesa respectively. Cc: Eric Engestrom <eric.engest...@imgtec.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- configure.ac | 1 + egl/w

Re: [RFC wayland-protocols] Add contribution guidelines for desktop extensions

2018-02-22 Thread Emil Velikov
Hi Pekka, On 22 February 2018 at 08:32, Pekka Paalanen wrote: > +Once there is sufficient cross-desktop support for a proposal, the Wayland > +maintainers can accept the extension into wayland-protocols. > + Might be worth defining "sufficient" in a bullet point somewhere.

  1   2   3   4   >