[webkit-changes] [175829] trunk/Tools

2014-11-10 Thread conrad_shultz
Title: [175829] trunk/Tools Revision 175829 Author conrad_shu...@apple.com Date 2014-11-10 14:01:59 -0800 (Mon, 10 Nov 2014) Log Message Unreviewed, moved myself to the list of committers. * Scripts/webkitpy/common/config/contributors.json: Modified Paths trunk/Tools/ChangeLog

[webkit-changes] [175985] trunk/Source/WebKit2

2014-11-11 Thread conrad_shultz
Title: [175985] trunk/Source/WebKit2 Revision 175985 Author conrad_shu...@apple.com Date 2014-11-11 15:59:41 -0800 (Tue, 11 Nov 2014) Log Message Clients should be notified when a page preview finishes https://bugs.webkit.org/show_bug.cgi?id=138635 Reviewed by Tim Horton. Add SPI to

[webkit-changes] [176238] trunk/Source/WebKit2

2014-11-17 Thread conrad_shultz
Title: [176238] trunk/Source/WebKit2 Revision 176238 Author conrad_shu...@apple.com Date 2014-11-17 17:13:16 -0800 (Mon, 17 Nov 2014) Log Message Page previews should be loaded sooner https://bugs.webkit.org/show_bug.cgi?id=138814 Reviewed by Tim Horton. *

[webkit-changes] [176299] trunk/Source/WebKit2

2014-11-18 Thread conrad_shultz
Title: [176299] trunk/Source/WebKit2 Revision 176299 Author conrad_shu...@apple.com Date 2014-11-18 17:43:14 -0800 (Tue, 18 Nov 2014) Log Message Give clients a way to cancel preview popovers https://bugs.webkit.org/show_bug.cgi?id=138855 Reviewed by Tim Horton. Promote -[WKView

[webkit-changes] [176306] trunk/Source/WebKit2

2014-11-18 Thread conrad_shultz
Title: [176306] trunk/Source/WebKit2 Revision 176306 Author conrad_shu...@apple.com Date 2014-11-18 21:08:41 -0800 (Tue, 18 Nov 2014) Log Message Unreviewed. Revision to the build fix in r176304. The guarded method should simply be in the !TARGET_OS_IPHONE block. *

[webkit-changes] [176427] trunk/Source/WebKit2

2014-11-20 Thread conrad_shultz
Title: [176427] trunk/Source/WebKit2 Revision 176427 Author conrad_shu...@apple.com Date 2014-11-20 16:36:45 -0800 (Thu, 20 Nov 2014) Log Message Clients should be able to customize preview click behavior https://bugs.webkit.org/show_bug.cgi?id=138940 Reviewed by Tim Horton. *

[webkit-changes] [176428] trunk/Source/WebKit2

2014-11-20 Thread conrad_shultz
Title: [176428] trunk/Source/WebKit2 Revision 176428 Author conrad_shu...@apple.com Date 2014-11-20 16:57:53 -0800 (Thu, 20 Nov 2014) Log Message Clicks on previews can be recognized multiple times https://bugs.webkit.org/show_bug.cgi?id=138944 Reviewed by Tim Horton. *

[webkit-changes] [176483] trunk/Source/WebKit2

2014-11-21 Thread conrad_shultz
Title: [176483] trunk/Source/WebKit2 Revision 176483 Author conrad_shu...@apple.com Date 2014-11-21 16:07:46 -0800 (Fri, 21 Nov 2014) Log Message Page previews should have a margin. https://bugs.webkit.org/show_bug.cgi?id=138990 Reviewed by Beth Dakin. Enclose the WKWebView (or

[webkit-changes] [176511] trunk/Source/WebKit2

2014-11-23 Thread conrad_shultz
Title: [176511] trunk/Source/WebKit2 Revision 176511 Author conrad_shu...@apple.com Date 2014-11-23 21:21:13 -0800 (Sun, 23 Nov 2014) Log Message Page previews should have titles https://bugs.webkit.org/show_bug.cgi?id=139020 Reviewed by Tim Horton. *

[webkit-changes] [176613] trunk/Source/WebKit2

2014-12-01 Thread conrad_shultz
Title: [176613] trunk/Source/WebKit2 Revision 176613 Author conrad_shu...@apple.com Date 2014-12-01 16:49:49 -0800 (Mon, 01 Dec 2014) Log Message Clients need a way to explicitly set the title of a page preview https://bugs.webkit.org/show_bug.cgi?id=139161 Reviewed by Beth Dakin. This

[webkit-changes] [176707] trunk/Source/WebKit2

2014-12-02 Thread conrad_shultz
Title: [176707] trunk/Source/WebKit2 Revision 176707 Author conrad_shu...@apple.com Date 2014-12-02 18:57:05 -0800 (Tue, 02 Dec 2014) Log Message Don't block menu highlighting when presenting a page preview https://bugs.webkit.org/show_bug.cgi?id=139217 Reviewed by Tim Horton. *

[webkit-changes] [177402] trunk/Source/WebKit2

2014-12-16 Thread conrad_shultz
Title: [177402] trunk/Source/WebKit2 Revision 177402 Author conrad_shu...@apple.com Date 2014-12-16 15:14:55 -0800 (Tue, 16 Dec 2014) Log Message Add a progress indicator to the preview popover https://bugs.webkit.org/show_bug.cgi?id=139699 Reviewed by Tim Horton. *

[webkit-changes] [177754] trunk/Source/WebKit2

2014-12-26 Thread conrad_shultz
Title: [177754] trunk/Source/WebKit2 Revision 177754 Author conrad_shu...@apple.com Date 2014-12-26 21:46:33 -0800 (Fri, 26 Dec 2014) Log Message Safari build crashes when zooming into/choosing a tab from tab view https://bugs.webkit.org/show_bug.cgi?id=139934 Reviewed by Dan Bernstein.

[webkit-changes] [179909] trunk/Source/WebKit2

2015-02-10 Thread conrad_shultz
Title: [179909] trunk/Source/WebKit2 Revision 179909 Author conrad_shu...@apple.com Date 2015-02-10 18:08:49 -0800 (Tue, 10 Feb 2015) Log Message Clients need the ability to hook into immediate action lifecycle https://bugs.webkit.org/show_bug.cgi?id=141449 Reviewed by Tim Horton. *

[webkit-changes] [181607] trunk/Source/WebKit2

2015-03-16 Thread conrad_shultz
Title: [181607] trunk/Source/WebKit2 Revision 181607 Author conrad_shu...@apple.com Date 2015-03-16 19:58:07 -0700 (Mon, 16 Mar 2015) Log Message Don't pass nil as a fireDate for NSTimer https://bugs.webkit.org/show_bug.cgi?id=142765 Reviewed by Dan Bernstein. While we're here, switch

[webkit-changes] [181686] trunk/Source

2015-03-18 Thread conrad_shultz
Title: [181686] trunk/Source Revision 181686 Author conrad_shu...@apple.com Date 2015-03-18 00:05:48 -0700 (Wed, 18 Mar 2015) Log Message Ignore some deprecation warnings https://bugs.webkit.org/show_bug.cgi?id=142813 Reviewed by Mark Rowe. Fixing the deprecations is tracked by:

[webkit-changes] [181562] trunk/Source

2015-03-16 Thread conrad_shultz
Title: [181562] trunk/Source Revision 181562 Author conrad_shu...@apple.com Date 2015-03-16 10:13:04 -0700 (Mon, 16 Mar 2015) Log Message Allow clients to selectively disable plug-ins https://bugs.webkit.org/show_bug.cgi?id=142506 Reviewed by Anders Carlsson. Source/WebCore: Add new

[webkit-changes] [181483] trunk/Source

2015-03-13 Thread conrad_shultz
Title: [181483] trunk/Source Revision 181483 Author conrad_shu...@apple.com Date 2015-03-13 11:58:32 -0700 (Fri, 13 Mar 2015) Log Message Allow clients to selectively disable plug-ins https://bugs.webkit.org/show_bug.cgi?id=142506 Reviewed by Anders Carlsson. Source/WebCore: Add new

[webkit-changes] [181873] trunk/Source/WebCore

2015-03-23 Thread conrad_shultz
Title: [181873] trunk/Source/WebCore Revision 181873 Author conrad_shu...@apple.com Date 2015-03-23 15:04:34 -0700 (Mon, 23 Mar 2015) Log Message Replace uses of kCTFontSystemFontType https://bugs.webkit.org/show_bug.cgi?id=142984 Reviewed by Tim Horton. * rendering/RenderThemeMac.mm:

[webkit-changes] [183978] trunk/Source/WebKit2

2015-05-07 Thread conrad_shultz
Title: [183978] trunk/Source/WebKit2 Revision 183978 Author conrad_shu...@apple.com Date 2015-05-07 21:23:41 -0700 (Thu, 07 May 2015) Log Message Don't register for Lookup notifications until needed https://bugs.webkit.org/show_bug.cgi?id=144783 Reviewed by Tim Horton. *

[webkit-changes] [185717] trunk/Source/WebCore

2015-06-18 Thread conrad_shultz
Title: [185717] trunk/Source/WebCore Revision 185717 Author conrad_shu...@apple.com Date 2015-06-18 12:32:15 -0700 (Thu, 18 Jun 2015) Log Message REGRESSION: js/dom/navigator-plugins-crash.html asserts a lot https://bugs.webkit.org/show_bug.cgi?id=144399 Reviewed by Darin Adler.

[webkit-changes] [191366] trunk/Source/WebKit2

2015-10-20 Thread conrad_shultz
Title: [191366] trunk/Source/WebKit2 Revision 191366 Author conrad_shu...@apple.com Date 2015-10-20 18:10:32 -0700 (Tue, 20 Oct 2015) Log Message _WKThumbnailView should support a snapshot-only mode https://bugs.webkit.org/show_bug.cgi?id=150106 Reviewed by Tim Horton. Add a new

[webkit-changes] [197881] trunk/Source/WebKit2

2016-03-09 Thread conrad_shultz
Title: [197881] trunk/Source/WebKit2 Revision 197881 Author conrad_shu...@apple.com Date 2016-03-09 13:30:45 -0800 (Wed, 09 Mar 2016) Log Message WebsiteDataStore::Configuration::legacyWebsiteDataStoreConfiguration() should respect the passed-in configuration

[webkit-changes] [201366] trunk/Source/WebKit2

2016-05-24 Thread conrad_shultz
Title: [201366] trunk/Source/WebKit2 Revision 201366 Author conrad_shu...@apple.com Date 2016-05-24 17:46:20 -0700 (Tue, 24 May 2016) Log Message _WKThumbnailView should expose its snapshot size https://bugs.webkit.org/show_bug.cgi?id=158049 Reviewed by Tim Horton. *

[webkit-changes] [200957] trunk/Source/WebKit2

2016-05-16 Thread conrad_shultz
Title: [200957] trunk/Source/WebKit2 Revision 200957 Author conrad_shu...@apple.com Date 2016-05-16 12:20:40 -0700 (Mon, 16 May 2016) Log Message Fix some deprecation warnings. * UIProcess/mac/WKPrintingView.mm: (-[WKPrintingView _drawPDFDocument:page:atPoint:]): *

[webkit-changes] [199646] trunk/Source/WebCore

2016-04-17 Thread conrad_shultz
Title: [199646] trunk/Source/WebCore Revision 199646 Author conrad_shu...@apple.com Date 2016-04-17 12:33:57 -0700 (Sun, 17 Apr 2016) Log Message Try (again) to fix debug builds after r199643. Unreviewed. * dom/ScriptExecutionContext.cpp: Add another missing include. Modified Paths

[webkit-changes] [199645] trunk/Source/WebCore

2016-04-17 Thread conrad_shultz
Title: [199645] trunk/Source/WebCore Revision 199645 Author conrad_shu...@apple.com Date 2016-04-17 12:28:38 -0700 (Sun, 17 Apr 2016) Log Message Try to fix debug builds after r199643. Unreviewed. * Modules/indexeddb/IDBObjectStore.cpp: Add a missing include. Modified Paths

[webkit-changes] [215615] trunk/Tools

2017-04-21 Thread conrad_shultz
Title: [215615] trunk/Tools Revision 215615 Author conrad_shu...@apple.com Date 2017-04-21 10:26:14 -0700 (Fri, 21 Apr 2017) Log Message commit-log-editor should respect the git editor if one is set https://bugs.webkit.org/show_bug.cgi?id=171085 Reviewed by Daniel Bates. *

[webkit-changes] [230747] trunk/Source/WebKit

2018-04-17 Thread conrad_shultz
Title: [230747] trunk/Source/WebKit Revision 230747 Author conrad_shu...@apple.com Date 2018-04-17 20:07:10 -0700 (Tue, 17 Apr 2018) Log Message WebKit::DisplayLink maintains a strong reference to WebPageProxy, creating a reference cycle https://bugs.webkit.org/show_bug.cgi?id=184718

[webkit-changes] [236491] trunk/Source/WebKit

2018-09-25 Thread conrad_shultz
Title: [236491] trunk/Source/WebKit Revision 236491 Author conrad_shu...@apple.com Date 2018-09-25 18:18:53 -0700 (Tue, 25 Sep 2018) Log Message Enable customization of the file upload panel https://bugs.webkit.org/show_bug.cgi?id=189970 Reviewed by Wenson Hsieh. With this change,

[webkit-changes] [240353] trunk/Source

2019-01-23 Thread conrad_shultz
Title: [240353] trunk/Source Revision 240353 Author conrad_shu...@apple.com Date 2019-01-23 12:36:37 -0800 (Wed, 23 Jan 2019) Log Message Clean up USE(WEB_THREAD) https://bugs.webkit.org/show_bug.cgi?id=193698 Rubber-stamped by Tim Horton. WebCore: *

[webkit-changes] [240355] trunk/Source

2019-01-23 Thread conrad_shultz
Title: [240355] trunk/Source Revision 240355 Author conrad_shu...@apple.com Date 2019-01-23 13:03:32 -0800 (Wed, 23 Jan 2019) Log Message Unreviewed; Revert "Clean up USE(WEB_THREAD)" This reverts commit 24ba8bb9e1dad8679b492d9a2d47da619be85789.

[webkit-changes] [238674] trunk/Source/WebKit

2018-11-29 Thread conrad_shultz
Title: [238674] trunk/Source/WebKit Revision 238674 Author conrad_shu...@apple.com Date 2018-11-29 10:26:46 -0800 (Thu, 29 Nov 2018) Log Message Factor out configuration of the file upload image picker https://bugs.webkit.org/show_bug.cgi?id=192138 Reviewed by Tim Horton. By factoring

[webkit-changes] [242368] trunk/Source/WebCore/PAL

2019-03-04 Thread conrad_shultz
Title: [242368] trunk/Source/WebCore/PAL Revision 242368 Author conrad_shu...@apple.com Date 2019-03-04 11:58:34 -0800 (Mon, 04 Mar 2019) Log Message Improper use of PLATFORM(TVOS) in PAL https://bugs.webkit.org/show_bug.cgi?id=195215 Reviewed by Darin Adler. There are a couple stray

[webkit-changes] [243168] trunk/Source/WebKit

2019-03-19 Thread conrad_shultz
Title: [243168] trunk/Source/WebKit Revision 243168 Author conrad_shu...@apple.com Date 2019-03-19 13:35:14 -0700 (Tue, 19 Mar 2019) Log Message REGRESSION (r242369): Only use picker-supported UTIs when creating image picker https://bugs.webkit.org/show_bug.cgi?id=195955 Reviewed by

[webkit-changes] [240369] trunk/Source/WebKitLegacy/mac

2019-01-23 Thread conrad_shultz
Title: [240369] trunk/Source/WebKitLegacy/mac Revision 240369 Author conrad_shu...@apple.com Date 2019-01-23 17:08:31 -0800 (Wed, 23 Jan 2019) Log Message Fix the Apple Internal build. See . Rubber-stamped by Tim Horton. * WebCoreSupport/WebFrameLoaderClient.mm: Modified Paths

[webkit-changes] [240729] trunk/Source/WebKit

2019-01-30 Thread conrad_shultz
Title: [240729] trunk/Source/WebKit Revision 240729 Author conrad_shu...@apple.com Date 2019-01-30 13:46:52 -0800 (Wed, 30 Jan 2019) Log Message Ensure image picker sourceType is set before cameraDevice https://bugs.webkit.org/show_bug.cgi?id=193998 Reviewed by Beth Dakin. *

[webkit-changes] [252729] trunk/Source/WebCore

2019-11-20 Thread conrad_shultz
Title: [252729] trunk/Source/WebCore Revision 252729 Author conrad_shu...@apple.com Date 2019-11-20 23:25:43 -0800 (Wed, 20 Nov 2019) Log Message Crash at com.apple.WebCore: -[WebRevealHighlight revealContext:drawRectsForItem:] https://bugs.webkit.org/show_bug.cgi?id=204434 Reviewed by

[webkit-changes] [252782] trunk/Source/WebKit

2019-11-22 Thread conrad_shultz
Title: [252782] trunk/Source/WebKit Revision 252782 Author conrad_shu...@apple.com Date 2019-11-22 10:41:33 -0800 (Fri, 22 Nov 2019) Log Message Remove -[_WKThumbnailView usesSnapshot/setUsesSnapshot:] https://bugs.webkit.org/show_bug.cgi?id=150099 Reviewed by Tim Horton. Remove some

[webkit-changes] [255467] trunk/Source/WTF

2020-01-30 Thread conrad_shultz
Title: [255467] trunk/Source/WTF Revision 255467 Author conrad_shu...@apple.com Date 2020-01-30 16:15:47 -0800 (Thu, 30 Jan 2020) Log Message `FALLTHROUGH` macro isn't properly defined when building Objective-C files using Clang https://bugs.webkit.org/show_bug.cgi?id=206637 Reviewed by

[webkit-changes] [264746] trunk

2020-07-22 Thread conrad_shultz
Title: [264746] trunk Revision 264746 Author conrad_shu...@apple.com Date 2020-07-22 21:49:02 -0700 (Wed, 22 Jul 2020) Log Message Update macOS Version macros https://bugs.webkit.org/show_bug.cgi?id=214653 Reviewed by Tim Horton. PerformanceTests: *

[webkit-changes] [269124] trunk/Source/WebCore

2020-10-28 Thread conrad_shultz
Title: [269124] trunk/Source/WebCore Revision 269124 Author conrad_shu...@apple.com Date 2020-10-28 14:16:49 -0700 (Wed, 28 Oct 2020) Log Message Remove diagnostic logging for plug-ins https://bugs.webkit.org/show_bug.cgi?id=218304 Reviewed by Tim Horton. There's no longer a need to