Re: [webkit-dev] Announcing Login with GitHub on EWS webpages

2023-03-15 Thread Aakash Jain via webkit-dev
judgement in deciding when to press that button. Thanks Aakash > On Feb 23, 2023, at 4:18 PM, Aakash Jain wrote: > > I have also deployed the same "Login with GitHub" feature on build.webkit.org > (post-commit CI). Very small subset of our users (especially admins, &g

Re: [webkit-dev] Announcing Login with GitHub on EWS webpages

2023-02-23 Thread Aakash Jain via webkit-dev
you notice any issue or have any feedback. Thanks Aakash > On Feb 22, 2023, at 2:29 PM, Aakash Jain wrote: > > One cool trick can be to combine this feature with "skip-ews" GitHub label > (or --no-ews flag in git-webkit, announced in > https://lists.webkit.org/

Re: [webkit-dev] Announcing Login with GitHub on EWS webpages

2023-02-22 Thread Aakash Jain via webkit-dev
se let me know if anyone has any question. Thanks Aakash > On Feb 20, 2023, at 4:34 PM, Aakash Jain wrote: > > Hi Everyone, > > I am happy to announce a new feature in EWS: "Login with GitHub". > > In Bugzilla world, we have a feature named "Retry

[webkit-dev] Announcing Login with GitHub on EWS webpages

2023-02-20 Thread Aakash Jain via webkit-dev
Hi Everyone, I am happy to announce a new feature in EWS: "Login with GitHub". In Bugzilla world, we have a feature named "Retry failed builds" which allow us to retry the EWS builds which failed (especially useful when the failure might be due to flakiness or infrastructure issue). However,

Re: [webkit-dev] git-webkit pr now supports --no-ews / --ews flags

2023-01-27 Thread Aakash Jain via webkit-dev
s bad when one > thing becomes two. Can we pick one name for this feature? Either —no-ews > (git-webkit) and no-ews (GitHub) or —skip-ews (git-webkit) and skip-ews > (GitHub)? > > Thanks, > Geoff > >> On Jan 26, 2023, at 11:36 AM, Aakash Jain via webkit-dev &g

[webkit-dev] git-webkit pr now supports --no-ews / --ews flags

2023-01-26 Thread Aakash Jain via webkit-dev
Hi Everyone, git-webkit pr now supports --no-ews / --ews flags (as of 259115@main). This is similar to --no-ews flag we had in webkit-patch. You can also manually add skip-ews label on any PR when you don't need EWS to run anymore on it. --no-ews flag will also automatically add the skip-ews

[webkit-dev] Announcing EWS status-bubbles on Github PRs

2022-08-17 Thread Aakash Jain via webkit-dev
Hi Everyone, I am happy to announce EWS status-bubbles on Github PRs. We’ve ported many of the best features of Bugzilla EWS status-bubbles to a GitHub compatible format. From now on, when you create any new GitHub PR, you will automatically see EWS status-bubbles on your PRs. We also mirror

Re: [webkit-dev] New fast commit queue mode: fast-cq

2021-10-25 Thread Aakash Jain via webkit-dev
I have added fast-cq support to webkit-patch land-safely in https://commits.webkit.org/243492@main Sample invocation: webkit-patch land-safely --fast-cq Thanks Aakash > On Oct 21, 2021, at 8:28 PM, Aakash Jain wrote: > > > >> On Oct 21, 2021, at 7:36 PM, John Wiland

Re: [webkit-dev] New fast commit queue mode: fast-cq

2021-10-21 Thread Aakash Jain via webkit-dev
> On Oct 21, 2021, at 7:36 PM, John Wilander wrote: > >> On Apr 8, 2021, at 1:44 PM, Aakash Jain via webkit-dev >> mailto:webkit-dev@lists.webkit.org>> wrote: >> >> Hi Everyone, >> >> I am happy to inform you that I have added a fast-commit-

Re: [webkit-dev] Commit Queue down for maintainence

2021-07-28 Thread Aakash Jain via webkit-dev
Commit Queue is back online. Please let me know if you notice any issue. Thanks Aakash > On Jul 28, 2021, at 1:27 PM, Aakash Jain wrote: > > Hi Everyone, > > We just took commit-queue bots offline for some maintenance. I will send > another update when they are back o

[webkit-dev] Commit Queue down for maintainence

2021-07-28 Thread Aakash Jain via webkit-dev
Hi Everyone, We just took commit-queue bots offline for some maintenance. I will send another update when they are back online. Thanks Aakash ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Ryan Haddad is now a WebKit Reviewer

2021-07-15 Thread Aakash Jain via webkit-dev
Hello All, I would like to announce that Ryan Haddad is now a WebKit Reviewer. His expertise is tools and infrastructure. Please join me in congratulation him.  Congratulations Ryan!  -Aakash___ webkit-dev mailing list webkit-dev@lists.webkit.org

[webkit-dev] Is valgrind suppressions.txt unused

2021-04-30 Thread Aakash Jain via webkit-dev
Hi Everyone, Is anyone (particularly gtk folks) are using valgrind especially suppressions.txt file (https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/valgrind/suppressions.txt). This file doesn't seems to be modified for a long time, so I am not sure if this is even being used. I am

Re: [webkit-dev] Commit-Queue failing intermittently

2021-04-24 Thread Aakash Jain via webkit-dev
back to git.webkit.org in https://bugs.webkit.org/show_bug.cgi?id=224762 Commit-Queue seems to be working reliably since then (without a single such issue in last 5 days). Thanks Aakash > On Feb 23, 2021, at 7:06 PM, Aakash Jain wrote: > > Most of the issues with commit-queue were

[webkit-dev] New fast commit queue mode: fast-cq

2021-04-08 Thread Aakash Jain via webkit-dev
Hi Everyone, I am happy to inform you that I have added a fast-commit-queue mode to the Commit-Queue. In this mode Commit-Queue would land patches quickly (typically taking ~1 minute, e.g.: https://ews-build.webkit.org/#/builders/28/builds/10876). This mode skips building and testing. It

[webkit-dev] New EWS queue: Stress Test EWS

2021-04-06 Thread Aakash Jain via webkit-dev
Hi Everyone, I am happy to announce that I have added a new EWS queue: Stress Test EWS. From now on, you would see a new status bubbles (on Bugzilla bug) named: 'mac-wk2-stress'. For the patches that add or modify layout tests, this EWS will run those added/modified layout-tests repeatedly

[webkit-dev] EWS and build.webkit.org upgraded to Buildbot v2.10.5

2021-04-05 Thread Aakash Jain via webkit-dev
it.org to this Buildbot (v2.10.5). Please let me know if anyone notices any issue. Thanks Aakash > On Mar 5, 2021, at 7:32 PM, Aakash Jain wrote: > > Hi Everyone > > I have also upgraded EWS (ews-build.webkit.org) to latest Buildbot (v2.10.1). > > Please let me know if anyone not

Re: [webkit-dev] Reminder: WebKit SVN tree clousures (March 2021)

2021-03-22 Thread Aakash Jain via webkit-dev
Hello everyone, The maintenance has been completed. WebKit SVN tree is open again. Commit-queue bots are also back online. Thanks for your patience. Please let us know if you notice any issue. Thanks Aakash > On Mar 17, 2021, at 12:50 PM, Ling Ho via webkit-dev > wrote: > > Hello, > > The

[webkit-dev] github.com repository force push

2021-03-19 Thread Aakash Jain via webkit-dev
Hi everyone, We had little bit of issue with syncing between WebKit's github and svn repositories. To fix the issue, we had to force push and modify few git commits. In case you notice any conflict in your github.com checkout of WebKit repo (which might be because of

[webkit-dev] EWS Upgraded to latest Buildbot

2021-03-05 Thread Aakash Jain via webkit-dev
Hi Everyone I have also upgraded EWS (ews-build.webkit.org) to latest Buildbot (v2.10.1). Please let me know if anyone notices any issue. Thanks Aakash > On Feb 8, 2021, at 8:04 PM, Aakash Jain wrote: > Hello Everyone, > > We have upgraded build.webkit.org to latest Build

Re: [webkit-dev] Commit-Queue failing intermittently

2021-02-23 Thread Aakash Jain via webkit-dev
Most of the issues with commit-queue were fixed. We also added automatic retries in commit-queue to better handle intermittent issues (in https://webkit.org/b/222038). Please let me know if anyone notices any issue. Thanks Aakash > On Feb 4, 2021, at 4:39 PM, Aakash Jain wrote: >

Re: [webkit-dev] EWS down for emergency maintenance

2021-02-20 Thread Aakash Jain via webkit-dev
EWS (including commit-queue) is back online. Please let me know if anyone notices any issue. Thanks Aakash > On Feb 20, 2021, at 8:20 AM, Aakash Jain wrote: > > Hi Everyone, > > EWS (including commit-queue) is currently down for emergency maintenance. > Status bubbles on

[webkit-dev] EWS down for emergency maintenance

2021-02-20 Thread Aakash Jain via webkit-dev
Hi Everyone, EWS (including commit-queue) is currently down for emergency maintenance. Status bubbles on existing Bugzilla bugs should still keep loading. I'll send an update when the maintenance is complete. Thanks Aakash ___ webkit-dev mailing list

[webkit-dev] build.webkit.org Upgraded to latest Buildbot

2021-02-08 Thread Aakash Jain via webkit-dev
Hello Everyone, We have upgraded build.webkit.org to latest Buildbot (v2.10.1 released in 2021) (https://webkit.org/b/175056). Earlier it was running an ancient version of Buildbot, v0.8.6p1 (released in 2012). This is a brand new server. Buildbot doesn't support migrating data from old

[webkit-dev] Commit-Queue failing intermittently

2021-02-04 Thread Aakash Jain via webkit-dev
We are noticing intermittent issues with Commit-Queue failing to commit, since we moved it to github. We are looking into it. Meanwhile, if Commit-Queue fails on your patch, you can set cq+ again to retry. Thanks Aakash > On Jan 19, 2021, at 4:56 PM, Aakash Jain wrote: > > All t

Re: [webkit-dev] EWS offline for maintenance for about an hour

2021-01-19 Thread Aakash Jain via webkit-dev
All the issues have been fixed. Please let me know if anyone notices any issue. Thanks Aakash > On Jan 19, 2021, at 12:23 PM, Aakash Jain wrote: > > We are noticing some issues on Style-Queue and Commit-Queue. We are looking > into that. > > Thanks > Aakash > >

Re: [webkit-dev] EWS offline for maintenance for about an hour

2021-01-19 Thread Aakash Jain via webkit-dev
We are noticing some issues on Style-Queue and Commit-Queue. We are looking into that. Thanks Aakash > On Jan 19, 2021, at 9:58 AM, Aakash Jain wrote: > > Hi Everyone, > > We need to do some maintenance on the EWS bots (in order to switch the > repository from git.w

[webkit-dev] EWS offline for maintenance for about an hour

2021-01-19 Thread Aakash Jain via webkit-dev
Hi Everyone, We need to do some maintenance on the EWS bots (in order to switch the repository from git.webkit.org to https://github.com/webkit/webkit, https://bugs.webkit.org/show_bug.cgi?id=220479). EWS buildbot will be offline for about an hour, so it wouldn't process any new builds.

Re: [webkit-dev] Problems with code review tool

2020-09-23 Thread Aakash Jain
Interesting. I haven't noticed such problem myself and wasn't aware of this issue. I was aware that the EWS status-bubble loading time has been increasing steadily as we have been increasing number of EWS queues. Tracked in https://bugs.webkit.org/show_bug.cgi?id=214821. I will prioritize

[webkit-dev] EWS now cq- the patches with build or layout test failure

2020-09-09 Thread Aakash Jain
Hi All, From now on, whenever EWS detects any build failure or layout test failure caused by a patch, it will mark the patch cq-. If the patch was in commit queue at the time it was marked cq-, commit queue would not land it. You can always mark the patch cq+ again (if you think that EWS was

[webkit-dev] EWS now sends email notifications for failures

2020-08-25 Thread Aakash Jain
Hi Everyone, I am happy to announce another EWS feature: email notifications. >From now on, whenever EWS detects any build or test failure caused by a patch, >it will send email notification to the patch author. In case of build failure, >email will contain the relevant error lines, so as to

Re: [webkit-dev] EWS now parses error logs in case of build failure

2020-08-11 Thread Aakash Jain
' log is also present, containing only 1 line which is the relevant error. Hopefully this would make it easier to spot the relevant errors from large logs. Please let me know if you notice any issue or have any feedback.. Thanks Aakash > On Oct 29, 2019, at 7:05 PM, Aakash Jain wrote: >

Re: [webkit-dev] New EWS queues for tvOS and watchOS

2020-07-14 Thread Aakash Jain
Suzuki wrote: >> >> Nice, >> >> Is watchOS build ARMv7k? Or is it ARM64_32? >> >> -Yusuke >> >>> On Jul 11, 2020, at 8:09 AM, Aakash Jain wrote: >>> >>> Hi Everyone, >>> >>> I am happy to announce that we ha

[webkit-dev] New EWS queues for tvOS and watchOS

2020-07-11 Thread Aakash Jain
Hi Everyone, I am happy to announce that we have added new EWS queues for tvOS and watchOS. From now on, you would see four new status bubbles (on Bugzilla bug) named: tv, tv-sim, watch, watch-sim (corresponding to device and simulator builds for watchOS and tvOS). This should help in

Re: [webkit-dev] ios-wk2 ews queue slow due to fast/hidpi/image-srcset-relative-svg-canvas-2x.html test

2020-03-31 Thread Aakash Jain
https://bugs.webkit.org/show_bug.cgi?id=207038 has been fixed, thanks to Said Abou-Hallawa. ios-wk2 ews queue is fast again (https://ews-build.webkit.org/#/builders/24). Please let me know if you notice any issue. Thanks Aakash > On Mar 26, 2020, at 7:01 PM, Aakash Jain wrote: >

[webkit-dev] ios-wk2 ews queue slow due to fast/hidpi/image-srcset-relative-svg-canvas-2x.html test

2020-03-26 Thread Aakash Jain
Hi Everyone, Many of you might have noticed that ios-wk2 EWS queue has been slow for a while now. This is primarily due to the layout test fast/hidpi/image-srcset-relative-svg-canvas-2x.html being extremely flaky on EWS. Sometimes this also results in false positive, causing EWS to think that

Re: [webkit-dev] Transitioning commit-queue to new EWS and deprecating old EWS

2020-03-23 Thread Aakash Jain
Mar 18, 2020, at 3:12 PM, Aakash Jain wrote: > > Hello Everyone, > > I have transitioned commit-queue from old EWS to new EWS. This was the last > queue on old EWS. I will soon start deleting old EWS code from the repository. > > While transitioning the commit-queue,

[webkit-dev] Transitioning commit-queue to new EWS and deprecating old EWS

2020-03-18 Thread Aakash Jain
Hello Everyone, I have transitioned commit-queue from old EWS to new EWS. This was the last queue on old EWS. I will soon start deleting old EWS code from the repository. While transitioning the commit-queue, I have also made several improvements: - commit-queue now supports security bugs -

Re: [webkit-dev] Updating iOS EWS

2020-02-12 Thread Aakash Jain
The bug (https://webkit.org/b/207115) was fixed yesterday, and api-ios ews is back to normal. Please let me know if you notice any issue.ThanksAakashOn Feb 3, 2020, at 1:56 PM, Aakash Jain wrote:We are noticing various API test failures on iOS after the OS update. Some of the API tests on iOS

Re: [webkit-dev] Updating iOS EWS

2020-02-03 Thread Aakash Jain
We are noticing various API test failures on iOS after the OS update. Some of the API tests on iOS are being very flaky, causing api-ios EWS queue to slow down and occasionally blaming the patch being tested for those test failure. Please verify the api-ios EWS result accordingly. We are

Re: [webkit-dev] macOS EWS queues down for maintenance

2020-01-10 Thread Aakash Jain
> On Jan 9, 2020, at 6:23 PM, Aakash Jain wrote: > > Quick Update: we are still working on updating the bots and resolving any > issues. We also upgraded hardware for few of the bots (from MacPro5,1 to > MacPro 6,1). We expect it to be finished by tomorrow. > > Thanks &g

Re: [webkit-dev] macOS EWS queues down for maintenance

2020-01-09 Thread Aakash Jain
Quick Update: we are still working on updating the bots and resolving any issues. We also upgraded hardware for few of the bots (from MacPro5,1 to MacPro 6,1). We expect it to be finished by tomorrow. Thanks Aakash > On Jan 8, 2020, at 10:41 PM, Aakash Jain wrote: > > Hi Everyone

[webkit-dev] macOS EWS queues down for maintenance

2020-01-08 Thread Aakash Jain
Hi Everyone, We are in process of upgrading our macOS bots from High Sierra to Mojave https://bugs.webkit.org/show_bug.cgi?id=205948 We are noticing some unexpected configuration issues. For now, we have paused most of macOS EWS queues while we

Re: [webkit-dev] Handling flaky layout-test failures in EWS

2019-12-05 Thread Aakash Jain
> > I understand some flakiness might be specific to EWS but I’d imagine that’d > be more of minority. If it is common, we could also make EWS bots > periodically run full tests without patches and report results to flakiness > dashboard so that we have a corpse of flaky teat

Re: [webkit-dev] Handling flaky layout-test failures in EWS

2019-12-05 Thread Aakash Jain
gt; - Clean re-run produces no failures. > > This looks like decent evidence to make the EWS bubble red. I don't know what > exactly the threshold should be, but that should certainly be below 30. > > - Alexey > > >> 3 дек. 2019 г., в 8:40 AM, Aakash Jain > <mailto:aakash

[webkit-dev] Handling flaky layout-test failures in EWS

2019-12-03 Thread Aakash Jain
Hi Everyone, We have various layout-tests which are flaky (which sometimes pass and sometimes fail/crash/timeout). EWS needs to work despite these flaky tests, and need to be able to tell whether the patch being tested introduced any test failure or not. In EWS, we have logic (same logic in

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-12-02 Thread Aakash Jain
l to >>> the patch author is not something anyone can Cc themselves on, and is not >>> archived, so seems like a strictly worse form of communication. >>> >>>> On Nov 2, 2019, at 9:34 AM, Alexey Proskuryakov >>> <mailto:a...@apple.com>> wrot

[webkit-dev] Survey regarding EWS

2019-12-02 Thread Aakash Jain
Hi Everyone, I want to get everyone's opinion on EWS, especially regarding if (and how) EWS should send notifications when a patch fails on any EWS queue. Here is a link to a short survey: https://www.surveymonkey.com/r/XQ77LQD I would appreciate if

Re: [webkit-dev] iOS EWS behind by 3 days??

2019-11-10 Thread Aakash Jain
This queue is back in good shape. Alexey figured out that the root-cause was a configuration issue, which started after our recent upgrade of iOS EWS bots to Catalina. Thanks Aakash > On Nov 5, 2019, at 11:57 AM, Alexey Proskuryakov wrote: > > > >> 4 нояб. 2019 г., в 11:30 PM, Ryosuke Niwa

[webkit-dev] Wincairo build broken

2019-11-02 Thread Aakash Jain
Hello, Wincairo build seems to be broken. I filed: https://bugs.webkit.org/show_bug.cgi?id=203791 [wincairo] 'deref': is not a member of

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-01 Thread Aakash Jain
t; How about only a single comment when the first failure occurs? (Or else when > all bots pass, if there is never a failure.) > > This should help the author, the reviewer, and anyone else cc’d, without > being too spammy. > >> On Nov 1, 2019, at 5:20 PM, Aakash Jain wrot

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-01 Thread Aakash Jain
tification? Maybe a flag on > a patch or JSON configuration file somewhere. > > - R. Niwa > > On Tue, Oct 29, 2019 at 4:05 PM Aakash Jain wrote: > Hi Everyone, > > I am happy to announce another EWS feature. > > From now on, in case of build failure, EWS will parse the erro

[webkit-dev] EWS now parses error logs in case of build failure

2019-10-29 Thread Aakash Jain
Hi Everyone, I am happy to announce another EWS feature. >From now on, in case of build failure, EWS will parse the errors and display >them in a separate 'errors' log. You wouldn't have to search through thousands >of lines of logs to find the error message. For example, in

Re: [webkit-dev] Planned EWS improvements

2019-10-22 Thread Aakash Jain
any feedback. Known UI issues: https://bugs.webkit.org/show_bug.cgi?id=203249 <https://bugs.webkit.org/show_bug.cgi?id=203249> Thanks Aakash > On Sep 26, 2019, at 7:56 PM, Saam Barati wrote: > > Hi Aakash, > > Thanks for doing this work. > >> On Sep 26,

[webkit-dev] Some EWS bots facing network issues while trying to reach S3

2019-10-22 Thread Aakash Jain
Hi All, Some of the EWS bots are facing network issues while trying to reach S3 (since this morning). We are working to fix the issue as quickly as possible. Tracking in: https://bugs.webkit.org/show_bug.cgi?id=203246 If you have any

Re: [webkit-dev] Wincairo build seems to be broken

2019-10-13 Thread Aakash Jain
%20Debug%20%28Build%29/builds/11055 Thanks Aakash > On Oct 12, 2019, at 2:43 AM, Aakash Jain wrote: > > Tracking in https://bugs.webkit.org/show_bug.cgi?id=202879 > <https://bugs.webkit.org/show_bug.cgi?id=202879>. Probably broken in > https://bugs.webkit.org/show_bug.cg

Re: [webkit-dev] Wincairo build seems to be broken

2019-10-12 Thread Aakash Jain
shape, it's probably easy to accidentally break WinCairo (WinCairo EWS didn't run properly in above case as well). -Aakash > On Oct 12, 2019, at 2:33 AM, Aakash Jain wrote: > > Hello All, > > Wincairo build seems to be broken. EWS and build.webkit.org > <http://build

[webkit-dev] Wincairo build seems to be broken

2019-10-12 Thread Aakash Jain
Hello All, Wincairo build seems to be broken. EWS and build.webkit.org seems to be failing with below build error, e.g.: https://ews-build.webkit.org/#/builders/12/builds/7400/steps/9/logs/stdio,

Re: [webkit-dev] JSC EWS being too optimistic

2019-10-09 Thread Aakash Jain
Hi Caio, Thanks for reporting this issue. Jonathan fixed the bug you reported (https://bugs.webkit.org/show_bug.cgi?id=202419 ). It was a regression from a recent change. I verified the fix using the same patch you tested with earlier. jsc EWS

Re: [webkit-dev] Upgrading Buildbot on EWS

2019-10-06 Thread Aakash Jain
Hi All, The upgrade went smoothly. EWS with Buildbot v1.8.2 seems to be running fine. Please let me know if anyone notices any issue. https://ews-build.webkit.org/#/about <https://ews-build.webkit.org/#/about> Thanks Aakash > On Oct 5, 2019, at 10:22 AM, Aakash Jain wrote: &g

[webkit-dev] Upgrading Buildbot on EWS

2019-10-05 Thread Aakash Jain
Hi All, I am planning to upgrade Buildbot on EWS (ews-build.webkit.org) tomorrow (Sunday, Oct 6th) around 6am PST from v1.7 to v1.8.2. It would give us few security fixes. Note that we aren't upgrading to Buildbot 2.0+ yet, since it need Python 3 compatibility. Python 3 compatibility work

Re: [webkit-dev] Planned EWS improvements

2019-09-30 Thread Aakash Jain
> On Sep 30, 2019, at 9:32 AM, Adrian Perez de Castro wrote: > > Hello Aakash (and everybody else), > > On Thu, 26 Sep 2019 14:27:25 -0400, Aakash Jain wrote: > >> I have been making number of improvements to EWS. I also have various >> planned improvements to

Re: [webkit-dev] ios-wk2 EWS in a bad state because of flaky tests

2019-09-29 Thread Aakash Jain
This queue is back in good state. Please let me know if you notice any issue. Thanks Aakash > On Sep 27, 2019, at 9:21 PM, Aakash Jain wrote: > > Hi All, > > Last week we updated the iOS bots from iOS 12 to iOS 13. Since then we have > been noticing a lot of flaky tests. B

[webkit-dev] ios-wk2 EWS in a bad state because of flaky tests

2019-09-27 Thread Aakash Jain
Hi All, Last week we updated the iOS bots from iOS 12 to iOS 13. Since then we have been noticing a lot of flaky tests. Because of that ios-wk2 queue has been in a bad state. Most of the time, it is unable to determine if the test failures were introduced by the patch or were pre-existing, and

Re: [webkit-dev] Planned EWS improvements

2019-09-27 Thread Aakash Jain
ot; : >>> On Sep 27, 2019, at 3:27 AM, Aakash Jain wrote: >>> >>> Hi Everyone, >>> >>> I have been making number of improvements to EWS. I also have various >>> planned improvements to EWS. I wanted to reach out to you guys to see if >&

Re: [webkit-dev] WinCairo EWS

2019-09-27 Thread Aakash Jain
Do you think adding a build step before svn-apply which deletes “ C:\Users\ContainerAdministrator\AppData\Local\Temp” would help? Thanks Aakash > On Sep 27, 2019, at 1:34 PM, ross.kirsl...@sony.com wrote: > >  > It provides every bit as much useful information as any other EWS bot when >

[webkit-dev] Planned EWS improvements

2019-09-26 Thread Aakash Jain
Hi Everyone, I have been making number of improvements to EWS. I also have various planned improvements to EWS. I wanted to reach out to you guys to see if anyone wants me to prioritize any particular improvement(s). If there is any improvement which you want to see and is not listed below,

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

2019-09-25 Thread Aakash Jain
lt;https://bugs.webkit.org/show_bug.cgi?id=201993>> > > Maybe we could do something similar for layout test failures (a semi-modal > dialog that lists the errors, and links directly to the results rather than > having to click (twice) through the buildbot landing page

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

2019-09-19 Thread Aakash Jain
> On Jun 16, 2019, at 2:14 PM, Darin Adler wrote: > >> On Jun 15, 2019, at 9:13 PM, Aakash Jain > <mailto:aakash_j...@apple.com>> wrote: >> >> 1) Do not upload archive (for layout-test-results) on bugzilla, instead >> upload it to another server, un

Re: [webkit-dev] Questions about JSC EWS queues

2019-09-19 Thread Aakash Jain
> On Sep 19, 2019, at 7:22 AM, Guillaume Emont wrote: > > Quoting Aakash Jain (2019-09-18 19:21:02) >> Hi All, >> >> I am working on moving JSC EWS queues from old EWS to new EWS. I am trying to >> clearly understand various JSC EWS queues. I have few questio

[webkit-dev] Questions about JSC EWS queues

2019-09-18 Thread Aakash Jain
Hi All, I am working on moving JSC EWS queues from old EWS to new EWS. I am trying to clearly understand various JSC EWS queues. I have few questions: 1) What does 'jsc-only' port represent? From https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/config/ews.json#L45

[webkit-dev] Emojis for builder vs tester in EWS status-bubbles

2019-09-13 Thread Aakash Jain
Hi Everyone, We had this long-standing issue with the EWS bubbles that many engineers were confused whether a queue was build-only, test-only or build-and-test. For e.g.: https://webkit.org/b/152790 Simon Fraser 2016-01-06: "From the EWS bubbles you can't tell if a bot is a build-only bot, or

[webkit-dev] EWS Watchlist

2019-09-10 Thread Aakash Jain
Hi Everyone, For those who don't know we have a cool little feature named watchlist, which allows you to monitor any particular code in WebKit repository. You can specify the files/folders to monitor (in

Re: [webkit-dev] Recent EWS improvements

2019-09-04 Thread Aakash Jain
> On Sep 4, 2019, at 11:49 am, Adrian Perez de Castro wrote: > > Hello Aakash, WebKittens, > > On Thu, 29 Aug 2019 18:01:56 -0400, Aakash Jain wrote: > >> I want to update everyone with the further improvements I have made to new >> EWS. As always, please fee

Re: [webkit-dev] Recent EWS improvements

2019-08-29 Thread Aakash Jain
://webkit.org/b/201140 - [ews] Status bubble should display only important messages in pop-over https://webkit.org/b/201308 Only remaining queues on old EWS are windows, jsc and commit-queue, which I will be working on next. Thanks Aakash > On Jul 11, 2019, at 10:18 am, Aakash Jain wrote: >

Re: [webkit-dev] EWS bubbles not loading for some users

2019-08-22 Thread Aakash Jain
The issue has been resolved. Please let me know if anyone still notice any issue with EWS. Thanks Aakash > On Aug 22, 2019, at 12:57 pm, Aakash Jain wrote: > > Hi Everyone, > > There were some DNS changes done yesterday for webkit.org > <http://webkit.org/>. It

[webkit-dev] EWS bubbles not loading for some users

2019-08-22 Thread Aakash Jain
Hi Everyone, There were some DNS changes done yesterday for webkit.org . It seems to be causing EWS bubbles not to load for some users. For those users, https://ews.webkit.org is redirecting to bugs.webkit.org instead of

Re: [webkit-dev] Recent EWS improvements

2019-07-11 Thread Aakash Jain
ipped https://webkit.org/b/199079 <https://webkit.org/b/199079> - Do not print worker environment variables in each build step https://webkit.org/b/197319 <https://webkit.org/b/197319> - Do not run unix commands for windows in PrintConfiguration https://webkit.org/b/199605 <https://w

[webkit-dev] wincairo EWS bot down?

2019-06-24 Thread Aakash Jain
wincairo-ews-001 bot seems to be stuck/down for last 2 days (https://webkit-queues.webkit.org/queue-status/wincairo-ews ). There are ~43 patch pending currently. Can someone take a look? Thanks Aakash

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

2019-06-18 Thread Aakash Jain
> On Jun 16, 2019, at 2:14 PM, Darin Adler wrote: > >> On Jun 15, 2019, at 9:13 PM, Aakash Jain > <mailto:aakash_j...@apple.com>> wrote: >> >> 1) Do not upload archive (for layout-test-results) on bugzilla, instead >> upload it to another server, un

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

2019-06-18 Thread Aakash Jain
> On Jun 17, 2019, at 1:52 PM, Keith Rollin wrote: > >> On Jun 16, 2019, at 11:14, Darin Adler wrote: >> >> If we want to augment it, we should think of what we are aiming at. I do >> find it useful to see which tests are failing, and when I click on the red >> bubble I don’t see that

[webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

2019-06-15 Thread Aakash Jain
Hi Everyone, I am gathering feedback about EWS - specially about the comments which EWS makes on the Bugzilla bugs. Currently, the comments are not very user-friendly/polished/readable and are sometimes very noisy (e.g.: 72 comments and 36 attachments by EWS in

[webkit-dev] Recent EWS improvements

2019-05-22 Thread Aakash Jain
ge on 50+ patches (https://ews-build.webkit.org/api/v2/builders/3/builds?state_string__contains=new%20API%20Test=bug_id=-number <https://ews-build.webkit.org/api/v2/builders/3/builds?state_string__contains=new%20API%20Test=bug_id=-number>). Thanks Aakash > On Apr 4, 2019, at 10:00 P

Re: [webkit-dev] Introducing brand new EWS

2019-04-11 Thread Aakash Jain
; patches are in the queue? > > - R. Niwa > > On Thu, Apr 4, 2019 at 6:59 PM Aakash Jain <mailto:aakash_j...@apple.com>> wrote: > Introducing brand new EWS > > with EWS for API Tests (for macOS and iOS) > > and EWS for WebKitPerl Tests! > > > Star

[webkit-dev] Introducing brand new EWS

2019-04-04 Thread Aakash Jain
Introducing brand new EWS with EWS for API Tests (for macOS and iOS) and EWS for WebKitPerl Tests! Starting today, when you upload a patch to bugs.webkit.org , you will see few more bubbles (for API tests and webkitperl tests). You might also see additional button

Re: [webkit-dev] iOS EWS bots sick?

2018-11-20 Thread Aakash Jain
I am having a look. Seems like an ongoing intermittent issue. Tracked in https://bugs.webkit.org/show_bug.cgi?id=191864 Thanks Aakash > On Nov 19, 2018, at 10:39 PM, Ryosuke Niwa wrote: > > e.g. > >

[webkit-dev] WinCairo EWS bots down

2018-11-19 Thread Aakash Jain
Hi Don, Sony Folks, WinCairo bots seems to be down for last 2 days. Can someone please have a look? https://webkit-queues.webkit.org/queue-status/wincairo-ews Thanks Aakash ___ webkit-dev

Re: [webkit-dev] Buildbot upgrade on build.webkit.org

2018-01-08 Thread Aakash Jain
" -Aakash > On Dec 13, 2017, at 6:51 PM, Aakash Jain <aakash_j...@apple.com> wrote: > > > >> On Dec 11, 2017, at 1:10 AM, Konstantin Tokarev <annu...@yandex.ru >> <mailto:annu...@yandex.ru>> wrote: >> >> >> >>

Re: [webkit-dev] Buildbot upgrade on build.webkit.org

2017-12-13 Thread Aakash Jain
> On Dec 11, 2017, at 1:10 AM, Konstantin Tokarev <annu...@yandex.ru> wrote: > > > > 11.12.2017, 02:49, "Carlos Alberto Lopez Perez" <clo...@igalia.com>: >> On 07/12/17 21:47, Aakash Jain wrote: >>> For people using build.webkit.org <ht

[webkit-dev] Buildbot upgrade on build.webkit.org

2017-12-07 Thread Aakash Jain
Hello WebKittens, We have been using an ancient (5 years old) version of Buildbot on build.webkit.org . I am starting to work on upgrading to latest Buildbot (0.9.x). New buildbot would look like this: https://nine.buildbot.net . For

[webkit-dev] EWS improvements and new EWSes

2017-11-09 Thread Aakash Jain
Hi All, We have added webkitpy EWS this week. This should help in making sure that we don't accidentally break webkitpy tests. This EWS will run only if your patch has webkitpy related changes. Please avoid landing the patch if webkitpy EWS fails for your patch. Don Olmstead added WinCairo

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-11-03 Thread Aakash Jain
> On Nov 3, 2017, at 9:20 AM, Maciej Stachowiak <m...@apple.com> wrote: > > > >> On Nov 3, 2017, at 8:59 AM, Aakash Jain <aakash_j...@apple.com >> <mailto:aakash_j...@apple.com>> wrote: >> >> >> >>> On Nov 2, 2017, at 8

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-11-03 Thread Aakash Jain
> On Nov 2, 2017, at 8:45 PM, Maciej Stachowiak <m...@apple.com> wrote: > > > >> On Nov 2, 2017, at 5:41 PM, Aakash Jain <aakash_j...@apple.com >> <mailto:aakash_j...@apple.com>> wrote: >> >> >> >>> On Oct 26

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-11-02 Thread Aakash Jain
>>> >>>> >>>>> 25 окт. 2017 г., в 18:21, Michael Catanzaro <mcatanz...@igalia.com >>>>> <mailto:mcatanz...@igalia.com>> написал(а): >>>>> >>>>> On Wed, Oct 25, 2017 at 4:58 PM, Aakash Jain <aakas

[webkit-dev] Dead code in webkitpy runtests.py

2017-11-01 Thread Aakash Jain
Hi Everyone, Inside webkitpy, in tool/steps/runtests.py there is code to run various kind of tests (JSC, bindings, webkitpy, webkitperl, layout-tests) which seems like dead code. This code is not used by EWS (since ews pass --non-interactive argument to webkit-patch). I believe the original

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-25 Thread Aakash Jain
case, I always prefer the PEP8 rules, because check-webkit-style will > complain if you don't do so. > > Brian > >> 2017/10/25 午後0:13、Aakash Jain <aakash_j...@apple.com >> <mailto:aakash_j...@apple.com>>のメール: >> >> Hi All, >> &

[webkit-dev] Formatting style for inline comments in Python code

2017-10-25 Thread Aakash Jain
Hi All, There is one case in which Webkit style guidelines and Python style guidelines do not match. This is about spacing before inline comments. WebKit style guidelines (https://webkit.org/code-style-guidelines/#comments-eol ) says:

Re: [webkit-dev] EWS bots don't like patches with too many test failures

2017-10-17 Thread Aakash Jain
Hi All, This issue is now resolved after the fix in https://trac.webkit.org/changeset/223572/webkit Please let us know if anyone notices any issue with EWS bots. Thanks Aakash > On Oct 16, 2017, at 10:03 PM, Aakash Jain <aakash_j...@apple.com> wrote: > > Hi All, > >

[webkit-dev] EWS bots don't like patches with too many test failures

2017-10-16 Thread Aakash Jain
Hi All, We recently noticed that bots on some of the EWS queues get stuck while running layout-tests on some particular patches. This results in EWS queues not able to process new patches until the bots are manually fixed. This happens with patches which have many layout-test failures (30+).

Re: [webkit-dev] EWS queues seem stuck

2017-10-08 Thread Aakash Jain
Many bots were stuck processing https://bug-178007-attachments.webkit.org/attachment.cgi?id=323010 (during build-and-test) and mac-debug queue bots was stuck on

  1   2   >