Re: [webkit-dev] sick of forgetting bugzilla email addresses?

2010-06-10 Thread William Siegrist
Dave Kilzer has updating bugzilla on his todo list, but he's been busy. I can talk to him about what bugzilla can do for this. If we limit the data to only people who have been cc'd, then I don't believe we're leaking any additional information. Opening up CORS for trac/svn is doable, but its

Re: [webkit-dev] Mouse wheel event precision

2010-06-10 Thread Peter Kasting
On Thu, Jun 10, 2010 at 12:26 PM, David Hyatt wrote: > Having investigated the original bug and its fix that caused this > regression, Safari 4's behavior was correct. The new behavior is broken. > A tiny continuous event in Safari 4 correctly reported values that are > smaller than one line d

[webkit-dev] Windows Builders Wedged on WebKitAuxiliaryLibrary

2010-06-10 Thread Eric Seidel
Checking Last-Modified date of WebKitAuxiliaryLibrary.zip... Downloading WebKitAuxiliaryLibrary.zip... Couldn't check Last-Modified date of new WebKitAuxiliaryLibrary.zip. % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload

Re: [webkit-dev] sick of forgetting bugzilla email addresses?

2010-06-10 Thread Eric Seidel
Apologies, it appears I was misinformed. On Thu, Jun 10, 2010 at 4:44 PM, Alexey Proskuryakov wrote: > > 10.06.2010, в 16:18, Eric Seidel написал(а): > >> A real data feed from bugs.webkit.org of the user names would be best. > > There may be some expectation of privacy from users who never file

Re: [webkit-dev] sick of forgetting bugzilla email addresses?

2010-06-10 Thread Ojan Vafai
On Thu, Jun 10, 2010 at 4:04 PM, Ojan Vafai wrote: > Also, I tried porting the Chrome extension to a Safari extension. After > much wrangling, I couldn't get any content scripts to load though. The other > bits of the extension (e.g. the global page) loaded fine though, so it's not > just like I

Re: [webkit-dev] sick of forgetting bugzilla email addresses?

2010-06-10 Thread Alexey Proskuryakov
10.06.2010, в 16:18, Eric Seidel написал(а): A real data feed from bugs.webkit.org of the user names would be best. There may be some expectation of privacy from users who never file bugs or add comments. I don't think there is a way for non-admin users to get a user list from Bugzilla.

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-10 Thread David Hyatt
Yes, I got schooled on this days ago, but welcome to the party! ;) dave On Jun 10, 2010, at 6:00 PM, Maciej Stachowiak wrote: > > On Jun 2, 2010, at 1:22 PM, David Hyatt wrote: > >> >> I really don't think hit testing needs to be modified to get what you want. >> You can do a scattershot sa

Re: [webkit-dev] LayoutTest with a fragment reported as the document URL?

2010-06-10 Thread David Kilzer
I think you want: window.location.hash = 'name1'; I'm sure there are other layout tests that set the hash property, so you might search for them to get some ideas about how to build your test. Dave -- Sent from my iPhone 3GS On Jun 7, 2010, at 2:04 PM, Chris Fleizach wrote: > > I'd like the

Re: [webkit-dev] Mouse wheel event precision

2010-06-10 Thread David Hyatt
I think for now I'm just going to implement the "minimum line movement of 1" and only do it at the DOM event level. That way if we use the wheel event internally (e.g., for a non-native scrollview implementation) it will still do the right thing. dave On Jun 10, 2010, at 3:01 PM, Peter Kastin

Re: [webkit-dev] Why does Frame.h use mutable members instead of OwnPtr?

2010-06-10 Thread Eric Seidel
Example. Use of a mutable member for AnimationController: https://trac.webkit.org/browser/trunk/WebCore/page/Frame.h#L346 Causes us to pull in AnimationController.h: https://trac.webkit.org/browser/trunk/WebCore/page/Frame.h#L31 Which pulls in additional headers of its own. Frame.h is included

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-10 Thread Antonio Gomes (:tonikitoo)
Hi, as a follow up on this and based on a quick chat with hyatt on irc, the minimalistic approach seems to be the way to go. dhyatt, david, could you join the discussion about rect based hit test on bug 40197 just need me to make a decision on the right naming? dhyatt, not that simple. Basicall

Re: [webkit-dev] sick of forgetting bugzilla email addresses?

2010-06-10 Thread Eric Seidel
A real data feed from bugs.webkit.org of the user names would be best. :) If we had one for svn.webkit.org then we wouldn't need commiters.py at all. Commiters.py is a hack around lack of available data from our servers. Also, we keep hacking bugzilla, and yet our bugzilla is still years-out-of

Re: [webkit-dev] Mouse wheel event precision

2010-06-10 Thread Peter Kasting
On Thu, Jun 10, 2010 at 12:26 PM, David Hyatt wrote: > There are Web sites that depend on never scrolling less than 1 wheel delta > line though. So what can we do to get the best of both worlds? > Can we keep a count of the "total delta not yet sent to the page", and each time it overflows one

Re: [webkit-dev] Mouse wheel event precision

2010-06-10 Thread David Hyatt
I filed https://bugs.webkit.org/show_bug.cgi?id=40441 to track this issue. dave (hy...@apple.com) On Jun 10, 2010, at 2:26 PM, David Hyatt wrote: > On Jun 10, 2010, at 1:01 PM, Nathan Vander Wilt wrote: > >> On Jun 9, 2010, at 3:51 PM, David Hyatt wrote: >>> On Jun 9, 2010, at 2:25 AM, Andy

Re: [webkit-dev] sick of forgetting bugzilla email addresses?

2010-06-10 Thread Ojan Vafai
> > On Thu, Jun 10, 2010 at 3:55 PM, Maciej Stachowiak wrote: > On Jun 7, 2010, at 2:30 PM, Julie Parent wrote: > >> Thank you thank you thank you! >> >> >> I'm happy using this as a Chrome extension, but if there is enough >> interest to have it added to Bugzilla directly, I can do it (I already

Re: [webkit-dev] sick of forgetting bugzilla email addresses?

2010-06-10 Thread Ojan Vafai
Actually, all we want is access to http://svn.webkit.org/repository/webkit/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. That's the source of username/email/irc data. The bugzilla data wouldn't be bad, but it does limit what the autocomplete can do. For example, right now it will

Re: [webkit-dev] Mouse wheel event precision

2010-06-10 Thread David Hyatt
On Jun 10, 2010, at 1:01 PM, Nathan Vander Wilt wrote: > On Jun 9, 2010, at 3:51 PM, David Hyatt wrote: >> On Jun 9, 2010, at 2:25 AM, Andy Estes wrote: >> >>> >>> On Jun 8, 2010, at 8:34 PM, Nathan Vander Wilt wrote: >>> What Safari 4 seemed to do was simply provide much greater precision

Re: [webkit-dev] sick of forgetting bugzilla email addresses?

2010-06-10 Thread William Siegrist
Don't you really want bugzilla usernames instead of trac/svn usernames though? Wouldn't it be better to ask bugzilla for the data? -Bill On Jun 7, 2010, at 2:40 PM, Adam Barth wrote: > Can we set up CORS headers (e.g., Access-Control-Allow-Origin: *) on > trac.webkit.org or http://svn.webkit.o

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-10 Thread Maciej Stachowiak
On Jun 2, 2010, at 1:22 PM, David Hyatt wrote: > > I really don't think hit testing needs to be modified to get what you want. > You can do a scattershot sampling using multiple candidate points within the > rect and apply whatever heuristics you want to choose a node. I'm also not > convin

Re: [webkit-dev] Why does Frame.h use mutable members instead of OwnPtr?

2010-06-10 Thread Maciej Stachowiak
On Jun 10, 2010, at 12:04 AM, Eric Seidel wrote: > This causes a huge header dependency cascade, bloating object files > and slowing down builds. I can't imagine avoiding the pointer > indirection is actually a measurable runtime savings (at least in most > cases). Can you give a specific examp

Re: [webkit-dev] sick of forgetting bugzilla email addresses?

2010-06-10 Thread Maciej Stachowiak
On Jun 7, 2010, at 2:30 PM, Julie Parent wrote: > Thank you thank you thank you! > > I'm happy using this as a Chrome extension, but if there is enough interest > to have it added to Bugzilla directly, I can do it (I already have a local > bugzilla running for the Rietveld work). I think this

Re: [webkit-dev] free functions

2010-06-10 Thread Maciej Stachowiak
On Jun 3, 2010, at 1:36 AM, Chris Jerdonek wrote: > On Tue, May 25, 2010 at 10:01 AM, Darin Adler wrote: >> On May 25, 2010, at 7:54 AM, Chris Jerdonek wrote: >> >>> I sometimes come across public member functions whose implementations do >>> not depend on private data. >>> >>> There is a sch

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-10 Thread Maciej Stachowiak
On Jun 4, 2010, at 1:32 PM, Darin Fisher wrote: > On Fri, Jun 4, 2010 at 11:15 AM, Peter Kasting wrote: > On Fri, Jun 4, 2010 at 11:11 AM, Darin Adler wrote: > If the two enum types are identical except for their names, then this doesn’t > firewall the types at all. > > It doesn't firewall th

Re: [webkit-dev] feedback{?,+,-} flag in bugzilla

2010-06-10 Thread Peter Kasting
On Thu, Jun 10, 2010 at 11:20 AM, Adam Barth wrote: > On Thu, Jun 10, 2010 at 10:46 AM, Peter Kasting > wrote: > > I'd quite like a flag that means "this isn't ready for review, but the > test > > bots should try it out and see if there are bugs in it". I don't know if > we > > already have a f

Re: [webkit-dev] feedback{?,+,-} flag in bugzilla

2010-06-10 Thread Adam Barth
On Thu, Jun 10, 2010 at 10:46 AM, Peter Kasting wrote: > On Thu, Jun 10, 2010 at 8:34 AM, Antonio Gomes (:tonikitoo) > wrote: >> >> Ideally, patches in feedback? status should also be easier to >> review/validate, and the author would be sure it is taking the right >> path. EWS bots would not nec

Re: [webkit-dev] Mouse wheel event precision

2010-06-10 Thread Nathan Vander Wilt
On Jun 9, 2010, at 3:51 PM, David Hyatt wrote: > On Jun 9, 2010, at 2:25 AM, Andy Estes wrote: > >> >> On Jun 8, 2010, at 8:34 PM, Nathan Vander Wilt wrote: >> >>> What Safari 4 seemed to do was simply provide much greater precision, where >>> scrolling half a line simply yielded about 20 units

Re: [webkit-dev] feedback{?,+,-} flag in bugzilla

2010-06-10 Thread Peter Kasting
On Thu, Jun 10, 2010 at 8:34 AM, Antonio Gomes (:tonikitoo) < toniki...@gmail.com> wrote: > Ideally, patches in feedback? status should also be easier to > review/validate, and the author would be sure it is taking the right > path. EWS bots would not necessarily have to build it or even do style

[webkit-dev] feedback{?,+,-} flag in bugzilla

2010-06-10 Thread Antonio Gomes (:tonikitoo)
Hi, Mozilla's bugzilla had added a imo very useful flag to their bugzilla: feedback{?,+,-}. As the name implies, it is generally used when a patch is not yet ready for a final review, but idea is shaped enough that worth a validation before moving on. It might be specially useful when an idea is

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-10 Thread Antonio Gomes (:tonikitoo)
Hi, As Grace pointed out in the spun-off thread, bug 40197 was filed and a patch was put up for feedback there. I looked over the patch, and since it took a different path from what I had in mind to fix the problem, I also took a couple of days and implemented mine prototype. I explained details

[webkit-dev] Why does Frame.h use mutable members instead of OwnPtr?

2010-06-10 Thread Eric Seidel
This causes a huge header dependency cascade, bloating object files and slowing down builds. I can't imagine avoiding the pointer indirection is actually a measurable runtime savings (at least in most cases). -eric ___ webkit-dev mailing list webkit-dev