Re: [webkit-dev] How to enable WebGL on WebKit QT port?

2011-05-03 Thread Benjamin Poulain
On Tue, May 3, 2011 at 1:22 AM, Won J Jeon wjj...@gmail.com wrote: Thanks for the update. BTW, is there any switch that I need to turn on in order to enable WebGL support with QT port? I built the code by using '--3d-canvas --3d-rendering' switches and launched QtTestBrowser by using

Re: [webkit-dev] JSC bindings in the Qt bridge

2011-05-15 Thread Benjamin Poulain
On Sat, May 14, 2011 at 9:55 PM, Oliver Hunt oli...@apple.com wrote: Given there seems to be little focus on these bindings from Nokia it seems that the best path forward is to have them rewritten in terms of the JSC API rather than the JSC internals. This will insulate the bindings from

Re: [webkit-dev] Fixing the Platform fields in Bugzilla

2011-07-05 Thread Benjamin Poulain
On Tue, Jul 5, 2011 at 6:41 PM, Simon Fraser simon.fra...@apple.com wrote: These don't represent the suite of hardware and OSes that WebKit is used on these days, nor do they represent the various ports. For example, there's no way to indicate that a bug is in the QT port. Can we clean this

Re: [webkit-dev] Subpixel Layout Update

2011-10-28 Thread Benjamin Poulain
On Fri, Oct 28, 2011 at 1:43 PM, Levi Weintraub le...@chromium.org wrote: As you may know, Emil and I have been diligently working on getting subpixel layout up and running in WebKit. After much testing, we settled on a fixed point implementation instead of floats; we're happy to discuss how

Re: [webkit-dev] Cleaning up directories in WebCore

2011-11-18 Thread Benjamin Poulain
On Fri, Nov 18, 2011 at 11:21 AM, Adam Barth aba...@webkit.org wrote: Features/  notifications/ (8 files)  storage/ (195 files)  fileapi/ (115 files)  webaudio/ (103 files)  mediastream/ (28 files; under active development)  workers/ (43 files)  websockets/ (20 files)  inspector/ (426

Re: [webkit-dev] Should WebKit require SQLite?

2011-12-03 Thread Benjamin Poulain
On Sat, Dec 3, 2011 at 10:47 AM, Ryosuke Niwa rn...@webkit.org wrote: It seems undesirable to increase the number of dependencies since being able to port easily is one of the strengths of WebKit. On the other hand, reducing the number of flags will certainly reduce the build system complexity

Re: [webkit-dev] Removing support for the RVCT compiler

2011-12-10 Thread Benjamin Poulain
On Sat, Dec 10, 2011 at 6:55 PM, Andreas Kling kl...@webkit.org wrote: Are there any objections to removing support for the RVCT compiler (ARM RealView) in WebKit? As far as I know, the only user has been the Symbian port which is no longer present on WebKit trunk. It looks like there are two

Re: [webkit-dev] Removing support for the RVCT compiler

2011-12-10 Thread Benjamin Poulain
On Sat, Dec 10, 2011 at 8:47 PM, Eric Seidel e...@webkit.org wrote: I'm curious what the practical implications of this are?  Are there 500 #ifdefs for RVCT or 5? I think a dozen of #ifdef, plus a dozen of workarounds for compiler bugs. Benjamin ___

Re: [webkit-dev] URL validating process in WebKit

2011-12-13 Thread Benjamin Poulain
On Tue, Dec 13, 2011 at 12:00 PM, Ghita alaoui_gh...@hotmail.com wrote: I need to know how webkit validates a URL address entered by a user in the web browser, I tried to follow step by step the compiler, but since I'm new, I'm completely lost in the webkit source code, so I would like to make

Re: [webkit-dev] js-test-(pre|post).js in http tests

2011-12-19 Thread Benjamin Poulain
2011/12/19 Alexey Proskuryakov a...@webkit.org: Generally speaking, I think that it's not worth it making existing tests pretty for the sake of prettiness or even consistency. It is very easy to lose some intended non-obvious properties of tests that way, as well as to lose unintended testing.

Re: [webkit-dev] Selection model is broken

2012-01-05 Thread Benjamin Poulain
On Thu, Jan 5, 2012 at 3:31 PM, Ojan Vafai o...@chromium.org wrote: Is this too crazy? Are there other solutions? I also do not like the selection model but I am unsure about your suggestion. If we use the visual model for selection, finding the order of the content would get tricky (because

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-01-08 Thread Benjamin Poulain
On Sun, Jan 8, 2012 at 6:15 PM, Dan Bernstein m...@apple.com wrote: Please set the svn:mime-type property on binary files that you add to the tree, such as *-expected.png, before committing. Otherwise the resulting webkit-changes message will include those files as text, which is inconvenient.

[webkit-dev] Changing the implementation of KURL

2012-01-26 Thread Benjamin Poulain
Hello, I would like to give another shot at the URL implementation Adam started some times ago. There are a few problems with the current KURL: -there are two implementations: WebKit and Google URL -some stuff are just plain incorrect :) -the WebKit implementation has some bugs which makes it

Re: [webkit-dev] Changing the implementation of KURL

2012-01-27 Thread Benjamin Poulain
On Thu, Jan 26, 2012 at 11:17 PM, Darin Fisher da...@chromium.org wrote: Instead of doing all of this work, have you considered just treating GoogleURL in much the same way as WebKit treats ANGLE?  You could perhaps just commit a copy of GoogleURL into Source/ThirdParty, and then WebKit as a

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Benjamin Poulain
On Sat, Jan 28, 2012 at 4:59 PM, Brett Wilson bre...@chromium.org wrote: So to clarify, I think we need to keep the current architecture. Obviously WebKit needs a URL class that uses its String class, so WTFURL would probably be a wrapper around some core library for WebKit to use. Chromium

Re: [webkit-dev] Changing the implementation of KURL

2012-01-28 Thread Benjamin Poulain
On Sat, Jan 28, 2012 at 8:01 PM, Darin Fisher da...@chromium.org wrote: If CFNetwork exposed an API to its URL parser, then it would be super wise for any port of WebKit using CFNetwork to reuse the same URL parser. That is an interesting idea. I always considered it would be beneficial to

Re: [webkit-dev] Propose adding button support to text based notifications (Was: Removing HTML notifications from WebKit)

2012-02-14 Thread Benjamin Poulain
On Tue, Feb 14, 2012 at 5:59 PM, Jian Li jia...@chromium.org wrote: One of the reasons for using html notifications is to allow direct interaction with the notifications. Here're some scenarios from our customers that want to use html notifications purely for this purpose: Does any platform

Re: [webkit-dev] small change to RenderThemeWin::determineState

2012-02-22 Thread Benjamin Poulain
On Wed, Feb 22, 2012 at 3:20 PM, Lynn Neir lynn.n...@skype.net wrote: Hello… I have a small addition to RenderThemeWin::determineState so it will handle indeterminate (mixed) state for checkbox.  I am not sure who owns this code. Nobody owns that code. Submitting patches to WebKit is really

[webkit-dev] Is anyone really using IPP

2012-03-05 Thread Benjamin Poulain
Hello, I have seen a few patches from Intel to add support of Intel IPP for some algorithm. A quick search make me think nobody enable this code. Is anyone really using IPP? My concern is if nobody uses/tests it, we might be adding dead code to WebKit. Benjamin

Re: [webkit-dev] CSS3 Paged Media module

2012-03-06 Thread Benjamin Poulain
On Wed, Feb 8, 2012 at 4:50 AM, Milian Wolff milian.wo...@kdab.com wrote: I wonder, has anyone begun working on this? If not, I am willing to give it a shot. I realize that this is a big task, and it will probably be hard for a newcomer like me to do properly. Hence take this email also as a

[webkit-dev] The Gtk EWS bot is sick: no space left on device

2012-03-09 Thread Benjamin Poulain
Hello, The Gtk EWS bot keep failing with: Last 500 characters of output: patch: write error : No space left on device patch: write error : No space left on device patch: write error : No space left on device Can anyone have a look at the poor machine? Benjamin

Re: [webkit-dev] Segmentation fault: stackbase

2012-03-17 Thread Benjamin Poulain
On Sat, Mar 17, 2012 at 2:04 AM, Yongbing Huang huangyongb...@ict.ac.cn wrote: I met the following problem when running the jsc in QtWebkit. Are there any suggestions? You should get the full backtrace create a reduction, and open a bug report on bugs.webkit.org. Benjamin

[webkit-dev] Is anyone not using PREEMPT_GEOLOCATION_PERMISSION?

2012-03-29 Thread Benjamin Poulain
Hello, The flag PREEMPT_GEOLOCATION_PERMISSION was added in http://trac.webkit.org/changeset/63742 around some code of Geolocation. I could not find any case where PREEMPT_GEOLOCATION_PERMISSION is not used. Unless someone does not use this flag, I plan to remove the flag and the related useless

Re: [webkit-dev] Following up on removing -khtml- and -apple- CSS vendor prefixes

2012-04-05 Thread Benjamin Poulain
On Thu, Apr 5, 2012 at 1:08 AM, Adam Barth aba...@webkit.org wrote: In July 2010, there was a thread on webkit-dev about removing support for the -khtml- and -apple- vendor prefixes: As a first step toward deprecation, it would be nice if browsers could issue a warning in the console when such

Re: [webkit-dev] Is anyone not using PREEMPT_GEOLOCATION_PERMISSION?

2012-04-05 Thread Benjamin Poulain
On Thu, Mar 29, 2012 at 3:00 PM, Benjamin Poulain benja...@webkit.org wrote: I could not find any case where PREEMPT_GEOLOCATION_PERMISSION is not used. Unless someone does not use this flag, I plan to remove the flag and the related useless code. I did not get any answer for a week. Here

Re: [webkit-dev] Eliminate potential null pointer dereference?

2012-04-20 Thread Benjamin Poulain
On Fri, Apr 20, 2012 at 10:53 AM, Luke Macpherson macpher...@chromium.org wrote: What do we hope to achieve by adding a test when fixing a bug? To prevent a bug from being reintroduced into the codebase at a later date. This is a reasonable goal, so let’s remember that the goal is to prevent

Re: [webkit-dev] Eliminate potential null pointer dereference?

2012-04-20 Thread Benjamin Poulain
On Fri, Apr 20, 2012 at 1:48 PM, Rachel Blum gr...@chromium.org wrote: Unless there's a demonstrable reason that you _need_ a value uninitialized, why is the burden of proof on the person doing cleanup? Yes, at the point the code was written, it's well possible that the author was aware that

Re: [webkit-dev] Deprecating features guideline wiki

2012-04-27 Thread Benjamin Poulain
On Fri, Apr 27, 2012 at 2:18 PM, Dirk Pranke dpra...@chromium.org wrote: That said, what sort of officialness does this writeup/guideline/policy have? Do all the ports agree that this is what our stance should be? Everyone seemed to agree we just need to discuss each deprecation on webkit-dev

Re: [webkit-dev] Deprecating features guideline wiki

2012-04-27 Thread Benjamin Poulain
On Fri, Apr 27, 2012 at 5:10 PM, Eric Seidel e...@webkit.org wrote: Is the concern that we've been deprecating too many things too quickly? Quite the contrary. People were concerned about the way to deprecate more stuff and making fewer mistakes when adding and removing features :)

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-16 Thread Benjamin Poulain
On Wed, May 16, 2012 at 9:08 PM, Ryosuke Niwa rn...@webkit.org wrote: e.g. 12345 WIN MAC TEXT IMAGE test.html instead of BUGWK12345 WIN MAC : test.html = TEXT IMAGE I wonder how this is gonna help making test_expectation.txt less obscure. If anything, I would make the file more verbose. I also

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-16 Thread Benjamin Poulain
On Wed, May 16, 2012 at 9:34 PM, Ryosuke Niwa rn...@webkit.org wrote: Any concrete proposals? I would go for something verbose in a easy to understand format. E.g. { test: 'fast/html/keygen.html', platform: 'mac, linux', bug: 'webkit.org/b/6', expectedResults: ['crash', 'text',

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

2012-05-17 Thread Benjamin Poulain
On Wed, May 16, 2012 at 11:04 PM, Ryosuke Niwa rn...@webkit.org wrote: { test: 'fast/html/keygen.html',  platform: 'mac, linux',  bug: 'webkit.org/b/6',  expectedResults: ['crash', 'text', 'image'],  action: 'skip' } As far as I know, a lot of people edit this file on a text editor so

Re: [webkit-dev] malloc(0)

2012-06-13 Thread Benjamin Poulain
On Wed, Jun 13, 2012 at 12:48 PM, Myles C. Maxfield myles.maxfi...@gmail.com wrote: I don't think that a good solution is to change the interface of ICU and try to upstream a patch to ICU - I think a better solution would be to work around this requirement of ICU inside WebKit. What is exactly

Re: [webkit-dev] malloc(0)

2012-06-13 Thread Benjamin Poulain
On Wed, Jun 13, 2012 at 3:27 PM, Darin Adler da...@apple.com wrote: There is still the question of if I can upstream this to ICU, which I'm checking on. I was not proposing changing ICU. I did. In addition to changing WebKit, not using the pointer when the length is zero does not

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Benjamin Poulain
On Wed, Jun 13, 2012 at 4:32 PM, Dirk Pranke dpra...@chromium.org wrote: So something like webkit.org/12345 [Win Mac Debug] animations/stop-animation-on-suspend.html [Crash Text Pass] ? I like that! This seems quite readable to me as well. As mentioned above, I'd be inclined to make the

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-06 Thread Benjamin Poulain
On Fri, Jul 6, 2012 at 3:49 PM, Ryosuke Niwa rn...@webkit.org wrote: It DOES. Even today, I find many comments (even FIXMEs) that are out-of-date. Say you add a some comment to a function A because of some odd behavior of another function B, which A calls. Someone awesome later gets rid of the

Re: [webkit-dev] connect xmlrpc with Javascript

2012-07-08 Thread Benjamin Poulain
On Sun, Jul 8, 2012 at 12:00 PM, Federico Manuel Echeverri Choux echeverr...@gmail.com wrote: Hi, guys, i develop some application with webkit on gtk client. but i need to connect with openerp-server. This is the wrong mailing list. Try webkit-gtk or webkit-help. The list webkit-dev is about

Re: [webkit-dev] C++ unit tests for WebKit?

2012-07-11 Thread Benjamin Poulain
On Wed, Jul 11, 2012 at 2:23 PM, Hans Muller hmul...@adobe.com wrote: Have the merits of C++ unit tests been debated before? I noticed that a bug representing as much has been around since 2008 (https://bugs.webkit.org/show_bug.cgi?id=21010). The last comment (2009) concludes with: I'd be

Re: [webkit-dev] Html5 local storage location in Webkit

2012-07-16 Thread Benjamin Poulain
On Mon, Jul 16, 2012 at 5:30 PM, Navanshu Mahor mahor1...@gmail.com wrote: Which Folder In Local Hard Disk Stores Html5 Local Storage Data in webkit This Is The Wrong Mailing List, Try webkit-help. The mailing list webkit-dev is for discussions about the development of WebKit. Try the port

Re: [webkit-dev] assumption about point packing in multit-touch tests

2012-07-18 Thread Benjamin Poulain
On Wed, Jul 18, 2012 at 8:59 AM, Tomeu Vizoso to...@tomeuvizoso.net wrote: Though the W3C spec allows packing more than one touch point update in a single touch event, it says nothing about how these updates should be packed, so I think that the current tests are too restrictive and should be

Re: [webkit-dev] assumption about point packing in multit-touch tests

2012-07-19 Thread Benjamin Poulain
It looks like this spec needs an update, not the WebKit tests. I don't think the spec should be changed so that XInput based platforms cannot satisfy the spec requirements. But I agree that the tests are good the way they are because they enforce the requirement to at least possibly support

Re: [webkit-dev] New runtime setting: css3TextDecoration

2012-08-14 Thread Benjamin Poulain
On Tue, Aug 14, 2012 at 3:10 PM, Julien Chaffraix julien.chaffr...@gmail.com wrote: The most significant performance impact is probably the increase in the binary size which I won't deny and don't have insights into. This is only a part of the performance problem but it is actually fairly bad.

Re: [webkit-dev] Proposal to remove list-item special counter

2012-08-15 Thread Benjamin Poulain
Can I remove this feature? See http://trac.webkit.org/wiki/DeprecatingFeatures It would be nice to first have some usage data. Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Initializing String and AtomicString with literals

2012-08-24 Thread Benjamin Poulain
Dear webkit-dev, Some recent changes improved the way we can use string classes with literals. There are 3 new constructors for initializing a string from a literal: -String(ASCIILIteral): http://trac.webkit.org/browser/trunk/Source/WTF/wtf/text/WTFString.h#L139 -String(const char[],

Re: [webkit-dev] Initializing String and AtomicString with literals

2012-08-25 Thread Benjamin Poulain
On Fri, Aug 24, 2012 at 10:18 PM, Adam Barth aba...@webkit.org wrote: [[[ The difference between the version is if the length of the string is included or not. Having the size given in the constructor makes the constructor faster. Having the size also makes the code bigger, which is a

Re: [webkit-dev] Initializing String and AtomicString with literals

2012-08-25 Thread Benjamin Poulain
On Fri, Aug 24, 2012 at 10:05 PM, Adam Barth aba...@webkit.org wrote: Thanks! The wiki page is very helpful. I wonder if we should organize a hack-a-thon to deploy this pattern throughout WebKit. Is there a way the compiler could give us a list of all the code location we should update?

[webkit-dev] PSA: JSC::UString will retire, String is excited to meet you

2012-08-29 Thread Benjamin Poulain
Hi WebKit-dev, Some unifying has been done between String and UString, and it will soon be time to remove UString entirely. The benefits of removing UStrings are: -Simpler code. -No need to implement each feature in String and UString -Fewer ref-deref -Smaller binary (about 44kb smaller on Mac

Re: [webkit-dev] String::operator+= considered harmful

2012-09-04 Thread Benjamin Poulain
On Tue, Sep 4, 2012 at 4:22 PM, Adam Barth aba...@webkit.org wrote: Removing operator+= will likely require changes to a number of port-specific files. I'll do my best to remove these, but I might need some help from maintainers of individual ports. If you're interested in helping out,

Re: [webkit-dev] New Feature: CSS Element

2012-09-10 Thread Benjamin Poulain
On Mon, Sep 10, 2012 at 6:41 PM, Anish Bhayani bhay...@adobe.com wrote: I am an intern on the Adobe Web Platform Authoring team. For the summer, I was working on implementing CSS Element [1] in WebKit. The specification itself is still being finalized, but Mozilla [2] has had this feature

Re: [webkit-dev] WebKit image rendering performance

2012-09-11 Thread Benjamin Poulain
On Tue, Sep 11, 2012 at 1:45 AM, Klemen Slavič krof.drak...@gmail.comwrote: First time poster. While I admit I haven't worked on WebKit code (yet), I'm very familiar with its workings across different implementations (desktop, mobile and otherwise). In my research regarding WebKit rendering

Re: [webkit-dev] Pre-proposal: Adding a Coverity instance for WebKIt

2012-09-17 Thread Benjamin Poulain
On Mon, Sep 17, 2012 at 4:11 PM, James Hawkins jhawk...@chromium.orgwrote: A few details: * Google will front the cost of the license (non-zero...very far from zero) and the infrastructure. * I'd leave it up to the WebKit leadership to decide who has access (most likely limited to WebKit

Re: [webkit-dev] Transformations precision: double - float

2012-10-15 Thread Benjamin Poulain
On Mon, Oct 15, 2012 at 9:35 AM, Gabor Rapcsanyi rga...@inf.u-szeged.huwrote: On 10/12/2012 11:23 AM, Tom Hudson wrote: Do you have particular bottleneck functions that you have reason to believe would benefit from ARM SIMD optimizations? Under what workloads, and how much benefit? We've

Re: [webkit-dev] Porting WebKit To a new graphic backend.

2012-11-13 Thread Benjamin Poulain
On Tue, Nov 13, 2012 at 9:03 AM, ZhangJiPeng oneco...@gmail.com wrote: I want to porting webkit to a new graphics library, because I need to rendeting webpage to any platform. The graphic library named Picasso( http://picasso-graphic.googlecode.com/files/picasso12_source.tar.gz). Only a

Re: [webkit-dev] Adding Screen orientation API

2012-11-22 Thread Benjamin Poulain
On Thu, Nov 22, 2012 at 1:34 AM, ryuan Choi ryuan.c...@gmail.com wrote: I would like to let you know, I am planning to add Screen Orientation API to WebCore. This feature will be behind the ENABLE_SCREEN_ORIENTATION. Please see : http://www.w3.org/TR/screen-orientation/

Re: [webkit-dev] pointer events specification - first editors draft

2012-11-22 Thread Benjamin Poulain
On Wed, Nov 21, 2012 at 2:42 PM, Rick Byers rby...@chromium.org wrote: Outside of the design details, are there any thoughts or concerns about WebKit getting an implementation of pointer events at some point? In my opinion, the pointer events spec is a bad idea (at least, in its current

Re: [webkit-dev] pointer events specification - first editors draft

2012-11-28 Thread Benjamin Poulain
On Wed, Nov 28, 2012 at 8:23 AM, Adam Barth aba...@webkit.org wrote: I'm sympathetic to these concerns, but, unfortunately, I don't see any other path that leads to interoperability with Internet Explorer. Currently, there is little to no content that supports pointer events. There is also

Re: [webkit-dev] pointer events specification - first editors draft

2012-11-29 Thread Benjamin Poulain
On Thu, Nov 29, 2012 at 10:27 AM, Adam Barth aba...@webkit.org wrote: I would prefer WebKit to be wise and wait for either good use cases, or a better spec. In my view, the wise course of action is for all user agents to implement an interoperable set of input events so that authors don't

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Benjamin Poulain
On Mon, Dec 3, 2012 at 11:11 AM, Dirk Schulze dschu...@adobe.com wrote: Why does this feature have a flag at all? background-position with up to 4 arguments is specified with CSS3 background and borders. There are three major implementations with this feature. So we are just catching up. If

Re: [webkit-dev] Adding CSS3 background-position offsets.

2012-12-03 Thread Benjamin Poulain
On Mon, Dec 3, 2012 at 12:59 PM, Dirk Schulze dschu...@adobe.com wrote: Depends on the future. But for such a small patch, a new flag seems to be overdone. I looked into the patch, and adding the flag caused more code, then the actual feature (even if the computed style is missing). I believe

Re: [webkit-dev] pointer events specification - first editors draft

2012-12-04 Thread Benjamin Poulain
On Tue, Dec 4, 2012 at 10:34 AM, Rick Byers rby...@chromium.org wrote: The premise of the specification is that using mouse event and touch events interchangeably is needed. In reality, nobody was really asking for that because it is a terrible idea. You can already easily unify pen, touch

Re: [webkit-dev] Deep copy of the page with it's JS context

2012-12-12 Thread Benjamin Poulain
On Wed, Dec 12, 2012 at 11:03 AM, Николай Матюнин matyuni...@gmail.comwrote: I need your help (or just some advice). Currently I use WebKit (actually phantom.JS, which is based on the WebKit) as an instrument to research and develop the effective methods of ajax web-applications crawling

Re: [webkit-dev] Keeping up with new additions to canvas

2013-01-08 Thread Benjamin Poulain
On Tue, Jan 8, 2013 at 2:35 PM, Dean Jackson d...@apple.com wrote: On Jan 8, 2013, at 11:37 AM, Dean Jackson d...@apple.com wrote: As well as the other suggestions, you can look at bugs in the Canvas component. e.g. https://bugs.webkit.org/show_bug.cgi?id=82790 Marked as duplicate

Re: [webkit-dev] Feature Announcement: Moving HTML Parser off the Main Thread

2013-01-09 Thread Benjamin Poulain
On Wed, Jan 9, 2013 at 7:07 PM, Eric Seidel e...@webkit.org wrote: On Wed, Jan 9, 2013 at 6:38 PM, Oliver Hunt oli...@apple.com wrote: How will we ensure thread safety? Even at just the tokenizing level don't we use AtomicString? AtromicString isn't threadsafe wrt StringImpl IIRC so this

Re: [webkit-dev] Feature Announcement: WebSpeech - Speech Synthesis

2013-01-13 Thread Benjamin Poulain
On Sun, Jan 13, 2013 at 2:12 AM, Chris Fleizach cfleiz...@apple.com wrote: I'm planning on implementing the speech synthesis aspect of the WebSpeech API Specification https://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html#tts-section [...] Let me know if you have any questions.

Re: [webkit-dev] Adding Web MIDI API support to WebCore

2013-01-18 Thread Benjamin Poulain
On Fri, Jan 18, 2013 at 3:04 PM, Levi Weintraub le...@chromium.org wrote: I see that this is intended to go in as a module. My understanding is that concept was created to allow this sort of thing with minimal impact to core functionality. I don't think that is the concern at hand, but

Re: [webkit-dev] Please do not enable ENABLE_INPUT_TYPE_DATETIME

2013-01-21 Thread Benjamin Poulain
On Sun, Jan 20, 2013 at 9:55 PM, TAMURA, Kent tk...@chromium.org wrote: Please do not enable ENABLE_INPUT_TYPE_DATETIME to ship input type=datetimeimplementation in your products. We had some discussion in WHATWG [1] [2] and realized input type=datetime UIs in iOS Safari and Android Chrome

Re: [webkit-dev] RGBA8 and BGRA8 formats in WebKit

2013-01-21 Thread Benjamin Poulain
On Mon, Jan 21, 2013 at 7:00 AM, Zoltan Herczeg zherc...@webkit.org wrote: In WebKit both RGBA and BGRA formats are used for different purposes and different platforms in WebKit. Do we have a policy which one we prefer? It would be nice to reduce conversions between them in the future as it

Re: [webkit-dev] RGBA8 and BGRA8 formats in WebKit

2013-01-22 Thread Benjamin Poulain
On Tue, Jan 22, 2013 at 12:39 PM, Allan Sandfeld Jensen k...@carewolf.comwrote: memcpy is heavily optimized for different architectures and even subarchitectures. Unless you take the time to write several architecture specific BGRA-RGBA conversions it will never be as fast as memcpy. This

Re: [webkit-dev] Feature announcement: Custom Elements

2013-01-29 Thread Benjamin Poulain
On Tue, Jan 29, 2013 at 6:22 PM, Hajime Morrita morr...@chromium.orgwrote: I'm going to implement Custom Elements standard behind ENABLE(CUSTOM_ELEMENTS) flag. https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/custom/index.html Here is the tracking bug for the feature:

Re: [webkit-dev] Adding blending mode to background images

2013-02-01 Thread Benjamin Poulain
On Fri, Feb 1, 2013 at 12:44 PM, Rik Cabanier caban...@gmail.com wrote: background-image: url(a.png), url(b.png); -webkit-background-blend-mode: screen, screen; Out of curiosity: I am probably way too late for the party, but why not blend surface-to-surface? E.g. background-image:

Re: [webkit-dev] Exporting symbols (was Re: Common build system (was Re: WebKit Wishes))

2013-02-02 Thread Benjamin Poulain
On Sat, Feb 2, 2013 at 10:23 PM, Eric Seidel e...@webkit.org wrote: What I've learned from this thread, is that AppleWin and AppleMac are the only two ports which require lists of exported symbols. If both were to convert to using EXPORT decorators instead, then we could remove needs for

Re: [webkit-dev] SerializedScriptValue: signed vs unsigned char

2013-02-04 Thread Benjamin Poulain
On Mon, Feb 4, 2013 at 3:51 PM, Alec Flett alecfl...@chromium.org wrote: At the moment, SerializedScriptValue uses Vectoruint8_t (aka Vectorunsigned char) for both it's API (createFromWireBytes, toWireBytes) as well as its internal representation. (for both v8 and jsc implementations) The

Re: [webkit-dev] SerializedScriptValue: signed vs unsigned char

2013-02-04 Thread Benjamin Poulain
On Mon, Feb 4, 2013 at 4:54 PM, Alec Flett alecfl...@chromium.org wrote: Well, nobody is explicitly using LChar with SerializedScriptValue (maybe it should, maybe that's another issue) but I guess this is why I'm asking - I'm happy to just deal with this in IDB with some ugly

Re: [webkit-dev] Gated trunk, experiences from OpenStack

2013-02-05 Thread Benjamin Poulain
On Tue, Feb 5, 2013 at 12:17 PM, Dirk Pranke dpra...@chromium.org wrote: There are two other related aspects that make our tests flaky: 1) They're very high level integration tests (mostly), which, as they cover large swaths of code in each test, are much more susceptible to flakiness than

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Benjamin Poulain
On Tue, Feb 5, 2013 at 12:59 PM, Maciej Stachowiak m...@apple.com wrote: I have to say that the syntax weight of gyp files (quotes, commas, braces, brackets) makes them feel harder to read and edit than other build file formats designed for human consumption (obviously Xcode is worse). As

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Benjamin Poulain
On Fri, Feb 8, 2013 at 11:12 AM, Ryosuke Niwa rn...@webkit.org wrote: I had similar thoughts but my counter proposal is to let DRT/WTR generate multiple actual results either in the form of multiple layers in PNG or multiple PNG images. The advantage of this latter approach is that we can

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Benjamin Poulain
On Fri, Feb 8, 2013 at 3:16 PM, noam.rosent...@nokia.com wrote: The problem with dynamic features of the web like animations/interactions is that they're non-deterministic, or at least a lot less deterministic than static features of the web like layouts. Ref tests, pixel tests etc. are

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Benjamin Poulain
On Fri, Feb 8, 2013 at 4:12 PM, Gregg Tavares g...@google.com wrote: Can you expose a time or setTime function in DRT and some option that says let JS control the clock? Unfortunately, that only works in the simple cases. We could cheat the WebCore clock, but that would ultimately be wrong

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-09 Thread Benjamin Poulain
On Sat, Feb 9, 2013 at 1:24 AM, noam.rosent...@nokia.com wrote: I did not say they cannot be tested with the two methods suggested :) It's more about a preference to move some of those decisions from the test infrastructure to the test itself, but potentially those bugs could be tested in

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

2013-02-09 Thread Benjamin Poulain
On Sat, Feb 9, 2013 at 3:01 PM, James Robinson jam...@google.com wrote: http://trac.webkit.org/changeset/141812 ( https://bugs.webkit.org/show_bug.cgi?id=108139) added fine-grain locking to the AtomicString table in order to support the iOS WebKit threading model. If parallel execution is

[webkit-dev] Can Qt use some of the common DRT code?

2013-02-10 Thread Benjamin Poulain
Hi, Today, adding a support for a new function in TestRunner requires (painfully) changing: -WebKitTestRunner. -Common DRT + 6 implementations (Mac, Win, GTK, EFL, WX, Blackberry). -Chromium DRT. -Qt DRT. I think we can do much better. A first step is to have more common code in DRT. One of the

[webkit-dev] Is the wxWidgets port maintained?

2013-02-10 Thread Benjamin Poulain
Hi again, While looking into DRT changes, I notice there is zero activity on the wxWidgets implementation. Looking at WebCore/WebKit, excluding general changes, the last commit for wxWidgets is 6 months old: http://trac.webkit.org/changeset/126457 So...is the port still active? Maybe it should

Re: [webkit-dev] Need help regarding layouting and painting part

2013-02-10 Thread Benjamin Poulain
On Sun, Feb 10, 2013 at 10:30 PM, 85.mukesh 85.muk...@gmail.com wrote: I want to put any kind of Box2d effect on html element. These things I want to do with css extension. [...] Wrong mailing list. WebKit-dev is for the development of WebKit. If you want to make some kind of non-standard

Re: [webkit-dev] Can Qt use some of the common DRT code?

2013-02-10 Thread Benjamin Poulain
On Sun, Feb 10, 2013 at 10:56 PM, Jochen Eisinger joc...@chromium.orgwrote: Today, adding a support for a new function in TestRunner requires (painfully) changing: -WebKitTestRunner. -Common DRT + 6 implementations (Mac, Win, GTK, EFL, WX, Blackberry). -Chromium DRT. -Qt DRT. I think we

Re: [webkit-dev] Can Qt use some of the common DRT code?

2013-02-10 Thread Benjamin Poulain
On Sun, Feb 10, 2013 at 11:20 PM, Jochen Eisinger joc...@chromium.orgwrote: I'm not sure I understand. In what cases do you then add something to DRT and need to change all of them? Take this for example: http://trac.webkit.org/changeset/130416 It does not make sense to test everything

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Benjamin Poulain
On Mon, Feb 11, 2013 at 11:27 AM, Kevin Ollivier kev...@theolliviers.comwrote: I actually have recently been working on a patch to get trunk building again, though. The path of least resistance for me would simply be to ask people to ignore the wx port in their changes, but leave it in the

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Benjamin Poulain
On Mon, Feb 11, 2013 at 6:17 PM, Kevin Ollivier kev...@theolliviers.comwrote: To be honest, I think I know more about the wx port, and would probably be better able to cleanly remove it from the tree, than you would. As I've said from the start, I'll remove it if that's what people want, but I

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-13 Thread Benjamin Poulain
On Wed, Feb 13, 2013 at 9:38 PM, Dongsung Huang luxte...@company100.netwrote: I like this idea. I cannot find any harm if we have this functionality. Those changes are not harmless. There are people monitoring tests results full time in order to keep WebKit in good shape. No other part of

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-13 Thread Benjamin Poulain
On Wed, Feb 13, 2013 at 11:16 PM, Dirk Pranke dpra...@chromium.org wrote: Those changes are not harmless. There are people monitoring tests results full time in order to keep WebKit in good shape. No other part of WebKit require continuous attention. I'm sorry, but either I don't

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-13 Thread Benjamin Poulain
On Wed, Feb 13, 2013 at 11:27 PM, noam.rosent...@nokia.com wrote: Why wasn't a ref-test a better solution in this particular case? Because gaussian blurs on the GPU are not accurate, and look slightly different on different GPUs, but usually close enough. We need a way to measure close

Re: [webkit-dev] How to get patch test at different platform before webkit-patch upload

2013-02-16 Thread Benjamin Poulain
Hi, On Sat, Feb 16, 2013 at 5:45 PM, 徐征 xz91...@yahoo.co.jp wrote: I am handling this issue (https://bugs.webkit.org/show_bug.cgi?id=78957) now. My question is I test my added test code locally, however, it seems failed on some other platform(get red on cr-linux). So can I(and how can I)

Re: [webkit-dev] Getting involved

2013-02-18 Thread Benjamin Poulain
Hi Jason, On Mon, Feb 18, 2013 at 2:45 PM, Jason Anderssen janders...@exactal.comwrote: With a background in development (both windows and MAC) I was wanting to get involved in an open source project that I believe is going to make the world a greater place. So I have decided to get involved

Re: [webkit-dev] Getting involved

2013-02-19 Thread Benjamin Poulain
On Tue, Feb 19, 2013 at 11:29 AM, Dirk Pranke dpra...@chromium.org wrote: On http://trac.webkit.org/wiki there are a bunch of pages under Layout Tests and Performance Tests that describe much of the infrastructure. These days most of it is written in Python. I don't know what projects

Re: [webkit-dev] [Coding Style] Clarification about multiple assignments on one line

2013-02-22 Thread Benjamin Poulain
On Fri, Feb 22, 2013 at 2:35 PM, Julien Chaffraix jchaffr...@webkit.orgwrote: over several reviews, I have been saying that the following line is a coding style violation: firstVariable = secondVariable = 0; For a concrete example, the computePreferredLogicalWidths uses the following

Re: [webkit-dev] WebKit Perf Monitor (perf.webkit.org) has been launched

2013-02-24 Thread Benjamin Poulain
On Sun, Feb 24, 2013 at 7:24 PM, Ryosuke Niwa rn...@webkit.org wrote: We've replaced webkit-perf.appspot.com by perf.webkit.org. webkit-perf.appspot.com will be phased-out in the coming weeks. I'm going to check in the source code of perf.webkit.org into WebKit repository in coming months.

Re: [webkit-dev] New web-facing CSS feature: -webkit-cursor-visibility: auto-hide

2013-03-04 Thread Benjamin Poulain
On Mon, Mar 4, 2013 at 4:52 PM, Jer Noble jer.no...@apple.com wrote: On Mar 4, 2013, at 4:46 PM, Ryosuke Niwa rn...@webkit.org wrote: Could you add either build or runtime flag? I most definitely could. But are there any ports who would disable the flag? (Honestly asking, here.) If not,

Re: [webkit-dev] Heads-up: C++11 and WebKit2

2013-03-05 Thread Benjamin Poulain
On Tue, Mar 5, 2013 at 3:48 PM, Kenneth Rohde Christiansen kenneth.christian...@gmail.com wrote: I am personally happy that we can make use of C++11 and I don't suppose it is a problem for the Tizen/EFL port. On the other hand, I fear that Qt might be targeting some platforms where this could

Re: [webkit-dev] Making performance tests in WebKit more useful

2013-03-08 Thread Benjamin Poulain
On Fri, Mar 8, 2013 at 2:15 AM, Ryosuke Niwa rn...@webkit.org wrote: Three major problems with existing WebKit performance tests are: 1. There are too many tests to run 2. Some tests have variances that are too high to be of any use 3. Some tests are too specific to be of any

Re: [webkit-dev] window.internals abuse

2013-03-13 Thread Benjamin Poulain
On Wed, Mar 13, 2013 at 10:04 AM, Ryosuke Niwa rn...@webkit.org wrote: Background blur (or background filters in general) are not a web-exposed feature, so it seems odd that Internals has a switch for some non-web-exposed feature that is only implemented by one port. It feels like this was

Re: [webkit-dev] Ever increasing binary size

2013-03-22 Thread Benjamin Poulain
On Fri, Mar 22, 2013 at 12:12 AM, Ryosuke Niwa rn...@webkit.org wrote: WebKit nightly build for r135421 dated November 21st, 2012 was 46.1MB. WebKit nightly build for r145786 dated March 13th, 2013 was 49.4MB. Our binary size increased by 7.2% in just 4 months. I have been tracking this

  1   2   3   >