Re: [webkit-dev] Github vs. git.webkit.org

2012-12-04 Thread Tor Arne Vestbø
://github.com/apache The mirroring icon indicates kind of official-ness. I don't know how long their mirroring delay is, though. On Sat, Dec 1, 2012 at 12:07 AM, Tor Arne Vestbø tor.arne.ves...@digia.com mailto:tor.arne.ves...@digia.com wrote: On 11/28/12 16:55 , Adam Barth wrote

Re: [webkit-dev] Github vs. git.webkit.org

2012-11-30 Thread Tor Arne Vestbø
On 11/28/12 16:55 , Adam Barth wrote: My sense is that the WebKit community would prefer that the hashes in GitHub match the hashes in git.webkit.org so that folks can more easily move branches between the two. For my part, I've switched over to using GitHub exclusive of git.webkit.org, so the

Re: [webkit-dev] Github vs. git.webkit.org

2012-11-28 Thread Tor Arne Vestbø
On 11/25/12 1:12 , Adam Barth wrote: On Sat, Nov 24, 2012 at 1:53 PM, Gergely Kis gerg...@homejinni.com wrote: Yes, I saw that thread, but I got confused by this other thread: https://lists.webkit.org/pipermail/webkit-dev/2012-April/020339.html Here most of the participants seemed to agree

Re: [webkit-dev] github mirror

2012-04-24 Thread Tor Arne Vestbø
On 18.04.12 17:02, Simon Hausmann wrote: On Wednesday, April 18, 2012 06:53:46 AM ext Shezan Baig wrote: Hi WebKit, I've been using a fork of the following repo: https://github.com/WebKit/webkit However, yesterday there was discussion on #webkit that the SHA-1 checksums on this repo are

Re: [webkit-dev] github mirror

2012-04-24 Thread Tor Arne Vestbø
On 24.04.12 15:55, ext Adam Roben wrote: Probably the biggest issue is for people who've been using git.webkit.org and now want to try out GitHub. Since the commits are distinct between the two repositories, they have to do a full clone to make the switch. Any idea why git is not smarter when

Re: [webkit-dev] github mirror

2012-04-24 Thread Tor Arne Vestbø
On 24.04.12 16:04, ext Shezan Baig wrote: On Tue, Apr 24, 2012 at 9:55 AM, Adam Robenaro...@webkit.org wrote: In what situation does this cause issues? Probably the biggest issue is for people who've been using git.webkit.org and now want to try out GitHub. Since the commits are distinct

Re: [webkit-dev] An incremental approach (was Re: UPDATED Re: Version control survey)

2012-03-12 Thread Tor Arne Vestbø
On 11.03.12 00:08, Alp Toker wrote: The way I see it, a better mirror would address: *Author Names *The committer names don't have the full author name in the git mirror right now, just an SVN id. This info could be extracted out of a database or the ChangeLog message if one exists, during

Re: [webkit-dev] Moving to Git?

2012-03-09 Thread Tor Arne Vestbø
On 09.03.12 01:36, Aaron Boodman wrote: I think it would look the same, except for instead of monotonically increasing decimal numbers in the revision column, you'd see random hexadecimal ones (typically 6-8 digits long). It would be possible to use 'git describe' [1] to give something like

Re: [webkit-dev] Moving to Git?

2012-03-09 Thread Tor Arne Vestbø
On 08.03.12 22:25, Ryosuke Niwa wrote: That'll certainly be an improvement. I still dislike git hashes though. If someone implements such a script in webkit-patch and we can automatically assign svn-revision like numbers to all commits, I can be convinced to use git. Dunno about webkit-patch,

Re: [webkit-dev] Is converting pixel tests to reftests kosher for imported libraries?

2012-03-08 Thread Tor Arne Vestbø
On 08.03.12 01:57, Levi Weintraub wrote: On Wed, Mar 7, 2012 at 4:50 PM, Ryosuke Niwa rn...@webkit.org mailto:rn...@webkit.org wrote: On Wed, Mar 7, 2012 at 4:44 PM, Darin Fisher da...@chromium.org mailto:da...@chromium.org wrote: Hrm, if the test expectations are customized

Re: [webkit-dev] Moving to Git?

2012-03-08 Thread Tor Arne Vestbø
On 08.03.12 18:22, Geoffrey Garen wrote: Rather than asking for a switch to git by fiat, why not improve git and our git-related infrastructure to the point where people choose to switch naturally? The fact that many valuable contributors choose not to use git is sufficient proof that switching

Re: [webkit-dev] Some new coding style rules

2010-08-05 Thread Tor Arne Vestbø
On 04.08.10 20.04, Adam Roben wrote: On Aug 4, 2010, at 7:15 AM, Jeremy Orlow wrote: 2. ENABLE(FOO) #endif comments #if ENABLE(FOO) .. #endif // ENABLE(FOO) Shall we remove the comment, or require it explicitely in the style rules? I find these comments especially helpful when there are

Re: [webkit-dev] Bugzilla Triaged keyword

2010-04-27 Thread Tor Arne Vestbø
On 26.04.10 22.16, Andras Becsi wrote: As far as I know QtWebKit uses this keyword to indicate that the corresponding bug has been checked and prioritized based on its severity by a triaging group of two QtWebKit developers. https://trac.webkit.org/wiki/QtWebKitBugs#Triagingbugs That's

Re: [webkit-dev] changelog and patches

2010-02-23 Thread Tor Arne Vestbø
On 23/2/10 13:31 , Evan Martin wrote: Run WebKitTools/Scripts/resolve-ChangeLogs each time you rebase. Or run once: git config merge.changelog.driver resolve-ChangeLogs --merge-driver %O %A %B tor arne ___ webkit-dev mailing list

[webkit-dev] Increasing the number of cross-platform/port expected results

2010-02-23 Thread Tor Arne Vestbø
Hey all, A reoccurring problem when trying to maintain layout-test results is differences in font and theme metrics for tests that dump the render tree. Often a test does not actually test font loading/rendering or theming, but has a piece of text or an input element somewhere in the test

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-02-23 Thread Tor Arne Vestbø
On 23/2/10 14:15 , Evan Martin wrote: On Tue, Feb 23, 2010 at 2:00 PM, Tor Arne Vestbø tor.arne.ves...@nokia.com wrote: Lately we've been playing with the idea of using SVG fonts for the Qt port to get the same set of expected results for qt-mac, qt-linux and qt-win, by injecting new @font

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-02-23 Thread Tor Arne Vestbø
On 23/2/10 17:02 , Simon Fraser wrote: On Feb 23, 2010, at 5:00 AM, Tor Arne Vestbø wrote: Hey all, A reoccurring problem when trying to maintain layout-test results is differences in font and theme metrics for tests that dump the render tree. Often a test does not actually test font loading

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-02-23 Thread Tor Arne Vestbø
On 23/2/10 17:34 , Simon Fraser wrote: On Feb 23, 2010, at 8:21 AM, Tor Arne Vestbø wrote: On 23/2/10 17:02 , Simon Fraser wrote: I think the correct longterm solution to this problem is to use reftests. A reftest consists of two files; the test file, and a reference file that should give

[webkit-dev] Disabling 'Reset Assignee to default' on component change on bugs.webkit.org

2010-02-17 Thread Tor Arne Vestbø
Hey, http://bugs.webkit.org/ currently has the behavior that if you change the component, the checkbox Reset Assignee to default is automatically checked, which will revert the assignee to the default for that component. The default for all our components is webkit-unassig...@webkit.org:

Re: [webkit-dev] Disabling 'Reset Assignee to default' on component change on bugs.webkit.org

2010-02-17 Thread Tor Arne Vestbø
On 17/2/10 17:55 , Alexey Proskuryakov wrote: 17.02.2010, в 07:15, Tor Arne Vestbø написал(а): Which means that if you change the component for a bug that has been assigned to someone, for example during triaging, you may accidentally remove that assignee and the bug may drop out

Re: [webkit-dev] [Qt] Build problem due to newly introduced WebKit/qt/Api/DerivedSources.pro

2010-02-05 Thread Tor Arne Vestbø
On 2/5/10 4:51 PM, İsmail Dönmez wrote: Seems to be due to newly checked in DerivedSources.pro. Try applying this: http://gist.github.com/295937 I have to run but I'll land this on Monday. Tor Arne ___ webkit-dev mailing list

Re: [webkit-dev] changelogs: a reprise

2010-01-27 Thread Tor Arne Vestbø
Tor Arne Vestbø wrote: Here's a wip patch to update-webkit's Git part I've been running locally for a few days now, it has basic resolve-ChangeLogs-support, as well as mirror support: http://gist.github.com/287646 https://bugs.webkit.org/show_bug.cgi?id=34206 tor arne

Re: [webkit-dev] Tagging bug names with a platform name: limit to platform-specific patches

2010-01-21 Thread Tor Arne Vestbø
Darin Adler wrote: Hi folks. We’ve never formalized this, but I believe that patches tagged with a particular platform name such as [Qt] Add new API for fluffy bunnies should be limited to one particular platform’s code. If the patch changes more than a trivial bit of platform-independent

Re: [webkit-dev] Did I break the build?

2010-01-08 Thread Tor Arne Vestbø
Eric Seidel wrote: http://build.webkit.org/console Will let you know. I love the console, thanks for adding this! tor arne ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Did I break the build?

2010-01-08 Thread Tor Arne Vestbø
Eric Seidel wrote: The Chromium developers, notably Nicolas Sylvain added /console. Mark Rowe is our kind BuildBot admin who updated our copy to the latest BuildBot version including this new feature. I was not involved. :) Then great thanks to both Nicolas and Mark!! :) tor arne

Re: [webkit-dev] Patch status display on bugs.webkit.org

2010-01-04 Thread Tor Arne Vestbø
Adam Barth wrote: As we bring more bots online, this user interface should scale better than posting lots of pass comments. If folks like this display, we can incorporate it into bugs.webkit.org directly. +1 for including this in the site directly! Cool stuff! Tor Arne

[webkit-dev] Style guide for indenting nested #if #define in headers

2009-10-15 Thread Tor Arne Vestbø
Hey, Could not find anything in the style guide regarding indentation of nested #ifs/#ifdefs in headers, ie. not #ifdefs in normal code, where adding extra indentation would break the indentation of the surrounding code, but nested #ifdefs in files like Platform.h Personally I prefer

[webkit-dev] Guided bug reporting on bugs.webkit.org

2009-10-06 Thread Tor Arne Vestbø
Hey, Right now we have the bug reporting guidelines, here: http://webkit.org/quality/bugwriting.html And the actual form here: https://bugs.webkit.org/enter_bug.cgi?product=WebKit Would it make sense to expand the create-form template in Bugzilla to join these two in a guided

Re: [webkit-dev] [webkit-changes] [48407] trunk/LayoutTests

2009-09-17 Thread Tor Arne Vestbø
Chris Fleizach wrote: It's possible that Windows, for example, supports an accessibility value attribute for sliders, but it's also possible that it does not. Likewise, it's possible Linux could support that attribute, or not. All I am sure of right now is that it's not implemented now. So

Re: [webkit-dev] User Stylesheets changes I'd like to make

2009-09-04 Thread Tor Arne Vestbø
On 9/4/09 9:47 PM, David Hyatt wrote: Right now the user stylesheet location is stored as a URL. This is based off ancient history, namely that we happened to store the preference this way on Mac. Even though Safari only allows you to pick local files from its UI for user stylesheets, the

Re: [webkit-dev] Building Webkit on Linux

2009-08-11 Thread Tor Arne Vestbø
On 8/11/09 12:30 PM, Jilu Oommen wrote: Hi, I am trying to build webkit on Linux using gcc (GCC) 4.3.0 20080428 (Red Hat 4.3.0-8). Currently I am getting stuck on linking error: ar: DerivedSources/.libs/JSCSSCharsetRule.o: No such file or directory Can you please let me know a solution at the

Re: [webkit-dev] Themes extending the style

2008-11-05 Thread Tor Arne Vestbø
with CSS rules. I just woke up, and haven't had my coffee yet, but didn't we add this in r268f45? The Qt port uses WebCore/platform/qt/html4-adjustments-qt.css to modify html4.css, not replace it as far as I remember. -- Tor Arne Vestbø, Software Engineer Qt Software, Nokia, Oslo, Norway http

Re: [webkit-dev] Themes extending the style

2008-11-05 Thread Tor Arne Vestbø
Tor Arne Vestbø wrote: I just woke up, and haven't had my coffee yet, but didn't we add this in r268f45? Sorry, that was r34297 http://trac.webkit.org/changeset/34297 -- Tor Arne Vestbø, Software Engineer Qt Software, Nokia, Oslo, Norway http://www.trolltech.com

Re: [webkit-dev] WebKit-r33371 compilation error against Qtopia Phone Edition 4.3.1

2008-05-13 Thread Tor Arne Vestbø
HTMLFormElement.cpp ../../../WebCore/platform/FileSystem.h:138: error: 'PlatformModule' was not declared in this scope Add || defined(Q_WS_QWS) I'll sort this out in a patch. Thanks for reporting! Tor Arne -- Tor Arne Vestbø, Software Engineer Trolltech ASA, Oslo, Norway http://www.trolltech.com

[webkit-dev] How to abstract text drag delay and hysteresis

2008-02-21 Thread Tor Arne Vestbø
right with me, but maybe a global function? Tor Arne -- Tor Arne Vestbø, Software Engineer Trolltech ASA, Oslo, Norway http://www.trolltech.com/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit