[webkit-dev] JavaScriptCore enhancements

2009-07-03 Thread Zoltan Herczeg
Hi, we hope the general arm-jit will soon go to mainline, so we could have enough time to countinue our work on other JSC enhancements. We would like to hear your opinion about them (Are they still valid? Has someone else already been working on it? Which one is important for you?): - runtime

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-03 Thread Alexey Proskuryakov
02.07.2009, в 18:05, Adam Roben написал(а): - I prefer having Bug N: before the actual bug description so I don't have to parse the URL myself for the bug number. It also acts as a visual marker when I read the ChangeLog entry. ... Here's an example entry that follows the format

[webkit-dev] how to extend the javascript native object?

2009-07-03 Thread 胡 波
    I want to extend the javascript native object,such as widget object,and make it inherit window object. That is to say,when the widget object is extended, and we can use it by the window.widget.(method/property) in the html document?

Re: [webkit-dev] how to extend the javascript native object?

2009-07-03 Thread Jack Wootton
To add, it maybe useful to look at the following files in the JavaScriptCore (Although, personally I didn't find them particularly easy to understand.) JavaScriptCore\API\testapi.c testapi.js There are also some example programs that do what you want to do, only with different objects. JSPong:

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-03 Thread Peter Kasting
Since this seems to have become the new bikeshed, I'll chime in with my color preference: Reviewed by John Smith (jsm...@webkit.org) https://bugs.webkit.org/show_bug.cgi?id=123456 Fix WebKit being not awesome enough. Make five files more awesome. FWIW, I agree with those who desire

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-03 Thread Jeremy Orlow
On Fri, Jul 3, 2009 at 10:24 AM, Peter Kasting pkast...@google.com wrote: Since this seems to have become the new bikeshed, I'll chime in with my color preference: Reviewed by John Smith (jsm...@webkit.org) https://bugs.webkit.org/show_bug.cgi?id=123456 Fix WebKit being not awesome

Re: [webkit-dev] ChangeLog

2009-07-03 Thread Darin Adler
On Jul 3, 2009, at 10:44 AM, Jeremy Orlow wrote: I agree that the ChangeLog really is duplicate information [...] The WebKit project change log was inspired by GNU project change logs: http://www.gnu.org/prep/standards/html_node/Change-Logs.html. I don’t like ChangeLog specifically. My

Re: [webkit-dev] ChangeLog

2009-07-03 Thread Peter Kasting
On Fri, Jul 3, 2009 at 10:55 AM, Darin Adler da...@apple.com wrote: It's backwards to say that the ChangeLog is a workaround for lack of tools. Some day we may see a tool that works so well that we’d be willing to forgo change logs, but we need to see that tool in action first to see that it

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-03 Thread John Sullivan
On Jul 2, 2009, at 12:40 AM, Eric Seidel wrote: Agreed. Although, Darin Adler is about the only person I ever see fill in per-file/per-function information. :) Darin is certainly more conscientious about this than most people, but a quick glance at WebCore's ChangeLog shows that many

[webkit-dev] Changes since Version 37894 ?

2009-07-03 Thread Elison Smith
Hi, I had checked out a version of the WebKit codebase last November (version 37894) and have done some dev around that. I now want to sync back with the current head, to be able to make use of all the improvements that have gone in since then - due to the contributions of the people here. Can

Re: [webkit-dev] ChangeLog

2009-07-03 Thread Jeremy Orlow
To be more clear: Rietveld + gcl (the way Chromium does reviews/checkins) has you specify a group of files which is called a change list. Part of each change list is a description. Reviewers use and critique this description, which is much like what's done with the ChangeLog. Nothing lists out

Re: [webkit-dev] Changes since Version 37894 ?

2009-07-03 Thread Adam Barth
I believe there have been numerous changes since then. For example, I believe the JavaScript engine has been completely re-written. Adam On Fri, Jul 3, 2009 at 12:03 PM, Elison Smithelison.sm...@gmail.com wrote: Hi, I had checked out a version of the WebKit codebase last November (version

[webkit-dev] [V8] It's time for V8Proxy to come to Jesus

2009-07-03 Thread Adam Barth
If you're uninterested in the V8 bindings, you can skip this email. Clocking in at 3255 lines (plus a 682-line header file), V8Proxy is out of control. Historically a bridge from the V8 bindings to the V8 engine, V8Proxy is responsible for a number of tasks including: 1) Creating new contexts

Re: [webkit-dev] ChangeLog

2009-07-03 Thread Darin Adler
On Jul 3, 2009, at 12:04 PM, Jeremy Orlow wrote: Nothing lists out the modified functions like in your ChangeLog, but I guess that's just not something people commonly need. I often search for old relevant changes by searching for function names. At least once a week for the last 5 years.

Re: [webkit-dev] ChangeLog

2009-07-03 Thread Jeremy Orlow
On Fri, Jul 3, 2009 at 12:29 PM, Darin Adler da...@apple.com wrote: On Jul 3, 2009, at 12:04 PM, Jeremy Orlow wrote: Nothing lists out the modified functions like in your ChangeLog, but I guess that's just not something people commonly need. I often search for old relevant changes by

Re: [webkit-dev] ChangeLog

2009-07-03 Thread Joe Mason
Darin Adler wrote: My experience on other projects that don’t use ChangeLog is that many check-ins don’t have clear comments or descriptions, and the fact that these are missing is considerably easier to overlook. Source code control comments can be tricky if you can never delete or edit them.

Re: [webkit-dev] [V8] It's time for V8Proxy to come to Jesus

2009-07-03 Thread Aaron Boodman
+1: Hooray for any attempts to tame V8Proxy. - a On Fri, Jul 3, 2009 at 12:23 PM, Adam Barthaba...@webkit.org wrote: If you're uninterested in the V8 bindings, you can skip this email. Clocking in at 3255 lines (plus a 682-line header file), V8Proxy is out of control.  Historically a bridge

Re: [webkit-dev] Some new mailing lists

2009-07-03 Thread Eric Seidel
I wondered after auto-complete failed me this week, and I accidentally sent Peter's nomination to webkit-dev instead of webkit-reviewers, why do we have webkit- at the start of all are lists? That's just 6 more characters I have to type to make sure that I auto-complete correctly. :) Couldn't

Re: [webkit-dev] Some new mailing lists

2009-07-03 Thread Mark Rowe
On 2009-07-03, at 13:34, Eric Seidel wrote: I wondered after auto-complete failed me this week, and I accidentally sent Peter's nomination to webkit-dev instead of webkit-reviewers, why do we have webkit- at the start of all are lists? That's just 6 more characters I have to type to make sure

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-03 Thread Maciej Stachowiak
On Jul 3, 2009, at 10:44 AM, Jeremy Orlow wrote: On Fri, Jul 3, 2009 at 10:24 AM, Peter Kasting pkast...@google.com wrote: Since this seems to have become the new bikeshed, I'll chime in with my color preference: Reviewed by John Smith (jsm...@webkit.org)

Re: [webkit-dev] ChangeLog

2009-07-03 Thread Maciej Stachowiak
On Jul 3, 2009, at 12:29 PM, Darin Adler wrote: On Jul 3, 2009, at 12:04 PM, Jeremy Orlow wrote: Nothing lists out the modified functions like in your ChangeLog, but I guess that's just not something people commonly need. I often search for old relevant changes by searching for function

Re: [webkit-dev] Some new mailing lists

2009-07-03 Thread Maciej Stachowiak
On Jul 3, 2009, at 1:34 PM, Eric Seidel wrote: I wondered after auto-complete failed me this week, and I accidentally sent Peter's nomination to webkit-dev instead of webkit-reviewers, why do we have webkit- at the start of all are lists? That's just 6 more characters I have to type to make

Re: [webkit-dev] ChangeLog

2009-07-03 Thread Joe Mason
Maciej Stachowiak wrote: I'm not sure why making an extra copy of the info on update is better than doing it on checkin. People update their tree more often than they commit, so prima facie this seems like a backwards way to do it. Also, svn2cl is much slower than a one-time copy of the latest

[webkit-dev] Inheritance in IDL files/JS bindings

2009-07-03 Thread Drew Wilson
I'm working on refactoring some code out of WebCore::Worker into a common base class to be shared between SharedWorker and Worker. So I've defined a new AbstractWorker.idl and its associated JS bindings. AbstractWorker is not intended to be instantiable, so I don't have a constructor generated for

Re: [webkit-dev] Inheritance in IDL files/JS bindings

2009-07-03 Thread Maciej Stachowiak
On Jul 3, 2009, at 2:42 PM, Drew Wilson wrote: Is there anything special I need to do when implementing inheritance in IDL files and JS bindings? I *think* I'm correctly following the example of other places where we use inheritance (example HTMLElement - Element - Node), although there

Re: [webkit-dev] Inheritance in IDL files/JS bindings

2009-07-03 Thread Sam Weinig
On Fri, Jul 3, 2009 at 2:42 PM, Drew Wilson atwil...@google.com wrote: I'm working on refactoring some code out of WebCore::Worker into a common base class to be shared between SharedWorker and Worker. So I've defined a new AbstractWorker.idl and its associated JS bindings. AbstractWorker is

[webkit-dev] content policies

2009-07-03 Thread Roger Pack
Sorry to just join and post in...just wondering if any consideration had been given to something akin to Gecko's content policies for filtering content. This would allow things like adblock plus to work more easily with webkit based browsers [1]. Or is this something like create a patch and send

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-03 Thread David Kilzer
On Friday, July 3, 2009 3:20:58 AM, Alexey Proskuryakov wrote: 02.07.2009, в 18:05, Adam Roben написал(а): Here's an example entry that follows the format that I (and I think Dave) like: +2009-04-20 Adam Roben aro...@apple.com + +Change MemoryStream::createInstance to

Re: [webkit-dev] ChangeLog

2009-07-03 Thread David Kilzer
On Friday, July 3, 2009 1:01:33 PM, Joe Mason wrote: Even if sticking with svn, you just need to run svn2cl once when you update to get a local copy of the changelog. If each developer had to run that command to get a local changelog, I can't imagine the svn server would be very

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-03 Thread David Kilzer
On Friday, July 3, 2009 2:19:51 PM, Maciej Stachowiak wrote: What I do (and I think many of us do) is use a script that automatically fills in the commit message from the ChangeLog. The script is WebKitTools/Scripts/commit-log-editor. Setting one of these environment variables (depending on

[webkit-dev] RenderContainer class in webkit source code

2009-07-03 Thread n179911
Hi, Can you please tell me if the RenderContainer class in webkit source code got removed? I notice this class in android's webkit source, but when I check the code in webkit trunk, that class is not there. Can you please if that class got removed? Thank you

Re: [webkit-dev] RenderContainer class in webkit source code

2009-07-03 Thread Simon Fraser
On Jul 3, 2009, at 5:41 PM, n179911 wrote: Hi, Can you please tell me if the RenderContainer class in webkit source code got removed? I notice this class in android's webkit source, but when I check the code in webkit trunk, that class is not there. Can you please if that class got removed?

Re: [webkit-dev] RenderContainer class in webkit source code

2009-07-03 Thread n179911
Thanks. I am not sure how to use ChangeLogs. On Fri, Jul 3, 2009 at 5:58 PM, Simon Frasersimon.fra...@apple.com wrote: On Jul 3, 2009, at 5:41 PM, n179911 wrote: Hi, Can you please tell me if the RenderContainer class in webkit source code got removed? I notice this class in android's