Re: [Wicket-user] SubmitLink and back button...

2006-09-14 Thread Johan Compagner
But also for input in the wicket side??convertInput(),getInput(),getConvertedInput,validate name themAren't really meant for a button as far as i know.johanOn 9/13/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: I guess the reason that a button is a formcomponent is because abutton can receive inp

Re: [Wicket-user] SubmitLink and back button...

2006-09-13 Thread Igor Vaynberg
Forms themselves are versioned by default afaik, its the form components that are not. and now buttons are versioned by default.-IgorOn 9/13/06, Erik Brakkee <[EMAIL PROTECTED]> wrote:Igor Vaynberg wrote: > we are talking about form components that take their input off form> submissions - like tex

Re: [Wicket-user] SubmitLink and back button...

2006-09-13 Thread Erik Brakkee
Igor Vaynberg wrote: > we are talking about form components that take their input off form > submissions - like textfield - its not very practical to version it > because on backbutton you would resubmit the form and it would once > again pull its value from the request params. Ok, I didn't get tha

Re: [Wicket-user] SubmitLink and back button...

2006-09-13 Thread Igor Vaynberg
we are talking about form components that take their input off form submissions - like textfield - its not very practical to version it because on backbutton you would resubmit the form and it would once again pull its value from the request params. it doesnt work right now on buttons - i am going

Re: [Wicket-user] SubmitLink and back button...

2006-09-13 Thread Erik Brakkee
Johan Compagner wrote: > what would you poll the form for? (calling isVersioned()) from the > form components isVersioned()? > That is pretty much already done in that method. So I don't need to wait until all components are added to the form to call setVersioned(true)? > > i guess why we don't ver

Re: [Wicket-user] SubmitLink and back button...

2006-09-13 Thread Martijn Dashorst
I guess the reason that a button is a formcomponent is because a button can receive input... the value of a submit is pretty important... Martijn On 9/13/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > add an rfe for 2.0 :) > > -Igor > > > > On 9/13/06, Johan Compagner <[EMAIL PROTECTED]> wrote:

Re: [Wicket-user] SubmitLink and back button...

2006-09-13 Thread Igor Vaynberg
add an rfe for 2.0 :)-IgorOn 9/13/06, Johan Compagner <[EMAIL PROTECTED]> wrote: yeah that a button is a FormComponent on the wicket side is maybe a bit strange..Because almost all the things formcomponent has are not really used by a button.I get that on the markup side it is a form thing.. But to

Re: [Wicket-user] SubmitLink and back button...

2006-09-13 Thread Johan Compagner
yeah that a button is a FormComponent on the wicket side is maybe a bit strange..Because almost all the things formcomponent has are not really used by a button.I get that on the markup side it is a form thing.. But to be a formcomponent in java is maybe not even needed. johanOn 9/13/06, Igor Vaynb

Re: [Wicket-user] SubmitLink and back button...

2006-09-13 Thread Igor Vaynberg
yes, it doesnt make sense for form components that act on input, but this doesnt exactly apply to buttons.-IgorOn 9/13/06, Johan Compagner < [EMAIL PROTECTED]> wrote:what would you poll the form for? (calling isVersioned()) from the form components isVersioned()? That is pretty much already done in

Re: [Wicket-user] SubmitLink and back button...

2006-09-13 Thread Johan Compagner
what would you poll the form for? (calling isVersioned()) from the form components isVersioned()?That is pretty much already done in that method.i guess why we don't versioning formcomponents because it doesn't make much sense for the data (model) change. I guess the rest like visible it should wor

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Igor Vaynberg
thanks for the contribution-IgorOn 9/12/06, Erik Brakkee <[EMAIL PROTECTED]> wrote: Igor Vaynberg wrote:> there really isnt that much to it. if you have an object inside the> model it is versioned for you through modelchanging/changed calls.>> if you have state outside the model you version it your

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Erik Brakkee
Igor Vaynberg wrote: > there really isnt that much to it. if you have an object inside the > model it is versioned for you through modelchanging/changed calls. > > if you have state outside the model you version it yourself using > addStateChange which is trivial - just have to remember to do it. >

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Igor Vaynberg
On 9/12/06, Erik Brakkee <[EMAIL PROTECTED]> wrote: Igor Vaynberg wrote:> not formcomponents, which i think is a bit weird/wrong.Aha.>> what we want is to let the form control the versioning of> formcomponents, so inside formcomponent constructor we set it to > false. and then form overrides setver

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Erik Brakkee
Igor Vaynberg wrote: > not formcomponents, which i think is a bit weird/wrong. Aha. > > what we want is to let the form control the versioning of > formcomponents, so inside formcomponent constructor we set it to > false. and then form overrides setversioned() and replicates that call > to the form

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Igor Vaynberg
not formcomponents, which i think is a bit weird/wrong.what we want is to let the form control the versioning of formcomponents, so inside formcomponent constructor we set it to false. and then form overrides setversioned() and replicates that call to the formcomponents. the problem is that during

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Erik Brakkee
Can the call 'addLink.setVersioned(true);' be left out? By default pages are versioned so components on pages are versioned too by default, right? - Using Tomcat but need to do more? Need to support web services, security? Ge

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Martijn Dashorst
Go ahead with the commercial applications on the wiki. As long as they are developed using Wicket. Martijn On 9/12/06, Erik Brakkee <[EMAIL PROTECTED]> wrote: > Igor Vaynberg wrote: > > ok, should be fixed in 1.2.3, you can try the wicket-1.x branch now if > > you want > Thanks! I can wait for ve

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Igor Vaynberg
sure, wiki registration is open so feel free :)-IgorOn 9/12/06, Erik Brakkee <[EMAIL PROTECTED]> wrote: Igor Vaynberg wrote:> ok, should be fixed in 1.2.3, you can try the wicket-1.x branch now if> you wantThanks! I can wait for version 1.2.3 since the problem is not thatcritical for us.>> for the

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Erik Brakkee
Igor Vaynberg wrote: > ok, should be fixed in 1.2.3, you can try the wicket-1.x branch now if > you want Thanks! I can wait for version 1.2.3 since the problem is not that critical for us. > > for the versioning to work properly though you need to remember > changes done against your dataprovider b

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Igor Vaynberg
ok, should be fixed in 1.2.3, you can try the wicket-1.x branch now if you wantfor the versioning to work properly though you need to remember changes done against your dataprovider because it keeps its own state that needs to be rolled back. attached is the submitlinkpage.java that shows you how

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Igor Vaynberg
yeah i can reproduce it to, the problem is that the submitlink changes the form's value using _javascript_ - and the browser remembers it in its cache! so when you go back that cahnged url is present. ugly, im going to look for a solution. -IgorOn 9/12/06, Johan Compagner <[EMAIL PROTECTED]> wrote:

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Johan Compagner
best thing is to make a bug report and attach the testcase.Because in the traffic ammount of the mailing list it can be forgotton..johanOn 9/12/06, Erik Brakkee <[EMAIL PROTECTED]> wrote: Have you seen the test case I posted on the mailing list?Can you confirm that you see the problem too and that

Re: [Wicket-user] SubmitLink and back button...

2006-09-12 Thread Erik Brakkee
Have you seen the test case I posted on the mailing list? Can you confirm that you see the problem too and that it is indeed a wicket problem and not a problem with the way I use wicket? - Using Tomcat but need to do more? Nee

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Erik Brakkee
Igor Vaynberg wrote: > yes, i would imagine that would unless you repaint the form I am still relatively new with wicket and I haven't got a clue what you are talking about :-) Anyway, I managed to reproduce the problem with a very simple example so lets see what comes out of this. > > -Igor -

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Erik Brakkee
Johan Compagner wrote: ok so the value == null so the value shouldn't be something when you submit it. Please set a breakpoint on Form.onFormSubmitted linenr: 190 You must be looking at a different version of the code than I am. In wicket 1.2.2, I have set a break point at line 291, right afte

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Igor Vaynberg
yes, i would imagine that would unless you repaint the form-IgorOn 9/11/06, Erik Brakkee <[EMAIL PROTECTED] > wrote:Igor Vaynberg wrote:> AjaxSubmitLink/ButtonAjaxSubmitLink also fails in exactly the same way. >> -Igor-Using To

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Erik Brakkee
Igor Vaynberg wrote: > AjaxSubmitLink/Button AjaxSubmitLink also fails in exactly the same way. > > -Igor - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Erik Brakkee
Johan Compagner wrote: > if you could make a case where we can look at? I have managed to reproduce the problem using a very simple example. I have a list of submit links with a form. Initially, the list is empty. In addition, there is one link by which an additional submit link can be added to the

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Igor Vaynberg
AjaxSubmitLink/Button -IgorOn 9/11/06, Erik Brakkee <[EMAIL PROTECTED]> wrote: Igor Vaynberg wrote:> is the submit link ajax? that would do it. that link has to reset the> value when it is done processing.I used the standard SubmitLink. Nothing special here. Is there also anajax version? >> -Igor>-

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Erik Brakkee
Igor Vaynberg wrote: > is the submit link ajax? that would do it. that link has to reset the > value when it is done processing. I used the standard SubmitLink. Nothing special here. Is there also an ajax version? > > -Igor > ---

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Igor Vaynberg
is the submit link ajax? that would do it. that link has to reset the value when it is done processing.-IgorOn 9/11/06, Johan Compagner < [EMAIL PROTECTED]> wrote:ok so the value == null so the value shouldn't be something when you submit it. Please set a breakpoint on Form.onFormSubmitted linenr:

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Johan Compagner
ok so the value == null so the value shouldn't be something when you submit it.Please set a breakpoint on Form.onFormSubmitted linenr: 190johanOn 9/11/06, Erik Brakkee <[EMAIL PROTECTED]> wrote: Johan Compagner wrote:> if you could make a case where we can look at?I will try to make a small exampl

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Erik Brakkee
Johan Compagner wrote: > if you could make a case where we can look at? I will try to make a small example tonight. > > What is the hidden fields value (that is an hidden input field > appended to the form) > right before you get the error? The hidden form field is: > > johan > > ---

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Johan Compagner
if you could make a case where we can look at?What is the hidden fields value (that is an hidden input field appended to the form)right before you get the error?johan On 9/11/06, Erik Brakkee <[EMAIL PROTECTED]> wrote: Johan Compagner wrote: Hmm can you give us a test case for this? Because

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Erik Brakkee
Johan Compagner wrote: Hmm can you give us a test case for this? Because if you click on the submitlink that call: wicket.markup.html.form.Form.dispatchEvent(Form.java:1205) shouldn't happen at all. Because there shouldn't be something in this url:     String url = "">             if (

Re: [Wicket-user] SubmitLink and back button...

2006-09-11 Thread Johan Compagner
Hmm can you give us a test case for this?Because if you click on the submitlink that call: wicket.markup.html.form.Form.dispatchEvent(Form.java:1205)shouldn't happen at all. Because there shouldn't be something in this url:     String url = "">            if (!Strings.isEmpty(url))            {