Daimona added a comment.
In T353961#9595560 <https://phabricator.wikimedia.org/T353961#9595560>,
@Lucas_Werkmeister_WMDE wrote:
> Which is a bit of a shame, because @Daimona removed a bunch of inter-table
dependencies like this when introducing ChangedTablesTracke
Daimona added a comment.
In T353957#9424131 <https://phabricator.wikimedia.org/T353957#9424131>,
@Daimona wrote:
> H I don't quite understand why PHPUnit is printing the usage and then
aborting. It's definitely not the first time I'm seeing this, but I can't
remember what
Daimona added a comment.
H I don't quite understand why PHPUnit is printing the usage and then
aborting. It's definitely not the first time I'm seeing this, but I can't
remember what the cause is.
TASK DETAIL
https://phabricator.wikimedia.org/T353957
EMAIL PREFERENCES
https
Daimona added a comment.
In T351709#9348821 <https://phabricator.wikimedia.org/T351709#9348821>,
@Lucas_Werkmeister_WMDE wrote:
> Apparently both affected tests have this pattern: [...]
Indeed, that pattern had already caused some test failures before. I thought
I had
Daimona removed a project: CampaignEvents.
TASK DETAIL
https://phabricator.wikimedia.org/T328497
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: KSiebert, StudiesWorld, Jdforrester-WMF, Aklapper, Krinkle, Catrope,
Legoktm, TrevorParscal
Daimona added a subtask: T351001: Remove unnecessary ResourceLoader targets
definitions from CampaignEvents.
TASK DETAIL
https://phabricator.wikimedia.org/T328497
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: KSiebert, StudiesWorld
Daimona added a comment.
In T340201#9211976 <https://phabricator.wikimedia.org/T340201#9211976>,
@Bawolff wrote:
> - mustache templates
Yup, that would be T199397 <https://phabricator.wikimedia.org/T199397>. I'm
not sure how feasible that would be.
> May
Daimona removed a parent task: T90875: Use vendor/bin/phpunit instead of
tests/phpunit/phpunit.php.
TASK DETAIL
https://phabricator.wikimedia.org/T277464
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: ItamarWMDE, Michael, kostajh, WMDE
Daimona closed this task as "Resolved".
Daimona assigned this task to Lucas_Werkmeister_WMDE.
Daimona added a comment.
All patches merged, Wikibase CI is green, resolving this.
TASK DETAIL
https://phabricator.wikimedia.org/T345372
EMAIL PREFERENCES
https://phabricator.wik
Daimona closed this task as "Resolved".
Daimona assigned this task to Umherirrender.
Daimona added a comment.
This was resolved in r586067
<https://gerrit.wikimedia.org/r/c/mediawiki/core/+/586067> 3 years ago.
TASK DETAIL
https://phabricator.wikimedia.org/T248088
E
Daimona added a subtask: T142120: Remove UnitTestsList hook subscribers, move
tests to be autodiscovered for extensions that have been converted to extension
registration.
TASK DETAIL
https://phabricator.wikimedia.org/T298509
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings
Daimona added a comment.
Just came here to say that I tried running LanguageConverterFactoryTest
(which is super slow, see T50217#9030084
<https://phabricator.wikimedia.org/T50217#9030084>) before and after the
changes in this ticket. It went from 12-13 seconds to 1 second,
Daimona added a comment.
Note that the presence of this hook makes it quite difficult to have a
standard PHPUnit setup (T227900 <https://phabricator.wikimedia.org/T227900>,
T90875 <https://phabricator.wikimedia.org/T90875>), because we need to fully
initialize MediaWiki in
Daimona removed parent tasks: T227900: Phase out usage of
tests/phpunit/suite.xml, T90875: Use vendor/bin/phpunit instead of
tests/phpunit/phpunit.php.
TASK DETAIL
https://phabricator.wikimedia.org/T298509
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
Daimona added a parent task: T227900: Phase out usage of
tests/phpunit/suite.xml.
TASK DETAIL
https://phabricator.wikimedia.org/T298509
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Krinkle, cscott, kostajh, Jdforrester-WMF, Aklapper
Daimona closed this task as "Resolved".
Daimona added a comment.
Local failure is resolved, hence closing this task.
TASK DETAIL
https://phabricator.wikimedia.org/T340928
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
Daimona added a comment.
In T340928#8987551 <https://phabricator.wikimedia.org/T340928#8987551>,
@Lucas_Werkmeister_WMDE wrote:
> In T340928#8984321 <https://phabricator.wikimedia.org/T340928#8984321>,
@Daimona wrote:
>
>> Right, I didn't realize that sin
Daimona claimed this task.
Daimona added a comment.
Right, I didn't realize that since Wikibase doesn't have a single
extension.json file, LocalSettingsGenerator will use the old style
`require_once`, which includes `Wikibase.php`, which provides some overrides
for CI.
I'm going
Daimona added a comment.
Looks like this has to do with the special config
<https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/7c169d33929171fbe2e2460df56c1a0bf95cb2d5/build>
that is injected in Wikimedia CI.
The issue disappears locally if
Daimona added a comment.
Also, note that this test is not failing in CI with MW master. That's why I'm
suggesting it may have to do with config, where it would fail locally because I
have a different config than CI, and it would also fail in CI when not using
phpunit.php because the config
Daimona created this task.
Daimona added projects: Wikidata, MediaWiki-extensions-WikibaseClient.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
In r934707 <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/934707> I'm
trying to get rid of tests/phpunit/phpunit.ph
Daimona added a comment.
In T65632#8945234 <https://phabricator.wikimedia.org/T65632#8945234>,
@matej_suchanek wrote:
> I suspect MediawikiEditFilterHookRunner::getContextForEditFilter
<https://gerrit.wikimedia.org/g/mediawiki/extensi
Daimona edited projects, added Wikidata; removed CampaignEvents.
Daimona added a comment.
Removing #campaignevents
<https://phabricator.wikimedia.org/tag/campaignevents/> as this is not about
the codebase of the extension, adding #wikidata
<https://phabricator.wikimedia.org/tag
Daimona added a comment.
In T293346#8068839 <https://phabricator.wikimedia.org/T293346#8068839>,
@Lydia_Pintscher wrote:
> Is this possible now that we are tagging all UI edits? I don't know if
abuse filter has access to that.
No, unfortunately. AF uses the EditFilterMerg
Daimona added a comment.
I'm not familiar with wikidata, so I'm not sure what's really happening here.
However, this does not seem to be caused by AbuseFilter itself: IIUC, a
wikidata filter is being run on another wiki, but this is NOT happening via the
AbuseFilter's own "global fi
Daimona added a comment.
In T308443#7933248 <https://phabricator.wikimedia.org/T308443#7933248>,
@tstarling wrote:
> - Patch phan. Wastes upstream's time with ancient PHP version issues, and
probably incurs a rebase cost when reapplying the core patch, due to phan
deploym
Daimona closed subtask T304243: Replace (error|warning|success)box in test
cases of AbuseFilter as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T300306
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Stang, Daimona, Krinkle
Daimona added a comment.
In T300306#7778299 <https://phabricator.wikimedia.org/T300306#7778299>,
@Jdlrobson wrote:
> @Daimona message boxes were designed intentionally to not have attributes.
If an element is using custom attributes then there are 3 options:
>
> - M
Daimona added a comment.
My opinion is that these classes should not be removed until we provide
proper replacements. The task description already provides many useful
examples, but there seems to be at least one use case which is not covered,
i.e. when you want a (success|error|warning)box
Daimona added a comment.
Based on my local testing, my guess was right. This was caused by r747596
<https://gerrit.wikimedia.org/r/c/mediawiki/core/+/747596> -- notice how
`$slotRole` is not passed to onEditFilterMergedContent. OTOH, it's really not
that patch's fault, since the par
Daimona added a subtask: T25: Wikibase runs the EditFilterMergedContent
hook with an extra parameter.
TASK DETAIL
https://phabricator.wikimedia.org/T298672
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Bugreporter, Base
Daimona added a parent task: T298672: "Anonymous" users cannot undo changes
related to structured data due to AbuseFilter.
TASK DETAIL
https://phabricator.wikimedia.org/T25
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
C
Daimona updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T25
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, 94rain, Nandana,
Lahi, Gq86
Daimona added a comment.
The first thing that comes to mind is that whoever is firing the
EditFilterMergedContent hook is passing SLOT_MAIN instead of the actual slot
being edited. I'll try to reproduce this locally and see if that's indeed the
reason.
TASK DETAIL
https
Daimona removed a parent task: T261067: Use DI in AbuseFilterHooks.
TASK DETAIL
https://phabricator.wikimedia.org/T25
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, 94rain
Daimona added a comment.
Actually, it's possible to add the parameter to the handler and phan won't
complain. Yet it requires the extension to pick a default, and it looks like a
code smell anyway. Hence, I still believe that this should be fixed in
Wikibase/core.
TASK DETAIL
https
Daimona updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T25
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, 94rain, Nandana,
Lahi, Gq86
Daimona added a parent task: T261067: Use DI in AbuseFilterHooks.
TASK DETAIL
https://phabricator.wikimedia.org/T25
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, 94rain, Nandana
Daimona created this task.
Daimona added projects: Wikidata, MediaWiki-Core-Hooks, AbuseFilter.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Wikibase has its own code
<https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikib
Daimona moved this task from Ready to Product sign-off 落 on the
Community-Tech (CommTech-Sprint-6) board.
Daimona added a comment.
(Not sure where this should go)
TASK DETAIL
https://phabricator.wikimedia.org/T288722
WORKBOARD
https://phabricator.wikimedia.org/project/board/5411
Daimona removed a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T288722
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Aklapper, Daimona, DannyS712, NRodriguez, ldelench_wmf, Invadibot,
maantietaja, SCIdude
Daimona added a comment.
In T285498#7220146 <https://phabricator.wikimedia.org/T285498#7220146>,
@Samwilson wrote:
>> A part which queries Wikidata for bare URLs.
>
> A Sparql query can do this, and perhaps we'd want to query based on missing
reference properties,
Daimona moved this task from In Development to Review/Feedback on the
Community-Tech (CommTech-Sprint-4) board.
Daimona added a comment.
Preliminary investigation
-
What follows is my preliminary investigation on this wish. It is not complete
yet, mostly
Daimona claimed this task.
Daimona moved this task from Ready to In Development on the Community-Tech
(CommTech-Sprint-4) board.
TASK DETAIL
https://phabricator.wikimedia.org/T285498
WORKBOARD
https://phabricator.wikimedia.org/project/board/5383/
EMAIL PREFERENCES
https
Daimona added a comment.
The namespace is explicitly set
<https://phabricator.wikimedia.org/diffusion/EABF/browse/master/includes/AbuseLogger.php$152>
to 0, and has always been. I think this might be due to issues with cross-wiki
references. Things might have improved
Daimona added a parent task: T283216: Cleanup old PHPUnit Class Aliases.
TASK DETAIL
https://phabricator.wikimedia.org/T283457
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana
Daimona created this task.
Daimona added projects: Wikibase-Quality-Constraints, Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
At the time of writing, Wikibase's composer.json has `"data-values/common":
"^1.0.0|^0.4.0|^0.3.0",`, and Wikiba
Daimona added a comment.
In T278011#6934730 <https://phabricator.wikimedia.org/T278011#6934730>,
@Lucas_Werkmeister_WMDE wrote:
> Nope, too early :D
>
>> 12:11:10 Tests: 4319, Assertions: 14540, **Errors: 63, Failures: 14**,
Skipped: 276.
>
> But le
Daimona added a project: MediaWiki-extensions-WikibaseRepository.
Restricted Application added a project: Wikidata.
TASK DETAIL
https://phabricator.wikimedia.org/T278011
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Aklapper
Daimona claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T277859
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Ladsgroup, Addshore, Aklapper, maantietaja, Akuckartz, darthmon_wmde,
94rain, Nandana, Lahi, Gq86, Daimona
Daimona added a comment.
Even if it isn't an opcache corruption, it might still be a PHP bug. In
principle it might make sense to report it upstream, but since we're using PHP
7.2 (no longer supported), I think we should first see if this still happens
after upgrading to a supported version
Daimona updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T269757
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Aklapper, Akuckartz, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE,
GoranSMilovanovic
Daimona created this task.
Daimona added a project: Wikibase-Quality-Constraints.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
Copying from T269756 <https://phabricator.wikimedia.org/T269756>:
The exten
Daimona created this task.
Daimona added projects: Wikidata.org, Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
The extension's composer.json reads:
"php": ">=5.5.9"
But the code is already using PHP 7.1 nullable types, as sp
Daimona added a comment.
Well done everybody! Should another task be created about the removal of
PHPUnit4CompatTrait
<https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/574a68116410b531c8b3f7952c5e866ec3cfd4c8/repo/tests/phpunit/includes/Parsers/PHPUnit4CompatTrait.
Daimona added a comment.
In T265091#6586803 <https://phabricator.wikimedia.org/T265091#6586803>,
@Reedy wrote:
> In T265091#6586789 <https://phabricator.wikimedia.org/T265091#6586789>,
@Daimona wrote:
>
>> Dupe of T264926 <https://phabricator.wikimedia.or
Daimona added a comment.
Dupe of T264926 <https://phabricator.wikimedia.org/T264926>?
TASK DETAIL
https://phabricator.wikimedia.org/T265091
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Aklapper, Reedy, Akuckartz, Dan
Daimona added a comment.
There seem to be more flaky test, not only in WB but also elsewhere (e.g.
AbuseFilter and FileImporter at least). I'm convincing myself that it might be
a wdio bug, as per comments at T264926
<https://phabricator.wikimedia.org/T264926>.
TASK DETAIL
Daimona triaged this task as "High" priority.
Daimona added a comment.
I'm seeing this error more and more, e.g. today on r629233
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/629233>.
I'm unsure about the status for other gated extensions, but it's
Daimona created this task.
Daimona added projects: MediaWiki-extensions-WikibaseClient, ci-test-error
(WMF-deployed Build Failure).
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
Recently I've been consistently facing
Daimona added a project: TestMe.
Daimona added a comment.
Based on a couple random edits on wikidata, this seems to be working
correctly now. Leaving open for confirmation. If it's still broken, this task
can be considered for the upcoming overhaul.
TASK DETAIL
https
Daimona closed this task as "Resolved".
Daimona assigned this task to Jakob_WMDE.
Daimona added a project: phan.
Daimona added a comment.
Fixed with
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/602735/
Aside, we might conside
Daimona added a comment.
In T250338#6170464 <https://phabricator.wikimedia.org/T250338#6170464>,
@DannyS712 wrote:
> @Daimona or another phan expert - would you be willing to take a look at
the wikibase phan failure?
It's coming from an array property, so likely a false
Daimona added a comment.
In T250720#6073559 <https://phabricator.wikimedia.org/T250720#6073559>,
@Ahmad252 wrote:
> In T250720#6072828 <https://phabricator.wikimedia.org/T250720#6072828>,
@Daimona wrote:
>
>> Haven't checked deeply, but a possible hin
Daimona closed this task as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T250570
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: matej_suchanek, Daimona, DannyS712, Aklapper, darthmon_wmde, 94rain,
Nandana,
Daimona added a comment.
Haven't checked deeply, but a possible hint is that AF doesn't see automatic
edit summaries (I think there was a task for that) which, however, it sees when
retrospectively examinating edits.
TASK DETAIL
https://phabricator.wikimedia.org/T250720
EMAIL PREFERENCES
Daimona claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T250570
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: matej_suchanek, Daimona, DannyS712, Aklapper, Blissjay007, Oblanco79,
Alter-paule, Beast1978, Un1tY, Hook696
Daimona added a comment.
In T250570#6068356 <https://phabricator.wikimedia.org/T250570#6068356>,
@Daimona wrote:
> Or actually, I think it's because checking `getType() == UNDEFINED` (at
least in callKeyword and callFunc, perhaps elsewhere) doesn't work well for
arrays (i
Daimona added a comment.
Or actually, I think it's because checking `getType() == UNDEFINED` (at least
in callKeyword and callFunc, perhaps elsewhere) doesn't work well for arrays
(it doesn't recurse).
Adding AFPData::hasUndefined() as a recursive method would be the solution.
TASK
Daimona added a comment.
I think explicit casts aren't special-cased in the DUNDEFINED check, should
be an easy fix
TASK DETAIL
https://phabricator.wikimedia.org/T250570
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona
Daimona renamed this task from "AFPException when saving filter on wikidata" to
"AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to
something else".
Daimona updated the task description.
Daimona edited Stack Trace.
TASK DETAIL
https://phabricator.w
Daimona merged a task: T247806: Make WikibaseLexeme compatible with PHP 7.4.
Daimona added subscribers: Jdforrester-WMF, Reedy, Aklapper.
TASK DETAIL
https://phabricator.wikimedia.org/T247782
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc
Daimona added a comment.
Not because of PHP 7.4 :-[
TASK DETAIL
https://phabricator.wikimedia.org/T247806
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Reedy, Aklapper, Jdforrester-WMF, darthmon_wmde, Nandana,
Mringgaard
Daimona closed this task as a duplicate of T247782: WikibaseLexeme CI broken
due to Title constructor being private.
TASK DETAIL
https://phabricator.wikimedia.org/T247806
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Reedy, Aklapper
Daimona added a comment.
Meh, I thought these test-only errors would have been spotted by the wmf-gate
jobs. Sorry for the breakage :(
TASK DETAIL
https://phabricator.wikimedia.org/T247782
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Daimona added a comment.
It doesn't seem a recent regression, see
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+blame/de5e309c258b121bf0626728d8d9a6fd2ab0c717/client/tests/phpunit/includes/ClientParserOutputDataUpdaterTest.php#170
The fix should be as easy
Daimona added a comment.
Now it should be compatible. Can we enable PHP74 tests as voting?
TASK DETAIL
https://phabricator.wikimedia.org/T247595
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Aklapper, darthmon_wmde, Nandana
Daimona added a comment.
In T243590#5962809 <https://phabricator.wikimedia.org/T243590#5962809>,
@Jdforrester-WMF wrote:
> Is this the same set of issues that emit errors in the CI run?
Apparently, no. Filed T247595 <https://phabricator.wikimedia.org/T247595> for
tha
Daimona created this task.
Daimona added projects: PHP 7.4 support, Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
From T243590#5962809 <https://phabricator.wikimedia.org/T243590#5962809>:
00:18:23.529 There were 3 errors:
00:18:23.529
Daimona added a comment.
That change is not responsible, but the extension is broken:
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/47112/artifact/log/mw-error.log
TASK DETAIL
https://phabricator.wikimedia.org/T245629
EMAIL PREFERENCES
https
Daimona added a comment.
In T237164#5896034 <https://phabricator.wikimedia.org/T237164#5896034>,
@Addshore wrote:
> It looks like that was removed in
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/552166/ but not linked to
this ticket.
Ah, thanks, I forgot about
Daimona added a comment.
For some reason, cache/integration-tests is not being installed, see
https://integration.wikimedia.org/ci/job/wikibase-repo-docker/11815/console.
This used to work before the test was disabled.
Also, the library is currently broken: its public interface is using
Daimona added a comment.
In T243296#5829712 <https://phabricator.wikimedia.org/T243296#5829712>,
@Addshore wrote:
> I'm going to go around and update this in various places that it is used.
I can help with review.
> Also going forward we will consider if
Daimona added a comment.
In T237164#5827203 <https://phabricator.wikimedia.org/T237164#5827203>,
@Jdforrester-WMF wrote:
> Is this going anywhere, or are we just going to leave it disabled forever?
I guess it's going to sit in the bitrot limbo until a new version is
Daimona added a comment.
Not if we move the main ruleset file per T243296#5826268
<https://phabricator.wikimedia.org/T243296#5826268>. And, of course, unless it
turns out to be impossible to have two different rulesets in MW-CS.
TASK DETAIL
https://phabricator.wikimedia.org/T243296
Daimona added a comment.
In T243296#5826260 <https://phabricator.wikimedia.org/T243296#5826260>,
@Lucas_Werkmeister_WMDE wrote:
> (Unless “Move the WB ruleset to MW-CS” includes disabling those rules for
all of MW-CS?)
Sort of, yes. I believe it's possible to have two
Daimona added a comment.
In T243296#5821602 <https://phabricator.wikimedia.org/T243296#5821602>,
@Legoktm wrote:
> I think we could ship it inside the MediaWiki-Codesniffer repo so it
doesn't fall behind at least.
I think this is a great idea to get started with. I guess
Daimona added subscribers: Ladsgroup, Daimona.
Daimona added a comment.
CC @Ladsgroup as releaser of the last two versions and (AFAICS) most active
maintainer.
TASK DETAIL
https://phabricator.wikimedia.org/T243296
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
Daimona raised the priority of this task from "Medium" to "Unbreak Now!".
Daimona added a comment.
In T243122#5814763 <https://phabricator.wikimedia.org/T243122#5814763>,
@Physikerwelt wrote:
> I think this is not ubn. Why not disable the test?
B
Daimona added a project: MediaWiki-extensions-PropertySuggester.
TASK DETAIL
https://phabricator.wikimedia.org/T243124
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Aklapper, Reedy, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic
Daimona added a parent task: T233864: 1.35.0-wmf.16 deployment blockers.
TASK DETAIL
https://phabricator.wikimedia.org/T243122
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Aklapper, Daimona, darthmon_wmde, Nandana, Lahi, Gq86
Daimona created this task.
Daimona added projects: Math, Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
As observed in r565622
<https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Math/+/565622/>, tests
currently fail on Math because of:
>
Daimona added a comment.
In T240884#5810160 <https://phabricator.wikimedia.org/T240884#5810160>,
@sbassett wrote:
> In T240884#5810094 <https://phabricator.wikimedia.org/T240884#5810094>,
@Ladsgroup wrote:
>
>> One complicating factor here is that AbuseFilte
Daimona added a comment.
In T241947#5802594 <https://phabricator.wikimedia.org/T241947#5802594>,
@Addshore wrote:
> Well, RequestContext::getMain is slightly less evil that the global
probably.
Yeah, well, a little bit... I believe the only difference is that, w
Daimona added a comment.
In T241947#5802562 <https://phabricator.wikimedia.org/T241947#5802562>,
@Addshore wrote:
> In T241947#5776623 <https://phabricator.wikimedia.org/T241947#5776623>,
@Daimona wrote:
>
>> Note: there are two usages in the entry point whi
Daimona added a comment.
Note: there are two usages in the entry point which I'm unsure how to fix.
TASK DETAIL
https://phabricator.wikimedia.org/T241947
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Daimona, Aklapper, Hook696
Daimona created this task.
Daimona added projects: Technical-Debt (Deprecation process),
MediaWiki-extensions-WikibaseRepository.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
TASK DETAIL
https
Daimona edited projects, added MediaWiki-Special-pages; removed Wikidata,
MediaWiki-extensions-Diff.
TASK DETAIL
https://phabricator.wikimedia.org/T239265
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Aklapper, Daimona, Amorymeltzer
Daimona created this task.
Daimona added projects: Wikimedia-production-error, MediaWiki-extensions-Diff.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
Error
-
`MediaWiki version:` **`1.35.0-wmf.5
Daimona closed this task as "Resolved".
Daimona removed a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T235326
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daimona
Cc: Ladsgroup, Lucas_Werkmeister_WMDE,
1 - 100 of 160 matches
Mail list logo
