[Wikidata-bugs] [Maniphest] [Updated] T169638: Option to Show and Hide Wikidata edits on RecentChanges is not working according to user or wiki preferences
Krinkle added a project: Edit-Review-Improvements-RC-Page.Herald added a project: Collaboration-Team-Triage. TASK DETAILhttps://phabricator.wikimedia.org/T169638EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Trizek-WMF, Aklapper, GoranSMilovanovic, QZanden, Iniquity, jmatazzoni, Izno, SBisson, Wikidata-bugs, aude, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, KrinkleCc: PokestarFan, Agabi10, gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Minhnv-2809, Zppix, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Krinkle added commits: rEWBA0df49eeaf49d: Use multi-page RefreshLinksJobs in WikiPageUpdater, rEWBA4d8e2b80d700: Use HTMLCacheUpdateJob instead of invalidateCache, rEWBA172b739396bd: Remove overengineered page update code from ChangeHandler, rEWBA2987fe5bcf62: Move injection of RC records to a separate job., rEWBA24d45d6d0cfc: Wait for replication after adding RC entries in WikiPageUpdater. TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, KrinkleCc: Jrbranaa, PokestarFan, Agabi10, gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Minhnv-2809, Zppix, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, KrinkleCc: Jrbranaa, PokestarFan, Agabi10, gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Minhnv-2809, Zppix, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.Herald added a subscriber: PokestarFan. TASK DETAILhttps://phabricator.wikimedia.org/T124418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: PokestarFan, Gilles, GWicke, ArielGlenn, Krinkle, Peter, EBernhardson, Smalyshev, gerritbot, Legoktm, daniel, hoo, aude, Lydia_Pintscher, JanZerebecki, MZMcBride, Luke081515, aaron, faidon, Joe, ori, BBlack, Aklapper, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Zppix, Izno, Wikidata-bugs, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T70567: Make EntityView UI aware of redirects
Krinkle removed a project: MediaWiki-Redirects.Herald added a subscriber: PokestarFan. TASK DETAILhttps://phabricator.wikimedia.org/T70567EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: PokestarFan, thiemowmde, adrianheine, aude, Snaterlicious, Lydia_Pintscher, daniel, JohnLewis, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T54564: Allow sitelinks to redirect pages to fix the 'Bonnie and Clyde problem'
Krinkle removed a project: MediaWiki-Redirects. TASK DETAILhttps://phabricator.wikimedia.org/T54564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Eugene, PokestarFan, ArthurPSmith, Pasleim, StudiesWorld, daniel, Metamorforme42, JEumerus, Harmonia_Amanda, Ash_Crow, DannyH, Agabi10, Choomaq, IKhitron, QZanden, thiemowmde, Toto256, Acer, Elitre, Sylvain_WMFr, Lea_Lacroix_WMDE, Schlum, TomT0m, Thryduulf, Rich_Farmbrough, Zppix, ChristianKl, Mike_Peel, Wittylama, Liuxinyu970226, SebastianHelm, MisterSynergy, Oliv0, JanusTroelsen, Blahma, MGChecker, MSGJ, Izno, Nnemo, bzimport, Unknown Object (MLST), DanielFriesen, Gymel, Denny, jeblad, Abraham, Addshore, SamB, Toru10, Wikidata-bugs, JAnD, Nemo_bis, He7d3r, -jem-, ValterVB, Filceolaire, Micru, JanZerebecki, matej_suchanek, Ricordisamoa, MZMcBride, Aklapper, Tgr, kaldari, Laddo, Lydia_Pintscher, Jane023, Ltrlg, JohnLewis, Fomafix, Zellfaze, GoranSMilovanovic, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
Krinkle closed this task as "Resolved".Krinkle added a comment. Fixed. The hit rate dropped to 0 for this warning in Logstash as of August 17. (Presumably due to all wikis to 1.30.0-wmf.14)TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: mmodell, Addshore, demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
Krinkle closed subtask T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope" as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, KrinkleCc: Stashbot, TerraCodes, Jay8g, Liuxinyu970226, thcipriani, Jrbranaa, PokestarFan, Agabi10, gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Minhnv-2809, Zppix, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T154596: SpecialModifyEntity master queries on page views
Krinkle edited projects, added Availability (Multiple-active-datacenters); removed Multiple-active-datacenters. TASK DETAILhttps://phabricator.wikimedia.org/T154596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, KrinkleCc: Catrope, Joe, Krenair, PleaseStand, gerritbot, Aklapper, Gilles, Nemo_bis, MZMcBride, Glaisher, Johan, daniel, Amire80, aaron, 45Jayjay1969, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T154596: SpecialModifyEntity master queries on page views
Krinkle edited projects, added Multiple-active-datacenters; removed Wikimedia-Multiple-active-datacenters, Availability. TASK DETAILhttps://phabricator.wikimedia.org/T154596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, KrinkleCc: Catrope, Joe, Krenair, PleaseStand, gerritbot, Aklapper, Gilles, Nemo_bis, MZMcBride, Glaisher, Johan, daniel, Amire80, aaron, 45Jayjay1969, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T117272: Wikidata: Possibility to add comments with more than 255 bytes, potential db issue
Krinkle changed the title from "Wikidata: Possibilty to add comments with more than 255 bytes, potenzial db issue" to "Wikidata: Possibility to add comments with more than 255 bytes, potential db issue".Krinkle edited projects, added DBA; removed MediaWiki-Database. TASK DETAILhttps://phabricator.wikimedia.org/T117272EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lydia_Pintscher, StudiesWorld, jcrespo, csteipp, Bawolff, Aklapper, Luke081515, QZanden, Marostegui, Minhnv-2809, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T162594: Introduce MessageLocalizer interface to remove the need to depend on IContextSource for creating Message objects
Krinkle added a comment. To avoid reliance on global state, and dragging in the kitchen sink that is IContextSource, a narrow interface called MessageLocalizer should be introduced [..] Calling code that only needs the msg() method can then start using MessageLocalizer instead of IContextSource [..] This allows testing and re-use of such components without the need to construct or get an IContextSource from global state. I think this exaggerates the problem a bit. Creating a Message object requires two things: An interface language, and a title. (Defaults from global User and wgTitle) When a class doesn't (and shouldn't) involve a context source, you construct Message directly (or wfMessage). When the class has sensible values for these two requirements (language, title), one can create a convenience wrapper by defining a local msg method. I doubt anyone would extend ContextSource for a class just to get a msg() method. That seems rather unnecessary. I would not consider that acceptable for code in MediaWiki core. I don't particularly mind a MessageLocalizer interface existing, but want to make sure the rationale is not "Avoiding global state" or "Avoiding context source". The rationale is standardising the method name and parameters with a centralised interface. I am skeptical of these kinds of interfaces as it usually doesn't end up being used. We'd specify the interface whenever we add such method, but never use it anywhere. It would help to have an example use case where a method would use MessageLocalizer as parameter type, or in what scenario one would want to instanceof-check for it?TASK DETAILhttps://phabricator.wikimedia.org/T162594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, KrinkleCc: Krinkle, Nemo_bis, Agabi10, gerritbot, Ladsgroup, Aklapper, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, MuhammadShuaib, Izno, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, KartikMistry, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T140879: 503 error raises again while trying to load a Wikidata page
Krinkle edited projects, added Wikidata; removed MediaWiki-General-or-Unknown. TASK DETAILhttps://phabricator.wikimedia.org/T140879EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: jcrespo, Aklapper, abian, Zppix, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Izno, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T168696: Add test for Wikibase parser tag hooks
Krinkle created this task.Krinkle added projects: Wikimedia-Incident, Wikidata, MediaWiki-extensions-WikibaseClient.Herald added a subscriber: Aklapper. TASK DESCRIPTIONFollows-up on: T167238: Fatal Error: "Tag hook for noexternallanglinks is not callable" (1.30.0-wmf.4/includes/parser/Parser.php) https://gerrit.wikimedia.org/r/357523 (which fixed breakage from https://gerrit.wikimedia.org/r/356174 I believe this is the third or fourth time a fatal error from Wikibase parser hooks made its way to production. Localisation update, magic word corruption, and others. This time it was just broken code that never worked. Ideally, QA processes would have caught this post-merge, but perhaps it's uncommon or hard to test in beta. Either way, it seems this code is overdue to have a basic integration test or unit test so that it executes at least once.TASK DETAILhttps://phabricator.wikimedia.org/T168696EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g, greg, mmodell___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126361: Wrong style of Table of Contents displays when saving a page at Wikivoyage
Krinkle added a comment. In T126361#3287295, @Jdlrobson wrote: Im somewhat hopeful T130632 will fix this. In T126361#3287353, @gerritbot wrote: Change 355274 had a related patch set uploaded (by Krinkle; owner: Krinkle): [mediawiki/extensions/WikidataPageBanner@master] Use ParserOutput::setTOCEnabled instead of OutputPage::enableTOC https://gerrit.wikimedia.org/r/355274 Indeed. T130632 moves the logic of loading mediawiki.toc from Parser to Skin. It also removes support to toggle TOC via OutputPage. Instead, this should happen via ParserOutput directly (via the same hook). This way it will also be considered by EditPage Preview, Live Preview, and the Parse API – which is what Parsoid and VisualEditor use.TASK DETAILhttps://phabricator.wikimedia.org/T126361EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, gerritbot, Elitre, Jdlrobson, Aklapper, Whatamidoing-WMF, Robinma, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, Winter, Lewizho99, Maathavan, Wess, Izno, Jrf, Husun1297, Wikidata-bugs, aude, Swainr, Lydia_Pintscher, Jdforrester-WMF, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T114577: [Task] Move PopulateInterwiki into MediaWiki (core)
Krinkle removed projects: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Patch-For-Review.Krinkle closed this task as "Resolved".Krinkle assigned this task to aude. TASK DETAILhttps://phabricator.wikimedia.org/T114577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aude, KrinkleCc: gerritbot, Addshore, daniel, aude, Aklapper, hoo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan
Krinkle added a comment. In T124418#3276610, @BBlack wrote: Not resolved, as the purge graphs can attest! Which graphs? This issue is about a "massive increase" observed between December 2015 and January 2016, however our graphs don't go back far enough. It seems data prior to June 2016 has been wiped. https://grafana-admin.wikimedia.org/dashboard/db/job-queue-rate?orgId=1=htmlCacheUpdate=now-2y=now F8180982: Screen Shot 2017-05-25 at 16.40.47.png From a quick look through this task I also couldn't find any absolute numbers from before this point to compare against, so I don't know what we're aiming for or what we're investigating here.TASK DETAILhttps://phabricator.wikimedia.org/T124418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: GWicke, ArielGlenn, Krinkle, Peter, EBernhardson, Smalyshev, gerritbot, Legoktm, daniel, hoo, aude, Lydia_Pintscher, JanZerebecki, MZMcBride, Luke081515, aaron, faidon, Joe, ori, BBlack, Aklapper, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Zppix, Izno, Wikidata-bugs, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T155043: "Don't initialize MWServices super early" causes test failure on .7
Krinkle removed a project: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)). TASK DETAILhttps://phabricator.wikimedia.org/T155043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Reedy, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T126077: html continues to say "Editing..." after I saved an edit using VisualEditor (and interwiki links are gone)
Krinkle removed a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)). TASK DETAILhttps://phabricator.wikimedia.org/T126077EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Mrjohncummings, APerson, jeblad, Dvorapa, Izno, Jdforrester-WMF, gerritbot, Aklapper, StudiesWorld, aude, Robinma, GoranSMilovanovic, QZanden, merbst, Wess, Jrf, Husun1297, Wikidata-bugs, Swainr, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T160140: Wikidata accepts invalid geo coordinates, causing indexing failures
Krinkle edited projects, added MW-1.29-release-notes; removed MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T160140EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Liuxinyu970226, gerritbot, aude, Smalyshev, Deskana, thiemowmde, daniel, Lydia_Pintscher, Aklapper, MaxSem, EBernhardson, GoranSMilovanovic, QZanden, EBjune, Avner, debt, Gehel, FloNight, Izno, Wikidata-bugs, jayvdb, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan
Krinkle added a comment. In T124418#3302573, @BBlack wrote: In T124418#1985526, @BBlack wrote: Continuing with some stuff I was saying in IRC the other day. At the "new normal", we're seeing something in the approximate ballpark of 400/s articles purged (which is then multiplied commonly for ?action="" and mobile and ends up more like ~1600/s actual HTCP packets), whereas the edit rate across all projects is something like 10/s. That 400/s number used to be somewhere south of 100 before December. In T124418#1986594, @BBlack wrote: Regardless, the average rate of HTCP these days is normally-flat-ish (a few scary spikes aside), and is mostly throttled by the jobqueue. The question still remains: what caused permanent, large bumps in the jobqueue htmlCacheUpdate insertion rate on ~Dec4, ~Dec11, and ~Jan20? Just to confirm, you're saying before December 2015, the purge rate was below 100/s, and has since then been around ~ 400/s. It'd be nice to have some recent numbers as well, created using the same method as then. Some of my own: cp4008:~$ varnishtop -I 'ReqMethod:PURGE' -p 1 cp1055:~$ varnishtop -I 'ReqMethod:PURGE' -p 1 I found numbers typically to be between 900 and 4000 per second.TASK DETAILhttps://phabricator.wikimedia.org/T124418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: GWicke, ArielGlenn, Krinkle, Peter, EBernhardson, Smalyshev, gerritbot, Legoktm, daniel, hoo, aude, Lydia_Pintscher, JanZerebecki, MZMcBride, Luke081515, aaron, faidon, Joe, ori, BBlack, Aklapper, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Zppix, Izno, Wikidata-bugs, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T147798: Wikibase repo UI is sometimes not properly starting up (on Firefox)
Krinkle removed a project: Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T147798EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, KrinkleCc: Gilles, ori, Aklapper, Krinkle, aude, thiemowmde, Jonas, Lydia_Pintscher, Tobi_WMDE_SW, hoo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T167360: "Warning: in_array() expects parameter 2 to be an array or collection" from Wikibase MwTimeIsoFormatter
Krinkle renamed this task from "Warning: in_array() expects parameter 2 to be an array or collection" to ""Warning: in_array() expects parameter 2 to be an array or collection" from Wikibase MwTimeIsoFormatter". TASK DETAILhttps://phabricator.wikimedia.org/T167360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, aude, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T167238: Fatal Error: "Tag hook for noexternallanglinks is not callable" (1.30.0-wmf.4/includes/parser/Parser.php)
Krinkle created this task.Krinkle added projects: Wikidata, Wikimedia-log-errors.Herald added subscribers: Jay8g, TerraCodes.
TASK DESCRIPTIONhttps://test2.wikipedia.org/wiki/Main_Page?
[WTc6bApAEKkAADjb1VEF] /wiki/Main_Page MWException from line 3382 of /srv/mediawiki/php-1.30.0-wmf.4/includes/parser/Parser.php: Tag hook for noexternallanglinks is not callable
Backtrace:
#0 /srv/mediawiki/php-1.30.0-wmf.4/includes/parser/Parser.php(3136): Parser->callParserFunction(PPFrame_Hash, string, array)
#1 /srv/mediawiki/php-1.30.0-wmf.4/includes/parser/Preprocessor_Hash.php(1072): Parser->braceSubstitution(array, PPFrame_Hash)
#2 /srv/mediawiki/php-1.30.0-wmf.4/includes/parser/Parser.php(2950): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#3 /srv/mediawiki/php-1.30.0-wmf.4/includes/parser/Parser.php(1305): Parser->replaceVariables(string)
#4 /srv/mediawiki/php-1.30.0-wmf.4/includes/parser/Parser.php(451): Parser->internalParse(string)
#5 /srv/mediawiki/php-1.30.0-wmf.4/includes/content/WikitextContent.php(330): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#6 /srv/mediawiki/php-1.30.0-wmf.4/includes/content/AbstractContent.php(497): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#7 /srv/mediawiki/php-1.30.0-wmf.4/includes/poolcounter/PoolWorkArticleView.php(140): AbstractContent->getParserOutput(Title, integer, ParserOptions)
#8 /srv/mediawiki/php-1.30.0-wmf.4/includes/poolcounter/PoolCounterWork.php(123): PoolWorkArticleView->doWork()
#9 /srv/mediawiki/php-1.30.0-wmf.4/includes/page/Article.php(586): PoolCounterWork->execute()
#10 /srv/mediawiki/php-1.30.0-wmf.4/includes/actions/ViewAction.php(68): Article->view()
#11 /srv/mediawiki/php-1.30.0-wmf.4/includes/MediaWiki.php(499): ViewAction->show()
#12 /srv/mediawiki/php-1.30.0-wmf.4/includes/MediaWiki.php(293): MediaWiki->performAction(Article, Title)
#13 /srv/mediawiki/php-1.30.0-wmf.4/includes/MediaWiki.php(862): MediaWiki->performRequest()
#14 /srv/mediawiki/php-1.30.0-wmf.4/includes/MediaWiki.php(523): MediaWiki->main()
#15 /srv/mediawiki/php-1.30.0-wmf.4/index.php(43): MediaWiki->run()
#16 /srv/mediawiki/w/index.php(3): include(string)
#17 {main}TASK DETAILhttps://phabricator.wikimedia.org/T167238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: TerraCodes, Aklapper, Krinkle, Jay8g, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T167238: Fatal Error: "Tag hook for noexternallanglinks is not callable" (1.30.0-wmf.4/includes/parser/Parser.php)
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION<https://test2.wikipedia.org/wiki/Main_Page?> ```...TASK DETAILhttps://phabricator.wikimedia.org/T167238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: TerraCodes, Aklapper, Krinkle, Jay8g, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T162594: Introduce MessageLocalizer interface to remove the need to depend on IContextSource for creating Message objects
Krinkle added a comment. In T162594#3347436, @daniel wrote: In T162594#3341141, @Krinkle wrote: I doubt anyone would extend ContextSource for a class just to get a msg() method. That seems rather unnecessary. I would not consider that acceptable for code in MediaWiki core. Well, using subclassing for this kind of thing shouldn't be done anyway. So in Wikibase, we use composition - that is, we inject a factory service. Defining an interface for that factory is what this ticket is about. I see now. The point being that you can inject a class with a msg method into something without that class needing to know what language to be used, or why (e.g. content/user/arbitrary language) and pre-configuring other parameters to Message (useDatabase, title, interface, etc.).TASK DETAILhttps://phabricator.wikimedia.org/T162594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, KrinkleCc: Nikerabbit, Krinkle, Nemo_bis, Agabi10, gerritbot, Ladsgroup, Aklapper, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, MuhammadShuaib, Izno, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, KartikMistry, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126361: When editing via VisualEditor Wrong style of Table of Contents displays when saving a page at Wikivoyage
Krinkle added a comment. The fix for this was the same as for mediawiki.toc loading in MobileFrontend and depends on a 5-patch stack in MediaWiki core - which was merged after the branch cut this week, so it'll roll out next week. Can you reproduce it in beta?TASK DETAILhttps://phabricator.wikimedia.org/T126361EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, gerritbot, Elitre, Jdlrobson, Aklapper, Whatamidoing-WMF, Robinma, GoranSMilovanovic, QZanden, merbst, Winter, Wess, Dvorapa, Izno, Jrf, Husun1297, Wikidata-bugs, Ryasmeen, aude, jeblad, Swainr, Lydia_Pintscher, TheDJ, Jdforrester-WMF, Mbch331, Jay8g, Ltrlg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T169023: Wikibase ontology url: wikiba.se or wikidata.org?
Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...Looking further it seems that most references to this concept in XML files actually use http://wikiba.se/ontology not wikidata.org, although there are a few references to http://www.wikidata.org/ontology on the web.
In fact, using Google, I find 1,800 references to `wikiba.se/ontology`, 4,000 references to `www.wikidata.org/ontology`, and over 12,000 references to `wikidata.org/ontology`.
* Has the canonical url moved to wikiba.se?...* {T112127}
* {T112042}
* {T99820}TASK DETAILhttps://phabricator.wikimedia.org/T169023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Zppix, Izno, Wikidata-bugs, aude, JeroenDeDauw, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T169023: Wikibase ontology url: wikiba.se or wikidata.org?
Krinkle edited projects, added Wikibase-DataModel; removed Wikibase-Internal-Serialization. TASK DETAILhttps://phabricator.wikimedia.org/T169023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Zppix, Izno, Wikidata-bugs, aude, JeroenDeDauw, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T169023: Wikibase ontology url: wikiba.se or wikidata.org?
Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* {T166299}
* {T112127}TASK DETAILhttps://phabricator.wikimedia.org/T169023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Zppix, Izno, Wikidata-bugs, aude, JeroenDeDauw, faidon, Mbch331, Jay8g, fgiunchedi___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T169023: Wikibase ontology url: wikiba.se or wikidata.org?
Krinkle added a comment. Based on T93207: Decide which domain to use for the wikibase ontology URI, I've changed this task to instead be a clean up task to remove the broken wikidata.org alias. It already doesn't work.TASK DETAILhttps://phabricator.wikimedia.org/T169023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Zppix, Izno, Wikidata-bugs, aude, JeroenDeDauw, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan
Krinkle added a parent task: T175897: Audit and improve JobQueue performance (2017). TASK DETAILhttps://phabricator.wikimedia.org/T124418EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: PokestarFan, Gilles, GWicke, ArielGlenn, Krinkle, Peter, EBernhardson, Smalyshev, gerritbot, Legoktm, daniel, hoo, aude, Lydia_Pintscher, JanZerebecki, MZMcBride, Luke081515, aaron, faidon, Joe, ori, BBlack, Aklapper, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Zppix, Izno, Wikidata-bugs, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop
Krinkle added a parent task: T175897: Audit and improve JobQueue performance (2017). TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tbayer, mobrovac, Nikerabbit, Mholloway, Legoktm, ema, Joe, GWicke, Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Daniel_Mietchen, XXN, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, Vali.matei, Avner, Lewizho99, Zppix, Maathavan, debt, Gehel, FloNight, Izno, Eevans, Hardikj, Wikidata-bugs, aude, jayvdb, faidon, Mbch331, Jay8g, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T163551: Huge number of duplicate rows in wb_terms
Krinkle added a comment.
When editing a page in VisualEditor, I sometimes notice that the description (from Wikidata's pageterms API) is duplicated. I results in the following rendering:
F9586347: Screen Shot 2017-09-16 at 20.51.29.png
The joining by a single comma also looks odd, but is possibly a bug in VisualEditor (depending on whether or not this value is meant to be an array or not, if meant to be a string, then the silent conversion to string is to be expected).
Underlying query: https://en.wikipedia.org/w/api.php?action="">
{
"query": {
"pages": {
"1351345": {
"pageid": 1351345,
"ns": 0,
"title": "Momo (food)",
"terms": {
"description": [
"Nepalese and Indian cuisine originated in Nepal",
"Nepalese and Indian cuisine originated in Nepal"
]
}
"contentmodel": "wikitext",
"pagelanguage": "en",
"pagelanguagehtmlcode": "en",
"pagelanguagedir": "ltr",
"touched": "2017-09-12T13:36:49Z",
"lastrevid": 800270184,
"length": 8406,
"thumbnail": {
"source": "https://upload.wikimedia.org/wikipedia/commons/thumb/a/a1/Momo_nepal.jpg/80px-Momo_nepal.jpg",
"width": 80,
"height": 58
},
"pageimage": "Momo_nepal.jpg"
}
}
},
"batchcomplete": ""
}TASK DETAILhttps://phabricator.wikimedia.org/T163551EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, KrinkleCc: Krinkle, Ladsgroup, gerritbot, daniel, Smalyshev, jcrespo, aude, Aklapper, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T163551: Huge number of duplicate rows in wb_terms
Krinkle added a comment. In T163551#3612317, @Lydia_Pintscher wrote: That's definitely not how it should be. There should only ever be one description for a given item and language. Is this also caused by the duplicate rows? I'm not sure. I was gonna file a new task, but found this existing task instead. I suppose the end-result of duplicate values return via the API could be caused by a different bug as well, it looks like this bug would also cause it. And while a potential fix was provided for new submissions, I don't see any record of existing items having been fixed.TASK DETAILhttps://phabricator.wikimedia.org/T163551EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, KrinkleCc: Lydia_Pintscher, Krinkle, Ladsgroup, gerritbot, daniel, Smalyshev, jcrespo, aude, Aklapper, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T174922: Decide what to do with Wikibase JS-only libraries regarding the build/deployment of Wikidata code
Krinkle added a comment. In T174922#3583384, @WMDE-leszek wrote: One concern with the Option 5 I could imagine is that the separation between those libs and the "core" Wikibase is drawn less strict than e.g. when those libs are only pulled in when "building" Wikibase & co (option 4), or when they're technically separate git repos/submodules (option 3). In addition to the static analysis test @Legoktm suggested, this can also be enforced through unit tests. If the libraries have working unit tests that can be run in these separate repos, they can continue to be run that way when in the Wikibase repo. There shouldn't be any need to run them via MediaWiki QUnit. Check out https://github.com/wikimedia/oojs and https://github.com/wikimedia/unicodejs for examples of simple npm-test libraries that don't involve MediaWiki. The only thing needed is to have the main package.json's test script also execute tests for the individual libraries. This could be as simple as npm install && npm test in each lib directly, or more elaborate/fine-tuned.TASK DETAILhttps://phabricator.wikimedia.org/T174922EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: JeroenDeDauw, Krinkle, Aklapper, Addshore, Legoktm, greg, Lydia_Pintscher, daniel, thiemowmde, Aleksey_WMDE, Jonas, hoo, aude, demon, WMDE-leszek, GoranSMilovanovic, QZanden, Liudvikas, Izno, Luke081515, Wikidata-bugs, zeljkofilipin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T176312: Don’t check format constraint via SPARQL
Krinkle added a project: TechCom-RfC. TASK DETAILhttps://phabricator.wikimedia.org/T176312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lucas_Werkmeister_WMDE, Krinkle, Aklapper, GoranSMilovanovic, QZanden, Agabi10, Izno, Wikidata-bugs, aude, GWicke, jayvdb, fbstj, RobLa-WMF, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase
Krinkle added a comment. The above flame graph is from HHVM profiling samples over 24 hours from production traffic. While useful to see the overall impact on average, it does not provide timings (due to being sampled). Here two profiles from XHGui for an individual request (including flamegraph). https://performance.wikimedia.org/xhgui/run/flamegraph?id=59d4a63a3f3dfacf5d63a6ab (total: 1.3s) EchoNotificationsHandlers::onBeforeCreateEchoEvent (111ms, 8%) https://performance.wikimedia.org/xhgui/run/flamegraph?id=59d4a5ef3f3dfacf5daf6f40 (total: 45s) EchoNotificationsHandlers::onBeforeCreateEchoEvent (231ms, 1%) TASK DETAILhttps://phabricator.wikimedia.org/T177311EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aude, thiemowmde, Krinkle, Aklapper, GoranSMilovanovic, QZanden, Vali.matei, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177414: Maintenance scripts exit with 0 when an (uncaught) exception is encountered
Krinkle added a comment. This explains why postgres was seemingly passing on Travis CI when in fact it was broken (again). BeforeAfter https://travis-ci.org/wikimedia/mediawiki/jobs/283426437https://travis-ci.org/wikimedia/mediawiki/jobs/283543802 F10039102: Screen Shot 2017-10-06 at 20.33.54.pngF10039106: Screen Shot 2017-10-06 at 20.34.27.png TASK DETAILhttps://phabricator.wikimedia.org/T177414EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, KrinkleCc: Krinkle, gerritbot, Aklapper, ArielGlenn, hoo, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T145819: Jobs invoking SiteConfiguration::getConfig cause HHVM to fail updating the bytecode cache due to being filesize limited to 512MBytes
Krinkle removed a project: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...**Change log statistics**
|| | ID | Timestamp
|--|--|--
| Oldest | 373786394 | 19:45, 12 September 2016...| | Site | Position | Pending | Lag | Touched...Change log statistics
|| | ID | Timestamp
|--|--|--
| Oldest | 373789761 | 20:00, 12 September 2016...| | Site | Position | Pending | Lag | Touched...I have noticed:
```
```lang=jsonn,lines=10
{...TASK DETAILhttps://phabricator.wikimedia.org/T145819EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: thcipriani, Anomie, aaron, MZMcBride, Tobi_WMDE_SW, FastLizard4, JJMC89, zeljkofilipin, Lydia_Pintscher, daniel, aude, Addshore, Aklapper, greg, Legoktm, demon, gerritbot, Stashbot, hashar, GoranSMilovanovic, QZanden, Liudvikas, Izno, Luke081515, Wikidata-bugs, ArielGlenn, He7d3r, Mbch331, Jay8g, mmodell___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase
Krinkle created this task.Krinkle added projects: Performance-Team, MediaWiki-extensions-WikibaseClient, Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTION/includes/WebStart.php
EchoHooks::initEchoExtension (3.05%)
Wikibase\Client\Hooks\EchoNotificationsHandlers::onBeforeCreateEchoEvent
Wikibase\Client\Hooks\EchoNotificationsHandlers::newFromGlobalState (2.63%)
public static function onBeforeCreateEchoEvent(
array &$notifications,
array &$notificationCategories,
array &$icons
) {
$self = self::newFromGlobalState();
$self->doBeforeCreateEchoEvent( $notifications, $notificationCategories, $icons );
}
For example: https://performance.wikimedia.org/xenon/svgs/daily/2017-10-01.load.svgz
F9984501: Screen Shot 2017-10-03 at 19.24.12.png
The doBeforeCreateEchoEvent() method call itself is trivial. Most time is spent in newFromGlobalState(), which requires numerous services that are not used.
NamespaceChecker (unused)
RepoLinker (unused)
WikibaseClient (mostly unused, except for Settings)
WikibaseClient//SiteLookup (unused)
WikibaseClient//DataTypeDefinitions (unused)
WikibaseClient//Settings (used)
The most expensive here is SiteLookup and NamespaceChecker, which are both created here for the unrelated hook onWikibaseHandleChange - which is not called on most requests and not worth blocking WebStart on all web requests.
From a brief look it seems that the main problem is that all hook handlers share the same singleton for injection (instead of obtaining their own services as needed), which means calling one hook ends up also requiring services for other hooks.
A deeper problem is that these services have expensive constructors, which is unexpected, and likely the reason why this approach was assumed to be unproblematic.
See also: T160678: Reduce ChronologyProtector init cost for load.phpTASK DETAILhttps://phabricator.wikimedia.org/T177311EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aude, thiemowmde, Krinkle, Aklapper, GoranSMilovanovic, QZanden, Vali.matei, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T177764: [Task] Make Wikibase JavaScript unit tests QUnit 2 compatible
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] https://gerrit.wikimedia.org/r/383363...TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: gerritbot, WMDE-leszek, Aleksey_WMDE, Addshore, hoo, aude, Aklapper, Krinkle, Jonas, Ladsgroup, thiemowmde, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase
Krinkle added a comment. @aude A week is fine. This isn't a regression from current week's branch.TASK DETAILhttps://phabricator.wikimedia.org/T177311EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aude, KrinkleCc: Lydia_Pintscher, gerritbot, hoo, aude, thiemowmde, Krinkle, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T173710: Job queue is increasing non-stop
Krinkle triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Daniel_Mietchen, Harej, XXN, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, Emijrp, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, Vali.matei, Avner, Lewizho99, Zppix, Maathavan, debt, Gehel, FloNight, Izno, Wikidata-bugs, aude, jayvdb, faidon, Mbch331, Jay8g, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop
Krinkle removed projects: MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review.Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONThis doesn't sound good:
| August 21
|--
| {F9141847 height=150}
Current:
Mitigation:
* 6898d06f8f Disable rebound CDN purges for backlinks in HTMLCacheUpdateJob. @aaron, https://gerrit.wikimedia.org/r/373705
In MediaWiki 1.27 (2015) we introduced `$wgCdnReboundPurgeDelay` (more information at ). This means that effectively every purge is actually two purges, spaced out by a few seconds, to account for race conditions between database replication and cache population. However, the common case of recursive updates (e.g. from templates) is already delayed through the JobQueue, so we can omit the rebound purge in that case.
**→** Fixing this improved job execution throughput, and decreased job queue growth.
* 70d1bc0091 Make workItemCount() smarter for htmlCacheUpdate/refreshLinks. @aaron,
To avoid pressure on CDN and database, job execution can be throttled via . The placeholder jobs for recursive updates (e.g. for templates) were being counted as 1, which needlessly subjected them to throttling.
**→** Fixing this improved job execution throughput.
* 56ed177f1 Reduce batch size in WikiPageUpdater. @Ladsgroup,
**→** Fixing this improved job execution throughput.
* cb7c910ba Fix old regression in HTMLCacheUpdate de-duplication. @aaron,
Following a refactor in mid-2016, the duplication logic for recursive updates started to be miscalculated (based on current time, instead of time from the initial placeholder/root job).
**→** Fixing this significantly decreased job queue growth.
| August 31
{F9141847}
[[ https://grafana.wikimedia.org/dashboard/db/job-queue-health?refresh=1m=1 | current]]|--
| {F9232210 height=150} {F9232209 height=200}
TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: GWicke, Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Daniel_Mietchen, Harej, XXN, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, Emijrp, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, Vali.matei, Avner, Zppix, debt, Gehel, FloNight, Izno, Eevans, mobrovac, Hardikj, Wikidata-bugs, aude, jayvdb, faidon, Mbch331, Jay8g, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T173710: Job queue is increasing non-stop
Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...Current:
### Mitigation:
* 6898d06f8f Disable rebound CDN purges for backlinks in HTMLCacheUpdateJob. @aaron, https://gerrit.wikimedia.org/r/373705... **→** Fixing this significantly decreased job queue growth.
| August 31
|--See also:
| {F9232210 height=150} {F9232209 height=200}
* {T124418}TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: GWicke, Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Daniel_Mietchen, Harej, XXN, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, Emijrp, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, Vali.matei, Avner, Zppix, debt, Gehel, FloNight, Izno, Eevans, mobrovac, Hardikj, Wikidata-bugs, aude, jayvdb, faidon, Mbch331, Jay8g, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T174422: Make dbBatchSize in WikiPageUpdater configurable
Krinkle added a comment. @Ladsgroup @aaron Would $wgUpdateRowsPerQuery be appropiate here, too? Or is it important for this particular query to use a different batch size?TASK DETAILhttps://phabricator.wikimedia.org/T174422EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, KrinkleCc: Aklapper, fgiunchedi, aaron, Krinkle, Jdforrester-WMF, WMDE-leszek, jcrespo, EBernhardson, gerritbot, Emijrp, Mr.Ibrahem, Magnus, Sjoerddebruin, Bugreporter, Pasleim, XXN, Harej, Daniel_Mietchen, Agabi10, Stashbot, daniel, Liuxinyu970226, Peachey88, BBlack, Andreasmperu, Nemo_bis, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T173696: Cache constraint check results
Krinkle added a comment. In T173696#3569491, @Ladsgroup wrote: Pinging @aaron and @Krinkle as they are the experts on this. I left a few minor points at https://gerrit.wikimedia.org/r/373918. I don't know much about the use of regular expressions in the particular context of Sparql and Wikidata, but it does leave me somewhat confused. If the regex itself was retrieved from the wiki database (not Sparql) and the input text is available in PHP, why do we need to query an external service to execute a regular _expression_?TASK DETAILhttps://phabricator.wikimedia.org/T173696EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, aaron, gerritbot, Ladsgroup, daniel, Aklapper, Jonas, Lucas_Werkmeister_WMDE, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Agabi10, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T173696: Cache constraint check results
Krinkle added a comment.
In T173696#3584607, @Krinkle wrote:
[..] why do we need to query an external service to execute a regular _expression_?
In T173696#3584821, @Lucas_Werkmeister_WMDE wrote:
Because checking arbitrary regexes on arbitrary input opens us up to DoS attacks via malicious regexes [..]. This came up during the security review of the extension (T101467), and we eventually decided to check regexes on an external service instead, where queries are subject to a timeout (T102752).
Interesting. And this uses the same Sparql endpoint at https://query.wikidata.org/ as for public queries? I knew this was called from within Wikidata for MediaWiki API queries, but I didn't know it was used e.g. when saving edits (assuming validation happens there).
I'm bringing this up because the reason we want caching is due to its performance, right? ConstraintCheck/SparqlHelper in Wikidata currently has a timeout of 5 seconds. Presumably in order to support some of the more complex regular expressions and larger input texts. I imagine that with a more performant backend caching might not be as needed.
(off-topic: )
Response times look fairly good in Graphite (source). The minutely p99 over the last 5 days ranges from 100-500ms, although with regular spikes of 1-5 seconds. From manual testing I find it's usually ~350ms with short regex/text, and ~600-1200ms for more larger input. The only responses under 300ms are those that were a cache-hit in Varnish (yay) in which case it's typically 100-130ms. This is okay.
On the other hand, considering its for internal execution of a single regex, ~300ms is a lot. I wonder if something like a "simple" PHP or Python subprocess would work (something that runs preg_match or re.match, using tight firejail with cgroup restrictions, like other MediaWiki subprocesses). Or perhaps using LuaSandbox? (below via eval.php):
$sandbox = new LuaSandbox; $sandbox->setCPULimit(0.25); $sandbox->setMemoryLimit(512000); // 512KB
$lua = "function match_text(text, pattern) return string.match(text, pattern) ~= nil end";
$sandbox->loadString($lua)->call(); $result = $sandbox->callFunction('match_text', 'foo', 'f..');
return is_array($result) && isset($result[0]) && $result[0] === true;
These lines take < 1ms. With large input (e.g. wikitext article), and a more complex pattern, between 5 and 10ms. However, I quickly realised Lua doesn't implement PCRE regular expressions by default (T52454, Lua Patterns). I wonder if it's worth revisiting the security implications of adding PCRE bindings to a LuaSandbox (perhaps reduced to a subclass for Wikibase).
Anyway, just a few off topic thoughts :)TASK DETAILhttps://phabricator.wikimedia.org/T173696EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, aaron, gerritbot, Ladsgroup, daniel, Aklapper, Jonas, Lucas_Werkmeister_WMDE, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Agabi10, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T173710: Job queue is increasing non-stop
Krinkle added a comment. In T173710#3583445, @Joe wrote: As a side comment: this is one of the cases where I would've loved to have an elastic environment to run MediaWiki-related applications: I could've spun up 10 instances of jobrunner dedicated to refreshlinks (or, ideally, the system could have done it automagically), for example. Yep! Very true. When I first read about Borg and whenever I read about similar principles since, the job queue always comes to mind as a great use case. Of course it would benefit app server maintenance too, but the job queue pressure tends to vary more than app server pressure. A Borg-like system would allow us to make the most of the idle time on all (app) servers and gracefully fill it up with job runners. Of course, that doesn't apply to cases that are limited by a common resource (e.g. database). But the idea is still very attractive. Permanently setting up more job runners remains a difficult calculation for us, because in the end we must prioritise app servers for site availability. On the other hand, given how idle most app servers are most of the time, it seems like a royal waste to not put it to use.TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Nikerabbit, Mholloway, Legoktm, ema, Joe, GWicke, Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Daniel_Mietchen, Harej, XXN, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, Vali.matei, Avner, Lewizho99, Zppix, Maathavan, debt, Gehel, FloNight, Izno, Eevans, mobrovac, Hardikj, Wikidata-bugs, aude, jayvdb, faidon, Mbch331, Jay8g, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T175109: beta: Wikidata dispatchChanges.php causes a lot of "Wikimedia\Rdbms\DatabaseMysqlBase::unlock failed to release lock"
Krinkle added a comment. Still happening. 750,000+ log entries in the last 30 days on Beta Cluster. Most are like: mediawiki WARNING wikidatawiki deployment-tin Wikimedia\Rdbms\DatabaseMysqlBase::unlock failed to release lock '' or mediawiki WARNING wikidatawiki deployment-tin Wikimedia\Rdbms\DatabaseMysqlBase::unlock failed to release lock ''Wikibase.wikidatawiki.dispatchChanges.''TASK DETAILhttps://phabricator.wikimedia.org/T175109EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, thiemowmde, Ladsgroup, aude, Aklapper, hashar, GoranSMilovanovic, QZanden, TerraCodes, Izno, Luke081515, Wikidata-bugs, Mbch331, Jay8g, Krenair, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T145535: language code disparity (Wikidata tracking)
Krinkle closed subtask T21986: Wikis waiting to be renamed (tracking) as "Resolved".Herald added a subscriber: Danmichaelo. TASK DETAILhttps://phabricator.wikimedia.org/T145535EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Danmichaelo, PokestarFan, Liuxinyu970226, Krenair, zhuyifei1999, MF-Warburg, Denny, Merl, SPQRobin, liangent, Koavf, Nemo_bis, Fomafix, Lydia_Pintscher, Amire80, Aklapper, Esc3300, GoranSMilovanovic, QZanden, Srdjan_m, MuhammadShuaib, Izno, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T18976: Wikis waiting for creation (tracking)
Krinkle closed this task as "Resolved".Krinkle added a comment. Per T102509, closed in favour of #Wiki-Setup (Create).TASK DETAILhttps://phabricator.wikimedia.org/T18976EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, PokestarFan, Jayprakash12345, QZanden, hoo, DatGuy, StevenJ81, Acer, Danny_B, TerraCodes, JEumerus, greg, Krenair, Aklapper, Meno25, Matanya, Arseny1992, aude, brion, Amire80, Ebe123, SPQRobin, mxn, TTO, Az1568, Pathoschild, Merl, Petrb, Steinsplitter, revi, Glaisher, Rschen7754, Kanjy, Snowolf, Hkjacksonhk, Liuxinyu970226, jeremyb, MF-Warburg, Stryn, zhuyifei1999, Dcljr, Dereckson, JohnLewis, GoranSMilovanovic, Devwaker, Urbanecm, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Jdforrester-WMF, Mbch331, Rxy, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T102026: Create Wikipedia Northern Luri
Krinkle edited projects, added Wiki-Setup (Create); removed Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T102026EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Krenair, KrinkleCc: Matanya, greg, Nikerabbit, Glaisher, Dzahn, Ebe123, jcrespo, coren, Springle, Mogoeilor, Krenair, gerritbot, Aklapper, MF-Warburg, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, aude, Dcljr, Jdforrester-WMF, Mbch331, Rxy, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T54034: Create Wikivoyage Vietnamese
Krinkle edited projects, added Wiki-Setup (Create); removed Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T54034EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Reedy, KrinkleCc: Wikidata-bugs, Abraham, SPQRobin, mxn, Petrb, Snowolf, Dzahn, Lydia_Pintscher, jeremyb, MF-Warburg, Dereckson, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Luke081515, biplabanand, Dcljr, Jdforrester-WMF, Matanya, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T18976: Wikis waiting for creation (tracking)
Krinkle removed subtasks: T173643: Create Wiktionary Fiji Hindi, T173471: Re-open Wikibooks Bashkir, T173013: Create Wikivoyage Hindi, T168782: Create fishbowl wiki for Maithili Wikimedians User Group, T168765: Create Wikiversity Hindi, T168764: Reopen Wikinews Dutch, T168518: Create Dinka Wikipedia, T165977: Create CoC committee private wiki, T167714: Create Atikamekw Wikipedia, T162510: Create fishbowl wiki for West Bengal Wikimedians User Group, T161529: Create Wikipedia Doteli, T160865: Create Wikipedia Khowar, T160868: Create Wikipedia Kabiye, T155038: Create Wikimania 2018 wiki, T151731: Create an arbcom-cs wiki, T151570: Create Wikivoyage Finnish, T149522: Create Wikisource Eastern Punjabi, T146612: Create Livvi-Karelian Wikipedia at olo.wikipedia.org, T143138: Private wiki for Project Grants Committee, T140898: Create Wikipedia Tulu, T135521: Internal Wiki for Wikimedians of Ecuador, T134017: Create Wikipedia Jamaican, T126832: Recreate a wiki for Wikimedia Portugal, T125501: Create Adyghe Wikipedia, T122062: Create the wikimania2017 wiki, T106305: Create Wikipedia South Azerbaijani, T102026: Create Wikipedia Northern Luri, T98676: Create fishbowl wiki for Wikimedia User Group China, T96468: Create Wikipedia Goan Konkani, T85374: Create wikimania2016 wiki, T73382: Create Wikivoyage Persian, T62764: Create an arbcom-cz wiki, T74346: Create Wikipedia Maithili, T62220: Move wiki.toolserver.org to WMF, T73875: Create Oriya Wikisource, T68370: Create wikimania2015wiki, T63222: Create wiki (legalteamwiki) for Wikimedia Foundation legal team, T66557: New England Wikimedians website, T51328: Create Wikipedia Tuvan, T61077: Create Wikivoyage Chinese, T47744: Please create ombudsmen.wikimedia.org, T45812: Create Sanskrit Wikiquote, T54034: Create Wikivoyage Vietnamese, T50413: Create Greek Wikivoyage, T50412: Create Venetian Wiktionary, T45129: Create Wikisource Assamese, T48417: Create Wikivoyage Ukrainian, T48416: Create Hebrew Wikivoyage (hewikivoyage), T49945: Create wikimania2014 wiki, T44933: Create Wikivoyage Spanish, T44934: Create Wikivoyage Portuguese, T38477: Create wikimania2013 wiki, T46606: Create Wikiquote in Oriya, T46462: Create Wikipedia Minangkabau, T46460: Create Wikiversity Korean, T33096: Create a new wiki for Wikimedia Bangladesh, T46414: Create Wikivoyage Polish, T46413: Create Wikivoyage Romanian, T31456: Create Wikipedia Mingrelian, T36351: Create Wikisource in Belarusian, T31339: create a test wiki for RTL development, T34511: Create Western Panjabi Wiktionary, T34510: Create Veps Wikipedia, T32882: Create Wikipedia in Northern Sotho, T31273: nyc.wikimedia.org wiki, T36223: Create Wikipedia Lezgi, T32793: Create Wikimedia Belgium wiki (be.wikimedia.org), T29631: the Wikisource for Sanskrit is approved, T29557: Create Sakha Wikisource, T27773: Create Wikibooks in Limburgish, T27774: Create Wikinews in Esperanto, T27743: Create the Breton Wikisource (ws/br), T29379: Please create Wikipedia in Latgalian language, T27696: Create vec.wikisource.org, T35907: Please create a Marathi Wikisource, T27569: Create the Gagauz Wikipedia (wp/gag), T27544: Create a new Wikipedia in Hill Mari, T27307: Create Wikipedia in Banjar, T30520: Create wikimania2012 wiki, T27130: Create Wikipedia in Komi-Permyak, T27056: Create new wiki for Persian Wikinews, T37290: Create Slovenian Wikiversity, T22181: New approved projects, T26928: Creation of a wiki for Wikimedia Estonia, T30139: Create the Greek Wikinews, T37138: Create Gujarati Wikisource, T26776: Create Korean Wikinews, T31796: Create Wikiversity Arabic, T31758: Create a wiki for the future chapter Wikimedia México, T30022: Create the Albanian Wikinews, T30003: Create the Kabardian Circassian Wikipedia, T31715: Please create a wiki for Wikimedia Argentina, T26664: Wiki for Wikimedia Macedonia, T21609: Create Domain for Wikimedia Colombia, T24657: Create Wikipedia Karachay-Balkar, T28136: Create Wikisource in Esperanto, T27924: Create Wikipedia in Rusyn, T27904: Create the Swedish Wikiversity (wv/sv), T27871: Create the Palatinate German Wikipedia (wp/pfl), T15547: Create Wikimania 2009 website, T13614: Create Wikimania 2008 website, T18812: Request for a Dutch version of labs. TASK DETAILhttps://phabricator.wikimedia.org/T18976EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: PokestarFan, Jayprakash12345, QZanden, hoo, DatGuy, StevenJ81, Acer, Danny_B, TerraCodes, JEumerus, greg, Krenair, Aklapper, Meno25, Matanya, Arseny1992, aude, brion, Amire80, Ebe123, SPQRobin, mxn, TTO, Az1568, Pathoschild, Merl, Petrb, Steinsplitter, revi, Glaisher, Rschen7754, Kanjy, Snowolf, Hkjacksonhk, Liuxinyu970226, jeremyb, MF-Warburg, Stryn, zhuyifei1999, Dcljr, Dereckson, JohnLewis, GoranSMilovanovic, Devwaker, Urbanecm, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Jdforrester-WMF, Mbch331, Rxy, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T73382: Create Wikivoyage Persian
Krinkle edited projects, added Wiki-Setup (Create); removed Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T73382EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Glaisher, KrinkleCc: Wikidata-bugs, Ebe123, Petrb, Steinsplitter, revi, aude, Glaisher, Calak, Snowolf, Yamaha5, Ladsgroup, Lydia_Pintscher, jeremyb, MF-Warburg, Reedy, Stryn, zhuyifei1999, Dereckson, JohnLewis, Th3d3v1ls, Hfbn0, Zppix, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Luke081515, biplabanand, Dcljr, faidon, Jdforrester-WMF, Matanya, Rxy, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T134017: Create Wikipedia Jamaican
Krinkle edited projects, added Wiki-Setup (Create); removed Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T134017EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Krenair, KrinkleCc: Jdforrester-WMF, RobH, Lydia_Pintscher, StevenJ81, hoo, aude, Multichill, VIGNERON, Nikki, chasemp, Andrew, Volans, Stashbot, MZMcBride, zhuyifei1999, Dereckson, Mtherwjs, Glaisher, Dzahn, Ebe123, gerritbot, jcrespo, Krenair, SPQRobin, Aklapper, Matanya, JEumerus, MF-Warburg, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, Lewizho99, Zppix, Maathavan, DatGuy, Devwaker, Urbanecm, Tulsi_Bhagat, Izno, MGChecker, Luke081515, biplabanand, Wikidata-bugs, Snowolf, Dcljr, faidon, Mbch331, Rxy, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T168765: Create Wikiversity Hindi
Krinkle edited projects, added Wiki-Setup (Create); removed Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T168765EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Reedy, KrinkleCc: Anooprao, Stashbot, Reedy, Trizek-WMF, YmKavishwar, Crochet.david, gerritbot, PokestarFan, gh87, Ebe123, Lsanabria, Sfic, Urbanecm, StevenJ81, SPQRobin, Rschen7754, Mahir256, Koavf, Dereckson, Jayprakash12345, Dcljr, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, Lewizho99, Zppix, Maathavan, DatGuy, Devwaker, JEumerus, Tulsi_Bhagat, Izno, Luke081515, JAllemandou, biplabanand, Wikidata-bugs, Snowolf, aude, Nemo_bis, faidon, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair, fgiunchedi, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T160868: Create Wikipedia Kabiye
Krinkle edited projects, added Wiki-Setup (Create); removed Wikimedia-Site-requests. TASK DETAILhttps://phabricator.wikimedia.org/T160868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dereckson, KrinkleCc: Urbanecm, PokestarFan, aude, Dcljr, QZanden, hoo, Meno25, Raymond, Nemo_bis, Dzahn, Stashbot, revi, Esc3300, Paladox, Rschen7754, tomasz, TerraCodes, Dereckson, gerritbot, Aklapper, MF-Warburg, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, DatGuy, Devwaker, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T174922: Decide what to do with Wikibase JS-only libraries regarding the build/deployment of Wikidata code
Krinkle added a comment. Move all those libraries to Wikibase git repository pro: dependency problem goes away con: code provided by those libs is no longer versioned as now - all only work with current Wikibase master con: even more code in Wikibase.git con: no way for those libs to by used by other users than Wikibase (but are there any?) Turn those libs into npm packages and check in them into a particular place in Wikibase git repository to be picked up by RL pro: easy integration with RL (know where files are) pro: libs can be still released and developed independently from Wikibase/MW con: libs are maintained in two places con: needs manual committing after each release of a lib (Composer no longer used) Regarding Option 1: Having your own Git repository and being published as npm package (e.g. for third-parties) are not mutually exclusive. You can run npm publish from any directory that contains a package.json file. Whether it's a sub directory of something or even in a Git repo at all is irrelevant from npm's perspective. (This is why for example, in npm, contrary to Composer, the version number must be declared in package.json). So you can consolidate the best of option 1 and option 2: Option 5: Move those libraries to the Wikibase git repository: pro: dependency problem goes away pro: build step goes away pro: easy integration with RL (know where files are) pro: libs can be still released and published independently from Wikibase/MW pro: libs only maintained in a single place con: even more code in Wikibase.git This would be my recommendation (as first step).TASK DETAILhttps://phabricator.wikimedia.org/T174922EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Aklapper, Addshore, Legoktm, greg, Lydia_Pintscher, daniel, thiemowmde, Aleksey_WMDE, Jonas, hoo, aude, demon, WMDE-leszek, GoranSMilovanovic, QZanden, Liudvikas, Izno, Luke081515, Wikidata-bugs, zeljkofilipin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T174422: Make dbBatchSize in WikiPageUpdater configurable
Krinkle removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T174422EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, KrinkleCc: Aklapper, fgiunchedi, aaron, Krinkle, Jdforrester-WMF, WMDE-leszek, jcrespo, EBernhardson, gerritbot, Emijrp, Mr.Ibrahem, Magnus, Sjoerddebruin, Bugreporter, Pasleim, XXN, Harej, Daniel_Mietchen, Agabi10, Stashbot, daniel, Liuxinyu970226, Peachey88, BBlack, Andreasmperu, Nemo_bis, Ladsgroup, GoranSMilovanovic, QZanden, Vali.matei, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T173710: Job queue is increasing non-stop
Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... **→** Fixing this significantly decreased job queue growth.
| Dashboard: Job Queue Helath
|--
| {F9232210 height=150} {F9232209 height=200}
| Job queue size down from 10M to a steady ~2M. Before the regression it was a steady between 100K -1M.
| [Dashboard: Varnish stats](https://grafana.wikimedia.org/dashboard/file/varnish-aggregate-client-status-codes.json?orgId=1=1503729100778=1504135040719)
|--
| {F9232784 height=250}
| Purge rate from production Varnish servers reduced by **2-3X**, from 75-100K/s to ~30K/s.
| [Dashboard: Job Queue Rate for htmlCacheUpdate](https://grafana.wikimedia.org/dashboard/db/job-queue-rate?panelId=2=1=htmlCacheUpdate=now-90d=now)
|--
| {F9232855 height=200}
| Queue rate of `htmlCacheUpdate` back to normal. Deduplication/Superseding optimisation is now working. Execution speed has increased.
See also:...TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: GWicke, Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Daniel_Mietchen, Harej, XXN, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, Emijrp, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, Vali.matei, Avner, Zppix, debt, Gehel, FloNight, Izno, Eevans, mobrovac, Hardikj, Wikidata-bugs, aude, jayvdb, faidon, Mbch331, Jay8g, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T173710: Job queue is increasing non-stop
Krinkle added a comment. Added a mitigation section to the task description. Also a summary of the impact of the mitigations so far (based on input from @aaron). Dashboard: Job Queue Helath F9232210: Screen Shot 2017-08-31 at 00.00.31.png F9232209: Screen Shot 2017-08-31 at 00.00.18.png Job queue size down from 10M to a steady ~2M. Before the regression it was a steady between 100K -1M. Dashboard: Varnish stats F9232784: Screen Shot 2017-08-31 at 00.15.34.png Purge rate from production Varnish servers reduced by 2-3X, from 75-100K/s to ~30K/s. Dashboard: Job Queue Rate for htmlCacheUpdate F9232855: Screen Shot 2017-08-31 at 00.21.36.png Queue rate of htmlCacheUpdate back to normal. Deduplication/Superseding optimisation is now working. Execution speed has increased. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: GWicke, Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Daniel_Mietchen, Harej, XXN, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, Emijrp, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, Vali.matei, Avner, Zppix, debt, Gehel, FloNight, Izno, Eevans, mobrovac, Hardikj, Wikidata-bugs, aude, jayvdb, faidon, Mbch331, Jay8g, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T177764: [Task] Make Wikibase JavaScript unit tests QUnit 2 compatible
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] https://gerrit.wikimedia.org/r/383117TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: gerritbot, WMDE-leszek, Aleksey_WMDE, Addshore, hoo, aude, Aklapper, Krinkle, Jonas, Ladsgroup, thiemowmde, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T177087: Make Wikibase-related JS libraries npm packages and include them as git submodules in Wikibase.git instead of installing as PHP libs using Composer
Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION//This task executes the decision made at {T174922}//
Libraries to consider:...TASK DETAILhttps://phabricator.wikimedia.org/T177087EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Ricordisamoa, Aklapper, Addshore, Lydia_Pintscher, WMDE-leszek, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T173225: [Task] Tag releases of smaller Wikibase libraries significantly lagging behind
Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[] https://github.com/wmde/WikibaseSerializationJavaScript/pull/43
See also:
* {T172916}
* {T174922}
* {T173818}
* {T177087}TASK DETAILhttps://phabricator.wikimedia.org/T173225EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: Addshore, Jakob_WMDE, Lucas_Werkmeister_WMDE, hoo, aude, Ladsgroup, daniel, Jonas, WMDE-leszek, Aklapper, thiemowmde, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T173850: Possible WMF deployed extension PHP 7 issues
Krinkle removed a project: HHVM. TASK DETAILhttps://phabricator.wikimedia.org/T173850EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Paladox, Ottomata, gerritbot, Mattflaschen-WMF, Liuxinyu970226, WMDE-leszek, Anomie, Aklapper, Jdforrester-WMF, Addshore, MaxSem, Krenair, Reedy, SilvioAryneutro, Minilexikon, Timoavax79, Lordiis, GoranSMilovanovic, TheDragonFire, Maosef, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Orienteerix, EnricoCNC, Litanwei, Avner, Lewizho99, Ddproxy, Maathavan, debt, TerraCodes, Iniquity, SundanceRaphael, Reasno, Gehel, Debenben, Jseddon, JGirault, gabriel-wmde, phabyogi, FloNight, DStrine, Dixtosa, Trizek-WMF, GAllegre, Susannaanas, XenoRyet, Thibaut120094, Izno, SBisson, Matiia, ferdbold, lxbarth, Wong128hk, Luke081515, Nirmos, JAllemandou, Zache, Planemad, Wikidata-bugs, Snowolf, Prod, Hydriz, Base, aude, fredw, SPQRobin, AndyRussG, Ebe123, Pcoombe, Huji, Physikerwelt, Pkra, Dinoguy1000, Gryllida, jeblad, jayvdb, Ricordisamoa, MrStradivarius, Catrope, Lydia_Pintscher, Yurik, Darkdadaah, Arrbee, scfc, KartikMistry, Se4598, Jackmcbarn, Mbch331, Jay8g, Ltrlg, jeremyb, Legoktm, Tgr___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T177764: [Task] Make Wikibase JavaScript unit tests QUnit 2 compatible
Krinkle removed projects: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: gerritbot, WMDE-leszek, Aleksey_WMDE, Addshore, hoo, aude, Aklapper, Krinkle, Jonas, Ladsgroup, thiemowmde, GoranSMilovanovic, QZanden, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177485: lost cursor focus in fields when adding property items
Krinkle added a comment. In T177485#3661914, @Sjoerddebruin wrote: Can this be some side-effect of T124742? The _javascript_ console is full of deprecated notices (pointing to the statement view as well). There were no official breaking changes in jQuery 3 that aren't covered by jQuery Migrate (apart from Deferred now being async, but it sometimes being sync was already unsupported). The deprecation notices mean things are working. If this bug is triggered by a change in jQuery 3, it will not have a deprecation warning for where it went wrong. I would recommend trying to reproduce this error on https://test.wikidata.org and, if it happens there, to first temporarily disable wgUsejQueryThree on testwikidatawiki only to verify if that is indeed the cause.TASK DETAILhttps://phabricator.wikimedia.org/T177485EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Sjoerddebruin, thiemowmde, Liuxinyu970226, jhsoby, Aklapper, Billinghurst, GoranSMilovanovic, Jrbranaa, QZanden, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177311: 2% of /w/load.php spent in WebStart/onBeforeCreateEchoEvent for Wikibase
Krinkle added a comment.
In T177311#3659950, @gerritbot wrote:
Change 382383 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Split Echo hook handlers based on services needed
https://gerrit.wikimedia.org/r/382383
@aude Thanks for the quick patch!
public static function newFromGlobalState() {
- $wikibaseClient = WikibaseClient::getDefaultInstance();
- $settings = $wikibaseClient->getSettings();
+ $settings = WikibaseSettings::getClientSettings();
return new self(
- $wikibaseClient->newRepoLinker(),
- $wikibaseClient->getNamespaceChecker(),
$settings->getSetting( 'echoIcon' ),
);
Very nice. I didn't know WikibaseSettings::getClientSettings existed. That also avoids creating WikibaseClient's services.TASK DETAILhttps://phabricator.wikimedia.org/T177311EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aude, KrinkleCc: Lydia_Pintscher, gerritbot, hoo, aude, thiemowmde, Krinkle, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Declined] T105638: RFC: Streamlining Composer usage
Krinkle closed this task as "Declined".Krinkle triaged this task as "Normal" priority.Krinkle added a comment. In T105638#3670708, @Addshore wrote: Personally I think out composer usage is rather streamlined right now Indeed. Our conventions around how Composer should be used in MediaWiki development, release and deployment have settled. I don't think we're in an ideal or perfect situation but it seems to be working well enough right now and meets the original criteria for adopting Composer However, the RFC about agreeing how to use Composer (initially) is a separate one:https://www.mediawiki.org/wiki/Requests_for_comment/Composer_managed_libraries_for_use_on_WMF_cluster Despite its generic name, this RFC (T105638) was not so much about setting up how we use Composer, but changing how we use Composer to be different. Specifically to address complexity with regards to merging composer.json files from multiple sources whilst still making it easy and consistent to test and install separately. This was mainly for the use case of the Wikidata build, which is being changed to not have its own vendor install anymore, thus making this an RFC without a shephard/stakeholder. The idea of automating mediawiki/vendor and/or to move the Composer step to be during CI or deployment, instead of in Git, remains interesting for the future. But following a reevaluation from TechCom, I'm closing this RFC given the original use case is becoming obsolete, and there is no longer resourcing from the affected teams for this problem. Affected teams (e.g. Release Engineering or MediaWiki Platform Team) are free to create a new RFC at any time, possibly borrowing some of the ideas from this RFC.TASK DETAILhttps://phabricator.wikimedia.org/T105638EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Scott_WUaS, RobLa-WMF, adrianheine, Ricordisamoa, MoritzMuehlenhoff, dduvall, Tgr, mobrovac, GWicke, Addshore, Spage, greg, tstarling, aude, hoo, daniel, thcipriani, mmodell, bd808, csteipp, Legoktm, Krinkle, hashar, JanZerebecki, Aklapper, GoranSMilovanovic, QZanden, Lynhg, SBisson, Luke081515, Wikidata-bugs, Malyacko, jayvdb, fbstj, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177764: [Task] Make Wikibase JavaScript unit tests QUnit 2 compatible
Krinkle added a comment. @thiemowmde The tests still fail with QUnit 2 at https://gerrit.wikimedia.org/r/#/c/367838/13. Failures come from data-values/value-view. In T177764#3674594, @gerritbot wrote: Change 383383 merged by jenkins-bot: [data-values/value-view@master] Remove QUnit.Parameterize dependency and make tests pass with QUnit 2 https://gerrit.wikimedia.org/r/383383 This would fix those failures, but it seems that while merged before the mediawiki/extensions/Wikidata build this morning, it is not included. I guess it needs to be released and pulled through? https://github.com/wikimedia/mediawiki-extensions-Wikidata/commits/master/extensions/ValueView/tests/src/jquery.valueview.tests.testExpert.jsTASK DETAILhttps://phabricator.wikimedia.org/T177764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, KrinkleCc: gerritbot, WMDE-leszek, Aleksey_WMDE, Addshore, hoo, aude, Aklapper, Krinkle, Jonas, Ladsgroup, thiemowmde, GoranSMilovanovic, QZanden, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T178806: Wikibase: Batch HTMLCacheUpdateJobs across changes
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...We could reduce the number of HTMLCacheUpdateJobs posted by collecting pages to be notified over an entire batch of changes, such as the batch contained in a ChangeNotificationJob. This should be done in a way that keeps collecting pages to purge while processing changes, and then chopping that list into badgbatches according to purgeCacheBatchSize. This requires the interaction between (Wiki)PageUpdater and ChangeHandler to be re-engineeredTASK DETAILhttps://phabricator.wikimedia.org/T178806EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hoo, Ladsgroup, thiemowmde, Joe, elukey, Krinkle, Aklapper, daniel, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T178806: Wikibase: Batch HTMLCacheUpdateJobs across changes
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONCurrently, we optimize for the case of a change triggering updates to many pages: we chop the set of pages into badgesbatches and push one HTMLCacheUpdateJob for each batchTASK DETAILhttps://phabricator.wikimedia.org/T178806EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hoo, Ladsgroup, thiemowmde, Joe, elukey, Krinkle, Aklapper, daniel, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T145819: Jobs invoking SiteConfiguration::getConfig cause HHVM to fail updating the bytecode cache due to being filesize limited to 512MBytes
Krinkle added a parent task: T146285: Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7). TASK DETAILhttps://phabricator.wikimedia.org/T145819EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: thcipriani, Anomie, aaron, MZMcBride, Tobi_WMDE_SW, FastLizard4, JJMC89, zeljkofilipin, Lydia_Pintscher, daniel, aude, Addshore, Aklapper, greg, Legoktm, demon, gerritbot, Stashbot, hashar, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Liudvikas, Luke081515, mobrovac, Wikidata-bugs, ArielGlenn, He7d3r, Mbch331, Jay8g, Krenair, fgiunchedi, jeremyb, mmodell___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop
Krinkle added a subscriber: Jeff_G.Krinkle merged a task: T178840: Commons category updates are very slow. Commons job queue very large.. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Jeff_G, Addshore, zhuyifei1999, RP88, Jack_who_built_the_house, elukey, debt, mxn, Daimona, YOUR1, Tbayer, mobrovac, Nikerabbit, Mholloway, Legoktm, ema, Joe, GWicke, Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Daniel_Mietchen, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, Cpaulf30, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, Vali.matei, Avner, Lewizho99, Zppix, Maathavan, Gehel, FloNight, Eevans, Hardikj, Wikidata-bugs, aude, jayvdb, faidon, Mbch331, Jay8g, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T183101: Items missing from Wikidata index
Krinkle added a project: Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T183101EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: aaron, Aklapper, EBernhardson, dcausse, Smalyshev, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, Vali.matei, Jdrewniak, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T178997: AddUsagesForPageJob doesn't really report execution status
Krinkle edited projects, added EventBus; removed MediaWiki-JobQueue.Herald added a project: Analytics. TASK DETAILhttps://phabricator.wikimedia.org/T178997EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pchelolo, KrinkleCc: thiemowmde, gerritbot, daniel, Pchelolo, Lahi, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, Agabi10, Eevans, JAllemandou, mobrovac, Hardikj, Wikidata-bugs, aude, GWicke, TheDJ, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T180727: WikibaseClient resources are broken in WMF
Krinkle moved this task from Inbox to Radar on the Performance-Team board.Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T180727WORKBOARDhttps://phabricator.wikimedia.org/project/board/1212/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: IKhitron, Robby, Addshore, hoo, WMDE-leszek, Ladsgroup, gerritbot, TerraCodes, Jay8g, Liuxinyu970226, Aklapper, eranroz, Imarlier, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Nirmos, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop
Krinkle added a commit: rMW8f829de5f040: Add action/user tracking to link refresh jobs. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: zhuyifei1999, RP88, Jack_who_built_the_house, elukey, debt, mxn, Daimona, YOUR1, Tbayer, mobrovac, Nikerabbit, Mholloway, Legoktm, ema, Joe, GWicke, Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Daniel_Mietchen, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, Vali.matei, Avner, Lewizho99, Zppix, Maathavan, Gehel, FloNight, Eevans, Hardikj, Wikidata-bugs, aude, jayvdb, faidon, Mbch331, Jay8g, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T173710: Job queue is increasing non-stop
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] https://gerrit.wikimedia.org/r/386636...TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: zhuyifei1999, RP88, Jack_who_built_the_house, elukey, debt, mxn, Daimona, YOUR1, Tbayer, mobrovac, Nikerabbit, Mholloway, Legoktm, ema, Joe, GWicke, Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Daniel_Mietchen, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, Vali.matei, Avner, Lewizho99, Zppix, Maathavan, Gehel, FloNight, Eevans, Hardikj, Wikidata-bugs, aude, jayvdb, faidon, Mbch331, Jay8g, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T173710: Job queue is increasing non-stop
Krinkle added a commit: rEWBA081c1cd78f9d: Add cause action/agent tracking to link refresh jobs. TASK DETAILhttps://phabricator.wikimedia.org/T173710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: zhuyifei1999, RP88, Jack_who_built_the_house, elukey, debt, mxn, Daimona, YOUR1, Tbayer, mobrovac, Nikerabbit, Mholloway, Legoktm, ema, Joe, GWicke, Nemo_bis, Andreasmperu, BBlack, Peachey88, Liuxinyu970226, daniel, Stashbot, Agabi10, Daniel_Mietchen, Pasleim, Bugreporter, Sjoerddebruin, Magnus, Mr.Ibrahem, gerritbot, EBernhardson, Esc3300, jcrespo, WMDE-leszek, Jdforrester-WMF, Krinkle, aaron, fgiunchedi, Aklapper, Ladsgroup, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, Vali.matei, Avner, Lewizho99, Zppix, Maathavan, Gehel, FloNight, Eevans, Hardikj, Wikidata-bugs, aude, jayvdb, faidon, Mbch331, Jay8g, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T89733: Allow ContentHandler to expose structured data to the search engine.
Krinkle moved this task from Backlog to Implemented on the TechCom-RfC (ArchCom-Approved) board.Krinkle removed projects: MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)), MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), Patch-For-Review, RfC. TASK DETAILhttps://phabricator.wikimedia.org/T89733WORKBOARDhttps://phabricator.wikimedia.org/project/board/2002/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, KrinkleCc: StudiesWorld, gerritbot, EBernhardson, DannyH, hoo, Deskana, RobLa-WMF, Tgr, Yurik, dcausse, JanZerebecki, Smalyshev, matthiasmullie, aude, Ricordisamoa, Krenair, MZMcBride, bd808, brion, Manybubbles, Aklapper, daniel, Lahi, GoranSMilovanovic, QZanden, SBisson, Wikidata-bugs, GWicke, jayvdb, fbstj, santhosh, Jdforrester-WMF, Jackmcbarn, Mbch331, Rxy, Jay8g, Ltrlg, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T592: RfC: ChangesList formatting
Krinkle added projects: Wikidata, Edit-Review-Improvements-RC-Page.Herald added a project: Collaboration-Team-Triage. TASK DETAILhttps://phabricator.wikimedia.org/T592EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Addshore, aude, daniel, Qgil, Quiddity, wikibugs-l-list, Lahi, GoranSMilovanovic, QZanden, Iniquity, jmatazzoni, SBisson, Luke081515, Wikidata-bugs, GWicke, jayvdb, fbstj, Catrope, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T182322: ChronologyProtector breaks if two requests write different sets of databases
Krinkle edited projects, added MediaWiki-Database; removed MediaWiki-General-or-Unknown, Performance, Performance-Team-notice, Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T182322EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, KrinkleCc: Darwinius, Aklapper, Lea_Lacroix_WMDE, Addshore, Ladsgroup, Joe, Trizek-WMF, jhsoby, Envlh, Framawiki, daniel, hoo, Simon_Villeneuve, Manu1400, MisterSynergy, Fnielsen, Jay8g, TerraCodes, aude, aaron, Krinkle, Jonas, thiemowmde, Lucas_Werkmeister_WMDE, Steinsplitter, Anvilaquarius, Anomalocaris, Sjoerddebruin, Imarlier, GerritBot, MusikAnimal, Rayssa-, Lahi, Gq86, GoranSMilovanovic, QZanden, Vali.matei, Johan, Luke081515, NavinoEvans, Wikidata-bugs, TheDJ, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191965: Structured Data on Wikimedia Commons: introduction and Q
Krinkle updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION* **When**: Friday 18 May, 16:00 - 17:00 * **Where**: Sala de projectes (QC/0011) What is #structured-data-commons? What is the team working on at this moment? Which new features will be rolled out this year? How can you contribute to the project? Got any feedback or requests for the developers and the whole team?...@Keegan and @marktraceur introduce you to everything you need to know, and answer your questions. TASK DETAILhttps://phabricator.wikimedia.org/T191965EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Keegan, KrinkleCc: Edouard-lopez, Lahi, 0x010C, Rfarrand, jgleeson, Abit, Cparle, matthiasmullie, Aklapper, Abbe98, Mholloway, ESM, SandraF_WMF, Keegan, MarkTraceur, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Culex, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, aude, Husky, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191965: Structured Data on Wikimedia Commons: introduction and Q
Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* **Where**: Sala de projectes (QC/0011)
* Next session: {T194275}
What is #structured-data-commons? What is the team working on at this moment? Which new features will be rolled out this year? How can you contribute to the project? Got any feedback or requests for the developers and the whole team?...TASK DETAILhttps://phabricator.wikimedia.org/T191965EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Keegan, KrinkleCc: Edouard-lopez, Lahi, 0x010C, Rfarrand, jgleeson, Abit, Cparle, matthiasmullie, Aklapper, Abbe98, Mholloway, ESM, SandraF_WMF, Keegan, MarkTraceur, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Culex, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, aude, Husky, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189538: Reduce complexity of Wikibase JS module registration
Krinkle added a comment. The remaining work here is to apply "Reduce indirection in resources files" to the rest of Wikibase. The above commit (https://gerrit.wikimedia.org/r/419334) was merely an example for one of the modules (view/wikibase-data-model).TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lydia_Pintscher, gerritbot, thiemowmde, WMDE-leszek, Addshore, Aklapper, Krinkle, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T189538: Reduce complexity of Wikibase JS module registration
Krinkle removed projects: MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review.Krinkle updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* [x] / {e9b71a058b24}
* [ * [x] / {d4f0dd2b51dfeef95abb4edae3bff349e27f2541}
* ..
---...TASK DETAILhttps://phabricator.wikimedia.org/T189538EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Lydia_Pintscher, gerritbot, thiemowmde, WMDE-leszek, Addshore, Aklapper, Krinkle, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Wikidata-bugs, aude, Mbch331, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T123221: [Task] Remove IE8 workarounds from Wikibase
Krinkle added subscribers: gerritbot, Krinkle.Krinkle added a comment. In T123218#3916627, @gerritbot wrote: [mediawiki/extensions/Wikibase@master] Remove some of IE8 hacks (wikibase/templates.js) https://gerrit.wikimedia.org/r/392663 TASK DETAILhttps://phabricator.wikimedia.org/T123221EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, gerritbot, Ladsgroup, Ricordisamoa, Jonas, adrianheine, thiemowmde, StudiesWorld, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, LawExplorer, Wikidata-bugs, aude, Dinoguy1000, TheDJ, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T195906: Phan fails for Wikibase on wmf.x branches
Krinkle removed a project: Wikimedia-log-errors (Shared Build Failure). TASK DETAILhttps://phabricator.wikimedia.org/T195906EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Jdforrester-WMF, TerraCodes, Liuxinyu970226, Stashbot, Legoktm, Lucas_Werkmeister_WMDE, Aklapper, thcipriani, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Volker_E, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?
Krinkle added a comment. @Jdlrobson It does indeed appear to be a bug somewhere relating to cache pollution, in particular it seems a cache key somewhere is being shared between mobile and desktop that shouldn't be. I can reproduce the following in Incognito mode (with disabled cache): (Desktop) View https://en.wikipedia.org/wiki/Barack_Obama, check Dev Tools/Network/CSS. Observe main stylesheet does not include ext.math.styles. (Mobile) View https://en.m.wikipedia.org/wiki/Barack_Obama, observe the main stylesheet includes ext.math.styles. (Mobile purge) https://en.m.wikipedia.org/wiki/Barack_Obama?action="">, confirm. Then reload https://en.m.wikipedia.org/wiki/Barack_Obama, observe the main stylesheet still includes ext.math.styles. (Desktop) View https://en.wikipedia.org/wiki/Barack_Obama, observe the main stylesheet now also includes ext.math.styles. (Desktop purge) View https://en.wikipedia.org/wiki/Barack_Obama?action="">, confirm. Reload and confirm it is no longer included on desktop. (Mobile) View https://en.m.wikipedia.org/wiki/Barack_Obama, observe the main stylesheet does not include ext.math.styles. Point 1Point 2Point 3 F22262922: cap1-desktop.pngF22263103: cap3-mobile.pngF22263104: cap2-mobile.png Point 4Point 5 F22263105: cap5-mobile.pngF22263106: cap4-desktop.png So it seems that whenever the last purge came from mobile, the module is included, whenever the last purge came from desktop, it is (correctly) not included. I'd recommend trying to reproduce it locally, and on Beta Cluster, and on different production wikis. That would help narrow it down somewhat.TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Physikerwelt, Krinkle, brion, Niedzielski, greg, TerraCodes, Liuxinyu970226, Peter, Jdlrobson, Volker_E, Aklapper, Imarlier, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Winter, Vali.matei, JJMC89, Debenben, Bianjiang, Nirmos, Cwek, Wikidata-bugs, aude, fredw, GWicke, Pkra, Dinoguy1000, ssastry, scfc, Arlolra, Jackmcbarn, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T173949: ext.math.styles is sometimes loaded when not needed - causing CSS size in production to fluctuate - parser cache pollution?
Krinkle removed a project: Performance. TASK DETAILhttps://phabricator.wikimedia.org/T173949EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Physikerwelt, Krinkle, brion, Niedzielski, greg, TerraCodes, Liuxinyu970226, Peter, Jdlrobson, Volker_E, Aklapper, Imarlier, Lahi, Gq86, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Winter, Vali.matei, JJMC89, Debenben, Bianjiang, Nirmos, Cwek, Wikidata-bugs, aude, fredw, Pkra, Dinoguy1000, ssastry, scfc, Arlolra, Jackmcbarn, Mbch331, Darkminds3113, GWicke, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T195906: Phan fails for Wikibase on wmf.x branches
Krinkle added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T195906EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: TerraCodes, Liuxinyu970226, Stashbot, Legoktm, Lucas_Werkmeister_WMDE, Aklapper, thcipriani, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Volker_E, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T195868: CI failures in php70: Undefined constant 'Wikibase\Client\Store\NS_MAIN'
Krinkle added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T195868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Stashbot, thcipriani, Legoktm, Liuxinyu970226, TerraCodes, Krinkle, Jdforrester-WMF, Aleksey_WMDE, daniel, Smalyshev, gerritbot, Ladsgroup, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T189329: jquery.wikibase qunit tests are flaky (Pending Ajax requests)
Krinkle closed this task as "Resolved".Krinkle claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T189329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Tgr, hashar, gerritbot, Reedy, Krinkle, dcausse, Jdlrobson, hoo, Mbch331, Jonas, TerraCodes, Liuxinyu970226, Gilles, Daimona, WMDE-leszek, SBisson, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Huji, Mholloway, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Volker_E, Wikidata-bugs, aude, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet
Krinkle added a project: Performance-Team. TASK DETAILhttps://phabricator.wikimedia.org/T152185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdlrobson, KrinkleCc: Krinkle, gerritbot, JGirault, Massimo_Telo, Nicholas.tsg, Jdlrobson, ovasileva, Andyrom75, Aklapper, Imarlier, Winter, Vali.matei, Wikidata-bugs, Lydia_Pintscher___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet
Krinkle added a comment. @Jdlrobson Yes, there is some form of sandboxing at the level of module loading. Which means that if you define module "a" and "b" as a.js and b.js, and load them separately but in the same request with "a" before "b", then even if "a" throws an exception during initialisation (e.g. syntax error or some other error that happens when first executing the file), then "b" should still run without issue. Can you still reproduce a problem locally when RelatedArticles is without the above patch? If so, could you try to make a more minimal test case that ends up with e.g. putting a certain piece of code in module X that makes it fail and something in module Y, where Y won't get executed?TASK DETAILhttps://phabricator.wikimedia.org/T152185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdlrobson, KrinkleCc: Krinkle, gerritbot, JGirault, Massimo_Telo, Nicholas.tsg, Jdlrobson, ovasileva, Andyrom75, Aklapper, Winter, Wikidata-bugs, Lydia_Pintscher___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
