[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 531963 abandoned by Tonina Zhelyazkova: bridge: Refactor EventEmittingButton Reason: Not applicable anymore https://gerrit.wikimedia.org/r/531963 TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 531727 abandoned by Tonina Zhelyazkova: bridge: copy EventEmittingButton Reason: Not applicable anymore https://gerrit.wikimedia.org/r/531727 TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 532292 abandoned by Tonina Zhelyazkova: bridge: Aligments with OOUI Reason: Not applicable anymore https://gerrit.wikimedia.org/r/532292 TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 532293 abandoned by Tonina Zhelyazkova: bridge: button tag switch Reason: does not apply anymore https://gerrit.wikimedia.org/r/532293 TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabricator.wikimedia.org/

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 530865 abandoned by Michael Große: bridge: Create reusable button component Reason: a different chain has been merged https://gerrit.wikimedia.org/r/530865 TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabr

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 536225 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Make EventEmittingButton accessible if used as button https://gerrit.wikimedia.org/r/536225 TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES ht

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Michael added a comment. @Charlie_WMDE Another topic that came up is the question of which effect pressing the space bar should have, if the button is an overloaded or a pure link. This is not needed for the current use-case, but it is likely to come up in the future. (An example of the bu

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Michael added a comment. @Charlie_WMDE Two UX related things that came up during working on this: 1. OOUI buttons look different when they are clicked with the mouse or activated by the enter or space key. We are not entirely sure whether this is actually intended by the people of OOU

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 536139 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: vertically align EventEmittingButton text https://gerrit.wikimedia.org/r/536139 TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabri

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 536138 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: add squary option to EventEmittingButton https://gerrit.wikimedia.org/r/536138 TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabric

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 536137 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: mend EventEmittingButton per OOUI https://gerrit.wikimedia.org/r/536137 TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabricator.wi

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 536016 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: copy EventEmittingButton https://gerrit.wikimedia.org/r/536016 TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 536225 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Make EventEmittingButton accessible if used as button https://gerrit.wikimedia.org/r/536225 TASK DETAIL https://phabrica

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 536139 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: vertically align EventEmittingButton text https://gerrit.wikimedia.org/r/536139 TASK DETAIL https://phabricato

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 536137 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: mend EventEmittingButton per OOUI https://gerrit.wikimedia.org/r/536137 TASK DETAIL https://phabricator.wikime

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 536138 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: add squary option to EventEmittingButton https://gerrit.wikimedia.org/r/536138 TASK DETAIL https://phabricator

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 536016 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Matthias Geisler): [mediawiki/extensions/Wikibase@master] bridge: copy EventEmittingButton https://gerrit.wikimedia.org/r/536016 TASK DETAIL https://phabricator.wikimedia.org/T230

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Michael added a comment. In T230326#5475526 , @Pablo-WMDE wrote: > Hanna however was kind enough to point a key difference between the "primaryprogressive" button as used in termbox and the one we can observe in the bridge spec and the

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

alaa_wmde added a comment. I finally got the time to pay attention to this task. I'm apparently too late to the party, for which I deeply apologize, esp. to @Pablo-WMDE and @Matthias_Geisler_WMDE who did ping me before in person to have a look, which I failed to do //for reasons// **tl;

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Pablo-WMDE added a comment. Talked with @Hanna_Petruschat_WMDE ragarding "bullet 3", i.e. the reasoning back when during termbox. She confirmed that the "primaryprogressive" button implemented for termbox is indeed supposed to follow the OOUI specification and all discrepancies can be consid

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Charlie_WMDE added a comment. @Pablo-WMDE From my perspective bullet 1 is definitely correct. I can not speak for bullet 3. That is probably in the heads of the termbox devs and @Hanna_Petruschat_WMDE Depending on the correctness of bullet 3, we would have an answer to this question > i

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Pablo-WMDE added a comment. Thanks for following up on this @Charlie_WMDE > is there a discrepancy between the OOUI primary progressive button and the one that was implemented for termbox? I would not know but I heard rumors there are. The good thing is It does not really matter and

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Matthias_Geisler_WMDE added a comment. @Charlie_WMDE at this particular one there is very tiny difference in the active-focus behavior. TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Charlie_WMDE added a comment. @Pablo-WMDE Thank you for the overview. I have still not understood for the specific case you mentioned, is there a discrepancy between the OOUI primary progressive button and the one that was implemented for termbox? TASK DETAIL https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Charlie_WMDE added a comment. In T230326#5458725 , @Michael wrote: > In T230326#5458613 , @Charlie_WMDE wrote: > >> I think the implication for UX/product would be that the permutat

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Lucas_Werkmeister_WMDE added a comment. In T230326#5460245 , @Michael wrote: > My understanding was that `ButtonWidget`

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Michael added a comment. In T230326#5459413 , @Lucas_Werkmeister_WMDE wrote: > Side note: OOUI has two general classes for buttons. In both, a tag name is configurable, but `ButtonWidget`

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Lucas_Werkmeister_WMDE added a comment. Side note: OOUI has two general classes for buttons. In both, a tag name is configurable, but `ButtonWidget` is for general, client-handled buttons (`` by default), whereas `Butto

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Michael added a comment. In T230326#5458613 , @Charlie_WMDE wrote: > I think the implication for UX/product would be that the permutation-option allows for quicker button creation in the future (which is good since we'll definitely need

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Matthias_Geisler_WMDE added a comment. > Example 1: > The Termbox cancel button has different hover behavior and click/active styles than a frameless, icon only ButtonWidget > > Termbox cancel button: https://tools-static.wmflabs.org/wikibase-termbox-storybook/?path=/story/eventemitti

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Michael added a comment. Maybe my post above was a bit too concise, so here is a longer version of my reasoning. Also, some update. I think we should not try to extract a single component that replaces all usages of the `EventEmittingButton` component in Termbox. From my point of view

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Matthias_Geisler_WMDE added a comment. Meta note: To be honest I do not like, how this discussion is now starting – putting somewhere a -2 and start a discussion without a appropriate pointing on the concrete thing where you see the problems. | As written above, I think trying to genera

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Michael added a comment. As written above, I think trying to generalize the Termbox EventEmittingButton to be used everywhere in Bridge is an approach that is flawed in its premises. This creates an overly complex component that does multiple jobs (Link and pure Button) and tries to conform

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Jakob_WMDE added a comment. Apologies for popping in unsolicited, but it looks like this task and its patches took a strange turn. The original idea was to start sharing the component with Termbox (says so in the title/description), which I think is great. Then, based on the `a` tag vs

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 532293 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler): [mediawiki/extensions/Wikibase@master] bridge: button tag switch https://gerrit.wikimedia.org/r/532293 TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAI

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 532292 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler): [mediawiki/extensions/Wikibase@master] bridge: Aligments with OOUI https://gerrit.wikimedia.org/r/532292 TASK DETAIL https://phabricator.wikimedia.org/T230326 EM

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 531727 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler): [mediawiki/extensions/Wikibase@master] bridge: copy EventEmittingButton https://gerrit.wikimedia.org/r/531727 TASK DETAIL https://phabricator.wikimedia.org/T23032

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 531963 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler): [mediawiki/extensions/Wikibase@master] bridge: Modify EventEmittingButton https://gerrit.wikimedia.org/r/531963 TASK DETAIL https://phabricator.wikimedia.org/T230

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

gerritbot added a comment. Change 530865 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Create reusable button component https://gerrit.wikimedia.org/r/530865 TASK DETAIL https://phabricator.wikimedia.org/T23

[Wikidata-bugs] [Maniphest] [Commented On] T230326: Reuse EventEmittingButton from termbox

Michael added a comment. That `EventEmittingButton` component uses a link (``) with `href="#"` and styled as a button. This is an anti-pattern and poses accessibility issues . If we need a button, then let's use a semantically correct e