[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel removed a subtask: T233350: ActiveAbstract: remove dependency on pre-MCR 
database schema.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: holger.knust, daniel
Cc: BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[WDoranWMF]

WDoranWMF changed the point value for this task from "1" to "5".

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WDoranWMF
Cc: BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[CCicalese_WMF]

CCicalese_WMF edited projects, added Core Platform Team Workboards (Purple); 
removed Core Platform Team Workboards (Clinic Duty Team).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: CCicalese_WMF
Cc: BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Wikidata-bugs, Mbch331, Ltrlg, Pchelolo, mobrovac
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[CCicalese_WMF]

CCicalese_WMF removed parent tasks: T184615: Once MCR is deployed, drop the 
rev_text_id, rev_content_model, and rev_content_format fields from the revision 
table, T198557: Remove support for writing to the pre-MCR schema, T198492: Drop 
rev_text_id and ar_text_id when running update.php, T183487: MCR schema 
migration stage 3: stop using legacy fields, T198312: Set the WMF cluster to 
use the new MCR-only schema.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: CCicalese_WMF
Cc: BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[CCicalese_WMF]

CCicalese_WMF added a parent task: T231693: No direct or indirect access to 
pre-MCR fields is ungated.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: CCicalese_WMF
Cc: BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[CCicalese_WMF]

CCicalese_WMF edited projects, added CPT Initiatives (MCR Schema Migration); 
removed CPT Initiatives (MCR).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: CCicalese_WMF
Cc: BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[CCicalese_WMF]

CCicalese_WMF added a project: Core Platform Team (MCR).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: CCicalese_WMF
Cc: BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[Fjalapeno]

Fjalapeno edited projects, added Core Platform Team; removed Core Platform Team 
(MCR).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Fjalapeno
Cc: BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Sario528, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, 
_jensen, rosalieper, Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[WDoranWMF]

WDoranWMF edited projects, added Core Platform Team Workboards (Clinic Duty 
Team); removed Core Platform Team Workboards (Purple).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WDoranWMF
Cc: BPirkle, tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Sario528, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, 
_jensen, rosalieper, Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a subtask: T228675: Remove direct access to the text table from 
the Translate extension..

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, aude, Aklapper, daniel, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Sario528, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[WDoranWMF]

WDoranWMF edited projects, added Core Platform Team Workboards (Purple); 
removed Core Platform Team Workboards (Team 3).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, WDoranWMF
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel removed a subtask: T220884: Update the DeletePagesForGood extension for 
MCR.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[BPirkle]

BPirkle added a comment.


  I've uploaded patches for all issues identified in this task. In an effort to 
keep this task focused on ar_text_id and rev_text_id, I created several related 
tasks for things that deserve attention and which are related to MCR, but not 
directly to rev_text_id or ar_text_id:
  
  T220884  (additional 
DeletePagesForGood extension updates)
  T227836  (maintenance script 
related to DeletePagesForGood, but possibly also generically useful)
  T227840  (additional Duplicator 
extension updates)
  
  While it may be slightly disingenuous to push the additional work to other 
tasks and declare this task done, I think it does make sense to move the 
extension work that is not part of the MCR Schema migration critical path to 
more focused tasks. Focused tasks are good practice, and extension-specific 
tasks are more likely to be noticed by people interested in those specific 
extensions.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[GeoffreyT2000]

GeoffreyT2000 added a subtask: T220884: Update the DeletePagesForGood extension 
for MCR.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, GeoffreyT2000
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[ReleaseTaggerBot]

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.14; 
2019-07-16); removed MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, ReleaseTaggerBot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, EvanProdromou, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[CCicalese_WMF]

CCicalese_WMF edited projects, added Core Platform Team Kanban (Team 3); 
removed Core Platform Team Kanban (Doing).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, CCicalese_WMF
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, EvanProdromou, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[Anomie]

Anomie added a comment.


  In T198341#5137816 , 
@Anomie wrote:
  
  > For that matter, I should run a query on the Analytics data to see whether 
we can just remove ApiQueryDeletedrevs entirely yet.
  
  
  T221869: Remove deprecated ApiQueryDeletedRevs 

  
  Possibly still worth removing the `ar_text_id` uses to close out this task 
though.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, Anomie
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[BPirkle]

BPirkle added a comment.


  Unless I'm missing something, @Anomie already did the bulk of the work for 
the first two (ApiQueryAllDeletedRevisions and ApiQueryDeletedRevisions) in 
commit 07842be3 
 
as part of T200568 , particularly by 
adding ApiQueryRevisionsBase::extractSlotInfo().
  
  ApiQueryDeletedrevs would require larger changes because, as Anomie noted in 
the commit message for 07842be3 
 
, "ApiQueryDeletedrevs wasn't touched,
  since it has been deprecated since 1.25 anyway." May I remove it? If not, may 
I no-op it?
  
  I'm posting a change for just the first two bullet points. If I can remove or 
no-op ApiQueryDeletedrevs, I'll do that as a separate change.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, ReleaseTaggerBot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel edited projects, added Core Platform Team Kanban (Waiting for Review); 
removed Core Platform Team Kanban (Doing).
daniel added a comment.


  One patch waiting for review, and a few things to do in extensions. Nearly 
done.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[WDoranWMF]

WDoranWMF set the point value for this task to "1".

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, WDoranWMF
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[ReleaseTaggerBot]

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.25; 
2019-04-09); removed MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, ReleaseTaggerBot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[BPirkle]

BPirkle added a comment.


  Per discussion in this task, I created new task T220450 
 for the additional Postgres changes 
(searchindex table).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, ReleaseTaggerBot
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[Anomie]

Anomie added a comment.


  In T198341#5022412 , 
@daniel wrote:
  
  > In T198341#5021347 , 
@BPirkle wrote:
  >
  > > - includes/search/SearchPostgres.php
  >
  >
  > odd stuff, maybe @anomie can help. Two uses seem completely pointless, the 
third one should probably use getQueryInfo?
  
  
  Note in the PostgreSQL schema the "text" table is named "pagecontent". That 
was done in rSVN15791 ; I don't 
know why quoting wasn't just used instead. The plan for T164898 
/T191231 
 includes renaming it back to "text".
  
  It looks like that file needs some #technical-debt 
 cleanup to use the 
IDatabase querying methods rather than building SQL strings directly, but that 
alone would probably be out of scope here.
  
  What is in scope is that it's trying to search directly against the `text` 
table, having added an extra column for that purpose, and will need to be 
converted to use a `searchindex` table like MySQL does.
  
  >> - tests/phpunit/includes/ActorMigrationTest.php
  > 
  > I think Anomie siad somehwre that the rev_text_id stuff should just be 
removed, right?
  
  Correct. That was just above in T198341#5020970 
.
  
  > I recommend doing separate patches for all of these.
  
  Here's one place where Daniel and I differ: I'd put most of these in one 
patch instead of having 10+ single-file changes.
  
  SearchPostgres.php seems complicated enough that it would make sense to do it 
separately though, since it's going to involve a schema change for PG plus 
probably significant edits to the file itself.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, Anomie
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[BPirkle]

BPirkle added a comment.


  In T198341#5022332 , 
@daniel wrote:
  
  > > includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All 
other references are either gated directly, or are in private functions with 
all calls gated)
  >
  > getQueryInfo() should have proper gating as well. If you think it  does 
not, let's talk before you change things.
  
  
  I looked again, you are correct. I saw the comment mentioning this task 
(T198341 ) and initially thought 
there was something to do.  We just need to be sure callers don't pass a "text" 
option, but that's already covered under T198342 
 (which is probably a good candidate 
for my next task after I finish this one).  So nothing to do to getQueryInfo() 
at the moment.
  
  Thanks very much for your comments on the other items.  I'll proceed down the 
list, making separate patches for each.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[Anomie]

Anomie added a comment.


  > I'll also remove any references to the other two fields [text.old_id and 
archive.ar_text_id]
  
  Note that text.old_id references are probably sill valid in low-level code 
like HistoryBlob.php and SqlBlobStore.
  
  > - maintenance/populateContentTables.php
  
  This maintenance script is intended to be called during update when 
rev_text_id still exists in the database, specifically to migrate data //out 
of// rev_text_id before dropping the column.
  
  At some point it'll probably gain a check near line 190 

 something like
  
if ( !$this->dbw->fieldExists( $table, $fields['text_id'], __METHOD__ ) ) {
$this->output( "No need to populate, $table.{$fields['text_id']} field 
does not exist\n" );
return;
}
  
  Whether that's done during this task or T184615 
, I have no real opinion.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, Anomie
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[BPirkle]

BPirkle added a subscriber: tstarling.
BPirkle added a comment.


  Thank you.  With that in mind, here's my current understanding. The list 
below applies only to rev_text_id, not ar_text_id or text.old_id. When touching 
code for rev_text_id, I'll also remove any references to the other two fields. 
I'll then loop back and review/remove any remaining references to them.
  
  rev_text_id references that will be removed/refactored in this task:
  
  - includes/Revision/RevisionStore.php (I'll touch only getQueryInfo().  All 
other references are either gated directly, or are in private functions with 
all calls gated)
  - includes/search/SearchPostgres.php
  - maintenance/Maintenance.php
  - maintenance/populateContentTables.php
  - maintenance/rebuildtextindex.php
  - maintenance/storage/checkStorage.php
  - maintenance/storage/compressOld.php
  - maintenance/storage/fixT22757.php (this script will be removed entirely, 
pending confirmation from @tstarling )
  - maintenance/storage/trackBlobs.php
  - tests/phpunit/includes/ActorMigrationTest.php
  
  rev_text_id references that will not be touched in this task:
  
  - HISTORY (documentation)
  - includes/export/WikiExporter.php (gated, will be addressed in T198706 
 and T174031 
)
  - includes/export/XmlDumpWriter.php (will be addressed in T198706 
 and T174031 
)
  - includes/installer/MssqlUpdater.php (schema, historical)
  - includes/installer/MysqlUpdater.php (schema, historical)
  - includes/installer/PostgresUpdater.php (schema, historical)
  - includes/installer/SqliteUpdate.php (schema, historical)
  - includes/page/WikiPage.php (gated)
  - includes/Revision.php (gated and deprecated)
  - includes/Revision/RevisionStore.php (I'll touch only getQueryInfo().  All 
other references are either gated directly, or are in private functions with 
all calls gated)
  - maintenance/tables.sql (schema)
  - maintenance/archives/patch-rev_text_id-default.sql (schema, historical)
  - maintenance/archives/patch-rev_text_id.sql (schema, historical)
  - maintenance/mssql/tables.sql (schema)
  - maintenance/mssql/archives/patch-rev_text_id-default.sql (schema, 
historical)
  - maintenance/oracle/tables.sql (schema)
  - maintenance/postgres/tables.sql (schema)
  - maintenance/postgres/patch-textsearch_bug66650.sql (schema)
  - maintenance/sqlite/archives/initial-indexes.sql (schema)
  - maintenance/sqlite/archives/patch-comment-table.sql (schema)
  - maintenance/sqlite/archives/patch-rev_text_id-default.sql (schema, 
historical)
  - tests/phpunit/data/db/sqlite/tables-1.13.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.15.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.16.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.17.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.18.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.19.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.20.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.21.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.22.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.23.sql (historical)
  - tests/phpunit/includes/RevisionMcrReadNewDbTest.php (testing)
  - tests/phpunit/includes/RevisionMcrWriteBothDbTest.php (testing)
  - tests/phpunit/includes/RevisionNoContentModelDbTest.php (testing)
  - tests/phpunit/includes/RevisionPreMcrDbTest.php (testing)
  - tests/phpunit/includes/Revision/create-pre-mcr-fiels.sql (testing)
  - tests/phpunit/includes/Revision/drop-pre-mcr-fields.sql (testing)
  - tests/phpunit/includes/Revision/McrReadNewRevisionStoreDbTest.php (testing)
  - tests/phpunit/includes/Revision/McrWriteBothRevisionStoreDbTest.php 
(testing)
  - tests/phpunit/includes/Revision/NoContentModelRevisionStoreDbTest.php 
(testing)
  - tests/phpunit/includes/Revision/PreMcrRevisionStoreDbTest.php (testing)
  - tests/phpunit/includes/Revision/RevisionQueryInfoTest.php (testing)
  - tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php (testing)
  - tests/phpunit/includes/Revision/RevisionStoreTest.php (testing)
  
  If anyone notices anything glaringly incorrect in that list, please let me 
know. Otherwise, I'll proceed and ask any further questions as they arise.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[Anomie]

Anomie added a comment.


  Yes. You should just be able to delete the two references.
  
  When the code was added in rMW27c61fb1e94d: Add `actor` table and code to 
start using it 
 
`rev_text_id` did not have a default and so needed to be specified for the 
INSERTs to succeed. That was later changed in rMW8d15ade67267: Add default for 
revision.rev_text_id where missing 
,
 so now the `rev_text_id` can be omitted.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, Anomie
Cc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, 
alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a comment.


  In T198341#5019920 , 
@BPirkle wrote:
  
  > Question on one occurrence of these fields:  is the maintenance script 
fixT22757.php still relevant?
  
  
  Looks like T22757  was resolved in 
2010, so I think we can get rid of that script :) Just make a patch to removed 
it. Best ping Tim about it, just to be sure.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, daniel
Cc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, 
alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[MBinder_WMF]

MBinder_WMF removed a project: Multimedia.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle, MBinder_WMF
Cc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, 
alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg, 
V4switch, Wong128hk, matthiasmullie, Fabrice_Florin, Matanya
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel edited projects, added Core Platform Team Kanban; removed Core Platform Team Backlog (Later).
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, Wikidata-bugs, Mbch331, Ltrlg, holger.knust___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a parent task: T184615: Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields to be dropped from revision.
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, holger.knust, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, Wikidata-bugs, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a parent task: T198557: Remove support for legacy pre-MCR schema.
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, holger.knust, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, Wikidata-bugs, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[CCicalese_WMF]

CCicalese_WMF added projects: Core Platform Team Kanban (Later), Core Platform Team (MCR: Tech Debt).
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CCicalese_WMFCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Wikidata-bugs, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[Jdforrester-WMF]

Jdforrester-WMF edited projects, added SDC Engineering; removed SDC General.
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdforrester-WMFCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Wikidata-bugs, Mbch331, Ltrlg, PDrouin-WMF, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, Tramullas, Acer, Susannaanas, Aschroet, Jane023, Base, matthiasmullie, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC phase 2).daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONAny code that accesses  rev_text_id and ar_text_id fields prevents us from eis unabling storing extra slots besides the main slote to make use of MCR. In order to enable for MCR support, all references to these fields have to be removed from the code. They should be replaced with RevisionStore::getQueryInfo(),  RevisionStore::newRevisionRecordFromRow(), and RevisionRecord::getContent()TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a parent task: T198492: Drop rev_text_id and ar_text_id when running update.php.
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[gerritbot]

gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

[daniel]

daniel added a parent task: T183487: MCR schema migration stage 3: drop support for legacy fields.
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs