[MediaWiki-CodeReview] [MediaWiki r89677]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89677. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89677#c0 Commit summary: 1.17: MFT r88492, r88870, r88871, r89003, r89108, r89114, r89115, r89129, r89532, r89653

[MediaWiki-CodeReview] [MediaWiki r89677]: New comment added

2011-06-07 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89677. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89677#c17760 Commit summary: 1.17: MFT r88492, r88870, r88871, r89003, r89108, r89114, r89115, r89129, r89532, r89653 Comment: See r89679.

[MediaWiki-CodeReview] [MediaWiki r89678]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r89678. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89678#c0 Commit summary: Adding my USERINFO file. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r86236]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86236. Old Status: deferred New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86236#c0 Commit summary: corrected computation of ISO serialisation ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r86236]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86236. Old Status: reverted New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86236#c0 Commit summary: corrected computation of ISO serialisation ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r86326]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86326. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86326#c0 Commit summary: Update all core calls of SpecialPage-getName(); ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r86307]: New comment added

2011-06-07 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r86307. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86307#c17762 Commit summary: Few style/whitespace/comment issues from r86169 Comment: commented code removed in Exif-isUndefined() Maybe we should keep it around.

[MediaWiki-CodeReview] [MediaWiki r86276]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86276. Old Status: deferred New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86276#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-04-17 19:30:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r86334]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r86334. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86334#c17763 Commit summary: Revert r86236 Comment: What revision was I actually reverting? :S ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r86227]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86227. Old Status: deferred New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86227#c0 Commit summary: Localisation updates from translatewiki.net. ___

[MediaWiki-CodeReview] [MediaWiki r86187]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86187. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86187#c0 Commit summary: Fix for r86186: correct check ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r86186]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86186. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86186#c0 Commit summary: * (bug 25946) The message on the top of Special:RecentChanges is now displayed in user language instead of content

[MediaWiki-CodeReview] [MediaWiki r86301]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86301. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86301#c0 Commit summary: Update messages files for r86294: revert of r86186, r86187, r86227, r86276. * also contains recent translations from

[MediaWiki-CodeReview] [MediaWiki r86294]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86294. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86294#c0 Commit summary: (bug 28590) Temporary revert of r86186, r86187, r86227, r86276: caused instant breakage of Wikimedia websites via

[MediaWiki-CodeReview] [MediaWiki r86334]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r86334. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86334#c17764 Commit summary: Revert r86236 Comment: r86326 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org

[MediaWiki-CodeReview] [MediaWiki r86334]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r86334. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86334#c0 Commit summary: Revert r86236 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r86334]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r86334. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86334#c17765 Commit summary: Revert r86236 Comment: The code doesn't exist in trunk it's now $t = $this-getTitle(); ___

[MediaWiki-CodeReview] [MediaWiki r86083]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86083. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86083#c0 Commit summary: Another table parser test ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r86067]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86067. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86067#c0 Commit summary: Update undelete.php to use short option aliases. People using --u and --r will need to change either to -u or --user for --u

[MediaWiki-CodeReview] [MediaWiki r86061]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86061. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86061#c0 Commit summary: Allow people to use apos; entity (sinqle quote character: ') in wikitext. It probably wasn't included originally, as its

[MediaWiki-CodeReview] [MediaWiki r86061]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86061. Old Status: ok New Status: new User Hashar also posted a comment on MediaWiki.r86061. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86061#c17766 Commit summary: Allow people to use apos; entity (sinqle quote character: ') in

[MediaWiki-CodeReview] [MediaWiki r87121]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r87121. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87121#c0 Commit summary: Remove pointless warning: ceratinly I can't imagine why we show a warning when using a filter versus not using one (below

[MediaWiki-CodeReview] [MediaWiki r85917]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r85917. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85917#c0 Commit summary: Reverting r85784 for good measure too (Pending better solution) ___

[MediaWiki-CodeReview] [MediaWiki r87122]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r87122. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87122#c0 Commit summary: Per discussion on Mediawiki-l, talk about the GROUP BY issue a bit. ___

[MediaWiki-CodeReview] [MediaWiki r86747]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r86747. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86747#c0 Commit summary: Allow rows missing iw_trans or iw_local to be considered valid. ___

[MediaWiki-CodeReview] [MediaWiki r85807]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r85807. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85807#c0 Commit summary: Add MWInit to AutoLoader, see if we unbreak doxygen ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r86733]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r86733. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86733#c0 Commit summary: Follow-up r86732: really mark it as deprecated ;) ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r85224]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r85224. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85224#c0 Commit summary: Don't convert text to a variant, if it is already written in that variant (to reduce use of -{}-)

[MediaWiki-CodeReview] [MediaWiki r86443]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r86443. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86443#c0 Commit summary: Quick comments for r79036 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r85323]: New comment added

2011-06-07 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r85323. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85323#c17767 Commit summary: Type hints to substring used in integer addition Comment: what is the hint for? Isn't PHP able to handle : 42 * 60 ?

[MediaWiki-CodeReview] [MediaWiki r85323]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r85323. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85323#c17768 Commit summary: Type hints to substring used in integer addition Comment: Just more obvious ___ MediaWiki-CodeReview mailing

Re: [Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code

2011-06-07 Thread Chad
On Tue, Jun 7, 2011 at 2:56 PM, Brion Vibber br...@pobox.com wrote: Currently working (mostly backwards) to fill in the Code Review holes from before 1.18 branch point: http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWikioffset=87519path=%2Ftrunk%2Fphase3 Roadmap provisionally

Re: [Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code

2011-06-07 Thread Roan Kattouw
On Tue, Jun 7, 2011 at 8:56 PM, Brion Vibber br...@pobox.com wrote: Currently working (mostly backwards) to fill in the Code Review holes from before 1.18 branch point: http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWikioffset=87519path=%2Ftrunk%2Fphase3 Yay! Did you see the

[MediaWiki-CodeReview] [MediaWiki r85004]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r85004. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r85004. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85004#c17769 Commit summary: Fixup some ambiguously defined variables Cast a substr back to

[MediaWiki-CodeReview] [MediaWiki r84796]: New comment added

2011-06-07 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r84796. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84796#c17770 Commit summary: Break svn blame on every single line of SpecialWatchlist.php by converting it to subclass SpecialPage and hence changing the indentation :D.

[MediaWiki-CodeReview] [MediaWiki r86061]: New comment added

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r86061. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86061#c17771 Commit summary: Allow people to use apos; entity (sinqle quote character: ') in wikitext. It probably wasn't included originally, as its not part of html4, but was

Re: [Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code

2011-06-07 Thread Brion Vibber
On Tue, Jun 7, 2011 at 12:58 PM, Roan Kattouw roan.katt...@gmail.comwrote: On Tue, Jun 7, 2011 at 8:56 PM, Brion Vibber br...@pobox.com wrote: Currently working (mostly backwards) to fill in the Code Review holes from before 1.18 branch point:

[MediaWiki-CodeReview] [MediaWiki r87340]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87340. Old Status: new New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r87340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87340#c17772 Commit summary: Moved printfooter and debug HTML away from

[MediaWiki-CodeReview] [MediaWiki r84739]: New comment added

2011-06-07 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r84739. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84739#c17773 Commit summary: Changes default value so that it's not converted to array( 0 = '' ) by the (array) cast a few lines below. This was breaking the check whether the magic

[MediaWiki-CodeReview] [MediaWiki r89683]: New comment added

2011-06-07 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r89683. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89683#c17774 Commit summary: Comment: Sorry, missed the comment: Add i18n file, add extension to Translatewiki ___

[MediaWiki-CodeReview] [MediaWiki r89683]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89683. Old Status: new New Status: ok User ^demon also posted a comment on MediaWiki.r89683. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89683#c17775 Commit summary: Comment: Fix Lingo description, add to Translatewiki?

[MediaWiki-CodeReview] [MediaWiki r87322]: New comment added

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r87322. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87322#c17776 Commit summary: Tablesorter: Add a title attribute to sort arrows ( Bug 21453 ) Comment: Honestly I'm a bit leery of this; the appearance of the arrow shows the

[MediaWiki-CodeReview] [MediaWiki r87203]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r87203. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87203#c0 Commit summary: (bug 28738) Implement request splitting in mw.loader so ResourceLoader requests with query strings longer than a

[MediaWiki-CodeReview] [MediaWiki r89676]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89676. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89676#c0 Commit summary: 1.17: MFT r82247, r87203, r87265, r87494, r87497, r87711, r87840, r88076, r89615

[MediaWiki-CodeReview] [MediaWiki r87322]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87322. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87322#c0 Commit summary: Tablesorter: Add a title attribute to sort arrows ( Bug 21453 ) ___

[MediaWiki-CodeReview] [MediaWiki r87479]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r87479. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87479#c0 Commit summary: Fixed some register_globals vulnerabilities. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r87266]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r87266. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87266#c0 Commit summary: Adjust maxwidth calculation for galleries. Bug 27577 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r84739]: New comment added

2011-06-07 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r84739. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84739#c1 Commit summary: Changes default value so that it's not converted to array( 0 = '' ) by the (array) cast a few lines below. This was breaking the

[MediaWiki-CodeReview] [MediaWiki r87333]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r87333. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87333#c0 Commit summary: MFT r87266 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r87320]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87320. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87320#c0 Commit summary: Removed Skin::$usercss, always false, nothing sets this ___

[MediaWiki-CodeReview] [MediaWiki r87302]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87302. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87302#c0 Commit summary: Kill from r87290 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r88902]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r88902. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88902#c0 Commit summary: Merge r87235 to 1.17, fix will have to go in 1.18. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89250]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89250. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89250#c0 Commit summary: * upgrade patches for oracle 1.17-1.19 * fixed tableExists to handle possible username-dbname difference * added indexExists

[MediaWiki-CodeReview] [MediaWiki r89252]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89252. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89252#c0 Commit summary: * MFT r89250. only the tableExists function ad 1.17 already supports user-dbname difference

[MediaWiki-CodeReview] [MediaWiki r87290]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87290. Old Status: new New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r87290. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87290#c17778 Commit summary: Add makeInsertOptions Allow Sqlite to OR

[MediaWiki-CodeReview] [MediaWiki r89358]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89358. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89358#c0 Commit summary: (bug 29117) A string is missing when the UI is in Hebrew Backport r88658 ___

[MediaWiki-CodeReview] [MediaWiki r89488]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r89488. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89488#c0 Commit summary: code documentation for $wgPreprocessorCacheThreshold follow up r80180 ___

[MediaWiki-CodeReview] [MediaWiki r89269]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89269. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89269#c0 Commit summary: Manually merge r89266 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89268]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89268. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89268#c0 Commit summary: Manually merge r89266 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89407]: New comment added

2011-06-07 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r89407. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89407#c17779 Commit summary: Don't execute the loop if there's no X-Forwarded-For header, also don't use isset() to check only for null Comment: The problem

[MediaWiki-CodeReview] [MediaWiki r89509]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r89509. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89509#c0 Commit summary: -Whelp to dump available warning keys from r89343 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89681]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89681. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89681#c0 Commit summary: Followup to r86061: add parser test case to confirm that 'apos' in wikitext doesn't make it to output. 'apos;' is not

[MediaWiki-CodeReview] [MediaWiki r89684]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89684. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89684#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-06-07 20:30:00 39:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r81619]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r81619. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81619#c0 Commit summary: * (bug 18011) Special:FileDuplicateSearch UI fixes and remote file repo support Fixes: - now accepts file titles with or

[MediaWiki-CodeReview] [MediaWiki r89407]: New comment added

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r89407. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89407#c17780 Commit summary: Don't execute the loop if there's no X-Forwarded-For header, also don't use isset() to check only for null Comment: You would at least need to

[MediaWiki-CodeReview] [MediaWiki r82102]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r82102. Old Status: new New Status: ok User ^demon also posted a comment on MediaWiki.r82102. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82102#c17781 Commit summary: * (bug 26298) Throw warning instead of silently saving blank

[MediaWiki-CodeReview] [MediaWiki r85362]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r85362. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85362#c0 Commit summary: * (bug 28417) Fix PHP notice when importing revision without a listed id ___

[MediaWiki-CodeReview] [MediaWiki r85410]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r85410. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85410#c0 Commit summary: * (bug 24755) AuthPlugin auto-creation of local accounts can now be aborted by other extensions by handling the

[MediaWiki-CodeReview] [MediaWiki r85545]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r85545. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85545#c0 Commit summary: Followup to r85504: add missing .js file ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r87292]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87292. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r87292. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87292#c17783 Commit summary: * (bug 20468) User::invalidateCache throws 1205:

[MediaWiki-CodeReview] [MediaWiki r87292]: New comment added

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r87292. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87292#c17784 Commit summary: * (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded Severly limit the number of calls that actually update the database

Re: [Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code

2011-06-07 Thread Krinkle
Brion Vibber wrote: On Tue, Jun 7, 2011 at 12:58 PM, Roan Kattouw roan.katt...@gmail.comwrote: On Tue, Jun 7, 2011 at 8:56 PM, Brion Vibber br...@pobox.com wrote: Currently working (mostly backwards) to fill in the Code Review holes from before 1.18 branch point:

Re: [Wikitech-l] Update Gadgets extension on WMF wikis

2011-06-07 Thread Thomas Morton
Default gadgets would solve an issue I am facing at the moment :) So +1 to deployment of updates. Tom On 7 June 2011 22:25, Leo Koppelkamm diebu...@gmail.com wrote: There's usually some code (general utility fn's, some legacy remappings etc.) in common.js that could break a lot of stuff if

Re: [Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code

2011-06-07 Thread Rob Lanphier
On Tue, Jun 7, 2011 at 12:57 PM, Chad innocentkil...@gmail.com wrote: On Tue, Jun 7, 2011 at 2:56 PM, Brion Vibber br...@pobox.com wrote: Currently working (mostly backwards) to fill in the Code Review holes from before 1.18 branch point:

[MediaWiki-CodeReview] [MediaWiki r86334]: New comment added, and revision status changed

2011-06-07 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r86334. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r86334. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86334#c17785 Commit summary: Revert r86236 Comment: Thanks!

[MediaWiki-CodeReview] [MediaWiki r87292]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r87292. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87292#c17786 Commit summary: * (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded Severly limit the number of calls that actually update the database (for no

[MediaWiki-CodeReview] [MediaWiki r87286]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER changed the status of MediaWiki.r87286. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87286#c0 Commit summary: Switching arrows in Special:FileList to match the usual behaviour in MW. Bug 18962

[MediaWiki-CodeReview] [MediaWiki r87292]: New comment added

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r87292. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87292#c17787 Commit summary: * (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded Severly limit the number of calls that actually update the database

[MediaWiki-CodeReview] [MediaWiki r87292]: New comment added

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r87292. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87292#c17788 Commit summary: * (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded Severly limit the number of calls that actually update the database

[MediaWiki-CodeReview] [MediaWiki r87292]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r87292. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87292#c17789 Commit summary: * (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded Severly limit the number of calls that actually update the database (for no

[MediaWiki-CodeReview] [MediaWiki r87322]: New comment added

2011-06-07 Thread MediaWiki Mail
User DieBuche posted a comment on MediaWiki.r87322. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87322#c17791 Commit summary: Tablesorter: Add a title attribute to sort arrows ( Bug 21453 ) Comment: I think we both agree on the current behaviour of the arrows themselves (show

[MediaWiki-CodeReview] [MediaWiki r87292]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r87292. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87292#c17790 Commit summary: * (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded Severly limit the number of calls that actually update the database (for no

[MediaWiki-CodeReview] [MediaWiki r87322]: New comment added

2011-06-07 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r87322. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87322#c17792 Commit summary: Tablesorter: Add a title attribute to sort arrows ( Bug 21453 ) Comment: I don't think it is that confusing. If the tooltip would describe the

[MediaWiki-CodeReview] [MediaWiki r79479]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r79479. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79479#c0 Commit summary: Per my comment on r68760: Make MWfunction class, complete with call_user_func helper functions that automatically make the

[MediaWiki-CodeReview] [MediaWiki r87292]: New comment added

2011-06-07 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r87292. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87292#c17793 Commit summary: * (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded Severly limit the number of calls that actually update the database (for no

[MediaWiki-CodeReview] [MediaWiki r89471]: New comment added

2011-06-07 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r89471. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89471#c17794 Commit summary: Add BlockTest to the tests autoloader. Needed by ApiBlockTest.php Added tabs to other items (compare ignoring whitespace). Comment: Yes, API and

[MediaWiki-CodeReview] [MediaWiki r80129]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r80129. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80129#c0 Commit summary: Follow up r47852. Unlike forkWorkers(), the start() method doesn't get the $procs parameter.

[MediaWiki-CodeReview] [MediaWiki r80281]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r80281. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80281#c0 Commit summary: bug 10158 : do not mention allowing others to contact you if $wgEnableUserEmail=false This required to tweak

[MediaWiki-CodeReview] [MediaWiki r81562]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r81562. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81562#c0 Commit summary: doxygen: add support for EXCLUDE keyword ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r81563]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r81563. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81563#c0 Commit summary: Deprecated wfMsgWeirdKey(), use wfMessage() instead. Moved getDefaultMessageText() from Article to Title so that it can be

[MediaWiki-CodeReview] [MediaWiki r89688]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r89688. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89688#c0 Commit summary: Doc fix for r85410 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89689]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89689. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89689#c0 Commit summary: Follow up r85410 r89688. Try to make clearer that this is a message key. ___

[MediaWiki-CodeReview] [MediaWiki r83829]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r83829. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83829#c0 Commit summary: Follow-up r83827: a Block object will never be internally of TYPE_ID. ___

[MediaWiki-CodeReview] [MediaWiki r87292]: New comment added

2011-06-07 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r87292. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87292#c17795 Commit summary: * (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded Severly limit the number of calls that actually update the database

[MediaWiki-CodeReview] [MediaWiki r86627]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r86627. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86627#c0 Commit summary: Fix hook definition from r86482 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r89492]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89492. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89492#c0 Commit summary: install PHPUnit with MacPorts if available MFT r89479 r89480 ___

[MediaWiki-CodeReview] [MediaWiki r86519]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r86519. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86519#c0 Commit summary: FIx inconsistent messages in r86482. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r86513]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r86513. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86513#c0 Commit summary: Follow-up r86482: * Declare PasswordReset obsolete per release of MediaWiki 1.18 * Remove support from Translate extension.

[MediaWiki-CodeReview] [MediaWiki r89687]: Revision status changed

2011-06-07 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r89687. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89687#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-06-07 20:35:00 UTC)

[MediaWiki-CodeReview] [MediaWiki r89451]: New comment added

2011-06-07 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r89451. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89451#c17796 Commit summary: Followup r88124: fix the most glaring bug of the week Comment: Well done! ___ MediaWiki-CodeReview

<    1   2   3   4   >