[MediaWiki-CodeReview] [MediaWiki r97136]: New comment added, and revision status changed

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r97136. Old Status: new New Status: ok User "Nikerabbit" also posted a comment on MediaWiki.r97136. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97136#c22568 Commit summary: Add support for a second argument to wfDeprecated so

Re: [Wikitech-l] Alternatives to LimeSurvey

2011-09-14 Thread Dmitriy Sintsov
* Erik Moeller [Wed, 14 Sep 2011 17:40:07 -0700]: > Hi folks, > > we've been using LimeSurvey for the last couple of years to run > Wikimedia surveys, but as we pushed it to its limits, we've surfaced > numerous problems, including security vulnerabilities and major > concurrency issues. It's got

[MediaWiki-CodeReview] [MediaWiki r97129]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r97129. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97129 Commit summary: prevent users from being able to get a disabled survey ___ MediaWiki-Cod

[MediaWiki-CodeReview] [MediaWiki r97128]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r97128. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97128 Commit summary: rem stupid code ___ MediaWiki-CodeReview mailing list mediawiki-coderev.

[MediaWiki-CodeReview] [MediaWiki r97127]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r97127. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97127 Commit summary: restricted access to survey statistics via the API to survey admins ___

[MediaWiki-CodeReview] [MediaWiki r97099]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r97099. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97099 Commit summary: MFT r97098: revert of r80746 to fix bug 30900 ___ MediaWiki-CodeReview mailin

[MediaWiki-CodeReview] [MediaWiki r97098]: New comment added, and revision status changed

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r97098. Old Status: new New Status: ok User "Nikerabbit" also posted a comment on MediaWiki.r97098. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97098#c22567 Commit summary: * (bug 30900) Remove confusing default value added fo

[MediaWiki-CodeReview] [MediaWiki r97096]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r97096. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97096#c22566 Commit summary: Typo fixed in message text of MediaWiki:logentry-suppress-delete see http://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Logentry-suppress-

[MediaWiki-CodeReview] [MediaWiki r97091]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r97091. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97091#c22565 Commit summary: FU r89706: Cleaned up getParserOptions duplication problems Comment: $wgLanguageCode is now unused. __

[MediaWiki-CodeReview] [MediaWiki r97083]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r97083. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97083 Commit summary: Paste mistake, these two oldid methods were next to each other but ended up with the robots stuff pasted in between accid

[MediaWiki-CodeReview] [MediaWiki r97073]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r97073. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97073 Commit summary: Added @todo items ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@

[MediaWiki-CodeReview] [MediaWiki r97071]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r97071. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97071 Commit summary: Introduce Language::getMessageKeysFor() and use it in ApiQueryAllmessages ___

[MediaWiki-CodeReview] [MediaWiki r96889]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r96889. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96889 Commit summary: Committed old wmf maintenenace script ___ MediaWiki-CodeReview mailing list media

[MediaWiki-CodeReview] [MediaWiki r96906]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r96906. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96906 Commit summary: Updated r86144 code due to reverts in r96889 (specifically of Parser.php change in r86072) _

[MediaWiki-CodeReview] [MediaWiki r89895]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89895. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89895 Commit summary: * followup r89860: magic word renamed and internationalized * fixes (magic word registration, loading css and js, return

[MediaWiki-CodeReview] [MediaWiki r86082]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r86082. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86082 Commit summary: bugfix: parser needs to be unstubbed before startExternalParse ___ MediaWik

[MediaWiki-CodeReview] [MediaWiki r84876]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84876. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84876 Commit summary: parser function: directset, standard input: save and continue, one-step form save

[MediaWiki-CodeReview] [MediaWiki r97135]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r97135. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97135 Commit summary: Very early version of selection mechanism that works across paragraphs, lists and tables _

[Wikitech-l] New pattern for introducing wfDeprecated calls into core

2011-09-14 Thread Daniel Friesen
For awhile now we've had this pattern for deprecating interfaces: * Mark it deprecated with @deprecated when you deprecate it * In one or two releases add wfDeprecated * A release or two after that or more remove the interface entirely The rationale of not adding wfDeprecated seams to be so we don

Re: [Wikitech-l] Alternatives to LimeSurvey

2011-09-14 Thread Daniel Mietchen
Hi Erik, I don't know of a better tool than LimeSurvey but I have posted a similar question a while ago, and some of the replies at http://friendfeed.com/danielmietchen/2e2b1da8/looking-for-options-web-based-survey-any may be useful here. Daniel On Thu, Sep 15, 2011 at 2:40 AM, Erik Moeller wr

[Wikitech-l] Alternatives to LimeSurvey

2011-09-14 Thread Erik Moeller
Hi folks, we've been using LimeSurvey for the last couple of years to run Wikimedia surveys, but as we pushed it to its limits, we've surfaced numerous problems, including security vulnerabilities and major concurrency issues. It's got many of the right capabilities and may be fixable, but it wou

[MediaWiki-CodeReview] [MediaWiki r97117]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r97117. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97117 Commit summary: Implementation of drawSelection method in ContentView ___ MediaWiki-CodeRev

[MediaWiki-CodeReview] [MediaWiki r85957]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Happy-melon" posted a comment on MediaWiki.r85957. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85957#c22564 Commit summary: Look mum, no globals! Implement a RequestContext for HTMLForm, passed in the constructor. Currently this is optional with B/C; at a later date it

[MediaWiki-CodeReview] [MediaWiki r75155]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "MarkAHershberger" changed the status of MediaWiki.r75155. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75155 Commit summary: When specifying a foreground color, also specify a background color. __

[MediaWiki-CodeReview] [MediaWiki r97108]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Siebrand" posted a comment on MediaWiki.r97108. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97108#c22563 Commit summary: RL2: Commit some initial code for the foreign gadgets preferences tab. Still needs work. Thinking I might want to do s/shared gadgets/foreign gadgets/

[MediaWiki-CodeReview] [MediaWiki r84876]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "MarkAHershberger" changed the status of MediaWiki.r84876. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84876 Commit summary: parser function: directset, standard input: save and continue, one-step form save _

[MediaWiki-CodeReview] [MediaWiki r86082]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "MarkAHershberger" changed the status of MediaWiki.r86082. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86082 Commit summary: bugfix: parser needs to be unstubbed before startExternalParse ___ M

[MediaWiki-CodeReview] [MediaWiki r52855]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r52855. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/52855#c22562 Commit summary: Added position:relative to #bodyContent to allow absolutes to be relative to it, rather than #content. Also, changed #actions to #p-cactions to be

[MediaWiki-CodeReview] [MediaWiki r89895]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "MarkAHershberger" changed the status of MediaWiki.r89895. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89895 Commit summary: * followup r89860: magic word renamed and internationalized * fixes (magic word registration, loading css and js,

Re: [Wikitech-l] [openZIM dev-l] Phonegap and Wikimedia mobile apps

2011-09-14 Thread Brion Vibber
On Wed, Sep 14, 2011 at 2:33 PM, Tomasz Finc wrote: > CC'ing Herman Wong from Nitobi who's helping develop an Android > version of the Wikimedia iOS app. I'll be sending an email with more > detail on that later this week. > > Herman, Christian is looking to write a plug in to implement a simpler

[MediaWiki-CodeReview] [MediaWiki r97096]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Purodha" posted a comment on MediaWiki.r97096. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97096#c22561 Commit summary: Typo fixed in message text of MediaWiki:logentry-suppress-delete see http://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Logentry-suppress-del

Re: [Wikitech-l] [openZIM dev-l] Phonegap and Wikimedia mobile apps

2011-09-14 Thread Tomasz Finc
CC'ing Herman Wong from Nitobi who's helping develop an Android version of the Wikimedia iOS app. I'll be sending an email with more detail on that later this week. Herman, Christian is looking to write a plug in to implement a simpler reader for the http://openzim.org/ standard. Christian, come

[MediaWiki-CodeReview] [MediaWiki r85957]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r85957. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85957#c22560 Commit summary: Look mum, no globals! Implement a RequestContext for HTMLForm, passed in the constructor. Currently this is optional with B/C; at a later date i

[MediaWiki-CodeReview] [MediaWiki r96958]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r96958. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96958#c22559 Commit summary: * Use local context instead of global variables * Pass the context to the HTMLForm object Comment: Hm, also note that when passing the context th

[MediaWiki-CodeReview] [MediaWiki r96958]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r96958. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96958#c22558 Commit summary: * Use local context instead of global variables * Pass the context to the HTMLForm object Comment: Seems to be a non-required update for an inter

[MediaWiki-CodeReview] [MediaWiki r96658]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r96658. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96658 Commit summary: AjaxLogin: bug #24657 - clarify description message (+bump version number) ___ Me

[MediaWiki-CodeReview] [MediaWiki r97030]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r97030. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97030 Commit summary: Merged Wikia change. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@l

[MediaWiki-CodeReview] [MediaWiki r97048]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r97048. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97048 Commit summary: Revert part of r97046 which was not intented to be committed. As side note, would be nice to have this configurable someway.

[MediaWiki-CodeReview] [MediaWiki r97046]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r97046. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97046 Commit summary: Removed some more unused message made obsolete by r96847 (one was still referenced in r97044, but was already unused)

[MediaWiki-CodeReview] [MediaWiki r97038]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r97038. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97038 Commit summary: Add extension (r96960) to translatewiki.net ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r97100]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r97100. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97100 Commit summary: Localisation updates for core and extension messages from translatewiki.net ___

[MediaWiki-CodeReview] [MediaWiki r80746]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r80746. Old Status: resolved New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80746 Commit summary: * changed 'searchmenu-new-nocreate' to no longer be ignored and have content. Addresses bug 26747. * remove

[MediaWiki-CodeReview] [MediaWiki r80746]: New comment added, and revision status changed

2011-09-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r80746. Old Status: fixme New Status: resolved User "Brion VIBBER" also posted a comment on MediaWiki.r80746. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80746#c22557 Commit summary: * changed 'searchmenu-new-nocreate' to no

[MediaWiki-CodeReview] [MediaWiki r97041]: New comment added, and revision status changed

2011-09-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r97041. Old Status: new New Status: ok User "Aaron Schulz" also posted a comment on MediaWiki.r97041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97041#c22556 Commit summary: There was a double space between log action text

[MediaWiki-CodeReview] [MediaWiki r97096]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Raymond" posted a comment on MediaWiki.r97096. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97096#c22555 Commit summary: Typo fixed in message text of MediaWiki:logentry-suppress-delete see http://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Logentry-suppress-del

[MediaWiki-CodeReview] [MediaWiki r96824]: New comment added, and revision status changed

2011-09-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r96824. Old Status: fixme New Status: reverted User "Brion VIBBER" also posted a comment on MediaWiki.r96824. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96824#c22554 Commit summary: SpecialSearch: add two hooks, one to modi

[MediaWiki-CodeReview] [MediaWiki r97094]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r97094. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97094 Commit summary: Use local context instead of global variables ___ MediaWiki-CodeReview mail

[MediaWiki-CodeReview] [MediaWiki r94465]: New comment added, and revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r94465. Old Status: new New Status: fixme User "^demon" also posted a comment on MediaWiki.r94465. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94465#c22553 Commit summary: Add code to the sanitizer to convert presontational attrib

[MediaWiki-CodeReview] [MediaWiki r96824]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r96824. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96824#c22552 Commit summary: SpecialSearch: add two hooks, one to modify the power search box, one to change the message pointing to the page title searched for WikimediaIncu

[MediaWiki-CodeReview] [MediaWiki r96824]: New comment added, and revision status changed

2011-09-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r96824. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r96824. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96824#c22551 Commit summary: SpecialSearch: add two hooks, one to modify th

[MediaWiki-CodeReview] [MediaWiki r95603]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r95603. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95603 Commit summary: Unused variables. $wgContLang in CategoryPage was probably removed with the better directionality improvements. $wgServer, $w

[MediaWiki-CodeReview] [MediaWiki r94349]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r94349. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94349 Commit summary: Update Interwiki::getURL's first argument so that it's properly urlencoded when replacements are made. Scanning all of

[MediaWiki-CodeReview] [MediaWiki r94353]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r94353. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94353 Commit summary: Followup r94349; Interwiki::getURL used `$title != null` to test if the $title arg was passed and should be substituted

[MediaWiki-CodeReview] [MediaWiki r94460]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r94460. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94460 Commit summary: Followup r94353; Use !== null since that's what we use in core. ___ MediaWiki-Cod

[MediaWiki-CodeReview] [MediaWiki r97085]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r97085. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97085 Commit summary: Moved get location from event to view, since it required knowledge of the rendering state to do it's job - also added s

[MediaWiki-CodeReview] [MediaWiki r97093]: New comment added, and revision status changed

2011-09-14 Thread MediaWiki Mail
User "Jeroen De Dauw" changed the status of MediaWiki.r97093. Old Status: new New Status: ok User "Jeroen De Dauw" also posted a comment on MediaWiki.r97093. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97093#c22550 Commit summary: Add extension (r96920) to translatewiki.net

[MediaWiki-CodeReview] [MediaWiki r97078]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r97078. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97078 Commit summary: Switched from prepending http for protocol-relative $wgUploadStashScalerBaseUrl to wfExpandUrl() Followup to r96934 ___

[MediaWiki-CodeReview] [MediaWiki r80746]: New comment added, and revision status changed

2011-09-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r80746. Old Status: ok New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r80746. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80746#c22549 Commit summary: * changed 'searchmenu-new-nocreate' to no longe

[MediaWiki-CodeReview] [MediaWiki r83562]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r83562. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83562#c22548 Commit summary: 1.17wmf1: Live hack to add backwards compatibility for &from= and &until= to category pages. Should be merged to trunk. Also changes an instance o

[MediaWiki-CodeReview] [MediaWiki r84610]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r84610. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84610#c22547 Commit summary: * Put parser output file version tracking to core * Added some ParserOutput accessors * A few cleanups to fetchFile() Comment: Oh, I thought you

[MediaWiki-CodeReview] [MediaWiki r96772]: New comment added

2011-09-14 Thread MediaWiki Mail
User "COGDEN" posted a comment on MediaWiki.r96772. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96772#c22546 Commit summary: Minor formatting and documentation revisions. Comment: I appreciate your comment. I'll take another look at the documentation. "wc_dissertation" was i

[MediaWiki-CodeReview] [MediaWiki r97081]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Dantman" posted a comment on MediaWiki.r97081. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97081#c22545 Commit summary: Checkpoint; Starting with new PageView system. This is very non-functional now. Development pattern for this project, break everything then make it bet

[MediaWiki-CodeReview] [MediaWiki r96934]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Raindrift" changed the status of MediaWiki.r96934. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96934 Commit summary: If the scaler URL is protocol-relative, things just break here. Sets a sane default.

[MediaWiki-CodeReview] [MediaWiki r96934]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Raindrift" posted a comment on MediaWiki.r96934. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96934#c22544 Commit summary: If the scaler URL is protocol-relative, things just break here. Sets a sane default. Comment: Yeah, these are good points. Fixed in r97078. Than

[MediaWiki-CodeReview] [MediaWiki r97022]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r97022. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97022 Commit summary: Possible fix for issue reported in r83762. I had a hard time confirming the problem/fix with profiling. Committing t

[MediaWiki-CodeReview] [MediaWiki r97026]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Preilly" posted a comment on MediaWiki.r97026. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97026#c22543 Commit summary: fix for wml view pagination links Comment: This should be fixed in r97076. But, note that Title::getLocalUrl doesn't work at this point in the class

[MediaWiki-CodeReview] [MediaWiki r97022]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r97022. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97022#c22542 Commit summary: Possible fix for issue reported in r83762. I had a hard time confirming the problem/fix with profiling. Committing this now to get more attention.

[MediaWiki-CodeReview] [MediaWiki r97060]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Jack Phoenix" changed the status of MediaWiki.r97060. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97060 Commit summary: Whitespace/documentation ___ MediaWiki-CodeReview mailing list mediawiki-co

[MediaWiki-CodeReview] [MediaWiki r97040]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r97040. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97040 Commit summary: Instead of throwing fatals, accept null titles in old log entries. New log entries will still die with fatal few l

[MediaWiki-CodeReview] [MediaWiki r97045]: New comment added, and revision status changed

2011-09-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r97045. Old Status: new New Status: ok User "Aaron Schulz" also posted a comment on MediaWiki.r97045. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97045#c22541 Commit summary: Added a bit defensive programming, as suggested b

[MediaWiki-CodeReview] [MediaWiki r97052]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r97052. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97052#c22540 Commit summary: RL2: Followup to r96954 and r97005: add i18n messages for the validation stuff. The messages aren't very good at this point and may need tweaking, but

[MediaWiki-CodeReview] [MediaWiki r97019]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r97019. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97019 Commit summary: Fixed key-mapping for currency code in rapid html system ___ MediaWi

[MediaWiki-CodeReview] [MediaWiki r97019]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Awjrichards" posted a comment on MediaWiki.r97019. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97019#c22539 Commit summary: Fixed key-mapping for currency code in rapid html system Comment: Huh - this must've been a result of me improperly using git-svn. I must've acc

[MediaWiki-CodeReview] [MediaWiki r88741]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r88741. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88741 Commit summary: Follow-up r88740: forgot to commit this guy ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r89220]: New comment added, and revision status changed

2011-09-14 Thread MediaWiki Mail
User "MarkAHershberger" changed the status of MediaWiki.r89220. Old Status: fixme New Status: new User "MarkAHershberger" also posted a comment on MediaWiki.r89220. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89220#c22538 Commit summary: Remove Cite singleton. Store it inside

[MediaWiki-CodeReview] [MediaWiki r97029]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Yaron Koren" posted a comment on MediaWiki.r97029. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97029#c22537 Commit summary: New extension: code by Ike Hecht (I'm just checking it in) Comment: I should have specified - this extension was created specifically for a client

[MediaWiki-CodeReview] [MediaWiki r97029]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Jack Phoenix" posted a comment on MediaWiki.r97029. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97029#c22536 Commit summary: New extension: code by Ike Hecht (I'm just checking it in) Comment: I think that everyone can see the what, but what people can't see is the why

[MediaWiki-CodeReview] [MediaWiki r97053]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r97053. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97053 Commit summary: pageoutput branch: Experimenting on Renderer/View with canonical and tab definitions, dropping Action for SpecialPages, Skin.

[MediaWiki-CodeReview] [MediaWiki r97054]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r97054. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97054 Commit summary: Initialized merge tracking via "svnmerge" with revisions "1-97051" from svn+ssh://dantman@wikimedia/svnroot/mediawiki/trunk/ph

[MediaWiki-CodeReview] [MediaWiki r97029]: New comment added

2011-09-14 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r97029. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97029#c22535 Commit summary: New extension: code by Ike Hecht (I'm just checking it in) Comment: I assumed as much, which is why I skipped mentioning jquery and wfLoadExtensionMes

[MediaWiki-CodeReview] [MediaWiki r97029]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Yaron Koren" posted a comment on MediaWiki.r97029. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97029#c22534 Commit summary: New extension: code by Ike Hecht (I'm just checking it in) Comment: This one I can answer - the extension aims to be compatible with MW 1.15. Eve

[MediaWiki-CodeReview] [MediaWiki r86304]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r86304. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86304 Commit summary: * (bug 28532) wfMsgExt() and wfMsgWikiHtml() use $wgOut->parse() * (bug 16129) Transcluded special pages expose strip marker

[MediaWiki-CodeReview] [MediaWiki r97057]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r97057. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97057 Commit summary: Revert r96715 per committer's (Chad's) CR comment ___ MediaWiki-CodeReview mailin

[MediaWiki-CodeReview] [MediaWiki r96715]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r96715. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96715 Commit summary: Add a comment about something I noticed while spelunking the code ___ Medi

[MediaWiki-CodeReview] [MediaWiki r97056]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r97056. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97056 Commit summary: RL2: Remove TODO comment that was addressed by r96949 ___ MediaWiki-CodeRevie

[MediaWiki-CodeReview] [MediaWiki r96715]: New comment added

2011-09-14 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r96715. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96715#c22533 Commit summary: Add a comment about something I noticed while spelunking the code Comment: I forgot that t_paamayim_nekudotayim was added in php4, this can be reverted

[MediaWiki-CodeReview] [MediaWiki r97052]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r97052. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97052#c22532 Commit summary: RL2: Followup to r96954 and r97005: add i18n messages for the validation stuff. The messages aren't very good at this point and may need tweaking, b

[MediaWiki-CodeReview] [MediaWiki r97052]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r97052. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97052#c22531 Commit summary: RL2: Followup to r96954 and r97005: add i18n messages for the validation stuff. The messages aren't very good at this point and may need tweaking, b

[MediaWiki-CodeReview] [MediaWiki r97036]: New comment added

2011-09-14 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r97036. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97036#c22530 Commit summary: Partial revert r97035, followup r96930: make recentchanges tests pass again Comment: I meant r94244, copy+pasted the wrong rev :)

[MediaWiki-CodeReview] [MediaWiki r97051]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" changed the status of MediaWiki.r97051. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97051 Commit summary: Don't process empty queries (fix for bug 30892) ___ MediaWiki-CodeReview mail

[MediaWiki-CodeReview] [MediaWiki r97050]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r97050. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97050#c22529 Commit summary: Followup r86304, guard against $title AND $wgTitle being null Add profiling too Comment: /me approves. _

[MediaWiki-CodeReview] [MediaWiki r97005]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r97005. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97005 Commit summary: R2: Adding some comments that helped me understand Gadget::validatePropertiesArray * Explicitly document the first and third

[MediaWiki-CodeReview] [MediaWiki r85922]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r85922. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c22528 Commit summary: Comment: This version of doTableStuff() takes 20 times longer and uses 25 times as much memory as the old code for this test case: "{|\n" . str

[MediaWiki-CodeReview] [MediaWiki r96765]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Catrope" posted a comment on MediaWiki.r96765. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96765#c22527 Commit summary: (bug 30722) Add an identity collation that sorts things based on what the unicode code point is (aka pre-1.17 behaviour). I'm tagging this 1.18 becaus

[MediaWiki-CodeReview] [MediaWiki r96715]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Catrope" posted a comment on MediaWiki.r96715. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96715#c22526 Commit summary: Add a comment about something I noticed while spelunking the code Comment: I don't understand; how does this assignment make the PHP4 check useless? D

[MediaWiki-CodeReview] [MediaWiki r97019]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Catrope" posted a comment on MediaWiki.r97019. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97019#c22525 Commit summary: Fixed key-mapping for currency code in rapid html system Comment: .orig? ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r96640]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r96640. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96640 Commit summary: Remove wgProto from mw.config * Introduced in r82575 spontaneously, but was never used. * It was removed from PHP by Tim in r

[MediaWiki-CodeReview] [MediaWiki r97047]: Revision status changed

2011-09-14 Thread MediaWiki Mail
User "Siebrand" changed the status of MediaWiki.r97047. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97047 Commit summary: Revert r96798 - makes parser go infinite loop somewhere ___ MediaWiki-CodeRevie

[MediaWiki-CodeReview] [MediaWiki r84610]: New comment added

2011-09-14 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r84610. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84610#c22524 Commit summary: * Put parser output file version tracking to core * Added some ParserOutput accessors * A few cleanups to fetchFile() Comment: There's nothing wr

Re: [Wikitech-l] Announcing Wikihadoop: using Hadoop to analyze Wikipedia dump files

2011-09-14 Thread Dirk Riehle
Hello everyone! Wikihadoop sounds like a great project! I wanted to point out that you can make it even more powerful for many research applications by combining it with the Sweble Wikitext parser. Doing so, you could enable Wikipedia dump processing not only on the rough XML dump level, but o

  1   2   >