Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-05-07 Thread Platonides
On 06/05/13 18:12, Guillaume Paumier wrote: Hi, On Sun, Mar 10, 2013 at 2:11 AM, Rob Lanphier ro...@wikimedia.org wrote: Short version: This mail is fishing for feedback on proposed work on Gerrit-Bugzilla integration to replace code review tags. I was wondering: has a decision been made

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-05-06 Thread Guillaume Paumier
Hi, On Sun, Mar 10, 2013 at 2:11 AM, Rob Lanphier ro...@wikimedia.org wrote: Short version: This mail is fishing for feedback on proposed work on Gerrit-Bugzilla integration to replace code review tags. I was wondering: has a decision been made regarding this? I'm resuming work on (notably)

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-15 Thread Christian Aistleitner
Hi Niklas, On Thu, Mar 14, 2013 at 10:54:05AM +0200, Niklas Laxström wrote: On 14 March 2013 01:07, Christian Aistleitner christ...@quelltextlich.at wrote: Queries are just a grep away, and setting them can be done through git as well, until we integrate that into gerrit. Except that you

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-14 Thread Christian Aistleitner
Hi, On Thu, Mar 14, 2013 at 12:27:06AM +0100, Krinkle wrote: Can git notes be changed after merge? Yes. Do they show in Gerrit diffs, so we don't accidentally lose them if someone else pushed an amend without the tags? No. At least not yet :-) Can they be removed after merge? Yes. And

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-14 Thread Niklas Laxström
On 14 March 2013 01:07, Christian Aistleitner christ...@quelltextlich.at wrote: Wouldn't git notes be a good match [1]? They're basically annotations attached to commits. You can add/remove them to any commit without changing the actual commit. And support comes directly with git, as for

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-13 Thread Andre Klapper
On Tue, 2013-03-12 at 20:28 -0700, Rob Lanphier wrote: If the problem is with the rigidity of keywords, one thing I should note is that, in addition to tagging, there's also the whiteboard in Bugzilla, which I believe you can use for free form stuff to query. I believe Andre only enabled that

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-13 Thread Christian Aistleitner
Hi, On Tue, Mar 12, 2013 at 08:28:25PM -0700, Rob Lanphier wrote: The Bugzilla-based solution has some of the advantages of the MediaWiki-based solution. We may be able to implement it more quickly than something native to Gerrit because we're already working on Bugzilla integration, and we

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-13 Thread Krinkle
Can git notes be changed after merge? Do they show in Gerrit diffs, so we don't accidentally lose them if someone else pushed an amend without the tags? Can they be removed after merge? Can one query for commits having a certain tag within a repo/branch/author? (eg. fixme commits by me in mw

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-13 Thread rupert THURNER
On Thu, Mar 14, 2013 at 12:07 AM, Christian Aistleitner christ...@quelltextlich.at wrote: Hi, On Tue, Mar 12, 2013 at 08:28:25PM -0700, Rob Lanphier wrote: The Bugzilla-based solution has some of the advantages of the MediaWiki-based solution. We may be able to implement it more quickly

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-12 Thread Andre Klapper
On Mon, 2013-03-11 at 17:09 +0100, Christian Aistleitner wrote: On Mon, Mar 11, 2013 at 12:43:44AM +0100, Andre Klapper wrote: Are there some thoughts already how to make a match between a project in Gerrit and its related Bugzilla product/component? [Disclaimer: I'm a fan of DOAP metadata

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-12 Thread Chad
On Tue, Mar 12, 2013 at 6:45 AM, Andre Klapper aklap...@wikimedia.org wrote: Wasn't aware of that. Are there projects in Gerrit that don't use bugzilla.wikimedia.org? A lot of MediaWiki extensions, I assume? In that case we're back to the problem that you need a URI value for the bugtracker.

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-12 Thread Guillaume Paumier
Hi, On Sun, Mar 10, 2013 at 2:11 AM, Rob Lanphier ro...@wikimedia.org wrote: Hi folks, Short version: This mail is fishing for feedback on proposed work on Gerrit-Bugzilla integration to replace code review tags. I preferred that if we were going to have our own hacky solution, it should

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-12 Thread Greg Grossmeier
Hello! quote name=Guillaume Paumier date=2013-03-12 time=15:03:04 +0100 Hi, On Sun, Mar 10, 2013 at 2:11 AM, Rob Lanphier ro...@wikimedia.org wrote: Hi folks, Short version: This mail is fishing for feedback on proposed work on Gerrit-Bugzilla integration to replace code review tags.

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-12 Thread K. Peachey
On Wed, Mar 13, 2013 at 2:43 AM, Greg Grossmeier g...@wikimedia.org wrote: 4) A Gerrit-based tagging plugin would need some engineering that might not be apparent at first blush, for example: who can set tags and remove them? Does that vary by tag? How could I, for example, keep track of all

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-12 Thread Platonides
Doing the tags in Gerrit is the right thing. Who can change them is not a problem, just make a changetags log. (BTW, you would have the same problem in bugzilla with people removing that superimportant tag) ___ Wikitech-l mailing list

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-12 Thread Rob Lanphier
Hi Guillaume, Good point. Comments below... On Tue, Mar 12, 2013 at 7:03 AM, Guillaume Paumier gpaum...@wikimedia.org wrote: On Sun, Mar 10, 2013 at 2:11 AM, Rob Lanphier ro...@wikimedia.org wrote: Short version: This mail is fishing for feedback on proposed work on Gerrit-Bugzilla

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-12 Thread Rob Lanphier
On Tue, Mar 12, 2013 at 10:14 AM, K. Peachey p858sn...@gmail.com wrote: On Wed, Mar 13, 2013 at 2:43 AM, Greg Grossmeier g...@wikimedia.org wrote: 4) A Gerrit-based tagging plugin would need some engineering that might not be apparent at first blush, for example: who can set tags and remove

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-11 Thread Christian Aistleitner
Hi Andre, On Mon, Mar 11, 2013 at 12:43:44AM +0100, Andre Klapper wrote: Are there some thoughts already how to make a match between a project in Gerrit and its related Bugzilla product/component? [Disclaimer: I'm a fan of DOAP metadata files, if used properly.] While DOAP looks great, is

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-10 Thread Niklas Laxström
On 10 March 2013 03:11, Rob Lanphier ro...@wikimedia.org wrote: Hi folks, Short version: This mail is fishing for feedback on proposed work on Gerrit-Bugzilla integration to replace code review tags. Interesting idea. I can imagine Bugzilla integration working fine for filing fixmes - not so

Re: [Wikitech-l] Replacement for tagging in Gerrit

2013-03-10 Thread Andre Klapper
On Sat, 2013-03-09 at 17:11 -0800, Rob Lanphier wrote: The solution that Chad and I discussed is an addition to the Bugzilla-Gerrit plugin that Christian is already working on. The idea would be that, for any given revision, there would be a file bug about this revision link. Following that

[Wikitech-l] Replacement for tagging in Gerrit

2013-03-09 Thread Rob Lanphier
Hi folks, Short version: This mail is fishing for feedback on proposed work on Gerrit-Bugzilla integration to replace code review tags. Long version: One feature of our old code review system that was a tagging system that made it quick and easy to assign a keyword to a revision at any time.